Page MenuHomePhabricator
Feed Advanced Search

Yesterday

stellaraccident committed rG1de7a17ff320: [MLIR][python] Disable SONAME on extensions. (authored by stellaraccident).
[MLIR][python] Disable SONAME on extensions.
Thu, Jul 29, 5:47 PM
stellaraccident closed D107113: [MLIR][python] Disable SONAME on extensions..
Thu, Jul 29, 5:47 PM · Restricted Project
stellaraccident added a reviewer for D107113: [MLIR][python] Disable SONAME on extensions.: mikeurbach.
Thu, Jul 29, 3:24 PM · Restricted Project
stellaraccident requested review of D107113: [MLIR][python] Disable SONAME on extensions..
Thu, Jul 29, 3:24 PM · Restricted Project
stellaraccident committed rGcf36ab1d6c39: [MLIR][Python] Use DEST_PREFIX when installing. (authored by stellaraccident).
[MLIR][Python] Use DEST_PREFIX when installing.
Thu, Jul 29, 3:16 PM
stellaraccident closed D107100: [MLIR][Python] Use DEST_PREFIX when installing..
Thu, Jul 29, 3:15 PM · Restricted Project
stellaraccident added a reviewer for D107100: [MLIR][Python] Use DEST_PREFIX when installing.: mikeurbach.
Thu, Jul 29, 1:35 PM · Restricted Project
stellaraccident requested review of D107100: [MLIR][Python] Use DEST_PREFIX when installing..
Thu, Jul 29, 1:34 PM · Restricted Project
stellaraccident committed rG5b2e7f50a679: [MLIR][python] Export CAPI headers. (authored by stellaraccident).
[MLIR][python] Export CAPI headers.
Thu, Jul 29, 12:07 PM
stellaraccident closed D107090: [MLIR][python] Export CAPI headers..
Thu, Jul 29, 12:07 PM · Restricted Project
stellaraccident added a reviewer for D107090: [MLIR][python] Export CAPI headers.: mikeurbach.
Thu, Jul 29, 10:40 AM · Restricted Project
stellaraccident requested review of D107090: [MLIR][python] Export CAPI headers..
Thu, Jul 29, 10:40 AM · Restricted Project

Wed, Jul 28

stellaraccident committed rG768f56264150: Update file names and extensions for MLIR Python execution engine changes. (authored by stellaraccident).
Update file names and extensions for MLIR Python execution engine changes.
Wed, Jul 28, 8:19 PM
stellaraccident committed rG7e2174c2535e: NFC: Add missing import to integration test. (authored by stellaraccident).
NFC: Add missing import to integration test.
Wed, Jul 28, 7:44 PM
stellaraccident committed rG0cdf4915019a: Break apart the MLIR ExecutionEngine from core python module. (authored by stellaraccident).
Break apart the MLIR ExecutionEngine from core python module.
Wed, Jul 28, 5:02 PM
stellaraccident closed D106992: Break apart the MLIR ExecutionEngine from core python module..
Wed, Jul 28, 5:01 PM · Restricted Project
stellaraccident committed rGdad10a9afbc3: NFC: Adapt operation.py to builtin operation print format changes. (authored by stellaraccident).
NFC: Adapt operation.py to builtin operation print format changes.
Wed, Jul 28, 4:58 PM
stellaraccident updated the diff for D106992: Break apart the MLIR ExecutionEngine from core python module..

Update test class name that changed.

Wed, Jul 28, 2:10 PM · Restricted Project
stellaraccident added a comment to D106992: Break apart the MLIR ExecutionEngine from core python module..

fyi - this has some failures. I'll need to triage more. will get to it soon.

Wed, Jul 28, 1:17 PM · Restricted Project
stellaraccident resigned from D106992: Break apart the MLIR ExecutionEngine from core python module..
Wed, Jul 28, 1:02 PM · Restricted Project
stellaraccident accepted D106992: Break apart the MLIR ExecutionEngine from core python module..
Wed, Jul 28, 1:01 PM · Restricted Project
stellaraccident requested review of D106992: Break apart the MLIR ExecutionEngine from core python module..
Wed, Jul 28, 1:01 PM · Restricted Project

Tue, Jul 27

stellaraccident accepted D105903: Emit strong definition for TypeID storage in Op definition (WIP).
Tue, Jul 27, 10:34 PM · Restricted Project
stellaraccident committed rG310c9496d809: Re-engineer MLIR python build support. (authored by stellaraccident).
Re-engineer MLIR python build support.
Tue, Jul 27, 9:03 AM
stellaraccident closed D106520: Re-engineer MLIR python build support..
Tue, Jul 27, 9:03 AM · Restricted Project

Mon, Jul 26

stellaraccident added a comment to D106520: Re-engineer MLIR python build support..

We have pre-patched npcomp (https://github.com/llvm/mlir-npcomp/pull/251) and the iree-llvm-sandbox (https://github.com/google/iree-llvm-sandbox) successfully based on this patch. Mike says that he has a pending patch for CIRCT. So I think this is ready to land. I'll plan to do so tomorrow.

Mon, Jul 26, 10:22 PM · Restricted Project
stellaraccident updated the diff for D106520: Re-engineer MLIR python build support..

Add sources custom target to ALL.

Mon, Jul 26, 10:14 PM · Restricted Project
stellaraccident added inline comments to D105903: Emit strong definition for TypeID storage in Op definition (WIP).
Mon, Jul 26, 9:01 AM · Restricted Project

Thu, Jul 22

stellaraccident accepted D106610: [mlir][tosa] Disable tosa shape verification between operands/results.

Makes sense. Thanks!

Thu, Jul 22, 10:19 PM · Restricted Project
stellaraccident accepted D106617: [mlir][tosa] Make tosa MakeBroadcastable pass handle unreanked tensors..
Thu, Jul 22, 5:34 PM · Restricted Project
stellaraccident updated the diff for D106520: Re-engineer MLIR python build support..

A couple of minor fixes found while integrating a third party project.

Thu, Jul 22, 3:59 PM · Restricted Project
stellaraccident added a comment to D106520: Re-engineer MLIR python build support..

I've reviewed, and I think I'm understanding what's going on. I don't think I have enough CMake chops to provide serious suggestions/alternatives on the approach, so I'm just going to try it out with CIRCT and see how it goes. Assuming it works and we don't have to work around TypeID issues and whatnot, I'm satisfied!

Thu, Jul 22, 3:47 PM · Restricted Project

Wed, Jul 21

stellaraccident added a comment to D106520: Re-engineer MLIR python build support..

if not installing into python/ anymore, can you document where things will get installed? I didn't quite parse it out of the code.

Wed, Jul 21, 10:54 PM · Restricted Project
stellaraccident updated the diff for D106520: Re-engineer MLIR python build support..

Update docs.

Wed, Jul 21, 10:52 PM · Restricted Project
stellaraccident added a reviewer for D106520: Re-engineer MLIR python build support.: jdd.
Wed, Jul 21, 9:44 PM · Restricted Project
stellaraccident added reviewers for D106520: Re-engineer MLIR python build support.: mikeurbach, ftynse, mehdi_amini.
Wed, Jul 21, 9:44 PM · Restricted Project
stellaraccident requested review of D106520: Re-engineer MLIR python build support..
Wed, Jul 21, 9:43 PM · Restricted Project
stellaraccident added a reviewer for D106419: Generalize a facility in MLIR CMake for producing aggregate shared and static libraries.: mehdi_amini.
Wed, Jul 21, 9:47 AM · Restricted Project

Tue, Jul 20

stellaraccident updated the diff for D106419: Generalize a facility in MLIR CMake for producing aggregate shared and static libraries..

Rebase

Tue, Jul 20, 9:56 PM · Restricted Project
stellaraccident added a reviewer for D106419: Generalize a facility in MLIR CMake for producing aggregate shared and static libraries.: stephenneuendorffer.
Tue, Jul 20, 9:54 PM · Restricted Project
stellaraccident requested review of D106419: Generalize a facility in MLIR CMake for producing aggregate shared and static libraries..
Tue, Jul 20, 9:53 PM · Restricted Project
stellaraccident committed rG2607209b3fff: Remove libMLIRPublicAPI DSO. (authored by stellaraccident).
Remove libMLIRPublicAPI DSO.
Tue, Jul 20, 5:59 PM
stellaraccident closed D106369: Remove libMLIRPublicAPI DSO..
Tue, Jul 20, 5:59 PM · Restricted Project
stellaraccident updated the diff for D106369: Remove libMLIRPublicAPI DSO..

Fix python API on windows (some pre-existing test failures but generally works).

Tue, Jul 20, 4:15 PM · Restricted Project
stellaraccident updated the diff for D106369: Remove libMLIRPublicAPI DSO..

Fix windows visibility (verified locally).

Tue, Jul 20, 4:02 PM · Restricted Project
stellaraccident accepted D105063: [mlir][tosa] Add quantized lowering for matmul and fully_connected.

Nice - thanks.

Tue, Jul 20, 12:10 PM · Restricted Project
stellaraccident added a comment to D106369: Remove libMLIRPublicAPI DSO..

Thanks for the review and conversation, Mehdi. Summarizing:

Tue, Jul 20, 11:27 AM · Restricted Project
stellaraccident updated the diff for D106369: Remove libMLIRPublicAPI DSO..

Remove global property of CAPI libs.

Tue, Jul 20, 11:24 AM · Restricted Project
stellaraccident updated the diff for D106369: Remove libMLIRPublicAPI DSO..

Fix windows build better.

Tue, Jul 20, 11:23 AM · Restricted Project
stellaraccident added a comment to D106369: Remove libMLIRPublicAPI DSO..

I'm not sure I understand the problem you're trying to fix here: having a single DSO exporting all of the C API seems valuable to me.

And I didn't quite get the problem with C unit-test linking to it? Is it because the C unit-test would embed another copy of libSupport from libMLIRPublicApi.so ?

Tue, Jul 20, 10:23 AM · Restricted Project
stellaraccident updated the diff for D106369: Remove libMLIRPublicAPI DSO..

Fix Windows build.

Tue, Jul 20, 9:27 AM · Restricted Project
stellaraccident added reviewers for D106369: Remove libMLIRPublicAPI DSO.: mehdi_amini, jdd, GeorgeLyon, mikeurbach, ftynse, silvas.
Tue, Jul 20, 8:23 AM · Restricted Project
stellaraccident requested review of D106369: Remove libMLIRPublicAPI DSO..
Tue, Jul 20, 8:22 AM · Restricted Project
stellaraccident added a comment to D106169: [MLIR][CAPI] On MINGW don't link against libMLIR.

I don't quite get why this is the right fix, instead of pruning _DEPS to not add all the static archives instead?
Isn't the intent to dynamically link mostly to libMLIR.so ?

Tue, Jul 20, 7:03 AM · Restricted Project
stellaraccident committed rG3d25fa21d0c7: Exclude pybind11 2.7.0 from MLIR python requirements. (authored by stellaraccident).
Exclude pybind11 2.7.0 from MLIR python requirements.
Tue, Jul 20, 6:57 AM

Fri, Jul 16

stellaraccident accepted D106169: [MLIR][CAPI] On MINGW don't link against libMLIR.
Fri, Jul 16, 11:22 AM · Restricted Project

Fri, Jul 2

stellaraccident accepted D105345: [mlir][linalg][python] Add min operation in OpDSL..
Fri, Jul 2, 8:59 AM · Restricted Project

Thu, Jul 1

stellaraccident accepted D105302: Update MLIRContext to allow injecting an external ThreadPool (NFC).
Thu, Jul 1, 1:23 PM · Restricted Project
stellaraccident accepted D105203: [mlir][linalg][python] Add max operation in OpDSL.

Very nice - good to see this all coming together!

Thu, Jul 1, 1:14 PM · Restricted Project
stellaraccident accepted D105272: [CMake][MLIR][Linalg] Adding variable to specify tablegen file dependencies..
Thu, Jul 1, 9:05 AM · Restricted Project, Restricted Project

Wed, Jun 30

stellaraccident accepted D105188: [mlir][linalg][python] Update integration of OpDSL doc (NFC)..

Thanks - we should extend this doc with more detail at some point.

Wed, Jun 30, 7:20 AM · Restricted Project

Jun 29 2021

stellaraccident committed rG485cc55edfb8: [mlir] Generare .cpp.inc files for dialects. (authored by stellaraccident).
[mlir] Generare .cpp.inc files for dialects.
Jun 29 2021, 1:13 PM
stellaraccident closed D105070: [mlir] Generare .cpp.inc files for dialects..
Jun 29 2021, 1:12 PM · Restricted Project
stellaraccident updated the diff for D105070: [mlir] Generare .cpp.inc files for dialects..

Rename hasExplicitDestructor to hasNonDefaultDestructor (on a second read, this seemed like an improvement to me).

Jun 29 2021, 1:09 PM · Restricted Project
stellaraccident accepted D105117: [mlir][linalg][python] Explicit shape and dimension order in OpDSL..

Quite nice: I didn't know if this was going to work out so easily.

Jun 29 2021, 8:47 AM · Restricted Project
stellaraccident accepted D105123: [mlir][linalg][python] Update the OpDSL doc (NFC)..

Thank you. Also, i just noticed that this file was not put in a great place: can it be moved to the linalg directory?

Jun 29 2021, 8:31 AM · Restricted Project

Jun 28 2021

stellaraccident updated the summary of D105070: [mlir] Generare .cpp.inc files for dialects..
Jun 28 2021, 8:08 PM · Restricted Project
stellaraccident updated the diff for D105070: [mlir] Generare .cpp.inc files for dialects..

Update bazel build files.

Jun 28 2021, 8:07 PM · Restricted Project
stellaraccident updated the diff for D105070: [mlir] Generare .cpp.inc files for dialects..

Fix samples.

Jun 28 2021, 8:05 PM · Restricted Project
stellaraccident updated the diff for D105070: [mlir] Generare .cpp.inc files for dialects..

Patch all dialects

Jun 28 2021, 7:43 PM · Restricted Project
stellaraccident updated the diff for D105070: [mlir] Generare .cpp.inc files for dialects..

Comments

Jun 28 2021, 7:22 PM · Restricted Project
stellaraccident updated the summary of D105070: [mlir] Generare .cpp.inc files for dialects..
Jun 28 2021, 5:49 PM · Restricted Project
stellaraccident added inline comments to D105070: [mlir] Generare .cpp.inc files for dialects..
Jun 28 2021, 5:48 PM · Restricted Project
stellaraccident added a reviewer for D105070: [mlir] Generare .cpp.inc files for dialects.: lattner.
Jun 28 2021, 4:59 PM · Restricted Project
stellaraccident requested review of D105070: [mlir] Generare .cpp.inc files for dialects..
Jun 28 2021, 4:58 PM · Restricted Project

Jun 27 2021

stellaraccident added a reviewer for D105000: [mlir] Change translation API to allow custom top-level operations.: rriddle.
Jun 27 2021, 6:01 PM · Restricted Project
stellaraccident requested review of D105000: [mlir] Change translation API to allow custom top-level operations..
Jun 27 2021, 6:00 PM · Restricted Project

Jun 24 2021

stellaraccident added inline comments to D104632: [mlir] Add Cpp emitter.
Jun 24 2021, 10:03 PM · Restricted Project

Jun 21 2021

stellaraccident added a comment to D104207: [Verifier] Parallelize verification and dom checking. NFC..

The problem with pulling this into an MLIRContext is that parallelism isn't specific to MLIR. It is specific to the machine that is being run on. It's not like MLIR gets some cpus and (LLVM or higher-level SW) gets others.

-Chris

Jun 21 2021, 10:57 AM · Restricted Project
stellaraccident added a comment to D104207: [Verifier] Parallelize verification and dom checking. NFC..

Have you tried shoving the global executor into a ManagedStatic?

Jun 21 2021, 8:53 AM · Restricted Project

Jun 20 2021

stellaraccident added a comment to D104207: [Verifier] Parallelize verification and dom checking. NFC..

Ok, well I'm still not clear what is going on here - if the static dtor for the thread pool is running while there is still MLIR stuff going on then there is going to be all sorts of bad things that come unraveled. However, I'm totally ok with River's patch to add threadpool to MLIRContext.

Jun 20 2021, 4:53 PM · Restricted Project

Jun 18 2021

stellaraccident committed rG4b9d28bd530f: Partial rollback: Disable MLIR verifier parallelism. (authored by stellaraccident).
Partial rollback: Disable MLIR verifier parallelism.
Jun 18 2021, 2:58 PM
stellaraccident closed D104570: Partial rollback: Disable MLIR verifier parallelism..
Jun 18 2021, 2:58 PM · Restricted Project
stellaraccident added a reviewer for D104570: Partial rollback: Disable MLIR verifier parallelism.: lattner.
Jun 18 2021, 2:44 PM · Restricted Project
stellaraccident requested review of D104570: Partial rollback: Disable MLIR verifier parallelism..
Jun 18 2021, 2:44 PM · Restricted Project

Jun 17 2021

stellaraccident added a comment to D104207: [Verifier] Parallelize verification and dom checking. NFC..

I've got some pretty strong evidence that this is indeed deadlocking during verification processing, but I can't quite explain why.

Jun 17 2021, 11:51 PM · Restricted Project
stellaraccident added a comment to D104207: [Verifier] Parallelize verification and dom checking. NFC..

This is just using llvm::parallelForEachN (not doing anything particularly fancy) so I can't imagine how it would be different than other similar things using it. It is possible this is exposing a lower level problem in LLVM threading.

In any case, let me know how I can help. I'd prefer not to revert this though, as it is a significant speedup.

Jun 17 2021, 7:32 PM · Restricted Project

Jun 16 2021

stellaraccident accepted D104321: [mlir] Move `memref.dim` canonicalization using `InferShapedTypeOpInterface` to a separate pass..

Thanks. Rename lgtm

Jun 16 2021, 11:53 AM · Restricted Project

Jun 15 2021

stellaraccident accepted D104321: [mlir] Move `memref.dim` canonicalization using `InferShapedTypeOpInterface` to a separate pass..

Thanks for cleaning this up. I'm marking approve because I could be convinced about the naming but don't love it how it is spelled in this patch. Open to other opinions.

Jun 15 2021, 6:30 PM · Restricted Project
stellaraccident added inline comments to D104224: [mlir][linalg] Adapt yaml codegen to support scalar parameters..
Jun 15 2021, 5:20 AM · Restricted Project

Jun 14 2021

stellaraccident accepted D104224: [mlir][linalg] Adapt yaml codegen to support scalar parameters..

Some nits and notes for the future. I like that this enables scalars and is much simpler than where the capture work was headed.

Jun 14 2021, 9:53 PM · Restricted Project
stellaraccident accepted D104220: [mlir][linalg][python] Adapt the OpDSL to use scalars..

This is good - thanks. I'm glad we were able to back away from the more complicated capture semantics and just directly represent scalars.

Jun 14 2021, 9:44 PM · Restricted Project
stellaraccident accepted D103853: [MLIR] [Python] Add `owner` to PyValue and fix its parent reference.

Thanks - this looks right to me.

Jun 14 2021, 9:37 PM · Restricted Project

Jun 11 2021

stellaraccident added inline comments to D104009: [MLIR] Execution engine python binding support for shared libraries.
Jun 11 2021, 12:36 AM · Restricted Project
stellaraccident added a comment to D104009: [MLIR] Execution engine python binding support for shared libraries.

I would have wrote: ..., int numPaths, const MlirStringRef *libPaths).

This is the kind of API that I expect the user to map to an ArrayRef on the other side: the C API is unsafe (by nature somehow...) but the chance for error should be almost none because this is only a "binding" API and safe constructs can be used to wrap around this.

Makes sense to me - this makes it cleaner at the call site both for C and Python. It's just a downside that you'd have a bad crash if there is a consistency b/w the count and the number of elements in the ref. The comma separated string avoids that by design and you never get an opaque crash in the C API. Note that the C API user won't typically have an ArrayRef or a higher level structure to map that to the C API. They are using C right? :-)

Jun 11 2021, 12:33 AM · Restricted Project

Jun 10 2021

stellaraccident added a comment to D104009: [MLIR] Execution engine python binding support for shared libraries.

All else being equal, it is better to not be in the business of textually manipulating file paths with ad hoc separators. While a bit more typing, would you be open to changing the c API to take a size and pointer to an array of string views? Then on the python side, accept a list of strings.

Jun 10 2021, 12:12 AM · Restricted Project

Jun 4 2021

stellaraccident added inline comments to D103669: Avoid assertion failure on printing scf.for in debug dump..
Jun 4 2021, 7:08 PM · Restricted Project
stellaraccident added a comment to D103724: Revert "Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns".

Can we please have an explanation/rationale for reverts? Given the short time window, I'm left to assume something was done in error.

Jun 4 2021, 4:31 PM · Restricted Project
stellaraccident added inline comments to D103669: Avoid assertion failure on printing scf.for in debug dump..
Jun 4 2021, 9:03 AM · Restricted Project

Jun 3 2021

stellaraccident added a reviewer for D103669: Avoid assertion failure on printing scf.for in debug dump.: rriddle.
Jun 3 2021, 10:35 PM · Restricted Project