Page MenuHomePhabricator
Feed Advanced Search

Yesterday

tstellar created D67772: Update git-llvm script to push to GitHub.
Thu, Sep 19, 12:25 PM · Restricted Project

Wed, Sep 18

tstellar committed rG9f4c7571a1fe: AMDGPU/SILoadStoreOptimizer: Add const to more functions (authored by tstellar).
AMDGPU/SILoadStoreOptimizer: Add const to more functions
Wed, Sep 18, 9:39 PM
tstellar committed rL372298: AMDGPU/SILoadStoreOptimizer: Add const to more functions.
AMDGPU/SILoadStoreOptimizer: Add const to more functions
Wed, Sep 18, 9:38 PM
tstellar closed D65901: AMDGPU/SILoadStoreOptimizer: Add const to more functions.
Wed, Sep 18, 9:38 PM · Restricted Project
tstellar requested review of D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo.

Ping.

Wed, Sep 18, 9:04 PM · Restricted Project

Fri, Sep 13

tstellar added inline comments to D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Fri, Sep 13, 5:43 PM · Restricted Project

Thu, Sep 12

tstellar accepted D67484: test-release.sh: Don't use chrpath on Solaris.

LGTM. I think CMake removes the build RPATH when installing, but we'd have to confirm that before removing this code.

Thu, Sep 12, 6:26 AM · Restricted Project

Tue, Sep 10

tstellar accepted D66389: AMDGPU/GlobalISel: Legalize constant 32-bit loads.

LGTM.

Tue, Sep 10, 8:11 AM

Mon, Sep 9

tstellar added reviewers for D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test: smeenai, phosek.
Mon, Sep 9, 7:01 AM · Restricted Project
tstellar added inline comments to D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test.
Mon, Sep 9, 7:00 AM · Restricted Project

Wed, Aug 28

tstellar committed rG5be949e3d007: [LLVM-C] Fix omission of INSTALL_WITH_TOOLCHAIN to llvm_add_library() (authored by tstellar).
[LLVM-C] Fix omission of INSTALL_WITH_TOOLCHAIN to llvm_add_library()
Wed, Aug 28, 4:02 PM
tstellar committed rL370271: [LLVM-C] Fix omission of INSTALL_WITH_TOOLCHAIN to llvm_add_library().
[LLVM-C] Fix omission of INSTALL_WITH_TOOLCHAIN to llvm_add_library()
Wed, Aug 28, 4:02 PM
tstellar accepted D66906: [LLVM-C] Fix omission of INSTALL_WITH_TOOLCHAIN to.

LGTM.

Wed, Aug 28, 3:03 PM

Tue, Aug 27

tstellar created D66840: docs/DeveloperPolicy: Add instructions for requesting GitHub commit access.
Tue, Aug 27, 3:57 PM · Restricted Project

Mon, Aug 26

tstellar committed rL370009: Add meta directory to store svn/github username mappings.
Add meta directory to store svn/github username mappings
Mon, Aug 26, 9:24 PM

Aug 20 2019

tstellar added a comment to D64817: [CMake] Fix LLVM build non-determinism on RHEL.

Which version of RHEL is this patch meant for? Since the jump to C++14, on RHEL <= 7, you will need to compile llvm with the devtoolset toolchain, which has a newer version of binutils. This fix is probably only needed on the release/9.x branch (which can still be built by the system toolchain on RHEL7) and not trunk.

It is possible to build with Clang and libc++ and not use a newer version of binutils for trunk.

Aug 20 2019, 4:10 PM · Restricted Project
tstellar added a comment to D64817: [CMake] Fix LLVM build non-determinism on RHEL.

Which version of RHEL is this patch meant for? Since the jump to C++14, on RHEL <= 7, you will need to compile llvm with the devtoolset toolchain, which has a newer version of binutils. This fix is probably only needed on the release/9.x branch (which can still be built by the system toolchain on RHEL7) and not trunk.

Aug 20 2019, 2:23 PM · Restricted Project
tstellar updated subscribers of D64817: [CMake] Fix LLVM build non-determinism on RHEL.
Aug 20 2019, 9:48 AM · Restricted Project

Aug 19 2019

tstellar accepted D66400: AMDGPU: Remove code address space predicates.

LGTM.

Aug 19 2019, 10:28 PM

Aug 13 2019

tstellar updated the diff for D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'.

Another attempt to fix this that depends less on the build directory.

Aug 13 2019, 4:05 PM · Restricted Project
tstellar created D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'.
Aug 13 2019, 3:17 PM · Restricted Project

Aug 8 2019

tstellar added a child revision for D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions: D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets.
Aug 8 2019, 12:55 PM · Restricted Project
tstellar added a parent revision for D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets: D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Aug 8 2019, 12:55 PM · Restricted Project
tstellar created D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets.
Aug 8 2019, 12:50 PM · Restricted Project
tstellar added parent revisions for D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions: D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo, D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics, D65901: AMDGPU/SILoadStoreOptimizer: Add const to more functions.
Aug 8 2019, 12:36 PM · Restricted Project
tstellar added a child revision for D65901: AMDGPU/SILoadStoreOptimizer: Add const to more functions: D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Aug 8 2019, 12:36 PM · Restricted Project
tstellar added a child revision for D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics: D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Aug 8 2019, 12:36 PM · Restricted Project
tstellar added a child revision for D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo: D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Aug 8 2019, 12:36 PM · Restricted Project
tstellar committed rG87e2c9147e6d: lit: Bump version to 0.10.0 (authored by tstellar).
lit: Bump version to 0.10.0
Aug 8 2019, 12:23 PM
tstellar committed rL368329: lit: Bump version to 0.10.0.
lit: Bump version to 0.10.0
Aug 8 2019, 12:22 PM
tstellar closed D65763: lit: Bump version to 0.10.0.
Aug 8 2019, 12:22 PM · Restricted Project
tstellar added a comment to D65763: lit: Bump version to 0.10.0.

We also need to bump the version in the release/9.x branch to 0.9.0.

Done in r367992, and I've made a note for myself to include it in the major version bump next time.

What made you notice this, i.e. where does this version number matter?

Aug 8 2019, 11:55 AM · Restricted Project
tstellar created D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Aug 8 2019, 10:39 AM · Restricted Project
tstellar committed rGe77eb50f6d66: lit: Use a License classifier that pypi will accept (authored by tstellar).
lit: Use a License classifier that pypi will accept
Aug 8 2019, 10:25 AM
tstellar committed rL368315: lit: Use a License classifier that pypi will accept.
lit: Use a License classifier that pypi will accept
Aug 8 2019, 10:25 AM
tstellar closed D65762: lit: Use a License classifier that pypi will accept.
Aug 8 2019, 10:25 AM · Restricted Project

Aug 7 2019

tstellar updated the diff for D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo.

Make helper function members of CombineInfo class.

Aug 7 2019, 2:59 PM · Restricted Project
tstellar created D65901: AMDGPU/SILoadStoreOptimizer: Add const to more functions.
Aug 7 2019, 1:30 PM · Restricted Project
tstellar updated the diff for D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.

Address review comments.

Aug 7 2019, 10:26 AM · Restricted Project
tstellar updated the diff for D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.

Update offsets for the raw and struct intrinsic variants.

Aug 7 2019, 10:15 AM · Restricted Project
tstellar updated the diff for D65762: lit: Use a License classifier that pypi will accept.

Add missing comma.

Aug 7 2019, 8:49 AM · Restricted Project
tstellar updated the summary of D65762: lit: Use a License classifier that pypi will accept.
Aug 7 2019, 8:45 AM · Restricted Project
tstellar added a reviewer for D65762: lit: Use a License classifier that pypi will accept: joerg.
Aug 7 2019, 8:40 AM · Restricted Project
tstellar updated the diff for D65762: lit: Use a License classifier that pypi will accept.

Change license classifier to: OSI Approved :: Apache Software License
as suggested by Joerg on IRC.

Aug 7 2019, 8:40 AM · Restricted Project

Aug 6 2019

tstellar committed rL368047: Add 8.0.1 clang-tools-extra docs.
Add 8.0.1 clang-tools-extra docs
Aug 6 2019, 7:50 AM
tstellar committed rL368046: Add 8.0.1 libcxx docs.
Add 8.0.1 libcxx docs
Aug 6 2019, 7:47 AM
tstellar committed rL368045: Add 8.0.1 lld docs.
Add 8.0.1 lld docs
Aug 6 2019, 7:46 AM
tstellar committed rL368040: Update latest release to 8.0.1.
Update latest release to 8.0.1
Aug 6 2019, 7:13 AM
tstellar committed rL368039: Add 8.0.1 clang docs.
Add 8.0.1 clang docs
Aug 6 2019, 7:10 AM
tstellar committed rL368037: Add 8.0.1 LLVM docs.
Add 8.0.1 LLVM docs
Aug 6 2019, 6:50 AM

Aug 5 2019

tstellar added a comment to D65763: lit: Bump version to 0.10.0.

We also need to bump the version in the release/9.x branch to 0.9.0.

Aug 5 2019, 11:34 AM · Restricted Project
tstellar created D65763: lit: Bump version to 0.10.0.
Aug 5 2019, 11:34 AM · Restricted Project
tstellar updated the diff for D65762: lit: Use a License classifier that pypi will accept.

Remove accidental version bump.

Aug 5 2019, 11:31 AM · Restricted Project
tstellar created D65762: lit: Use a License classifier that pypi will accept.
Aug 5 2019, 11:29 AM · Restricted Project
tstellar committed rGe15d95a987d5: AMDGPU/LoadStoreOptimizer: Set the correct offset whem merging MMOs (authored by tstellar).
AMDGPU/LoadStoreOptimizer: Set the correct offset whem merging MMOs
Aug 5 2019, 9:11 AM
tstellar committed rL367881: AMDGPU/LoadStoreOptimizer: Set the correct offset whem merging MMOs.
AMDGPU/LoadStoreOptimizer: Set the correct offset whem merging MMOs
Aug 5 2019, 9:08 AM
tstellar closed D65557: AMDGPU/LoadStoreOptimizer: Set the correct offset whem merging MMOs.
Aug 5 2019, 9:08 AM · Restricted Project

Aug 1 2019

tstellar committed rL367621: Add links to 8.0.1 binaries.
Add links to 8.0.1 binaries
Aug 1 2019, 2:56 PM
tstellar added inline comments to D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo.
Aug 1 2019, 9:07 AM · Restricted Project

Jul 31 2019

tstellar committed rG7a2958bc20bc: AMDGPU/SILoadStoreOptimizer: Make some functions const (authored by tstellar).
AMDGPU/SILoadStoreOptimizer: Make some functions const
Jul 31 2019, 10:40 PM
tstellar committed rL367517: AMDGPU/SILoadStoreOptimizer: Make some functions const.
AMDGPU/SILoadStoreOptimizer: Make some functions const
Jul 31 2019, 10:40 PM
tstellar closed D65316: AMDGPU/SILoadStoreOptimizer: Make some functions const.
Jul 31 2019, 10:40 PM · Restricted Project
tstellar created D65557: AMDGPU/LoadStoreOptimizer: Set the correct offset whem merging MMOs.
Jul 31 2019, 10:17 PM · Restricted Project
tstellar updated the diff for D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.

Add support for the raw and struct intrinsics.

Jul 31 2019, 9:21 PM · Restricted Project

Jul 30 2019

tstellar created D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo.
Jul 30 2019, 8:46 PM · Restricted Project

Jul 29 2019

tstellar committed rGcc0bc941d4eb: AMDGPU/LoadStoreOptimizer: combine MMOs when merging instructions (authored by tstellar).
AMDGPU/LoadStoreOptimizer: combine MMOs when merging instructions
Jul 29 2019, 9:43 AM
tstellar committed rL367237: AMDGPU/LoadStoreOptimizer: combine MMOs when merging instructions.
AMDGPU/LoadStoreOptimizer: combine MMOs when merging instructions
Jul 29 2019, 9:42 AM
tstellar closed D65036: AMDGPU/LoadStoreOptimizer: combine MMOs when merging instructions.
Jul 29 2019, 9:42 AM · Restricted Project

Jul 25 2019

tstellar abandoned D65288: AMDGPU: Disable the load and store cluster mutations for the schedulers.

Ok, thanks for the info. I will drop this patch.

Jul 25 2019, 8:41 PM · Restricted Project
tstellar created D65316: AMDGPU/SILoadStoreOptimizer: Make some functions const.
Jul 25 2019, 8:20 PM · Restricted Project
tstellar accepted D65002: AMDGPU/GlobalISel: Handle most function return types.

LGTM.

Jul 25 2019, 2:17 PM
tstellar created D65288: AMDGPU: Disable the load and store cluster mutations for the schedulers.
Jul 25 2019, 9:13 AM · Restricted Project

Jul 24 2019

tstellar committed rGf181dd99cf1c: github-upload-release.py: Fix script name in examples (authored by tstellar).
github-upload-release.py: Fix script name in examples
Jul 24 2019, 6:54 PM
tstellar committed rL366978: github-upload-release.py: Fix script name in examples.
github-upload-release.py: Fix script name in examples
Jul 24 2019, 6:50 PM
tstellar committed rG925ccdbfd758: Add github-release.py script (authored by tstellar).
Add github-release.py script
Jul 24 2019, 6:45 PM
tstellar committed rL366977: Add github-release.py script.
Add github-release.py script
Jul 24 2019, 6:44 PM
tstellar closed D64841: Add github-release.py script.
Jul 24 2019, 6:44 PM · Restricted Project
tstellar added inline comments to D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.
Jul 24 2019, 4:15 PM · Restricted Project

Jul 23 2019

tstellar committed rL366812: Add 8.0.1 to the release page.
Add 8.0.1 to the release page
Jul 23 2019, 7:32 AM

Jul 22 2019

tstellar updated the diff for D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.

Rename test.

Jul 22 2019, 11:03 AM · Restricted Project
tstellar added a comment to D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.

We could do the same for the raw and struct variants of the intrinsics, but I wasn't sure exactly what conditions had to be met in order to guarantee that we had a constant offset.

Jul 22 2019, 9:23 AM · Restricted Project
tstellar created D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.
Jul 22 2019, 9:23 AM · Restricted Project
tstellar accepted D65084: AMDGPU/GlobalISel: Remove manual store select code.

Ok, this seems fine. Those types aren't really use much.

Jul 22 2019, 7:46 AM
tstellar accepted D65091: AMDGPU/GlobalISel: Select simple local stores.

LGTM.

Jul 22 2019, 7:22 AM
tstellar accepted D65090: AMDGPU/GlobalISel: Select local loads.

LGTM.

Jul 22 2019, 7:18 AM
tstellar accepted D65085: AMDGPU/GlobalISel: Fix flat load/store of pointer types.

LGTM.

Jul 22 2019, 7:17 AM
tstellar accepted D65086: AMDGPU/GlobalISel: RegBankSelect struct buffer load/store.

LGTM.

Jul 22 2019, 7:17 AM
tstellar added a comment to D65084: AMDGPU/GlobalISel: Remove manual store select code.

Which types are regressed?

Jul 22 2019, 7:17 AM
tstellar accepted D65083: AMDGPU/GlobalISel: Select local atomic cmpxchg.

LGTM.

Jul 22 2019, 7:17 AM
tstellar accepted D65082: AMDGPU/GlobalISel: Allow selection of DS atomicrmw.

LGTM.

Jul 22 2019, 7:14 AM

Jul 19 2019

tstellar created D65036: AMDGPU/LoadStoreOptimizer: combine MMOs when merging instructions.
Jul 19 2019, 10:11 PM · Restricted Project
tstellar committed rL366604: Add links to 8.0.1 sources.
Add links to 8.0.1 sources
Jul 19 2019, 12:27 PM
tstellar committed rL366583: Add 7.1.0 release to index.html.
Add 7.1.0 release to index.html
Jul 19 2019, 7:26 AM

Jul 17 2019

tstellar added a comment to D64894: [CMake] Don't set Python_ADDITIONAL_VERSIONS.

I'm in favor of this, but we should make sure there is documentation telling users how to explicitly choose the python version they want. I'm also curious, how does cmake determine which version to use if more than on interpreter is found?

Jul 17 2019, 3:54 PM · Restricted Project, Restricted Project
tstellar added a comment to D64841: Add github-release.py script.

My initial thought when I saw the filename was that this was a github version of test-release.sh. Which we'll need too, but it's not this one :-) What do you think about renaming to github-upload-release.py, or something else that has "upload" in the name to make it more explicit?

This is super cool! I just looked at https://github.com/llvm/llvm-project/releases

Should we be using this to host binaries from now on, and link to them from http://releases.llvm.org/ (ah, I see you did this for 7.1.0 already; I guess I'm not keeping up).

Jul 17 2019, 2:31 PM · Restricted Project
tstellar updated the diff for D64841: Add github-release.py script.

Rename script and add documentation for how to obtain a github token.

Jul 17 2019, 2:26 PM · Restricted Project
tstellar abandoned D64567: AMDGPU/GISel: Add support for vector shader inputs.
Jul 17 2019, 1:56 PM · Restricted Project
tstellar accepted D64877: AMDGPU/GlobalISel: Attempt to RegBankSelect image intrinsics.

LGTM.

Jul 17 2019, 1:56 PM

Jul 16 2019

tstellar created D64841: Add github-release.py script.
Jul 16 2019, 5:11 PM · Restricted Project

Jul 15 2019

tstellar committed rG4422cc4f1a91: [OpenCL] Make TableGen'd builtin tables and helper functions static (authored by tstellar).
[OpenCL] Make TableGen'd builtin tables and helper functions static
Jul 15 2019, 3:35 PM