Page MenuHomePhabricator
Feed Advanced Search

Mar 1 2019

vlad.tsyrklevich committed rCRT355251: Revert "Revert "[sanitizers] Don't use Windows Trace Logging on MinGW"".
Revert "Revert "[sanitizers] Don't use Windows Trace Logging on MinGW""
Mar 1 2019, 4:46 PM
vlad.tsyrklevich committed rL355251: Revert "Revert "[sanitizers] Don't use Windows Trace Logging on MinGW"".
Revert "Revert "[sanitizers] Don't use Windows Trace Logging on MinGW""
Mar 1 2019, 4:46 PM
vlad.tsyrklevich committed rGa75077bc7386: Revert "[sanitizers] Don't use Windows Trace Logging on MinGW" (authored by vlad.tsyrklevich).
Revert "[sanitizers] Don't use Windows Trace Logging on MinGW"
Mar 1 2019, 4:39 PM
vlad.tsyrklevich committed rL355250: Revert "[sanitizers] Don't use Windows Trace Logging on MinGW".
Revert "[sanitizers] Don't use Windows Trace Logging on MinGW"
Mar 1 2019, 4:39 PM
vlad.tsyrklevich committed rCRT355250: Revert "[sanitizers] Don't use Windows Trace Logging on MinGW".
Revert "[sanitizers] Don't use Windows Trace Logging on MinGW"
Mar 1 2019, 4:38 PM
vlad.tsyrklevich committed rG892513800747: Revert "[MIPS GlobalISel] Fix mul operands" (authored by vlad.tsyrklevich).
Revert "[MIPS GlobalISel] Fix mul operands"
Mar 1 2019, 11:02 AM
vlad.tsyrklevich committed rL355219: Revert "[MIPS GlobalISel] Fix mul operands".
Revert "[MIPS GlobalISel] Fix mul operands"
Mar 1 2019, 11:02 AM

Feb 26 2019

vlad.tsyrklevich committed rGc01643087e71: Revert "[PGO] Context sensitive PGO (part 1)" (authored by vlad.tsyrklevich).
Revert "[PGO] Context sensitive PGO (part 1)"
Feb 26 2019, 7:47 PM
vlad.tsyrklevich committed rL354953: Revert "[PGO] Context sensitive PGO (part 1)".
Revert "[PGO] Context sensitive PGO (part 1)"
Feb 26 2019, 7:47 PM
vlad.tsyrklevich committed rG443e00a51bb9: Revert "[compiler-rt] Intercept the bcmp() function." (authored by vlad.tsyrklevich).
Revert "[compiler-rt] Intercept the bcmp() function."
Feb 26 2019, 10:31 AM
vlad.tsyrklevich added a reverting change for rCRT354852: [compiler-rt] Fix test broken by r354851.: rCRT354906: Revert "[compiler-rt] Intercept the bcmp() function.".
Feb 26 2019, 10:28 AM
vlad.tsyrklevich committed rCRT354906: Revert "[compiler-rt] Intercept the bcmp() function.".
Revert "[compiler-rt] Intercept the bcmp() function."
Feb 26 2019, 10:28 AM
vlad.tsyrklevich added a reverting change for rCRT354853: [compiler-rt] disable asan bcmp tests on android.: rCRT354906: Revert "[compiler-rt] Intercept the bcmp() function.".
Feb 26 2019, 10:28 AM
vlad.tsyrklevich committed rL354906: Revert "[compiler-rt] Intercept the bcmp() function.".
Revert "[compiler-rt] Intercept the bcmp() function."
Feb 26 2019, 10:27 AM
vlad.tsyrklevich added a reverting change for rL354853: [compiler-rt] disable asan bcmp tests on android.: rL354906: Revert "[compiler-rt] Intercept the bcmp() function.".
Feb 26 2019, 10:27 AM
vlad.tsyrklevich added a reverting change for rL354852: [compiler-rt] Fix test broken by r354851.: rL354906: Revert "[compiler-rt] Intercept the bcmp() function.".
Feb 26 2019, 10:27 AM

Feb 25 2019

vlad.tsyrklevich committed rGc6d54ae9daad: Revert "Improve "llvm-nm -f sysv" output for Elf files" (authored by vlad.tsyrklevich).
Revert "Improve "llvm-nm -f sysv" output for Elf files"
Feb 25 2019, 11:06 PM
vlad.tsyrklevich committed rL354849: Revert "Improve "llvm-nm -f sysv" output for Elf files".
Revert "Improve "llvm-nm -f sysv" output for Elf files"
Feb 25 2019, 11:05 PM
vlad.tsyrklevich committed rGe50038e4dc53: Revert "Make static counters in ASTContext non-static." (authored by vlad.tsyrklevich).
Revert "Make static counters in ASTContext non-static."
Feb 25 2019, 11:54 AM
vlad.tsyrklevich committed rC354812: Revert "Make static counters in ASTContext non-static.".
Revert "Make static counters in ASTContext non-static."
Feb 25 2019, 11:54 AM
vlad.tsyrklevich committed rL354812: Revert "Make static counters in ASTContext non-static.".
Revert "Make static counters in ASTContext non-static."
Feb 25 2019, 11:54 AM

Feb 12 2019

vlad.tsyrklevich accepted D58105: docs: Update the ShadowCallStack documentation..
Feb 12 2019, 2:12 PM · Restricted Project

Feb 7 2019

vlad.tsyrklevich accepted D57924: [safestack] Remove pageSize.

LGTM as long as https://reviews.llvm.org/D57863 doesn't land (to ensure that struct tinfo *tinfo = reinterpret_cast<struct tinfo *>(addr); is a valid pointer to writable memory as the guard is no longer rounded up to page size.)

Feb 7 2019, 3:17 PM · Restricted Project, Restricted Project
vlad.tsyrklevich accepted D57863: [safestack] Explain why tinfo at the end of the buffer.
Feb 7 2019, 2:15 PM · Restricted Project, Restricted Project
vlad.tsyrklevich added a comment to D57924: [safestack] Remove pageSize.

Alternatively, we could have a static buffer we use as a 'temporary' safe stack while initialization runs. I'm not really set on that idea, but it seems cleaner and like it may be more future proof in case another syscall we use (like getrlimit() right now) is intercepted. What do you think?

Feb 7 2019, 1:49 PM · Restricted Project, Restricted Project
vlad.tsyrklevich added inline comments to D57863: [safestack] Explain why tinfo at the end of the buffer.
Feb 7 2019, 1:39 PM · Restricted Project, Restricted Project
vlad.tsyrklevich accepted D57866: [safestack] Don't crash if stack size is not aligned as expected.
Feb 7 2019, 12:37 PM · Restricted Project, Restricted Project

Jan 18 2019

vlad.tsyrklevich committed rC351528: Fix failing MSan bots.
Fix failing MSan bots
Jan 18 2019, 12:47 AM
vlad.tsyrklevich committed rL351528: Fix failing MSan bots.
Fix failing MSan bots
Jan 18 2019, 12:47 AM

Jan 17 2019

vlad.tsyrklevich committed rC351457: TLS: Respect visibility for thread_local variables on Darwin (PR40327).
TLS: Respect visibility for thread_local variables on Darwin (PR40327)
Jan 17 2019, 9:57 AM
vlad.tsyrklevich committed rL351457: TLS: Respect visibility for thread_local variables on Darwin (PR40327).
TLS: Respect visibility for thread_local variables on Darwin (PR40327)
Jan 17 2019, 9:57 AM
vlad.tsyrklevich closed D56818: TLS: Respect visibility for thread_local variables on Darwin (PR40327).
Jan 17 2019, 9:57 AM

Jan 16 2019

vlad.tsyrklevich added inline comments to D56818: TLS: Respect visibility for thread_local variables on Darwin (PR40327).
Jan 16 2019, 9:50 PM
vlad.tsyrklevich added inline comments to D56818: TLS: Respect visibility for thread_local variables on Darwin (PR40327).
Jan 16 2019, 9:37 PM
vlad.tsyrklevich added a comment to D56818: TLS: Respect visibility for thread_local variables on Darwin (PR40327).

John I took a brief at look at the visibility for templated thread_local variables on Darwin and they looked correct at a glance, though I'm not confident I understand the ABI well enough to understand exactly how the linkonce*/weak_odr case differs between Darwin and other platforms.

Jan 16 2019, 3:34 PM
vlad.tsyrklevich created D56818: TLS: Respect visibility for thread_local variables on Darwin (PR40327).
Jan 16 2019, 3:28 PM

Jan 15 2019

vlad.tsyrklevich committed rL351282: Revert "[Tooling] Make clang-tool find libc++ dir on mac when running on a file….
Revert "[Tooling] Make clang-tool find libc++ dir on mac when running on a file…
Jan 15 2019, 4:41 PM
vlad.tsyrklevich committed rC351282: Revert "[Tooling] Make clang-tool find libc++ dir on mac when running on a file….
Revert "[Tooling] Make clang-tool find libc++ dir on mac when running on a file…
Jan 15 2019, 4:41 PM

Jan 14 2019

vlad.tsyrklevich committed rC351159: Revert alignment assumptions changes.
Revert alignment assumptions changes
Jan 14 2019, 7:42 PM
vlad.tsyrklevich committed rL351159: Revert alignment assumptions changes.
Revert alignment assumptions changes
Jan 14 2019, 7:42 PM
vlad.tsyrklevich committed rCRT351159: Revert alignment assumptions changes.
Revert alignment assumptions changes
Jan 14 2019, 7:42 PM
vlad.tsyrklevich committed rCRT351153: Silence failing tests.
Silence failing tests
Jan 14 2019, 6:26 PM
vlad.tsyrklevich committed rL351153: Silence failing tests.
Silence failing tests
Jan 14 2019, 6:26 PM

Dec 13 2018

vlad.tsyrklevich committed rL349115: Windows ASan: Instrument _msize_base().
Windows ASan: Instrument _msize_base()
Dec 13 2018, 4:42 PM
vlad.tsyrklevich committed rCRT349115: Windows ASan: Instrument _msize_base().
Windows ASan: Instrument _msize_base()
Dec 13 2018, 4:42 PM
vlad.tsyrklevich closed D55684: Windows ASan: Instrument _msize_base().
Dec 13 2018, 4:42 PM
vlad.tsyrklevich added reviewers for D55684: Windows ASan: Instrument _msize_base(): rnk, Restricted Project.
Dec 13 2018, 4:08 PM
vlad.tsyrklevich created D55684: Windows ASan: Instrument _msize_base().
Dec 13 2018, 4:07 PM

Nov 26 2018

vlad.tsyrklevich accepted D54543: [stack-safety] Inter-Procedural Analysis implementation.
Nov 26 2018, 11:44 AM
vlad.tsyrklevich accepted D54504: [stack-safety] Local analysis implementation.

modulo nits on updating comments that I left earlier

Nov 26 2018, 11:37 AM
vlad.tsyrklevich added a comment to D54504: [stack-safety] Local analysis implementation.

I've been busy and still haven't had a chance to run down why the behavior of %z in the NonConstantOffset() test changes so oddly with different select values.

Nov 26 2018, 11:01 AM
vlad.tsyrklevich accepted D54541: [stack-safety] Empty local passes for Stack Safety Global Analysis.
Nov 26 2018, 10:58 AM
vlad.tsyrklevich accepted D54502: [stack-safety] Empty local passes for Stack Safety Local Analysis.
Nov 26 2018, 10:58 AM

Nov 15 2018

vlad.tsyrklevich added a comment to D54543: [stack-safety] Inter-Procedural Analysis implementation.

Can we reconsider this later. I've added TODO. Probably these are implementation details which are unneeded.

Nov 15 2018, 4:27 PM
vlad.tsyrklevich added a comment to D54543: [stack-safety] Inter-Procedural Analysis implementation.

That's unfortunate, as now we can keep checks for local and global passes mostly the same and highlight the difference with branched LOCAL-NEXT/GLOBAL-NEXT

Nov 15 2018, 12:26 PM
vlad.tsyrklevich added inline comments to D54502: [stack-safety] Empty local passes for Stack Safety Local Analysis.
Nov 15 2018, 6:47 AM
vlad.tsyrklevich added inline comments to D54541: [stack-safety] Empty local passes for Stack Safety Global Analysis.
Nov 15 2018, 6:47 AM
vlad.tsyrklevich added inline comments to D54504: [stack-safety] Local analysis implementation.
Nov 15 2018, 6:47 AM
vlad.tsyrklevich added a comment to D54543: [stack-safety] Inter-Procedural Analysis implementation.

The local tests that check for use 'empty-set, $CALL_INFO' for the local and 'full-set, $CALL_INFO' for the global analysis is sort of confusing. It seems like the use is safe in local analysis (empty-set means no uses!) but unsafe in the global, when really the situation is actually local analysis has 'no local uses but used in function calls' and the global analysis is just 'it's safe/unsafe (function call info is integrated into the previous distintion)'. Maybe we should clear all of the UseInfo::Calls fields at the end of StackSafetyDataFlowAnalysis?

Nov 15 2018, 6:46 AM

Oct 27 2018

vlad.tsyrklevich committed rL345457: Revert "DebugInfo: reduce DIE range verification on object files".
Revert "DebugInfo: reduce DIE range verification on object files"
Oct 27 2018, 10:41 AM

Oct 26 2018

vlad.tsyrklevich committed rL345397: Revert "UBSan blacklist workaround for bot timeouts".
Revert "UBSan blacklist workaround for bot timeouts"
Oct 26 2018, 9:09 AM

Oct 25 2018

vlad.tsyrklevich committed rL345356: Revert "[AArch64] Create proper memoperand for multi-vector stores".
Revert "[AArch64] Create proper memoperand for multi-vector stores"
Oct 25 2018, 7:02 PM

Oct 22 2018

vlad.tsyrklevich committed rC344961: Revert "Ensure sanitizer check function calls have a !dbg location".
Revert "Ensure sanitizer check function calls have a !dbg location"
Oct 22 2018, 2:54 PM
vlad.tsyrklevich committed rL344961: Revert "Ensure sanitizer check function calls have a !dbg location".
Revert "Ensure sanitizer check function calls have a !dbg location"
Oct 22 2018, 2:54 PM

Oct 19 2018

vlad.tsyrklevich added inline comments to D53336: Stack Safety Analysis documentation.
Oct 19 2018, 10:10 AM

Oct 16 2018

vlad.tsyrklevich accepted D53336: Stack Safety Analysis documentation.
Oct 16 2018, 3:03 PM
vlad.tsyrklevich added a comment to D53336: Stack Safety Analysis documentation.

I sent you my StackSafetyAnalysis.rst edits over e-mail because the s/// format got tricky.

Oct 16 2018, 12:37 PM

Sep 21 2018

vlad.tsyrklevich committed rL342763: SafeStack: Fix flaky test (PR39001).
SafeStack: Fix flaky test (PR39001)
Sep 21 2018, 12:04 PM
vlad.tsyrklevich committed rCRT342763: SafeStack: Fix flaky test (PR39001).
SafeStack: Fix flaky test (PR39001)
Sep 21 2018, 12:03 PM
vlad.tsyrklevich closed D52330: SafeStack: Fix flaky test (PR39001).
Sep 21 2018, 12:03 PM
vlad.tsyrklevich added inline comments to D52330: SafeStack: Fix flaky test (PR39001).
Sep 21 2018, 10:50 AM

Sep 20 2018

vlad.tsyrklevich created D52330: SafeStack: Fix flaky test (PR39001).
Sep 20 2018, 4:14 PM

Sep 14 2018

vlad.tsyrklevich added a comment to D51905: Front-end of the implementation of the interleaving algorithm.

This change causes all compiler-rt cfi tests to be UNSUPPORTED for me locally, do you have any idea why that might be? The lit changes don't make it immediately clear.

Not sure why that happened. How did you run the compiler-rt tests? Did you use ninja check-cfi?

Sep 14 2018, 2:14 PM · Restricted Project

Sep 12 2018

vlad.tsyrklevich committed rCRT342092: [TSan] Update test values.
[TSan] Update test values
Sep 12 2018, 3:19 PM
vlad.tsyrklevich committed rL342092: [TSan] Update test values.
[TSan] Update test values
Sep 12 2018, 3:18 PM

Sep 11 2018

vlad.tsyrklevich added a comment to D51905: Front-end of the implementation of the interleaving algorithm.

This change causes all compiler-rt cfi tests to be UNSUPPORTED for me locally, do you have any idea why that might be? The lit changes don't make it immediately clear.

Sep 11 2018, 5:02 PM · Restricted Project

Aug 30 2018

vlad.tsyrklevich committed rL341116: SafeStack: Prevent OOB reads with mem intrinsics.
SafeStack: Prevent OOB reads with mem intrinsics
Aug 30 2018, 1:47 PM
vlad.tsyrklevich closed D51334: SafeStack: Prevent OOB reads with mem intrinsics.
Aug 30 2018, 1:47 PM

Aug 28 2018

vlad.tsyrklevich committed rCRT340856: SafeStack: Fix thread liveness check on *BSD.
SafeStack: Fix thread liveness check on *BSD
Aug 28 2018, 11:31 AM
vlad.tsyrklevich committed rL340856: SafeStack: Fix thread liveness check on *BSD.
SafeStack: Fix thread liveness check on *BSD
Aug 28 2018, 11:31 AM
vlad.tsyrklevich closed D51368: SafeStack: Fix thread liveness check on *BSD.
Aug 28 2018, 11:31 AM
vlad.tsyrklevich added a comment to D51368: SafeStack: Fix thread liveness check on *BSD.

NetBSD is fixed, as I was observing previously:

$ check-safestack

********************
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Testing Time: 0.56s
********************
Failing Tests (1):
    SafeStack :: pthread-cleanup.c

  Expected Passes    : 7
  Unsupported Tests  : 1
  Unexpected Failures: 1

The failure is gone with this patch.

Aug 28 2018, 11:28 AM
vlad.tsyrklevich added a comment to D51368: SafeStack: Fix thread liveness check on *BSD.
[100%] Running the SafeStack tests
-- Testing: 9 tests, 8 threads --
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Testing Time: 0.61s
  Expected Passes    : 8
  Unsupported Tests  : 1
[100%] Built target check-safestack
$ uname -a
NetBSD chieftec 8.99.24 NetBSD 8.99.24 (GENERIC) #2: Thu Aug 16 13:44:34 CEST 2018  root@chieftec:/public/netbsd-root/sys/arch/amd64/compile/GENERIC amd64
Aug 28 2018, 11:23 AM
vlad.tsyrklevich created D51368: SafeStack: Fix thread liveness check on *BSD.
Aug 28 2018, 10:28 AM

Aug 27 2018

vlad.tsyrklevich created D51334: SafeStack: Prevent OOB reads with mem intrinsics.
Aug 27 2018, 5:34 PM

Aug 23 2018

vlad.tsyrklevich added inline comments to D50754: Implementation of a vtable interleaving algorithm.
Aug 23 2018, 9:42 AM · Restricted Project

Aug 21 2018

vlad.tsyrklevich committed rCRT340308: SafeStack: Use correct unsafe stack sizes.
SafeStack: Use correct unsafe stack sizes
Aug 21 2018, 10:30 AM
vlad.tsyrklevich committed rL340308: SafeStack: Use correct unsafe stack sizes.
SafeStack: Use correct unsafe stack sizes
Aug 21 2018, 10:30 AM
vlad.tsyrklevich closed D51016: SafeStack: Use correct unsafe stack sizes.
Aug 21 2018, 10:30 AM

Aug 20 2018

vlad.tsyrklevich created D51016: SafeStack: Use correct unsafe stack sizes.
Aug 20 2018, 4:50 PM
vlad.tsyrklevich added inline comments to D43690: [ThinLTO] Keep available_externally symbols live.
Aug 20 2018, 11:13 AM
vlad.tsyrklevich added a comment to D43690: [ThinLTO] Keep available_externally symbols live.

Hello, I wonder if we need to keep linkonce_odr symbols live here as well. I observe a case that a vtable for template class initiated has linkonce_odr linkage and marked dead here, which results compiler crash at WholeProgramDevirt because the global variable for vtable doesn't have initializer (https://github.com/llvm-mirror/llvm/blob/master/lib/Transforms/IPO/WholeProgramDevirt.cpp#L676 assumes that GV has the initializer). Thanks!

Aug 20 2018, 10:05 AM

Aug 14 2018

vlad.tsyrklevich committed rL339732: SafeStack: Disable Darwin support.
SafeStack: Disable Darwin support
Aug 14 2018, 2:39 PM
vlad.tsyrklevich committed rCRT339723: Reland "SafeStack: Delay thread stack clean-up"".
Reland "SafeStack: Delay thread stack clean-up""
Aug 14 2018, 1:29 PM
vlad.tsyrklevich committed rL339723: Reland "SafeStack: Delay thread stack clean-up"".
Reland "SafeStack: Delay thread stack clean-up""
Aug 14 2018, 1:29 PM
vlad.tsyrklevich committed rC339720: SafeStack: Disable Darwin support.
SafeStack: Disable Darwin support
Aug 14 2018, 12:51 PM
vlad.tsyrklevich committed rL339720: SafeStack: Disable Darwin support.
SafeStack: Disable Darwin support
Aug 14 2018, 12:51 PM
vlad.tsyrklevich closed D50724: SafeStack: Disable Darwin support.
Aug 14 2018, 12:51 PM
vlad.tsyrklevich committed rL339719: SafeStack: Disable Darwin support.
SafeStack: Disable Darwin support
Aug 14 2018, 12:47 PM
vlad.tsyrklevich committed rCRT339719: SafeStack: Disable Darwin support.
SafeStack: Disable Darwin support
Aug 14 2018, 12:47 PM