Page MenuHomePhabricator
Feed Advanced Search

Aug 10 2016

omtcyf0 added a comment to D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.

Revert changes.

Thanks! If Aaron has no objections, good to go.

Aug 10 2016, 10:57 AM
omtcyf0 updated the diff for D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.

Revert changes.

Aug 10 2016, 10:52 AM
omtcyf0 added a comment to D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.
Aug 10 2016, 7:24 AM
omtcyf0 updated the diff for D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.

Address comments.

Aug 10 2016, 7:24 AM
omtcyf0 abandoned D15685: [clang-tidy] introducing cppcoreguidelines-enum-all-caps check.
Aug 10 2016, 2:21 AM
omtcyf0 abandoned D17244: [clang-tidy] readability-ternary-operator new check.
Aug 10 2016, 2:21 AM
omtcyf0 removed reviewers for D17244: [clang-tidy] readability-ternary-operator new check: alexfh, djasper, Eugene.Zelenko, LegalizeAdulthood.
Aug 10 2016, 2:20 AM
omtcyf0 added a comment to D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.
Aug 10 2016, 2:19 AM
omtcyf0 updated the diff for D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.

Address comments.

Aug 10 2016, 2:18 AM

Aug 9 2016

omtcyf0 updated the diff for D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.

Address remaining comments.

Aug 9 2016, 7:03 AM
omtcyf0 updated the diff for D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.

Address comments Alex made.

Aug 9 2016, 6:32 AM

Jul 16 2016

omtcyf0 edited reviewers for D22237: clang-rename: fix renaming member functions, added: omtcyfz; removed: omtcyf0.
Jul 16 2016, 1:17 AM
omtcyf0 updated subscribers of D21814: clang-rename: split existing options into two new subcommands.
Jul 16 2016, 12:35 AM

Jul 15 2016

omtcyf0 added a comment to D22237: clang-rename: fix renaming member functions.

Sorry for a late response.

Jul 15 2016, 11:45 PM

Jul 14 2016

omtcyf0 added a comment to D22237: clang-rename: fix renaming member functions.

This one doesn't fix it though.

Jul 14 2016, 1:48 AM
omtcyf0 added a comment to D22102: [clang-rename] extend testset.

@vmiklos sure thing.

Jul 14 2016, 1:41 AM
omtcyf0 updated the diff for D22102: [clang-rename] extend testset.
Jul 14 2016, 1:40 AM
omtcyf0 added a comment to D22102: [clang-rename] extend testset.

Can you please land it?

Jul 14 2016, 1:00 AM
omtcyf0 added a comment to D22102: [clang-rename] extend testset.

Oops, sorry. Fixed it.

Jul 14 2016, 12:53 AM
omtcyf0 updated the diff for D22102: [clang-rename] extend testset.
Jul 14 2016, 12:52 AM
omtcyf0 added a comment to D22091: [clang-rename] exit code-related bugfix and code cleanup.

Can you please land it?

Jul 14 2016, 12:44 AM
omtcyf0 updated the diff for D22091: [clang-rename] exit code-related bugfix and code cleanup.
Jul 14 2016, 12:43 AM

Jul 13 2016

omtcyf0 added a comment to D22091: [clang-rename] exit code-related bugfix and code cleanup.

Does it look good now?

Jul 13 2016, 11:49 PM
omtcyf0 removed reviewers for D22102: [clang-rename] extend testset: ioeric, bkramer, alexfh.
Jul 13 2016, 11:42 PM
omtcyf0 added a comment to D22129: [clang-rename] add documentation.

Any other objections?

Jul 13 2016, 11:42 PM
omtcyf0 removed reviewers for D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check: LegalizeAdulthood, rsmith.
Jul 13 2016, 11:41 PM

Jul 12 2016

omtcyf0 updated the diff for D22102: [clang-rename] extend testset.
Jul 12 2016, 12:35 AM
omtcyf0 updated the diff for D22129: [clang-rename] add documentation.

Thanks for the feedback!

Jul 12 2016, 12:20 AM

Jul 11 2016

omtcyf0 removed reviewers for D22129: [clang-rename] add documentation: hokein, klimek, ioeric, alexfh.
Jul 11 2016, 6:29 AM
omtcyf0 updated the diff for D22102: [clang-rename] extend testset.

add XFAIL test with virtual function renaming

Jul 11 2016, 12:57 AM
omtcyf0 updated the diff for D22091: [clang-rename] exit code-related bugfix and code cleanup.

Add new test, which ensures clang-rename failure if new name is not passed.

Jul 11 2016, 12:22 AM

Jul 10 2016

omtcyf0 added inline comments to D22091: [clang-rename] exit code-related bugfix and code cleanup.
Jul 10 2016, 1:33 AM
omtcyf0 updated the diff for D22091: [clang-rename] exit code-related bugfix and code cleanup.
Jul 10 2016, 1:30 AM

Jul 8 2016

omtcyf0 updated the diff for D22129: [clang-rename] add documentation.
Jul 8 2016, 4:57 AM
omtcyf0 added a comment to D22100: [clang-rename] fix typo in Python script for Vim integration.

@hokein thanks! Can you please land it? I don't have commit access.

Jul 8 2016, 4:42 AM
omtcyf0 retitled D22129: [clang-rename] add documentation from to [clang-rename] add documentation.
Jul 8 2016, 4:32 AM

Jul 7 2016

omtcyf0 added a comment to D21814: clang-rename: split existing options into two new subcommands.

I think it's important to note that Miklos is probably a user, otherwise I'd guess he wouldn't add those features.

Jul 7 2016, 3:20 PM
omtcyf0 added a comment to D21814: clang-rename: split existing options into two new subcommands.

Miklos, thanks for the feedback!

Jul 7 2016, 1:55 PM
omtcyf0 retitled D22102: [clang-rename] extend testset from to [clang-rename] extend testset.
Jul 7 2016, 11:41 AM
omtcyf0 retitled D22100: [clang-rename] fix typo in Python script for Vim integration from to [clang-rename] fix typo in Python script for Vim integration.
Jul 7 2016, 11:28 AM
omtcyf0 added a comment to D22087: [clang-rename] add basic vim integration.

@kimgr oops, sorry.

Jul 7 2016, 11:24 AM
omtcyf0 added a comment to D21814: clang-rename: split existing options into two new subcommands.

Thank you very much for contributing to clang-rename.

Jul 7 2016, 11:19 AM
omtcyf0 added inline comments to D22091: [clang-rename] exit code-related bugfix and code cleanup.
Jul 7 2016, 10:47 AM
omtcyf0 updated the diff for D22091: [clang-rename] exit code-related bugfix and code cleanup.
Jul 7 2016, 10:47 AM
omtcyf0 added a comment to D22087: [clang-rename] add basic vim integration.

@bkramer can you please land the patch?

Jul 7 2016, 7:37 AM
omtcyf0 retitled D22091: [clang-rename] exit code-related bugfix and code cleanup from to [clang-rename] exit code-related bugfix and code cleanup.
Jul 7 2016, 7:34 AM
omtcyf0 added a comment to D22087: [clang-rename] add basic vim integration.
Jul 7 2016, 5:41 AM
omtcyf0 updated the diff for D22087: [clang-rename] add basic vim integration.
Jul 7 2016, 5:40 AM
omtcyf0 added inline comments to D22087: [clang-rename] add basic vim integration.
Jul 7 2016, 5:35 AM
omtcyf0 updated the diff for D22087: [clang-rename] add basic vim integration.
Jul 7 2016, 5:34 AM
omtcyf0 added a comment to D22087: [clang-rename] add basic vim integration.

One note about that header removal: how do I do it then? I thought attaching such changes to a random patch is not a problem. Otherwise there will be some one-line patches for such things, won't they?

Jul 7 2016, 5:23 AM
omtcyf0 updated the diff for D22087: [clang-rename] add basic vim integration.
Jul 7 2016, 5:18 AM
omtcyf0 added a reviewer for D22087: [clang-rename] add basic vim integration: ioeric.
Jul 7 2016, 4:26 AM
omtcyf0 retitled D22087: [clang-rename] add basic vim integration from to [clang-rename] add basic vim integration.
Jul 7 2016, 4:25 AM

Jul 6 2016

omtcyf0 added a comment to D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.

http://en.cppreference.com/w/cpp/header for reference

Jul 6 2016, 6:40 AM
omtcyf0 added a comment to D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.

@alexfh same applies to the other headers. All of them are marked as "deprecated" there.

Jul 6 2016, 6:35 AM
omtcyf0 added a comment to D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.

resolved small problems

Jul 6 2016, 5:43 AM
omtcyf0 updated the diff for D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.
Jul 6 2016, 5:42 AM

Jul 4 2016

omtcyf0 added inline comments to D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.
Jul 4 2016, 11:44 AM
omtcyf0 updated the diff for D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.

Hope it looks better now.

Jul 4 2016, 11:43 AM
omtcyf0 added a comment to D21974: [clang-include-fixer] fix PEP8 warnings.

@bkramer I don't. Can you please land it?

Jul 4 2016, 9:34 AM
omtcyf0 added a reviewer for D21974: [clang-include-fixer] fix PEP8 warnings: alexfh.
Jul 4 2016, 6:58 AM
omtcyf0 retitled D21974: [clang-include-fixer] fix PEP8 warnings from to [clang-include-fixer] fix PEP8 warnings.
Jul 4 2016, 6:58 AM

Apr 22 2016

omtcyf0 added a comment to D19406: [clang-tidy] fix link in Release Notes.

I'd be very grateful if you could land it!

Apr 22 2016, 5:36 AM
omtcyf0 retitled D19406: [clang-tidy] fix link in Release Notes from [clang-tidy] Release Notes fix typo in check link to [clang-tidy] fix link in Release Notes.
Apr 22 2016, 3:15 AM
omtcyf0 retitled D19406: [clang-tidy] fix link in Release Notes from to [clang-tidy] Release Notes fix typo in check link.
Apr 22 2016, 3:10 AM

Mar 11 2016

omtcyf0 added a comment to D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check.

@alexfh, why? I've deleted these headers both from sources and from testset, didn't I?

Mar 11 2016, 9:04 AM

Mar 9 2016

omtcyf0 retitled D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check from to [clang-tidy] minor improvements in modernise-deprecated-headers check.
Mar 9 2016, 5:26 AM

Feb 26 2016

omtcyf0 added a comment to D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics..

Hm. Seems like this is either me using run-clang-tidy.py wrong or it working not properly, because I still get compilation errors. I believe I've done same thing yesterday using older tree and I didn't get any.

Feb 26 2016, 5:12 AM
omtcyf0 added a comment to D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics..

@xazax.hun did you actually run the tool on the LLVM codebase?

Because this check generates tons of false-positive reports during codebase analysis.

See the minimal example below.

omtcyf0-laptop:playground omtcyf0$ cat main.cpp 
#include <vector>

int main() {
  std::vector<int> numbers = {1, 2, 3, 4, 5, 6};
  for (std::vector<int>::iterator it = std::begin(numbers),
                                  end = std::end(numbers);
       it != end; ++it) {
    (*it)++;
  }
  return 0;
}
omtcyf0-laptop:playground omtcyf0$ /Users/omtcyf0/Documents/dev/build/Release/llvm/bin/clang-tidy -checks=misc-suspicious-semicolon main.cpp 
Error while trying to load a compilation database:
Could not auto-detect compilation database for file "main.cpp"
No compilation database found in /Users/omtcyf0/Documents/dev/playground or any parent directory
json-compilation-database: Error while opening JSON database: No such file or directory
Running without flags.
1 warning and 1 error generated.
Error while processing /Users/omtcyf0/Documents/dev/playground/main.cpp.
/Users/omtcyf0/Documents/dev/playground/main.cpp:6:17: warning: potentially unintended semicolon [misc-suspicious-semicolon]
       it != end; ++it) {
                ^
/usr/include/wchar.h:89:10: error: 'stdarg.h' file not found [clang-diagnostic-error]
#include <stdarg.h>
         ^

And this is happening all over the LLVM codebase, because there is nothing bad there.

Can you please fix that?

Kirill, the problem in your case may be related to the check seeing incomplete AST due to compilation errors. Can you append -- -std=c++11 to your clang-tidy invocation and try again whether it will be able to parse the file completely (i.e. without any "file not found" and other compilation errors)?

Feb 26 2016, 4:45 AM
omtcyf0 added a comment to D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics..

@xazax.hun did you actually run the tool on the LLVM codebase?

Feb 26 2016, 4:10 AM

Feb 25 2016

omtcyf0 added inline comments to D17602: [clang-tidy] update links to Google Code Style in docs.
Feb 25 2016, 6:35 AM
omtcyf0 added a comment to D17602: [clang-tidy] update links to Google Code Style in docs.

Thank you very much, @hokein!

Feb 25 2016, 6:24 AM
omtcyf0 added inline comments to D17602: [clang-tidy] update links to Google Code Style in docs.
Feb 25 2016, 6:21 AM
omtcyf0 added inline comments to D17602: [clang-tidy] update links to Google Code Style in docs.
Feb 25 2016, 6:07 AM
omtcyf0 updated the diff for D17602: [clang-tidy] update links to Google Code Style in docs.

Removed the breakline.

Feb 25 2016, 6:05 AM
omtcyf0 added inline comments to D17602: [clang-tidy] update links to Google Code Style in docs.
Feb 25 2016, 5:10 AM
omtcyf0 removed a reviewer for D17602: [clang-tidy] update links to Google Code Style in docs: cfe-commits.
Feb 25 2016, 4:42 AM
omtcyf0 retitled D17602: [clang-tidy] update links to Google Code Style in docs from to [clang-tidy] update links to Google Code Style in docs.
Feb 25 2016, 4:41 AM

Feb 24 2016

omtcyf0 added a comment to D17244: [clang-tidy] readability-ternary-operator new check.

Thanks for the review!

Feb 24 2016, 5:55 AM
omtcyf0 added a comment to D17484: [clang-tidy] introduce modernize-deprecated-headers check.

Looks good with one nit.

Let me know if you need me to commit the patch for you.

Feb 24 2016, 4:12 AM
omtcyf0 updated the diff for D17484: [clang-tidy] introduce modernize-deprecated-headers check.

replaced few explicit casts to llvm::Twine with implicit ones

Feb 24 2016, 4:12 AM

Feb 23 2016

omtcyf0 updated the diff for D17484: [clang-tidy] introduce modernize-deprecated-headers check.

changed the warning comment to be more precise; fixed line with > 80 symbols

Feb 23 2016, 2:18 AM
omtcyf0 updated the diff for D17484: [clang-tidy] introduce modernize-deprecated-headers check.

Resolved issues @alexfh pointed to.

Feb 23 2016, 2:11 AM

Feb 22 2016

omtcyf0 added a comment to D17484: [clang-tidy] introduce modernize-deprecated-headers check.

Marked the comments as *done*.

Feb 22 2016, 11:11 AM
omtcyf0 updated the diff for D17484: [clang-tidy] introduce modernize-deprecated-headers check.

Fixed all the issues @alexfh pointed to.

Feb 22 2016, 11:10 AM
omtcyf0 added a comment to D17484: [clang-tidy] introduce modernize-deprecated-headers check.

Thank you for a review, Alex!

Feb 22 2016, 10:15 AM

Feb 21 2016

omtcyf0 added a comment to D17484: [clang-tidy] introduce modernize-deprecated-headers check.
Feb 21 2016, 3:02 AM
omtcyf0 updated the diff for D17484: [clang-tidy] introduce modernize-deprecated-headers check.

Thanks for a review, Richard!
Fixed all the issues you pointed to!

Feb 21 2016, 3:01 AM

Feb 20 2016

omtcyf0 updated the diff for D17484: [clang-tidy] introduce modernize-deprecated-headers check.

Thanks for a review, Eugene!

Feb 20 2016, 2:36 PM
omtcyf0 updated the diff for D17484: [clang-tidy] introduce modernize-deprecated-headers check.

fixed clang-tidy/modernize/DeprecatedHeaders.h head typo caused by the check rename

Feb 20 2016, 11:17 AM
omtcyf0 retitled D17484: [clang-tidy] introduce modernize-deprecated-headers check from to [clang-tidy] introduce modernize-deprecated-headers check.
Feb 20 2016, 11:14 AM

Feb 17 2016

omtcyf0 updated the diff for D17244: [clang-tidy] readability-ternary-operator new check.

Followed some suggestions Richard has kindly given me; fixed the nonsense in SourceRanges' extracting code

Feb 17 2016, 12:55 PM

Feb 13 2016

omtcyf0 retitled D17244: [clang-tidy] readability-ternary-operator new check from to [clang-tidy] readability-ternary-operator new check.
Feb 13 2016, 12:36 PM

Jan 18 2016

omtcyf0 added inline comments to D16286: [clang-tidy] Readability check for redundant parenthesis in return expression..
Jan 18 2016, 6:07 AM
omtcyf0 added a comment to D16270: [clang-tidy] Python scripts shebang fixes.

That'll be very nice.

Jan 18 2016, 6:05 AM

Jan 17 2016

omtcyf0 retitled D16270: [clang-tidy] Python scripts shebang fixes from to [clang-tidy] Python scripts shebang fixes.
Jan 17 2016, 7:54 AM

Dec 29 2015

omtcyf0 added a comment to D15685: [clang-tidy] introducing cppcoreguidelines-enum-all-caps check.

@alexfh, Thanks for the feedback!

Dec 29 2015, 12:58 AM

Dec 21 2015

omtcyf0 retitled D15685: [clang-tidy] introducing cppcoreguidelines-enum-all-caps check from to [clang-tidy] introducing cppcoreguidelines-enum-all-caps check.
Dec 21 2015, 12:55 AM

Dec 12 2015

omtcyf0 updated the diff for D15370: [scan-view] replace deprecated optparse with argparse.

Added tool description.

Dec 12 2015, 2:04 AM