Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

	Include stories about projects I am a member of.

Mar 24 2023

FlameTop added a comment to D144083: [JITLink] Initial AArch32 backend.

Thank you for the swift action. Unfortunately another MSVC-ism has reared its head.

Mar 24 2023, 6:44 AM · Restricted Project, Restricted Project

FlameTop added a comment to D144083: [JITLink] Initial AArch32 backend.

We are seeing a build error on Windows building with MSVC. Attempt to access a private typedef.

Mar 24 2023, 3:51 AM · Restricted Project, Restricted Project

Nov 10 2021

FlameTop added a comment to D112803: Investigation of porting scudo standalone to Windows for use in LLVM tools..

One of the main problems we found in this investigation was getting reliable performance metrics. Scudo was at least very consistent. Windows Heap appears to be wildly influenced by the allocation/de-allocation profile. In some circumstances WinHeap was seen to perform and scale very well over multiple threads. But in others it was seen to perform amazingly badly. One suspected culprit for this effect is the interaction between the 'low-fragmentation' heap scheme used for smaller allocations vs the 'big heap' for larger.

Nov 10 2021, 7:12 AM · Restricted Project

Oct 29 2021

FlameTop updated the summary of D112803: Investigation of porting scudo standalone to Windows for use in LLVM tools..

Oct 29 2021, 6:55 AM · Restricted Project

FlameTop updated the diff for D112803: Investigation of porting scudo standalone to Windows for use in LLVM tools..

Fixed missing commit in diff file.

Oct 29 2021, 4:57 AM · Restricted Project

FlameTop requested review of D112803: Investigation of porting scudo standalone to Windows for use in LLVM tools..

Oct 29 2021, 4:48 AM · Restricted Project

Jun 21 2021

FlameTop added a comment to D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries.

This commit is failing the test on non-arm targets (e.g. https://lab.llvm.org/buildbot/#/builders/139/builds/5932). I think the test needs a 'requires' line for aarch64.

Jun 21 2021, 7:38 AM · Restricted Project, Restricted Project

May 8 2019

FlameTop added a comment to D61089: [Reassociation] Place moved instructions after landing pads.

Looks like some lines got truncated from the head of the first test file. Test is failing due to no run line.

May 8 2019, 9:30 AM · Restricted Project

Dec 21 2018

FlameTop added a comment to D55792: Allow direct navigation to static analysis checker documentation through SARIF exports.

I'm afraid we are seeing a build failure here on our local Windows checking MSVC build. Unfortunately I cannot find a public buildbot that uses the exact configuration that causes the assertion. The assertion we are seeing is

Dec 21 2018, 9:35 AM

FlameTop added inline comments to rL349812: Allow direct navigation to static analysis checker documentation through SARIF….

Dec 21 2018, 6:03 AM

Sep 13 2018

FlameTop added a comment to rL342088: [llvm-cov] Delete custom JSON serialization code (NFC).

May I ask if the changes made to 'binary-formats.canonical.json' in regards to making the filename checks more strict were deliberate? It is just that on Windows systems these checks now fail due to path name differences (the good old '/' vs '\' problems). I notice you did keep a more relaxed filename check intact in some other tests.

Sep 13 2018, 5:34 AM

Jan 23 2018

FlameTop added a comment to D42369: Issue local statics in correct DWARF lexical scope.

In D42369#984155, @probinson wrote:

I'm not seeing where the add/getLocalLexicalDIEs APIs are being used.

Jan 23 2018, 5:23 AM · Restricted Project

FlameTop updated the diff for D42369: Issue local statics in correct DWARF lexical scope.

Apologies, I had a lot of trouble getting svn setup on my machine. Seems I lost some changes in the original diff. Updated for code to issues the lexical DIEs.

Jan 23 2018, 5:19 AM · Restricted Project

Jan 22 2018

FlameTop created D42370: Issue local statics in correct DWARF lexical scope.

Jan 22 2018, 6:44 AM · Restricted Project, debug-info

FlameTop created D42371: Issue local statics in correct DWARF lexical scope.

Jan 22 2018, 6:44 AM · Restricted Project

FlameTop created D42369: Issue local statics in correct DWARF lexical scope.

Jan 22 2018, 6:44 AM · Restricted Project

Oct 26 2017

FlameTop added a comment to D34272: [Tooling] A new framework for executing clang frontend actions..

Hello, I'm afraid this commit is failing on Windows.

Oct 26 2017, 5:34 AM

Oct 19 2017

FlameTop added a comment to D38030: Fix APFloat from string conversion for Inf.

I'm afraid this has broken Windows builds (http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/12860/steps/test/logs/stdio).

Oct 19 2017, 5:16 AM

Jun 19 2017

FlameTop added a comment to D34144: [CodeGen] Add generic MacroFusion pass..

This change is failing to build on windows buildbots.

Jun 19 2017, 4:34 AM

Jun 8 2017

FlameTop added inline comments to D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed..

Jun 8 2017, 5:36 AM · Restricted Project

Dec 20 2016

FlameTop abandoned D27410: Always issue vtables when generating coverage instrumentation.

I must apologise to you all. The problem was reported in our out-of-tree version of the compiler and I must have hit finger problems when I confirmed it in tree. Repeating the test I can no longer reproduce the fault with the 3.9.0 public build. It must be some effect of a local change.

Dec 20 2016, 8:11 AM