Page MenuHomePhabricator
Feed Advanced Search

Yesterday

DavidSpickett accepted D138689: [openmp] Support building for armv7 Windows with mingw tools.

LGTM, remember to update your commit message to reflect the 15 arguments thing.

Fri, Nov 25, 7:31 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D138704: RFC: [openmp] Provide an assembly implementation of __kmp_invoke_microtask on ARM.

Not trying to end up with more comments than assembly, but it might be the easiest way to do it :)

Fri, Nov 25, 7:29 AM · Restricted Project, Restricted Project
DavidSpickett accepted D138703: [openmp] Fix build break for less common architectures.

LGTM

Fri, Nov 25, 5:07 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D138703: [openmp] Fix build break for less common architectures.
Fri, Nov 25, 4:29 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D138689: [openmp] Support building for armv7 Windows with mingw tools.

The proper solution would be to write an assembly version of __kmp_invoke_microtask for ARM too.

Fri, Nov 25, 4:22 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D138689: [openmp] Support building for armv7 Windows with mingw tools.

(The version in z_Linux_util.cpp only handles up to 15 arguments. And contrary to aarch64, z_Linux_asm.S doesn't have any assembly for 32 bit arm.)

Fri, Nov 25, 2:44 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D136578: [LLDB] [LoongArch] Add minimal LoongArch support.

Nice, glad to see that.

Fri, Nov 25, 12:46 AM · Restricted Project, Restricted Project

Thu, Nov 24

DavidSpickett added a comment to D132646: [LLVM][TableGen] Support combined cells in jupyter kernel.

Yes it behaves like the Python kernel, the order that you run cells in matters.

Thu, Nov 24, 10:49 AM · Restricted Project, Restricted Project
DavidSpickett accepted D137827: [openmp] Use z_Linux_asm.S to provide __kmp_invoke_microtask with Clang for Windows/aarch64.

LGTM

Thu, Nov 24, 6:27 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D137827: [openmp] Use z_Linux_asm.S to provide __kmp_invoke_microtask with Clang for Windows/aarch64.

The C implementation of __kmp_invoke_microtask in z_Windows_NT-586_util.cpp relies on unguaranteed assumptions about the compiler behaviour

Thu, Nov 24, 5:18 AM · Restricted Project, Restricted Project
DavidSpickett accepted D138407: [LLDB] Add LoongArch register definitions and operations.

Looks good from the LLDB side.

Thu, Nov 24, 5:06 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D137827: [openmp] Use z_Linux_asm.S to provide __kmp_invoke_microtask with Clang for Windows/aarch64.

I have zero idea about OpenMP, just one comment on the cmake.

Thu, Nov 24, 4:36 AM · Restricted Project, Restricted Project

Wed, Nov 23

DavidSpickett added a comment to D138476: [AMDGPU][InsertWaits] No wait for WAW for global/scratch_load.

Since this change one of our bots has been timing out trying to build SIInsertWaitcnts.cpp https://lab.llvm.org/buildbot/#/builders/182/builds/4502.

Wed, Nov 23, 6:36 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D138407: [LLDB] Add LoongArch register definitions and operations.
Wed, Nov 23, 4:23 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo..

We (Linaro) also have an issue with a bot that uses -DCOMPILER_RT_BUILD_SANITIZERS=OFF.

Wed, Nov 23, 3:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
DavidSpickett accepted D138447: [LLDB][RISCV] Add RV32F instruction support for EmulateInstructionRISCV.

This LGTM.

Wed, Nov 23, 3:07 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added inline comments to D138407: [LLDB] Add LoongArch register definitions and operations.
Wed, Nov 23, 3:05 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D138539: Use std::nullopt_t instead of NoneType (NFC): DavidSpickett.

lldb parts LGTM.

Wed, Nov 23, 2:54 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, Nov 22

DavidSpickett added inline comments to D138407: [LLDB] Add LoongArch register definitions and operations.
Tue, Nov 22, 8:20 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D138447: [LLDB][RISCV] Add RV32F instruction support for EmulateInstructionRISCV.

I am no floating point expert but the structure seems fine and the use of APFloat means most of it looks right on the surface.

Tue, Nov 22, 8:06 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett committed rG75e09ce9b3bf: [libcxx] Add BOT_OWNERS.txt (authored by DavidSpickett).
[libcxx] Add BOT_OWNERS.txt
Tue, Nov 22, 7:41 AM · Restricted Project, Restricted Project
DavidSpickett closed D138445: [libcxx] Add BOT_OWNERS.txt.
Tue, Nov 22, 7:41 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D138445: [libcxx] Add BOT_OWNERS.txt.

Note H for Phabricator handle.

Tue, Nov 22, 7:41 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D138445: [libcxx] Add BOT_OWNERS.txt.

I will land this then, others can add to it.

Tue, Nov 22, 7:36 AM · Restricted Project, Restricted Project

Mon, Nov 21

DavidSpickett added a comment to D138197: [lldb] Fix bitfield incorrectly printing when field crosses a storage unit.

Thanks for working on this. Due to llvm dev and vacation it took me a while to get to this.

Mon, Nov 21, 9:35 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D138445: [libcxx] Add BOT_OWNERS.txt.

Though being able to add discord/phab names would be nice and sod's law that the format took D and P already. We can figure something out if that would be useful.

Mon, Nov 21, 9:16 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D138445: [libcxx] Add BOT_OWNERS.txt.
Mon, Nov 21, 9:11 AM · Restricted Project, Restricted Project

Fri, Nov 18

DavidSpickett committed rG57045982e92e: [LLDB][AArch64] Add BF16BF16, SME2p1 and SVE2p1 to disassembler test (authored by DavidSpickett).
[LLDB][AArch64] Add BF16BF16, SME2p1 and SVE2p1 to disassembler test
Fri, Nov 18, 8:18 AM · Restricted Project
DavidSpickett committed rG3ae3162cb66f: [libcxx] Fix link to Buildbot interface (authored by DavidSpickett).
[libcxx] Fix link to Buildbot interface
Fri, Nov 18, 7:47 AM · Restricted Project, Restricted Project
DavidSpickett closed D138286: [libcxx] Fix link to Buildbot interface.
Fri, Nov 18, 7:47 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D138286: [libcxx] Fix link to Buildbot interface.
Fri, Nov 18, 4:56 AM · Restricted Project, Restricted Project

Thu, Nov 17

DavidSpickett accepted D138026: [ARM][AArch64] Use StringRef in TargetParser structs.

Searching for +xyz will actually lead you to where it is defined.

Thu, Nov 17, 7:44 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions.

What was the decision on m_dwarf_cu possibly being nullptr? We at least want asserts in paths where we assume it'll not be null.

Thu, Nov 17, 3:36 AM · Restricted Project, Restricted Project
DavidSpickett accepted D137761: [LLDB][RISCV] Allow accessing FPR registers through ABI names.

LGTM

Thu, Nov 17, 3:31 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D138026: [ARM][AArch64] Use StringRef in TargetParser structs.

This is now reverse, so that the "+arch-feature" is now visible in the .def, which is a bit clearer.

Thu, Nov 17, 3:25 AM · Restricted Project, Restricted Project
DavidSpickett accepted D138181: [test] Allow skipTestIfFn to apply to entire classes for skipIfNoSBHeaders.

LGTM. Do what makes sense to you with the comment.

Thu, Nov 17, 3:16 AM · Restricted Project, Restricted Project
DavidSpickett accepted D137508: [LLDB][RISCV] Allow accessing registers through ABI names.

Glanced at "Table 18.2: RISC-V calling convention register usage.", LGTM.

Thu, Nov 17, 3:02 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D137975: [libc++] Make it an error to define _LIBCPP_DEBUG.

@DavidSpickett @ARMDavidSpickett The ARM bots seem to be down right now. Can someone please look into it? It's stalling our CI.

Thu, Nov 17, 2:07 AM · Restricted Project, Restricted Project

Wed, Nov 9

DavidSpickett accepted D137692: Fix typo in CMake variable name.

LGTM

Wed, Nov 9, 11:06 PM · Restricted Project

Thu, Nov 3

DavidSpickett added a comment to D137338: Fix dupe word typos.

Looked at the lldb changes, some comments for you. If you want to get a "looks good" for those please submit a separate review with only the lldb parts and I'll review that instead.

Thu, Nov 3, 9:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
DavidSpickett added a comment to D136757: [SLP] Extend reordering data of tree entry to support PHI nodes.

Hi @skc7, this has caused a test suite failure on Linaro's SVE vector length agnostic buildbot.

Thu, Nov 3, 4:56 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D137272: [lldb][Test] Make TestFrameFormatNameWithArgs.test more compatible across platforms.

Test passes on AArch64 Ubuntu 20.04.4, where it failed prior to this change.

Thu, Nov 3, 2:51 AM · Restricted Project, Restricted Project
DavidSpickett accepted D137312: [LLDB] [LoongArch] Add loongarch64 case in ComputeHostArchitectureSupport().

LGTM. Follows the same logic AArch64 does. (meaning: we don't support debugging 32 bit from a 64 bit lldb very well, if it all, but it's still noted here as possible)

Thu, Nov 3, 2:47 AM · Restricted Project, Restricted Project

Wed, Nov 2

DavidSpickett added inline comments to D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions.
Wed, Nov 2, 9:37 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions.
Wed, Nov 2, 7:53 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions.

I'm missing some context here I think.

Wed, Nov 2, 7:51 AM · Restricted Project, Restricted Project

Tue, Nov 1

DavidSpickett accepted D136066: [ARM] Specify Triple in DebugInfo Tests.

LGTM

Tue, Nov 1, 7:54 AM · Restricted Project, Restricted Project
DavidSpickett accepted D137045: [lldb] Don't crash when printing static enum members with bool as underlying type.

LGTM

Tue, Nov 1, 2:10 AM · Restricted Project, Restricted Project

Mon, Oct 31

DavidSpickett added a reviewer for D137085: [LLVM][TableGen] Add first tutorial notebook: awarzynski.
Mon, Oct 31, 8:45 AM · Restricted Project, Restricted Project
DavidSpickett added reviewers for D132646: [LLVM][TableGen] Support combined cells in jupyter kernel: awarzynski, jpienaar.
Mon, Oct 31, 8:39 AM · Restricted Project, Restricted Project
DavidSpickett planned changes to D132647: [LLVM][TableGen] Add JSON magic directive to Jupyter kernel.

I am going to rethink this once the basic tutorials are in place.

Mon, Oct 31, 8:37 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D137085: [LLVM][TableGen] Add first tutorial notebook.
Mon, Oct 31, 8:34 AM · Restricted Project, Restricted Project
DavidSpickett committed rG6268a6704a84: [LLDB][AArch64] Add SME2 to disassembler test (authored by DavidSpickett).
[LLDB][AArch64] Add SME2 to disassembler test
Mon, Oct 31, 7:14 AM · Restricted Project
DavidSpickett abandoned D137076: [LLVM][AArch64] Add SME2 to +all disassembler feature.

Going with https://reviews.llvm.org/D137016 instead.

Mon, Oct 31, 5:09 AM · Restricted Project, Restricted Project
DavidSpickett abandoned D137074: [LLVM][AArch64] Disable +all feature for SME2 tests.

So it is!

Mon, Oct 31, 5:09 AM · Restricted Project, Restricted Project
DavidSpickett added reviewers for D137076: [LLVM][AArch64] Add SME2 to +all disassembler feature: lenary, CarolineConcatto.
Mon, Oct 31, 5:03 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D137076: [LLVM][AArch64] Add SME2 to +all disassembler feature.
Mon, Oct 31, 5:03 AM · Restricted Project, Restricted Project
DavidSpickett added reviewers for D137074: [LLVM][AArch64] Disable +all feature for SME2 tests: lenary, CarolineConcatto.
Mon, Oct 31, 4:57 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D137074: [LLVM][AArch64] Disable +all feature for SME2 tests.
Mon, Oct 31, 4:56 AM · Restricted Project, Restricted Project
DavidSpickett accepted D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection.

Looks good to me.

Mon, Oct 31, 3:33 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D137041: [LLDB] Optimize lldb build time and memory consumption..

Please mention the tools version in the commit somewhere "memory consumption when using gcc 13". If one of you could file a bug at https://gcc.gnu.org/bugzilla/, then you can reference that also.

Mon, Oct 31, 3:30 AM · Restricted Project
DavidSpickett added inline comments to D137045: [lldb] Don't crash when printing static enum members with bool as underlying type.
Mon, Oct 31, 3:22 AM · Restricted Project, Restricted Project

Fri, Oct 28

DavidSpickett accepted D135664: [wasm] Always treat DWARF expression addresses as load addresses.

LGTM, thanks!

Fri, Oct 28, 7:39 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D135664: [wasm] Always treat DWARF expression addresses as load addresses.
Fri, Oct 28, 4:26 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D136938: [LLDB] Fix code breakpoints on tagged addresses.

If you want to understand the motivation beyond "this should work why doesn't it", here it is.

Fri, Oct 28, 3:44 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added reviewers for D136938: [LLDB] Fix code breakpoints on tagged addresses: omjavaid, jasonmolenda.
Fri, Oct 28, 3:42 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added a comment to D136938: [LLDB] Fix code breakpoints on tagged addresses.

Tests will run only for armv8.3-a hardware so I've tested them with qemu-system. Existing tests pass on Armv8 Linux as before.

Fri, Oct 28, 3:42 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett updated the diff for D136938: [LLDB] Fix code breakpoints on tagged addresses.

Add a release note.

Fri, Oct 28, 3:37 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett requested review of D136938: [LLDB] Fix code breakpoints on tagged addresses.
Fri, Oct 28, 3:29 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added a reviewer for D136928: [LLDB] Fix help text for "platform settings": clayborg.

Alternatively, I could look at adding that option. Not sure off the top of my head if configuring an inactive platform would even work.

Fri, Oct 28, 2:19 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D136928: [LLDB] Fix help text for "platform settings".
Fri, Oct 28, 2:18 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D136362: [LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV.

Can you give us:

  • the full cmake command you used to configure the project
  • the gcc/g++ version used
  • the distro used
  • the architecture (unlikely to matter but I'm assuming Loongson?)
  • the version of clang++ that did work
Fri, Oct 28, 12:48 AM · Restricted Project, Restricted Project, Restricted Project

Oct 27 2022

DavidSpickett committed rGc6e2de60423a: [LLVM] Use DWARFv4 bitfields when tuning for GDB (authored by DavidSpickett).
[LLVM] Use DWARFv4 bitfields when tuning for GDB
Oct 27 2022, 1:51 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett closed D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB.
Oct 27 2022, 1:51 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett updated the diff for D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB.
  • DWARFvN -> DWARF vN
  • Remove superfluous brackets.
Oct 27 2022, 1:39 AM · Restricted Project, Restricted Project, Restricted Project

Oct 26 2022

DavidSpickett committed rG6cc5bcc12d30: [LLDB] Correct env vars for Android port selection (authored by DavidSpickett).
[LLDB] Correct env vars for Android port selection
Oct 26 2022, 5:33 AM · Restricted Project
DavidSpickett updated the summary of D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB.
Oct 26 2022, 3:13 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett updated the diff for D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB.
  • Test that linux DWARFv4 uses data_bit_offset and that adding GDB tuning does not change that.
  • Add release notes for clang and llvm.
Oct 26 2022, 3:12 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added a comment to D136465: Make remote-android local ports configurable.

Thanks for your efforts here, very much appreciated.

Oct 26 2022, 1:15 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D136465: Make remote-android local ports configurable.

Landed as https://github.com/llvm/llvm-project/commit/1e210abf9925ad08fb7c79894b4ec5ef8f0ef173.

Oct 26 2022, 1:15 AM · Restricted Project, Restricted Project
DavidSpickett committed rG1e210abf9925: [LLDB] Make remote-android local ports configurable (authored by mark2185).
[LLDB] Make remote-android local ports configurable
Oct 26 2022, 1:15 AM · Restricted Project
DavidSpickett closed D136465: Make remote-android local ports configurable.
Oct 26 2022, 1:14 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D136465: Make remote-android local ports configurable.

Great! I'd just like to note that I do not have commit access, per the guide's instructions.

Oct 26 2022, 12:26 AM · Restricted Project, Restricted Project

Oct 25 2022

DavidSpickett accepted D135622: [lldb] Add a "diagnostics dump" command.

LGTM

Oct 25 2022, 8:47 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D136578: [LLDB] [LoongArch] Add minimal LoongArch support.

Landed as https://github.com/llvm/llvm-project/commit/a3be778ed09b7badcda20c5c8738ba19531dad48.

Oct 25 2022, 6:00 AM · Restricted Project, Restricted Project
DavidSpickett committed rGa3be778ed09b: [LLDB] [LoongArch] Add minimal LoongArch support (authored by seehearfeel).
[LLDB] [LoongArch] Add minimal LoongArch support
Oct 25 2022, 6:00 AM · Restricted Project
DavidSpickett closed D136578: [LLDB] [LoongArch] Add minimal LoongArch support.
Oct 25 2022, 6:00 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D136578: [LLDB] [LoongArch] Add minimal LoongArch support.

I am a newcomer, here are some of my thoughts:
(1) Add the minimal changes to fix the build errors.
(2) Submit other more patches step by step to make
the basic command "run", "breakpoint", "next" ...
can be used to debug, single patch or patch series.
(3) Add more code to make more commands work well.

Oct 25 2022, 5:16 AM · Restricted Project, Restricted Project
DavidSpickett accepted D136674: [LLDB] Fix RISCV build.

Thanks! Apologies (I missed a few x86 ones at the time too).

Oct 25 2022, 5:10 AM · Restricted Project, Restricted Project
DavidSpickett committed rG3d9bf8ce7bdf: [LLDB] Add missing breaks to current frame row in command map (authored by DavidSpickett).
[LLDB] Add missing breaks to current frame row in command map
Oct 25 2022, 3:20 AM · Restricted Project
DavidSpickett added inline comments to D135622: [lldb] Add a "diagnostics dump" command.
Oct 25 2022, 2:54 AM · Restricted Project, Restricted Project
DavidSpickett accepted D136578: [LLDB] [LoongArch] Add minimal LoongArch support.

This LGTM from the lldb side.

Oct 25 2022, 2:19 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D136465: Make remote-android local ports configurable.

Yes, somehow, and yes just update again.

Oct 25 2022, 2:11 AM · Restricted Project, Restricted Project

Oct 24 2022

DavidSpickett added a comment to D136462: [LLDB] Add color to output text when searching for symbols.

And if it helps to refactor in parent patches to make this change easier, go for it. Maybe you add generic colouring support to something, then the last patch hooks it up to the symbol lookup, something along those lines.

Oct 24 2022, 3:37 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D136462: [LLDB] Add color to output text when searching for symbols.

I agree that this change names - print - restore names is going to cause problems. Pavel is right that this should happen in some dump function somewhere.

Oct 24 2022, 3:35 AM · Restricted Project, Restricted Project
DavidSpickett committed rG8d06ef565818: [LLDB] Check that RegisterInfo and ContextInfo are trivial (authored by DavidSpickett).
[LLDB] Check that RegisterInfo and ContextInfo are trivial
Oct 24 2022, 3:16 AM · Restricted Project
DavidSpickett closed D136584: [LLDB] Check that RegisterInfo and ContextInfo are trivial.
Oct 24 2022, 3:16 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D136578: [LLDB] [LoongArch] Add minimal LoongArch support: DavidSpickett.
Oct 24 2022, 3:15 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D136578: [LLDB] [LoongArch] Add minimal LoongArch support.

What's more, AFAIK, @seehearfeel (yangtiezhu@loongson.cn) is the LoongArch port maintainer of gdb.
Regarding the public buildbot, I'm trying to set it up and maybe we can see it in one or two weeks.

Oct 24 2022, 3:15 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D136578: [LLDB] [LoongArch] Add minimal LoongArch support.

Always good to see another architecture in lldb.

Oct 24 2022, 2:12 AM · Restricted Project, Restricted Project