Page MenuHomePhabricator
Feed Advanced Search

Fri, Jul 30

DavidSpickett requested review of D107172: Revert "[libcxx][CI] Work around Arm buildkite failures".
Fri, Jul 30, 8:37 AM · Restricted Project
DavidSpickett added a reverting change for D105704: [libcxx][CI] Work around Arm buildkite failures: D107172: Revert "[libcxx][CI] Work around Arm buildkite failures".
Fri, Jul 30, 8:37 AM · Restricted Project
DavidSpickett added a reverting change for rGf8bef4734845: [libcxx][CI] Work around Arm buildkite failures: D107172: Revert "[libcxx][CI] Work around Arm buildkite failures".
Fri, Jul 30, 8:37 AM
DavidSpickett added a comment to D103368: [libc++][format] Adds parser std-format-spec..

Apologies for the AArch64 test timeout. There are some issues on our end that I'm currently working on.

Fri, Jul 30, 8:12 AM · Restricted Project
DavidSpickett abandoned D107056: <Testing new libcxx bot machines, do not commit>.
Fri, Jul 30, 8:10 AM · Restricted Project
DavidSpickett planned changes to D107056: <Testing new libcxx bot machines, do not commit>.
Fri, Jul 30, 6:40 AM · Restricted Project
DavidSpickett updated the diff for D107056: <Testing new libcxx bot machines, do not commit>.

Set off a new buildkite build.

Fri, Jul 30, 6:00 AM · Restricted Project
DavidSpickett reclaimed D107056: <Testing new libcxx bot machines, do not commit>.
Fri, Jul 30, 5:58 AM · Restricted Project
DavidSpickett committed rG98b5659b53ff: [lldb][AArch64] Mark mismatched tags in tag read output (authored by DavidSpickett).
[lldb][AArch64] Mark mismatched tags in tag read output
Fri, Jul 30, 3:48 AM
DavidSpickett closed D106880: [lldb][AArch64] Mark mismatched tags in tag read output.
Fri, Jul 30, 3:48 AM · Restricted Project
DavidSpickett added a comment to D103368: [libc++][format] Adds parser std-format-spec..

Apologies for the AArch64 test timeout. There are some issues on our end that I'm currently working on.

Fri, Jul 30, 3:09 AM · Restricted Project
DavidSpickett committed rG555cd03193c9: [lldb] Correct format of qMemTags type field (authored by DavidSpickett).
[lldb] Correct format of qMemTags type field
Fri, Jul 30, 3:07 AM
DavidSpickett closed D104914: [lldb] Correct format of qMemTags type field.
Fri, Jul 30, 3:07 AM · Restricted Project
DavidSpickett added a comment to D107140: [lldb] Show memory tags in memory read output.

Also Omair we talked about 13 backports to get MTE support to a good place. This is one that I think would be ok to not do so, given that tag reading can be done manually as needed and it has some complexity to be considered.

Fri, Jul 30, 2:35 AM · Restricted Project
DavidSpickett added reviewers for D107140: [lldb] Show memory tags in memory read output: omjavaid, pcc.

DumpDataExtractor has formatting unittests. Due to memory tags being read from the execution context there are no new unittests. (the existing ones pass)

Fri, Jul 30, 2:33 AM · Restricted Project
DavidSpickett requested review of D107140: [lldb] Show memory tags in memory read output.
Fri, Jul 30, 2:25 AM · Restricted Project
DavidSpickett abandoned D107056: <Testing new libcxx bot machines, do not commit>.
Fri, Jul 30, 1:11 AM · Restricted Project

Thu, Jul 29

DavidSpickett updated the diff for D106880: [lldb][AArch64] Mark mismatched tags in tag read output.

Rebase

Thu, Jul 29, 8:34 AM · Restricted Project
DavidSpickett added inline comments to D107079: [lldb] Change the log format to JSON instead of plain text.
Thu, Jul 29, 8:22 AM · Restricted Project
DavidSpickett added a comment to D107079: [lldb] Change the log format to JSON instead of plain text.

With the added channels in each message we could just do the filtering on our side and tell people to just enable every channel in every category.

Thu, Jul 29, 8:20 AM · Restricted Project
DavidSpickett planned changes to D107056: <Testing new libcxx bot machines, do not commit>.
Thu, Jul 29, 4:42 AM · Restricted Project
DavidSpickett requested review of D107056: <Testing new libcxx bot machines, do not commit>.
Thu, Jul 29, 4:41 AM · Restricted Project
DavidSpickett added a comment to D106943: [AArch64][SVE] Fix incorrect mask type when lowering fixed type SVE gather/scatter.

This fixes the 2 stage build and my reproducer. Thanks again!

Thu, Jul 29, 3:26 AM · Restricted Project
DavidSpickett committed rGd510b5f199d6: [lldb][AArch64] Annotate synchronous tag faults (authored by DavidSpickett).
[lldb][AArch64] Annotate synchronous tag faults
Thu, Jul 29, 2:26 AM
DavidSpickett closed D105178: [lldb][AArch64] Annotate synchronous tag faults.
Thu, Jul 29, 2:26 AM · Restricted Project

Wed, Jul 28

DavidSpickett updated the diff for D103626: [lldb][AArch64] Remove non address bits from memory read arguments.

Rebase onto main.

Wed, Jul 28, 7:51 AM · Restricted Project
DavidSpickett updated the diff for D102757: [lldb] Remove non address bits when looking up memory regions.
  • Rebase onto main
  • Add DoGetMemoryRegionInfo for ScriptedProcess
Wed, Jul 28, 7:50 AM · Restricted Project
DavidSpickett updated the summary of D104914: [lldb] Correct format of qMemTags type field.
Wed, Jul 28, 7:00 AM · Restricted Project
DavidSpickett updated the diff for D104914: [lldb] Correct format of qMemTags type field.
  • Rebase onto main
  • Update the way we cast down to int32_t to avoid use of static_cast.
Wed, Jul 28, 7:00 AM · Restricted Project
DavidSpickett committed rG6eded00e0c6b: [lldb] Add "memory tag write" --end-addr option (authored by DavidSpickett).
[lldb] Add "memory tag write" --end-addr option
Wed, Jul 28, 6:06 AM
DavidSpickett closed D105183: [lldb] Add "memory tag write" --end-addr option.
Wed, Jul 28, 6:05 AM · Restricted Project
DavidSpickett updated subscribers of rG4fd42e2e803d: [libcxx] Bump __libcpp_version to 14 after branch.

@ldionne FYI. With this all the things in the "Post-release check list" are accounted for so I figured it was obvious enough to commit without review.

Wed, Jul 28, 4:12 AM
DavidSpickett committed rG4fd42e2e803d: [libcxx] Bump __libcpp_version to 14 after branch (authored by DavidSpickett).
[libcxx] Bump __libcpp_version to 14 after branch
Wed, Jul 28, 4:10 AM
DavidSpickett committed rG6a7a2ee8161d: [lldb] Add "memory tag write" command (authored by DavidSpickett).
[lldb] Add "memory tag write" command
Wed, Jul 28, 2:13 AM
DavidSpickett closed D105182: [lldb] Add "memory tag write" command.
Wed, Jul 28, 2:12 AM · Restricted Project

Tue, Jul 27

DavidSpickett updated the diff for D105182: [lldb] Add "memory tag write" command.

Add a link to intrinsics documentation in the test file.

Tue, Jul 27, 9:00 AM · Restricted Project
DavidSpickett added a reviewer for D106880: [lldb][AArch64] Mark mismatched tags in tag read output: omjavaid.

This gives us the equivalent of GDB's "mtag check" but with some more flexibility and no extra command.

Tue, Jul 27, 8:24 AM · Restricted Project
DavidSpickett requested review of D106880: [lldb][AArch64] Mark mismatched tags in tag read output.
Tue, Jul 27, 8:21 AM · Restricted Project
DavidSpickett committed rG5ea091a8174b: [lldb][AArch64] Add memory tag writing to lldb (authored by DavidSpickett).
[lldb][AArch64] Add memory tag writing to lldb
Tue, Jul 27, 7:19 AM
DavidSpickett closed D105181: [lldb][AArch64] Add memory tag writing to lldb.
Tue, Jul 27, 7:18 AM · Restricted Project
DavidSpickett added a reverting change for rZORG24c07902d058: Remove aarch64-sve-vector-bits-min compile flag from SVE 2 stage bot: rZORGcd75632349bb: Revert "Remove aarch64-sve-vector-bits-min compile flag from SVE 2 stage bot".
Tue, Jul 27, 4:43 AM
DavidSpickett committed rZORGcd75632349bb: Revert "Remove aarch64-sve-vector-bits-min compile flag from SVE 2 stage bot" (authored by DavidSpickett).
Revert "Remove aarch64-sve-vector-bits-min compile flag from SVE 2 stage bot"
Tue, Jul 27, 4:43 AM
DavidSpickett committed rG7d27230de333: [lldb][AArch64] Add memory tag writing to lldb-server (authored by DavidSpickett).
[lldb][AArch64] Add memory tag writing to lldb-server
Tue, Jul 27, 4:02 AM
DavidSpickett closed D105180: [lldb][AArch64] Add memory tag writing to lldb-server.
Tue, Jul 27, 4:02 AM · Restricted Project
DavidSpickett added a comment to D105180: [lldb][AArch64] Add memory tag writing to lldb-server.

The QEMU testing docs https://lldb.llvm.org/use/qemu-testing.html include MTE options. Apart from having a compatible toolchain there's no difference to SVE.

Tue, Jul 27, 1:46 AM · Restricted Project

Mon, Jul 26

DavidSpickett committed rZORG0b9e49366d6c: Add missing closing quote to SVE 2 stage cmake options (authored by DavidSpickett).
Add missing closing quote to SVE 2 stage cmake options
Mon, Jul 26, 1:28 AM

Fri, Jul 23

DavidSpickett committed rZORG24c07902d058: Remove aarch64-sve-vector-bits-min compile flag from SVE 2 stage bot (authored by DavidSpickett).
Remove aarch64-sve-vector-bits-min compile flag from SVE 2 stage bot
Fri, Jul 23, 8:43 AM
DavidSpickett added a comment to D105817: [LV] Enable vectorization of multiple exit loops w/computable exit counts.

Oh and I'll update the bot to workaround this issue until we can find the cause.

Fri, Jul 23, 8:41 AM · Restricted Project
DavidSpickett added a comment to D105817: [LV] Enable vectorization of multiple exit loops w/computable exit counts.

Does setting that flag change the number of loops which get vectorizer? If not, it must change *how* they get vectorized.

Fri, Jul 23, 8:24 AM · Restricted Project
DavidSpickett added inline comments to D105180: [lldb][AArch64] Add memory tag writing to lldb-server.
Fri, Jul 23, 6:53 AM · Restricted Project

Thu, Jul 22

DavidSpickett added a comment to D105817: [LV] Enable vectorization of multiple exit loops w/computable exit counts.

@reames This commit has broken our 2 stage A64FX SVE bot. (sorry for the late report, took me a while to bisect it)

Thu, Jul 22, 7:32 AM · Restricted Project

Wed, Jul 21

DavidSpickett added a comment to D103986: [PowerPC] Floating Point Builtins for XL Compat..

You missed a REQUIRES for the llvm test, I added one in: https://reviews.llvm.org/rG2404834c206a8930b0c420d94f4941b31c355de5

Wed, Jul 21, 7:21 AM · Restricted Project, Restricted Project
DavidSpickett committed rG2404834c206a: [PowerPC] Require power-pc target for new builtin test (authored by DavidSpickett).
[PowerPC] Require power-pc target for new builtin test
Wed, Jul 21, 7:20 AM
DavidSpickett added a comment to D105669: [NFC][compiler-rt][hwasan] Move __hwasan_tag_mismatch4 to hwasan.cpp.

@leonardchan Sorry for the late report, took us some time to get to this but - this caused a test failure on Linaro's AArch64 bots.

Wed, Jul 21, 5:48 AM · Restricted Project
DavidSpickett committed rGbb4f7b916661: [compiler-rt][hwasan] Update register-dump-read.c test (authored by DavidSpickett).
[compiler-rt][hwasan] Update register-dump-read.c test
Wed, Jul 21, 5:44 AM
DavidSpickett added a comment to D106170: [flang] Runtime API for data pointers.

Bots are green.

Wed, Jul 21, 1:33 AM · Restricted Project, Restricted Project

Tue, Jul 20

DavidSpickett added a comment to D106234: [PowerPC] Fallback to base's implementation of shouldExpandAtomicCmpXchgInIR and shouldExpandAtomicCmpXchgInIR.

Thanks, bot is green again. https://lab.llvm.org/buildbot/#/builders/188/builds/1143

Tue, Jul 20, 2:28 AM · Restricted Project
DavidSpickett added a comment to D106170: [flang] Runtime API for data pointers.

This change has broken the flang build on our latest-gcc bot:
https://lab.llvm.org/buildbot/#/builders/160/builds/3224

Tue, Jul 20, 2:19 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D106234: [PowerPC] Fallback to base's implementation of shouldExpandAtomicCmpXchgInIR and shouldExpandAtomicCmpXchgInIR.

Now I posted the comment I see someone else reported it. I'll leave it up to you then to prevent any confusion.

Tue, Jul 20, 2:04 AM · Restricted Project
DavidSpickett added a comment to D106234: [PowerPC] Fallback to base's implementation of shouldExpandAtomicCmpXchgInIR and shouldExpandAtomicCmpXchgInIR.

One of these tests is failing on Arm bots: https://lab.llvm.org/buildbot/#/builders/171/builds/1162

Tue, Jul 20, 2:03 AM · Restricted Project

Mon, Jul 19

DavidSpickett added a comment to D106281: Disable benchmark tests on iOS.

Based on https://cmake.org/cmake/help/latest/command/option.html this should work fine.

Mon, Jul 19, 8:24 AM
DavidSpickett committed rG3d5c1a817381: [compiler-rt][GWP-ASAN] Disable 2 tests on Armv7 Linux (authored by DavidSpickett).
[compiler-rt][GWP-ASAN] Disable 2 tests on Armv7 Linux
Mon, Jul 19, 3:45 AM
DavidSpickett added a comment to D106192: [LLDB][GUI] Add Create Target form.

This doesn't support remote files yet, I am still having trouble testing those.

Mon, Jul 19, 2:23 AM · Restricted Project
DavidSpickett added a comment to D106155: Reland "[benchmark] Re-enable building benchmark tests".

The error comes from gtest-port.cc which does #import <Foundation/Foundation.h>. Is it possible there is some C++/Objective C mixing issue here and we need to add some a flag or build option? (though if #import works at all it must have some understanding)

Mon, Jul 19, 2:06 AM
DavidSpickett added a reviewer for D106226: [lldb] Improve error message when "lldb attach" fails: DavidSpickett.
Mon, Jul 19, 1:53 AM · Restricted Project
DavidSpickett added a comment to D106226: [lldb] Improve error message when "lldb attach" fails.

Thanks for looking at this, I've been tripped up by this myself.

Mon, Jul 19, 1:52 AM · Restricted Project

Fri, Jul 16

DavidSpickett committed rTdb5544472372: Reland "[benchmark] Re-enable building benchmark tests" (authored by DavidSpickett).
Reland "[benchmark] Re-enable building benchmark tests"
Fri, Jul 16, 8:22 AM
DavidSpickett added a reverting change for rTf6b04890c21a: Revert "[benchmark] Re-enable building benchmark tests": rTdb5544472372: Reland "[benchmark] Re-enable building benchmark tests".
Fri, Jul 16, 8:22 AM
DavidSpickett closed D106155: Reland "[benchmark] Re-enable building benchmark tests".
Fri, Jul 16, 8:22 AM
DavidSpickett added inline comments to D106155: Reland "[benchmark] Re-enable building benchmark tests".
Fri, Jul 16, 8:21 AM
DavidSpickett retitled D106155: Reland "[benchmark] Re-enable building benchmark tests" from Reland "[benchmark] Re-enable building benchmark tests"" to Reland "[benchmark] Re-enable building benchmark tests".
Fri, Jul 16, 8:19 AM
DavidSpickett added inline comments to D106155: Reland "[benchmark] Re-enable building benchmark tests".
Fri, Jul 16, 8:15 AM
DavidSpickett added a comment to D106155: Reland "[benchmark] Re-enable building benchmark tests".

This seems logical to me but putting in review just in case you had other goals with this change. Test suite passes on AArch64 with this and I see MicroBenchmark mentions in the results so I assume it's doing the right thing.

Fri, Jul 16, 8:13 AM
DavidSpickett added a comment to D105361: [benchmark] Re-enable building benchmark tests.

Fix for review: https://reviews.llvm.org/D106155

Fri, Jul 16, 8:11 AM
DavidSpickett added a reviewer for D106155: Reland "[benchmark] Re-enable building benchmark tests": mtrofin.
Fri, Jul 16, 8:11 AM
DavidSpickett requested review of D106155: Reland "[benchmark] Re-enable building benchmark tests".
Fri, Jul 16, 8:10 AM
DavidSpickett added a reverting change for rTf6b04890c21a: Revert "[benchmark] Re-enable building benchmark tests": D106155: Reland "[benchmark] Re-enable building benchmark tests".
Fri, Jul 16, 8:10 AM
DavidSpickett committed rGadee89f8bcd1: [lldb][AArch64] Add tag packing and repetition memory tag manager (authored by DavidSpickett).
[lldb][AArch64] Add tag packing and repetition memory tag manager
Fri, Jul 16, 6:21 AM
DavidSpickett closed D105179: [lldb][AArch64] Add tag packing and repetition memory tag manager.
Fri, Jul 16, 6:21 AM · Restricted Project
DavidSpickett updated the diff for D105178: [lldb][AArch64] Annotate synchronous tag faults.

Correct potentitally -> potentially.

Fri, Jul 16, 3:59 AM · Restricted Project
DavidSpickett updated the diff for D105178: [lldb][AArch64] Annotate synchronous tag faults.

Account for fault addresses not being granule aligned by asking
for fault_addr to fault_addr+1 which always gives you 1 tag back.
(same trick we do in "memory tag read" if we only have a start address)

Fri, Jul 16, 3:57 AM · Restricted Project
DavidSpickett added a reviewer for D102428: [StopInfoMachException] Summarize arm64e BLRAx/LDRAx auth failures: omjavaid.

Apologies, I missed the ping. A couple of minor comments otherwise this looks good to me.

Fri, Jul 16, 3:36 AM · Restricted Project
DavidSpickett committed rGd046fb62b7e7: [lldb][AArch64] Refactor memory tag range handling (authored by DavidSpickett).
[lldb][AArch64] Refactor memory tag range handling
Fri, Jul 16, 3:02 AM
DavidSpickett closed D105630: [lldb][AArch64] Refactor memory tag range handling.
Fri, Jul 16, 3:02 AM · Restricted Project
DavidSpickett added a comment to D105361: [benchmark] Re-enable building benchmark tests.

I've reverted this (https://github.com/llvm/llvm-test-suite/commit/f6b04890c21ac634fcba6075017ec1487a85e132) as it's causing cmake to fail on all of the Linaro bots running the test suite.

Fri, Jul 16, 1:46 AM
DavidSpickett added a reverting change for rTc9eda518d5f9: [benchmark] Re-enable building benchmark tests: rTf6b04890c21a: Revert "[benchmark] Re-enable building benchmark tests".
Fri, Jul 16, 1:44 AM
DavidSpickett added a reverting change for D105361: [benchmark] Re-enable building benchmark tests: rTf6b04890c21a: Revert "[benchmark] Re-enable building benchmark tests".
Fri, Jul 16, 1:44 AM
DavidSpickett committed rTf6b04890c21a: Revert "[benchmark] Re-enable building benchmark tests" (authored by DavidSpickett).
Revert "[benchmark] Re-enable building benchmark tests"
Fri, Jul 16, 1:44 AM

Thu, Jul 15

DavidSpickett updated the diff for D105630: [lldb][AArch64] Refactor memory tag range handling.

Update comment about save/restoring end of range.

Thu, Jul 15, 8:21 AM · Restricted Project
DavidSpickett updated the diff for D105183: [lldb] Add "memory tag write" --end-addr option.

Rebase

Thu, Jul 15, 8:19 AM · Restricted Project
DavidSpickett updated the diff for D105182: [lldb] Add "memory tag write" command.

Rebase

Thu, Jul 15, 8:19 AM · Restricted Project
DavidSpickett updated the diff for D105181: [lldb][AArch64] Add memory tag writing to lldb.

Rebase, update use of SendPacketAndWaitForResponse.

Thu, Jul 15, 8:19 AM · Restricted Project
DavidSpickett updated the diff for D105180: [lldb][AArch64] Add memory tag writing to lldb-server.

Rebase

Thu, Jul 15, 8:18 AM · Restricted Project
DavidSpickett updated the diff for D105179: [lldb][AArch64] Add tag packing and repetition memory tag manager.

Rebase, correct the commit title and printf formatters for 32 bit build.

Thu, Jul 15, 8:17 AM · Restricted Project
DavidSpickett updated the diff for D105630: [lldb][AArch64] Refactor memory tag range handling.

Rebase and correct printf formatting to fix 32 bit test issues.

Thu, Jul 15, 8:16 AM · Restricted Project
DavidSpickett updated the diff for D105178: [lldb][AArch64] Annotate synchronous tag faults.

Rebase

Thu, Jul 15, 8:16 AM · Restricted Project
DavidSpickett retitled D105179: [lldb][AArch64] Add tag packing and repetition memory tag manager from [lldb][AArch64] Add tag repeat and unpack to memory tag manager to [lldb][AArch64] Add tag packing and repetition memory tag manager.
Thu, Jul 15, 7:53 AM · Restricted Project
DavidSpickett accepted D106052: [flang][driver] Randomise the names of the temporary unparsed files.

LGTM

Thu, Jul 15, 7:48 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D106052: [flang][driver] Randomise the names of the temporary unparsed files.
Thu, Jul 15, 6:30 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D106052: [flang][driver] Randomise the names of the temporary unparsed files.
Thu, Jul 15, 6:24 AM · Restricted Project, Restricted Project