Page MenuHomePhabricator
Feed Advanced Search

Feb 6 2020

DavidSpickett added inline comments to D74120: [ARM][ASMParser] Refuse equal RdHi/RdLo for s/umlal, smlsl, s/umull, umaal.
Feb 6 2020, 5:23 AM · Restricted Project
DavidSpickett edited reviewers for D74120: [ARM][ASMParser] Refuse equal RdHi/RdLo for s/umlal, smlsl, s/umull, umaal, added: dmgreen; removed: greened.
Feb 6 2020, 5:05 AM · Restricted Project
DavidSpickett accepted D74118: [Target][AArch64] Remove non-existing system registers ICH_VSEIR_EL2 & ICC_SEIEN_EL1 from AArch64 backend.

No references to these registers in the current ARMARM document, LGTM.

Feb 6 2020, 4:30 AM · Restricted Project

Feb 5 2020

DavidSpickett added a comment to D73469: [ARM][AsmParser] Make assembly directives case insensitive.

Posted http://lists.llvm.org/pipermail/llvm-dev/2020-February/138937.html if you want to comment there.

Feb 5 2020, 3:06 AM · Restricted Project
DavidSpickett added a comment to D73469: [ARM][AsmParser] Make assembly directives case insensitive.

The rationale is that the case of a directive has never really been important even though we'd reject anything that isn't lower case. I looked at all the targets in LLVM and none of them specify anything that isn't all lower case (though nothing in the code prevents them from doing so). All the targets GCC supports will accept any case also, though they may document with a set format.

Feb 5 2020, 1:44 AM · Restricted Project

Feb 4 2020

DavidSpickett committed rGa05566c99419: [ARM] Correct missing newline after outputting .tlsdescseq directive. (authored by DavidSpickett).
[ARM] Correct missing newline after outputting .tlsdescseq directive.
Feb 4 2020, 9:44 AM
DavidSpickett closed D73972: [ARM] Correct missing newline after outputting .tlsdescseq directive..
Feb 4 2020, 9:44 AM · Restricted Project
DavidSpickett updated the summary of D73469: [ARM][AsmParser] Make assembly directives case insensitive.
Feb 4 2020, 9:17 AM · Restricted Project
DavidSpickett added a comment to D73469: [ARM][AsmParser] Make assembly directives case insensitive.

Posted https://reviews.llvm.org/D73972 as a new change for the ".tlsdescseq" directive.

Feb 4 2020, 9:17 AM · Restricted Project
DavidSpickett created D73972: [ARM] Correct missing newline after outputting .tlsdescseq directive..
Feb 4 2020, 9:17 AM · Restricted Project
DavidSpickett added a parent revision for D73972: [ARM] Correct missing newline after outputting .tlsdescseq directive.: D73469: [ARM][AsmParser] Make assembly directives case insensitive.
Feb 4 2020, 9:17 AM · Restricted Project
DavidSpickett added a child revision for D73469: [ARM][AsmParser] Make assembly directives case insensitive: D73972: [ARM] Correct missing newline after outputting .tlsdescseq directive..
Feb 4 2020, 9:17 AM · Restricted Project
DavidSpickett committed rG95c95a94d7a6: [ARM][AsmParser] Make assembly directives case insensitive (authored by DavidSpickett).
[ARM][AsmParser] Make assembly directives case insensitive
Feb 4 2020, 8:40 AM
DavidSpickett closed D73469: [ARM][AsmParser] Make assembly directives case insensitive.
Feb 4 2020, 8:40 AM · Restricted Project

Jan 27 2020

DavidSpickett edited reviewers for D73469: [ARM][AsmParser] Make assembly directives case insensitive, added: ostannard; removed: olista01.
Jan 27 2020, 6:12 AM · Restricted Project
DavidSpickett added a parent revision for D73469: [ARM][AsmParser] Make assembly directives case insensitive: D72686: [AsmParser] Make generic directives and aliases case insensitive..
Jan 27 2020, 6:03 AM · Restricted Project
DavidSpickett added a child revision for D72686: [AsmParser] Make generic directives and aliases case insensitive.: D73469: [ARM][AsmParser] Make assembly directives case insensitive.
Jan 27 2020, 6:03 AM · Restricted Project
DavidSpickett updated subscribers of rG37fb3b33637b: [AsmParser] Make generic directives and aliases case insensitive..

@grosbach I've not seen this "requires audit" before. Did the change cause a problem/do you need any actions from me on this?

Jan 27 2020, 6:03 AM
DavidSpickett created D73469: [ARM][AsmParser] Make assembly directives case insensitive.
Jan 27 2020, 5:56 AM · Restricted Project

Jan 20 2020

DavidSpickett committed rG952a540b2199: [test] On Mac, don't try to use result of sysctl command if calling it failed. (authored by DavidSpickett).
[test] On Mac, don't try to use result of sysctl command if calling it failed.
Jan 20 2020, 2:07 AM
DavidSpickett closed D72278: [test] On Mac, don't try to use result of sysctl command if calling it failed..
Jan 20 2020, 2:07 AM · Restricted Project

Jan 17 2020

DavidSpickett committed rG398dc06ad015: [AArch64] Make AArch64 specific assembly directives case insensitive (authored by DavidSpickett).
[AArch64] Make AArch64 specific assembly directives case insensitive
Jan 17 2020, 8:25 AM
DavidSpickett closed D72923: [AArch64] Make AArch64 specific assembly directives case insensitive.
Jan 17 2020, 8:25 AM · Restricted Project
DavidSpickett created D72923: [AArch64] Make AArch64 specific assembly directives case insensitive.
Jan 17 2020, 6:59 AM · Restricted Project
DavidSpickett committed rG37fb3b33637b: [AsmParser] Make generic directives and aliases case insensitive. (authored by DavidSpickett).
[AsmParser] Make generic directives and aliases case insensitive.
Jan 17 2020, 3:11 AM
DavidSpickett closed D72686: [AsmParser] Make generic directives and aliases case insensitive..
Jan 17 2020, 3:11 AM · Restricted Project
DavidSpickett updated the diff for D72686: [AsmParser] Make generic directives and aliases case insensitive..

Added a comment to init directive map saying that they should all be lower case.
Switched to a generic x86 target and alias for the lit test, to match the other MC/AsmParser tests.

Jan 17 2020, 1:39 AM · Restricted Project
DavidSpickett added a comment to D72278: [test] On Mac, don't try to use result of sysctl command if calling it failed..

ping, @cmatthews does the updated diff look good to you?

Jan 17 2020, 12:55 AM · Restricted Project

Jan 15 2020

DavidSpickett added a comment to D72686: [AsmParser] Make generic directives and aliases case insensitive..

This suggests that there are exceptions, do you which targets and directives don't follow this?

Jan 15 2020, 2:10 AM · Restricted Project
DavidSpickett added inline comments to D72686: [AsmParser] Make generic directives and aliases case insensitive..
Jan 15 2020, 1:14 AM · Restricted Project

Jan 14 2020

DavidSpickett added reviewers for D72686: [AsmParser] Make generic directives and aliases case insensitive.: eliben, grosbach.
Jan 14 2020, 2:04 AM · Restricted Project
DavidSpickett added a comment to D72686: [AsmParser] Make generic directives and aliases case insensitive..

Direct link to Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=39527

Jan 14 2020, 2:00 AM · Restricted Project
DavidSpickett created D72686: [AsmParser] Make generic directives and aliases case insensitive..
Jan 14 2020, 2:00 AM · Restricted Project

Jan 13 2020

DavidSpickett updated the diff for D72278: [test] On Mac, don't try to use result of sysctl command if calling it failed..

Turns out I didn't have /usr/sbin on my PATH (due to some machine hopping).

Jan 13 2020, 5:48 AM · Restricted Project

Jan 9 2020

DavidSpickett added a reviewer for D72278: [test] On Mac, don't try to use result of sysctl command if calling it failed.: cmatthews.
Jan 9 2020, 2:44 AM · Restricted Project

Jan 6 2020

DavidSpickett added a comment to D72278: [test] On Mac, don't try to use result of sysctl command if calling it failed..

I found this running lit tests on a Mac that doesn't have sysctl available. Not very familiar with it so I'm not sure why that is the case for our particular machine.

Jan 6 2020, 8:31 AM · Restricted Project
DavidSpickett created D72278: [test] On Mac, don't try to use result of sysctl command if calling it failed..
Jan 6 2020, 8:31 AM · Restricted Project

Dec 20 2019

DavidSpickett added a comment to D71705: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats.

Failure was unrelated, re-landed as 0ca9d2fd39264054501927ba6d3c5330159458d7.

Dec 20 2019, 2:15 AM · Restricted Project
DavidSpickett committed rG0ca9d2fd3926: Re-land "[cmake] Add dependency on llvm-dwarfdump to llvm-locstats" (authored by DavidSpickett).
Re-land "[cmake] Add dependency on llvm-dwarfdump to llvm-locstats"
Dec 20 2019, 1:15 AM
DavidSpickett added a reverting change for rGf8e2ab3cd347: Revert "[cmake] Add dependency on llvm-dwarfdump to llvm-locstats": rG0ca9d2fd3926: Re-land "[cmake] Add dependency on llvm-dwarfdump to llvm-locstats".
Dec 20 2019, 1:15 AM

Dec 19 2019

DavidSpickett committed rGf8e2ab3cd347: Revert "[cmake] Add dependency on llvm-dwarfdump to llvm-locstats" (authored by DavidSpickett).
Revert "[cmake] Add dependency on llvm-dwarfdump to llvm-locstats"
Dec 19 2019, 9:23 AM
DavidSpickett added a reverting change for rGba430f503244: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats: rGf8e2ab3cd347: Revert "[cmake] Add dependency on llvm-dwarfdump to llvm-locstats".
Dec 19 2019, 9:23 AM
DavidSpickett added a comment to D71705: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats.

Have reverted due to failure on lld-x86_64-ubuntu-fast buildbot, will investigate and re-land.

Dec 19 2019, 9:23 AM · Restricted Project
DavidSpickett committed rGba430f503244: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats (authored by DavidSpickett).
[cmake] Add dependency on llvm-dwarfdump to llvm-locstats
Dec 19 2019, 8:42 AM
DavidSpickett closed D71705: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats.
Dec 19 2019, 8:41 AM · Restricted Project
DavidSpickett added a child revision for D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built.: D71705: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats.
Dec 19 2019, 7:52 AM · Restricted Project
DavidSpickett added a parent revision for D71705: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats: D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..
Dec 19 2019, 7:52 AM · Restricted Project
DavidSpickett added a comment to D71705: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats.

Please make sure the tool name is llvm-locstats instead of llvm-covstat.

Dec 19 2019, 7:52 AM · Restricted Project
DavidSpickett updated the diff for D71705: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats.
Dec 19 2019, 7:52 AM · Restricted Project
DavidSpickett added a comment to D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..

Posted: https://reviews.llvm.org/D71705 to make that change.

Dec 19 2019, 7:13 AM · Restricted Project
DavidSpickett created D71705: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats.
Dec 19 2019, 7:13 AM · Restricted Project
DavidSpickett added a reviewer for D71705: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats: dstenb.
Dec 19 2019, 7:13 AM · Restricted Project
DavidSpickett added a comment to D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..

That looks good to me and it works for our use case.

Dec 19 2019, 6:53 AM · Restricted Project
DavidSpickett added a comment to D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..

Ah I see. Well, I think the build target existing even if it's not added to "all" is fine. Which is what BUILD_TOOLS controls:

macro(add_llvm_tool name)
  if( NOT LLVM_BUILD_TOOLS )
    set(EXCLUDE_FROM_ALL ON)
  endif()
Dec 19 2019, 3:33 AM · Restricted Project
DavidSpickett added a comment to D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..

Sorry for the confusion. May be the llvm/CMakeLists.txt is better place to address this?

llvm/CMakeLists.txt:

if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS)
  add_subdirectory(utils/llvm-locstats)
endif()
Dec 19 2019, 2:59 AM · Restricted Project
DavidSpickett added a comment to D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..

The llvm-dwarfdump tool target will still be there. Unless that also has this BUILD vs INCLUDE issue.

Dec 19 2019, 2:54 AM · Restricted Project
DavidSpickett committed rG119cd70322af: [cmake] Include the llvm-locstats target when utils and tools are not being… (authored by DavidSpickett).
[cmake] Include the llvm-locstats target when utils and tools are not being…
Dec 19 2019, 2:45 AM
DavidSpickett closed D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..
Dec 19 2019, 2:45 AM · Restricted Project
DavidSpickett added a comment to D71611: [cmake] Add llvm-locstats to LLVM_TEST_DEPENDS.

No that's fine, no change needed. I think you just uncovered an issue with the way llvm-locstats was defined (or not as the case was).

Dec 19 2019, 2:45 AM · Restricted Project
DavidSpickett added a comment to D71611: [cmake] Add llvm-locstats to LLVM_TEST_DEPENDS.

Posted a fix here: https://reviews.llvm.org/D71695

Dec 19 2019, 2:30 AM · Restricted Project
DavidSpickett created D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..
Dec 19 2019, 2:30 AM · Restricted Project
DavidSpickett added a comment to D71611: [cmake] Add llvm-locstats to LLVM_TEST_DEPENDS.

How is this change supposed to interact with LLVM_BUILD_TOOLS?
"LLVM_BUILD_TOOLS: Build the LLVM tools. If OFF, just generate build targets."

Dec 19 2019, 1:43 AM · Restricted Project

Nov 4 2019

DavidSpickett committed rG91167e22eca5: [hwasan] Remove lazy thread-initialisation (authored by DavidSpickett).
[hwasan] Remove lazy thread-initialisation
Nov 4 2019, 3:20 AM
DavidSpickett closed D69574: Remove lazy thread-initialisation.
Nov 4 2019, 3:20 AM · Restricted Project, Restricted Project, Restricted Project

Sep 17 2019

DavidSpickett committed rL372131: Request commit access for davidspickett..
Request commit access for davidspickett.
Sep 17 2019, 8:19 AM

Aug 21 2019

DavidSpickett committed rGe2b200b7bfa1: [libcxx] Only declare contents of threading API when… (authored by DavidSpickett).
[libcxx] Only declare contents of threading API when…
Aug 21 2019, 8:39 AM
DavidSpickett committed rL369537: [libcxx] Only declare contents of threading API when.
[libcxx] Only declare contents of threading API when
Aug 21 2019, 8:38 AM
DavidSpickett closed D66518: [libcxx] Only declare contents of threading API when _LIBCPP_HAS_THREAD_API_EXTERNAL is not defined..
Aug 21 2019, 8:38 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D66518: [libcxx] Only declare contents of threading API when _LIBCPP_HAS_THREAD_API_EXTERNAL is not defined..

Addressed Michael's comment by not moving the initial:
#endif // defined(_LIBCPP_HAS_THREAD_API_PTHREAD)

Aug 21 2019, 7:55 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D66518: [libcxx] Only declare contents of threading API when _LIBCPP_HAS_THREAD_API_EXTERNAL is not defined.: michaelplatings.
Aug 21 2019, 2:32 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D66480: Fix unavailability of __thread_id on external builds.

Apologies for the back and forth, I had my local builds mis-configured so the success was my mistake. I've put up a small change at https://reviews.llvm.org/D66518 that should fix things.

Aug 21 2019, 2:19 AM · Restricted Project
DavidSpickett created D66518: [libcxx] Only declare contents of threading API when _LIBCPP_HAS_THREAD_API_EXTERNAL is not defined..
Aug 21 2019, 2:16 AM · Restricted Project, Restricted Project

Aug 20 2019

DavidSpickett abandoned D66301: [libcxx] __thread_id should be available when an external threading API is used..

Abandoned in favour of Marshall's fix.

Aug 20 2019, 9:15 AM
DavidSpickett accepted D66480: Fix unavailability of __thread_id on external builds.

Fixes the build for us and is neater than my solution. LGTM

Aug 20 2019, 9:08 AM · Restricted Project

Aug 15 2019

DavidSpickett created D66301: [libcxx] __thread_id should be available when an external threading API is used..
Aug 15 2019, 8:56 AM
DavidSpickett added a comment to D65895: Fix a layering violation in mutex - prep for fixing PR42918.

The move of thread_id to <threading_support> has caused a build error for us when _LIBCPP_HAS_THREAD_API_EXTERNAL is true

Aug 15 2019, 6:12 AM

Jul 9 2019

DavidSpickett accepted D64243: [NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand.

LGTM

Jul 9 2019, 3:07 AM · Restricted Project, Restricted Project

Jun 27 2019

DavidSpickett accepted D63862: [ARM] Tighten restrictions on use of SP in v8.1-M CSEL..
Jun 27 2019, 5:16 AM · Restricted Project
DavidSpickett accepted D63864: [ARM] Fix handling of zero offsets in LOB instructions..

LGTM

Jun 27 2019, 3:45 AM · Restricted Project
DavidSpickett added inline comments to D63862: [ARM] Tighten restrictions on use of SP in v8.1-M CSEL..
Jun 27 2019, 3:45 AM · Restricted Project
DavidSpickett accepted D63863: [ARM] Make coprocessor number restrictions consistent..

LGTM

Jun 27 2019, 3:30 AM · Restricted Project

May 9 2019

DavidSpickett accepted D61668: [ARM] Fix the extensions implied by a cpu name.
May 9 2019, 2:14 AM · Restricted Project, Restricted Project

May 8 2019

DavidSpickett added a comment to D61668: [ARM] Fix the extensions implied by a cpu name.

LGTM but the use of "intrinsic" in the commit message is confusing. Do you mean feature/implied feature, as in "the implied features defined by"?

May 8 2019, 2:46 AM · Restricted Project, Restricted Project

Apr 15 2019

DavidSpickett accepted D60486: [AArch64] Add support for MTE intrinsics.
Apr 15 2019, 2:43 AM · Restricted Project

Apr 12 2019

DavidSpickett accepted D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics.

LGTM

Apr 12 2019, 3:24 AM · Restricted Project, Restricted Project

Apr 10 2019

DavidSpickett added a comment to D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64.

What's the motivation for this change, are you working towards common flags for both platforms? The current way to select crypto on AArch64 is '-march=armv8.x-a+crypto/nocrypto'. I can see that would be an issue if Power PC doesn't support that syntax, or doesn't have a specific crypto extension.

Apr 10 2019, 7:15 AM · Restricted Project
DavidSpickett added a comment to D60486: [AArch64] Add support for MTE intrinsics.

One nit otherwise LGTM.

Apr 10 2019, 4:10 AM · Restricted Project
DavidSpickett added a comment to D60485: [AArch64] Add support for MTE intrinsics.

Do we need a separate file for that one "arm_mte_ptrdiff" test? Wouldn't it be easier to wrap the whole function in "cplusplus" and put it in the same file.

Apr 10 2019, 3:27 AM · Restricted Project

Apr 3 2019

DavidSpickett accepted D60188: [AArch64] Update v8.5a MTE instructions.

LGTM but add the specification link in the commit msg (https://developer.arm.com/docs/ddi0596/c) and reference LDG/STG in the title.

Apr 3 2019, 2:49 AM · Restricted Project

Apr 1 2019

DavidSpickett committed rG3d233d5d4d82: [AArch64] Add v8.5-a Memory Tagging STZGM instruction (authored by DavidSpickett).
[AArch64] Add v8.5-a Memory Tagging STZGM instruction
Apr 1 2019, 7:59 AM
DavidSpickett committed rL357397: [AArch64] Add v8.5-a Memory Tagging STZGM instruction.
[AArch64] Add v8.5-a Memory Tagging STZGM instruction
Apr 1 2019, 7:59 AM
DavidSpickett closed D60065: [AArch64] Add v8.5-a Memory Tagging STZGM instruction.
Apr 1 2019, 7:58 AM · Restricted Project
DavidSpickett committed rG9142b8ef1b9a: [AArch64] Add v8.5-a Memory Tagging STGM/LDGM instructions (authored by DavidSpickett).
[AArch64] Add v8.5-a Memory Tagging STGM/LDGM instructions
Apr 1 2019, 7:53 AM
DavidSpickett committed rL357395: [AArch64] Add v8.5-a Memory Tagging STGM/LDGM instructions.
[AArch64] Add v8.5-a Memory Tagging STGM/LDGM instructions
Apr 1 2019, 7:51 AM
DavidSpickett closed D60064: [AArch64] Add v8.5-a Memory Tagging STGM/LDGM instructions.
Apr 1 2019, 7:51 AM · Restricted Project
DavidSpickett closed D60063: [AArch64] Add v8.5-a Memory Tagging GMID_EL1 register.
Apr 1 2019, 7:46 AM · Restricted Project
DavidSpickett committed rGefe376add6ab: [AArch64] Add v8.5-a Memory Tagging GMID_EL1 register (authored by DavidSpickett).
[AArch64] Add v8.5-a Memory Tagging GMID_EL1 register
Apr 1 2019, 7:40 AM
DavidSpickett committed rL357392: [AArch64] Add v8.5-a Memory Tagging GMID_EL1 register.
[AArch64] Add v8.5-a Memory Tagging GMID_EL1 register
Apr 1 2019, 7:39 AM
DavidSpickett added a reviewer for D60065: [AArch64] Add v8.5-a Memory Tagging STZGM instruction: javed.absar.
Apr 1 2019, 6:45 AM · Restricted Project
DavidSpickett added a reviewer for D60063: [AArch64] Add v8.5-a Memory Tagging GMID_EL1 register: javed.absar.
Apr 1 2019, 6:45 AM · Restricted Project