No references to these registers in the current ARMARM document, LGTM.
Feb 6 2020
Feb 5 2020
Posted http://lists.llvm.org/pipermail/llvm-dev/2020-February/138937.html if you want to comment there.
The rationale is that the case of a directive has never really been important even though we'd reject anything that isn't lower case. I looked at all the targets in LLVM and none of them specify anything that isn't all lower case (though nothing in the code prevents them from doing so). All the targets GCC supports will accept any case also, though they may document with a set format.
Feb 4 2020
Posted https://reviews.llvm.org/D73972 as a new change for the ".tlsdescseq" directive.
Jan 27 2020
@grosbach I've not seen this "requires audit" before. Did the change cause a problem/do you need any actions from me on this?
Jan 20 2020
Jan 17 2020
Added a comment to init directive map saying that they should all be lower case.
Switched to a generic x86 target and alias for the lit test, to match the other MC/AsmParser tests.
ping, @cmatthews does the updated diff look good to you?
Jan 15 2020
This suggests that there are exceptions, do you which targets and directives don't follow this?
Jan 14 2020
Direct link to Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=39527
Jan 13 2020
Turns out I didn't have /usr/sbin on my PATH (due to some machine hopping).
Jan 9 2020
Jan 6 2020
I found this running lit tests on a Mac that doesn't have sysctl available. Not very familiar with it so I'm not sure why that is the case for our particular machine.
Dec 20 2019
Failure was unrelated, re-landed as 0ca9d2fd39264054501927ba6d3c5330159458d7.
Dec 19 2019
Have reverted due to failure on lld-x86_64-ubuntu-fast buildbot, will investigate and re-land.
Please make sure the tool name is llvm-locstats instead of llvm-covstat.
Posted: https://reviews.llvm.org/D71705 to make that change.
That looks good to me and it works for our use case.
Ah I see. Well, I think the build target existing even if it's not added to "all" is fine. Which is what BUILD_TOOLS controls:
macro(add_llvm_tool name) if( NOT LLVM_BUILD_TOOLS ) set(EXCLUDE_FROM_ALL ON) endif()
Sorry for the confusion. May be the llvm/CMakeLists.txt is better place to address this?
llvm/CMakeLists.txt:if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS) add_subdirectory(utils/llvm-locstats) endif()
The llvm-dwarfdump tool target will still be there. Unless that also has this BUILD vs INCLUDE issue.
No that's fine, no change needed. I think you just uncovered an issue with the way llvm-locstats was defined (or not as the case was).
Posted a fix here: https://reviews.llvm.org/D71695
How is this change supposed to interact with LLVM_BUILD_TOOLS?
"LLVM_BUILD_TOOLS: Build the LLVM tools. If OFF, just generate build targets."
Nov 4 2019
Sep 17 2019
Aug 21 2019
Addressed Michael's comment by not moving the initial:
#endif // defined(_LIBCPP_HAS_THREAD_API_PTHREAD)
Apologies for the back and forth, I had my local builds mis-configured so the success was my mistake. I've put up a small change at https://reviews.llvm.org/D66518 that should fix things.
Aug 20 2019
Abandoned in favour of Marshall's fix.
Fixes the build for us and is neater than my solution. LGTM
Aug 15 2019
The move of thread_id to <threading_support> has caused a build error for us when _LIBCPP_HAS_THREAD_API_EXTERNAL is true
Jul 9 2019
Jun 27 2019
May 9 2019
May 8 2019
LGTM but the use of "intrinsic" in the commit message is confusing. Do you mean feature/implied feature, as in "the implied features defined by"?
Apr 15 2019
Apr 12 2019
Apr 10 2019
What's the motivation for this change, are you working towards common flags for both platforms? The current way to select crypto on AArch64 is '-march=armv8.x-a+crypto/nocrypto'. I can see that would be an issue if Power PC doesn't support that syntax, or doesn't have a specific crypto extension.
One nit otherwise LGTM.
Do we need a separate file for that one "arm_mte_ptrdiff" test? Wouldn't it be easier to wrap the whole function in "cplusplus" and put it in the same file.
Apr 3 2019
LGTM but add the specification link in the commit msg (https://developer.arm.com/docs/ddi0596/c) and reference LDG/STG in the title.