Page MenuHomePhabricator
Feed Advanced Search

Fri, Dec 3

wsmoses accepted D115037: [mlir] Avoid needlessly converting LLVM named structs with compatible elements.
Fri, Dec 3, 1:43 PM · Restricted Project

Wed, Dec 1

wsmoses accepted D113580: [mlir] support recursive type conversion of named LLVM structs.
Wed, Dec 1, 10:21 AM · Restricted Project

Tue, Nov 16

wsmoses committed rG30d87d4a5d02: [MLIR][LLVM] Permit integer types in switch other than i32 (authored by wsmoses).
[MLIR][LLVM] Permit integer types in switch other than i32
Tue, Nov 16, 9:00 AM
wsmoses closed D113955: [MLIR][LLVM] Permit integer types in switch other than i32.
Tue, Nov 16, 9:00 AM · Restricted Project, Restricted Project
wsmoses updated the diff for D113955: [MLIR][LLVM] Permit integer types in switch other than i32.

Update flang test

Tue, Nov 16, 8:18 AM · Restricted Project, Restricted Project
wsmoses updated the diff for D113955: [MLIR][LLVM] Permit integer types in switch other than i32.

Force rebuild / fix format

Tue, Nov 16, 6:50 AM · Restricted Project, Restricted Project

Mon, Nov 15

wsmoses updated the diff for D113955: [MLIR][LLVM] Permit integer types in switch other than i32.

Fix rebase error

Mon, Nov 15, 10:13 PM · Restricted Project, Restricted Project
wsmoses reopened D113955: [MLIR][LLVM] Permit integer types in switch other than i32.
Mon, Nov 15, 10:13 PM · Restricted Project, Restricted Project
wsmoses added a comment to D113955: [MLIR][LLVM] Permit integer types in switch other than i32.

Ah arcanist didn't appear to take my update upon a land, one moment.

Mon, Nov 15, 10:06 PM · Restricted Project, Restricted Project
wsmoses committed rG94992670fcc5: [MLIR][LLVM] Permit integer types in switch other than i32 (authored by wsmoses).
[MLIR][LLVM] Permit integer types in switch other than i32
Mon, Nov 15, 9:46 PM
wsmoses closed D113955: [MLIR][LLVM] Permit integer types in switch other than i32.
Mon, Nov 15, 9:46 PM · Restricted Project, Restricted Project
wsmoses requested review of D113955: [MLIR][LLVM] Permit integer types in switch other than i32.
Mon, Nov 15, 5:14 PM · Restricted Project, Restricted Project

Oct 16 2021

wsmoses committed rG40b9c39db159: [MLIR][LLVM] Add memset intrinsic (authored by wsmoses).
[MLIR][LLVM] Add memset intrinsic
Oct 16 2021, 3:21 PM
wsmoses closed D111906: [MLIR][LLVM] Add memset intrinsic.
Oct 16 2021, 3:20 PM · Restricted Project

Oct 15 2021

wsmoses requested review of D111906: [MLIR][LLVM] Add memset intrinsic.
Oct 15 2021, 12:35 PM · Restricted Project

Sep 27 2021

wsmoses committed rG6dd5b1e33e04: [MLIR][LLVM] Add error if using incorrect attribute type for specifying LLVM… (authored by wsmoses).
[MLIR][LLVM] Add error if using incorrect attribute type for specifying LLVM…
Sep 27 2021, 10:24 AM
wsmoses closed D110566: [MLIR][LLVM] Add error if using incorrect attribute type for specifying LLVM linkage.
Sep 27 2021, 10:24 AM · Restricted Project
wsmoses updated the diff for D110566: [MLIR][LLVM] Add error if using incorrect attribute type for specifying LLVM linkage.

Address comments

Sep 27 2021, 10:11 AM · Restricted Project
wsmoses requested review of D110566: [MLIR][LLVM] Add error if using incorrect attribute type for specifying LLVM linkage.
Sep 27 2021, 9:56 AM · Restricted Project

Sep 10 2021

wsmoses added a comment to D108524: [MLIR] Primitive linkage lowering of FuncOp.

We do not but should. Apologies on the delay, will take a look at this week (was preparing for PACT and the start of the term).

Sep 10 2021, 5:47 PM · Restricted Project

Sep 3 2021

wsmoses committed rG21d43daf8f4a: [MLIR] Primitive linkage lowering of FuncOp (authored by wsmoses).
[MLIR] Primitive linkage lowering of FuncOp
Sep 3 2021, 5:42 PM
wsmoses closed D108524: [MLIR] Primitive linkage lowering of FuncOp.
Sep 3 2021, 5:42 PM · Restricted Project
wsmoses added a comment to D108221: [LoopIdiom] Keep TBAA when creating memcpy/memmove.

Hmm.. what does it mean to have a !tbaa tag on a llvm.memcpy/llvm.memmove ? The langref only seem to mention !tbaa.struct for llvm.memcpy. Is it allowed to have both a !tbaa and a !tbaa.struct ? What would that mean ?

Sep 3 2021, 5:40 PM · Restricted Project
wsmoses updated the diff for D108221: [LoopIdiom] Keep TBAA when creating memcpy/memmove.

Address comments

Sep 3 2021, 5:34 PM · Restricted Project
wsmoses updated the diff for D108524: [MLIR] Primitive linkage lowering of FuncOp.

Rebase with LLVM linkage printer

Sep 3 2021, 4:03 PM · Restricted Project
wsmoses accepted D109209: Make LLVM Linkage a first class attribute instead of using an integer attribute.

Yeah this is a lot nicer (as clearly evidenced by the llvm.mlir globals as well). For my own edification, is there documentation about the tablegen storageType/convertFromStorage parameters?

Sep 3 2021, 12:39 PM · Restricted Project

Sep 2 2021

wsmoses added a comment to D108524: [MLIR] Primitive linkage lowering of FuncOp.

Yeah I had tried reproducing the FMF flag variant originally, but it was unable to build in this case because the linkage is an IntegerAttr and the new Linkage wrapper attribute wasn’t allowed to have an IntegerStorage as a parameter. The reason the FMF flags get away with it is because it is a bitfield.

Sep 2 2021, 4:17 PM · Restricted Project
wsmoses added a comment to D108524: [MLIR] Primitive linkage lowering of FuncOp.

How does the following work as a scheme -- adding a custom printer/parser to the LLVM Linkage attribute itself. For a number of specific reasons, I'm not sure of a better way to do so than above. Specifically the tablegen-generated generatedAttributeParser and generatedAttributePrinter don't include any enum attributes since they are themselves subattributes of IntegerAttr and thus aren't registered to the dialect.

Sep 2 2021, 1:22 PM · Restricted Project
wsmoses updated the diff for D108524: [MLIR] Primitive linkage lowering of FuncOp.

Custom LLVM linkage attribute parsing

Sep 2 2021, 1:19 PM · Restricted Project

Sep 1 2021

wsmoses added a comment to D108524: [MLIR] Primitive linkage lowering of FuncOp.

Trying to add the stringify/symbolize presents linkage issues, ironically. Both of those functions are (reasonable) defined only within the LLVM dialect. The parser/printer for funcop, however, is within the builtin dialect -- which means that things can't be linked if the helper code is used. Alternatively the llvm linkage attributes could be moved to the builtin dialect, but that's its own can of worms.

Sep 1 2021, 5:54 PM · Restricted Project

Aug 25 2021

wsmoses updated the diff for D108524: [MLIR] Primitive linkage lowering of FuncOp.

Change to llvm linkage rather than just private/public

Aug 25 2021, 7:13 PM · Restricted Project

Aug 22 2021

wsmoses requested review of D108524: [MLIR] Primitive linkage lowering of FuncOp.
Aug 22 2021, 1:49 PM · Restricted Project

Aug 20 2021

wsmoses committed rG973cb2c326be: [MLIR][OMP] Ensure nested scf.parallel execute all iterations (authored by wsmoses).
[MLIR][OMP] Ensure nested scf.parallel execute all iterations
Aug 20 2021, 4:06 PM
wsmoses closed D108426: [MLIR][OMP] Ensure nested scf.parallel execute all iterations.
Aug 20 2021, 4:06 PM · Restricted Project

Aug 19 2021

wsmoses requested review of D108426: [MLIR][OMP] Ensure nested scf.parallel execute all iterations.
Aug 19 2021, 4:55 PM · Restricted Project

Aug 18 2021

wsmoses committed rG8c2ff7b69e77: [MLIR] Correct linkage of lowered globalop (authored by wsmoses).
[MLIR] Correct linkage of lowered globalop
Aug 18 2021, 8:10 AM
wsmoses closed D108252: [MLIR] Correct linkage of lowered globalop.
Aug 18 2021, 8:10 AM · Restricted Project

Aug 17 2021

wsmoses requested review of D108252: [MLIR] Correct linkage of lowered globalop.
Aug 17 2021, 3:25 PM · Restricted Project
wsmoses requested review of D108221: [LoopIdiom] Keep TBAA when creating memcpy/memmove.
Aug 17 2021, 10:36 AM · Restricted Project

Aug 3 2021

wsmoses added inline comments to D107343: [mlir] support translating OpenMP loops with reductions.
Aug 3 2021, 1:28 PM · Restricted Project

Jul 15 2021

wsmoses accepted D106076: [mlir] add an interface to support custom types in LLVM dialect pointers.
Jul 15 2021, 4:40 PM · Restricted Project

Jul 8 2021

wsmoses accepted D105631: [mlir] don't drop undef initializers in translation to LLVM IR.
Jul 8 2021, 2:02 PM · Restricted Project
wsmoses added inline comments to D105631: [mlir] don't drop undef initializers in translation to LLVM IR.
Jul 8 2021, 8:33 AM · Restricted Project

Jul 7 2021

wsmoses committed rG9a11c70c1856: [SCF] Handle lowering of Execute region to Standard CFG (authored by wsmoses).
[SCF] Handle lowering of Execute region to Standard CFG
Jul 7 2021, 12:27 PM
wsmoses closed D105567: [SCF] Handle lowering of Execute region to LLVM.
Jul 7 2021, 12:27 PM · Restricted Project
wsmoses committed rGeaf22ba0118a: [MLIR] Provide lowering of std switch to llvm switch (authored by wsmoses).
[MLIR] Provide lowering of std switch to llvm switch
Jul 7 2021, 12:27 PM
wsmoses closed D105580: [MLIR] Provide lowering of std switch to llvm switch.
Jul 7 2021, 12:26 PM · Restricted Project
wsmoses requested review of D105580: [MLIR] Provide lowering of std switch to llvm switch.
Jul 7 2021, 12:15 PM · Restricted Project
wsmoses updated the diff for D105567: [SCF] Handle lowering of Execute region to LLVM.

Add test

Jul 7 2021, 11:48 AM · Restricted Project
wsmoses requested review of D105567: [SCF] Handle lowering of Execute region to LLVM.
Jul 7 2021, 11:17 AM · Restricted Project

Jul 1 2021

wsmoses committed rGe86fe368db11: [MLIR] Allow Affine scalar replacement to handle inner operations (authored by wsmoses).
[MLIR] Allow Affine scalar replacement to handle inner operations
Jul 1 2021, 12:13 PM
wsmoses closed D105058: [MLIR] Allow Affine scalar replacement to handle inner operations.
Jul 1 2021, 12:13 PM · Restricted Project
wsmoses updated the summary of D105058: [MLIR] Allow Affine scalar replacement to handle inner operations.
Jul 1 2021, 8:14 AM · Restricted Project

Jun 30 2021

wsmoses updated the diff for D105058: [MLIR] Allow Affine scalar replacement to handle inner operations.

Fix depth inequality

Jun 30 2021, 11:09 AM · Restricted Project
wsmoses committed rGad4152d1b833: [MLIR] Update description of SCF.execute_region op (authored by wsmoses).
[MLIR] Update description of SCF.execute_region op
Jun 30 2021, 7:17 AM
wsmoses committed rGdfb34c0df9d0: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks (authored by wsmoses).
[MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks
Jun 30 2021, 7:03 AM
wsmoses closed D104960: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks.
Jun 30 2021, 7:03 AM · Restricted Project
wsmoses committed rG0cd8422e8caa: [MLIR] Eliminate unnecessary affine stores (authored by wsmoses).
[MLIR] Eliminate unnecessary affine stores
Jun 30 2021, 6:46 AM
wsmoses closed D105041: [MLIR] Eliminate unnecessary affine stores.
Jun 30 2021, 6:45 AM · Restricted Project

Jun 29 2021

wsmoses added a comment to D104865: [MLIR][SCF] Inline single block ExecuteRegionOp.

@wsmoses can you update the documentation?

Jun 29 2021, 11:35 AM · Restricted Project
wsmoses abandoned D105043: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks.
Jun 29 2021, 9:41 AM · Restricted Project
wsmoses updated the diff for D104960: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks.

Reopen changes

Jun 29 2021, 9:41 AM · Restricted Project
wsmoses reopened D104960: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks.
Jun 29 2021, 7:42 AM · Restricted Project

Jun 28 2021

wsmoses updated the diff for D105041: [MLIR] Eliminate unnecessary affine stores.

Address comments

Jun 28 2021, 8:11 PM · Restricted Project
wsmoses updated the summary of D105041: [MLIR] Eliminate unnecessary affine stores.
Jun 28 2021, 6:54 PM · Restricted Project
wsmoses requested review of D105058: [MLIR] Allow Affine scalar replacement to handle inner operations.
Jun 28 2021, 1:04 PM · Restricted Project
wsmoses updated the diff for D105043: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks.

Rename test

Jun 28 2021, 10:59 AM · Restricted Project
wsmoses requested review of D105043: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks.
Jun 28 2021, 10:57 AM · Restricted Project
wsmoses added a reverting change for rG5d6240b77e7e: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks: rG2ab27758d5c5: Revert "[MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks".
Jun 28 2021, 10:53 AM
wsmoses committed rG2ab27758d5c5: Revert "[MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks" (authored by wsmoses).
Revert "[MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks"
Jun 28 2021, 10:53 AM
wsmoses added a reverting change for D104960: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks: rG2ab27758d5c5: Revert "[MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks".
Jun 28 2021, 10:53 AM · Restricted Project
wsmoses added a reviewer for D105041: [MLIR] Eliminate unnecessary affine stores: bondhugula.
Jun 28 2021, 10:51 AM · Restricted Project
wsmoses added a comment to D104960: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks.

This revision was not accepted when it landed; it landed in state Needs Review.

Was this committed unintentionally? I don't see an approval from @ftynse post comments nor from anyone else.

Jun 28 2021, 10:51 AM · Restricted Project
wsmoses updated the diff for D105041: [MLIR] Eliminate unnecessary affine stores.

Fix rebase errors

Jun 28 2021, 10:36 AM · Restricted Project
wsmoses requested review of D105041: [MLIR] Eliminate unnecessary affine stores.
Jun 28 2021, 10:31 AM · Restricted Project
wsmoses committed rG5d6240b77e7e: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks (authored by wsmoses).
[MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks
Jun 28 2021, 10:10 AM
wsmoses closed D104960: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks.
Jun 28 2021, 10:10 AM · Restricted Project
wsmoses committed rG44826ecd929b: [MLIR] Correct memrefdataflow behavior in the presence of cast and other… (authored by wsmoses).
[MLIR] Correct memrefdataflow behavior in the presence of cast and other…
Jun 28 2021, 9:24 AM
wsmoses closed D104053: [MLIR] Correct memrefdataflow behavior in the presence of cast and other operations.
Jun 28 2021, 9:23 AM · Restricted Project
wsmoses committed rGcccc7e5aa808: [MLIR] Don't remove memref allocation if stored into another allocation (authored by wsmoses).
[MLIR] Don't remove memref allocation if stored into another allocation
Jun 28 2021, 9:06 AM
wsmoses closed D104947: [MLIR] Don't remove memref allocation if stored into another allocation.
Jun 28 2021, 9:06 AM · Restricted Project
wsmoses updated the diff for D104053: [MLIR] Correct memrefdataflow behavior in the presence of cast and other operations.

Post rebase / fixing nits

Jun 28 2021, 8:19 AM · Restricted Project
wsmoses committed rG35c0ab72fc20: [MLIR] Simplify select to a not (authored by wsmoses).
[MLIR] Simplify select to a not
Jun 28 2021, 8:00 AM
wsmoses closed D104966: [MLIR] Simplify select to a not.
Jun 28 2021, 8:00 AM · Restricted Project

Jun 27 2021

wsmoses added inline comments to D104053: [MLIR] Correct memrefdataflow behavior in the presence of cast and other operations.
Jun 27 2021, 7:53 PM · Restricted Project
wsmoses updated the diff for D104053: [MLIR] Correct memrefdataflow behavior in the presence of cast and other operations.

Restore dependence analysis and address comments

Jun 27 2021, 7:40 PM · Restricted Project
wsmoses added inline comments to D104053: [MLIR] Correct memrefdataflow behavior in the presence of cast and other operations.
Jun 27 2021, 12:14 PM · Restricted Project
wsmoses updated the diff for D104053: [MLIR] Correct memrefdataflow behavior in the presence of cast and other operations.

Additional comments

Jun 27 2021, 12:14 PM · Restricted Project
wsmoses updated the diff for D104053: [MLIR] Correct memrefdataflow behavior in the presence of cast and other operations.

Address comments

Jun 27 2021, 12:04 PM · Restricted Project
wsmoses updated the diff for D104960: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks.

Handle regions with multiple yields

Jun 27 2021, 11:09 AM · Restricted Project

Jun 25 2021

wsmoses added a comment to D104960: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks.

The more generic single block simplification you're suggesting was added here: https://reviews.llvm.org/D104865 .

Jun 25 2021, 11:45 PM · Restricted Project
wsmoses requested review of D104966: [MLIR] Simplify select to a not.
Jun 25 2021, 8:25 PM · Restricted Project
wsmoses updated the diff for D104960: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks.

Add newline

Jun 25 2021, 4:50 PM · Restricted Project
wsmoses requested review of D104960: [MLIR][SCF] Inline ExecuteRegion if parent can contain multiple blocks.
Jun 25 2021, 4:45 PM · Restricted Project
wsmoses updated the diff for D104947: [MLIR] Don't remove memref allocation if stored into another allocation.

Update format and naming

Jun 25 2021, 2:24 PM · Restricted Project
wsmoses updated the diff for D104947: [MLIR] Don't remove memref allocation if stored into another allocation.

Remove unrelated verifier patch

Jun 25 2021, 1:44 PM · Restricted Project
wsmoses added inline comments to D104947: [MLIR] Don't remove memref allocation if stored into another allocation.
Jun 25 2021, 1:36 PM · Restricted Project
wsmoses requested review of D104947: [MLIR] Don't remove memref allocation if stored into another allocation.
Jun 25 2021, 1:29 PM · Restricted Project

Jun 24 2021

wsmoses committed rG44985872b8a0: [MLIR][SCF] Inline single block ExecuteRegionOp (authored by wsmoses).
[MLIR][SCF] Inline single block ExecuteRegionOp
Jun 24 2021, 10:18 AM
wsmoses closed D104865: [MLIR][SCF] Inline single block ExecuteRegionOp.
Jun 24 2021, 10:17 AM · Restricted Project