Fri, Dec 3
Wed, Dec 1
Tue, Nov 16
Update flang test
Force rebuild / fix format
Mon, Nov 15
Fix rebase error
Ah arcanist didn't appear to take my update upon a land, one moment.
Oct 16 2021
Oct 15 2021
Sep 27 2021
Sep 10 2021
We do not but should. Apologies on the delay, will take a look at this week (was preparing for PACT and the start of the term).
Sep 3 2021
Hmm.. what does it mean to have a !tbaa tag on a llvm.memcpy/llvm.memmove ? The langref only seem to mention !tbaa.struct for llvm.memcpy. Is it allowed to have both a !tbaa and a !tbaa.struct ? What would that mean ?
Rebase with LLVM linkage printer
Yeah this is a lot nicer (as clearly evidenced by the llvm.mlir globals as well). For my own edification, is there documentation about the tablegen storageType/convertFromStorage parameters?
Sep 2 2021
Yeah I had tried reproducing the FMF flag variant originally, but it was unable to build in this case because the linkage is an IntegerAttr and the new Linkage wrapper attribute wasn’t allowed to have an IntegerStorage as a parameter. The reason the FMF flags get away with it is because it is a bitfield.
How does the following work as a scheme -- adding a custom printer/parser to the LLVM Linkage attribute itself. For a number of specific reasons, I'm not sure of a better way to do so than above. Specifically the tablegen-generated generatedAttributeParser and generatedAttributePrinter don't include any enum attributes since they are themselves subattributes of IntegerAttr and thus aren't registered to the dialect.
Custom LLVM linkage attribute parsing
Sep 1 2021
Trying to add the stringify/symbolize presents linkage issues, ironically. Both of those functions are (reasonable) defined only within the LLVM dialect. The parser/printer for funcop, however, is within the builtin dialect -- which means that things can't be linked if the helper code is used. Alternatively the llvm linkage attributes could be moved to the builtin dialect, but that's its own can of worms.
Aug 25 2021
Change to llvm linkage rather than just private/public
Aug 22 2021
Aug 20 2021
Aug 19 2021
Aug 18 2021
Aug 17 2021
Aug 3 2021
Jul 15 2021
Jul 8 2021
Jul 7 2021
Jul 1 2021
Jun 30 2021
Fix depth inequality
Jun 29 2021
@wsmoses can you update the documentation?
Jun 28 2021
This revision was not accepted when it landed; it landed in state Needs Review.
Was this committed unintentionally? I don't see an approval from @ftynse post comments nor from anyone else.
Fix rebase errors
Post rebase / fixing nits
Jun 27 2021
Restore dependence analysis and address comments
Handle regions with multiple yields
Jun 25 2021
The more generic single block simplification you're suggesting was added here: https://reviews.llvm.org/D104865 .
Update format and naming
Remove unrelated verifier patch