Page MenuHomePhabricator
Feed Advanced Search

Aug 10 2020

atrosinenko added a comment to D84636: [RFC] Make the default LibCall implementations from compiler-rt builtins library more customizable.

Another note to myself: add AUX_DECLS(__LibCallName) to every generic implementation file. They were forgotten unintentionally.

Aug 10 2020, 7:36 AM · Restricted Project
atrosinenko updated the diff for D84397: [MSP430] Replace known epilogues with branches to __mspabi_func_epilog_N.

Address the review comment

Aug 10 2020, 2:19 AM · Restricted Project

Aug 7 2020

atrosinenko added inline comments to D84397: [MSP430] Replace known epilogues with branches to __mspabi_func_epilog_N.
Aug 7 2020, 6:36 AM · Restricted Project
atrosinenko updated the diff for D84397: [MSP430] Replace known epilogues with branches to __mspabi_func_epilog_N.

Address the comment + misc fixes.

Aug 7 2020, 6:34 AM · Restricted Project
atrosinenko added a reviewer for D85032: [builtins] Make divXf3 handle denormal results: broadwaylamb.
Aug 7 2020, 2:51 AM · Restricted Project

Aug 6 2020

atrosinenko added a comment to D84602: [MSP430] Expose msp430_builtin calling convention to C code.

I suspect there might be some terminology clash, so clarifying a bit just in case.

Aug 6 2020, 10:28 AM · Restricted Project, Restricted Project
atrosinenko added a comment to D82014: [compiler-rt] Replaced __SOFT_FP__ with __SOFTFP__.

Ping @kamleshbhalui

I hope your or some reviewer can test the buildability on ARM.

If I get some time this week(end) I'll make a soft-float build. I don't want to hold the change up by insisting we test on a soft-float Arm. I am interested in whether these functions are tested at all in that case, which we ought to follow up with if they are not.

Aug 6 2020, 9:25 AM · Restricted Project, Restricted Project
atrosinenko added reviewers for D84397: [MSP430] Replace known epilogues with branches to __mspabi_func_epilog_N: hans, arsenm, efriedma.
Aug 6 2020, 8:38 AM · Restricted Project
atrosinenko added a comment to D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls.

Ping.

Aug 6 2020, 7:11 AM · Restricted Project
atrosinenko added a comment to D85113: [ABI][NFC] Fix the confusion of ByVal and ByRef argument names.

@rjmccall Uploaded, thank you!

Aug 6 2020, 5:27 AM · Restricted Project
atrosinenko committed rG5a07490d7611: [ABI][NFC] Fix the confusion of ByVal and ByRef argument names (authored by atrosinenko).
[ABI][NFC] Fix the confusion of ByVal and ByRef argument names
Aug 6 2020, 5:26 AM
atrosinenko closed D85113: [ABI][NFC] Fix the confusion of ByVal and ByRef argument names.
Aug 6 2020, 5:25 AM · Restricted Project

Aug 5 2020

atrosinenko added a comment to D84636: [RFC] Make the default LibCall implementations from compiler-rt builtins library more customizable.

Ping.

Aug 5 2020, 9:18 AM · Restricted Project
atrosinenko updated the summary of D84636: [RFC] Make the default LibCall implementations from compiler-rt builtins library more customizable.
Aug 5 2020, 9:10 AM · Restricted Project

Aug 3 2020

atrosinenko requested review of D85113: [ABI][NFC] Fix the confusion of ByVal and ByRef argument names.
Aug 3 2020, 2:19 AM · Restricted Project

Jul 31 2020

atrosinenko added inline comments to D84877: Support for soft fp16 to fp64 IEEE conversions.
Jul 31 2020, 10:43 AM · Restricted Project, Restricted Project
atrosinenko requested review of D85032: [builtins] Make divXf3 handle denormal results.
Jul 31 2020, 9:02 AM · Restricted Project
atrosinenko added a comment to D85031: [builtins] Unify the softfloat division implementation.

Here are the benchmark and fuzzing harness used to test this patch.

Jul 31 2020, 9:02 AM · Restricted Project
atrosinenko requested review of D85031: [builtins] Unify the softfloat division implementation.
Jul 31 2020, 9:02 AM · Restricted Project
atrosinenko updated the diff for D85031: [builtins] Unify the softfloat division implementation.

Revert auto-linting

Jul 31 2020, 9:02 AM · Restricted Project

Jul 30 2020

atrosinenko requested review of D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls.
Jul 30 2020, 4:33 AM · Restricted Project

Jul 28 2020

atrosinenko updated the diff for D84602: [MSP430] Expose msp430_builtin calling convention to C code.

Fix some review comments.

Jul 28 2020, 5:32 AM · Restricted Project, Restricted Project
atrosinenko added a comment to D84602: [MSP430] Expose msp430_builtin calling convention to C code.

Is there only one special calling convention, or is there any chance that different builtin functions would use different conventions?

Jul 28 2020, 4:33 AM · Restricted Project, Restricted Project
atrosinenko added inline comments to D84602: [MSP430] Expose msp430_builtin calling convention to C code.
Jul 28 2020, 4:12 AM · Restricted Project, Restricted Project

Jul 27 2020

atrosinenko requested review of D84636: [RFC] Make the default LibCall implementations from compiler-rt builtins library more customizable.
Jul 27 2020, 4:58 AM · Restricted Project

Jul 26 2020

atrosinenko updated the summary of D84605: [IR][MSP430] Expose the "msp430_builtin" calling convention to .ll.
Jul 26 2020, 12:00 PM · Restricted Project
Herald added a project to D84605: [IR][MSP430] Expose the "msp430_builtin" calling convention to .ll: Restricted Project.
Jul 26 2020, 11:56 AM · Restricted Project
Herald added projects to D84602: [MSP430] Expose msp430_builtin calling convention to C code: Restricted Project, Restricted Project.
Jul 26 2020, 11:43 AM · Restricted Project, Restricted Project

Jul 23 2020

atrosinenko updated the diff for D84417: [MSP430] Do not use __mspabi_cmp[fd] for FP comparisons.

Revert automatic formatting change.

Jul 23 2020, 8:05 AM · Restricted Project
Herald added a project to D84417: [MSP430] Do not use __mspabi_cmp[fd] for FP comparisons: Restricted Project.
Jul 23 2020, 8:01 AM · Restricted Project
Herald added a project to D84397: [MSP430] Replace known epilogues with branches to __mspabi_func_epilog_N: Restricted Project.
Jul 23 2020, 5:22 AM · Restricted Project

Jul 17 2020

atrosinenko added a reviewer for D84058: Pass -rtlib=libgcc in tests conditioned on the default.: atrosinenko.

If I get it right, the only thing this patch weakens about msp430-toolchain.c test is an assumption that libgcc is used by default.

Jul 17 2020, 11:40 AM · Restricted Project
atrosinenko added a comment to D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.

After a final retesting, this patch was updated a bit.

Jul 17 2020, 5:48 AM · Restricted Project
atrosinenko committed rG16a4350f76d2: [MSP430] Actualize the toolchain description (authored by atrosinenko).
[MSP430] Actualize the toolchain description
Jul 17 2020, 5:46 AM
atrosinenko closed D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.
Jul 17 2020, 5:46 AM · Restricted Project

Jul 14 2020

atrosinenko added a comment to D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.

Thank you! Will probably land it tomorrow.

Jul 14 2020, 8:50 AM · Restricted Project

Jul 9 2020

atrosinenko committed rG67422e429475: [MSP430] Align the _Complex ABI with current msp430-gcc (authored by atrosinenko).
[MSP430] Align the _Complex ABI with current msp430-gcc
Jul 9 2020, 8:32 AM
atrosinenko closed D82646: [MSP430] Align the _Complex ABI with current msp430-gcc.
Jul 9 2020, 8:32 AM · Restricted Project
atrosinenko updated the diff for D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.

Just an automatic rebase to (possibly) fix failing "Apply patch" step.

Jul 9 2020, 3:45 AM · Restricted Project
atrosinenko updated the diff for D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.

Just add the test on -rtlib=compiler-rt handling as everything other is ready for basic clang_rt.builtins support.

Jul 9 2020, 3:15 AM · Restricted Project

Jul 8 2020

atrosinenko updated the diff for D82646: [MSP430] Align the _Complex ABI with current msp430-gcc.

Support int/long/long long _Complex types (GCC extension). According to msp430-gcc v9.2.0, they behave identically.

Jul 8 2020, 10:23 AM · Restricted Project

Jul 7 2020

atrosinenko updated the diff for D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.

Fix path separators in unit test on Windows

Jul 7 2020, 3:53 AM · Restricted Project
atrosinenko updated the diff for D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.

Address the review comments.

Jul 7 2020, 2:25 AM · Restricted Project
atrosinenko added inline comments to D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.
Jul 7 2020, 2:24 AM · Restricted Project

Jul 1 2020

atrosinenko committed rGf4e3e8811e30: Test commit (authored by atrosinenko).
Test commit
Jul 1 2020, 2:05 PM

Jun 30 2020

atrosinenko retitled D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0 from [MSP430] Align the toolchain definition with the TI's msp430-gcc v8.3.1 to [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.
Jun 30 2020, 9:11 AM · Restricted Project
atrosinenko updated the diff for D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.
  • Rebase onto an up-to-date upstream commit
  • Recheck against v9.2.0
  • Misc fixes and improvements
Jun 30 2020, 9:11 AM · Restricted Project

Jun 29 2020

atrosinenko added a comment to D82635: [MSP430] Declare comparison LibCalls as returning i16 instead of i32.

Just a note: using __mspabi_cmpf as a generic LibCall seems quite incorrect because __mspabi_cmpf does not accept NaNs according to MSP430 EABI. msp430-elf-gcc v9.2.0 just uses __nesf2 in the example above. I plan changing this later when doing more adjustments for libgcc/clang_rt.

Jun 29 2020, 11:57 PM · Restricted Project
atrosinenko updated the summary of D82635: [MSP430] Declare comparison LibCalls as returning i16 instead of i32.
Jun 29 2020, 11:57 PM · Restricted Project

Jun 26 2020

atrosinenko created D82646: [MSP430] Align the _Complex ABI with current msp430-gcc.
Jun 26 2020, 5:56 AM · Restricted Project
atrosinenko created D82635: [MSP430] Declare comparison LibCalls as returning i16 instead of i32.
Jun 26 2020, 2:40 AM · Restricted Project
atrosinenko added a comment to D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.

Meanwhile, msp430-gcc v9.2.0 was released on Jun 12. Will recheck against the new version slightly later.

Jun 26 2020, 1:36 AM · Restricted Project

Jun 25 2020

atrosinenko added inline comments to D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list.
Jun 25 2020, 11:20 AM · Restricted Project
atrosinenko updated the diff for D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list.

Move missed powitf2.c source as well.

Jun 25 2020, 11:20 AM · Restricted Project
atrosinenko added a reviewer for D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list: efriedma.
Jun 25 2020, 3:12 AM · Restricted Project
atrosinenko added a comment to D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list.

Ping.

Jun 25 2020, 3:04 AM · Restricted Project

Jun 24 2020

atrosinenko added a comment to D81285: [builtins] Change si_int to int in some helper declarations.

Thank you!

Jun 24 2020, 12:29 AM · Restricted Project
atrosinenko updated the summary of D81285: [builtins] Change si_int to int in some helper declarations.
Jun 24 2020, 12:29 AM · Restricted Project

Jun 23 2020

atrosinenko added reviewers for D81285: [builtins] Change si_int to int in some helper declarations: efriedma, MaskRay.
Jun 23 2020, 11:15 AM · Restricted Project
atrosinenko updated the diff for D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.

Unit test: fix for path separators on Windows

Jun 23 2020, 9:04 AM · Restricted Project
atrosinenko updated the summary of D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.
Jun 23 2020, 2:04 AM · Restricted Project
atrosinenko updated the diff for D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.

Address the review comments.

Jun 23 2020, 1:32 AM · Restricted Project
atrosinenko added a comment to D81408: [builtins] Improve compatibility with 16 bit targets.

could you please clarify what exactly is wrong? Windows not building 'compiler-rt'?

Jun 23 2020, 1:32 AM · Restricted Project

Jun 22 2020

atrosinenko added a comment to D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.

Thank you for the comments. Will send an update soon.

Jun 22 2020, 9:07 AM · Restricted Project
atrosinenko updated the diff for D82184: [MSP430] Update register names.

Fix compile error when building with older compilers.

Jun 22 2020, 5:52 AM · Restricted Project, Restricted Project
atrosinenko reopened D82184: [MSP430] Update register names.
Jun 22 2020, 5:52 AM · Restricted Project, Restricted Project

Jun 20 2020

atrosinenko added a comment to D81488: [MSP430] Enable some basic support for debug information.

Unit test failure here is expected because D82055: [DebugInfo] Explicitly permit addr_size = 0x02 when parsing DWARF data have to be landed before.

Jun 20 2020, 2:05 AM · Restricted Project
atrosinenko added a comment to D81488: [MSP430] Enable some basic support for debug information.

Meanwhile, is it acceptable that byte-sized and word-sized registers share the same DWARF register numbers such as r12 (16 bit) and r12b (8 bit) in this example?

These kinds of decisions are supposed to be specified by the ABI document for the platform (not in the DWARF standard), so you'd have to direct this question to whatever consortium defines the ABI for MSP430.

Jun 20 2020, 2:05 AM · Restricted Project
atrosinenko updated subscribers of D81408: [builtins] Improve compatibility with 16 bit targets.

Those flaky test failures seems to be due to ld.lld being not built from source as part of testing compiler-rt/-only patches.

That should be something we can fix in the build system. compiler-rt/test/CMakeLists.txt has a list of executables which the tests depend on. If that list isn't complete, it should be updated.

Jun 20 2020, 12:29 AM · Restricted Project

Jun 19 2020

atrosinenko added a comment to D81488: [MSP430] Enable some basic support for debug information.

Meanwhile, is it acceptable that byte-sized and word-sized registers share the same DWARF register numbers such as r12 (16 bit) and r12b (8 bit) in this example?

Jun 19 2020, 11:58 AM · Restricted Project
atrosinenko updated the diff for D81488: [MSP430] Enable some basic support for debug information.

Thanks! I have dropped the entire #0 and #1 attribute lists - that did not change the output. All the debug information nodes, on the other hand, were left intact (just in case) apart from omitting some parts of the producer string.

Jun 19 2020, 11:26 AM · Restricted Project
atrosinenko updated the summary of D82184: [MSP430] Update register names.
Jun 19 2020, 6:59 AM · Restricted Project, Restricted Project
atrosinenko created D82184: [MSP430] Update register names.
Jun 19 2020, 6:59 AM · Restricted Project, Restricted Project
atrosinenko updated the diff for D81285: [builtins] Change si_int to int in some helper declarations.

Replaced native_int by plain int, as @aykevl suggested.

Jun 19 2020, 2:39 AM · Restricted Project
atrosinenko added a comment to D81408: [builtins] Improve compatibility with 16 bit targets.

Those flaky test failures seems to be due to ld.lld being not built from source as part of testing compiler-rt/-only patches.

Jun 19 2020, 2:07 AM · Restricted Project

Jun 18 2020

atrosinenko added a comment to D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list.

@samsonov Something strange happens with the compiler-rt tests: when this patch was initially uploaded, the tests were failed with seemingly unrelated failures: B59287. Some tests are broken upstream, I concluded.

Jun 18 2020, 11:26 AM · Restricted Project
atrosinenko added a comment to D82055: [DebugInfo] Explicitly permit addr_size = 0x02 when parsing DWARF data.

Thank you!

Jun 18 2020, 9:49 AM · Restricted Project
atrosinenko updated the diff for D81408: [builtins] Improve compatibility with 16 bit targets.

Rebase onto working upstream commit to (hopefully) make tests pass for my patch.

Jun 18 2020, 5:24 AM · Restricted Project
atrosinenko updated the diff for D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.

Fix test once again (replace more literal slashes with regex).

Jun 18 2020, 5:24 AM · Restricted Project
atrosinenko added a reviewer for D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list: koviankevin.
Jun 18 2020, 2:08 AM · Restricted Project
atrosinenko updated the diff for D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list.
  1. Since different quite unrelated patches failed on Jun 5 with quite the same messages, just rebase onto current master expecting build failure to go away
  2. Ping
Jun 18 2020, 2:08 AM · Restricted Project
atrosinenko updated the diff for D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.

fix unit test: add another "-lgcc" and (hopefully) fix path separators on Windows

Jun 18 2020, 2:08 AM · Restricted Project
atrosinenko added a reviewer for D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0: krisb.
Jun 18 2020, 2:08 AM · Restricted Project
atrosinenko updated the diff for D82055: [DebugInfo] Explicitly permit addr_size = 0x02 when parsing DWARF data.

Unit test: fix backslash on Windows

Jun 18 2020, 12:30 AM · Restricted Project
atrosinenko added a reviewer for D82055: [DebugInfo] Explicitly permit addr_size = 0x02 when parsing DWARF data: uabelho.
Jun 18 2020, 12:30 AM · Restricted Project

Jun 17 2020

atrosinenko updated the diff for D81488: [MSP430] Enable some basic support for debug information.

Implemented a test. Please note it depends on D82055: [DebugInfo] Explicitly permit addr_size = 0x02 when parsing DWARF data.

Jun 17 2020, 2:34 PM · Restricted Project
atrosinenko created D82055: [DebugInfo] Explicitly permit addr_size = 0x02 when parsing DWARF data.
Jun 17 2020, 2:34 PM · Restricted Project

Jun 11 2020

atrosinenko updated the summary of D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.
Jun 11 2020, 11:32 AM · Restricted Project
atrosinenko created D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.
Jun 11 2020, 11:32 AM · Restricted Project

Jun 9 2020

atrosinenko created D81488: [MSP430] Enable some basic support for debug information.
Jun 9 2020, 10:58 AM · Restricted Project
atrosinenko added inline comments to D81285: [builtins] Change si_int to int in some helper declarations.
Jun 9 2020, 9:19 AM · Restricted Project
atrosinenko added a comment to D81285: [builtins] Change si_int to int in some helper declarations.

I'm not sure whether native_int is any clearer than just int. I'm afraid it only introduces more complexity ("What's native_int? Oh, it's just int").

Jun 9 2020, 8:46 AM · Restricted Project
atrosinenko added inline comments to D81408: [builtins] Improve compatibility with 16 bit targets.
Jun 9 2020, 4:54 AM · Restricted Project

Jun 8 2020

atrosinenko added inline comments to D81408: [builtins] Improve compatibility with 16 bit targets.
Jun 8 2020, 11:35 AM · Restricted Project
atrosinenko added a comment to D78662: [builtins] Support architectures with 16-bit int.

I changed the integer types used in many builtins (si_int, du_int, etc) to specific integer widths. My rationale is that even though the libgcc documentation uses types such as int / long / long long, I believe their bit width is actually much more strictly defined.

Jun 8 2020, 9:22 AM · Restricted Project
atrosinenko created D81408: [builtins] Improve compatibility with 16 bit targets.
Jun 8 2020, 9:22 AM · Restricted Project

Jun 6 2020

atrosinenko added a reviewer for D81285: [builtins] Change si_int to int in some helper declarations: aykevl.
Jun 6 2020, 6:22 AM · Restricted Project
atrosinenko added a reviewer for D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list: aykevl.
Jun 6 2020, 6:22 AM · Restricted Project

Jun 5 2020

atrosinenko created D81285: [builtins] Change si_int to int in some helper declarations.
Jun 5 2020, 11:10 AM · Restricted Project
atrosinenko added a reviewer for D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list: joerg.
Jun 5 2020, 11:10 AM · Restricted Project