Page MenuHomePhabricator
Feed Advanced Search

Yesterday

yinghuitan accepted D138638: Report which modules have forcefully completed types in statistics..
Tue, Nov 29, 9:18 AM · Restricted Project, Restricted Project

Wed, Nov 23

yinghuitan abandoned D138589: Add runToBinaryEntry option for lldb-vscode.

Discussed offline. We can't rely on initialized event because it has to happen before all breakpoints are set. Will create a new design for htis.

Wed, Nov 23, 11:16 AM · Restricted Project, Restricted Project
yinghuitan requested review of D138589: Add runToBinaryEntry option for lldb-vscode.
Wed, Nov 23, 9:28 AM · Restricted Project, Restricted Project
yinghuitan abandoned D138536: Fix TestVSCode_launch.py test failure.
Wed, Nov 23, 9:26 AM · Restricted Project, Restricted Project

Tue, Nov 22

yinghuitan added a comment to D135798: Add runToBinaryEntry option for lldb-vscode.

The test failure is fixed in https://reviews.llvm.org/D138536

Tue, Nov 22, 6:19 PM · Restricted Project, Restricted Project
yinghuitan requested review of D138536: Fix TestVSCode_launch.py test failure.
Tue, Nov 22, 6:18 PM · Restricted Project, Restricted Project
yinghuitan committed rGf0c16f89124f: Add runToBinaryEntry option for lldb-vscode (authored by yinghuitan).
Add runToBinaryEntry option for lldb-vscode
Tue, Nov 22, 1:53 PM · Restricted Project
yinghuitan closed D135798: Add runToBinaryEntry option for lldb-vscode.
Tue, Nov 22, 1:53 PM · Restricted Project, Restricted Project

Mon, Nov 21

yinghuitan updated the diff for D138334: Improve llvm-symbolizer search logic for symlink.

Address review comment

Mon, Nov 21, 3:05 PM · Restricted Project, Restricted Project
yinghuitan added inline comments to D138334: Improve llvm-symbolizer search logic for symlink.
Mon, Nov 21, 3:04 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D138334: Improve llvm-symbolizer search logic for symlink.

@dblaikie, I did not find any existing test for it. Do you have any suggestion/example how to test this? We need to introduce a crash using this API and get the output and check the symbolication.

Mon, Nov 21, 2:53 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D138259: Add the ability to see when a type in incomplete..

Also, do you have any plan to record this happening in statistics dump so that our telemetry can report it?

Mon, Nov 21, 2:30 PM · Restricted Project, Restricted Project
yinghuitan added inline comments to D138259: Add the ability to see when a type in incomplete..
Mon, Nov 21, 2:29 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D138334: Improve llvm-symbolizer search logic for symlink.

@labath, thanks. I wish I can control the symlink deployment process, but unfortunately I can't. I think it is generally preferable to make lldb crash handler deal correctly with it.
I agree we do not want to regress any of existing behavior. That's why the patch only adds an extra search path for sys::findProgramByName which will prefer the executable parent first and fallback to try the second added path (real path from symlink) if failed to find in first path.

Mon, Nov 21, 9:46 AM · Restricted Project, Restricted Project
yinghuitan updated the diff for D138334: Improve llvm-symbolizer search logic for symlink.

Address review comments

Mon, Nov 21, 9:42 AM · Restricted Project, Restricted Project
yinghuitan added inline comments to D138334: Improve llvm-symbolizer search logic for symlink.
Mon, Nov 21, 9:32 AM · Restricted Project, Restricted Project

Sun, Nov 20

yinghuitan accepted D138383: Add a new top level statistic that tracks how many modules have variable errors..
Sun, Nov 20, 11:21 AM · Restricted Project, Restricted Project

Fri, Nov 18

yinghuitan requested review of D138334: Improve llvm-symbolizer search logic for symlink.
Fri, Nov 18, 3:15 PM · Restricted Project, Restricted Project

Tue, Nov 15

yinghuitan accepted D138077: Send statistics in initialized event.
Tue, Nov 15, 5:53 PM · Restricted Project, Restricted Project

Wed, Nov 2

yinghuitan requested changes to D137284: Override CalculateFrameVariableError in SymbolFileOnDemand.
Wed, Nov 2, 2:56 PM · Restricted Project, Restricted Project

Tue, Nov 1

yinghuitan committed rG6c8995649afa: Add formatting support for VSCode logpoints message (authored by yinghuitan).
Add formatting support for VSCode logpoints message
Tue, Nov 1, 8:44 AM · Restricted Project
yinghuitan closed D136697: Add formatting support for VSCode logpoints message.
Tue, Nov 1, 8:44 AM · Restricted Project, Restricted Project

Oct 28 2022

yinghuitan updated the diff for D136697: Add formatting support for VSCode logpoints message.

Add failure case testcase

Oct 28 2022, 3:37 PM · Restricted Project, Restricted Project

Oct 27 2022

yinghuitan updated the diff for D136697: Add formatting support for VSCode logpoints message.

Address review comments

Oct 27 2022, 4:15 PM · Restricted Project, Restricted Project
yinghuitan added inline comments to D136890: [lldb-vscode] Don't call SBValue.GetError after generating a summary..
Oct 27 2022, 4:11 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D136697: Add formatting support for VSCode logpoints message.

Address review comments.

Oct 27 2022, 3:57 PM · Restricted Project, Restricted Project
yinghuitan added inline comments to D136697: Add formatting support for VSCode logpoints message.
Oct 27 2022, 11:16 AM · Restricted Project, Restricted Project
yinghuitan added inline comments to D136697: Add formatting support for VSCode logpoints message.
Oct 27 2022, 11:13 AM · Restricted Project, Restricted Project

Oct 26 2022

yinghuitan updated the diff for D136697: Add formatting support for VSCode logpoints message.

Address review comments

Oct 26 2022, 9:31 AM · Restricted Project, Restricted Project
yinghuitan added inline comments to D136697: Add formatting support for VSCode logpoints message.
Oct 26 2022, 8:52 AM · Restricted Project, Restricted Project

Oct 25 2022

yinghuitan committed rG51effa57818b: Fix exception description in lldb-vscode (authored by yinghuitan).
Fix exception description in lldb-vscode
Oct 25 2022, 1:24 PM · Restricted Project
yinghuitan closed D136295: Fix exception description in lldb-vscode.
Oct 25 2022, 1:24 PM · Restricted Project, Restricted Project
yinghuitan requested review of D136697: Add formatting support for VSCode logpoints message.
Oct 25 2022, 9:50 AM · Restricted Project, Restricted Project

Oct 24 2022

yinghuitan added inline comments to D136177: [lldb-vscode] Send Statistics Dump in terminated event.
Oct 24 2022, 3:15 PM · Restricted Project, Restricted Project

Oct 20 2022

yinghuitan updated the diff for D136295: Fix exception description in lldb-vscode.

Fix comment

Oct 20 2022, 3:17 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D136295: Fix exception description in lldb-vscode.

Directly raise signal.

Oct 20 2022, 3:15 PM · Restricted Project, Restricted Project

Oct 19 2022

yinghuitan requested review of D136295: Fix exception description in lldb-vscode.
Oct 19 2022, 2:46 PM · Restricted Project, Restricted Project

Oct 18 2022

yinghuitan updated the diff for D135798: Add runToBinaryEntry option for lldb-vscode.

format

Oct 18 2022, 9:41 AM · Restricted Project, Restricted Project
yinghuitan updated the diff for D135798: Add runToBinaryEntry option for lldb-vscode.

Update message per feedback

Oct 18 2022, 9:38 AM · Restricted Project, Restricted Project
yinghuitan updated the diff for D135798: Add runToBinaryEntry option for lldb-vscode.

Use async model.

Oct 18 2022, 9:37 AM · Restricted Project, Restricted Project

Oct 12 2022

yinghuitan requested review of D135798: Add runToBinaryEntry option for lldb-vscode.
Oct 12 2022, 10:51 AM · Restricted Project, Restricted Project

Oct 11 2022

yinghuitan committed rGef25a217266a: Prevent lldb-vscode tests from source lldbinit file (authored by yinghuitan).
Prevent lldb-vscode tests from source lldbinit file
Oct 11 2022, 3:44 PM · Restricted Project
yinghuitan closed D135620: Prevent lldb-vscode tests from source lldbinit file.
Oct 11 2022, 3:43 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D135620: Prevent lldb-vscode tests from source lldbinit file.

Add comment per feedback

Oct 11 2022, 1:58 PM · Restricted Project, Restricted Project

Oct 10 2022

yinghuitan requested review of D135620: Prevent lldb-vscode tests from source lldbinit file.
Oct 10 2022, 3:03 PM · Restricted Project, Restricted Project

Sep 28 2022

yinghuitan accepted D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files..

I think @labath or anyone owns the ELF coredump debugging should take a look. I am surprised other major companies did not hit this issue.

Sep 28 2022, 9:54 PM · Restricted Project, Restricted Project
yinghuitan accepted D134333: When there are variable errors, display an error in VS Code's local variables view..
Sep 28 2022, 9:37 PM · Restricted Project, Restricted Project

Sep 27 2022

yinghuitan accepted D134508: Track which modules have debug info variable errors..
Sep 27 2022, 11:55 AM · Restricted Project, Restricted Project
yinghuitan accepted D134333: When there are variable errors, display an error in VS Code's local variables view..

LGTM pending Pavel's suggestion.

Sep 27 2022, 11:53 AM · Restricted Project, Restricted Project

Sep 22 2022

yinghuitan committed rGc5073ed5f929: Add auto source map deduce count statistics (authored by yinghuitan).
Add auto source map deduce count statistics
Sep 22 2022, 2:53 PM · Restricted Project
yinghuitan closed D134483: Add auto source map deduce count statistics.
Sep 22 2022, 2:53 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D134483: Add auto source map deduce count statistics.

rebase and trigger linter

Sep 22 2022, 2:47 PM · Restricted Project, Restricted Project
yinghuitan requested review of D134483: Add auto source map deduce count statistics.
Sep 22 2022, 2:36 PM · Restricted Project, Restricted Project

Sep 21 2022

yinghuitan accepted D134252: Track .dwo/.dwp loading errors and notify user when viewing variables..

Technical wise this patch looks good. One concern is that these error messages are user facing but we are making it favoring debugging, like skeleton DIE, showing the DIE offset etc... which is not very useful/actionable for end users.
Ideally, the user facing messages should focus on two things: 1. what is wrong in plain english. 2. any suggestion to fix it (e.g. ensure running lldb from build repo root). The more technical messages (with DIE offset) can be printed to log channel instead.

Sep 21 2022, 10:19 AM · Restricted Project, Restricted Project

Sep 19 2022

yinghuitan added a comment to D134252: Track .dwo/.dwp loading errors and notify user when viewing variables..

Do you plan to detect missing dwp file from SymbolFileDWARF::GetDwpSymbolFile() as well?

Sep 19 2022, 10:38 PM · Restricted Project, Restricted Project
yinghuitan committed rGdc9e6c52f3d8: Add auto deduce source map setting (authored by yinghuitan).
Add auto deduce source map setting
Sep 19 2022, 1:42 PM · Restricted Project
yinghuitan closed D133042: Add auto deduce source map setting.
Sep 19 2022, 1:41 PM · Restricted Project, Restricted Project

Sep 16 2022

yinghuitan updated the diff for D133042: Add auto deduce source map setting.

Fix nit

Sep 16 2022, 11:50 PM · Restricted Project, Restricted Project

Sep 15 2022

yinghuitan updated the diff for D133042: Add auto deduce source map setting.

Address review feedback

Sep 15 2022, 5:52 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D133042: Add auto deduce source map setting.

@clayborg, now I see you want to make this option true by default while full paths one to be optional. Then sure, it makes sense.

Sep 15 2022, 4:23 PM · Restricted Project, Restricted Project

Sep 14 2022

yinghuitan abandoned D133908: Add auto deduce source map setting.
Sep 14 2022, 5:27 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D133042: Add auto deduce source map setting.

Address review comments

Sep 14 2022, 5:26 PM · Restricted Project, Restricted Project
yinghuitan requested review of D133908: Add auto deduce source map setting.
Sep 14 2022, 5:25 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D133042: Add auto deduce source map setting.

@clayborg , it is my intention to make target.auto-deduce-source-map boolean flag ultimately working for both relative paths and two full paths (two full paths are really important for off build host debugging, e.g. dump or production debugging). In this patch, I focuses on getting relative path working because that's the default behavior; a follow-up patch can get two full paths working.
In my opinion boolean flag setting is dead simple to use (to enable both) and an enumeration setting would add extra barrier for adoption.

Sep 14 2022, 4:38 PM · Restricted Project, Restricted Project

Sep 12 2022

yinghuitan accepted D133164: Add the ability to show when variables fails to be available when debug info is valid..
Sep 12 2022, 1:46 PM · Restricted Project, Restricted Project
yinghuitan added inline comments to D133038: Add SBDebugger::GetSetting() public API.
Sep 12 2022, 10:25 AM · Restricted Project, Restricted Project

Sep 11 2022

yinghuitan committed rGd5f54751048b: Add SBDebugger::GetSetting() public APIs (authored by yinghuitan).
Add SBDebugger::GetSetting() public APIs
Sep 11 2022, 8:50 PM · Restricted Project
yinghuitan closed D133038: Add SBDebugger::GetSetting() public API.
Sep 11 2022, 8:50 PM · Restricted Project, Restricted Project

Sep 9 2022

yinghuitan updated the diff for D133038: Add SBDebugger::GetSetting() public API.

Address review comments

Sep 9 2022, 2:49 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D133038: Add SBDebugger::GetSetting() public API.

Address review comments

Sep 9 2022, 10:32 AM · Restricted Project, Restricted Project
yinghuitan added inline comments to D133038: Add SBDebugger::GetSetting() public API.
Sep 9 2022, 9:38 AM · Restricted Project, Restricted Project

Sep 8 2022

yinghuitan added a comment to D133038: Add SBDebugger::GetSetting() public API.
Sep 8 2022, 5:53 PM · Restricted Project, Restricted Project
yinghuitan retitled D133038: Add SBDebugger::GetSetting() public API from Add SBDebugger::GetSetting()public APIs to Add SBDebugger::GetSetting() public API.
Sep 8 2022, 5:52 PM · Restricted Project, Restricted Project
yinghuitan retitled D133038: Add SBDebugger::GetSetting() public API from Add SBDebugger::GetSetting()/GetSettings() public APIs to Add SBDebugger::GetSetting()public APIs.
Sep 8 2022, 5:52 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D133038: Add SBDebugger::GetSetting() public API.

Address review comments

Sep 8 2022, 5:48 PM · Restricted Project, Restricted Project
yinghuitan retitled D133038: Add SBDebugger::GetSetting() public API from Add GetSourceMap public API to Add SBDebugger::GetSetting()/GetSettings() public APIs.
Sep 8 2022, 11:23 AM · Restricted Project, Restricted Project
yinghuitan updated the diff for D133038: Add SBDebugger::GetSetting() public API.

Address review feedback.

Sep 8 2022, 11:22 AM · Restricted Project, Restricted Project

Sep 1 2022

yinghuitan updated the summary of D133042: Add auto deduce source map setting.
Sep 1 2022, 12:05 AM · Restricted Project, Restricted Project

Aug 31 2022

yinghuitan requested review of D133042: Add auto deduce source map setting.
Aug 31 2022, 12:17 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D133038: Add SBDebugger::GetSetting() public API.

Re-diff with clang-format

Aug 31 2022, 11:49 AM · Restricted Project, Restricted Project
yinghuitan requested review of D133038: Add SBDebugger::GetSetting() public API.
Aug 31 2022, 11:46 AM · Restricted Project, Restricted Project

Jul 13 2022

yinghuitan added a comment to D129307: Add a new breakpoint partial match settings.

From Jim, First off, I am supportive of your project, this is a pain point for some folks for sure. I am in favor of trying to automate "I built my binaries with sources in one location but locally they are in another" scenario.

Great to hear that! Seems all three companies are on the same page/goal to improve this area.

Jul 13 2022, 2:47 PM · Restricted Project, Restricted Project

Jul 12 2022

yinghuitan accepted D129528: Modify all register values whose byte size matches the address size to be formatter as eFormatAddressInfo..
Jul 12 2022, 5:17 PM · Restricted Project, Restricted Project

Jul 11 2022

yinghuitan added a comment to D129521: Add the ability to run expressions that call fork() or vfork()..

Change looks good to me. I will let @jingham take a second look before accepting.

Jul 11 2022, 9:54 PM · Restricted Project, Restricted Project
yinghuitan added inline comments to D129528: Modify all register values whose byte size matches the address size to be formatter as eFormatAddressInfo..
Jul 11 2022, 9:44 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D129307: Add a new breakpoint partial match settings.

@jingham, thanks for sharing the thoughts.

Jul 11 2022, 1:27 PM · Restricted Project, Restricted Project

Jul 7 2022

yinghuitan updated the diff for D129307: Add a new breakpoint partial match settings.

Remove unnecessary format changes caused by IDE.

Jul 7 2022, 10:14 AM · Restricted Project, Restricted Project
yinghuitan requested review of D129307: Add a new breakpoint partial match settings.
Jul 7 2022, 10:03 AM · Restricted Project, Restricted Project

Jun 24 2022

yinghuitan added a comment to D127702: Support logpoints in lldb-vscode.

@cmtice, are you sure the failure is caused by/related with this patch? This is a pure lldb-vscode change which is not used by normal lldb. Also, no mention of code in this patch in the error message.

Jun 24 2022, 12:41 PM · Restricted Project, Restricted Project

Jun 20 2022

yinghuitan committed rG5109de2da2e2: Fix build break introduced by https://reviews.llvm.org/D127702 (authored by yinghuitan).
Fix build break introduced by https://reviews.llvm.org/D127702
Jun 20 2022, 5:32 PM · Restricted Project
yinghuitan closed D128234: Fix build break introduced by https://reviews.llvm.org/D127702.
Jun 20 2022, 5:31 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D127702: Support logpoints in lldb-vscode.

Fixed in https://reviews.llvm.org/D128234

Jun 20 2022, 5:24 PM · Restricted Project, Restricted Project
yinghuitan requested review of D128234: Fix build break introduced by https://reviews.llvm.org/D127702.
Jun 20 2022, 5:23 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D127702: Support logpoints in lldb-vscode.

Sorry, I was fooled by the buildbot which says everything is green. Working on a fix for the build break now.

Jun 20 2022, 5:18 PM · Restricted Project, Restricted Project
yinghuitan committed rG8c6e138aa893: Support logpoints in lldb-vscode (authored by yinghuitan).
Support logpoints in lldb-vscode
Jun 20 2022, 4:22 PM · Restricted Project
yinghuitan closed D127702: Support logpoints in lldb-vscode.
Jun 20 2022, 4:22 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D127702: Support logpoints in lldb-vscode.

Using a single structured LogMessagePart per suggestion.

Jun 20 2022, 11:24 AM · Restricted Project, Restricted Project

Jun 14 2022

yinghuitan added inline comments to D127702: Support logpoints in lldb-vscode.
Jun 14 2022, 10:22 AM · Restricted Project, Restricted Project

Jun 13 2022

yinghuitan updated the summary of D127702: Support logpoints in lldb-vscode.
Jun 13 2022, 3:26 PM · Restricted Project, Restricted Project
yinghuitan requested review of D127702: Support logpoints in lldb-vscode.
Jun 13 2022, 3:24 PM · Restricted Project, Restricted Project