Page MenuHomePhabricator
Feed Advanced Search

Wed, May 13

huihuiz committed rGfd842d362662: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple. (authored by huihuiz).
[CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple.
Wed, May 13, 6:35 PM
huihuiz closed D79914: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple..
Wed, May 13, 6:35 PM · Restricted Project, Restricted Project
huihuiz created D79914: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple..
Wed, May 13, 4:57 PM · Restricted Project, Restricted Project

Thu, May 7

huihuiz added a comment to D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..

Looks like this breaks check-llvm at least on Linux: http://45.33.8.238/linux/17186/step_12.txt

Can you take a look? If it takes a while to fix, please revert while you investigate.

Thu, May 7, 2:08 PM · Restricted Project
huihuiz committed rGe8ea1eb4c1c6: [NFC] Adjust test check lines for D78267. (authored by huihuiz).
[NFC] Adjust test check lines for D78267.
Thu, May 7, 1:36 PM
huihuiz committed rG1ec0cc0f0243: [InstCombine][SVE] Fix visitExtractElementInst for scalable type. (authored by huihuiz).
[InstCombine][SVE] Fix visitExtractElementInst for scalable type.
Thu, May 7, 1:36 PM
huihuiz closed D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..
Thu, May 7, 1:35 PM · Restricted Project
huihuiz committed rG08c9c13749ae: [InstCombine][SVE] Fix visitInsertElementInst for scalable type. (authored by huihuiz).
[InstCombine][SVE] Fix visitInsertElementInst for scalable type.
Thu, May 7, 1:02 PM
huihuiz closed D78895: [InstCombine][SVE] Fix visitInsertElementInst for scalable type..
Thu, May 7, 1:02 PM · Restricted Project
huihuiz added a comment to D78895: [InstCombine][SVE] Fix visitInsertElementInst for scalable type..

Thanks! Fixed in the committed patch.

Thu, May 7, 1:02 PM · Restricted Project
huihuiz updated the diff for D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..

Address review comments.

Thu, May 7, 11:20 AM · Restricted Project
huihuiz updated the diff for D78895: [InstCombine][SVE] Fix visitInsertElementInst for scalable type..

Address review comments.

Thu, May 7, 10:47 AM · Restricted Project

Wed, Apr 29

huihuiz updated the diff for D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..

Thanks Eli for the feedback!
Please let me know if the fixes related to shuffle vector make sense to you.

Wed, Apr 29, 8:33 PM · Restricted Project
huihuiz added inline comments to D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..
Wed, Apr 29, 8:33 PM · Restricted Project
huihuiz updated the diff for D78895: [InstCombine][SVE] Fix visitInsertElementInst for scalable type..

Rebase.

Wed, Apr 29, 10:43 AM · Restricted Project

Mon, Apr 27

huihuiz updated the diff for D78895: [InstCombine][SVE] Fix visitInsertElementInst for scalable type..

Thanks Sander for the feedback!

Mon, Apr 27, 4:11 PM · Restricted Project

Sun, Apr 26

huihuiz added a comment to D78895: [InstCombine][SVE] Fix visitInsertElementInst for scalable type..
  1. Current upstream crash at:

llvm::ShuffleVectorInst::ShuffleVectorInst(llvm::Value *, llvm::Value *, ArrayRef<int>, const llvm::Twine &, llvm::Instruction *): Assertion `isValidOperands(V1, V2, Mask) && "Invalid shuffle vector instruction operands!"' failed.
take test.ll , run opt -S -instcombine test.ll

Sun, Apr 26, 10:19 PM · Restricted Project
huihuiz created D78895: [InstCombine][SVE] Fix visitInsertElementInst for scalable type..
Sun, Apr 26, 9:46 PM · Restricted Project

Apr 22 2020

huihuiz accepted D78688: [ValueTracking] Handle shufflevector constants in ComputeNumSignBits.

Looks fine with me.

Apr 22 2020, 8:38 PM · Restricted Project

Apr 16 2020

huihuiz added a comment to D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..

I am also looking at the related issues of shufflevector created by "extractelement, insertelement" pair.
Currently working on InstCombiner::visitInsertElementInst.

Apr 16 2020, 1:55 PM · Restricted Project
huihuiz updated the diff for D76655: [InstSimplify] Fix SimplifyGEPInst when GEP index type is vector type..

Thanks Eli for the feedback!

Apr 16 2020, 11:41 AM · Restricted Project

Apr 15 2020

huihuiz added a comment to D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..

Current upstream crash at llvm/include/llvm/ADT/APInt.h:1437: void llvm::APInt::setBit(unsigned int): Assertion `BitPosition < BitWidth && "BitPosition out of range"' failed.

Apr 15 2020, 9:17 PM · Restricted Project
huihuiz created D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..
Apr 15 2020, 9:17 PM · Restricted Project
huihuiz committed rG25db295756be: [NFC] Silence compiler warning [-Wmissing-braces]. (authored by huihuiz).
[NFC] Silence compiler warning [-Wmissing-braces].
Apr 15 2020, 12:06 PM

Apr 14 2020

huihuiz updated the diff for D76655: [InstSimplify] Fix SimplifyGEPInst when GEP index type is vector type..

My initial thought was wrong.
Spent sometime look again, we are nearly impossible to generate incorrect result without the code fixes in this patch.
But comparing a scalable size with a fixed size still doesn't make sense.

Apr 14 2020, 3:45 PM · Restricted Project
huihuiz committed rG5c1d1a62e375: [InstCombine][SVE] Fix visitGetElementPtrInst for scalable type. (authored by huihuiz).
[InstCombine][SVE] Fix visitGetElementPtrInst for scalable type.
Apr 14 2020, 12:59 PM
huihuiz closed D78081: [InstCombine][SVE] Fix visitGetElementPtrInst for scalable type..
Apr 14 2020, 12:58 PM · Restricted Project
huihuiz updated the diff for D78081: [InstCombine][SVE] Fix visitGetElementPtrInst for scalable type..

Thanks Eli for the feedbacks!
Yes, it's valid to use scalable type mininal size for inbounds checking.

Apr 14 2020, 10:10 AM · Restricted Project

Apr 13 2020

huihuiz added a comment to D78081: [InstCombine][SVE] Fix visitGetElementPtrInst for scalable type..

Current upstream crash at llvm/lib/IR/Constants.cpp:1674: static llvm::Constant *llvm::ConstantExpr::getCast(unsigned int, llvm::Constant *, llvm::Type *, bool): Assertion `CastInst::castIsValid(opc, C, Ty) && "Invalid constantexpr cast!"' failed.

Apr 13 2020, 10:24 PM · Restricted Project
huihuiz created D78081: [InstCombine][SVE] Fix visitGetElementPtrInst for scalable type..
Apr 13 2020, 10:14 PM · Restricted Project

Apr 12 2020

huihuiz committed rG4bde7c5986ee: [NFC] Use VectorType::isScalable to align with ongoing VectorType refactor. (authored by huihuiz).
[NFC] Use VectorType::isScalable to align with ongoing VectorType refactor.
Apr 12 2020, 4:01 PM
huihuiz committed rG8e2daa0c7f27: [NFC] Silence compiler warning [-Wmissing-braces]. (authored by huihuiz).
[NFC] Silence compiler warning [-Wmissing-braces].
Apr 12 2020, 2:57 PM

Apr 10 2020

huihuiz committed rG6e7eeb44b305: [GVN] Fix VNCoercion for Scalable Vector. (authored by huihuiz).
[GVN] Fix VNCoercion for Scalable Vector.
Apr 10 2020, 5:49 PM
huihuiz closed D76944: [GVN] Fix VNCoercion for Scalable Vector..
Apr 10 2020, 5:49 PM · Restricted Project
huihuiz committed rG6c989d024862: [BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type. (authored by huihuiz).
[BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type.
Apr 10 2020, 5:15 PM
huihuiz closed D77828: [BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type..
Apr 10 2020, 5:15 PM · Restricted Project
huihuiz added inline comments to D77828: [BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type..
Apr 10 2020, 3:04 PM · Restricted Project
huihuiz updated the diff for D77828: [BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type..

Address review comments.

Apr 10 2020, 3:04 PM · Restricted Project

Apr 9 2020

huihuiz added inline comments to D76944: [GVN] Fix VNCoercion for Scalable Vector..
Apr 9 2020, 4:53 PM · Restricted Project
huihuiz updated the diff for D76944: [GVN] Fix VNCoercion for Scalable Vector..

Address review comments.

Apr 9 2020, 4:53 PM · Restricted Project
huihuiz retitled D76944: [GVN] Fix VNCoercion for Scalable Vector. from [GVN] Fix VNCoercion/BasicAA for Scalable Vector. to [GVN] Fix VNCoercion for Scalable Vector..
Apr 9 2020, 4:53 PM · Restricted Project
huihuiz added a comment to D77828: [BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type..

Current upstream is producing wrong AliasResult for scalable type.

Apr 9 2020, 2:24 PM · Restricted Project
huihuiz added a parent revision for D77828: [BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type.: D76944: [GVN] Fix VNCoercion for Scalable Vector..
Apr 9 2020, 2:10 PM · Restricted Project
huihuiz created D77828: [BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type..
Apr 9 2020, 2:10 PM · Restricted Project
huihuiz added a child revision for D76944: [GVN] Fix VNCoercion for Scalable Vector.: D77828: [BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type..
Apr 9 2020, 2:10 PM · Restricted Project

Mar 30 2020

huihuiz added inline comments to D76944: [GVN] Fix VNCoercion for Scalable Vector..
Mar 30 2020, 10:16 AM · Restricted Project

Mar 27 2020

huihuiz created D76944: [GVN] Fix VNCoercion for Scalable Vector..
Mar 27 2020, 12:01 PM · Restricted Project

Mar 23 2020

huihuiz added a comment to D76655: [InstSimplify] Fix SimplifyGEPInst when GEP index type is vector type..

Take test.ll, run opt -S -instsimplify -o -
Then you will get the compiler warning: Compiler has made implicit assumption that TypeSize is not scalable.

Mar 23 2020, 5:27 PM · Restricted Project
huihuiz created D76655: [InstSimplify] Fix SimplifyGEPInst when GEP index type is vector type..
Mar 23 2020, 5:26 PM · Restricted Project

Mar 20 2020

huihuiz committed rG4f5af9d70dcc: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize() (authored by huihuiz).
[ValueTracking] Fix usage of DataLayout::getTypeStoreSize()
Mar 20 2020, 5:23 PM
huihuiz closed D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().
Mar 20 2020, 5:23 PM · Restricted Project
huihuiz committed rG1993f95f2b1e: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector. (authored by huihuiz).
[ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector.
Mar 20 2020, 3:13 PM
huihuiz closed D76464: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector..
Mar 20 2020, 3:13 PM · Restricted Project
huihuiz updated the diff for D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().
Mar 20 2020, 3:12 PM · Restricted Project
huihuiz added inline comments to D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().
Mar 20 2020, 2:40 PM · Restricted Project
huihuiz updated the diff for D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().

Address review comments.

Mar 20 2020, 2:40 PM · Restricted Project
huihuiz added inline comments to D76464: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector..
Mar 20 2020, 10:17 AM · Restricted Project
huihuiz updated the diff for D76464: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector..

Address review comments.

Mar 20 2020, 10:17 AM · Restricted Project

Mar 19 2020

huihuiz created D76464: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector..
Mar 19 2020, 5:00 PM · Restricted Project
huihuiz created D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().
Mar 19 2020, 2:14 PM · Restricted Project

Mar 18 2020

huihuiz committed rG2ea5495759f6: [InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector. (authored by huihuiz).
[InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector.
Mar 18 2020, 9:10 PM
huihuiz closed D76386: [InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector..
Mar 18 2020, 9:09 PM · Restricted Project
huihuiz added inline comments to D76386: [InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector..
Mar 18 2020, 9:09 PM · Restricted Project
huihuiz created D76386: [InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector..
Mar 18 2020, 2:40 PM · Restricted Project

Mar 17 2020

huihuiz committed rG1bf0c9937583: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector. (authored by huihuiz).
[ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector.
Mar 17 2020, 11:50 AM
huihuiz closed D76260: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector..
Mar 17 2020, 11:49 AM · Restricted Project

Mar 16 2020

huihuiz updated the diff for D76260: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector..
Mar 16 2020, 5:31 PM · Restricted Project
huihuiz updated the diff for D76260: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector..

minor update test name

Mar 16 2020, 4:57 PM · Restricted Project
huihuiz created D76260: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector..
Mar 16 2020, 4:57 PM · Restricted Project
huihuiz committed rG0616e9964b9e: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector. (authored by huihuiz).
[InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector.
Mar 16 2020, 12:02 PM
huihuiz closed D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector..
Mar 16 2020, 12:02 PM · Restricted Project
huihuiz added inline comments to D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector..
Mar 16 2020, 12:01 PM · Restricted Project

Mar 13 2020

huihuiz committed rGfc1f20574500: [SLPVectorizer][SVE] Bail out early for scalable vector. (authored by huihuiz).
[SLPVectorizer][SVE] Bail out early for scalable vector.
Mar 13 2020, 11:50 AM
huihuiz closed D76017: [SLPVectorizer][SVE] Bail out early for scalable vector..
Mar 13 2020, 11:50 AM · Restricted Project

Mar 12 2020

huihuiz committed rGf4f2706572b1: [ConstantFold][SVE] Fix constant folding for scalable vector compare… (authored by huihuiz).
[ConstantFold][SVE] Fix constant folding for scalable vector compare…
Mar 12 2020, 4:18 PM
huihuiz closed D73753: [ConstantFold][SVE] Fix constant folding for scalable vector compare instruction..
Mar 12 2020, 4:18 PM · Restricted Project
huihuiz updated the summary of D76017: [SLPVectorizer][SVE] Bail out early for scalable vector..
Mar 12 2020, 3:45 PM · Restricted Project
huihuiz updated the diff for D76017: [SLPVectorizer][SVE] Bail out early for scalable vector..
Mar 12 2020, 3:45 PM · Restricted Project
huihuiz added inline comments to D76017: [SLPVectorizer][SVE] Bail out early for scalable vector..
Mar 12 2020, 3:45 PM · Restricted Project
huihuiz committed rG118abf201738: [SVE] Update API ConstantVector::getSplat() to use ElementCount. (authored by huihuiz).
[SVE] Update API ConstantVector::getSplat() to use ElementCount.
Mar 12 2020, 1:35 PM
huihuiz closed D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount..
Mar 12 2020, 1:34 PM · Restricted Project, Restricted Project
huihuiz added inline comments to D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector..
Mar 12 2020, 1:34 PM · Restricted Project
huihuiz updated the diff for D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector..

Add more test to check the code path, as suggested.

Mar 12 2020, 1:34 PM · Restricted Project
huihuiz added inline comments to D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount..
Mar 12 2020, 11:56 AM · Restricted Project, Restricted Project
huihuiz updated the diff for D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount..

Addressed review comments.

Mar 12 2020, 11:56 AM · Restricted Project, Restricted Project

Mar 11 2020

huihuiz committed rG8f525739622d: [InstSimplify][SVE] Fix SimplifyInsert/ExtractElementInst for scalable vector. (authored by huihuiz).
[InstSimplify][SVE] Fix SimplifyInsert/ExtractElementInst for scalable vector.
Mar 11 2020, 3:21 PM
huihuiz closed D75782: [InstSimplify][SVE] Fix SimplifyInsert/ExtractElementInst for scalable vector..
Mar 11 2020, 3:21 PM · Restricted Project
huihuiz added a comment to D76017: [SLPVectorizer][SVE] Bail out early for scalable vector..

take test test/Transforms/SLPVectorizer/AArch64/scalable-vector.ll, run opt -slp-vectorizer

Mar 11 2020, 11:52 AM · Restricted Project
huihuiz created D76017: [SLPVectorizer][SVE] Bail out early for scalable vector..
Mar 11 2020, 11:52 AM · Restricted Project

Mar 9 2020

huihuiz added a comment to D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector..

take test.ll, run: opt -S -instsimplify test.ll -o -

Mar 9 2020, 10:38 PM · Restricted Project
huihuiz created D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector..
Mar 9 2020, 10:38 PM · Restricted Project

Mar 6 2020

huihuiz added a comment to D75782: [InstSimplify][SVE] Fix SimplifyInsert/ExtractElementInst for scalable vector..

Current upstream is doing wrong fold for scalable vectors.

Mar 6 2020, 4:34 PM · Restricted Project
huihuiz created D75782: [InstSimplify][SVE] Fix SimplifyInsert/ExtractElementInst for scalable vector..
Mar 6 2020, 4:34 PM · Restricted Project

Mar 2 2020

huihuiz committed rG44fa47c9e7ea: [ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore. (authored by huihuiz).
[ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore.
Mar 2 2020, 4:38 PM
huihuiz closed D75288: [ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore..
Mar 2 2020, 4:38 PM · Restricted Project

Feb 28 2020

huihuiz updated the diff for D75288: [ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore..

Thank you so much Oliver Stannard for the review!

Feb 28 2020, 11:30 AM · Restricted Project

Feb 27 2020

huihuiz updated the diff for D75288: [ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore..

reduce test a bit

Feb 27 2020, 2:41 PM · Restricted Project
huihuiz added a comment to D75288: [ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore..

you can see the mis-alignment, the StackAlignment is 8 for this test

Feb 27 2020, 12:23 PM · Restricted Project
huihuiz added a reviewer for D75288: [ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore.: samparker.
Feb 27 2020, 12:23 PM · Restricted Project
huihuiz created D75288: [ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore..
Feb 27 2020, 12:23 PM · Restricted Project