bump - @njames93 let me know if you have any further feedback. thanks!

• Fix compile for non-libc++

Feedback and rebase

bump please?

rebase

Addressed all comments except for the handleReturnType one which I responded to - let me know your thoughts, thanks!

• Better handling for ctor inits

Fix bug, other cleanups, rebase

• fix merge

Note, @PiotrZSL I don't have commit access, so if you're happy with the updates, could you please land this for me?

rebase

• feedback

bump?

Fix tests

• format

arc diff properly

rebase

refactor

> Would you consider supporting enable_if via parameters

feedback+rebase

bump - any other feedback?

• Rename

lgtm

• format

• Add tests for char[]

• Fix double curly brace matching in tests

• format

• format

rebase

rebase

• Use common function

If https://github.com/isocpp/CppCoreGuidelines/issues/2060 is accepted to only consider [=], then I assume we'd want to change the default value of IgnoreCaptureDefaultByReference to be true? Thanks by the way for this!

@PiotrZSL if you're happy with these changes, would you mind committing them for me? "Chris Cotter <ccotter14@bloomberg.net>"

In D140760#4222989, @PiotrZSL wrote:

What about classes that doesn't have begin/end method but got cbegin/cend ?
I thing there is open issue for that.

• fix docs, fix test

• move to utility file

@Febbe - checking in. is this still on your radar? I would love to see this merged!

• alpha

• fix bad rebase

bump - I know this is really old, but @lewmpk do you plan on finishing up the last remaining comments?

I didn't update the release notes since this check is new.

rebase

rebase

• add tests, simplify expr, handle unevaluated exprs
• formatting

• add tests, simplify expr, handle unevaluated exprs

Is it worth adding a cppcoreguidelines alias (ES.56)?

Indeed - sorry i missed that

• feedback

• Add more cases to swapped params
• Change message, add more tests

rebase

Thanks!

Yes, I'm ready for this to be committed. I don't have commit access, but if anyone could commit this on my behalf with Chris Cotter <ccotter14@bloomberg.net> that'd be great!

• Add option doc, remove auto

bump. I never heard back on the case where using an rvalue reference for a big pod type as opposed to const ref.

• Add another test case

• Add more tests for whitespace

Thanks both! Assuming this passes build, would one of you mind committing this for me? Chris Cotter <ccotter14@bloomberg.net>

fix bad 'arc diff'

• update release note, rebase

Thanks!

I don't have commit access - could you use Author: Chris Cotter <ccotter14@bloomberg.net>? Thanks!

Thanks for the name suggestion

• More clean option name

• Add comment regarding std::begin/end

Bump - anyone else have any thoughts here?

• Add more cases to swapped params

I'm not sure about the false positive case. Range based for loops reduce to calls to ADL lookup begin/end (or member function calls to begin/end). I believe the same "false positive" argument (whatever that may be) would apply in an equivalent manner to the member call case.

• Add negative test case
• Fix logic to only consider std:: or ADL calls

• fix bad merge in ReleaseNotes

• Address feedback

Friendly ping.