In principle, this looks pretty similar to D67942, and my opinion on it is the same -- I don't think we should be in the business of trying to package the transitive set of lldb dependencies. I think the lldb install target should install the stuff that it has built itself, and the rest should be up to some higher level packaging system.
Nov 7 2019
Nov 6 2019
@hhb I just did, and get the same error as well :(
ninja: error: 'bin/LLDB.framework/LLDB', needed by 'bin/LLDB.framework/Resources/Python/lldb/_lldb.so', missing and no known rule to make it
Nov 5 2019
Fix some naming
Nov 4 2019
Sent D69834. Haven't get a chance to test but you can see the idea...
See D68370. We probably need to do the same thing for darwin...
Alternatively we should not depends on install-liblldb to install python packages, but have a install command similar to what we did below for other platforms.
I fixed this locally by doing this (this fix doesn't really feel good but not sure what's the best way to do it):
Oct 30 2019
When creating symlink, make the target depends on relative target path. So that if the target file doesn't exist, the build will fail.
Update one more place
This looks reasonable to me. I'm just wondering, now that these are separate targets, I guess that means they can be run in random order, right? Will that cause any problems, for instance when creating a package and its subpackage (formatters and formatters/cpp maybe)?
Oct 29 2019
Oct 28 2019
Oct 27 2019
Right. I see what you mean.
But... does this have to happen at build time? Since the list of files is already known at configuration time, you should be able to generate the files in the "cmake" step (but still leave the copying for the build step, so that any changes to the files are reflected in rebuilds).
(I'm not insisting on that -- I think that the current patch is already much better than what we had before. If you think that the python script is better than that, feel free to say so.)
Oct 25 2019
I'm sorry, this dropped off my radar. The only question I have here is about the createPythonInit.py script. If we're moving stuff to cmake, I am wondering if we shouldn't move that thing too? It doesn't look like the code is doing anything which would be hard to replicate in cmake. WDYT ?
Oct 16 2019
I'm not sure if I like the usage of POST_BUILD stuff (it provides less control than separate targets) but overall this seems a good change. Replacing ~250 lines of reinventing the wheel with ~20 lines.
Oct 15 2019
One additional statement in openSUSE comparing to standard python:
libdir = plat_specific and get_config_var("platlibdir") or "lib"
Python 3.6.8 (default, Apr 30 2019, 13:27:23) [GCC] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import distutils.sysconfig >>> print(distutils.sysconfig.get_python_lib(True, False, '')) lib64/python3.6/site-packages >>> print(distutils.sysconfig.get_python_lib(True, False, '/abc')) /abc/lib64/python3.6/site-packages >>> print(distutils.sysconfig.get_python_lib(True, False)) /usr/lib64/python3.6/site-packages >>> print(distutils.sysconfig.get_python_lib(False, False, '')) lib/python3.6/site-packages >>> print(distutils.sysconfig.get_python_lib(False, False, '/abc')) /abc/lib/python3.6/site-packages >>> print(distutils.sysconfig.get_python_lib(False, False)) /usr/lib/python3.6/site-packages
This is interesting...
Build and installation completed successfully! LGTM, though it would be good if anyone tests this with Xcode.
Can you sync to the latest code and try again? Your problem is likely to be fixed in a previous change...
Oct 14 2019
Oops fix typo.
Fix the build for multi-config generator.
Oct 11 2019
Fix file copy path
Fix file copy path
Oct 10 2019
Remove tailing whitespace
Oct 9 2019
Simplify the path
Oct 7 2019
This is merged as 61f471a and 0016b45. Closing...
Reverts the change related to python dir for windows.
Converts python output path to cmake format.
Cool work. I presume you've tested it. I can test it tomorrow if you need me to. However, I can do that after the commit.
Oct 5 2019
Oct 4 2019
Oct 3 2019