Page MenuHomePhabricator
Feed Advanced Search

Nov 7 2019

hhb added a comment to D69931: Add rpath to liblldb so vendors can ship their own python framework (or others).

In principle, this looks pretty similar to D67942, and my opinion on it is the same -- I don't think we should be in the business of trying to package the transitive set of lldb dependencies. I think the lldb install target should install the stuff that it has built itself, and the rest should be up to some higher level packaging system.

Nov 7 2019, 3:04 PM · Restricted Project
hhb closed D69630: [lldb] Record framework build path and use it everywhere.
Nov 7 2019, 3:04 PM · Restricted Project

Nov 6 2019

hhb committed rG77a60f0df673: [lldb] Record framework build path and use it everywhere (authored by hhb).
[lldb] Record framework build path and use it everywhere
Nov 6 2019, 2:11 PM
hhb added a comment to D69589: [lldb] Refactor all POST_BUILD commands into targets.

@hhb I just did, and get the same error as well :(
ninja: error: 'bin/LLDB.framework/LLDB', needed by 'bin/LLDB.framework/Resources/Python/lldb/_lldb.so', missing and no known rule to make it

Nov 6 2019, 12:48 PM · Restricted Project

Nov 5 2019

hhb added a comment to D69589: [lldb] Refactor all POST_BUILD commands into targets.

@hhb fwiw, I still get the same error with this diff (after applying it on top of D69834). But D69834 by itself works great!

Nov 5 2019, 3:42 PM · Restricted Project
hhb updated the diff for D69589: [lldb] Refactor all POST_BUILD commands into targets.

Fix some naming

Nov 5 2019, 3:33 PM · Restricted Project
hhb updated the diff for D69589: [lldb] Refactor all POST_BUILD commands into targets.

Rebase

Nov 5 2019, 1:43 PM · Restricted Project
hhb committed rG6a79e083a0d1: [lldb] Add a install target for lldb python on darwin (authored by hhb).
[lldb] Add a install target for lldb python on darwin
Nov 5 2019, 1:34 PM
hhb closed D69834: [lldb] Add a install target for lldb python on darwin.
Nov 5 2019, 1:34 PM · Restricted Project
hhb updated the diff for D69834: [lldb] Add a install target for lldb python on darwin.

Rebase

Nov 5 2019, 1:34 PM · Restricted Project

Nov 4 2019

hhb added a comment to D69589: [lldb] Refactor all POST_BUILD commands into targets.

Sent D69834. Haven't get a chance to test but you can see the idea...

Nov 4 2019, 5:09 PM · Restricted Project
hhb created D69834: [lldb] Add a install target for lldb python on darwin.
Nov 4 2019, 5:06 PM · Restricted Project
hhb added a comment to D69589: [lldb] Refactor all POST_BUILD commands into targets.

See D68370. We probably need to do the same thing for darwin...

Nov 4 2019, 5:06 PM · Restricted Project
hhb added a comment to D69589: [lldb] Refactor all POST_BUILD commands into targets.

Alternatively we should not depends on install-liblldb to install python packages, but have a install command similar to what we did below for other platforms.

Nov 4 2019, 4:29 PM · Restricted Project
hhb added a comment to D69589: [lldb] Refactor all POST_BUILD commands into targets.

I fixed this locally by doing this (this fix doesn't really feel good but not sure what's the best way to do it):

Nov 4 2019, 4:20 PM · Restricted Project

Oct 30 2019

hhb updated the diff for D69589: [lldb] Refactor all POST_BUILD commands into targets.

When creating symlink, make the target depends on relative target path. So that if the target file doesn't exist, the build will fail.

Oct 30 2019, 5:14 PM · Restricted Project
hhb updated the diff for D69630: [lldb] Record framework build path and use it everywhere.

Fix

Oct 30 2019, 1:34 PM · Restricted Project
hhb updated the diff for D69630: [lldb] Record framework build path and use it everywhere.

Update one more place

Oct 30 2019, 11:21 AM · Restricted Project
hhb created D69630: [lldb] Record framework build path and use it everywhere.
Oct 30 2019, 10:41 AM · Restricted Project
hhb added a comment to D69589: [lldb] Refactor all POST_BUILD commands into targets.

This looks reasonable to me. I'm just wondering, now that these are separate targets, I guess that means they can be run in random order, right? Will that cause any problems, for instance when creating a package and its subpackage (formatters and formatters/cpp maybe)?

Oct 30 2019, 10:02 AM · Restricted Project

Oct 29 2019

hhb created D69589: [lldb] Refactor all POST_BUILD commands into targets.
Oct 29 2019, 3:31 PM · Restricted Project

Oct 28 2019

hhb committed rG99046b873f7f: [lldb] move package generation from python to cmake (authored by hhb).
[lldb] move package generation from python to cmake
Oct 28 2019, 5:53 PM
hhb closed D69019: [lldb] move package generation from python to cmake.
Oct 28 2019, 5:53 PM · Restricted Project
hhb updated the diff for D69019: [lldb] move package generation from python to cmake.

Rebase

Oct 28 2019, 4:51 PM · Restricted Project

Oct 27 2019

hhb added a comment to D69019: [lldb] move package generation from python to cmake.

Right. I see what you mean.

But... does this have to happen at build time? Since the list of files is already known at configuration time, you should be able to generate the files in the "cmake" step (but still leave the copying for the build step, so that any changes to the files are reflected in rebuilds).

(I'm not insisting on that -- I think that the current patch is already much better than what we had before. If you think that the python script is better than that, feel free to say so.)

Oct 27 2019, 4:41 PM · Restricted Project

Oct 25 2019

hhb added a comment to D69019: [lldb] move package generation from python to cmake.

I'm sorry, this dropped off my radar. The only question I have here is about the createPythonInit.py script. If we're moving stuff to cmake, I am wondering if we shouldn't move that thing too? It doesn't look like the code is doing anything which would be hard to replicate in cmake. WDYT ?

Oct 25 2019, 4:11 PM · Restricted Project

Oct 16 2019

hhb committed rG1d4a40751ff3: [lldb] move more things from python to cmake (authored by hhb).
[lldb] move more things from python to cmake
Oct 16 2019, 11:06 AM
hhb committed rL375024: [lldb] move more things from python to cmake.
[lldb] move more things from python to cmake
Oct 16 2019, 11:05 AM
hhb closed D69016: [lldb] move more things from python to cmake.
Oct 16 2019, 11:05 AM · Restricted Project
hhb added a reviewer for D69019: [lldb] move package generation from python to cmake: labath.
Oct 16 2019, 11:05 AM · Restricted Project
hhb updated the diff for D69019: [lldb] move package generation from python to cmake.

Format

Oct 16 2019, 11:05 AM · Restricted Project
hhb updated the diff for D69019: [lldb] move package generation from python to cmake.

Rebase

Oct 16 2019, 11:05 AM · Restricted Project
hhb added a comment to D69016: [lldb] move more things from python to cmake.

I'm not sure if I like the usage of POST_BUILD stuff (it provides less control than separate targets) but overall this seems a good change. Replacing ~250 lines of reinventing the wheel with ~20 lines.

Oct 16 2019, 9:50 AM · Restricted Project

Oct 15 2019

hhb created D69019: [lldb] move package generation from python to cmake.
Oct 15 2019, 10:25 PM · Restricted Project
hhb planned changes to D69019: [lldb] move package generation from python to cmake.
Oct 15 2019, 10:25 PM · Restricted Project
hhb created D69016: [lldb] move more things from python to cmake.
Oct 15 2019, 8:18 PM · Restricted Project
hhb committed rL374968: Request commit access for hhb.
Request commit access for hhb
Oct 15 2019, 7:38 PM
hhb committed rG208e9c01fc09: [lldb] Creates _liblldb symlink from cmake (authored by hhb).
[lldb] Creates _liblldb symlink from cmake
Oct 15 2019, 3:00 PM
hhb committed rL374953: [lldb] Creates _liblldb symlink from cmake.
[lldb] Creates _liblldb symlink from cmake
Oct 15 2019, 3:00 PM
hhb closed D68858: [lldb] Creates _liblldb symlink from cmake.
Oct 15 2019, 3:00 PM · Restricted Project
hhb added a comment to D68910: python path should be platform-dependent.

One additional statement in openSUSE comparing to standard python:

libdir = plat_specific and get_config_var("platlibdir") or "lib"
Oct 15 2019, 2:51 PM · Restricted Project
hhb added a comment to D68910: python path should be platform-dependent.
Python 3.6.8 (default, Apr 30 2019, 13:27:23) [GCC] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import distutils.sysconfig
>>> print(distutils.sysconfig.get_python_lib(True, False, ''))
lib64/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(True, False, '/abc'))
/abc/lib64/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(True, False))
/usr/lib64/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(False, False, ''))
lib/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(False, False, '/abc'))
/abc/lib/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(False, False))
/usr/lib/python3.6/site-packages

This is interesting...

Oct 15 2019, 2:41 PM · Restricted Project
hhb accepted D68910: python path should be platform-dependent.

How about this one?

Oct 15 2019, 2:23 PM · Restricted Project
hhb added a comment to D68858: [lldb] Creates _liblldb symlink from cmake.

Build and installation completed successfully! LGTM, though it would be good if anyone tests this with Xcode.

Oct 15 2019, 10:49 AM · Restricted Project
hhb requested changes to D68910: python path should be platform-dependent.

Can you sync to the latest code and try again? Your problem is likely to be fixed in a previous change...

Oct 15 2019, 10:48 AM · Restricted Project

Oct 14 2019

hhb added inline comments to D68858: [lldb] Creates _liblldb symlink from cmake.
Oct 14 2019, 10:34 PM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Oops fix typo.

Oct 14 2019, 9:48 PM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Fix the build for multi-config generator.

Oct 14 2019, 9:36 PM · Restricted Project
hhb planned changes to D68858: [lldb] Creates _liblldb symlink from cmake.
Oct 14 2019, 1:06 PM · Restricted Project

Oct 11 2019

hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Adds VERBATIM

Oct 11 2019, 4:23 PM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Fix typo

Oct 11 2019, 11:55 AM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Fix file copy path

Oct 11 2019, 11:55 AM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Fix file copy path

Oct 11 2019, 11:55 AM · Restricted Project
hhb added inline comments to D68719: Fix issue when building with Visual Studio.
Oct 11 2019, 11:37 AM · Restricted Project
hhb added reviewers for D68858: [lldb] Creates _liblldb symlink from cmake: labath, jingham, tatyana-krasnukha.
Oct 11 2019, 11:37 AM · Restricted Project
hhb committed rG6aacd9687543: [lldb] Fix python packages install path (authored by hhb).
[lldb] Fix python packages install path
Oct 11 2019, 10:43 AM
hhb closed D68878: [lldb] Fix python packages install path.
Oct 11 2019, 10:43 AM · Restricted Project
hhb committed rL374577: [lldb] Fix python packages install path.
[lldb] Fix python packages install path
Oct 11 2019, 10:42 AM
hhb created D68878: [lldb] Fix python packages install path.
Oct 11 2019, 10:14 AM · Restricted Project

Oct 10 2019

hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Remove tailing whitespace

Oct 10 2019, 10:52 PM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Rebase

Oct 10 2019, 10:42 PM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Fix format

Oct 10 2019, 10:42 PM · Restricted Project
hhb created D68858: [lldb] Creates _liblldb symlink from cmake.
Oct 10 2019, 10:42 PM · Restricted Project
hhb committed rG7b9900dff3c0: Clean up format in cmake file (authored by hhb).
Clean up format in cmake file
Oct 10 2019, 5:13 PM
hhb closed D68842: Clean up format in cmake file.
Oct 10 2019, 5:13 PM · Restricted Project
hhb committed rL374483: Clean up format in cmake file.
Clean up format in cmake file
Oct 10 2019, 5:13 PM
hhb created D68842: Clean up format in cmake file.
Oct 10 2019, 5:04 PM · Restricted Project
hhb added inline comments to D68719: Fix issue when building with Visual Studio.
Oct 10 2019, 2:43 PM · Restricted Project
hhb added inline comments to D68719: Fix issue when building with Visual Studio.
Oct 10 2019, 1:46 PM · Restricted Project

Oct 9 2019

hhb committed rG1a509417714d: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR (authored by hhb).
[lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR
Oct 9 2019, 3:35 PM
hhb closed D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR.
Oct 9 2019, 3:34 PM · Restricted Project
hhb committed rL374250: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR.
[lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR
Oct 9 2019, 3:34 PM
hhb updated the diff for D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR.

Simplify the path

Oct 9 2019, 2:31 PM · Restricted Project
hhb updated the summary of D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR.
Oct 9 2019, 2:12 PM · Restricted Project
hhb added a comment to D68719: Fix issue when building with Visual Studio.

I think this is caused by D68442. Can you check whether D68728 fixes it?

Oct 9 2019, 2:12 PM · Restricted Project
hhb updated the diff for D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR.

Fix format

Oct 9 2019, 2:07 PM · Restricted Project
hhb created D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR.
Oct 9 2019, 2:06 PM · Restricted Project

Oct 7 2019

hhb committed rG0016b450bee8: [lldb] Reverts part of 61f471a (authored by hhb).
[lldb] Reverts part of 61f471a
Oct 7 2019, 10:25 PM
hhb committed rL373998: [lldb] Reverts part of 61f471a.
[lldb] Reverts part of 61f471a
Oct 7 2019, 10:25 PM
hhb committed rG61f471a705a5: [lldb] Unifying lldb python path (authored by hhb).
[lldb] Unifying lldb python path
Oct 7 2019, 10:24 PM
hhb committed rL373991: [lldb] Unifying lldb python path.
[lldb] Unifying lldb python path
Oct 7 2019, 10:24 PM
hhb closed D68442: [lldb] Unifying lldb python path.

This is merged as 61f471a and 0016b45. Closing...

Oct 7 2019, 5:36 PM · Restricted Project
hhb updated the diff for D68442: [lldb] Unifying lldb python path.

Reverts the change related to python dir for windows.

Oct 7 2019, 5:09 PM · Restricted Project
hhb updated the diff for D68442: [lldb] Unifying lldb python path.

Converts python output path to cmake format.

Oct 7 2019, 4:10 PM · Restricted Project
hhb abandoned D67988: [lldb] clean up lldb/scripts a little bit.
Oct 7 2019, 1:59 PM · Restricted Project
hhb added a comment to D68442: [lldb] Unifying lldb python path.

Cool work. I presume you've tested it. I can test it tomorrow if you need me to. However, I can do that after the commit.

Oct 7 2019, 12:53 PM · Restricted Project
hhb updated the diff for D68442: [lldb] Unifying lldb python path.

Fix comments

Oct 7 2019, 12:47 PM · Restricted Project
hhb added inline comments to D68442: [lldb] Unifying lldb python path.
Oct 7 2019, 12:47 PM · Restricted Project

Oct 5 2019

hhb added inline comments to D68442: [lldb] Unifying lldb python path.
Oct 5 2019, 10:00 AM · Restricted Project
hhb added inline comments to D68442: [lldb] Unifying lldb python path.
Oct 5 2019, 9:50 AM · Restricted Project

Oct 4 2019

hhb updated the summary of D68442: [lldb] Unifying lldb python path.
Oct 4 2019, 5:39 PM · Restricted Project
hhb updated the diff for D68442: [lldb] Unifying lldb python path.

Rebase

Oct 4 2019, 5:39 PM · Restricted Project
hhb updated the summary of D68442: [lldb] Unifying lldb python path.
Oct 4 2019, 5:39 PM · Restricted Project
hhb added reviewers for D68442: [lldb] Unifying lldb python path: labath, mgorny.
Oct 4 2019, 5:23 PM · Restricted Project

Oct 3 2019

hhb updated the diff for D68442: [lldb] Unifying lldb python path.

Fix description..

Oct 3 2019, 9:52 PM · Restricted Project
hhb retitled D68442: [lldb] Unifying lldb python path from [lldb] Remove unused variables. to [lldb] Unifying lldb python path.
Oct 3 2019, 9:52 PM · Restricted Project
hhb created D68442: [lldb] Unifying lldb python path.
Oct 3 2019, 9:50 PM · Restricted Project
hhb updated the diff for D67988: [lldb] clean up lldb/scripts a little bit.

Fix comment

Oct 3 2019, 4:31 PM · Restricted Project
hhb abandoned D67583: Fix swig python package path.
Oct 3 2019, 4:20 PM · Restricted Project, Restricted Project
hhb committed rG48b38c93bc02: [lldb] Remove unused variables. (authored by hhb).
[lldb] Remove unused variables.
Oct 3 2019, 2:56 PM