Page MenuHomePhabricator
Feed Advanced Search

Thu, May 9

mattd accepted D61676: [MCA] Add support for nested and overlapping region markers.
Thu, May 9, 7:41 AM · Restricted Project

Wed, May 8

mattd added a comment to D61676: [MCA] Add support for nested and overlapping region markers.

This looks nice! We should probably also have a test for the case where a user specifies an END before a BEGIN tag.

Wed, May 8, 9:11 PM · Restricted Project

Apr 22 2019

mattd committed rG55043e2336c0: [sema][objc] Minor refactor to OverrideSearch. NFCI. (authored by mattd).
[sema][objc] Minor refactor to OverrideSearch. NFCI.
Apr 22 2019, 9:03 AM
mattd committed rL358898: [sema][objc] Minor refactor to OverrideSearch. NFCI..
[sema][objc] Minor refactor to OverrideSearch. NFCI.
Apr 22 2019, 9:02 AM
mattd committed rC358898: [sema][objc] Minor refactor to OverrideSearch. NFCI..
[sema][objc] Minor refactor to OverrideSearch. NFCI.
Apr 22 2019, 9:02 AM
mattd closed D60850: [sema][objc] Minor refactor to OverrideSearch. NFCI..
Apr 22 2019, 9:02 AM · Restricted Project

Apr 19 2019

mattd updated the diff for D60850: [sema][objc] Minor refactor to OverrideSearch. NFCI..

Thanks for the review, I addressed your comments:

  • Removed the reference, and pass the AST node as a pointer.
  • Made a few decls auto
Apr 19 2019, 8:26 AM · Restricted Project

Apr 17 2019

mattd created D60850: [sema][objc] Minor refactor to OverrideSearch. NFCI..
Apr 17 2019, 9:17 PM · Restricted Project

Apr 2 2019

mattd added a comment to D60170: [llvm-objcopy] [llvm-symbolizer] Fix failing tests.

LGTM, I'll let @jhenderson weigh-in to see what he says.

Apr 2 2019, 9:00 PM · Restricted Project
mattd added a comment to D60134: [llvm-nm]Add support for --no-demangle.

LGTM, as long as @rupprecht's comment is addressed.

Apr 2 2019, 8:24 PM · Restricted Project
mattd accepted D60134: [llvm-nm]Add support for --no-demangle.
Apr 2 2019, 8:24 PM · Restricted Project

Apr 1 2019

mattd added a comment to D53832: Make instrprof-set-dir-mode test tolerant of group ID.

Could you simply rebase the patch, or acknowledge the new LLVM license, as your patch was written prior to the license change.

My organization (Cray Inc) already signed the new license agreement, so I'm not sure what you need here. I can write that I acknowledge the new LLVM license, if that helps.

Apr 1 2019, 8:27 PM · Restricted Project, Restricted Project
mattd committed rG60a8816c2fc8: [compiler-rt][test] Make instrprof-set-dir-mode test tolerant of group ID (authored by mattd).
[compiler-rt][test] Make instrprof-set-dir-mode test tolerant of group ID
Apr 1 2019, 8:25 PM
mattd committed rCRT357449: [compiler-rt][test] Make instrprof-set-dir-mode test tolerant of group ID.
[compiler-rt][test] Make instrprof-set-dir-mode test tolerant of group ID
Apr 1 2019, 8:25 PM
mattd committed rL357449: [compiler-rt][test] Make instrprof-set-dir-mode test tolerant of group ID.
[compiler-rt][test] Make instrprof-set-dir-mode test tolerant of group ID
Apr 1 2019, 8:25 PM
mattd closed D53832: Make instrprof-set-dir-mode test tolerant of group ID.
Apr 1 2019, 8:25 PM · Restricted Project, Restricted Project

Mar 30 2019

mattd added a comment to D53832: Make instrprof-set-dir-mode test tolerant of group ID.

I do not have commit access. I probably should request it at some point, but I'm fine with someone else merging this for me.

Mar 30 2019, 11:52 AM · Restricted Project, Restricted Project

Mar 28 2019

mattd accepted D59928: [MCA] Add an experimental MicroOpQueue stage..
Mar 28 2019, 9:15 PM · Restricted Project
mattd added a comment to D59928: [MCA] Add an experimental MicroOpQueue stage..

LGTM!

Mar 28 2019, 9:14 PM · Restricted Project

Mar 22 2019

mattd added a comment to D53832: Make instrprof-set-dir-mode test tolerant of group ID.

This revision is now accepted and ready to land.Dec 3 2018, 12:55 PM

Been about 3.5 months since accepted. Can this be committed?

Mar 22 2019, 8:55 PM · Restricted Project, Restricted Project

Mar 13 2019

mattd removed a watcher for debug-info: mattd.
Mar 13 2019, 10:07 PM

Mar 7 2019

mattd committed rG6c5a49ccb9e4: [llvm-mca] Emit a message when no bottlenecks are identified. (authored by mattd).
[llvm-mca] Emit a message when no bottlenecks are identified.
Mar 7 2019, 11:36 AM
mattd committed rL355628: [llvm-mca] Emit a message when no bottlenecks are identified..
[llvm-mca] Emit a message when no bottlenecks are identified.
Mar 7 2019, 11:35 AM
mattd closed D59098: [llvm-mca] Emit a message when no bottlenecks are identified..
Mar 7 2019, 11:35 AM · Restricted Project
mattd accepted D59095: [llvm-readelf]Don't lose negative-ness of negative addends for no symbol relocations.

Makes sense. LGTM.

Mar 7 2019, 9:40 AM · Restricted Project
mattd created D59098: [llvm-mca] Emit a message when no bottlenecks are identified..
Mar 7 2019, 9:02 AM · Restricted Project

Mar 1 2019

mattd accepted D58728: [MCA] Highlight kernel bottlenecks in the summary view..
Mar 1 2019, 10:29 AM · Restricted Project
mattd committed rGb95daf0b7742: [lld][test] Fix tests. llvm-readobj now emits symbol section names. (authored by mattd).
[lld][test] Fix tests. llvm-readobj now emits symbol section names.
Mar 1 2019, 10:03 AM
mattd committed rL355211: [lld][test] Fix tests. llvm-readobj now emits symbol section names..
[lld][test] Fix tests. llvm-readobj now emits symbol section names.
Mar 1 2019, 10:03 AM
mattd committed rLLD355211: [lld][test] Fix tests. llvm-readobj now emits symbol section names..
[lld][test] Fix tests. llvm-readobj now emits symbol section names.
Mar 1 2019, 10:03 AM
mattd committed rG8a6f11f45fad: [llvm-readobj] Display section names for STT_SECTION symbols. (authored by mattd).
[llvm-readobj] Display section names for STT_SECTION symbols.
Mar 1 2019, 9:31 AM
mattd committed rL355207: [llvm-readobj] Display section names for STT_SECTION symbols..
[llvm-readobj] Display section names for STT_SECTION symbols.
Mar 1 2019, 9:31 AM
mattd closed D58796: [llvm-readobj] Display section names for STT_SECTION symbols..
Mar 1 2019, 9:30 AM · Restricted Project
mattd updated the diff for D58796: [llvm-readobj] Display section names for STT_SECTION symbols..

Thanks for the reviews everyone. This update addresses the feedback, all of which was incorporated.

Mar 1 2019, 9:03 AM · Restricted Project

Feb 28 2019

mattd updated the summary of D58796: [llvm-readobj] Display section names for STT_SECTION symbols..
Feb 28 2019, 2:42 PM · Restricted Project
mattd created D58796: [llvm-readobj] Display section names for STT_SECTION symbols..
Feb 28 2019, 2:42 PM · Restricted Project
mattd accepted D58785: [llvm-cxxfilt]Add test to show that empty lines can be handled.

LGTM

Feb 28 2019, 9:02 AM · Restricted Project

Feb 27 2019

mattd accepted D58728: [MCA] Highlight kernel bottlenecks in the summary view..

I like this and think users will find it very helpful. The changes seem sensible to me; however, I had a few nits... mostly stylistic things, no big deals. Anyways, I'll mark this patch as accept, as long as you cover the suggestions made by @lebedev.ri.

Feb 27 2019, 3:00 PM · Restricted Project
mattd committed rG1d5c23523e0b: [llvm-cxxfilt] Re-enable split and demangle stdin input on certain non… (authored by mattd).
[llvm-cxxfilt] Re-enable split and demangle stdin input on certain non…
Feb 27 2019, 1:39 PM
mattd added a reverting change for rG628ab5c6820b: Revert "[llvm-cxxfilt] Split and demangle stdin input on certain non…: rG1d5c23523e0b: [llvm-cxxfilt] Re-enable split and demangle stdin input on certain non….
Feb 27 2019, 1:39 PM
mattd committed rL355031: [llvm-cxxfilt] Re-enable split and demangle stdin input on certain non….
[llvm-cxxfilt] Re-enable split and demangle stdin input on certain non…
Feb 27 2019, 1:38 PM
mattd committed rG628ab5c6820b: Revert "[llvm-cxxfilt] Split and demangle stdin input on certain non… (authored by mattd).
Revert "[llvm-cxxfilt] Split and demangle stdin input on certain non…
Feb 27 2019, 11:54 AM
mattd added a reverting change for rG5cd5f8f25633: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics.: rG628ab5c6820b: Revert "[llvm-cxxfilt] Split and demangle stdin input on certain non….
Feb 27 2019, 11:54 AM
mattd committed rL355021: Revert "[llvm-cxxfilt] Split and demangle stdin input on certain non….
Revert "[llvm-cxxfilt] Split and demangle stdin input on certain non…
Feb 27 2019, 11:54 AM
mattd committed rG7a24dbdfd315: [llvm-readobj] Print section type values for unknown sections. (authored by mattd).
[llvm-readobj] Print section type values for unknown sections.
Feb 27 2019, 10:41 AM
mattd committed rL355014: [llvm-readobj] Print section type values for unknown sections..
[llvm-readobj] Print section type values for unknown sections.
Feb 27 2019, 10:41 AM
mattd closed D58701: [llvm-readobj] Print section type values for unknown sections..
Feb 27 2019, 10:41 AM · Restricted Project
mattd committed rG69bec61998c7: [llvm-cxxfilt] Re-enable the delimiters test on Windows. (authored by mattd).
[llvm-cxxfilt] Re-enable the delimiters test on Windows.
Feb 27 2019, 10:05 AM
mattd committed rL355011: [llvm-cxxfilt] Re-enable the delimiters test on Windows..
[llvm-cxxfilt] Re-enable the delimiters test on Windows.
Feb 27 2019, 10:03 AM
mattd committed rGeaa895368be6: Clean up the delimiters test. (authored by mattd).
Clean up the delimiters test.
Feb 27 2019, 9:39 AM
mattd committed rL355007: Clean up the delimiters test..
Clean up the delimiters test.
Feb 27 2019, 9:39 AM
mattd updated the diff for D58701: [llvm-readobj] Print section type values for unknown sections..
  • Fixed the test case (removed underscore typo, and extraneous shstrtab test).
  • Emit ANDROID_REL ANDROID_RELA instead of section offsets.
  • Modified the range check, allowing us to remove some now redundant code for printing the lower-bound section names.
Feb 27 2019, 8:59 AM · Restricted Project
mattd committed rG5cd5f8f25633: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics. (authored by mattd).
[llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics.
Feb 27 2019, 8:31 AM
mattd committed rL354998: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..
[llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics.
Feb 27 2019, 8:31 AM
mattd closed D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..
Feb 27 2019, 8:31 AM · Restricted Project

Feb 26 2019

mattd added a comment to D58701: [llvm-readobj] Print section type values for unknown sections..

lgtm

Should the +0 be +0x0 so that it's always a hex digit? Or is the +0 what the binutils already output?

Feb 26 2019, 5:05 PM · Restricted Project
mattd created D58701: [llvm-readobj] Print section type values for unknown sections..
Feb 26 2019, 4:57 PM · Restricted Project
mattd updated the diff for D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..
  • Added a more complicated test.
  • Made a few variables 'auto' instead of their iterator type.
Feb 26 2019, 10:16 AM · Restricted Project

Feb 20 2019

mattd accepted D58456: [llvm-readelf]Test a couple of corner-cases for --section-mapping.

LGTM. Thanks for adding these.

Feb 20 2019, 9:12 AM · Restricted Project
mattd added inline comments to D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..
Feb 20 2019, 8:55 AM · Restricted Project

Feb 19 2019

mattd added inline comments to D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..
Feb 19 2019, 5:17 PM · Restricted Project
mattd added a comment to D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..

Previously we would have emitted Foo [[:space:]] . right?

Feb 19 2019, 4:49 PM · Restricted Project
mattd created D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..
Feb 19 2019, 3:53 PM · Restricted Project

Feb 18 2019

mattd added a comment to D57149: [StackProtector] Skip analysing dead users in HasAddressTaken, PR40436.

Hi @uabelho

The test case in your patch definitely causes a problem, but that's because the -start-before/-stop-after is used. If I run that same test through llc, the UnreachableBlockElim pass kicks-in and drops the dead code.
I took a look at the code in your Janurary 24th comment. I was unable to get the same dead block to surface, but most likely I had the wrong flag set. How did you build the sample in that comment?

It can be reproduced with the full llc -O1 pipe on current trunk using:

llc -O1 -o - pr40436.ll

Feb 18 2019, 4:52 PM

Feb 14 2019

mattd committed rG582274329e3d: [llvm-cxxfilt] Fix a comment typo. NFC. (authored by mattd).
[llvm-cxxfilt] Fix a comment typo. NFC.
Feb 14 2019, 6:44 PM
mattd committed rL354094: [llvm-cxxfilt] Fix a comment typo. NFC..
[llvm-cxxfilt] Fix a comment typo. NFC.
Feb 14 2019, 6:43 PM
mattd committed rG123be5d4c0dd: [symbolizer] Avoid collecting symbols belonging to invalid sections. (authored by mattd).
[symbolizer] Avoid collecting symbols belonging to invalid sections.
Feb 14 2019, 3:54 PM
mattd committed rL354083: [symbolizer] Avoid collecting symbols belonging to invalid sections..
[symbolizer] Avoid collecting symbols belonging to invalid sections.
Feb 14 2019, 3:54 PM
mattd closed D58146: [symbolizer] Avoid collecting symbols belonging to invalid sections..
Feb 14 2019, 3:54 PM · Restricted Project

Feb 12 2019

mattd created D58146: [symbolizer] Avoid collecting symbols belonging to invalid sections..
Feb 12 2019, 1:45 PM · Restricted Project
mattd accepted D58066: [MCA][Scheduler] Use latency information to further classify busy instructions..
Feb 12 2019, 9:26 AM · Restricted Project

Feb 11 2019

mattd committed rG22c21934cefc: [llvm-cxxfilt] Split and demangle stdin input (authored by mattd).
[llvm-cxxfilt] Split and demangle stdin input
Feb 11 2019, 12:31 PM
mattd committed rL353743: [llvm-cxxfilt] Split and demangle stdin input.
[llvm-cxxfilt] Split and demangle stdin input
Feb 11 2019, 12:30 PM
mattd closed D57350: [llvm-cxxfilt] Split and demangle stdin input.
Feb 11 2019, 12:30 PM · Restricted Project
mattd added a comment to D58066: [MCA][Scheduler] Use latency information to further classify busy instructions..

LGTM. I had a few suggestions but nothing looks wrong to me.

Feb 11 2019, 11:16 AM · Restricted Project

Feb 7 2019

mattd updated the diff for D57350: [llvm-cxxfilt] Split and demangle stdin input.

I've updated the patch to replicate GNU's c++filt behavior. This patch now only splits strings that are passed via stdin. It does not split strings that are passed as arguments to llvm-cxxfilt via command line.

Feb 7 2019, 2:02 PM · Restricted Project

Feb 6 2019

mattd added a comment to D57149: [StackProtector] Skip analysing dead users in HasAddressTaken, PR40436.

The test case in your patch definitely causes a problem, but that's because the -start-before/-stop-after is used. If I run that same test through llc, the UnreachableBlockElim pass kicks-in and drops the dead code.
I took a look at the code in your Janurary 24th comment. I was unable to get the same dead block to surface, but most likely I had the wrong flag set. How did you build the sample in that comment?

Feb 6 2019, 10:28 AM

Feb 5 2019

mattd committed rG0d0e9c08a49d: [llvm-readobj] Display sections that do not belong to a segment in the section… (authored by mattd).
[llvm-readobj] Display sections that do not belong to a segment in the section…
Feb 5 2019, 1:02 PM
mattd committed rLLD353217: [llvm-readobj] Display sections that do not belong to a segment in the section….
[llvm-readobj] Display sections that do not belong to a segment in the section…
Feb 5 2019, 1:02 PM
mattd committed rL353217: [llvm-readobj] Display sections that do not belong to a segment in the section….
[llvm-readobj] Display sections that do not belong to a segment in the section…
Feb 5 2019, 1:02 PM
mattd closed D57700: [llvm-readobj] Display sections that do not belong to a segment in the section-mapping.
Feb 5 2019, 1:02 PM · Restricted Project
mattd added a comment to D57700: [llvm-readobj] Display sections that do not belong to a segment in the section-mapping.

Hello Davide,
The present format is good enough to convey the information. It is however not sufficient or sometimes difficult for present users of GNU tools (which are quite ubiquitous) to make a
switch as it is complete redesign of the post processing tools they may have based on.

-Hemant

It's not immediately clear from the original introduction of GNU style whether complete output identity was the original goal, or just similarity. Similarly, it's not clear from my previously attempt to gather information as to users expectations. I've subscribed @khemant in case he's got any further comments, since he made the original change. My reading of rL260430 which commits it is that it is intended to be like GNU readelf, but doesn't necessarily have to be identical. I'm open to further discussion on this (and I actually have a BoF on this subject at the next Euro LLVM, but that's still a couple of months away).

Feb 5 2019, 9:40 AM · Restricted Project

Feb 4 2019

mattd retitled D57700: [llvm-readobj] Display sections that do not belong to a segment in the section-mapping from [llvm-readobj] Display sections that do not belong to a segment in the segment-mapping to [llvm-readobj] Display sections that do not belong to a segment in the section-mapping.
Feb 4 2019, 10:49 AM · Restricted Project
mattd retitled D57700: [llvm-readobj] Display sections that do not belong to a segment in the section-mapping from [llvm-readobj] Display sections that do not belong to a segment in the section-to-segment dump. to [llvm-readobj] Display sections that do not belong to a segment in the segment-mapping.
Feb 4 2019, 10:34 AM · Restricted Project
mattd created D57700: [llvm-readobj] Display sections that do not belong to a segment in the section-mapping.
Feb 4 2019, 10:34 AM · Restricted Project

Feb 1 2019

mattd committed rL352896: [llvm-readobj] Add a flag to dump just the section-to-segment mapping..
[llvm-readobj] Add a flag to dump just the section-to-segment mapping.
Feb 1 2019, 10:51 AM
mattd closed D57365: [llvm-readobj] Add a flag to dump just the section-to-segment mapping..
Feb 1 2019, 10:51 AM · Restricted Project
mattd added inline comments to D57365: [llvm-readobj] Add a flag to dump just the section-to-segment mapping..
Feb 1 2019, 10:47 AM · Restricted Project
mattd committed rL352891: [llvm-nm] Report '.comment' ELF sections as 'n' instead of '?'.
[llvm-nm] Report '.comment' ELF sections as 'n' instead of '?'
Feb 1 2019, 9:38 AM
mattd closed D57544: [llvm-nm] Report '.comment' ELF sections as 'n' instead of '?'.
Feb 1 2019, 9:37 AM · Restricted Project

Jan 31 2019

mattd created D57544: [llvm-nm] Report '.comment' ELF sections as 'n' instead of '?'.
Jan 31 2019, 2:34 PM · Restricted Project
mattd added inline comments to D57365: [llvm-readobj] Add a flag to dump just the section-to-segment mapping..
Jan 31 2019, 1:25 PM · Restricted Project
mattd updated the diff for D57365: [llvm-readobj] Add a flag to dump just the section-to-segment mapping..
  • Update two tests to use FileChecks --implicit-check-not
  • Remove some cruft that, I think, was in an earlier version of this patch.
  • Update the CHECK-COUNT test to simply perform a CHECK followed by a CHECK-NOT.
Jan 31 2019, 1:24 PM · Restricted Project
mattd committed rL352785: [ELF] Return the section name when calling getSymbolName on a section symbol..
[ELF] Return the section name when calling getSymbolName on a section symbol.
Jan 31 2019, 11:42 AM
mattd closed D57105: [ELF] Return the section name when calling getSymbolName on a section symbol..
Jan 31 2019, 11:42 AM
mattd added a comment to D57105: [ELF] Return the section name when calling getSymbolName on a section symbol..

Okay, the change as-is LGTM, assuming that the following has been done:

I think before putting this in as is, it's probably worth reviewing all the call sites and seeing if there is anywhere where returning the section name would be harmful. I suspect it's probably mostly fine, given the lack of test failures.

A few things to look out for:

  1. Some code paths may already do the extra work needed to look up the section name, if the symbol doesn't have a name. These should be tidied up to not do this any more (it can be a later change).
  2. Some code paths may always print the name returned, but this may be undesirable for certain situations (I can't think of any off the top of my head however). This wouldn't be picked up by tests necessarily, due to the way FileCheck tests tend to be written.
  3. Some code may be using the name in some kind of map, if non-empty. This could cause issues e.g. with relocations in LLD, when attempting to map references to symbols via names. In practice, it shouldn't be an issue, but we should double check.
Jan 31 2019, 9:41 AM

Jan 30 2019

mattd updated the diff for D57365: [llvm-readobj] Add a flag to dump just the section-to-segment mapping..
  • I took a hint and decided to more the decision to print the section mapping with the program headers down into the dumper classes. This is similar to how the printSymbols and printDynamicSymbols are handled.
Jan 30 2019, 8:12 PM · Restricted Project
mattd added a comment to D57365: [llvm-readobj] Add a flag to dump just the section-to-segment mapping..

It occurred to me that if we were to implement section mapping for other output styles, e.g. LLVM, or formats (I don't know if that concept applies to COFF/MachO/Wasm etc mind you!), then we probably don't want to print the section mapping when program-headers is specified, except in GNU output style. This implies that the decision on whether to print the section mapping should be down to the dumper layer, not the command-line handling layer. This is very similar to the situation with --symbols/--dyn-symbols for GNU output style, and I suspect the solution should be essentially the same as rL351960.

Jan 30 2019, 2:54 PM · Restricted Project
mattd updated the diff for D57365: [llvm-readobj] Add a flag to dump just the section-to-segment mapping..
  • Removed a test
  • Replaced the uses of grep in the tests with CHECK-NOT and CHECK-COUNT
Jan 30 2019, 2:50 PM · Restricted Project
mattd updated the diff for D57105: [ELF] Return the section name when calling getSymbolName on a section symbol..
  • Update a comment, it was bothering me.
Jan 30 2019, 10:18 AM