Page MenuHomePhabricator
Feed Advanced Search

Yesterday

h-vetinari added a comment to D125788: [flang][driver] Rename `flang-new` as `flang`.

Very happy to see this finally happening! :)

Tue, May 17, 10:15 AM · Restricted Project, Restricted Project, Restricted Project

Tue, May 3

Herald added a project to D89057: Add the C++17 <memory_resource> header (mono-patch): Restricted Project.
Tue, May 3, 8:32 PM · Restricted Project, Restricted Project

Wed, Apr 27

h-vetinari added a comment to D124524: [demangler] Avoid nullptr UB.

2x "Buffer cannot by nullptr" -> "Buffer cannot be nullptr"

Wed, Apr 27, 9:03 PM · Restricted Project, Restricted Project

Apr 14 2022

Herald added a project to D116474: [lld] [coff] Fix the characteristics of some sections like ".voltbl".: Restricted Project.
Apr 14 2022, 11:17 PM · Restricted Project, Restricted Project, lld

Apr 13 2022

h-vetinari added a comment to D122008: [flang][driver] Add support for generating executables.

Speaking as a relative outside (but who's been waiting for flang in LLVM since well before it joined the monorepo), I'd much prefer code-generation-with-rough-edges in LLVM 15 (to start testing and raising eventual bugs), rather than a more polished flang (realistically still with bugs that need to be shaken out) in LLVM 16.

Apr 13 2022, 3:28 PM · Restricted Project, Restricted Project, Restricted Project

Apr 7 2022

Herald added a project to D97044: [libc++] [C++2b] [P0943] Add stdatomic.h header.: Restricted Project.
Apr 7 2022, 1:46 AM · Restricted Project, Restricted Project
h-vetinari added inline comments to D122976: Bump minimum toolchain version.
Apr 7 2022, 1:36 AM · Restricted Project, Restricted Project

Mar 26 2022

Herald added a project to D110500: [libc++][format][6/6] Improve vformat.: Restricted Project.
Mar 26 2022, 2:53 PM · Restricted Project, Restricted Project

Mar 22 2022

h-vetinari added inline comments to D122256: [clang][ABI] New C++20 module mangling scheme.
Mar 22 2022, 5:23 PM · Restricted Project, Restricted Project

Mar 9 2022

h-vetinari added a comment to D118352: [clang][ABI] New c++20 modules mangling scheme.

Something must have gone wrong... communication-wise... as @urnathan seems to have abandoned (resp. resigned from) all modules PRs. Hope any misunderstandings or grievances can be worked out!

Mar 9 2022, 3:46 PM · Restricted Project, Restricted Project

Mar 2 2022

Herald added a project to D119544: Deferred Concept Instantiation Implementation: Restricted Project.
Mar 2 2022, 5:57 PM · Restricted Project, Restricted Project
Herald added a project to D110641: Implement P0857R0 -Part B: requires clause for template-template params: Restricted Project.
Mar 2 2022, 5:51 PM · Restricted Project

Feb 27 2022

h-vetinari added a comment to D118599: [C++20][Modules][8/8] Amend module visibility rules for partitions..

A non-actionable comment out of curiosity for the work

Feb 27 2022, 4:01 PM · Restricted Project

Jan 24 2022

h-vetinari added a comment to D115999: [libc++][format] Finish P0645 Text Formatting..

Just a nit/note before LLVM 14 branches: a few bullets in FormatPaper.csv should probably now be updated as well.

Jan 24 2022, 6:17 PM · Restricted Project
h-vetinari added a comment to D115999: [libc++][format] Finish P0645 Text Formatting..

Congratulations on landing this huge piece of work, and even more so in time for LLVM 14!

Jan 24 2022, 11:42 AM · Restricted Project

Jan 13 2022

h-vetinari added a comment to D117230: [openmp][devicertl] Handle missing clang_tool.

Ah, just saw your comment to that exact effect in the meantime. :)

Jan 13 2022, 3:58 PM · Restricted Project
h-vetinari added a comment to D117230: [openmp][devicertl] Handle missing clang_tool.

OK, just taking the second half of the patch in openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt is actually enough for the backport.

Jan 13 2022, 3:57 PM · Restricted Project
h-vetinari added a comment to D117230: [openmp][devicertl] Handle missing clang_tool.

Thanks a lot for the patch! I'm trying to figure out how to apply this to 13.0.0-rc2, but it's not obvious since https://reviews.llvm.org/D111983 has happened in between and reshuffled a bunch of things around.

Jan 13 2022, 3:40 PM · Restricted Project

Nov 8 2021

h-vetinari added inline comments to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.
Nov 8 2021, 1:22 AM · Restricted Project

Oct 23 2021

h-vetinari added inline comments to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.
Oct 23 2021, 6:31 PM · Restricted Project

Oct 11 2021

h-vetinari added a comment to D88458: [CMake] Cache the compiler-rt library search results.

Given the cross-review of the respective authors, I'm assuming this is compatible / aligned with https://reviews.llvm.org/D111356? I ask because despite the mutual review, this wasn't mentioned in the email to LLVM-dev about the latter.

Oct 11 2021, 8:04 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 29 2021

h-vetinari added a comment to D110589: [IntelJITListener] Generalize JIT listener test.

I tested this patch in https://github.com/conda-forge/llvmdev-feedstock/pull/131 and it works as intended. Any blockers to landing it?

Sep 29 2021, 4:00 PM · Restricted Project