This updates the function createGOFFObjectFile to use Error instead of std::error_code as described in https://llvm.org/docs/ProgrammersManual.html#fallible-constructors
Tue, Oct 27
Update llvm/include/llvm/Object/GOFF.h to consider endianness of the host system for parsing GOFF records.
Fri, Oct 23
This update removes the RLDRelocationType enum from llvm/include/llvm/BinaryFormat/GOFF.h and clarifies comments regarding endianness.
Tue, Oct 20
This update removes variable definitions which are used only in the immediate next line and not used elsewhere.
Mon, Oct 19
This update fixes formatting issues, along with stubbing functions that are unnecessary
to implement for the time being from the GOFFObjectFile class
Thu, Oct 8
Tue, Oct 6
It looks to me like you uploaded the wrong diff. You need to upload a diff of your entire final commit that this will be committed as, when making edits to the code. If you intend to upload a series of individual commits, and want them all reviewed together, you should create separate patches for each of them and link them together using the "edit related objects" option to create a patch series.
This patch adds support for a large number of different dumping options all at once. Please break it down into separate smaller pieces. For example, your first patch could just create the GOFFDumper, and do nothing with it, the next adds section header support, the next symbol table support and so on. It is not going to be straightforward to review such a large piece of work all at once.
This update uploads the correct diff with all changes
Mon, Oct 5
Fix formatting issues
Fri, Oct 2
Mar 4 2020
Overall the patch LGTM, aside from 1 change we may want to make.