Page MenuHomePhabricator
Feed Advanced Search

Yesterday

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This updates the function createGOFFObjectFile to use Error instead of std::error_code as described in https://llvm.org/docs/ProgrammersManual.html#fallible-constructors

Wed, Oct 28, 12:45 PM · Restricted Project

Tue, Oct 27

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Update llvm/include/llvm/Object/GOFF.h to consider endianness of the host system for parsing GOFF records.

Tue, Oct 27, 9:42 AM · Restricted Project

Fri, Oct 23

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Fri, Oct 23, 1:52 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This update removes the RLDRelocationType enum from llvm/include/llvm/BinaryFormat/GOFF.h and clarifies comments regarding endianness.

Fri, Oct 23, 1:49 PM · Restricted Project

Tue, Oct 20

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This update removes variable definitions which are used only in the immediate next line and not used elsewhere.

Tue, Oct 20, 11:23 AM · Restricted Project

Mon, Oct 19

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This update fixes formatting issues, along with stubbing functions that are unnecessary
to implement for the time being from the GOFFObjectFile class

Mon, Oct 19, 11:39 AM · Restricted Project

Thu, Oct 8

yusra.syeda abandoned D88749: [SystemZ/z/OS] Add GOFF reader.

This patch has been broken down into the following 3 patches:
https://reviews.llvm.org/D89071
https://reviews.llvm.org/D89073
https://reviews.llvm.org/D89074

Thu, Oct 8, 2:21 PM · Restricted Project
yusra.syeda updated the summary of D89074: [SystemZ/z/OS] Add GOFF support for llvm-objdump.
Thu, Oct 8, 2:19 PM · Restricted Project
yusra.syeda requested review of D89074: [SystemZ/z/OS] Add GOFF support for llvm-objdump.
Thu, Oct 8, 2:14 PM · Restricted Project
yusra.syeda updated the summary of D89073: [SystemZ/z/OS] Add the GOFFDumper.
Thu, Oct 8, 2:11 PM · Restricted Project
yusra.syeda requested review of D89073: [SystemZ/z/OS] Add the GOFFDumper.
Thu, Oct 8, 2:08 PM · Restricted Project
yusra.syeda retitled D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format from Add GOFFObjectFile class and details of GOFF file format to [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Thu, Oct 8, 2:02 PM · Restricted Project
yusra.syeda requested review of D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Thu, Oct 8, 1:56 PM · Restricted Project

Tue, Oct 6

yusra.syeda added a comment to D88749: [SystemZ/z/OS] Add GOFF reader.

It looks to me like you uploaded the wrong diff. You need to upload a diff of your entire final commit that this will be committed as, when making edits to the code. If you intend to upload a series of individual commits, and want them all reviewed together, you should create separate patches for each of them and link them together using the "edit related objects" option to create a patch series.

This patch adds support for a large number of different dumping options all at once. Please break it down into separate smaller pieces. For example, your first patch could just create the GOFFDumper, and do nothing with it, the next adds section header support, the next symbol table support and so on. It is not going to be straightforward to review such a large piece of work all at once.

Tue, Oct 6, 9:44 AM · Restricted Project
yusra.syeda updated the diff for D88749: [SystemZ/z/OS] Add GOFF reader.

This update uploads the correct diff with all changes

Tue, Oct 6, 9:31 AM · Restricted Project

Mon, Oct 5

yusra.syeda updated the diff for D88749: [SystemZ/z/OS] Add GOFF reader.

Fix formatting issues

Mon, Oct 5, 1:11 PM · Restricted Project

Fri, Oct 2

yusra.syeda removed a reviewer for D88749: [SystemZ/z/OS] Add GOFF reader: jhenderson.
Fri, Oct 2, 12:01 PM · Restricted Project
yusra.syeda retitled D88749: [SystemZ/z/OS] Add GOFF reader from goff reader to [SystemZ/z/OS] Add GOFF reader.
Fri, Oct 2, 12:00 PM · Restricted Project
yusra.syeda requested review of D88749: [SystemZ/z/OS] Add GOFF reader.
Fri, Oct 2, 11:53 AM · Restricted Project

Mar 4 2020

yusra.syeda added a comment to D74166: [AIX][Frontend] Static init implementation for AIX considering no priority.

Overall the patch LGTM, aside from 1 change we may want to make.

Mar 4 2020, 7:52 AM · Restricted Project, Restricted Project

Jan 24 2020

yusra.syeda created D73378: [SystemZ] Add implementation for the intrinsic llvm.read_register.
Jan 24 2020, 12:16 PM · Restricted Project