Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Feb 10 2023

BigPeet added a comment to D142939: Fix handling of -> calls for modernize-use-emplace.

Thank you very much.

Feb 10 2023, 2:33 PM · Restricted Project, Restricted Project
BigPeet added a comment to D142939: Fix handling of -> calls for modernize-use-emplace.

Ping.

Feb 10 2023, 7:31 AM · Restricted Project, Restricted Project

Feb 1 2023

BigPeet added a comment to D142939: Fix handling of -> calls for modernize-use-emplace.

Generally we use prefer llvm::ArrayRef over const std::vector &

Feb 1 2023, 11:19 AM · Restricted Project, Restricted Project

Jan 31 2023

BigPeet updated the diff for D142939: Fix handling of -> calls for modernize-use-emplace.
  • fix passing vector by value instead of by ref-to-const
Jan 31 2023, 3:42 PM · Restricted Project, Restricted Project
BigPeet added a comment to D142939: Fix handling of -> calls for modernize-use-emplace.

Refactored the code a little bit to get rid of some repetitions. Should effectively match the same code as the accepted revision.

Jan 31 2023, 3:33 PM · Restricted Project, Restricted Project
BigPeet updated the diff for D142939: Fix handling of -> calls for modernize-use-emplace.
  • additional deduplication of code
Jan 31 2023, 3:30 PM · Restricted Project, Restricted Project
BigPeet updated the diff for D142939: Fix handling of -> calls for modernize-use-emplace.
  • reducing code repetition + further tests
Jan 31 2023, 3:08 PM · Restricted Project, Restricted Project

Jan 30 2023

BigPeet updated the summary of D142939: Fix handling of -> calls for modernize-use-emplace.
Jan 30 2023, 3:16 PM · Restricted Project, Restricted Project
BigPeet added reviewers for D142939: Fix handling of -> calls for modernize-use-emplace: nicovank, aaron.ballman.
Jan 30 2023, 3:10 PM · Restricted Project, Restricted Project
BigPeet requested review of D142939: Fix handling of -> calls for modernize-use-emplace.
Jan 30 2023, 3:08 PM · Restricted Project, Restricted Project
BigPeet added a comment to D135405: fix handling of braced-init temporaries for modernize-use-emplace.

Ping?

Jan 30 2023, 4:49 AM · Restricted Project, Restricted Project

Jan 10 2023

BigPeet added a comment to D135405: fix handling of braced-init temporaries for modernize-use-emplace.

GitHub username: BigPeet
GitHub email: pwolf2310@gmail.com

Jan 10 2023, 11:22 AM · Restricted Project, Restricted Project
BigPeet added a comment to D135405: fix handling of braced-init temporaries for modernize-use-emplace.

(Sorry, it's my first time contributing to LLVM and I simply don't know what happens next. Do I need to do anything? Or is it just waiting to get merged at some point?)

Jan 10 2023, 7:17 AM · Restricted Project, Restricted Project

Dec 15 2022

BigPeet added a comment to D135405: fix handling of braced-init temporaries for modernize-use-emplace.

Thanks for the review. Do I have to do anything or how will this be handled from here?

Dec 15 2022, 11:54 PM · Restricted Project, Restricted Project

Dec 6 2022

BigPeet added a comment to D135405: fix handling of braced-init temporaries for modernize-use-emplace.

Ping

Dec 6 2022, 11:09 PM · Restricted Project, Restricted Project

Oct 28 2022

BigPeet added a comment to D135405: fix handling of braced-init temporaries for modernize-use-emplace.

Ping

Oct 28 2022, 1:30 PM · Restricted Project, Restricted Project

Oct 17 2022

BigPeet added a comment to D135405: fix handling of braced-init temporaries for modernize-use-emplace.

Just a reminder. Do I have to do anything?

Oct 17 2022, 12:41 PM · Restricted Project, Restricted Project

Oct 7 2022

BigPeet updated the diff for D135405: fix handling of braced-init temporaries for modernize-use-emplace.

fixed wrong arc diff handling :-/

Oct 7 2022, 2:59 PM · Restricted Project, Restricted Project
BigPeet updated the diff for D135405: fix handling of braced-init temporaries for modernize-use-emplace.

applying clang-format

Oct 7 2022, 2:56 PM · Restricted Project, Restricted Project

Oct 6 2022

BigPeet added a reviewer for D135405: fix handling of braced-init temporaries for modernize-use-emplace: njames93.
Oct 6 2022, 2:54 PM · Restricted Project, Restricted Project
BigPeet updated the diff for D135405: fix handling of braced-init temporaries for modernize-use-emplace.
  • update comments
Oct 6 2022, 2:51 PM · Restricted Project, Restricted Project
BigPeet requested review of D135405: fix handling of braced-init temporaries for modernize-use-emplace.
Oct 6 2022, 2:43 PM · Restricted Project, Restricted Project