Thank you for the refactoring. Looks good, but let me retrigger testing with the latest changes.
ping @spupyrev

Thanks!

@sinan – please properly capitalize the title and use 50-72 commit formatting rule to align with the rest of BOLT commits for your future commits. Thank you for the fix!

Thank you for the fix and the test!

In D159089#4624694, @jobnoorman wrote:

Note that since this relies on a fix in lld (D159082), this patch will probably cause CI problems again (since the system's clang is used there).

clang-format

In D159460#4643578, @maksfb wrote:

Nice - good improvement. Do you know where the majority of the profile-processing time is spent with this change?

Address comments

Can you please retitle as imperative statement before landing?

Thanks. We recently discussed a case where stale matching was unable to match any block in a function and so function exec count was not set. We thought it's still beneficial to set exec count in this case for function reordering. I assume the entry block match will also make stale matching set function exec count in this scenario?

(Please make sure to amend your local commit before pushing - use arc land)

Can you please also tidy up the summary using 50-72 rule?

@Elvina – please update the title and summary. Looks good otherwise.

Thank you for taking care of it. Can you please also add a test?

Please update the title and summary.

In D151920#4626533, @Elvina wrote:

In D151920#4622639, @Amir wrote:

Hi Elvina, this stack broke aarch64 buildbot: https://lab.llvm.org/buildbot/#/builders/221/builds/17715. You should've received a notification. Please prioritize fixing it or revert if it can't be fixed quickly.

Hi! I'm trying to disable these tests in case they're building on aarch64, but I'm not sure this is the right way. Could you please take a look? https://reviews.llvm.org/D159094

Looks good. Thank you for updating it.

Hi Elvina, this stack broke aarch64 buildbot: https://lab.llvm.org/buildbot/#/builders/221/builds/17715. You should've received a notification. Please prioritize fixing it or revert if it can't be fixed quickly.

Bugfixes

perf2prof

Append to PGO_OPT

LGTM with minor nits. Tricky issue but thanks for handling it gracefully.

clang-format

In D155006#4574654, @dblaikie wrote:

SGTM

Call DestroyAll from setCurrentDocument

In D155006#4573881, @dblaikie wrote:

What are the codepaths that currently destroy these nodes?

Please add "[BOLT][NFC]" to the title.

Remove Input destructor override

LGTM with nits

Looks sane/safe.

LGTM sans nits.

Can you please retitle it as "[BOLT] Implement createRelocation for AArch64"?

Please fix a couple of nits, LGTM otherwise.

Or rather please retitle it as “[BOLT][test] Require x86_64-linux for <test>”

Please remove the dot from the title

Rebase

Add clang-bolt-profile-deps dependency

Move Offset annotation from former CTC to the tail call.