Page MenuHomePhabricator
Feed Advanced Search

Yesterday

saar.raz updated the diff for D65042: [Concept] Placeholder constraints and abbreviated templates.

Updated with correct diff

Thu, Jan 16, 6:38 AM · Restricted Project
saar.raz updated the diff for D65042: [Concept] Placeholder constraints and abbreviated templates.

Address CR comments.

Thu, Jan 16, 6:35 AM · Restricted Project
saar.raz committed rG8a3446746098: [Concepts] Fix ConceptSpecializationExpr profiling crash (authored by saar.raz).
[Concepts] Fix ConceptSpecializationExpr profiling crash
Thu, Jan 16, 3:43 AM

Wed, Jan 15

saar.raz updated the diff for D50360: [Concepts] Requires Expressions.

Address CR comments.

Wed, Jan 15, 8:06 PM · Restricted Project
saar.raz added a comment to D50360: [Concepts] Requires Expressions.

Addressed comments in latest diff.

Wed, Jan 15, 8:06 PM · Restricted Project
saar.raz added a comment to D50360: [Concepts] Requires Expressions.

Addressed comments in latest diff.

Wed, Jan 15, 1:29 PM · Restricted Project
saar.raz updated the diff for D50360: [Concepts] Requires Expressions.

Address first round of CR comments

Wed, Jan 15, 1:19 PM · Restricted Project

Tue, Jan 14

saar.raz committed rGff1e0fce817e: [Concepts] Type Constraints (authored by saar.raz).
[Concepts] Type Constraints
Tue, Jan 14, 6:10 PM
saar.raz closed D44352: [Concepts] Type Constraints.
Tue, Jan 14, 6:10 PM · Restricted Project

Mon, Jan 13

saar.raz updated the diff for D65042: [Concept] Placeholder constraints and abbreviated templates.

Greatly simplified abbreviated template parsing, unify with generic lambdas.
Instead of manually replacing autos with invented parameters after the fact, we now replace autos in parameter type specifiers with invented parameters in GetTypeSpecTypeForDeclarator, by:

  • Tracking the template parameter lists in the Declarator object
  • Tracking the template parameter depth before parsing function declarators (at which point we can match template parameters against scope specifiers to know if we have an explicit template parameter or not).

When encountering an AutoType in a parameter context we check a stack of InventedTemplateParameterInfo structures that contain the info required to create and accumulate
invented template parameters (fields that were already present in LambdaScopeInfo, which now inherits from this class and is looked up when an auto is encountered in a
lambda context).

Mon, Jan 13, 7:53 AM · Restricted Project

Fri, Jan 10

saar.raz updated the diff for D44352: [Concepts] Type Constraints.

Remove SuppressDiagnostics, conform TryAnnotateTypeConstraint, readd concepts to relaxed template argument check, fix recovery from bad scope in ParseTemplateParameter

Fri, Jan 10, 7:41 PM · Restricted Project
saar.raz created D72552: [Concepts] Constraint Satisfaction Caching.
Fri, Jan 10, 6:56 PM · Restricted Project
saar.raz committed rG9b23407063ca: [Concepts] Fix MarkUsedTemplateParameters for exprs (authored by saar.raz).
[Concepts] Fix MarkUsedTemplateParameters for exprs
Fri, Jan 10, 5:20 PM
saar.raz added a comment to D44352: [Concepts] Type Constraints.
Fri, Jan 10, 5:17 AM · Restricted Project
saar.raz updated the diff for D44352: [Concepts] Type Constraints.

Address some CR comments.

Fri, Jan 10, 5:16 AM · Restricted Project

Thu, Jan 9

saar.raz updated the diff for D44352: [Concepts] Type Constraints.

Remove accidental change to CMakeLists.txt

Thu, Jan 9, 5:31 PM · Restricted Project
saar.raz added a comment to D44352: [Concepts] Type Constraints.

Addressed all but one comment in recent commit.

Thu, Jan 9, 5:26 PM · Restricted Project
saar.raz updated the diff for D44352: [Concepts] Type Constraints.

Rebase onto trunk.
Address CR comments by rsmith.

Thu, Jan 9, 5:26 PM · Restricted Project
saar.raz committed rG84ce46269cfd: [Concepts] Fix failing test on Windows (authored by saar.raz).
[Concepts] Fix failing test on Windows
Thu, Jan 9, 6:28 AM
saar.raz committed rGb65b1f322bd8: [Concepts] Function trailing requires clauses (authored by saar.raz).
[Concepts] Function trailing requires clauses
Thu, Jan 9, 5:12 AM
saar.raz closed D43357: [Concepts] Function trailing requires clauses.
Thu, Jan 9, 5:12 AM · Restricted Project
saar.raz updated the diff for D43357: [Concepts] Function trailing requires clauses.

Address final CR comments by rsmith

Thu, Jan 9, 3:22 AM · Restricted Project

Wed, Jan 8

saar.raz updated the diff for D43357: [Concepts] Function trailing requires clauses.

Use InclusiveOr precedence when recovering from non-primary constraint expr

Wed, Jan 8, 3:19 PM · Restricted Project
saar.raz updated the diff for D43357: [Concepts] Function trailing requires clauses.

Address CR comments by rsmith.

Wed, Jan 8, 3:00 PM · Restricted Project
saar.raz added inline comments to D43357: [Concepts] Function trailing requires clauses.
Wed, Jan 8, 3:00 PM · Restricted Project

Tue, Jan 7

saar.raz updated the diff for D50360: [Concepts] Requires Expressions.

Refactor Requirement and subclasses to the AST, extract their creation logic to Sema.

Tue, Jan 7, 1:56 PM · Restricted Project
saar.raz updated the summary of D50360: [Concepts] Requires Expressions.
Tue, Jan 7, 1:56 PM · Restricted Project

Mon, Dec 23

saar.raz updated the diff for D43357: [Concepts] Function trailing requires clauses.

Fix memory handling of NormalizedConstraint and AtomicConstraint
Fix some more failed tests and rebase onto trunk

Mon, Dec 23, 10:14 PM · Restricted Project

Sun, Dec 22

saar.raz committed rGdf061c3e2b97: [Concepts] Constrained partial specializations and function overloads. (authored by saar.raz).
[Concepts] Constrained partial specializations and function overloads.
Sun, Dec 22, 10:52 PM
saar.raz committed rGd3f5769d5e93: [Concepts] Constrained partial specializations and function overloads. (authored by saar.raz).
[Concepts] Constrained partial specializations and function overloads.
Sun, Dec 22, 3:16 AM

Fri, Dec 20

saar.raz updated the diff for D43357: [Concepts] Function trailing requires clauses.

Address CR comments by rsmith.
Also, add Sema normalization API (useful on its own right) and a normalization cache, for two reasons:

  • Performance (not having to re-normalize the constraints for every template or concept on every use).
  • Preventing normalization diagnostics from popping up multiple times (when the causing constraint is normalized again).
Fri, Dec 20, 5:01 PM · Restricted Project
saar.raz added inline comments to D43357: [Concepts] Function trailing requires clauses.
Fri, Dec 20, 5:01 PM · Restricted Project

Dec 18 2019

saar.raz committed rG11d5fa6e87e3: [Concepts] Fix incorrect move out of temporary in D41910 (authored by saar.raz).
[Concepts] Fix incorrect move out of temporary in D41910
Dec 18 2019, 11:46 AM
saar.raz committed rG12038be20ee6: [Concepts] Fix crash in D41910 (authored by saar.raz).
[Concepts] Fix crash in D41910
Dec 18 2019, 11:36 AM
saar.raz closed D41910: [Concepts] Constrained partial specializations and function overloads..
Dec 18 2019, 11:36 AM · Restricted Project
saar.raz committed rGfc0731b98a67: [Concepts] Constrained partial specializations and function overloads. (authored by saar.raz).
[Concepts] Constrained partial specializations and function overloads.
Dec 18 2019, 11:07 AM

Dec 5 2019

saar.raz committed rGe7c24667816e: [Concepts] Fix build failures in D41569 (authored by saar.raz).
[Concepts] Fix build failures in D41569
Dec 5 2019, 3:55 PM
saar.raz committed rGfdf80e86a528: [Concepts] Constraint Enforcement & Diagnostics (authored by saar.raz).
[Concepts] Constraint Enforcement & Diagnostics
Dec 5 2019, 3:36 PM
saar.raz added a comment to D41910: [Concepts] Constrained partial specializations and function overloads..

Addressed in latest diff

Dec 5 2019, 2:54 PM · Restricted Project
saar.raz updated the diff for D41910: [Concepts] Constrained partial specializations and function overloads..

Address all CR comments by rsmith (including rewrite of normalization).
Decided to not support things like:

Dec 5 2019, 2:54 PM · Restricted Project

Nov 5 2019

saar.raz added inline comments to D50360: [Concepts] Requires Expressions.
Nov 5 2019, 12:10 PM · Restricted Project
saar.raz updated the diff for D50360: [Concepts] Requires Expressions.

Address final CR comments, add PCH tests

Nov 5 2019, 12:10 PM · Restricted Project

Oct 24 2019

saar.raz committed rGffa214ef2289: [Concepts] Constraint Enforcement & Diagnostics (authored by saar.raz).
[Concepts] Constraint Enforcement & Diagnostics
Oct 24 2019, 2:38 PM
saar.raz closed D41569: [Concepts] Constraint enforcement and diagnostics.

Committed ffa214ef22892d75340dc6720271863901dc2c90

Oct 24 2019, 2:38 PM · Restricted Project
saar.raz closed D41284: [Concepts] Associated constraints infrastructure..
Oct 24 2019, 2:38 PM · Restricted Project

Oct 17 2019

saar.raz updated the diff for D41569: [Concepts] Constraint enforcement and diagnostics.

Address CR comments by rsmith.

Oct 17 2019, 6:31 AM · Restricted Project

Oct 16 2019

saar.raz committed rGf567b008804a: [Concepts] ConceptSpecializationExprs mangling (authored by saar.raz).
[Concepts] ConceptSpecializationExprs mangling
Oct 16 2019, 5:25 PM
saar.raz committed rL375063: [Concepts] ConceptSpecializationExprs mangling.
[Concepts] ConceptSpecializationExprs mangling
Oct 16 2019, 5:13 PM

Oct 15 2019

saar.raz committed rG1e3e77e0b689: Fix failing mangle-concept.cpp test. (authored by saar.raz).
Fix failing mangle-concept.cpp test.
Oct 15 2019, 7:57 PM
saar.raz committed rL374971: Fix failing mangle-concept.cpp test..
Fix failing mangle-concept.cpp test.
Oct 15 2019, 7:56 PM
saar.raz committed rG5e34ad109ced: [Concepts] ConceptSpecializationExprs mangling (authored by saar.raz).
[Concepts] ConceptSpecializationExprs mangling
Oct 15 2019, 7:38 PM
saar.raz committed rL374967: [Concepts] ConceptSpecializationExprs mangling.
[Concepts] ConceptSpecializationExprs mangling
Oct 15 2019, 7:37 PM
saar.raz committed rG0330fba6e16d: [Concept] Associated Constraints Infrastructure (authored by saar.raz).
[Concept] Associated Constraints Infrastructure
Oct 15 2019, 11:46 AM
saar.raz committed rL374938: [Concept] Associated Constraints Infrastructure.
[Concept] Associated Constraints Infrastructure
Oct 15 2019, 11:46 AM
saar.raz committed rG84423bd4396b: [Concepts] Remove unused and illegal Sema includes from ExprCXX.cpp (authored by saar.raz).
[Concepts] Remove unused and illegal Sema includes from ExprCXX.cpp
Oct 15 2019, 8:56 AM
saar.raz committed rL374907: [Concepts] Remove unused and illegal Sema includes from ExprCXX.cpp.
[Concepts] Remove unused and illegal Sema includes from ExprCXX.cpp
Oct 15 2019, 8:47 AM
saar.raz committed rG5d98ba6077da: [Concepts] Concept Specialization Expressions (authored by saar.raz).
[Concepts] Concept Specialization Expressions
Oct 15 2019, 8:29 AM
saar.raz committed rL374903: [Concepts] Concept Specialization Expressions.
[Concepts] Concept Specialization Expressions
Oct 15 2019, 8:29 AM
saar.raz committed rGec87b003823d: [Concepts] Concept Specialization Expressions (authored by saar.raz).
[Concepts] Concept Specialization Expressions
Oct 15 2019, 4:55 AM
saar.raz added an edge to rL374882: [Concepts] Concept Specialization Expressions: D41217: [Concepts] Concept Specialization Expressions.
Oct 15 2019, 4:55 AM
saar.raz added 2 commit(s) for D41217: [Concepts] Concept Specialization Expressions: rC374882: [Concepts] Concept Specialization Expressions, rL374882: [Concepts] Concept Specialization Expressions.
Oct 15 2019, 4:55 AM · Restricted Project
saar.raz closed D41217: [Concepts] Concept Specialization Expressions.
Oct 15 2019, 4:55 AM · Restricted Project
saar.raz committed rL374882: [Concepts] Concept Specialization Expressions.
[Concepts] Concept Specialization Expressions
Oct 15 2019, 4:47 AM

Oct 14 2019

saar.raz added inline comments to D50360: [Concepts] Requires Expressions.
Oct 14 2019, 5:28 PM · Restricted Project
saar.raz updated the diff for D50360: [Concepts] Requires Expressions.

Address some CR comments

Oct 14 2019, 4:40 PM · Restricted Project
saar.raz updated the diff for D43357: [Concepts] Function trailing requires clauses.

Addressed remaining comments by rsmith

Oct 14 2019, 3:00 PM · Restricted Project
saar.raz closed D40381: Parse concept definition.
Oct 14 2019, 2:50 PM · Restricted Project
saar.raz removed reviewers for D41217: [Concepts] Concept Specialization Expressions: changyu, hubert.reinterpretcast, nwilson, faisalv.
Oct 14 2019, 2:50 PM · Restricted Project
saar.raz removed reviewers for D40381: Parse concept definition: hubert.reinterpretcast, nwilson, faisalv, changyu, martong, saar.raz.
Oct 14 2019, 2:50 PM · Restricted Project
saar.raz accepted D40381: Parse concept definition.
Oct 14 2019, 2:50 PM · Restricted Project
saar.raz accepted D40381: Parse concept definition.
Oct 14 2019, 2:50 PM · Restricted Project
saar.raz removed a reviewer for D40381: Parse concept definition: saar.raz.
Oct 14 2019, 2:50 PM · Restricted Project
saar.raz updated the diff for D41284: [Concepts] Associated constraints infrastructure..

Remove unrelated cleanup

Oct 14 2019, 1:25 PM · Restricted Project

Oct 13 2019

saar.raz added inline comments to D41217: [Concepts] Concept Specialization Expressions.
Oct 13 2019, 11:23 AM · Restricted Project
saar.raz updated the diff for D41217: [Concepts] Concept Specialization Expressions.

Address CR comments by rsmith

Oct 13 2019, 11:14 AM · Restricted Project

Jul 20 2019

saar.raz created D65042: [Concept] Placeholder constraints and abbreviated templates.
Jul 20 2019, 5:00 PM · Restricted Project

Jul 13 2019

saar.raz updated the diff for D44352: [Concepts] Type Constraints.

Rebase onto trunk.

Jul 13 2019, 8:42 AM · Restricted Project
saar.raz updated the diff for D41569: [Concepts] Constraint enforcement and diagnostics.

Move ConstraintSatisfaction to ASTConcept.h

Jul 13 2019, 8:07 AM · Restricted Project
saar.raz updated the diff for D41569: [Concepts] Constraint enforcement and diagnostics.

Add support for mangling of ConceptSpecializtationExprs

Jul 13 2019, 6:41 AM · Restricted Project
saar.raz updated the diff for D41284: [Concepts] Associated constraints infrastructure..

Rebase onto trunk.

Jul 13 2019, 6:30 AM · Restricted Project
saar.raz updated the diff for D41217: [Concepts] Concept Specialization Expressions.

Rebase onto trunk.

Jul 13 2019, 6:23 AM · Restricted Project

Jul 10 2019

saar.raz added an edge to rL365699: [Concepts] Concept definitions (D40381): D40381: Parse concept definition.
Jul 10 2019, 2:33 PM
saar.raz added 2 commit(s) for D40381: Parse concept definition: rC365699: [Concepts] Concept definitions (D40381), rL365699: [Concepts] Concept definitions (D40381).
Jul 10 2019, 2:33 PM · Restricted Project
saar.raz updated the diff for D40381: Parse concept definition.

Final committed diff.

Jul 10 2019, 2:33 PM · Restricted Project
saar.raz added an edge to rGd7aae33a9513: [Concepts] Concept definitions (D40381): D40381: Parse concept definition.
Jul 10 2019, 2:30 PM
saar.raz added 1 commit(s) for D40381: Parse concept definition: rGd7aae33a9513: [Concepts] Concept definitions (D40381).
Jul 10 2019, 2:30 PM · Restricted Project
saar.raz committed rGd7aae33a9513: [Concepts] Concept definitions (D40381) (authored by saar.raz).
[Concepts] Concept definitions (D40381)
Jul 10 2019, 2:27 PM
saar.raz committed rL365699: [Concepts] Concept definitions (D40381).
[Concepts] Concept definitions (D40381)
Jul 10 2019, 2:26 PM
saar.raz committed rGcbe3ed17fa99: My first test commit. (authored by saar.raz).
My first test commit.
Jul 10 2019, 1:04 PM
saar.raz committed rL365695: My first test commit..
My first test commit.
Jul 10 2019, 1:02 PM

Jun 29 2019

saar.raz updated the diff for D41569: [Concepts] Constraint enforcement and diagnostics.

Create ASTConstraintSatisfaction for correctly storing constraint satisfaction data in AST nodes.

Jun 29 2019, 1:14 PM · Restricted Project

Jun 16 2019

saar.raz updated the diff for D43357: [Concepts] Function trailing requires clauses.

Add support for lambda expression trailing requires clauses

Jun 16 2019, 9:34 AM · Restricted Project
saar.raz updated the diff for D60939: [Concepts] Delayed Constraint Substitution.

Do not instantiate lambda expression trailing requires clause

Jun 16 2019, 9:28 AM · Restricted Project

Jun 14 2019

saar.raz updated the diff for D60939: [Concepts] Delayed Constraint Substitution.

Only include template parameters that occur in the atomic constraint in the parameter mapping

Jun 14 2019, 3:46 PM · Restricted Project
saar.raz updated the diff for D44352: [Concepts] Type Constraints.

Fix incorrect comparison of type-constraints in template template argument matching

Jun 14 2019, 2:00 PM · Restricted Project
saar.raz updated the diff for D44352: [Concepts] Type Constraints.

Fix incorrect patch upload

Jun 14 2019, 9:27 AM · Restricted Project
saar.raz updated the diff for D50360: [Concepts] Requires Expressions.

Adjusted to changes in previous patches

Jun 14 2019, 9:27 AM · Restricted Project
saar.raz updated the diff for D44352: [Concepts] Type Constraints.

Adjust to changes in previous patches

Jun 14 2019, 9:18 AM · Restricted Project
saar.raz updated the diff for D41217: [Concepts] Concept Specialization Expressions.

Delay support for mangling to later patch (where CSEs are formed instead of UnresolvedLookupExprs with dependent args)

Jun 14 2019, 9:18 AM · Restricted Project
saar.raz updated the diff for D41569: [Concepts] Constraint enforcement and diagnostics.

Add support for CSE mangling

Jun 14 2019, 9:12 AM · Restricted Project