Page MenuHomePhabricator
Feed Advanced Search

Today

paulwalker-arm added inline comments to D107372: [InstCombine] Fixed select + masked load fold failure.
Wed, Aug 4, 5:06 AM · Restricted Project

Yesterday

paulwalker-arm added inline comments to D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes.
Tue, Aug 3, 10:05 AM · Restricted Project, Restricted Project
paulwalker-arm added inline comments to D106929: [AArch64][SVE][InstCombine] Unpack of a splat vector -> Scalar extend.
Tue, Aug 3, 9:41 AM · Restricted Project
paulwalker-arm added a comment to D106932: [AArch64][SVE][InstCombine] Move last{a,b} before binop if one operand is a splat value.

Sorry forgot to ask if you've used update_test_checks.py to generate the CHECK lines within sve-intrinsic-opts-lasta-lastb.ll like the other tests within the file. If not then please do so as otherwise the next person along will have unnecessary changes in their patch.

Tue, Aug 3, 8:02 AM · Restricted Project
paulwalker-arm added inline comments to D106932: [AArch64][SVE][InstCombine] Move last{a,b} before binop if one operand is a splat value.
Tue, Aug 3, 7:54 AM · Restricted Project
paulwalker-arm added inline comments to D106932: [AArch64][SVE][InstCombine] Move last{a,b} before binop if one operand is a splat value.
Tue, Aug 3, 7:54 AM · Restricted Project
paulwalker-arm accepted D106549: [AArch64][SVE] Combine bitcasts to predicate types with vector inserts of loads.
Tue, Aug 3, 6:53 AM · Restricted Project

Mon, Aug 2

paulwalker-arm added inline comments to D106549: [AArch64][SVE] Combine bitcasts to predicate types with vector inserts of loads.
Mon, Aug 2, 9:54 AM · Restricted Project

Fri, Jul 30

paulwalker-arm added inline comments to D106929: [AArch64][SVE][InstCombine] Unpack of a splat vector -> Scalar extend.
Fri, Jul 30, 4:14 AM · Restricted Project

Thu, Jul 29

paulwalker-arm added inline comments to D106932: [AArch64][SVE][InstCombine] Move last{a,b} before binop if one operand is a splat value.
Thu, Jul 29, 9:50 AM · Restricted Project
paulwalker-arm added inline comments to D106549: [AArch64][SVE] Combine bitcasts to predicate types with vector inserts of loads.
Thu, Jul 29, 5:49 AM · Restricted Project
paulwalker-arm added a comment to D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes.

@craig.topper can you share RISCV plans around supporting vscale_range? In essence we'd like to deprecate the TTI method and have LLVM IR contain all relevant information when is comes to interpreting vscale.

Thu, Jul 29, 4:28 AM · Restricted Project, Restricted Project

Tue, Jul 27

paulwalker-arm added a reviewer for D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts: c-rhodes.
Tue, Jul 27, 4:23 AM · Restricted Project

Mon, Jul 26

paulwalker-arm committed rG3b77e2737c85: [SVE] Use reg+reg addressing mode for immediate offsets. (authored by paulwalker-arm).
[SVE] Use reg+reg addressing mode for immediate offsets.
Mon, Jul 26, 8:26 AM
paulwalker-arm closed D106744: [SVE] Use reg+reg addressing mode for immediate offsets..
Mon, Jul 26, 8:26 AM · Restricted Project
paulwalker-arm committed rG8a8d01d58c14: [NFC] Change VFShape so it contains an ElementCount rather than seperate VF and… (authored by paulwalker-arm).
[NFC] Change VFShape so it contains an ElementCount rather than seperate VF and…
Mon, Jul 26, 4:37 AM
paulwalker-arm closed D106750: [NFC] Change VFShape so it contains an ElementCount rather than seperate VF and IsScalable properties..
Mon, Jul 26, 4:36 AM · Restricted Project

Sat, Jul 24

paulwalker-arm added reviewers for D106750: [NFC] Change VFShape so it contains an ElementCount rather than seperate VF and IsScalable properties.: sdesmalen, kmclaughlin.
Sat, Jul 24, 9:09 AM · Restricted Project
paulwalker-arm requested review of D106750: [NFC] Change VFShape so it contains an ElementCount rather than seperate VF and IsScalable properties..
Sat, Jul 24, 9:08 AM · Restricted Project
paulwalker-arm accepted D105889: [AArch64][SVE] Break false dependencies for inactive lanes of unary operations.
Sat, Jul 24, 8:12 AM · Restricted Project
paulwalker-arm added reviewers for D106744: [SVE] Use reg+reg addressing mode for immediate offsets.: david-arm, bsmith.
Sat, Jul 24, 5:35 AM · Restricted Project
paulwalker-arm requested review of D106744: [SVE] Use reg+reg addressing mode for immediate offsets..
Sat, Jul 24, 5:29 AM · Restricted Project
paulwalker-arm committed rGe697a542cab3: [SVE][NFC] Cleanup fixed length code gen tests to make them more resilient. (authored by paulwalker-arm).
[SVE][NFC] Cleanup fixed length code gen tests to make them more resilient.
Sat, Jul 24, 5:16 AM

Wed, Jul 21

paulwalker-arm added inline comments to D105889: [AArch64][SVE] Break false dependencies for inactive lanes of unary operations.
Wed, Jul 21, 9:33 AM · Restricted Project
paulwalker-arm added inline comments to D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion.
Wed, Jul 21, 2:01 AM · Restricted Project

Tue, Jul 20

paulwalker-arm accepted D105673: [SelectionDAG] Fix the representation of ISD::STEP_VECTOR..

I'm happy with the patch from an SVE point of view. I'm less enamoured by the MOVi32imm changes from the prerequisite patch, but I won't loose sleep over it.

Tue, Jul 20, 10:46 AM · Restricted Project
paulwalker-arm added inline comments to D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes.
Tue, Jul 20, 9:20 AM · Restricted Project, Restricted Project
paulwalker-arm added a comment to D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion.

@efriedma with this patch, all of conversion between VLST and VLAT should have same vector size(getElementType() * getElementCount()). The regression in D105097 will be fixed by using bitcast + vector.insert/extract directly

Tue, Jul 20, 2:57 AM · Restricted Project

Mon, Jul 19

paulwalker-arm added inline comments to D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes.
Mon, Jul 19, 7:46 AM · Restricted Project, Restricted Project

Fri, Jul 9

paulwalker-arm added a comment to D105673: [SelectionDAG] Fix the representation of ISD::STEP_VECTOR..

When the node was first added I figured it wouldn't be too long before somebody wanted to support a variable stride, so using an SDValue made sense so as to save some effort later. Personally I've never seen a need to support a variable stride and time has passed without such a request so I think locking the interface down now is a good move.

Fri, Jul 9, 3:05 AM · Restricted Project

Wed, Jul 7

paulwalker-arm accepted D103799: [CostModel] Express cost(urem) as cost(div+mul+sub) when set to Expand..
Wed, Jul 7, 3:01 AM · Restricted Project

Jul 5 2021

paulwalker-arm committed rG88522455c034: Fix typo in help text for -aarch64-enable-branch-targets. (authored by paulwalker-arm).
Fix typo in help text for -aarch64-enable-branch-targets.
Jul 5 2021, 8:17 AM

Jul 4 2021

paulwalker-arm committed rG287d39dd5adb: [NFC] Fix a few whitespace issues and typos. (authored by paulwalker-arm).
[NFC] Fix a few whitespace issues and typos.
Jul 4 2021, 4:04 AM

Jun 29 2021

paulwalker-arm added inline comments to D104471: [llvm][sve] Lowering for VLS truncating stores.
Jun 29 2021, 3:58 AM · Restricted Project

Jun 22 2021

paulwalker-arm accepted D104573: [AArch64] Optimize SVE bitcasts of unpacked types..
Jun 22 2021, 3:26 AM · Restricted Project

Jun 21 2021

paulwalker-arm added inline comments to D104573: [AArch64] Optimize SVE bitcasts of unpacked types..
Jun 21 2021, 4:27 AM · Restricted Project
paulwalker-arm accepted D104468: [Verifier] Fail on overrunning and invalid indices for {insert,extract} vector intrinsics.
Jun 21 2021, 3:24 AM · Restricted Project

Jun 18 2021

paulwalker-arm added inline comments to D104468: [Verifier] Fail on overrunning and invalid indices for {insert,extract} vector intrinsics.
Jun 18 2021, 9:37 AM · Restricted Project
paulwalker-arm added inline comments to D104468: [Verifier] Fail on overrunning and invalid indices for {insert,extract} vector intrinsics.
Jun 18 2021, 6:26 AM · Restricted Project
paulwalker-arm accepted D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries.
Jun 18 2021, 5:35 AM · Restricted Project, Restricted Project

Jun 17 2021

paulwalker-arm added inline comments to D102842: [Verifier] Fail on invalid indices for {insert,extract} vector intrinsics.
Jun 17 2021, 4:08 AM · Restricted Project
paulwalker-arm added inline comments to D102842: [Verifier] Fail on invalid indices for {insert,extract} vector intrinsics.
Jun 17 2021, 3:44 AM · Restricted Project

Jun 15 2021

paulwalker-arm added inline comments to D104217: [AArch64][SVE] Add support for fixed length MSCATTER/MGATHER.
Jun 15 2021, 4:57 AM · Restricted Project

Jun 14 2021

paulwalker-arm added inline comments to D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries.
Jun 14 2021, 10:27 AM · Restricted Project, Restricted Project

Jun 10 2021

paulwalker-arm added inline comments to D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries.
Jun 10 2021, 5:07 AM · Restricted Project, Restricted Project

Jun 9 2021

paulwalker-arm added a comment to D103170: [CodeGen][AArch64][SVE] Use ld1r[bhsd] for vector splat from memory.

I'll take a more detailed look later but structurally it looks fine to me. I've added a comment that hopefully means we don't need the frame index limitation.

Jun 9 2021, 11:51 AM · Restricted Project
paulwalker-arm added a comment to D103882: [CostModel][AArch64] Make loads/stores of <vscale x 1 x eltty> expensive..

My feeling is that the vectoriser should never try to vectorise a loop that is impossible to vectorise, with the act of costing a vectorisation candidate effectively saying the loop is safe to vectorise. So a way to guard this is to ensure that when costing a vectorisation candidate we force the need for a real cost. It's just unfortunate that when it comes to scalable vectorisation there are more scenarios that lead to loops that are not vectorisable (or rather, loops where scalable VFs must be pulled from the list of candidate VFs).

Jun 9 2021, 2:32 AM · Restricted Project

Jun 8 2021

paulwalker-arm accepted D103882: [CostModel][AArch64] Make loads/stores of <vscale x 1 x eltty> expensive..

Personally, for the testing I'd pick a different element type than i128 given that is already problematic.

Jun 8 2021, 9:28 AM · Restricted Project

Jun 3 2021

paulwalker-arm accepted D103168: [AArch64][SVE] Add support for using reverse forms of SVE2 shifts.
Jun 3 2021, 2:40 AM · Restricted Project

Jun 1 2021

paulwalker-arm accepted D98722: [LV] Build and cost VPlans for scalable VFs..
Jun 1 2021, 4:07 AM · Restricted Project

May 21 2021

paulwalker-arm added inline comments to D102842: [Verifier] Fail on invalid indices for {insert,extract} vector intrinsics.
May 21 2021, 9:06 AM · Restricted Project
paulwalker-arm accepted D102607: [AArch64][SVE] Add fixed length codegen for FP_ROUND/FP_EXTEND.
May 21 2021, 7:52 AM · Restricted Project
paulwalker-arm added inline comments to D102765: [SelectionDAG] Add stub implementation of ReplaceInsertSubVectorResults.
May 21 2021, 6:31 AM · Restricted Project

May 20 2021

paulwalker-arm added inline comments to D102765: [SelectionDAG] Add stub implementation of ReplaceInsertSubVectorResults.
May 20 2021, 10:47 AM · Restricted Project
paulwalker-arm added inline comments to D102766: [SelectionDAG] Implement PromoteIntRes_INSERT_SUBVECTOR.
May 20 2021, 10:42 AM · Restricted Project
paulwalker-arm added inline comments to D102607: [AArch64][SVE] Add fixed length codegen for FP_ROUND/FP_EXTEND.
May 20 2021, 10:28 AM · Restricted Project
paulwalker-arm accepted D102498: [AArch64][SVE] Improve codegen for fixed length vector concat.
May 20 2021, 10:03 AM · Restricted Project
paulwalker-arm accepted D102699: [InstSimplify] Properly constrain {insert,extract}_subvector intrinsic fold.
May 20 2021, 9:44 AM · Restricted Project

May 19 2021

paulwalker-arm added inline comments to D102498: [AArch64][SVE] Improve codegen for fixed length vector concat.
May 19 2021, 10:32 AM · Restricted Project
paulwalker-arm added a comment to D102607: [AArch64][SVE] Add fixed length codegen for FP_ROUND/FP_EXTEND.

I've added a recommendation that I believe will also simplify D102777.

May 19 2021, 9:29 AM · Restricted Project

May 18 2021

paulwalker-arm added inline comments to D102498: [AArch64][SVE] Improve codegen for fixed length vector concat.
May 18 2021, 8:58 AM · Restricted Project
paulwalker-arm added inline comments to D101986: [InstSimplify] Remove redundant {insert,extract}_vector intrinsic chains.
May 18 2021, 8:35 AM · Restricted Project, Restricted Project
paulwalker-arm added inline comments to D102498: [AArch64][SVE] Improve codegen for fixed length vector concat.
May 18 2021, 8:12 AM · Restricted Project
paulwalker-arm added inline comments to D102498: [AArch64][SVE] Improve codegen for fixed length vector concat.
May 18 2021, 3:08 AM · Restricted Project

May 17 2021

paulwalker-arm added inline comments to D101945: [LV] Add -scalable-vectorization=<option> flag..
May 17 2021, 4:01 AM · Restricted Project
paulwalker-arm added inline comments to D101945: [LV] Add -scalable-vectorization=<option> flag..
May 17 2021, 3:46 AM · Restricted Project
paulwalker-arm accepted D101945: [LV] Add -scalable-vectorization=<option> flag..
May 17 2021, 2:37 AM · Restricted Project
paulwalker-arm added inline comments to D102498: [AArch64][SVE] Improve codegen for fixed length vector concat.
May 17 2021, 2:18 AM · Restricted Project

May 16 2021

paulwalker-arm added a comment to D101945: [LV] Add -scalable-vectorization=<option> flag..

A few stylistic things to consider that I'll not hold you to, but the change to validate is the main thing stopping me from accepting the patch.

May 16 2021, 4:15 AM · Restricted Project

May 13 2021

paulwalker-arm accepted D101831: [AArch64][SVE] Add unpredicated vector BIC ISD node.
May 13 2021, 3:14 AM · Restricted Project
paulwalker-arm accepted D102077: [AArch64][SVE] Combine cntp intrinsics with add/sub to produce incp/decp.
May 13 2021, 3:10 AM · Restricted Project

May 12 2021

paulwalker-arm added inline comments to D101945: [LV] Add -scalable-vectorization=<option> flag..
May 12 2021, 9:48 AM · Restricted Project
paulwalker-arm added inline comments to D102330: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs for RDFFR_P.
May 12 2021, 8:17 AM · Restricted Project
paulwalker-arm accepted D101357: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for optimizePTestInstr.
May 12 2021, 7:03 AM · Restricted Project
paulwalker-arm added inline comments to D101357: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for optimizePTestInstr.
May 12 2021, 4:52 AM · Restricted Project

May 11 2021

paulwalker-arm accepted D101544: [AArch64][SVE] Improve sve.convert.to.svbool lowering.
May 11 2021, 9:47 AM · Restricted Project
paulwalker-arm added inline comments to D101831: [AArch64][SVE] Add unpredicated vector BIC ISD node.
May 11 2021, 7:44 AM · Restricted Project
paulwalker-arm accepted D101357: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for optimizePTestInstr.

Looks good to me. I've a few comments that you're free to ignore.

May 11 2021, 4:51 AM · Restricted Project

May 10 2021

paulwalker-arm added inline comments to D102077: [AArch64][SVE] Combine cntp intrinsics with add/sub to produce incp/decp.
May 10 2021, 11:39 AM · Restricted Project

May 2 2021

paulwalker-arm added inline comments to D101357: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for optimizePTestInstr.
May 2 2021, 3:37 AM · Restricted Project
paulwalker-arm added inline comments to D101544: [AArch64][SVE] Improve sve.convert.to.svbool lowering.
May 2 2021, 3:07 AM · Restricted Project
paulwalker-arm accepted D100527: [AArch64][SVE] More unpredicated ld1/st1 patterns for reg+reg addressing modes.

If you think it's worth addressing, I can try messing with the matcher.

May 2 2021, 2:34 AM · Restricted Project

Apr 30 2021

paulwalker-arm accepted D101642: [AArch64][SVE] Remove unused function missed from D101302.
Apr 30 2021, 8:36 AM · Restricted Project
paulwalker-arm accepted D101593: [AArch64][SVE] Remove index_vector node..

Please can you also remove INDEX_VECTOR from the AArch64ISD enum.

Apr 30 2021, 5:09 AM · Restricted Project
paulwalker-arm accepted D101574: [AArch64] Fix lowering for fshl/fshr with SVE types..

I'm not against adding the extra tests, which could also include the legal i8, i16 & i32 vector types, but for my money there's little new code here so I'm happy to assume the common expand/legalisation code is already well tested.

Apr 30 2021, 3:24 AM · Restricted Project
paulwalker-arm accepted D100816: [AArch64][SVE] Lower index_vector to step_vector.
Apr 30 2021, 3:17 AM · Restricted Project
paulwalker-arm added a comment to D100527: [AArch64][SVE] More unpredicated ld1/st1 patterns for reg+reg addressing modes.

Are we concerned about the reduced code quality shown by the splice tests? Is there a way to know if the basic block is, or within, a loop body? so that we can restrict the patterns to instances where we're confident the extra instructions are likely to be hoisted. I guess for the PTRUE case we already know there is a need for some kind of machine pass to remove larger element PTRUEs when a smaller element one is safe to use.

Apr 30 2021, 3:12 AM · Restricted Project

Apr 29 2021

paulwalker-arm added a comment to D100816: [AArch64][SVE] Lower index_vector to step_vector.

Assuming you agree I think you can just delete a bit of code and then the patch is good to go.

Apr 29 2021, 10:07 AM · Restricted Project

Apr 28 2021

paulwalker-arm added inline comments to D101369: [AArch64][SVE] Fold insert(zero, extract(X, 0), 0) -> X, when X is known to zero lanes 1-N.
Apr 28 2021, 2:11 AM · Restricted Project

Apr 27 2021

paulwalker-arm added inline comments to D101062: [AArch64][SVE] Better utilisation of unpredicated forms of arithmetic intrinsics.
Apr 27 2021, 7:31 AM · Restricted Project
paulwalker-arm added inline comments to D101076: [SVE][LoopVectorize] Add support for scalable vectorization of first-order recurrences.
Apr 27 2021, 6:08 AM · Restricted Project
paulwalker-arm accepted D101042: [AArch64] Add missing UINT_TO_FP promotions for v16i8.

Looks fine to me given this is more a "compiler shouldn't crash" test that will be updated once we have support to custom lower these nodes.

Apr 27 2021, 5:10 AM · Restricted Project
paulwalker-arm added inline comments to D100816: [AArch64][SVE] Lower index_vector to step_vector.
Apr 27 2021, 5:07 AM · Restricted Project

Apr 26 2021

paulwalker-arm added inline comments to D101042: [AArch64] Add missing UINT_TO_FP promotions for v16i8.
Apr 26 2021, 3:42 AM · Restricted Project

Apr 23 2021

paulwalker-arm added inline comments to D101076: [SVE][LoopVectorize] Add support for scalable vectorization of first-order recurrences.
Apr 23 2021, 4:14 AM · Restricted Project

Apr 22 2021

paulwalker-arm accepted D100370: [AArch64][SVE] Fix bug in lowering of fixed-length integer vector divides.

The non-power-of-two RUN lines should be extended to allow maximum testing (see comments) but otherwise looks good.

Apr 22 2021, 9:59 AM · Restricted Project
paulwalker-arm accepted D100812: [DAGCombiner] Allow operand of step_vector to be negative..

A couple of minor requests plus it's worth adding a "step-vector has more than one use" test but otherwise looks good to me. Thanks for your efforts @junparser, also thanks @frasercrmck and @craig.topper for the assists.

Apr 22 2021, 3:14 AM · Restricted Project

Apr 21 2021

paulwalker-arm added inline comments to D100812: [DAGCombiner] Allow operand of step_vector to be negative..
Apr 21 2021, 8:48 AM · Restricted Project
paulwalker-arm added inline comments to D100858: [AArch64][SVE] Allow generation of MOVPRFX for intrinsic nodes.
Apr 21 2021, 5:56 AM · Restricted Project
paulwalker-arm added inline comments to D100812: [DAGCombiner] Allow operand of step_vector to be negative..
Apr 21 2021, 5:17 AM · Restricted Project