Page MenuHomePhabricator
Feed Advanced Search

Today

jhenderson committed rGccf16c4d381d: Make test more robust (authored by jhenderson).
Make test more robust
Mon, Apr 6, 7:00 AM
jhenderson closed D77546: [test][llvm-objcopy] Make test robust against "foo" being in user's path.
Mon, Apr 6, 7:00 AM · Restricted Project
jhenderson accepted D77399: [llvm-readobj] - Introduce warnings for cases when unable to read strings from string tables..

LGTM.

Mon, Apr 6, 7:00 AM
jhenderson added inline comments to D61727: [llvm-objcopy] Add additional testing for various cases.
Mon, Apr 6, 6:27 AM · Restricted Project
Herald added a reviewer for D77546: [test][llvm-objcopy] Make test robust against "foo" being in user's path: alexshap.
Mon, Apr 6, 6:27 AM · Restricted Project
jhenderson accepted D77388: [llvm-objdump][NFC] Declare command-line externs in headers with namespace.

LGTM, too.

Mon, Apr 6, 1:36 AM · Restricted Project
jhenderson added a comment to D77383: [FileCheck] Allow parenthesized expressions.

Thanks for this. I think this is a good step in the right direction for FileCheck's numeric expression support. You should probably add something to the FileCheck documentation about operator precedence and also using parentheses.

Mon, Apr 6, 1:36 AM · Restricted Project
jhenderson updated subscribers of D74169: [WIP][LLD][ELF][DebugInfo] Remove obsolete debug info..

One drive-by request/question: have you done any measurements of the impact on debuggers? In other words, does it improve/make worse the time it takes them to load the debug data?

Mon, Apr 6, 1:03 AM · debug-info, lld, Restricted Project
jhenderson accepted D77495: [docs][llvm-dwarfdump] Add the release notes about --show-section-sizes.

Ha, I'm not sure I've ever writetn a release note for LLVM, despite adding various options! LGTM, but might be worth reaching out to someone who has written previous release notes to ensure it's well formed.

Mon, Apr 6, 1:03 AM · debug-info
jhenderson accepted D77352: [llvm] Fix missing FileCheck directive colons.

I'm not sure if it was intended, but the addition of colons in the original version of the patch to llvm/test/Transforms/LoopStrengthReduce/X86/lsr-insns-2.ll seem to have disappeared in the rebase. Otherwise, looks good to me.

Mon, Apr 6, 1:03 AM · Restricted Project
jhenderson added inline comments to D77399: [llvm-readobj] - Introduce warnings for cases when unable to read strings from string tables..
Mon, Apr 6, 12:29 AM

Fri, Apr 3

jhenderson accepted D76543: [llvm-dwp] Fix a possible out of bound access..

Looks good, though probably should get someone else to confirm.

Fri, Apr 3, 4:48 AM · debug-info, Restricted Project
jhenderson added inline comments to D76543: [llvm-dwp] Fix a possible out of bound access..
Fri, Apr 3, 3:11 AM · debug-info, Restricted Project
jhenderson added a comment to D77289: [Object] Fix crash caused by unhandled error..

I'd also recommend to start using "Edit related revisions" on the right panel of the phab.
Then you should be able to edit related parent/child revisions, because currently it is unobvious which dependencies your patches has.

Fri, Apr 3, 3:11 AM · Restricted Project
jhenderson accepted D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Correct grammatical mistakes. I will try my best to avoid these mistakes next time ...

Fri, Apr 3, 1:34 AM · Restricted Project
jhenderson added a comment to D77289: [Object] Fix crash caused by unhandled error..

Thinking about it, I'm reluctant to approve this as is, without a further change to actually report the error (possibly in a seperate patch). Prior to this patch, we have a failure that at least can be identified in certain build versions, whereas now the malformed-ness is not detectable at all. Perhaps this could temporarily use report_fatal_error with a follow-up patch bubbling the error further up the stack?

Fri, Apr 3, 1:34 AM · Restricted Project
jhenderson added inline comments to D77352: [llvm] Fix missing FileCheck directive colons.
Fri, Apr 3, 1:34 AM · Restricted Project
jhenderson added a reviewer for D77227: [RFC][FileCheck] Require colon immediately after CHECK directives: jhenderson.

Chiming in late, as I only just saw this discussion. I'll be honest, I don't fully follow the explanations. Would it be possible to write up the policy in FileCheck's documentation somewhere?

Fri, Apr 3, 1:02 AM · Restricted Project
jhenderson added inline comments to D76543: [llvm-dwp] Fix a possible out of bound access..
Fri, Apr 3, 12:30 AM · debug-info, Restricted Project
jhenderson added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Fri, Apr 3, 12:30 AM · Restricted Project
jhenderson added a comment to D76250: [llvm-objdump] Only reject -long-option in objdump mode.

The precedent for behaviour based on the name is long standing and not being introduced here. In fact the archiver already does this. clang also does this (clang vs clang++). This is not at all uncommon I think. The target triple prefixed tools should be treated as the tool that they specify and implicitly passing -target ... which is derived from the prefix.

Fri, Apr 3, 12:30 AM · Restricted Project
jhenderson added a comment to D76878: Implement new DW_OP_LLVM_* operations.

In the mean time, I would like to ask if any of the reviewers have thoughts on how to reconcile the need for more new DW_OP_ extensions than there is encoding space for. Currently we are proposing adding a DW_AT_augmentation which could be applied to DW_TAG_compile_unit which will essentially allow for us to say "this compile unit uses extension X", and as part of our definition of the extension we could indicate that we are using certain encodings that may already be in use elsewhere. Essentially this would be a way for extension vendors to multiplex over the same limited encoding space. I imagine we would carry this augmentation string in the DICompileUnit metadata.

Fri, Apr 3, 12:30 AM · debug-info, Restricted Project

Thu, Apr 2

jhenderson added a comment to D77285: [llvm-objdump][COFF][NFC] Split format-specific interfaces; add namespace.

Lots of small changes is fine by me, and probably even preferable overall.

Okay. I will address the comments on the commit (and change the patch description accordingly) if it goes smoothly. Would you like to see the other patches (if they don't have additional complications) posted for pre-commit review?

Thu, Apr 2, 11:57 PM · Restricted Project
jhenderson accepted D77302: [DebugInfo] Rename getOffset() to getContribution(). NFC..

LGTM

Thu, Apr 2, 7:33 AM · Restricted Project, debug-info, Restricted Project
jhenderson added a comment to D77285: [llvm-objdump][COFF][NFC] Split format-specific interfaces; add namespace.

Please let me know if there is a preference to post additional patches in parts in the same style or to update this one with the changes associated with the other files when they are all done. Thanks.

Thu, Apr 2, 7:01 AM · Restricted Project
jhenderson added a comment to D74755: [llvm-objcopy] Attribute an empty section to a segment ending at its address.

I've played around with the llvm-objcopy's with and without this patch to see the impact of the change. One situation I noticed is where using the --remove-section option, combined with the --only-keep-debug option. In the example I'm using, there is a PT_LOAD which contains a PT_GNU_RELRO, which contains, at its end, a PT_TLS, with another relro section before the TLS segment. (Note: the segment types, apart from the PT_LOAD are irrelevant here - a custom linker script could have all sorts of different segment types where this layout could happen). If the relro section is removed by objcopy, the output from only-keep-debug differs before and after this patch. I haven't experimented yet due to time constraints, but I wouldn't be entirely surprised if the same behaviour difference would be observed if --remove-section was performed in a prior run of llvm-objcopy, or if the section was replaced with segment padding of some variety.

Thu, Apr 2, 3:45 AM · Restricted Project
jhenderson added inline comments to D77289: [Object] Fix crash caused by unhandled error..
Thu, Apr 2, 2:40 AM · Restricted Project
jhenderson added inline comments to D77289: [Object] Fix crash caused by unhandled error..
Thu, Apr 2, 1:03 AM · Restricted Project
jhenderson accepted D77285: [llvm-objdump][COFF][NFC] Split format-specific interfaces; add namespace.

LGTM, with or without my comments addressed.

Thu, Apr 2, 1:03 AM · Restricted Project
jhenderson added a comment to D76250: [llvm-objdump] Only reject -long-option in objdump mode.

@jhenderson - accepting GNU options in GNU mode makes sense. This tool is *not* GNU - objdump is the GNU driver, llvm-objdump is the LLVM driver and accepts SUN style arguments.

Thu, Apr 2, 1:03 AM · Restricted Project
jhenderson added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Thu, Apr 2, 1:03 AM · Restricted Project
jhenderson added inline comments to D76833: [CodingStandards] Document coding standard for error and warning messages.
Thu, Apr 2, 12:30 AM · Restricted Project
jhenderson added inline comments to D67646: [llvm][TextAPI] adding inlining reexported libraries support.
Thu, Apr 2, 12:30 AM · Restricted Project

Wed, Apr 1

jhenderson added a comment to D77216: [llvm-readobj] - Fix crashes and misbehaviors when reading strings from broken string tables..

Hmmm... my first instinct here is that we should print a single warning out-of-line, and then use the "<?>" pattern in place of the invalid strings. That probably goes for the existing messages too. What do you think about that idea?

Wed, Apr 1, 7:52 AM
jhenderson added a comment to D76276: [Object] Add the method for checking if a section is a debug section.

Can this go as is, since the D74205 has a few tests using this? I agree a unit test is not the best solution for this..

Wed, Apr 1, 7:40 AM · Restricted Project, debug-info
jhenderson accepted D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.
Wed, Apr 1, 6:02 AM · Restricted Project
jhenderson accepted D77147: [llvm-readobj] - Do not crash when SHT_HASH table is broken..

LGTM.

Wed, Apr 1, 4:24 AM · Restricted Project
jhenderson accepted D75929: [DebugInfo] Support DWARFv5 index sections..

Nothing else from me, thanks.

Wed, Apr 1, 3:18 AM · Restricted Project, debug-info, Restricted Project
jhenderson accepted D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.

LGTM, with two more reportError -> reportWarning changes.

Wed, Apr 1, 2:43 AM · Restricted Project
jhenderson added inline comments to D77146: [DebugInfo] Fix reading location tables headers of v5 units in DWP..
Wed, Apr 1, 2:16 AM · debug-info, Restricted Project
jhenderson added a comment to D77145: [DebugInfo] Fix reading location tables of v5 units in DWP..

Again, looks good, although I'm not up-to-speed on the .debug_loc/.debug_loclists format, so this should get a second pair of eyes on it.

Wed, Apr 1, 1:03 AM · debug-info, Restricted Project
jhenderson accepted D77146: [DebugInfo] Fix reading location tables headers of v5 units in DWP..

Looks good to me, although I'm not fully up to speed on .debug_loclists to be 100% certain, so might be worth a second opinion.

Wed, Apr 1, 1:03 AM · debug-info, Restricted Project
jhenderson added inline comments to D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.
Wed, Apr 1, 1:03 AM · Restricted Project
jhenderson added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Wed, Apr 1, 12:30 AM · Restricted Project
jhenderson added a comment to D73306: llvm-addr2line: assume addresses on the command line are hexadecimal rather than attempting to guess the base based on the form of the number..

I think all the changes are good, but I'd like to see this patch independently of the variable renamings and document rewording before giving final approval to be sure. Please could you create separate commits for those and then rebase this patch on top, showing the diff of this patch only then.

Wed, Apr 1, 12:30 AM · Restricted Project
jhenderson accepted D76834: [yaml2obj] - Add NBucket and NChain fields for the SHT_HASH section..

LGTM.

Wed, Apr 1, 12:30 AM · Restricted Project
jhenderson added inline comments to D77147: [llvm-readobj] - Do not crash when SHT_HASH table is broken..
Wed, Apr 1, 12:30 AM · Restricted Project

Tue, Mar 31

jhenderson accepted D74205: [llvm-dwarfdump] Add the --show-sections-sizes option.
Tue, Mar 31, 8:16 AM · Restricted Project, debug-info
jhenderson added inline comments to D74205: [llvm-dwarfdump] Add the --show-sections-sizes option.
Tue, Mar 31, 7:12 AM · Restricted Project, debug-info
jhenderson accepted D74205: [llvm-dwarfdump] Add the --show-sections-sizes option.

LGTM, with one last request.

Tue, Mar 31, 6:37 AM · Restricted Project, debug-info
jhenderson committed rGb4d0384a6cd7: [ELF][test] Add test for --gc-sections + many sections (authored by jhenderson).
[ELF][test] Add test for --gc-sections + many sections
Tue, Mar 31, 4:59 AM
jhenderson committed rG0aa9c5429b83: [lld][ELF][test] Improve deplib.s (authored by jhenderson).
[lld][ELF][test] Improve deplib.s
Tue, Mar 31, 4:59 AM
jhenderson closed D76003: [ELF][test] Add test for --gc-sections + many sections.
Tue, Mar 31, 4:58 AM · Restricted Project
jhenderson closed D76851: [lld][ELF][test] Improve deplib.s.
Tue, Mar 31, 4:58 AM · Restricted Project
jhenderson committed rG6aacdd6083d8: [docs] Document coding standard for error and warning messages (authored by jhenderson).
[docs] Document coding standard for error and warning messages
Tue, Mar 31, 4:58 AM
jhenderson closed D76833: [CodingStandards] Document coding standard for error and warning messages.
Tue, Mar 31, 4:57 AM · Restricted Project
jhenderson added inline comments to D76833: [CodingStandards] Document coding standard for error and warning messages.
Tue, Mar 31, 3:18 AM · Restricted Project
jhenderson updated the diff for D76851: [lld][ELF][test] Improve deplib.s.

Remove "-unknown-linux" and adopted @grimar's suggestion.

Tue, Mar 31, 3:18 AM · Restricted Project
jhenderson updated subscribers of D74755: [llvm-objcopy] Attribute an empty section to a segment ending at its address.

Sorry for the delay in coming back again to this. It's taken me quite some time to collect my thoughts and find time for it, amidst all the other reviews people want my input on, not to mention my actual own workload.

Tue, Mar 31, 3:18 AM · Restricted Project
jhenderson requested changes to D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.

Sorry, I spotted the error handling is not using llvm-readobj's style. Please fix it.

Tue, Mar 31, 1:04 AM · Restricted Project
jhenderson added inline comments to D73306: llvm-addr2line: assume addresses on the command line are hexadecimal rather than attempting to guess the base based on the form of the number..
Tue, Mar 31, 1:04 AM · Restricted Project
jhenderson added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Tue, Mar 31, 1:04 AM · Restricted Project
jhenderson accepted D76733: New symbolizer option to print files relative to the compilation directory..

LGTM, with a nit.

Tue, Mar 31, 12:30 AM · Restricted Project
jhenderson added a comment to D74205: [llvm-dwarfdump] Add the --show-sections-sizes option.

I'm not at all familiar with Mach-O, so how do fat archives get generated (i.e. with what tool?)? Is there an LLVM equivalent we can use here?

There is no such thing as a fat archive, just regular archives that contain fat object files. The tool to create fat binaries is called lipo and there seems to be an llvm variant of it.

Tue, Mar 31, 12:30 AM · Restricted Project, debug-info

Mon, Mar 30

jhenderson accepted D76920: [llvm-readobj] - Improve test of --elf-hash-histogram option..

LGTM.

Mon, Mar 30, 5:55 AM · Restricted Project
jhenderson updated the diff for D76851: [lld][ELF][test] Improve deplib.s.

Fix other test due to removal of input file.

Mon, Mar 30, 4:50 AM · Restricted Project
jhenderson accepted D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..

Latest version looks good to me too.

Mon, Mar 30, 3:45 AM · Restricted Project, debug-info
jhenderson updated the diff for D76851: [lld][ELF][test] Improve deplib.s.

Address review comments:

  • Deleted foo input file.
  • Fix spacing.
  • Improved comment.
Mon, Mar 30, 3:44 AM · Restricted Project
jhenderson updated the diff for D76833: [CodingStandards] Document coding standard for error and warning messages.

Address comments. I'll leave this another 24 hours and then commit it, if that's okay?

Mon, Mar 30, 3:12 AM · Restricted Project
jhenderson added a comment to D76003: [ELF][test] Add test for --gc-sections + many sections.

Ping @MaskRay?

Mon, Mar 30, 2:40 AM · Restricted Project
jhenderson added a comment to D76543: [llvm-dwp] Fix a possible out of bound access..

Thanks. Looks good from my point of view, but @dblaikie should confirm he's happy.

Mon, Mar 30, 2:40 AM · debug-info, Restricted Project
jhenderson added inline comments to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..
Mon, Mar 30, 2:07 AM · Restricted Project, debug-info
jhenderson added inline comments to D76543: [llvm-dwp] Fix a possible out of bound access..
Mon, Mar 30, 1:35 AM · debug-info, Restricted Project
jhenderson added inline comments to D76920: [llvm-readobj] - Improve test of --elf-hash-histogram option..
Mon, Mar 30, 1:35 AM · Restricted Project
jhenderson accepted D76924: [llvm-readobj][test] - Simplify hash-symbols.test test..

LGTM.

Mon, Mar 30, 1:35 AM · Restricted Project
jhenderson added a comment to D76907: [PPCInstPrinter] Print conditional branches as `bt 2, $target` instead of `bt 2, .+$imm`.

I'm out of my depth here, so can't realistically review this. Sorry.

Mon, Mar 30, 1:02 AM · Restricted Project
jhenderson accepted D75342: [obj2yaml] - Teach tool to dump program headers..

LGTM, I think. Please wait for @MaskRay to confirm.

Mon, Mar 30, 1:02 AM · Restricted Project
jhenderson added inline comments to D76733: New symbolizer option to print files relative to the compilation directory..
Mon, Mar 30, 1:02 AM · Restricted Project
jhenderson added a comment to D77025: [Object] Update ObjectFile::makeTriple for XCOFF.

Did you see that there are a bunch of test failures according to the pre-merge build? Don't know if they're related, but I guess that they are somehow.

Mon, Mar 30, 12:30 AM · Restricted Project
jhenderson added a comment to D74023: [RISCV] ELF attribute section for RISC-V.

The code generally looks good. For unittests, I think we can either make llvm-readobj -A canonical or the unittests canonical. If we decide to place tests on one place, we should delete most tests on the other side.

My current preference is that we use more of unittests and leave the minimum to test/llvm-readobj/ELF/{ARM,RISCV}/

Agree. I will remove redundant tests in test/tools/llvm-readobj/ELF/{ARM,RISCV}/.

Mon, Mar 30, 12:30 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..
Mon, Mar 30, 12:30 AM · Restricted Project, debug-info
jhenderson added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Ahhhh, After enable -DLLVM_ENABLE_ASSERTIONS=ON,

there's an error: section [index 2] has an invalid sh_size (33) which is not a multiple of its sh_entsize (16)Stack dump. But this error won't show up in a release build. I think we should at least warn user about this?

Where abouts does this message come from?

Mon, Mar 30, 12:30 AM · Restricted Project
jhenderson added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Ahhhh, After enable -DLLVM_ENABLE_ASSERTIONS=ON,

there's an error: section [index 2] has an invalid sh_size (33) which is not a multiple of its sh_entsize (16)Stack dump. But this error won't show up in a release build. I think we should at least warn user about this?

Mon, Mar 30, 12:29 AM · Restricted Project
jhenderson added a comment to D74205: [llvm-dwarfdump] Add the --show-sections-sizes option.

I think that @aprantl wanted a test for Mach-O and archives, back then. I've added a test for mach-o and archive, in one shot (by using pre-existing fat mach-o archive from dsymutil).

What makes the dsymutil test special is that you can have fat (=multi-architecture) Mach-O binaries inside a static archive and it is important to test that this case is handled correctly, because you have two layers of multi-file enumeration going on. Since we already have it checked in as a binary I thought reusing it would be preferable over checking in yet another opaque binary. If we can generate one one the fly, that's fine, too.

Mon, Mar 30, 12:29 AM · Restricted Project, debug-info
jhenderson accepted D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

LGTM.

Mon, Mar 30, 12:29 AM · Restricted Project
jhenderson added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Mon, Mar 30, 12:29 AM · Restricted Project

Fri, Mar 27

jhenderson added reviewers for D76878: Implement new DW_OP_LLVM_* operations: dblaikie, ikudrin, aprantl, probinson, djtodoro, ostannard.

I've added a few reviewers who are probably better placed to review things from the DWARF/DW_OP perspective than me.

Fri, Mar 27, 4:50 AM · debug-info, Restricted Project
jhenderson added reviewers for D76877: Implement DW_CFA_LLVM_def_cfa_aspace: dblaikie, aprantl, djtodoro, ostannard, probinson, ikudrin.
Fri, Mar 27, 4:50 AM · debug-info, Restricted Project
jhenderson added a comment to D76852: [lld test] Tighten ELF/pre_init_fini_array.s test.

Looks good from my perspective. I'll leave it up to @MaskRay to approve once you've taken a look at his suggestion.

Fri, Mar 27, 4:50 AM · Restricted Project
jhenderson added a comment to D74205: [llvm-dwarfdump] Add the --show-sections-sizes option.

Do you think a regular llvm-ar archive test is sufficient for this testing, or do you think a mach-o fat archive is important to test independently? I don't see a massive need for the latter personally.

Fri, Mar 27, 4:18 AM · Restricted Project, debug-info
jhenderson accepted D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

LGTM, from a stylistic point of view. Not sure I can comment much on the behaviour parts that I haven't commented on. Please wait for other reviewers to approve too.

Fri, Mar 27, 3:44 AM · Restricted Project
jhenderson accepted D76706: [llvm-readobj] - Fix the crash when DT_STRTAB is broken..

LGTM, with one fix.

Fri, Mar 27, 2:38 AM · Restricted Project
jhenderson added inline comments to D75342: [obj2yaml] - Teach tool to dump program headers..
Fri, Mar 27, 2:38 AM · Restricted Project
jhenderson accepted D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.

LGTM. Please wait for @MaskRay to approve too, since I don't know very much about the details here.

Fri, Mar 27, 2:06 AM · Restricted Project

Thu, Mar 26

jhenderson committed rG3ff3c6986b1a: [lld][ELF] Fix error message (authored by jhenderson).
[lld][ELF] Fix error message
Thu, Mar 26, 8:40 AM
jhenderson closed D76846: [lld][ELF] Fix error message.
Thu, Mar 26, 8:39 AM · Restricted Project
jhenderson updated the diff for D76833: [CodingStandards] Document coding standard for error and warning messages.

Address review comments.

Thu, Mar 26, 8:38 AM · Restricted Project
jhenderson updated the diff for D76851: [lld][ELF][test] Improve deplib.s.

Remove unneeded test input.

Thu, Mar 26, 8:06 AM · Restricted Project
jhenderson created D76851: [lld][ELF][test] Improve deplib.s.
Thu, Mar 26, 8:06 AM · Restricted Project
jhenderson created D76846: [lld][ELF] Fix error message.
Thu, Mar 26, 7:33 AM · Restricted Project