Page MenuHomePhabricator
Feed Advanced Search

Fri, Jun 14

jhenderson committed rG891cdaab7a29: [docs][llvm-dwarfdump] Make the --show-parents and --show-children help text… (authored by jhenderson).
[docs][llvm-dwarfdump] Make the --show-parents and --show-children help text…
Fri, Jun 14, 5:57 AM
jhenderson committed rL363380: [docs][llvm-dwarfdump] Make the --show-parents and --show-children help text….
[docs][llvm-dwarfdump] Make the --show-parents and --show-children help text…
Fri, Jun 14, 5:57 AM
jhenderson closed D63275: [docs][llvm-dwarfdump] Make the --show-parents and --show-children help text and docs more consistent and correct.
Fri, Jun 14, 5:57 AM · Restricted Project
jhenderson committed rGf7cfabb45d87: [llvm-readobj] Don't abort printing of dynamic table if string reference is… (authored by jhenderson).
[llvm-readobj] Don't abort printing of dynamic table if string reference is…
Fri, Jun 14, 5:00 AM
jhenderson committed rL363374: [llvm-readobj] Don't abort printing of dynamic table if string reference is….
[llvm-readobj] Don't abort printing of dynamic table if string reference is…
Fri, Jun 14, 4:58 AM
jhenderson closed D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid.
Fri, Jun 14, 4:58 AM · Restricted Project
jhenderson created D63327: [docs][llvm-nm] Improve symbol code documentation.
Fri, Jun 14, 4:48 AM · Restricted Project
jhenderson accepted D63266: [llvm-readobj] - Do not fail to dump the object which has wrong type of .shstrtab..

LGTM.

Fri, Jun 14, 4:33 AM · Restricted Project
jhenderson accepted D63267: [yaml2obj] - Allow setting custom section types for implicit sections..

LGTM, with one nit.

Fri, Jun 14, 4:24 AM · Restricted Project
jhenderson added a comment to D63313: [llvm-objcopy] Remove no-op flush of errs.

What about llvm::outs()?

llvm::outs() is buffered, so would need flushing, although I vaguely remember seeing something in the code somewhere that automatically did it on process termination.

Fri, Jun 14, 4:21 AM · Restricted Project
jhenderson added a comment to D63313: [llvm-objcopy] Remove no-op flush of errs.

That's actually kind-of a problem. Unless *something* ensures that all the output
that was written into that is flushed, it may end up being dropped, rL360124.

Fri, Jun 14, 3:28 AM · Restricted Project
jhenderson added a comment to D63122: [llvm-strip] Error when using stdin twice .

Looks good, aside from the comment.

Fri, Jun 14, 3:25 AM · Restricted Project
jhenderson accepted D63090: [objcopy] Error when --preserve-dates is specified with standard streams.

LGTM.

Fri, Jun 14, 3:20 AM · Restricted Project
jhenderson accepted D63238: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target.

LGTM.

Fri, Jun 14, 3:19 AM · Restricted Project
jhenderson added a comment to D63239: [llvm-objcopy][NFC] Refactor output target parsing.

LGTM, with one nit. Also, if I understand it correctly, this change should have no functional change, right? In that case, please tag the summary with [NFC] (i.e. [llvm-objcopy][NFC] Refactor output target parsing) when you commit.

Fri, Jun 14, 3:17 AM · Restricted Project
jhenderson added inline comments to D62838: [Object] add isExecutableObject member function.
Fri, Jun 14, 3:03 AM · Restricted Project
jhenderson added a comment to D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid.

@grimar, are you happy for me to land this patch?

Fri, Jun 14, 2:38 AM · Restricted Project
jhenderson added a comment to D63292: [docs] Workaround old recommonmark version on buildbots.

html can be embedded in markdown? That was unexpected and sounds good. Does this work when generating man pages though instead of html?

Fri, Jun 14, 2:34 AM · Restricted Project

Thu, Jun 13

jhenderson accepted D63258: [llvm-objcopy][IHEX] Improve test case formatting. NFC.

LGTM.

Thu, Jun 13, 8:52 AM · Restricted Project
jhenderson accepted D63136: [yaml2obj] - Allow setting cutom Flags for implicit sections..

LGTM.

Thu, Jun 13, 8:49 AM · Restricted Project
jhenderson added a comment to D61672: [llvm-objcopy] Allow strip symtab in executables and DSOs.

The point is to test that dynamic symbols are not touched by --strip-unneeded run on executable. Do you think it's not needed?

It's not needed. We don't do anything in llvm-objcopy to the dynamic symbols ever, so I don't think we need to test this in this specific case.

Thu, Jun 13, 8:49 AM
jhenderson added inline comments to D63258: [llvm-objcopy][IHEX] Improve test case formatting. NFC.
Thu, Jun 13, 8:35 AM · Restricted Project
jhenderson added inline comments to D63239: [llvm-objcopy][NFC] Refactor output target parsing.
Thu, Jun 13, 8:32 AM · Restricted Project
jhenderson created D63275: [docs][llvm-dwarfdump] Make the --show-parents and --show-children help text and docs more consistent and correct.
Thu, Jun 13, 8:03 AM · Restricted Project
jhenderson added inline comments to D63267: [yaml2obj] - Allow setting custom section types for implicit sections..
Thu, Jun 13, 7:57 AM · Restricted Project
jhenderson added inline comments to D63266: [llvm-readobj] - Do not fail to dump the object which has wrong type of .shstrtab..
Thu, Jun 13, 7:39 AM · Restricted Project
jhenderson committed rGe6820dac99a8: [docs][llvm-symbolizer] Fix formatting issue with --functions (authored by jhenderson).
[docs][llvm-symbolizer] Fix formatting issue with --functions
Thu, Jun 13, 6:58 AM
jhenderson committed rL363266: [docs][llvm-symbolizer] Fix formatting issue with --functions.
[docs][llvm-symbolizer] Fix formatting issue with --functions
Thu, Jun 13, 6:55 AM
jhenderson closed D63195: [docs][llvm-symbolizer] Fix --functions syntax highlighting.
Thu, Jun 13, 6:55 AM · Restricted Project
jhenderson committed rG86b510aa5840: [docs][llvm-dwarfdump] Add missing options and behaviour to documentation (authored by jhenderson).
[docs][llvm-dwarfdump] Add missing options and behaviour to documentation
Thu, Jun 13, 6:53 AM
jhenderson committed rL363264: [docs][llvm-dwarfdump] Add missing options and behaviour to documentation.
[docs][llvm-dwarfdump] Add missing options and behaviour to documentation
Thu, Jun 13, 6:50 AM
jhenderson closed D63217: [docs][llvm-dwarfdump] Add missing options and behaviour to llvm-dwarfdump documentation.
Thu, Jun 13, 6:50 AM · Restricted Project
jhenderson accepted D63251: [llvm-objcopy] Fix sparc target endianness.

LGTM.

Thu, Jun 13, 5:55 AM · Restricted Project
jhenderson added a comment to D63211: [docs] Fix local docs build.

I just started setting up a new Ubuntu 18.04 machine with the intent of migrating away from my old 14.04 installation, and I see the exact same error, with the same versions, so it's not a Windows problem.

Thu, Jun 13, 5:16 AM · Restricted Project
jhenderson added inline comments to D63251: [llvm-objcopy] Fix sparc target endianness.
Thu, Jun 13, 4:35 AM · Restricted Project
jhenderson added a comment to D63238: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target.

Looks good, I think, but does GNU objcopy have sparc as -I/-O type? Is the syntax the same as you have used?

Yes, it has the same target name. I'm not familiar with SPARC at all, but now I noticed that 32-bit SPARC is big endian and gnu-objcopy -Oelf32-sparc certainly emits a big endian ELF file. I think I should fix the SPARC entry in ArchMap before committing this patch. What do you think on this?

Thu, Jun 13, 3:49 AM · Restricted Project
jhenderson added a comment to D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid.

D62072 seems to promote lowercasing the first letter in error messages.

Thu, Jun 13, 2:59 AM · Restricted Project
jhenderson added inline comments to D62583: [llvm-objcopy] Implement IHEX reader.
Thu, Jun 13, 2:20 AM · Restricted Project
jhenderson added a comment to D63239: [llvm-objcopy][NFC] Refactor output target parsing.

Could you explain a bit more the motivation behind this change, please? If I'm not mistaken, it's to allow using input and output format with non-ELF (e.g. COFF and Mach-O) targets?

Thu, Jun 13, 2:13 AM · Restricted Project
jhenderson added a comment to D63238: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target.

Looks good, I think, but does GNU objcopy have sparc as -I/-O type? Is the syntax the same as you have used?

Thu, Jun 13, 2:05 AM · Restricted Project
jhenderson added a comment to D63184: [llvm-objcopy] Recognize the output file format other than ELF.

For what it's worth, the usual thing to do is to leave the "core" of these sort of changes in the original patch, and create one or more new patches for the other part(s).

Thu, Jun 13, 2:02 AM · Restricted Project
jhenderson added a comment to D63185: [llvm-objcopy] [WIP] Librarify llvm-objcopy.

Okay, I think I see what you're getting at now. By creating a copy, you don't need to have the OriginalX fields. I think this makes sense now, okay.

Thu, Jun 13, 2:02 AM · Restricted Project
jhenderson added inline comments to D63122: [llvm-strip] Error when using stdin twice .
Thu, Jun 13, 1:49 AM · Restricted Project
jhenderson added inline comments to D62838: [Object] add isExecutableObject member function.
Thu, Jun 13, 1:43 AM · Restricted Project
jhenderson added a comment to D62964: [llvm-objdump] Include dynamic zero-sized and non-function symbols in disassembly.

How about only addressing what PR41947 need (STT_OBJECT and STT_FUNC) in this patch and have a separate patch addressing matching with GNU on what other types of symbols should show up in output?

PR41947 only used a STT_OBJECT as an example, so we shouldn't just limit this patch to the two types. Note that STT_NOTYPE, as well as symbols with processor etc specific types, can also appear in dynamic symbol tables.

Additionally, a patch for matching GNU on output format for these symbols got shown.

Sorry, I'm not sure I understand what you mean.

Thu, Jun 13, 1:35 AM · Restricted Project
jhenderson accepted D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid.

Looks good, with the suggested changes to the if statements.

Thu, Jun 13, 1:29 AM · Restricted Project

Wed, Jun 12

jhenderson added a comment to D63211: [docs] Fix local docs build.

FWIW, the full error text I got from the build was:
C:\llvm\llvm\docs\CommandGuide\llvm-objcopy.md:16:None:any reference target not found: llvm-strip.html

Wed, Jun 12, 9:41 AM · Restricted Project
jhenderson added a comment to D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..

By the way, since you are touching COFF and Mach-O code, your test should probably be run on a file with each of those formats too.

The change in COFF and Mach-o dumper is covered by

tools/llvm-readobj/coff-needed-libs.test (COFFDumper.cpp)
tools/llvm-readobj/macho-needed-libs.test (MachoDumper.cpp)

Wed, Jun 12, 9:24 AM · Restricted Project
jhenderson added a comment to D63211: [docs] Fix local docs build.

Hmm... Interesting. When I build this locally, the links are correct (linking to llvm-symbolizer.html etc as expected). What version of sphinx-build are you using? And what are the bots using, because I'm guessing that might be the difference.

Wed, Jun 12, 9:13 AM · Restricted Project
jhenderson created D63217: [docs][llvm-dwarfdump] Add missing options and behaviour to llvm-dwarfdump documentation.
Wed, Jun 12, 9:10 AM · Restricted Project
jhenderson created D63211: [docs] Fix local docs build.
Wed, Jun 12, 8:29 AM · Restricted Project
jhenderson added inline comments to D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid.
Wed, Jun 12, 7:06 AM · Restricted Project
jhenderson created D63195: [docs][llvm-symbolizer] Fix --functions syntax highlighting.
Wed, Jun 12, 6:05 AM · Restricted Project
jhenderson added a comment to D61672: [llvm-objcopy] Allow strip symtab in executables and DSOs.

A number of my test comments haven't been addressed yet. Please do so.

Wed, Jun 12, 5:39 AM
jhenderson committed rG31908669c6d0: [docs][llvm-symbolizer] Fix typo and grammar error (authored by jhenderson).
[docs][llvm-symbolizer] Fix typo and grammar error
Wed, Jun 12, 4:39 AM
jhenderson committed rL363145: [docs][llvm-symbolizer] Fix typo and grammar error.
[docs][llvm-symbolizer] Fix typo and grammar error
Wed, Jun 12, 4:39 AM
jhenderson committed rG4cfcacbdfefa: [docs] Fix typo (authored by jhenderson).
[docs] Fix typo
Wed, Jun 12, 3:46 AM
jhenderson committed rL363138: [docs] Fix typo.
[docs] Fix typo
Wed, Jun 12, 3:46 AM
jhenderson committed rG2c16bb80348d: [llvm-nm] Fix docs and help text for --print-size (authored by jhenderson).
[llvm-nm] Fix docs and help text for --print-size
Wed, Jun 12, 3:44 AM
jhenderson committed rL363136: [llvm-nm] Fix docs and help text for --print-size.
[llvm-nm] Fix docs and help text for --print-size
Wed, Jun 12, 3:41 AM
jhenderson closed D63142: [llvm-nm] Fix docs and help text for --print-size.
Wed, Jun 12, 3:41 AM · Restricted Project
jhenderson updated the diff for D63142: [llvm-nm] Fix docs and help text for --print-size.

Add note about Mach-O.

Wed, Jun 12, 3:27 AM · Restricted Project
jhenderson added inline comments to D63142: [llvm-nm] Fix docs and help text for --print-size.
Wed, Jun 12, 2:34 AM · Restricted Project
jhenderson added a comment to D63185: [llvm-objcopy] [WIP] Librarify llvm-objcopy.

At least with renaming a section, what is stopping you just modifying SectionBase.Name?

Wed, Jun 12, 2:31 AM · Restricted Project
jhenderson added a comment to D63184: [llvm-objcopy] Recognize the output file format other than ELF.

@seiya, it looks like what you've observed in the tests is https://bugs.llvm.org/show_bug.cgi?id=42171. Can you confirm, and if so update the bug accordingly?

Wed, Jun 12, 2:17 AM · Restricted Project
jhenderson added a comment to D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..

By the way, since you are touching COFF and Mach-O code, your test should probably be run on a file with each of those formats too.

Wed, Jun 12, 2:10 AM · Restricted Project
jhenderson added inline comments to D63122: [llvm-strip] Error when using stdin twice .
Wed, Jun 12, 1:53 AM · Restricted Project
jhenderson accepted D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid.

My instinct is to say that the RPATH change should be a separate change, since it's not just about the improved error/warning. Please could you split it off (we still want it, just not in a commit to do with error messages). LGTM, aside from that.

Wed, Jun 12, 1:45 AM · Restricted Project

Tue, Jun 11

jhenderson committed rG5058ae0945b9: [docs][llvm-nm] Add darwin as --format option (authored by jhenderson).
[docs][llvm-nm] Add darwin as --format option
Tue, Jun 11, 8:56 AM
jhenderson committed rL363081: [docs][llvm-nm] Add darwin as --format option.
[docs][llvm-nm] Add darwin as --format option
Tue, Jun 11, 8:55 AM
jhenderson created D63142: [llvm-nm] Fix docs and help text for --print-size.
Tue, Jun 11, 8:26 AM · Restricted Project
jhenderson committed rG224410b7c11e: [docs][llvm-nm] Make --help help text consistent with other options (authored by jhenderson).
[docs][llvm-nm] Make --help help text consistent with other options
Tue, Jun 11, 7:53 AM
jhenderson committed rL363073: [docs][llvm-nm] Make --help help text consistent with other options.
[docs][llvm-nm] Make --help help text consistent with other options
Tue, Jun 11, 7:53 AM
jhenderson added a comment to D63137: [yaml2obj] - Allow setting the custom Address for .strtab.

LGTM, with one nit.

Tue, Jun 11, 7:47 AM · Restricted Project
jhenderson added a comment to D63136: [yaml2obj] - Allow setting cutom Flags for implicit sections..

Do we have test cases anywhere for the sections' flags when they aren't described in the YAML?

Tue, Jun 11, 7:45 AM · Restricted Project
jhenderson added a comment to D60261: Change semantics of fadd/fmul vector reductions..

It looks like the documentation change may have broken the sphinx doc job (though I'm not certain it was this change, but the error comes from one of the lines this file touched): http://lab.llvm.org:8011/builders/llvm-sphinx-docs/builds/32236

Thanks for pointing out, for some reason I did not get an automated email about this failure.

I wonder if the 0.0 fp literal is causing the error, although I can't reproduce this locally (maybe due to different version of sphinx?). Probably the simplest fix to get buildbot passing again is to replace the ..code-block:: llvm with ::.

(Note that the LangRef on llvm.org is correctly updated)

Tue, Jun 11, 7:37 AM · Restricted Project
jhenderson committed rG9487963244e4: [llvm-dwarfdump] Simplify --ignore-case help text and documentation (authored by jhenderson).
[llvm-dwarfdump] Simplify --ignore-case help text and documentation
Tue, Jun 11, 6:51 AM
jhenderson committed rL363066: [llvm-dwarfdump] Simplify --ignore-case help text and documentation.
[llvm-dwarfdump] Simplify --ignore-case help text and documentation
Tue, Jun 11, 6:50 AM
jhenderson closed D63133: [llvm-dwarfdump] Simplify --ignore-case help text and documentation and fix grammar error.
Tue, Jun 11, 6:50 AM · Restricted Project
jhenderson committed rGbe7f5c71584c: [docs][llvm-nm] Fix documentation regarding llvm-nm reading stdin (authored by jhenderson).
[docs][llvm-nm] Fix documentation regarding llvm-nm reading stdin
Tue, Jun 11, 6:44 AM
jhenderson committed rL363065: [docs][llvm-nm] Fix documentation regarding llvm-nm reading stdin.
[docs][llvm-nm] Fix documentation regarding llvm-nm reading stdin
Tue, Jun 11, 6:44 AM
jhenderson closed D63135: [docs][llvm-nm] Fix documentation regarding llvm-nm reading stdin.
Tue, Jun 11, 6:43 AM · Restricted Project
jhenderson added a comment to D60261: Change semantics of fadd/fmul vector reductions..

It looks like the documentation change may have broken the sphinx doc job (though I'm not certain it was this change, but the error comes from one of the lines this file touched): http://lab.llvm.org:8011/builders/llvm-sphinx-docs/builds/32236

Tue, Jun 11, 6:42 AM · Restricted Project
jhenderson retitled D63135: [docs][llvm-nm] Fix documentation regarding llvm-nm reading stdin from [docs][llvm-nm to [docs][llvm-nm] Fix documentation regarding llvm-nm reading stdin.
Tue, Jun 11, 6:26 AM · Restricted Project
jhenderson created D63135: [docs][llvm-nm] Fix documentation regarding llvm-nm reading stdin.
Tue, Jun 11, 6:25 AM · Restricted Project
jhenderson added a comment to D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

I've reviewed up to the tests, and got lots of comments for you.

Tue, Jun 11, 6:08 AM · Restricted Project
jhenderson retitled D63133: [llvm-dwarfdump] Simplify --ignore-case help text and documentation and fix grammar error from [llvm-dwarfdump] Simplify --ignore-case help text and documentation and grammar error to [llvm-dwarfdump] Simplify --ignore-case help text and documentation and fix grammar error.
Tue, Jun 11, 5:47 AM · Restricted Project
jhenderson created D63133: [llvm-dwarfdump] Simplify --ignore-case help text and documentation and fix grammar error.
Tue, Jun 11, 4:47 AM · Restricted Project
jhenderson committed rGd5f38dae5982: [llvm-dwarfdump] Add -o to help text and remove --out-file from doc (authored by jhenderson).
[llvm-dwarfdump] Add -o to help text and remove --out-file from doc
Tue, Jun 11, 3:18 AM
jhenderson committed rL363044: [llvm-dwarfdump] Add -o to help text and remove --out-file from doc.
[llvm-dwarfdump] Add -o to help text and remove --out-file from doc
Tue, Jun 11, 3:17 AM
jhenderson closed D63013: [llvm-dwarfdump] Add -o to help text and remove --out-file from documentation.
Tue, Jun 11, 3:17 AM · Restricted Project
jhenderson added inline comments to D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid.
Tue, Jun 11, 3:13 AM · Restricted Project
jhenderson added inline comments to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.
Tue, Jun 11, 3:10 AM · Restricted Project
jhenderson added inline comments to D62838: [Object] add isExecutableObject member function.
Tue, Jun 11, 2:58 AM · Restricted Project
jhenderson added inline comments to D63122: [llvm-strip] Error when using stdin twice .
Tue, Jun 11, 2:54 AM · Restricted Project
jhenderson accepted D63014: [docs] Add "GNU binutils Replacements" section to command guide.

LGTM, with one nit.

Tue, Jun 11, 2:38 AM · Restricted Project
jhenderson added inline comments to D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..
Tue, Jun 11, 2:33 AM · Restricted Project
jhenderson added a comment to D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid.

As you've got D63115 in flight which fixes the FIXME in the test, maybe it would be better holding off committing this until that lands, and then you can avoid having the FIXME at all. What do you think?

Tue, Jun 11, 2:26 AM · Restricted Project
jhenderson added a comment to D63013: [llvm-dwarfdump] Add -o to help text and remove --out-file from documentation.

dwarfdump(-classic) on macOS also supported the --out-file option and on macOS we strive for compatibility with the older tool.

Tue, Jun 11, 2:20 AM · Restricted Project
jhenderson added a comment to rL362819: ELF: Create synthetic sections for loadable partitions..

I reproduced this using a simple linker script as follows:

Tue, Jun 11, 2:17 AM