Page MenuHomePhabricator
Feed Advanced Search

Aug 4 2021

mibintc added a reviewer for D74436: Change clang option -ffp-model=precise to select ffp-contract=on: zahiraam.
Aug 4 2021, 6:35 AM · Restricted Project
mibintc updated subscribers of D74436: Change clang option -ffp-model=precise to select ffp-contract=on.

There was a long discussion on cfe-dev about this issue approximately January-February 2020 including @scanon @andrew.w.kaylor and many others. While there wasn't 100% consensus to move to ffp-contract=on there are many reasons to do it including better numerical results and debuggability. I'm hoping that @andrew.w.kaylor @kbsmith1 @rjmccall and others will join in here.

Aug 4 2021, 6:33 AM · Restricted Project

Jul 30 2021

mibintc added a comment to D74436: Change clang option -ffp-model=precise to select ffp-contract=on.

We are seeing float related unit tests failing in Fuchsia after this patch. What flags should we add to our build to match llvm's previous float point behavior?

Jul 30 2021, 12:30 PM · Restricted Project
mibintc committed rG0a175ad445f0: [clang][patch][FPEnv] Fix syntax errors in pragma float_control test (authored by mibintc).
[clang][patch][FPEnv] Fix syntax errors in pragma float_control test
Jul 30 2021, 7:00 AM

Jul 29 2021

mibintc added a comment to D102343: [clang][patch][FPEnv] Make Initialization of C++ globals strictfp aware.

@MaskRay Thanks a lot -- yes!

Jul 29 2021, 10:38 AM · Restricted Project
mibintc committed rGfd251d903b9b: [clang][patch] Remove erroneous run line committed in D102343 (authored by mibintc).
[clang][patch] Remove erroneous run line committed in D102343
Jul 29 2021, 9:42 AM
mibintc committed rGbc5b5ea037db: [clang][patch][FPEnv] Make initialization of C++ globals strictfp aware (authored by mibintc).
[clang][patch][FPEnv] Make initialization of C++ globals strictfp aware
Jul 29 2021, 9:03 AM
mibintc closed D102343: [clang][patch][FPEnv] Make Initialization of C++ globals strictfp aware.
Jul 29 2021, 9:03 AM · Restricted Project
mibintc closed D106696: Suppress FP_CONTRACT due to planned command line changes (changes in the Makefile)..

commit 79f2b03c5111392d647fa542e120f70c8f39a991
Author: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Date: Mon Jul 26 11:36:23 2021 -0700

Jul 29 2021, 5:32 AM

Jul 28 2021

mibintc committed rG66ddac22e2a7: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend… (authored by mibintc).
[CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend…
Jul 28 2021, 7:51 AM
mibintc closed D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly.
Jul 28 2021, 7:51 AM · Restricted Project

Jul 27 2021

mibintc committed rG48ad446a0fb2: [clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp… (authored by mibintc).
[clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp…
Jul 27 2021, 10:56 AM
mibintc closed D74436: Change clang option -ffp-model=precise to select ffp-contract=on.
Jul 27 2021, 10:56 AM · Restricted Project
mibintc added a reviewer for D106863: Allow #pragma float_control(push|pop) within a language linkage specification: zahiraam.

Adding @zahiraam FYI

Jul 27 2021, 8:03 AM · Restricted Project
mibintc accepted D106863: Allow #pragma float_control(push|pop) within a language linkage specification.

Thanks for fixing this Aaron, just curious was there a bug report?

Jul 27 2021, 7:24 AM · Restricted Project
mibintc abandoned D106836: [LNT][FPEnv] Duplicate of D106696 to trigger pre-commit testing.

This was a DUP to trigger pre-commit testing. It didn't work. Abandon

Jul 27 2021, 7:05 AM

Jul 26 2021

mibintc requested review of D106836: [LNT][FPEnv] Duplicate of D106696 to trigger pre-commit testing.
Jul 26 2021, 4:31 PM
mibintc accepted D106696: Suppress FP_CONTRACT due to planned command line changes (changes in the Makefile)..
Jul 26 2021, 4:18 PM
mibintc accepted D105951: [clang] P2266 implicit moves STL workaround.

I tested this patch downstream on Windows with Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29334 for x64

Jul 26 2021, 10:00 AM · Restricted Project

Jul 24 2021

mibintc accepted D106696: Suppress FP_CONTRACT due to planned command line changes (changes in the Makefile)..
Jul 24 2021, 5:15 AM
mibintc committed rG05ae3035554a: [clang][patch] Remove test artifact before running test for consistent results (authored by mibintc).
[clang][patch] Remove test artifact before running test for consistent results
Jul 24 2021, 4:56 AM

Jul 23 2021

mibintc added inline comments to D106696: Suppress FP_CONTRACT due to planned command line changes (changes in the Makefile)..
Jul 23 2021, 12:38 PM
mibintc accepted D106696: Suppress FP_CONTRACT due to planned command line changes (changes in the Makefile)..

LGTM - please see changes requested inline. thanks a lot

Jul 23 2021, 12:16 PM
mibintc added a comment to D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file.

Whoops, shouldn't mess with the mkdir line

Jul 23 2021, 6:46 AM · Restricted Project
mibintc added a comment to D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file.

@bnbarham
I think you mean a patch like this, is it right? I'd like to fix the test in a pre-commit and then re-push my patch

Jul 23 2021, 6:32 AM · Restricted Project

Jul 22 2021

mibintc added a comment to D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly.

@MaskRay I experience that the failing test clang/test/Index/preamble-reparse-changed-module.m is non-deterministic and currently I cannot reproduce the fail. I added details in D95159. Are you able to reproduce if you clean your build area? Do you have a suggestion for how I can solve this problem? Thanks a lot

Jul 22 2021, 1:53 PM · Restricted Project
mibintc updated subscribers of D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file.

More info about the test failure I'm seeing for clang/test/Index/preamble-reparse-changed-module.m

Jul 22 2021, 1:48 PM · Restricted Project
mibintc reopened D74436: Change clang option -ffp-model=precise to select ffp-contract=on.

I had to revert again, it's still failing on Intel buildbots. Cannot reproduce on Intel-internal Broadwell server.

Jul 22 2021, 6:45 AM · Restricted Project
mibintc added a reverting change for rGb9b696bba670: [clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp…: rG4296d633b08d: Revert "[clang][fpenv][patch] Change clang option -ffp-model=precise to select….
Jul 22 2021, 6:43 AM
mibintc committed rG4296d633b08d: Revert "[clang][fpenv][patch] Change clang option -ffp-model=precise to select… (authored by mibintc).
Revert "[clang][fpenv][patch] Change clang option -ffp-model=precise to select…
Jul 22 2021, 6:43 AM
mibintc added a reverting change for D74436: Change clang option -ffp-model=precise to select ffp-contract=on: rG4296d633b08d: Revert "[clang][fpenv][patch] Change clang option -ffp-model=precise to select….
Jul 22 2021, 6:43 AM · Restricted Project
mibintc committed rGb9b696bba670: [clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp… (authored by mibintc).
[clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp…
Jul 22 2021, 5:00 AM
mibintc closed D74436: Change clang option -ffp-model=precise to select ffp-contract=on.
Jul 22 2021, 5:00 AM · Restricted Project

Jul 21 2021

mibintc updated subscribers of D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file.

@aaron.ballman suggested I may have made a mistake adding the new option, I'll look there.

Jul 21 2021, 11:14 AM · Restricted Project
mibintc added a comment to D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file.

The newly added test case clang/test/Index/preamble-reparse-changed-module.m is failing on the patch that I'm trying to commit, https://reviews.llvm.org/D93769

Jul 21 2021, 10:10 AM · Restricted Project

Jul 20 2021

mibintc added a comment to D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly.

This breaks clang/test/Index/preamble-reparse-changed-module.m

Seems like a libclang crash (an assert failure) if you enable LLVM_ENABLE_ASSERTIONS=on.

You can reproduce with check-clang-index

Thanks for this, I'm building with assertions on now. This patch doesn't expand FLT_EVAL_METHOD in -E mode, I'm guessing that's why it fails. It can't expand the macro during -E because the context showing the value of the macro setting is only available in Sema. I haven't yet studied the test but do you know have an idea how I might be able to solve the problem?

Jul 20 2021, 2:12 PM · Restricted Project
mibintc reopened D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly.
Jul 20 2021, 1:43 PM · Restricted Project
mibintc added a reverting change for rGce8024e8ff76: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend…: rGd48ad358b1e8: Revert "[CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and….
Jul 20 2021, 1:42 PM
mibintc committed rGd48ad358b1e8: Revert "[CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and… (authored by mibintc).
Revert "[CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and…
Jul 20 2021, 1:42 PM
mibintc added a reverting change for D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly: rGd48ad358b1e8: Revert "[CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and….
Jul 20 2021, 1:42 PM · Restricted Project
mibintc added inline comments to D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly.
Jul 20 2021, 1:39 PM · Restricted Project
mibintc added a comment to D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly.

This breaks clang/test/Index/preamble-reparse-changed-module.m

http://45.33.8.238/linux/51638/step_7.txt

Jul 20 2021, 1:37 PM · Restricted Project
mibintc committed rGce8024e8ff76: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend… (authored by mibintc).
[CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend…
Jul 20 2021, 1:03 PM
mibintc closed D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly.
Jul 20 2021, 1:02 PM · Restricted Project
mibintc updated the diff for D102343: [clang][patch][FPEnv] Make Initialization of C++ globals strictfp aware.

Removed use of auto, and used different capitalization for local var name

Jul 20 2021, 12:06 PM · Restricted Project
mibintc added a comment to D102343: [clang][patch][FPEnv] Make Initialization of C++ globals strictfp aware.

Question for Aaron

Jul 20 2021, 11:55 AM · Restricted Project
mibintc updated the diff for D102343: [clang][patch][FPEnv] Make Initialization of C++ globals strictfp aware.

Partially respond to @aaron.ballman 's review by refactoring a change into a separate commit, but I'll push back on another request, I'll add that reply inline.

Jul 20 2021, 11:50 AM · Restricted Project
mibintc committed rGea864c993302: [clang][patch][NFC] Refactor calculation of FunctionDecl to avoid duplicate code (authored by mibintc).
[clang][patch][NFC] Refactor calculation of FunctionDecl to avoid duplicate code
Jul 20 2021, 8:02 AM

Jul 19 2021

mibintc accepted D105997: Implement _ExtInt conversion rules.

LGTM

Jul 19 2021, 12:10 PM · Restricted Project
mibintc updated the diff for D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly.

I've rebased and applied clang-format. I'd like to push this, looking for your +1, thank you!

Jul 19 2021, 11:15 AM · Restricted Project
mibintc added a reviewer for D104935: Update the Polybench tests to check relative error: zahiraam.
Jul 19 2021, 7:58 AM
mibintc added inline comments to D102343: [clang][patch][FPEnv] Make Initialization of C++ globals strictfp aware.
Jul 19 2021, 6:41 AM · Restricted Project
mibintc updated the diff for D102343: [clang][patch][FPEnv] Make Initialization of C++ globals strictfp aware.

Respond to @aaron.ballman 's review, rebased & used clang-format

Jul 19 2021, 6:38 AM · Restricted Project

Jul 15 2021

mibintc added a comment to D105951: [clang] P2266 implicit moves STL workaround.

Intel compiles VS2019 #include files regularly with clang, and the file <filesystem> compiled with -std:c++latest encounters this error report, which @aaron.ballman suggests is related to this effort.

Jul 15 2021, 10:06 AM · Restricted Project

Jun 30 2021

mibintc committed rGe773216f4636: [clang][patch] Add builtin __arithmetic_fence and option fprotect-parens (authored by mibintc).
[clang][patch] Add builtin __arithmetic_fence and option fprotect-parens
Jun 30 2021, 6:58 AM
mibintc closed D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens.
Jun 30 2021, 6:58 AM · Restricted Project, Restricted Project

Jun 29 2021

mibintc committed rGaaba37187fda: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc).
[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to…
Jun 29 2021, 10:27 AM
mibintc closed D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options.
Jun 29 2021, 10:27 AM · Restricted Project, Restricted Project

Jun 28 2021

mibintc reopened D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options.

More buildbot failures

Jun 28 2021, 12:48 PM · Restricted Project, Restricted Project
mibintc added a reverting change for rG2dbe1c675fe9: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to…: rG1d85d0879a75: Revert "[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass….
Jun 28 2021, 12:48 PM
mibintc committed rG1d85d0879a75: Revert "[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass… (authored by mibintc).
Revert "[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass…
Jun 28 2021, 12:48 PM
mibintc added a reverting change for D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options: rG1d85d0879a75: Revert "[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass….
Jun 28 2021, 12:48 PM · Restricted Project, Restricted Project
mibintc committed rG2dbe1c675fe9: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc).
[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to…
Jun 28 2021, 12:10 PM
mibintc closed D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options.
Jun 28 2021, 12:10 PM · Restricted Project, Restricted Project
mibintc reopened D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options.

buildbot fails in lldb, will submit updates

Jun 28 2021, 12:08 PM · Restricted Project, Restricted Project
mibintc reopened D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens.

buildbot fails on lldb need to update this patch

Jun 28 2021, 12:06 PM · Restricted Project, Restricted Project
mibintc added a reverting change for rG4f1238e44d80: [clang][patch][fpenv] Add builtin __arithmetic_fence and option fprotect-parens: rGc27e5a2a8e34: Revert "[clang][patch][fpenv] Add builtin __arithmetic_fence and option….
Jun 28 2021, 9:43 AM
mibintc committed rGc27e5a2a8e34: Revert "[clang][patch][fpenv] Add builtin __arithmetic_fence and option… (authored by mibintc).
Revert "[clang][patch][fpenv] Add builtin __arithmetic_fence and option…
Jun 28 2021, 9:43 AM
mibintc added a reverting change for rG2c02b0c3f454: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to…: rG8815ef823c80: Revert "[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass….
Jun 28 2021, 9:43 AM
mibintc added a reverting change for D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens: rGc27e5a2a8e34: Revert "[clang][patch][fpenv] Add builtin __arithmetic_fence and option….
Jun 28 2021, 9:43 AM · Restricted Project, Restricted Project
mibintc committed rG8815ef823c80: Revert "[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass… (authored by mibintc).
Revert "[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass…
Jun 28 2021, 9:43 AM
mibintc added a reverting change for D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options: rG8815ef823c80: Revert "[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass….
Jun 28 2021, 9:43 AM · Restricted Project, Restricted Project
mibintc committed rG4f1238e44d80: [clang][patch][fpenv] Add builtin __arithmetic_fence and option fprotect-parens (authored by mibintc).
[clang][patch][fpenv] Add builtin __arithmetic_fence and option fprotect-parens
Jun 28 2021, 9:27 AM
mibintc committed rG2c02b0c3f454: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc).
[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to…
Jun 28 2021, 9:27 AM
mibintc committed rG931e95687d6d: [llvm][clang][fpenv] Create new intrinsic llvm.arith.fence to control FP… (authored by mibintc).
[llvm][clang][fpenv] Create new intrinsic llvm.arith.fence to control FP…
Jun 28 2021, 9:27 AM
mibintc closed D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens.
Jun 28 2021, 9:27 AM · Restricted Project, Restricted Project
mibintc closed D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options.
Jun 28 2021, 9:27 AM · Restricted Project, Restricted Project
mibintc closed D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level.
Jun 28 2021, 9:27 AM · Restricted Project

Jun 24 2021

mibintc updated the diff for D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens.

Rebase

Jun 24 2021, 10:39 AM · Restricted Project, Restricted Project
mibintc updated the diff for D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level.

Rebasing. Hope this clears lit fails.

Jun 24 2021, 10:37 AM · Restricted Project

Jun 23 2021

mibintc added a comment to D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens.

some inline replies. I think this is all set now.

Jun 23 2021, 1:20 PM · Restricted Project, Restricted Project
mibintc updated the diff for D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens.

Respond to @aaron.ballman 's review

Jun 23 2021, 1:17 PM · Restricted Project, Restricted Project
mibintc added a comment to D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens.

A couple inline replies to go along with the updated patch

Jun 23 2021, 10:28 AM · Restricted Project, Restricted Project
mibintc updated the diff for D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens.

The patch I uploaded for review yesterday wasn't correct, not sure what happened. This one looks better.

Jun 23 2021, 10:07 AM · Restricted Project, Restricted Project

Jun 22 2021

mibintc requested review of D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options.
Jun 22 2021, 11:10 AM · Restricted Project, Restricted Project
mibintc updated the diff for D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens.

This patch addresses almost all the review comments, not yet sure about @aaron.ballman 's question about CoreOptions

Jun 22 2021, 11:07 AM · Restricted Project, Restricted Project

Jun 19 2021

mibintc reopened D74436: Change clang option -ffp-model=precise to select ffp-contract=on.
Jun 19 2021, 5:26 AM · Restricted Project
mibintc added a comment to D74436: Change clang option -ffp-model=precise to select ffp-contract=on.

I’ve been trying to commit this patch. However, when I commit, the tests fail some 21 floating point tests in LNT. Also there is both performance improvement as well as regression which shouldn’t happen because the sum total of my clang patch + my LNT patch should effectively be a no-op.

Jun 19 2021, 5:26 AM · Restricted Project
mibintc added a reverting change for rGa1449a10dbcf: [clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp…: rG9abaf5c359ca: Revert "[clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp….
Jun 19 2021, 5:02 AM
mibintc committed rG9abaf5c359ca: Revert "[clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp… (authored by mibintc).
Revert "[clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp…
Jun 19 2021, 5:02 AM
mibintc added a reverting change for D74436: Change clang option -ffp-model=precise to select ffp-contract=on: rG9abaf5c359ca: Revert "[clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp….
Jun 19 2021, 5:02 AM · Restricted Project
mibintc committed rGa1449a10dbcf: [clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp… (authored by mibintc).
[clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp…
Jun 19 2021, 3:50 AM

Jun 18 2021

mibintc added a comment to D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens.

Reply to @joerg proposing new wording for the option description

Jun 18 2021, 12:23 PM · Restricted Project, Restricted Project

Jun 16 2021

mibintc committed rT24550c3385e8: [test-suite] Suppress FP_CONTRACT due to command line changes planned in D74436 (authored by mibintc).
[test-suite] Suppress FP_CONTRACT due to command line changes planned in D74436
Jun 16 2021, 10:10 AM
mibintc closed D102861: Suppress FP_CONTRACT due to planned command line changes.
Jun 16 2021, 10:10 AM

Jun 15 2021

mibintc added a comment to D102861: Suppress FP_CONTRACT due to planned command line changes.

I can resurrect some Armv7/v8 machines at home and try

Turns out my boards are too old and need some love that I'm unable to give them.

Thanks for looking

If you can't find anyone that can help you, an alternative is to merge and lookout for breakages, and if you only see one of two, (revert and) liaise with the bot owners to fix them.

I plan to try pushing again when I have a block of time to babysit the bots. Is the place I should watch on Green Dragon? e.g. https://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-x86_64h-O3/
I can see there's aarch64 and x86 but what about other arch?

Jun 15 2021, 2:21 PM
mibintc updated the diff for D102861: Suppress FP_CONTRACT due to planned command line changes.

Fixed an initialization bug in 2mm.c

Jun 15 2021, 12:38 PM

Jun 14 2021

mibintc abandoned D87049: Exploratory patch - capture DebugInfo for constexpr variables used within lambda.
Jun 14 2021, 1:06 PM · Restricted Project
mibintc abandoned D104055: Override ffp-contract to fast due to command line changes planned in D74436.
Jun 14 2021, 1:04 PM · Restricted Project
mibintc updated the diff for D102861: Suppress FP_CONTRACT due to planned command line changes.

The previous revision had a compilation error in 2mm.c I've corrected that.

Jun 14 2021, 10:59 AM