Page MenuHomePhabricator
Feed Advanced Search

Mar 10 2021

ppenzin accepted D98322: [llvm] Fix thinko in getVendorSignature(), where expected values of ECX and EDX were flipped for the AMD case..

Looks good in general, with one minor nit (inline).

Mar 10 2021, 6:18 PM · Restricted Project

Mar 9 2021

ppenzin reopened D97504: [llvm-exegesis] Disable the LBR check on AMD.

Apologies if this is not the right channel to raise issues with the patch.

Mar 9 2021, 10:30 PM · Restricted Project

Oct 28 2019

ppenzin awarded D61953: [OpenMP][IRBuilder][WIP] Prototype OpenMPIRBuilder a Like token.
Oct 28 2019, 2:40 PM · Restricted Project

Oct 16 2017

ppenzin added a comment to D37415: Add gtest include directories before system include directories on FreeBSD and DragonFlyBSD.

Thank you! Since I am new here, what should I do with the bug: https://bugs.llvm.org/show_bug.cgi?id=30877

Oct 16 2017, 8:08 PM

Sep 30 2017

ppenzin added a comment to D37415: Add gtest include directories before system include directories on FreeBSD and DragonFlyBSD.

I don't have commit privileges, I would need someone to commit this for me. Should I update the commit message with the reference to the review?

Sep 30 2017, 11:57 PM

Sep 26 2017

ppenzin updated the diff for D37415: Add gtest include directories before system include directories on FreeBSD and DragonFlyBSD.

To make sure that include directories in the tree override /usr/local/include on FreeBSD, we need to mark the latter as "system".

Sep 26 2017, 7:10 PM
ppenzin added a comment to D37415: Add gtest include directories before system include directories on FreeBSD and DragonFlyBSD.

Adding BEFORE unconditionally would work, I thought about that, but decided to be conservative. Turns out there is another way to fix include directories - by adding SYSTEM to the call to include_directories in main CMakeLists.txt. I think it can be a cleaner solution, I will look into that as well.

Sep 26 2017, 3:29 PM

Sep 25 2017

ppenzin added a comment to D37415: Add gtest include directories before system include directories on FreeBSD and DragonFlyBSD.

It is a FreeBSD-ism: non-system libraries and their headers go into /usr/local, which is not on default search paths. But there might be a more elegant way to do it, I will take a look.

Sep 25 2017, 1:49 PM
ppenzin added a comment to D37415: Add gtest include directories before system include directories on FreeBSD and DragonFlyBSD.

Main CMakeLists.txt invokes include_directories, which is necessary on FreeBSD:

Sep 25 2017, 1:22 PM

Sep 2 2017

ppenzin created D37415: Add gtest include directories before system include directories on FreeBSD and DragonFlyBSD.
Sep 2 2017, 5:35 PM