Looks good in general, with one minor nit (inline).
Mar 10 2021
Mar 9 2021
Apologies if this is not the right channel to raise issues with the patch.
Oct 28 2019
Oct 16 2017
Thank you! Since I am new here, what should I do with the bug: https://bugs.llvm.org/show_bug.cgi?id=30877
Sep 30 2017
I don't have commit privileges, I would need someone to commit this for me. Should I update the commit message with the reference to the review?
Sep 26 2017
To make sure that include directories in the tree override /usr/local/include on FreeBSD, we need to mark the latter as "system".
Adding BEFORE unconditionally would work, I thought about that, but decided to be conservative. Turns out there is another way to fix include directories - by adding SYSTEM to the call to include_directories in main CMakeLists.txt. I think it can be a cleaner solution, I will look into that as well.
Sep 25 2017
It is a FreeBSD-ism: non-system libraries and their headers go into /usr/local, which is not on default search paths. But there might be a more elegant way to do it, I will take a look.
Main CMakeLists.txt invokes include_directories, which is necessary on FreeBSD: