Page MenuHomePhabricator
Feed Advanced Search

Fri, Jul 23

vchuravy added a project to D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location: Restricted Project.
Fri, Jul 23, 2:53 AM · Restricted Project, Restricted Project

Sun, Jul 18

vchuravy added a reverting change for rGa56fe117e04f: Revert "[Orc] Add verylazy example for C-bindings": rG3321f4821e09: Reland [Orc] Add verylazy example for C-bindings.
Sun, Jul 18, 12:18 PM
vchuravy committed rG3321f4821e09: Reland [Orc] Add verylazy example for C-bindings (authored by vchuravy).
Reland [Orc] Add verylazy example for C-bindings
Sun, Jul 18, 12:18 PM
vchuravy added a reverting change for rGb5a6ad8c893a: [Orc] Add verylazy example for C-bindings: rGa56fe117e04f: Revert "[Orc] Add verylazy example for C-bindings".
Sun, Jul 18, 7:22 AM
vchuravy committed rGa56fe117e04f: Revert "[Orc] Add verylazy example for C-bindings" (authored by vchuravy).
Revert "[Orc] Add verylazy example for C-bindings"
Sun, Jul 18, 7:22 AM
vchuravy added a reverting change for D104799: [Orc] Add verylazy example for C-bindings: rGa56fe117e04f: Revert "[Orc] Add verylazy example for C-bindings".
Sun, Jul 18, 7:22 AM · Restricted Project
vchuravy committed rGb5a6ad8c893a: [Orc] Add verylazy example for C-bindings (authored by vchuravy).
[Orc] Add verylazy example for C-bindings
Sun, Jul 18, 3:07 AM
vchuravy closed D104799: [Orc] Add verylazy example for C-bindings.
Sun, Jul 18, 3:07 AM · Restricted Project
vchuravy committed rG0c164ea9e687: [MLIR][CAPI] On MINGW don't link against libMLIR (authored by vchuravy).
[MLIR][CAPI] On MINGW don't link against libMLIR
Sun, Jul 18, 3:06 AM
vchuravy closed D106169: [MLIR][CAPI] On MINGW don't link against libMLIR.
Sun, Jul 18, 3:06 AM · Restricted Project

Sat, Jul 17

vchuravy updated subscribers of D106206: Remove the NotUnderValgrind caching flag.

@loladiro does this impact us? Julia does support running under valgrind, see https://docs.julialang.org/en/v1/devdocs/valgrind/,
and IIRC that extends to JIT'ed code.

Sat, Jul 17, 5:50 AM · Restricted Project, Restricted Project
vchuravy added a project to D106206: Remove the NotUnderValgrind caching flag: Restricted Project.
Sat, Jul 17, 5:47 AM · Restricted Project, Restricted Project

Fri, Jul 16

vchuravy added a reviewer for D106169: [MLIR][CAPI] On MINGW don't link against libMLIR: stephenneuendorffer.
Fri, Jul 16, 11:09 AM · Restricted Project
vchuravy added a reviewer for D106169: [MLIR][CAPI] On MINGW don't link against libMLIR: stellaraccident.
Fri, Jul 16, 11:09 AM · Restricted Project
vchuravy requested review of D106169: [MLIR][CAPI] On MINGW don't link against libMLIR.
Fri, Jul 16, 11:08 AM · Restricted Project

Thu, Jul 15

vchuravy abandoned D73156: [clang] Build clang-shlib on mingw.
Thu, Jul 15, 11:46 AM · Restricted Project
vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Update test for adding dependencies and clang-format

Thu, Jul 15, 8:49 AM · Restricted Project

Mon, Jul 12

vchuravy added inline comments to D104799: [Orc] Add verylazy example for C-bindings.
Mon, Jul 12, 8:34 AM · Restricted Project
vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Update unittests

Mon, Jul 12, 8:32 AM · Restricted Project
vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Update docs

Mon, Jul 12, 4:49 AM · Restricted Project
vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Apply changes from lhames

Mon, Jul 12, 4:16 AM · Restricted Project

Sun, Jul 11

vchuravy added a comment to D104799: [Orc] Add verylazy example for C-bindings.

Regarding the MaterializationResponsibility API: it would be good to add the addDependencies and addDependenciesForAll methods. These declare dependencies for each materializing symbol so that ORC can track them in its dependence graph, which in turn ensures that lookups remain safe regardless of what threads the symbols are being materialized on. These methods are an essential part of the MaterializationResponsibility API.

Sun, Jul 11, 1:11 PM · Restricted Project
vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Address part of the review

Sun, Jul 11, 1:01 PM · Restricted Project

Fri, Jul 2

vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

add first draft of docs and unit test for MaterializationResponisibility

Fri, Jul 2, 10:49 AM · Restricted Project

Thu, Jul 1

vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

clang-format and rebase

Thu, Jul 1, 12:58 PM · Restricted Project
vchuravy committed rG45e8a0befbc8: [Orc] At CBindings for LazyRexports (authored by vchuravy).
[Orc] At CBindings for LazyRexports
Thu, Jul 1, 12:52 PM
vchuravy closed D104672: [Orc] At CBindings for LazyRexports.
Thu, Jul 1, 12:52 PM · Restricted Project
vchuravy updated the diff for D104672: [Orc] At CBindings for LazyRexports.

Add comment and clang-format

Thu, Jul 1, 8:35 AM · Restricted Project
vchuravy added a comment to D104672: [Orc] At CBindings for LazyRexports.

address review

Thu, Jul 1, 8:20 AM · Restricted Project
vchuravy updated the diff for D104672: [Orc] At CBindings for LazyRexports.

Address review comments

Thu, Jul 1, 8:20 AM · Restricted Project

Wed, Jun 30

vchuravy committed rG9762f12c6c60: [Orc] Run the examples as part of the tests (authored by vchuravy).
[Orc] Run the examples as part of the tests
Wed, Jun 30, 12:45 PM
vchuravy closed D104637: [Orc] Run the examples as part of the tests.
Wed, Jun 30, 12:45 PM · Restricted Project
vchuravy committed rG69e0f790e032: [Orc] Fix name of LLVMOrcIRTransformLayerSetTransform (authored by vchuravy).
[Orc] Fix name of LLVMOrcIRTransformLayerSetTransform
Wed, Jun 30, 12:44 PM
vchuravy closed D104840: [Orc] Fix name of LLVMOrcIRTransformLayerSetTransform.
Wed, Jun 30, 12:44 PM · Restricted Project

Sun, Jun 27

vchuravy added a project to D103052: Do not patch FDE symbols in RuntimeDyld, on targets that use non-absolute symbol relocations in `.eh_frame`: Restricted Project.
Sun, Jun 27, 12:42 AM · Restricted Project, Restricted Project

Sat, Jun 26

vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Create separate MaterializationUnit's

Sat, Jun 26, 7:27 AM · Restricted Project

Fri, Jun 25

vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Use MaterializationResponsibility::replace

Fri, Jun 25, 12:14 PM · Restricted Project

Jun 23 2021

vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Use IRLayer::emit instead of LLJIT::add

Jun 23 2021, 11:45 PM · Restricted Project
vchuravy requested review of D104840: [Orc] Fix name of LLVMOrcIRTransformLayerSetTransform.
Jun 23 2021, 10:51 PM · Restricted Project
vchuravy added a comment to D104799: [Orc] Add verylazy example for C-bindings.

@lhames this currently fails with

Jun 23 2021, 10:54 AM · Restricted Project
vchuravy requested review of D104799: [Orc] Add verylazy example for C-bindings.
Jun 23 2021, 10:52 AM · Restricted Project

Jun 21 2021

vchuravy requested review of D104672: [Orc] At CBindings for LazyRexports.
Jun 21 2021, 2:26 PM · Restricted Project
vchuravy requested review of D104637: [Orc] Run the examples as part of the tests.
Jun 21 2021, 5:39 AM · Restricted Project

Jun 17 2021

vchuravy added a project to D104480: [Orc] add C-API for transform layer: Restricted Project.
Jun 17 2021, 11:56 AM · Restricted Project, Restricted Project
vchuravy requested review of D104480: [Orc] add C-API for transform layer.
Jun 17 2021, 11:55 AM · Restricted Project, Restricted Project

May 14 2021

vchuravy updated subscribers of D102471: New tag for ittapi - fix an error related to cross-compiling ITTAPI in LLVM with mingw.
May 14 2021, 9:07 AM · Restricted Project

May 10 2021

vchuravy added inline comments to D102097: [CompilerRT] Sanitizer compilation on musl systems.
May 10 2021, 10:06 AM · Restricted Project

May 7 2021

vchuravy added inline comments to D102097: [CompilerRT] Sanitizer compilation on musl systems.
May 7 2021, 5:29 PM · Restricted Project
vchuravy updated subscribers of D102097: [CompilerRT] Sanitizer compilation on musl systems.
May 7 2021, 5:28 PM · Restricted Project
vchuravy requested review of D102097: [CompilerRT] Sanitizer compilation on musl systems.
May 7 2021, 5:23 PM · Restricted Project

Feb 16 2021

vchuravy added a project to D96283: [DAGCombine] Do not remove masking argument to FP16_TO_FP for some targets: Restricted Project.
Feb 16 2021, 7:27 PM · Restricted Project, Restricted Project

Jan 19 2021

vchuravy accepted D94980: [PowerPC] Do not emit HW loop with half precision operations.

That does seem to indeed fix all the remaining issues with Float16 that the Julia testsuite covers :)

Jan 19 2021, 7:20 PM · Restricted Project
vchuravy abandoned D94828: [PowerPC] Disable CTR loops containing floating point conversion on half-precision.

Abandoned in favour of D94980

Jan 19 2021, 7:19 PM · Restricted Project, Restricted Project

Jan 15 2021

vchuravy added reviewers for D94813: [MergeICmps] Don't merge icmps derived from pointers with addressspaces: courbet, MaskRay, jyknight.
Jan 15 2021, 9:37 PM · Restricted Project
vchuravy added a reviewer for D94828: [PowerPC] Disable CTR loops containing floating point conversion on half-precision: Restricted Project.
Jan 15 2021, 2:32 PM · Restricted Project, Restricted Project
vchuravy requested review of D94828: [PowerPC] Disable CTR loops containing floating point conversion on half-precision.
Jan 15 2021, 2:32 PM · Restricted Project, Restricted Project
vchuravy retitled D94813: [MergeICmps] Don't merge icmps derived from pointers with addressspaces from [MergeICmps] Don't merge icmps derived frm pointers with addressspaces to [MergeICmps] Don't merge icmps derived from pointers with addressspaces.
Jan 15 2021, 2:27 PM · Restricted Project
vchuravy accepted D94058: [PowerPC] Sign extend comparison operand for signed atomic comparisons.

Good to go from the Julia side.

Jan 15 2021, 11:26 AM · Restricted Project
vchuravy added a reviewer for D94813: [MergeICmps] Don't merge icmps derived from pointers with addressspaces: Restricted Project.
Jan 15 2021, 11:12 AM · Restricted Project
vchuravy requested review of D94813: [MergeICmps] Don't merge icmps derived from pointers with addressspaces.
Jan 15 2021, 11:12 AM · Restricted Project

Jan 5 2021

vchuravy updated subscribers of D94058: [PowerPC] Sign extend comparison operand for signed atomic comparisons.
Jan 5 2021, 7:57 AM · Restricted Project

Dec 16 2020

vchuravy added a comment to D92906: [PowerPC] Restore stack ptr from frame ptr with setjmp.

This fixed a whole set of bugs for us but it also seems to have caused a regression.
https://github.com/JuliaLang/julia/issues/38859

Dec 16 2020, 5:30 PM · Restricted Project

Dec 9 2020

vchuravy accepted D92906: [PowerPC] Restore stack ptr from frame ptr with setjmp.

Looks good from the Julia side, this does indeed fix the upstream bug. Thanks @nemanjai!

Dec 9 2020, 10:35 AM · Restricted Project
vchuravy updated subscribers of D92906: [PowerPC] Restore stack ptr from frame ptr with setjmp.
Dec 9 2020, 5:00 AM · Restricted Project

Dec 7 2020

vchuravy updated the diff for D75072: [SCEV] Record NI types in add exprs.

Rebase commit onto main

Dec 7 2020, 6:04 PM · Restricted Project, Restricted Project
vchuravy commandeered D75072: [SCEV] Record NI types in add exprs.
Dec 7 2020, 5:38 PM · Restricted Project, Restricted Project
vchuravy added a comment to D50010: [VNCoercion] Disallow coercion between different ni addrspaces.

Thanks! I rebased the PR and landed it.

Dec 7 2020, 5:21 PM · Restricted Project, Restricted Project
vchuravy committed rG700cf7dcc927: [VNCoercion] Disallow coercion between different ni addrspaces (authored by vchuravy).
[VNCoercion] Disallow coercion between different ni addrspaces
Dec 7 2020, 5:20 PM
vchuravy closed D50010: [VNCoercion] Disallow coercion between different ni addrspaces.
Dec 7 2020, 5:20 PM · Restricted Project, Restricted Project

Dec 6 2020

vchuravy added a comment to D50010: [VNCoercion] Disallow coercion between different ni addrspaces.

Bump for review. We (Julia) have been carrying this one for a while.

Dec 6 2020, 10:58 AM · Restricted Project, Restricted Project

Nov 27 2020

vchuravy updated subscribers of D86837: Allow specifying AA info when constructing certain libcalls.
Nov 27 2020, 5:13 PM · Restricted Project

Nov 23 2020

vchuravy added a comment to D75072: [SCEV] Record NI types in add exprs.

@reames I think you are the right person to review this. Any objections?
We have been carrying this on the Julia side. I can rebase this on master if that would help (LLVM 11 version is available here https://github.com/JuliaLang/julia/blob/master/deps/patches/llvm-11-D75072-SCEV-add-type.patch)

Nov 23 2020, 5:41 PM · Restricted Project, Restricted Project
vchuravy added a reviewer for D73156: [clang] Build clang-shlib on mingw: mstorsjo.
Nov 23 2020, 5:17 PM · Restricted Project
vchuravy added a comment to D88630: [clang/CMake] Respect LLVM_TOOLS_INSTALL_DIR.

Well, I've tested it and it doesn't seem to break anything for us (Gentoo) but I don't really understand why you'd have a different install dir for LLVM and Clang.

Nov 23 2020, 5:12 PM · Restricted Project
vchuravy committed rG4bc88a0e9a2e: Enable support for floating-point division reductions (authored by yuyichao).
Enable support for floating-point division reductions
Nov 23 2020, 5:06 PM
vchuravy closed D34078: Enable support for floating-point division reductions.
Nov 23 2020, 5:06 PM · Restricted Project, Restricted Project
vchuravy abandoned D89211: [RTDYLD] add debug statements for resolveX86Relocation.
Nov 23 2020, 4:06 PM · Restricted Project

Nov 6 2020

vchuravy abandoned D44650: Fix build of llvm-cfi-verify on mingw32.

In favor of https://reviews.llvm.org/D90969

Nov 6 2020, 1:53 PM · Restricted Project, Restricted Project

Nov 3 2020

vchuravy accepted D90722: [RTDYLD] support absolute relocations where needed.

Looks good from my side. @lhames should sign off though.

Nov 3 2020, 3:01 PM · Restricted Project
vchuravy abandoned D89241: [RTDYLD] be more defensive about relocations with empty symbol names.
Nov 3 2020, 2:51 PM · Restricted Project

Oct 19 2020

vchuravy added a comment to rGc068e9c8c123: [Support][CommandLine] Delete unused llvm::cl::ParseEnvrironmentOptions.

It is questionable for a downstream project to parse and interpret LLVM internal options directly. It should at least to have a -mllvm or --plugin-opt= prefix.

Oct 19 2020, 6:33 AM

Oct 18 2020

vchuravy added a comment to rGc068e9c8c123: [Support][CommandLine] Delete unused llvm::cl::ParseEnvrironmentOptions.

Yeah, I basically copy-and-pasted the original implementation, since we are indeed parsing this from the environment. https://github.com/JuliaLang/julia/pull/38092/commits/72c2136dfad7a535dba563c0f37f3c70da5558a2

Oct 18 2020, 10:05 PM
vchuravy added a comment to rGc068e9c8c123: [Support][CommandLine] Delete unused llvm::cl::ParseEnvrironmentOptions.

@MaskRay why was it necessary to delete this? It is used by downstream projects (like Julia). I agree that it isn't too much hassle to implement, but every tool that uses LLVM as a library will have to write a version themselves.

Oct 18 2020, 6:52 PM

Oct 12 2020

vchuravy updated the diff for D89241: [RTDYLD] be more defensive about relocations with empty symbol names.

clang-format

Oct 12 2020, 7:58 AM · Restricted Project
vchuravy requested review of D89241: [RTDYLD] be more defensive about relocations with empty symbol names.
Oct 12 2020, 7:55 AM · Restricted Project
vchuravy added a comment to D89211: [RTDYLD] add debug statements for resolveX86Relocation.

I think this can be very noisy as the number of relocations can be very large.

Oct 12 2020, 7:00 AM · Restricted Project

Oct 11 2020

vchuravy updated the diff for D89211: [RTDYLD] add debug statements for resolveX86Relocation.

Fix typo

Oct 11 2020, 11:23 AM · Restricted Project
vchuravy requested review of D89211: [RTDYLD] add debug statements for resolveX86Relocation.
Oct 11 2020, 11:21 AM · Restricted Project

Oct 8 2020

vchuravy accepted D88846: [mlir] Improve LLVM shlib support.
Oct 8 2020, 11:52 AM · Restricted Project

Jul 27 2020

vchuravy abandoned D66035: [WebAssembly] WIP: Add support for reference types.

I am interested in continuing this work and have a patch in progress based on the current available one here. Should I post the new patch here or under a new bug?

Jul 27 2020, 7:30 AM · Restricted Project, Restricted Project

Jul 17 2020

vchuravy updated subscribers of D84031: Clear NewGEPBases after finish using them in CodeGenPrep pass.
Jul 17 2020, 8:54 AM · Restricted Project

Jul 14 2020

vchuravy added a reviewer for D83800: Support PC relative relocation on AArch64 and PPC64 in RelocationResolver: nemanjai.
Jul 14 2020, 11:50 AM · Restricted Project

May 4 2020

vchuravy abandoned D78771: Add dependency edges between generated headers and users.

Abandoned in favour of @stephenneuendorffer recent list of changes.

May 4 2020, 6:54 AM · Restricted Project, Restricted Project
vchuravy accepted D79067: [MLIR] Fix libMLIR.so and LLVM_LINK_LLVM_DYLIB.
May 4 2020, 6:54 AM · Restricted Project
vchuravy accepted D79241: [cmake] Ensure that LINK_LIBS are dependencies for object library targets.
May 4 2020, 6:54 AM · Restricted Project

Apr 29 2020

vchuravy added a comment to D78773: Adjust libMLIR building to more closely follow libClang.

@vchuravy, What's your plan with this patch? I think this should land and I've started building on top of it.

Apr 29 2020, 7:29 PM · Restricted Project, Restricted Project
vchuravy added a comment to D44485: [MC] Always emit relocations for same-section function references.

Right the issue for is that LLVM6 used to accept and compile it without issue:

Apr 29 2020, 4:46 PM · Restricted Project
Herald added a reviewer for D73702: [WIP][mlir] enable conversion materialization for 1-1 type conversions: herhut.
Apr 29 2020, 6:56 AM · Restricted Project

Apr 24 2020

vchuravy added a comment to D78773: Adjust libMLIR building to more closely follow libClang.

Does this get us closer to fixing LLVM_LINK_LLVM_DYLIB?

Apr 24 2020, 10:49 AM · Restricted Project, Restricted Project
vchuravy added a comment to D78771: Add dependency edges between generated headers and users.

Ultimately, the solution may be to just generate all the headers before building everything else, which means that all mlir libraries would have a dependence on all IncGen targets. That isn't great, but I think it's better than the fix proposed in this review.

Apr 24 2020, 10:48 AM · Restricted Project, Restricted Project