Page MenuHomePhabricator
Feed Advanced Search

Tue, Oct 29

ributzka committed rGf5246fe96dcd: Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift (authored by ributzka).
Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift
Tue, Oct 29, 3:13 PM
ributzka committed rG3fa85d5359df: Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift (authored by ributzka).
Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift
Tue, Oct 29, 2:31 PM

Oct 7 2019

ributzka accepted D67529: [TextAPI] Introduce TBDv4.

Thanks Cyndy. LGTM

Oct 7 2019, 11:17 AM · Restricted Project
ributzka added a comment to D67646: [TextAPI] Add Multiple Document Support to TBDv3.

Does nm print now all symbols - including the inlined ones? That would be an unexpected change, because we don't do the same for MachOs that have re-exported frameworks. I think this feature should be guarded by an option.

Oct 7 2019, 9:58 AM · Restricted Project
ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Oct 7 2019, 9:55 AM · Restricted Project

Sep 27 2019

ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Sep 27 2019, 9:29 AM · Restricted Project

Sep 24 2019

ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Sep 24 2019, 10:31 AM · Restricted Project

Sep 23 2019

ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Sep 23 2019, 12:28 PM · Restricted Project

Sep 18 2019

ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Sep 18 2019, 11:30 AM · Restricted Project

Sep 13 2019

ributzka added a comment to D67249: [Modules][PCH] Hash input files content.

xxhash64 is apparently faster than MD5 and SHA1, and produces good quality hashes. I am not sure about the hash quality of hash_code for this purpose.

Sep 13 2019, 3:35 PM · Restricted Project
ributzka accepted D67527: [TextAPI] Arch&Platform to Target.

LGTM

Sep 13 2019, 10:33 AM · Restricted Project
ributzka accepted D67528: [TextAPI] Add New Supported Platforms.

LGTM

Sep 13 2019, 9:26 AM · Restricted Project
ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Sep 13 2019, 9:15 AM · Restricted Project

Sep 12 2019

ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Sep 12 2019, 5:00 PM · Restricted Project

Sep 11 2019

ributzka added a comment to D67249: [Modules][PCH] Hash input files content.

Did you try xxHash64?

Sep 11 2019, 4:17 PM · Restricted Project

Sep 10 2019

ributzka accepted D66160: [llvm-nm] Add tapi file support.

LGTM

Sep 10 2019, 3:06 PM · Restricted Project
ributzka added a comment to D66160: [llvm-nm] Add tapi file support.

The motivation to add this to llvm-nm, is to get the same functionally back that we lost with adding TBD files. Using it for testing is a nice side benefit.

Sep 10 2019, 9:30 AM · Restricted Project

Sep 9 2019

ributzka added a reviewer for D67249: [Modules][PCH] Hash input files content: ributzka.
Sep 9 2019, 2:56 PM · Restricted Project

Sep 6 2019

ributzka added inline comments to D67249: [Modules][PCH] Hash input files content.
Sep 6 2019, 3:42 PM · Restricted Project
ributzka added inline comments to D66160: [llvm-nm] Add tapi file support.
Sep 6 2019, 10:51 AM · Restricted Project

Sep 5 2019

ributzka accepted D67204: [TextAPI] update interface file for filtered iter.

LGTM

Sep 5 2019, 10:06 AM · Restricted Project

Sep 3 2019

ributzka committed rL370783: Request commit access for ributzka.
Request commit access for ributzka
Sep 3 2019, 10:01 AM