Page MenuHomePhabricator
Feed Advanced Search

Mar 10 2017

ributzka closed D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator. by committing rL297510: [VFS] Ignore broken symlinks in the directory iterator..
Mar 10 2017, 1:35 PM
ributzka updated the diff for D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator..

Remove the EC check completely.

Mar 10 2017, 10:01 AM

Mar 9 2017

ributzka added inline comments to D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator..
Mar 9 2017, 4:40 PM
ributzka added inline comments to D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator..
Mar 9 2017, 2:28 PM

Mar 8 2017

ributzka created D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator..
Mar 8 2017, 5:19 PM

Nov 8 2016

ributzka added a comment to rL286290: [asan/win] Add init hooks to .CRT$XLAB.

This is failing the SanitizerLintCheck. See http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/9576/consoleFull#-15796076f80f5c9c-2aaa-47fb-b15d-be39b7128d72.

Nov 8 2016, 2:57 PM

Oct 28 2016

ributzka added a comment to rL285381: Revert "[DAGCombiner] Add vector demanded elements support to computeKnownBits".

Hi Simon,

Oct 28 2016, 4:46 PM
ributzka added a comment to rL285381: Revert "[DAGCombiner] Add vector demanded elements support to computeKnownBits".

Hi Simon,

Oct 28 2016, 3:45 PM

Oct 27 2016

ributzka committed rL285381: Revert "[DAGCombiner] Add vector demanded elements support to computeKnownBits".
Revert "[DAGCombiner] Add vector demanded elements support to computeKnownBits"
Oct 27 2016, 9:10 PM

Aug 31 2016

ributzka added a comment to D23487: [Stackmap] Added callsite counts to emitted function information..

I'm in favor of the latter too (though I'm interested in what
@ributzka thinks). I'd suggest sending a mail to llvm-dev stating
that you're bumping the stackmap version in a backward incompatible
manner and see if anyone objects.

FWIW, I don't think this should be a problem for us.

Aug 31 2016, 10:48 AM

Aug 22 2016

ributzka added a comment to D23487: [Stackmap] Added callsite counts to emitted function information..

If we have to rev the version, which we have to in this case, then I would prefer to have the useful fixes from D13110 in there too. Otherwise this change just feels like a hack on the existing format without addressing any of the other issues.

Aug 22 2016, 10:36 AM
ributzka added a comment to D23487: [Stackmap] Added callsite counts to emitted function information..

What about reviving the patch in https://reviews.llvm.org/D13110. Wouldn't that solve your problem too?

Aug 22 2016, 9:54 AM

Jul 13 2016

ributzka accepted D21183: Better selection of common base address in constant hoisting.

LGTM

Jul 13 2016, 9:37 AM

Jun 10 2016

ributzka added a comment to D21183: Better selection of common base address in constant hoisting.

Mhh. The fact that AArch64 doesn't even implement the TTI hook and shows different behavior is not great - especially since it seems to have increased code size.

Jun 10 2016, 11:01 AM

Jun 9 2016

ributzka added a comment to D21183: Better selection of common base address in constant hoisting.

Looks like a nice improvement to ConstantHoisting, but I am a little worried about the limited scope and implementation for load optimization only.

Jun 9 2016, 11:07 AM

Nov 13 2015

ributzka committed rL253060: Fix auto-link for text-based dynamic library SDKs..
Fix auto-link for text-based dynamic library SDKs.
Nov 13 2015, 11:10 AM

Nov 4 2015

ributzka committed rL252076: Revert "Reapply: [asan] On OS X, log reports to syslog and os_trace".
Revert "Reapply: [asan] On OS X, log reports to syslog and os_trace"
Nov 4 2015, 1:05 PM

Aug 24 2015

ributzka accepted D12263: Fix LLVM C API for DataLayout.

LGTM

Aug 24 2015, 3:19 PM

Aug 19 2015

ributzka committed rL245499: [AArch64][FastISel] Don't fold shifts with UB..
[AArch64][FastISel] Don't fold shifts with UB.
Aug 19 2015, 1:53 PM

Aug 10 2015

ributzka accepted D11853: StackMap: FastISel: Add an appropriate number of immediate operands to the frame setup instruction..

Could you also add a test for PPC?

Aug 10 2015, 9:22 AM

Aug 6 2015

ributzka committed rL244291: [AArch64][FastISel] Always use AND before checking the branch flag..
[AArch64][FastISel] Always use AND before checking the branch flag.
Aug 6 2015, 3:45 PM
ributzka committed rL244287: Revert "[AArch64][FastISel] Add more truncation tests." and "[AArch64]….
Revert "[AArch64][FastISel] Add more truncation tests." and "[AArch64]…
Aug 6 2015, 3:14 PM
ributzka added a reverting change for rL243304: [AArch64][FastISel] Add more truncation tests.: rL244287: Revert "[AArch64][FastISel] Add more truncation tests." and "[AArch64]….
Aug 6 2015, 3:14 PM

Jul 27 2015

ributzka committed rL243304: [AArch64][FastISel] Add more truncation tests..
[AArch64][FastISel] Add more truncation tests.
Jul 27 2015, 12:01 PM

Jul 24 2015

ributzka committed rL243198: [AArch64][FastISel] Always use an AND instruction when truncating to non….
[AArch64][FastISel] Always use an AND instruction when truncating to non…
Jul 24 2015, 7:17 PM

Jul 9 2015

ributzka committed rL241823: [StackMap] Use lambdas to specify the sort and erase conditions. NFC..
[StackMap] Use lambdas to specify the sort and erase conditions. NFC.
Jul 9 2015, 10:11 AM
ributzka committed rL241822: [StackMap] Rename variables to be more consistent. NFC..
[StackMap] Rename variables to be more consistent. NFC.
Jul 9 2015, 10:11 AM
ributzka committed rL241821: [StackMaps] Use emplace_back when possible. NFC..
[StackMaps] Use emplace_back when possible. NFC.
Jul 9 2015, 10:11 AM

Jul 8 2015

ributzka committed rL241754: Run clang-format before making changes to StackMaps. NFC..
Run clang-format before making changes to StackMaps. NFC.
Jul 8 2015, 3:42 PM

Jul 6 2015

ributzka committed rL241536: [StackMap Liveness] Calling the base class' getAnalysisUsage method. NFCI..
[StackMap Liveness] Calling the base class' getAnalysisUsage method. NFCI.
Jul 6 2015, 7:05 PM
ributzka committed rL241535: [StackMap Liveness] No need to cache the MachineFunction. NFC..
[StackMap Liveness] No need to cache the MachineFunction. NFC.
Jul 6 2015, 7:05 PM

Jun 12 2015

ributzka updated subscribers of D10377: Add parser for the stackmap section format.
Jun 12 2015, 8:22 AM

Jun 11 2015

ributzka committed rL239568: [Stackmaps][X86] Remove EFLAGS and IP registers from the live-out mask..
[Stackmaps][X86] Remove EFLAGS and IP registers from the live-out mask.
Jun 11 2015, 3:44 PM

Jun 5 2015

ributzka updated subscribers of D9474: [X86][SSE] Vectorized i8 and i16 shift operators.
Jun 5 2015, 11:07 AM

Apr 9 2015

ributzka committed rL234529: [AArch64][FastISel] Fix integer extend optimization..
[AArch64][FastISel] Fix integer extend optimization.
Apr 9 2015, 1:04 PM

Mar 30 2015

ributzka committed rL233635: Transfer implicit operands when expanding the RET_ReallyLR pseudo instruction..
Transfer implicit operands when expanding the RET_ReallyLR pseudo instruction.
Mar 30 2015, 4:05 PM

Mar 11 2015

ributzka committed rL231945: Add the "vbroadcasti128" instruction back..
Add the "vbroadcasti128" instruction back.
Mar 11 2015, 10:31 AM
ributzka accepted D8258: Emit StackMap section on AArch64 target.

LGTM

Mar 11 2015, 9:10 AM

Mar 3 2015

ributzka committed rL231182: Remove 'llvm.x86.avx2.vbroadcasti128' intrinsic..
Remove 'llvm.x86.avx2.vbroadcasti128' intrinsic.
Mar 3 2015, 4:15 PM
ributzka committed rL231081: Lower _mm256_broadcastsi128_si256 directly to a vector shuffle..
Lower _mm256_broadcastsi128_si256 directly to a vector shuffle.
Mar 3 2015, 9:25 AM

Mar 2 2015

ributzka committed rL230988: Restore LLVMLinkModules C API until it is properly deprecated..
Restore LLVMLinkModules C API until it is properly deprecated.
Mar 2 2015, 11:02 AM

Feb 17 2015

ributzka added inline comments to D7698: [X86][FastIsel] Teach how to select scalar integer to float/double conversions..
Feb 17 2015, 10:40 AM

Feb 4 2015

ributzka committed rL228172: Revert "[ASan] Add the new __asan_mz_* symbols to asan_interface_internal.h".
Revert "[ASan] Add the new __asan_mz_* symbols to asan_interface_internal.h"
Feb 4 2015, 11:16 AM
ributzka committed rL228161: Add missing include..
Add missing include.
Feb 4 2015, 10:18 AM

Dec 22 2014

ributzka committed rL224722: Remove unused header. NFC..
Remove unused header. NFC.
Dec 22 2014, 11:10 AM

Dec 18 2014

ributzka committed rL224563: [Object] Don't crash on empty export lists..
[Object] Don't crash on empty export lists.
Dec 18 2014, 6:31 PM
ributzka closed D6732: [Object] Don't crash on empty export lists. by committing rL224563: [Object] Don't crash on empty export lists..
Dec 18 2014, 6:31 PM
ributzka updated subscribers of D6732: [Object] Don't crash on empty export lists..
Dec 18 2014, 5:12 PM
ributzka retitled D6732: [Object] Don't crash on empty export lists. from to [Object] Don't crash on empty export lists..
Dec 18 2014, 5:08 PM
ributzka committed rL224527: Add missing implementation of 'sys::path::is_other' to the support library..
Add missing implementation of 'sys::path::is_other' to the support library.
Dec 18 2014, 10:20 AM
ributzka accepted D6668: Have llvm-c-test only use libLLVM if libLLVM has all the right components..

LGTM

Dec 18 2014, 9:16 AM

Dec 11 2014

ributzka committed rL223941: [AArch64] MachO large code-model: Materialize FP constants in code..
[AArch64] MachO large code-model: Materialize FP constants in code.
Dec 11 2014, 6:28 AM

Dec 8 2014

ributzka accepted D6572: Adding a new option to CMake to disable C++ atexit on llvm-shlib..

LGTM

Dec 8 2014, 2:29 PM

Nov 26 2014

ributzka added a comment to D6245: [FastIsel][X86] Fix invalid register replacement for bool args.

Hi Keno,

Nov 26 2014, 9:29 AM
ributzka accepted D6415: [SwitchLowering] Handle multiple destinations on condensed case stmts.

Hi Bruno,

Nov 26 2014, 8:42 AM

Nov 21 2014

ributzka accepted D5683: Statepoint infrastructure for garbage collection.

There are still a lot of coding standard violations. I marked a few of them ...

Nov 21 2014, 1:36 PM

Nov 14 2014

ributzka added a comment to D6262: [FastISel][X86] Constrain register operand class in foldOperandImpl .

I think this should be done inside 'foldMemoryOperandImpl'. We shouldn't have to cleanup afterwards.

Nov 14 2014, 10:41 AM

Nov 13 2014

ributzka added a comment to D6245: [FastIsel][X86] Fix invalid register replacement for bool args.

You could make it a load from an address. The address could be simply an argument to 'foo'.

Nov 13 2014, 5:26 PM
ributzka added a comment to D6245: [FastIsel][X86] Fix invalid register replacement for bool args.

Checking for the label, the 'load' and the 'and' would be nice too ;-)

Nov 13 2014, 5:19 PM
ributzka accepted D6245: [FastIsel][X86] Fix invalid register replacement for bool args.

Great. Thanks for fixing this.

Nov 13 2014, 1:42 PM
ributzka added a comment to D6245: [FastIsel][X86] Fix invalid register replacement for bool args.

Hi Keno,

Nov 13 2014, 9:26 AM

Nov 6 2014

ributzka added a comment to D4608: Mangling for intrinsic names w/function type parameters.

Yes, please commit.

Nov 6 2014, 2:10 PM

Nov 3 2014

ributzka accepted D6101: Fix an issue with certain constants as live values in patchpoints..

LGTM

Nov 3 2014, 2:58 PM
ributzka accepted D6100: Change logic in StackMaps::recordStackMapOpers to use the isInt<32> predicate instead of bitwise operations..

LGTM

Nov 3 2014, 2:56 PM

Oct 30 2014

ributzka added a comment to D5683: Statepoint infrastructure for garbage collection.

Hi Philip,

Oct 30 2014, 5:19 PM

Oct 23 2014

ributzka accepted D5809: [X86] Improve mul w/ overflow codegen, to MUL8+SETO..

Hi Ahmed,

Oct 23 2014, 11:14 AM
ributzka accepted D5935: [AArch64] Fix fast-isel of cbz of i1, i8, i16.

Hi Oliver,

Oct 23 2014, 10:52 AM

Oct 17 2014

ributzka closed D5634: Enable invoking the patchpoint intrinsic.

Closed by commit rL220055 (authored by @ributzka).

Oct 17 2014, 10:49 AM

Oct 16 2014

ributzka added a comment to D5634: Enable invoking the patchpoint intrinsic.

The patch didn't apply cleanly against trunk. I merged it, but now the test case is failing for me. The test case is very fragile, because it relies on temporary labels. I think you can get rid of most of these checks.

Oct 16 2014, 4:01 PM
ributzka closed D5657: Reduce code duplication between patchpoint and non-patchpoint lowering. NFC..

Closed by commit rL219967 (authored by @ributzka).

Oct 16 2014, 2:37 PM
ributzka added a comment to D5657: Reduce code duplication between patchpoint and non-patchpoint lowering. NFC..

I think you forgot to get rid of "TargetLowering.h" ;-)
Do you have commit access?

Oct 16 2014, 1:12 PM

Oct 15 2014

ributzka added a comment to D5634: Enable invoking the patchpoint intrinsic.

Oh, I see. Never mind then.

Oct 15 2014, 1:19 PM
ributzka accepted D5634: Enable invoking the patchpoint intrinsic.

I still think not threading through ImmutableCallSite would be nicer and reduce unnecessary changes. Otherwise LGTM.

Oct 15 2014, 10:49 AM
ributzka accepted D5657: Reduce code duplication between patchpoint and non-patchpoint lowering. NFC..

LGTM

Oct 15 2014, 10:35 AM
ributzka added a comment to D5634: Enable invoking the patchpoint intrinsic.

Oh, that explains it. I wasn’t aware this patch depended on D5657.

Oct 15 2014, 9:53 AM

Oct 14 2014

ributzka added a parent revision for D5634: Enable invoking the patchpoint intrinsic: D5657: Reduce code duplication between patchpoint and non-patchpoint lowering. NFC..
Oct 14 2014, 3:43 PM
ributzka added a comment to D5634: Enable invoking the patchpoint intrinsic.

Hi Kevin,

Oct 14 2014, 10:55 AM

Oct 9 2014

ributzka accepted D4608: Mangling for intrinsic names w/function type parameters.

Just a few coding style nitpicks. Otherwise LGTM.

Oct 9 2014, 2:52 PM

Oct 8 2014

ributzka added a comment to D5634: Enable invoking the patchpoint intrinsic.

Just a few coding style nitpicks inline.

Oct 8 2014, 10:37 PM
ributzka added a comment to D5696: Add llvm.experimental.patchpoint.double.

If I recall correctly there should be a few places where the return type is hard-coded or assumed to be i64.

Oct 8 2014, 10:18 PM

Sep 8 2014

ributzka added a comment to D5249: fast-isel: remove dead code after falling back from selecting call instructions (PR20863).

Yup

Sep 8 2014, 1:28 PM
ributzka accepted D5249: fast-isel: remove dead code after falling back from selecting call instructions (PR20863).

Could you also add an unit test that checks that the local value area didn't get accidentally deleted as dead code too?

Sep 8 2014, 1:10 PM

Sep 3 2014

ributzka added a comment to D5156: Select elimination pass.

Hi Gerolf,

Sep 3 2014, 10:40 PM

Aug 21 2014

ributzka added inline comments to D5011: Fix unaligned reads/writes in X86JIT and RuntimeDyldELF..
Aug 21 2014, 3:47 PM
ributzka added inline comments to D5011: Fix unaligned reads/writes in X86JIT and RuntimeDyldELF..
Aug 21 2014, 1:39 PM

Jul 24 2014

ributzka accepted D4574: Add support for StackMap section for ELF/Linux systems.

LGTM

Jul 24 2014, 2:49 PM

Jul 17 2014

ributzka added a reviewer for D4574: Add support for StackMap section for ELF/Linux systems: lhames.
Jul 17 2014, 4:18 PM
ributzka accepted D4572: Explicitly report runtime stack realignment in StackMap section.

Being able to communicate the fact that the stack has been dynamically aligned during runtime is one of the things we want to add in the future to enable AVX.

Jul 17 2014, 2:12 PM