Page MenuHomePhabricator
Feed Advanced Search

Fri, Jul 30

jansvoboda11 added inline comments to D106864: [clang][cli] Expose -fno-cxx-modules in cc1.
Fri, Jul 30, 6:57 AM · Restricted Project
jansvoboda11 updated the diff for D106864: [clang][cli] Expose -fno-cxx-modules in cc1.

Add negative test, check error messages.

Fri, Jul 30, 6:56 AM · Restricted Project
jansvoboda11 retitled D106862: [clang] Remove misleading assertion in FullSourceLoc from [clang] Remove misleading assertion in `FullSourceLoc` to [clang] Remove misleading assertion in FullSourceLoc.
Fri, Jul 30, 5:58 AM · Restricted Project
jansvoboda11 retitled D106862: [clang] Remove misleading assertion in FullSourceLoc from [clang][modules] Avoid creating partial FullSourceLoc for explicit modules imports to [clang] Remove misleading assertion in `FullSourceLoc`.
Fri, Jul 30, 5:58 AM · Restricted Project
jansvoboda11 updated the summary of D107155: [clang][deps] Substitute clang-scan-deps executable in lit tests.
Fri, Jul 30, 5:51 AM · Restricted Project
jansvoboda11 requested review of D107155: [clang][deps] Substitute clang-scan-deps executable in lit tests.
Fri, Jul 30, 5:50 AM · Restricted Project
jansvoboda11 requested review of D106862: [clang] Remove misleading assertion in FullSourceLoc.

I investigated this a bit more.

Fri, Jul 30, 4:52 AM · Restricted Project
jansvoboda11 updated the diff for D106862: [clang] Remove misleading assertion in FullSourceLoc.

Remove assertion altogether.

Fri, Jul 30, 4:52 AM · Restricted Project

Tue, Jul 27

jansvoboda11 updated the summary of D106862: [clang] Remove misleading assertion in FullSourceLoc.
Tue, Jul 27, 6:45 AM · Restricted Project
jansvoboda11 added inline comments to D106864: [clang][cli] Expose -fno-cxx-modules in cc1.
Tue, Jul 27, 5:16 AM · Restricted Project
jansvoboda11 requested review of D106864: [clang][cli] Expose -fno-cxx-modules in cc1.
Tue, Jul 27, 5:13 AM · Restricted Project
jansvoboda11 requested review of D106862: [clang] Remove misleading assertion in FullSourceLoc.
Tue, Jul 27, 4:59 AM · Restricted Project
jansvoboda11 committed rG0f98e6e87558: [clang][tooling] Link LLVMOption to ToolingTests (authored by jansvoboda11).
[clang][tooling] Link LLVMOption to ToolingTests
Tue, Jul 27, 2:49 AM
jansvoboda11 committed rG5bcbb5ec5f07: [clang][tooling] Link clangDriver to ToolingTests (authored by jansvoboda11).
[clang][tooling] Link clangDriver to ToolingTests
Tue, Jul 27, 2:10 AM
jansvoboda11 committed rG11ee699b3c81: [clang][tooling] Accept Clang invocations with multiple jobs (authored by jansvoboda11).
[clang][tooling] Accept Clang invocations with multiple jobs
Tue, Jul 27, 1:48 AM
jansvoboda11 closed D105695: [clang][tooling] Accept Clang invocations with multiple jobs.
Tue, Jul 27, 1:48 AM · Restricted Project
jansvoboda11 committed rGb76c7c6faf06: [clang][driver] NFC: Expose InputInfo in Job instead of plain filenames (authored by jansvoboda11).
[clang][driver] NFC: Expose InputInfo in Job instead of plain filenames
Tue, Jul 27, 12:19 AM
jansvoboda11 closed D106788: [clang][driver] NFC: Expose InputInfo in Job instead of plain filenames.
Tue, Jul 27, 12:19 AM · Restricted Project
jansvoboda11 committed rG60426f33b1d4: [clang][driver] NFC: Move InputInfo.h from lib to include (authored by jansvoboda11).
[clang][driver] NFC: Move InputInfo.h from lib to include
Tue, Jul 27, 12:18 AM
jansvoboda11 closed D106787: [clang][driver] NFC: Move InputInfo.h from lib to include.
Tue, Jul 27, 12:17 AM · Restricted Project
jansvoboda11 added a comment to D105695: [clang][tooling] Accept Clang invocations with multiple jobs.

Seeing the -fembed-bitcode case made me think of -save-temps. I think this will work since -x cpp-output should return false for isSrcFile()... but probably worth adding a test. LGTM assuming the test passes.

Tue, Jul 27, 12:15 AM · Restricted Project

Mon, Jul 26

jansvoboda11 requested changes to D105881: [flang][driver] Switch to `BoolFOption` for boolean options.
Mon, Jul 26, 9:50 AM · Restricted Project, Restricted Project
jansvoboda11 added a comment to D105881: [flang][driver] Switch to `BoolFOption` for boolean options.

Sorry, I'm not sure I follow.

Mon, Jul 26, 9:50 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D105695: [clang][tooling] Accept Clang invocations with multiple jobs.

Formatting

Mon, Jul 26, 5:24 AM · Restricted Project
jansvoboda11 requested review of D105695: [clang][tooling] Accept Clang invocations with multiple jobs.

Requesting re-review, since there are two changes:

  • -cc1 commands that don't read a source file are ignored (e.g. jobs generated by -fembed-bitcode),
  • test now have -target arm64-apple-macosx11.0.0 to ensure things work platforms that don't have external assembler.
Mon, Jul 26, 5:23 AM · Restricted Project
jansvoboda11 updated the summary of D105695: [clang][tooling] Accept Clang invocations with multiple jobs.
Mon, Jul 26, 5:20 AM · Restricted Project
jansvoboda11 updated the diff for D105695: [clang][tooling] Accept Clang invocations with multiple jobs.

Also ignore cc1 jobs that have inputs that are not source files.

Mon, Jul 26, 5:15 AM · Restricted Project
jansvoboda11 requested review of D106788: [clang][driver] NFC: Expose InputInfo in Job instead of plain filenames.
Mon, Jul 26, 4:57 AM · Restricted Project
jansvoboda11 planned changes to D102488: [clang][deps] Prune unused header search paths.

After speaking with @dexonsmith, the laziness is probably not necessary when dealing with a short bit vector. I'll also explore using llvm::BitVector instead of std::vector<bool>.

Mon, Jul 26, 4:54 AM · Restricted Project
jansvoboda11 requested review of D106787: [clang][driver] NFC: Move InputInfo.h from lib to include.
Mon, Jul 26, 4:52 AM · Restricted Project

Thu, Jul 22

jansvoboda11 committed rGaa245ddd4627: [clang][lex] NFC: Add explicit cast to silence -Wsign-compare (authored by jansvoboda11).
[clang][lex] NFC: Add explicit cast to silence -Wsign-compare
Thu, Jul 22, 3:22 AM

Tue, Jul 20

jansvoboda11 added a comment to D104536: [clang][deps] Avoid minimizing PCH input files.

Looks like this breaks tests on Windows: http://45.33.8.238/win/42264/step_7.txt

Please take a look, and revert for now if it takes a while to fix.

Tue, Jul 20, 4:21 AM · Restricted Project
jansvoboda11 committed rGc94a345a5c69: [clang][deps] Fix test by checking ignored files correctly (authored by jansvoboda11).
[clang][deps] Fix test by checking ignored files correctly
Tue, Jul 20, 4:21 AM
jansvoboda11 committed rGe564fd93ab85: [clang][deps] Avoid minimizing PCH input files (authored by jansvoboda11).
[clang][deps] Avoid minimizing PCH input files
Tue, Jul 20, 3:20 AM
jansvoboda11 closed D104536: [clang][deps] Avoid minimizing PCH input files.
Tue, Jul 20, 3:20 AM · Restricted Project
jansvoboda11 committed rGbc1a2979fc70: [clang][deps] Separate filesystem caches for minimized and original files (authored by jansvoboda11).
[clang][deps] Separate filesystem caches for minimized and original files
Tue, Jul 20, 3:09 AM
jansvoboda11 closed D106146: [clang][deps] Separate filesystem caches for minimized and original files.
Tue, Jul 20, 3:08 AM · Restricted Project
jansvoboda11 committed rG63fd109d3aa6: [clang][deps] Normalize ignored filenames in minimizing file system (authored by jansvoboda11).
[clang][deps] Normalize ignored filenames in minimizing file system
Tue, Jul 20, 2:32 AM
jansvoboda11 closed D106064: [clang][deps] Normalize ignored filenames in minimizing file system.
Tue, Jul 20, 2:32 AM · Restricted Project
jansvoboda11 retitled D106064: [clang][deps] Normalize ignored filenames in minimizing file system from [clang][deps] Normalize paths in minimizing file system to [clang][deps] Normalize ignored filenames in minimizing file system.
Tue, Jul 20, 2:26 AM · Restricted Project

Mon, Jul 19

jansvoboda11 accepted D106100: [clang-scan-deps] ignore top-level module dependencies that aren't actually imported.

LGTM!

Mon, Jul 19, 2:08 PM · Restricted Project
jansvoboda11 added a comment to D106064: [clang][deps] Normalize ignored filenames in minimizing file system.

With the call to llvm::sys::path::native scoped only to IgnoredFiles, would this patch LGTY?

Mon, Jul 19, 10:19 AM · Restricted Project
jansvoboda11 added inline comments to D106064: [clang][deps] Normalize ignored filenames in minimizing file system.
Mon, Jul 19, 6:55 AM · Restricted Project

Fri, Jul 16

jansvoboda11 updated the diff for D104536: [clang][deps] Avoid minimizing PCH input files.

Rebase on top of D106146.

Fri, Jul 16, 6:00 AM · Restricted Project
jansvoboda11 updated the summary of D104536: [clang][deps] Avoid minimizing PCH input files.
Fri, Jul 16, 5:59 AM · Restricted Project
jansvoboda11 requested review of D106146: [clang][deps] Separate filesystem caches for minimized and original files.
Fri, Jul 16, 5:58 AM · Restricted Project

Thu, Jul 15

jansvoboda11 abandoned D104465: [clang][deps] Prevent PCH validation failures by padding minimized files.
Thu, Jul 15, 2:08 PM · Restricted Project
jansvoboda11 abandoned D104459: [clang][lex] Ensure minimizer output is never larger than input.
Thu, Jul 15, 2:08 PM · Restricted Project
jansvoboda11 abandoned D104462: [clang][lex] Add minimizer option to pad the output to the input size.
Thu, Jul 15, 2:08 PM · Restricted Project
jansvoboda11 retitled D104536: [clang][deps] Avoid minimizing PCH input files from WIP: [clang][deps] Avoid minimizing PCH input files to [clang][deps] Avoid minimizing PCH input files.
Thu, Jul 15, 9:52 AM · Restricted Project
jansvoboda11 updated the diff for D104536: [clang][deps] Avoid minimizing PCH input files.

Rebase on top of D106064, solving Windows CI failure.

Thu, Jul 15, 6:51 AM · Restricted Project
jansvoboda11 requested review of D106064: [clang][deps] Normalize ignored filenames in minimizing file system.
Thu, Jul 15, 6:50 AM · Restricted Project
jansvoboda11 retitled D105695: [clang][tooling] Accept Clang invocations with multiple jobs from [clang][tooling] Accept Clang invocations with multiple cc1 jobs to [clang][tooling] Accept Clang invocations with multiple jobs.
Thu, Jul 15, 1:36 AM · Restricted Project

Wed, Jul 14

jansvoboda11 updated the diff for D104536: [clang][deps] Avoid minimizing PCH input files.

Entirely disable DepFS when scanning PCHs.

Wed, Jul 14, 1:32 PM · Restricted Project
jansvoboda11 updated the diff for D105695: [clang][tooling] Accept Clang invocations with multiple jobs.

Handle cases with multiple input files and architectures, add tests.

Wed, Jul 14, 1:30 PM · Restricted Project

Tue, Jul 13

jansvoboda11 added inline comments to D105881: [flang][driver] Switch to `BoolFOption` for boolean options.
Tue, Jul 13, 8:24 AM · Restricted Project, Restricted Project
jansvoboda11 added inline comments to D105881: [flang][driver] Switch to `BoolFOption` for boolean options.
Tue, Jul 13, 4:37 AM · Restricted Project, Restricted Project

Mon, Jul 12

jansvoboda11 added a comment to D104536: [clang][deps] Avoid minimizing PCH input files.

I run a quick benchmark where an empty TU is configured with an explicitly built PCH that imports Cocoa. Dependency scanning without minimization takes 226 ms, with this patch 303 ms and 325 ms when padding minimized files to the original size. Since we'll eventually switch to a more sound implementation, I'm fine with this in the meantime.

Mon, Jul 12, 3:22 AM · Restricted Project
jansvoboda11 updated the diff for D104536: [clang][deps] Avoid minimizing PCH input files.

Handle system input files.

Mon, Jul 12, 1:54 AM · Restricted Project

Fri, Jul 9

jansvoboda11 added a comment to D103461: [clang][deps] NFC: Preserve the original frontend action.

@jansvoboda11 This change is causing the following LIT tests to fail on AIX:

Clang :: ClangScanDeps/headerwithdirname.cpp
Clang :: ClangScanDeps/headerwithdirnamefollowedbyinclude.cpp

The reason seems to be related to the fact that -fno-integrated-as is on by default on that platform. I get the same failure on Linux if I change the "compilation database" file to add -fno-integrated-as to the "command" line:

> /build_llvm/bin/clang-scan-deps -compilation-database ./headerwithdirname.cpp.tmp.cdb -j 1
> Error while scanning dependencies for /build_llvm/tools/clang/test/ClangScanDeps/Output/headerwithdirname.cpp.tmp.dir/headerwithdirname_input.cpp:
error: unable to handle compilation, expected exactly one compiler job in ' "clang" "-cc1" "-triple" "powerpc64le-unknown-linux-gnu" "-S" ...;  "/usr/bin/as" "-a64" "-mppc64" "-mlittle-endian" "-mpower8" "-I" "/build_llvm/tools/clang/test/ClangScanDeps/Output/headerwithdirname.cpp.tmp.dir" "-I" "/build_llvm/tools/clang/test/ClangScanDeps/Output/headerwithdirname.cpp.tmp.dir/foodir" "-I" "Inputs" "-o" "headerwithdirname_input.o" "/tmp/headerwithdirname_input-2e0050.s"; '

Thanks for the report and the reproducer. I'll try to get a fix ready tomorrow.

Fri, Jul 9, 5:20 AM · Restricted Project
jansvoboda11 requested review of D105695: [clang][tooling] Accept Clang invocations with multiple jobs.
Fri, Jul 9, 5:19 AM · Restricted Project

Wed, Jul 7

jansvoboda11 added a comment to D103461: [clang][deps] NFC: Preserve the original frontend action.

@jansvoboda11 This change is causing the following LIT tests to fail on AIX:

Clang :: ClangScanDeps/headerwithdirname.cpp
Clang :: ClangScanDeps/headerwithdirnamefollowedbyinclude.cpp

The reason seems to be related to the fact that -fno-integrated-as is on by default on that platform. I get the same failure on Linux if I change the "compilation database" file to add -fno-integrated-as to the "command" line:

> /build_llvm/bin/clang-scan-deps -compilation-database ./headerwithdirname.cpp.tmp.cdb -j 1
> Error while scanning dependencies for /build_llvm/tools/clang/test/ClangScanDeps/Output/headerwithdirname.cpp.tmp.dir/headerwithdirname_input.cpp:
error: unable to handle compilation, expected exactly one compiler job in ' "clang" "-cc1" "-triple" "powerpc64le-unknown-linux-gnu" "-S" ...;  "/usr/bin/as" "-a64" "-mppc64" "-mlittle-endian" "-mpower8" "-I" "/build_llvm/tools/clang/test/ClangScanDeps/Output/headerwithdirname.cpp.tmp.dir" "-I" "/build_llvm/tools/clang/test/ClangScanDeps/Output/headerwithdirname.cpp.tmp.dir/foodir" "-I" "Inputs" "-o" "headerwithdirname_input.o" "/tmp/headerwithdirname_input-2e0050.s"; '
Wed, Jul 7, 8:54 AM · Restricted Project
jansvoboda11 added inline comments to D105225: [clang] Add support for optional flag -fnew-infallible to restrict exception propagation.
Wed, Jul 7, 12:37 AM

Jun 18 2021

jansvoboda11 added a comment to D103930: [clang][HeaderSearch] Fix implicit module when using header maps.

Thanks for working on this, comments inline. @vsapsai @jansvoboda11 @dexonsmith any headermap related concerns on your side?

@jansvoboda11, I think it'd be prudent for us to test this patch out internally before it's landed, since I don't really trust that the existing unit tests cover all the interactions between header maps and modules. Might you be able to coordinate something with @arphaman?

Jun 18 2021, 7:46 AM · Restricted Project
jansvoboda11 added a comment to D104465: [clang][deps] Prevent PCH validation failures by padding minimized files.

Thanks for sharing your ideas! I've left my initial thoughts below, but I want to revisit this and think about it some more.

Jun 18 2021, 7:45 AM · Restricted Project
jansvoboda11 planned changes to D104536: [clang][deps] Avoid minimizing PCH input files.
Jun 18 2021, 7:44 AM · Restricted Project
jansvoboda11 requested review of D104536: [clang][deps] Avoid minimizing PCH input files.
Jun 18 2021, 7:33 AM · Restricted Project

Jun 17 2021

jansvoboda11 added a comment to D103930: [clang][HeaderSearch] Fix implicit module when using header maps.

I don't have any comments regarding header maps.

Jun 17 2021, 8:05 AM · Restricted Project
jansvoboda11 updated the summary of D104465: [clang][deps] Prevent PCH validation failures by padding minimized files.
Jun 17 2021, 7:51 AM · Restricted Project
jansvoboda11 updated the diff for D104459: [clang][lex] Ensure minimizer output is never larger than input.

Fix assert wording

Jun 17 2021, 7:46 AM · Restricted Project
jansvoboda11 updated the summary of D104462: [clang][lex] Add minimizer option to pad the output to the input size.
Jun 17 2021, 7:45 AM · Restricted Project
jansvoboda11 requested review of D104465: [clang][deps] Prevent PCH validation failures by padding minimized files.
Jun 17 2021, 7:44 AM · Restricted Project
jansvoboda11 abandoned D104460: [clang][lex] NFC: Extract source variable in minimizer tests.

Found a way to do the thing in a follow up with less churn. Sorry for the noise.

Jun 17 2021, 7:32 AM · Restricted Project
jansvoboda11 requested review of D104462: [clang][lex] Add minimizer option to pad the output to the input size.
Jun 17 2021, 7:25 AM · Restricted Project
jansvoboda11 requested review of D104460: [clang][lex] NFC: Extract source variable in minimizer tests.
Jun 17 2021, 6:37 AM · Restricted Project
jansvoboda11 requested review of D104459: [clang][lex] Ensure minimizer output is never larger than input.
Jun 17 2021, 6:34 AM · Restricted Project
jansvoboda11 added a comment to D104351: [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma once`..

This seems reasonable on first look. Can you add a test that demonstrates the problem this patch solves?

Jun 17 2021, 6:26 AM · Restricted Project

Jun 14 2021

jansvoboda11 committed rGf95ff8162721: [clang][deps] NFC: Handle `DependencyOutputOptions` only once (authored by jansvoboda11).
[clang][deps] NFC: Handle `DependencyOutputOptions` only once
Jun 14 2021, 6:16 AM
jansvoboda11 committed rG85208b96b85f: [clang][deps] NFC: Stop using moved-from object (authored by jansvoboda11).
[clang][deps] NFC: Stop using moved-from object
Jun 14 2021, 6:16 AM
jansvoboda11 closed D104104: [clang][deps] NFC: Handle `DependencyOutputOptions` only once.
Jun 14 2021, 6:16 AM · Restricted Project
jansvoboda11 closed D104106: [clang][deps] NFC: Stop using moved-from object.
Jun 14 2021, 6:16 AM · Restricted Project
jansvoboda11 committed rGf39dcf85f994: [clang][deps] NFC: Fix an XFAIL test on Windows (authored by jansvoboda11).
[clang][deps] NFC: Fix an XFAIL test on Windows
Jun 14 2021, 5:37 AM
jansvoboda11 added a comment to D104036: [clang][deps] Prevent unintended modifications of the original TU command-line.

Either this or your concurrent commit broke check-clang: http://45.33.8.238/linux/48839/step_7.txt

Please take a look and revert for now if it takes a while to fix.

Jun 14 2021, 5:20 AM · Restricted Project
jansvoboda11 committed rG80c0c639687e: [clang][deps] Prevent unintended modifications of the original TU command-line (authored by jansvoboda11).
[clang][deps] Prevent unintended modifications of the original TU command-line
Jun 14 2021, 5:05 AM
jansvoboda11 committed rG41115efca642: [clang][deps] NFC: Check the correct context hashes in tests (authored by jansvoboda11).
[clang][deps] NFC: Check the correct context hashes in tests
Jun 14 2021, 5:05 AM
jansvoboda11 closed D104036: [clang][deps] Prevent unintended modifications of the original TU command-line.
Jun 14 2021, 5:05 AM · Restricted Project
jansvoboda11 added inline comments to D104036: [clang][deps] Prevent unintended modifications of the original TU command-line.
Jun 14 2021, 4:29 AM · Restricted Project
jansvoboda11 committed rG1d8882b5e44e: [clang][deps] Fix failing modules.cpp test (authored by jansvoboda11).
[clang][deps] Fix failing modules.cpp test
Jun 14 2021, 3:56 AM
jansvoboda11 committed rG6c6dcfc4ce75: [clang][deps] Move enabling system header deps from `clang-scan-deps` to… (authored by jansvoboda11).
[clang][deps] Move enabling system header deps from `clang-scan-deps` to…
Jun 14 2021, 3:24 AM
jansvoboda11 committed rGcf7d9704688d: [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to… (authored by jansvoboda11).
[clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to…
Jun 14 2021, 3:24 AM
jansvoboda11 committed rGd8bab69ead22: [clang][deps] Move invocation adjustments from `clang-scan-deps` to… (authored by jansvoboda11).
[clang][deps] Move invocation adjustments from `clang-scan-deps` to…
Jun 14 2021, 3:23 AM
jansvoboda11 closed D104033: [clang][deps] Move enabling system header deps from `clang-scan-deps` to `DependencyScanning` library.
Jun 14 2021, 3:23 AM · Restricted Project
jansvoboda11 committed rG35fa3e60d161: [clang][deps] Move stripping of diagnostic serialization from `clang-scan-deps`… (authored by jansvoboda11).
[clang][deps] Move stripping of diagnostic serialization from `clang-scan-deps`…
Jun 14 2021, 3:23 AM
jansvoboda11 closed D104031: [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to `DependencyScanning` library.
Jun 14 2021, 3:23 AM · Restricted Project
jansvoboda11 closed D104030: [clang][deps] Move invocation adjustments from `clang-scan-deps` to `DependencyScanning` library.
Jun 14 2021, 3:23 AM · Restricted Project
jansvoboda11 closed D104012: [clang][deps] Move stripping of diagnostic serialization from `clang-scan-deps` to `DependencyScanning` library.
Jun 14 2021, 3:23 AM · Restricted Project
jansvoboda11 raised a concern with rG673c5ba58497: [clang-format] Adds a formatter for aligning arrays of structs.

This causes a bunch of build bot failures:

Jun 14 2021, 3:18 AM
jansvoboda11 committed rG4629554f0b66: [clang][deps] Handle modular dependencies present in PCH (authored by jansvoboda11).
[clang][deps] Handle modular dependencies present in PCH
Jun 14 2021, 3:01 AM
jansvoboda11 closed D103526: [clang][deps] Handle modular dependencies present in PCH.
Jun 14 2021, 3:01 AM · Restricted Project
jansvoboda11 committed rG9223209be11e: [clang][deps] Handle precompiled headers' AST files (authored by jansvoboda11).
[clang][deps] Handle precompiled headers' AST files
Jun 14 2021, 2:29 AM