Page MenuHomePhabricator
Feed Advanced Search

Thu, Jul 21

wrotki accepted D126351: [ASan][Darwin] Ensure we always register GCD worker threads.

LVGTM - very DRY :)

Thu, Jul 21, 3:10 PM · Restricted Project, Restricted Project

Tue, Jul 12

wrotki committed rGaf0a26b47661: [Sanitizers][Darwin] Remove SANITIZER_MAC (authored by wrotki).
[Sanitizers][Darwin] Remove SANITIZER_MAC
Tue, Jul 12, 9:11 AM · Restricted Project, Restricted Project
wrotki closed D129502: [Sanitizers][Darwin] Remove SANITIZER_MAC.
Tue, Jul 12, 9:11 AM · Restricted Project, Restricted Project

Mon, Jul 11

wrotki requested review of D129502: [Sanitizers][Darwin] Remove SANITIZER_MAC.
Mon, Jul 11, 10:26 AM · Restricted Project, Restricted Project

Jun 30 2022

wrotki accepted D128936: [Sanitizer][Darwin] Lookup dyld image header via shared cache.

LGTM

Jun 30 2022, 3:18 PM · Restricted Project, Restricted Project

Jun 28 2022

wrotki committed rG67ced6af3b6e: [Sanitizers] Cleanup handling of stat64/statfs64 (authored by wrotki).
[Sanitizers] Cleanup handling of stat64/statfs64
Jun 28 2022, 3:02 PM · Restricted Project, Restricted Project
wrotki closed D128476: [Sanitizers] Cleanup handling of stat64/statfs64.
Jun 28 2022, 3:02 PM · Restricted Project, Restricted Project

Jun 23 2022

wrotki requested review of D128476: [Sanitizers] Cleanup handling of stat64/statfs64.
Jun 23 2022, 3:58 PM · Restricted Project, Restricted Project

Jun 10 2022

wrotki added a comment to rGa4bf361454c4: Revert "[Sanitizers] Cleanup handling of stat64/statfs64".

Will do (add a comment why revert) , sorry.

Jun 10 2022, 11:09 AM · Restricted Project, Restricted Project
wrotki added a reverting change for rG6d890a0fb8b1: [Sanitizers] Cleanup handling of stat64/statfs64: rGa4bf361454c4: Revert "[Sanitizers] Cleanup handling of stat64/statfs64".
Jun 10 2022, 10:56 AM · Restricted Project, Restricted Project
wrotki committed rGa4bf361454c4: Revert "[Sanitizers] Cleanup handling of stat64/statfs64" (authored by wrotki).
Revert "[Sanitizers] Cleanup handling of stat64/statfs64"
Jun 10 2022, 10:56 AM · Restricted Project, Restricted Project
wrotki added a reverting change for D127343: [Sanitizers] Cleanup handling of stat64/statfs64: rGa4bf361454c4: Revert "[Sanitizers] Cleanup handling of stat64/statfs64".
Jun 10 2022, 10:56 AM · Restricted Project, Restricted Project
wrotki added a comment to D127343: [Sanitizers] Cleanup handling of stat64/statfs64.

Okay, will revert and investigate - thanks for notifying.

Jun 10 2022, 9:59 AM · Restricted Project, Restricted Project

Jun 9 2022

wrotki committed rG6d890a0fb8b1: [Sanitizers] Cleanup handling of stat64/statfs64 (authored by wrotki).
[Sanitizers] Cleanup handling of stat64/statfs64
Jun 9 2022, 12:51 PM · Restricted Project, Restricted Project
wrotki closed D127343: [Sanitizers] Cleanup handling of stat64/statfs64.
Jun 9 2022, 12:51 PM · Restricted Project, Restricted Project

Jun 8 2022

wrotki requested review of D127343: [Sanitizers] Cleanup handling of stat64/statfs64.
Jun 8 2022, 1:45 PM · Restricted Project, Restricted Project

May 31 2022

wrotki committed rGe2adffc39c52: [Sanitizers][Darwin] Deprecate SANITIZER_MAC - fail compilation if encountered (authored by wrotki).
[Sanitizers][Darwin] Deprecate SANITIZER_MAC - fail compilation if encountered
May 31 2022, 6:09 PM · Restricted Project, Restricted Project
wrotki closed D126577: [Sanitizers][Darwin] Deprecate SANITIZER_MAC - fail compilation if encountered.
May 31 2022, 6:09 PM · Restricted Project, Restricted Project

May 27 2022

wrotki requested review of D126577: [Sanitizers][Darwin] Deprecate SANITIZER_MAC - fail compilation if encountered.
May 27 2022, 4:28 PM · Restricted Project, Restricted Project

May 24 2022

wrotki committed rG8246b2e15656: [Sanitizers][Darwin] Replace SANITIZER_MAC with SANITIZER_APPLE in source files (authored by wrotki).
[Sanitizers][Darwin] Replace SANITIZER_MAC with SANITIZER_APPLE in source files
May 24 2022, 1:00 PM · Restricted Project, Restricted Project
wrotki closed D126263: [Sanitizers][Darwin] Replace SANITIZER_MAC with SANITIZER_APPLE in source files.
May 24 2022, 12:59 PM · Restricted Project, Restricted Project

May 23 2022

wrotki requested review of D126263: [Sanitizers][Darwin] Replace SANITIZER_MAC with SANITIZER_APPLE in source files.
May 23 2022, 6:11 PM · Restricted Project, Restricted Project

May 18 2022

wrotki committed rG77014b9a1334: [Sanitizers][Darwin] Rename Apple macro SANITIZER_MAC -> SANITIZER_APPLE (authored by wrotki).
[Sanitizers][Darwin] Rename Apple macro SANITIZER_MAC -> SANITIZER_APPLE
May 18 2022, 2:47 PM · Restricted Project, Restricted Project
wrotki closed D125816: [Sanitizers][Darwin] Rename Apple macro SANITIZER_MAC -> SANITIZER_APPLE.
May 18 2022, 2:46 PM · Restricted Project, Restricted Project
wrotki added inline comments to D125816: [Sanitizers][Darwin] Rename Apple macro SANITIZER_MAC -> SANITIZER_APPLE.
May 18 2022, 10:39 AM · Restricted Project, Restricted Project
wrotki updated the diff for D125816: [Sanitizers][Darwin] Rename Apple macro SANITIZER_MAC -> SANITIZER_APPLE.

Added SANITIZER_WATCHOS and SANITIZER_TVOS for the non-Apple case

May 18 2022, 10:31 AM · Restricted Project, Restricted Project
wrotki updated the diff for D125816: [Sanitizers][Darwin] Rename Apple macro SANITIZER_MAC -> SANITIZER_APPLE.

Re-adding missing #else line

May 18 2022, 9:51 AM · Restricted Project, Restricted Project

May 17 2022

wrotki updated the diff for D125816: [Sanitizers][Darwin] Rename Apple macro SANITIZER_MAC -> SANITIZER_APPLE.

Removed unneccessary conditional

May 17 2022, 10:57 AM · Restricted Project, Restricted Project
wrotki requested review of D125816: [Sanitizers][Darwin] Rename Apple macro SANITIZER_MAC -> SANITIZER_APPLE.
May 17 2022, 10:40 AM · Restricted Project, Restricted Project