Page MenuHomePhabricator
Feed Advanced Search

Thu, Apr 8

leonardchan committed rGa7b51d8a4fc8: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment (authored by leonardchan).
[compiler-rt][hwasan] Add C++17 new/delete operators with alignment
Thu, Apr 8, 3:45 PM
leonardchan closed D99368: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment.
Thu, Apr 8, 3:45 PM · Restricted Project

Wed, Apr 7

leonardchan updated the diff for D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia.

Rebase against submitted changes.

Wed, Apr 7, 4:42 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan added a comment to D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits.

I don't think this is warranted. There should not be any references to such things when building for Fuchsia.
This looks like it's intended to satisfy one reference in dead code in hwasan_interceptors.cpp.
I think the right solution is just to refactor the hwasan code so that the dead code is not compiled for Fuchsia at all.

Wed, Apr 7, 1:10 PM · Restricted Project

Thu, Mar 25

leonardchan committed rG36eaeaf728d3: [llvm][hwasan] Add Fuchsia shadow mapping configuration (authored by leonardchan).
[llvm][hwasan] Add Fuchsia shadow mapping configuration
Thu, Mar 25, 3:29 PM
leonardchan closed D99380: [llvm][hwasan] Add Fuchsia shadow mapping configuration.
Thu, Mar 25, 3:29 PM · Restricted Project
leonardchan updated the diff for D99380: [llvm][hwasan] Add Fuchsia shadow mapping configuration.
Thu, Mar 25, 3:28 PM · Restricted Project
leonardchan requested review of D99386: [compiler-rt][hwasan] Add definition for Symbolizer::SymbolizeFrame.
Thu, Mar 25, 3:24 PM · Restricted Project
leonardchan requested review of D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits.
Thu, Mar 25, 2:36 PM · Restricted Project
leonardchan requested review of D99380: [llvm][hwasan] Add Fuchsia shadow mapping configuration.
Thu, Mar 25, 2:25 PM · Restricted Project
leonardchan committed rG1abaadb30d37: [clang][driver] Support HWASan in the Fuchsia toolchain (authored by leonardchan).
[clang][driver] Support HWASan in the Fuchsia toolchain
Thu, Mar 25, 1:37 PM
leonardchan closed D99361: [clang][driver] Support HWASan in the Fuchsia toolchain.
Thu, Mar 25, 1:37 PM · Restricted Project
leonardchan requested review of D99368: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment.
Thu, Mar 25, 12:24 PM · Restricted Project
leonardchan requested review of D99364: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs.
Thu, Mar 25, 11:38 AM · Restricted Project
leonardchan requested review of D99361: [clang][driver] Support HWASan in the Fuchsia toolchain.
Thu, Mar 25, 11:29 AM · Restricted Project

Wed, Mar 24

leonardchan accepted D99243: [CMake][Fuchsia] Include llvm-lipo.
Wed, Mar 24, 9:58 AM · Restricted Project

Mar 16 2021

leonardchan added a comment to D91334: [compiler-rt] Set CMAKE_TRY_COMPILE_TARGET_TYPE to STATIC_LIBRARY when building builtins standalone.

I don't think this is an issue with this change, it's an issue on our side.

Did you guys manage to sort this one out, or is there still some lingering issue potentially related to this?

Mar 16 2021, 10:38 AM · Restricted Project

Mar 15 2021

leonardchan accepted D94355: [Passes] Add relative lookup table converter pass.

LGTM pending a few more comments. Should also give some time to let others respond if they have feedback.

Mar 15 2021, 11:56 AM · Restricted Project, Restricted Project
leonardchan added a comment to D97977: [Polly][Optimizer] Apply user-directed unrolling..

Hi, it seems that unroll_double.ll is failing on our clang builders (https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-x64/b8852671182559485616):

Mar 15 2021, 11:37 AM · Restricted Project, Restricted Project

Mar 11 2021

leonardchan added a comment to D91334: [compiler-rt] Set CMAKE_TRY_COMPILE_TARGET_TYPE to STATIC_LIBRARY when building builtins standalone.

Hi, I believe this patch may have indirectly led to a failure in our two-stage clang builder (https://luci-milo.appspot.com/p/fuchsia/builders/prod/clang-linux-x64/b8853033259975286848?):

Mar 11 2021, 5:40 PM · Restricted Project

Mar 10 2021

leonardchan committed rGbaf637dcde8c: Rename top-level LICENSE.txt files to LICENSE.TXT (authored by leonardchan).
Rename top-level LICENSE.txt files to LICENSE.TXT
Mar 10 2021, 9:28 PM
leonardchan closed D98380: Rename top-level LICENSE.txt files to LICENSE.TXT.
Mar 10 2021, 9:27 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan added a comment to D98380: Rename top-level LICENSE.txt files to LICENSE.TXT.

Will submit this now to fix up the CI builders, but we can revert this later if any major changes are needed.

Mar 10 2021, 9:27 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan updated the summary of D98380: Rename top-level LICENSE.txt files to LICENSE.TXT.
Mar 10 2021, 6:41 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan updated the summary of D98380: Rename top-level LICENSE.txt files to LICENSE.TXT.
Mar 10 2021, 6:06 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan requested review of D98380: Rename top-level LICENSE.txt files to LICENSE.TXT.
Mar 10 2021, 6:03 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan committed rG70af0bf6fe46: [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag (authored by leonardchan).
[clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag
Mar 10 2021, 4:29 PM
leonardchan closed D98375: [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag.
Mar 10 2021, 4:29 PM · Restricted Project
leonardchan requested review of D98375: [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag.
Mar 10 2021, 3:53 PM · Restricted Project
leonardchan added a comment to D94355: [Passes] Add relative lookup table converter pass.

One thing that just occurred to me: do we also perhaps want to hide this behind a flag? Right now it's being added to various default optimization pipelines, so some users might be surprised if they suddenly see their lookup tables change (either compiler or user generated). Do we want to make this something more opt-in, or is the layout itself not necessarily a concern to most users?

Mar 10 2021, 10:57 AM · Restricted Project, Restricted Project

Mar 9 2021

leonardchan added a comment to D96945: [InstCombine] Add simplification of two logical and/ors.

Yep, I reverted this patch. Could you post the commandline options that is used to build LLVM?
There was a similar failure reported (D95026) which is due to an existing bug in InstructionSimplify; maybe I can check whether its prospective fix resolves this issue as well.

Thanks for the followup. Can do. Let me see if I can minimize the reproducer/reduce the number of cmake flags needed for ease first since the two-stage build has dependencies on libxml2 and zlib.

While I'm doing that, if you already have a fix, what I can do is patch it locally and get back to you on if it also fixes the issues we see.

Mar 9 2021, 5:23 PM · Restricted Project
leonardchan committed rGcf371573b0b8: [llvm] Change DSOLocalEquivalent type if the underlying global value type… (authored by leonardchan).
[llvm] Change DSOLocalEquivalent type if the underlying global value type…
Mar 9 2021, 3:10 PM
leonardchan closed D97978: [llvm] Change DSOLocalEquivalent type if the underlying global value type changes.
Mar 9 2021, 3:10 PM · Restricted Project
leonardchan added a comment to D96945: [InstCombine] Add simplification of two logical and/ors.

Yep, I reverted this patch. Could you post the commandline options that is used to build LLVM?
There was a similar failure reported (D95026) which is due to an existing bug in InstructionSimplify; maybe I can check whether its prospective fix resolves this issue as well.

Mar 9 2021, 1:10 PM · Restricted Project
leonardchan added a comment to D96945: [InstCombine] Add simplification of two logical and/ors.

A bisect seems to show this patch causing the test failures we see on our two-stage clang builders (https://luci-milo.appspot.com/p/fuchsia/builders/prod/clang-linux-x64/b8853364937280028160?):

Mar 9 2021, 10:25 AM · Restricted Project

Mar 8 2021

leonardchan updated the diff for D97978: [llvm] Change DSOLocalEquivalent type if the underlying global value type changes.
Mar 8 2021, 11:18 AM · Restricted Project

Mar 5 2021

leonardchan updated the diff for D97978: [llvm] Change DSOLocalEquivalent type if the underlying global value type changes.

@dexonsmith @mehdi_amini Would you be the right folks to add for reviews on ValueMapper?

Mar 5 2021, 4:10 PM · Restricted Project
leonardchan added a comment to D97978: [llvm] Change DSOLocalEquivalent type if the underlying global value type changes.

Is it feasible to cover this by a test?

Mar 5 2021, 3:39 PM · Restricted Project
leonardchan accepted D98018: [Fuchsia] Enable Polly for first stage as well.
Mar 5 2021, 10:36 AM · Restricted Project

Mar 4 2021

leonardchan requested review of D97978: [llvm] Change DSOLocalEquivalent type if the underlying global value type changes.
Mar 4 2021, 1:51 PM · Restricted Project

Mar 2 2021

leonardchan accepted D97819: [CMake] Enable Polly for Fuchsia toolchain build.
Mar 2 2021, 4:47 PM · Restricted Project

Mar 1 2021

leonardchan added a comment to D95204: [lld-macho] Switch default to new Darwin backend.

Hi, I suspect thispatch might be causing the failure we're seeing in our non-mac builders (https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-x64/b8853941557626730880?):

Mar 1 2021, 10:47 AM · Restricted Project, Restricted Project, Restricted Project

Feb 26 2021

leonardchan committed rGbed888242662: [scudo][test] Disable -Wfree-nonheap-object (authored by leonardchan).
[scudo][test] Disable -Wfree-nonheap-object
Feb 26 2021, 11:15 AM
leonardchan closed D97516: [scudo][test] Disable -Wfree-nonheap-object.
Feb 26 2021, 11:15 AM · Restricted Project

Feb 25 2021

leonardchan updated the diff for D97516: [scudo][test] Disable -Wfree-nonheap-object.
Feb 25 2021, 5:47 PM · Restricted Project
leonardchan requested review of D97516: [scudo][test] Disable -Wfree-nonheap-object.
Feb 25 2021, 5:46 PM · Restricted Project

Feb 22 2021

leonardchan committed rG1c932baeaafb: [llvm][Bitcode] Add bitcode reader/writer for DSOLocalEquivalent (authored by leonardchan).
[llvm][Bitcode] Add bitcode reader/writer for DSOLocalEquivalent
Feb 22 2021, 10:39 AM
leonardchan closed D96170: [llvm][Bitcode] Add bitcode reader/writer for DSOLocalEquivalent.
Feb 22 2021, 10:39 AM · Restricted Project

Feb 19 2021

leonardchan added a comment to D96780: [NPM][LTO] Update buildLTODefaultPipeline to be more in-line with the old pass manager.

I've committed c141c6551be64f220b71786d24e98f6de906e6de in an attempt to fix the similar problem I was seeing here. Please let me know if it helps or doesn't in the Fuchsia build.

Feb 19 2021, 10:27 AM · Restricted Project

Feb 18 2021

leonardchan committed rGc77659e5494e: [llvm][IR] Do not place constants with static relocations in a mergeable section (authored by leonardchan).
[llvm][IR] Do not place constants with static relocations in a mergeable section
Feb 18 2021, 3:40 PM
leonardchan closed D95960: [llvm][IR] Do not place constants with static relocations in a mergeable section.
Feb 18 2021, 3:39 PM · Restricted Project
leonardchan added a comment to D94355: [Passes] Add relative lookup table converter pass.

It looks like you have everything setup for running on the new PM, but it doesn't look like the pass is added anywhere in the new PM pipeline. Unfortunately, I don't *think* there's anything in the new PM that acts as a "default pipeline that gets added to all other pipelines" similar to PassManagerBuilder::populateModulePassManager, so we'll need to manually include this somewhere in PassBuilder::buildO0DefaultPipeline and PassBuilder::buildPerModuleDefaultPipeline.

Feb 18 2021, 12:35 PM · Restricted Project, Restricted Project

Feb 16 2021

leonardchan added a comment to D96170: [llvm][Bitcode] Add bitcode reader/writer for DSOLocalEquivalent.

I've never patched the bitcode reader/writer before, I think, but from similar patches I've seen, this look good to me. Is there any sort of registration you're supposed to do of the new code?

Hmm. By registration, do you mean making cmake aware of the new test? I don't *think* there's anything else I may need to change. I mainly just copied similar logic from how the other constant codes are handled.

Adding @rnk who may have more familiarity.

Some of the other serializers using bitcode require some of the codes to be registered, either as abbreviations or just for incidental reasons. If there's nothing like that for similar record codes, though, it's probably not a thing for BC.

Feb 16 2021, 4:52 PM · Restricted Project
leonardchan added a reviewer for D96170: [llvm][Bitcode] Add bitcode reader/writer for DSOLocalEquivalent: rnk.
Feb 16 2021, 3:27 PM · Restricted Project
leonardchan updated subscribers of D96170: [llvm][Bitcode] Add bitcode reader/writer for DSOLocalEquivalent.

I've never patched the bitcode reader/writer before, I think, but from similar patches I've seen, this look good to me. Is there any sort of registration you're supposed to do of the new code?

Feb 16 2021, 3:27 PM · Restricted Project
leonardchan added a comment to D95960: [llvm][IR] Do not place constants with static relocations in a mergeable section.
In D95960#2566681, @pcc wrote:

I think you will need to s/needsRelocation/needsDynamicRelocation/g throughout the rest of the codebase.

Feb 16 2021, 3:14 PM · Restricted Project
leonardchan updated the diff for D95960: [llvm][IR] Do not place constants with static relocations in a mergeable section.
Feb 16 2021, 3:12 PM · Restricted Project

Feb 12 2021

leonardchan added a comment to D96170: [llvm][Bitcode] Add bitcode reader/writer for DSOLocalEquivalent.

*ping* Any comments for this patch? I believe these are mostly mechanical changes that were left out of the original DSOLocalEquivalent patch.

Feb 12 2021, 4:06 PM · Restricted Project

Feb 10 2021

leonardchan updated the diff for D95960: [llvm][IR] Do not place constants with static relocations in a mergeable section.

Updated to remove needsStaticRelocation.

Feb 10 2021, 10:22 AM · Restricted Project

Feb 9 2021

leonardchan added a comment to D82703: [InstCombine] convert assumes to operand bundles.

Hi. I suspect this patch might be causing this test failure we're seeing on our builders (https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-x64/b8855749711840653472?):

Feb 9 2021, 1:18 PM · Restricted Project

Feb 8 2021

leonardchan added a reviewer for D96170: [llvm][Bitcode] Add bitcode reader/writer for DSOLocalEquivalent: phosek.
Feb 8 2021, 2:44 PM · Restricted Project
leonardchan added a comment to rG0fc1738eb75d: [Test] Add failing test for PR49087.

Hi. This test seems to be failing on our clang builder (https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-arm64/b8855886813666955488?):

Feb 8 2021, 9:41 AM

Feb 5 2021

leonardchan requested review of D96170: [llvm][Bitcode] Add bitcode reader/writer for DSOLocalEquivalent.
Feb 5 2021, 12:27 PM · Restricted Project

Feb 3 2021

leonardchan updated the diff for D95960: [llvm][IR] Do not place constants with static relocations in a mergeable section.
Feb 3 2021, 2:19 PM · Restricted Project
leonardchan requested review of D95960: [llvm][IR] Do not place constants with static relocations in a mergeable section.
Feb 3 2021, 10:25 AM · Restricted Project

Feb 1 2021

leonardchan updated the summary of D95694: [clang][RelativeVTablesABI] Place non-local vtables in comdat groups.
Feb 1 2021, 12:00 PM · Restricted Project

Jan 29 2021

leonardchan requested review of D95694: [clang][RelativeVTablesABI] Place non-local vtables in comdat groups.
Jan 29 2021, 12:10 PM · Restricted Project

Jan 26 2021

leonardchan accepted D95479: [clang-format] Avoid considering include directive as a template closer..

LGTM. Confirmed on our end this fixes our issue. Thanks for addressing this!

Jan 26 2021, 1:36 PM · Restricted Project
leonardchan added a comment to D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates.

That's definitely an unintended behaviour. Please file a bug and possibly mark it as release blocker for LLVM 12. Either a fix will be there soon, or we'll revert.

FYI, simple reproduce:

verifyFormat("#include <stdint.h>\n"
             "namespace rep {}",
             Style);

The problem doesn't happen with #include "stdint.h".

Jan 26 2021, 1:18 PM · Restricted Project, Restricted Project
leonardchan added a comment to D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates.

Hi. Up until this point, we've noticed that this patch can produce different formatted files depending on amount of whitespace. For example, given (A):

Jan 26 2021, 10:48 AM · Restricted Project, Restricted Project

Jan 25 2021

leonardchan committed rGc0e94e997473: [clang][Fuchsia] Add relative-vtables + asan multilibs (authored by leonardchan).
[clang][Fuchsia] Add relative-vtables + asan multilibs
Jan 25 2021, 3:25 PM
leonardchan closed D95253: [clang][Fuchsia] Add relative-vtables + asan multilibs.
Jan 25 2021, 3:25 PM · Restricted Project

Jan 22 2021

leonardchan requested review of D95253: [clang][Fuchsia] Add relative-vtables + asan multilibs.
Jan 22 2021, 11:23 AM · Restricted Project
leonardchan added a comment to D94355: [Passes] Add relative lookup table converter pass.

Almost there! Just a few more comments on my end.

Jan 22 2021, 10:52 AM · Restricted Project, Restricted Project

Jan 21 2021

leonardchan added a comment to rGd38be2ba0e4e: [llvm-mca] Initial implementation of serialization using JSON. The views.

Hi. It seems this commit is causing this failure on our aarch64 bulder (https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-arm64/b8857452110716658368):

Jan 21 2021, 4:29 PM
leonardchan requested review of D95182: [clang][Fuchsia] Turn on Relative VTables for Fuchsia.
Jan 21 2021, 3:54 PM · Restricted Project
leonardchan updated the summary of D95154: [WIP][clang][Fuchsia] Add the *-fuchsia-gnu arch and multilibs.
Jan 21 2021, 11:21 AM · Restricted Project
leonardchan requested review of D95154: [WIP][clang][Fuchsia] Add the *-fuchsia-gnu arch and multilibs.
Jan 21 2021, 11:21 AM · Restricted Project

Jan 20 2021

leonardchan added a comment to D93668: [clang] Override the Fuchsia platform ABI using the triple environment.

Also, this probably isn't very important, but just as a heads up: if we were to depend on the environment component in the triple as the flag for selecting which multilib to use, then the multilib would be stored in a directory containing that environment.

Jan 20 2021, 11:17 AM · Restricted Project

Jan 19 2021

leonardchan added a comment to D93668: [clang] Override the Fuchsia platform ABI using the triple environment.

I agree that if we want to allow selecting C++ ABI only, a flag like -fc++abi= with some additional checks to disallow invalid combinations is better. The question is whether we want to allow that in the first place? The motivation behind this change is to support generating code that's ABI compatible with the code generated by GCC. That could be expressed using the target triple (one idea is to use *-*-fuchsia-gnu), which would cover both C++ ABI as well as other aspects of the ABI (for example it could also disable SafeStack/ShadowCallStack) so developers don't need to concern themselves with all the details of the ABI, which could evolve over time expanding the set of flags you'd need to pass to the compiler to generate code that's ABI compatible with GCC.

Jan 19 2021, 11:40 AM · Restricted Project

Jan 15 2021

leonardchan added a comment to D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia.
In D91466#2395297, @pcc wrote:

How does Zircon handle tagged addresses in syscalls? Are they handled equivalently to Linux's tagged address ABI?

Jan 15 2021, 5:13 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan updated the diff for D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia.

Locally I'm able to build and run the bringup.arm64 config (that is launch the shell and run some commands).

Jan 15 2021, 5:09 PM · Restricted Project, Restricted Project, Restricted Project

Jan 14 2021

leonardchan added a comment to D94355: [Passes] Add relative lookup table converter pass.

Looking good. Just a few more comments on my end.

Jan 14 2021, 11:07 AM · Restricted Project, Restricted Project

Jan 12 2021

leonardchan added inline comments to D94355: [Passes] Add relative lookup table converter pass.
Jan 12 2021, 10:09 AM · Restricted Project, Restricted Project

Jan 11 2021

leonardchan updated the diff for D93668: [clang] Override the Fuchsia platform ABI using the triple environment.
Jan 11 2021, 3:31 PM · Restricted Project
leonardchan added inline comments to D94355: [Passes] Add relative lookup table converter pass.
Jan 11 2021, 11:29 AM · Restricted Project, Restricted Project

Jan 7 2021

leonardchan added a comment to D93668: [clang] Override the Fuchsia platform ABI using the triple environment.

I'd prefer to use the target triple rather than introducing a custom flag.

With dedicated flags, you might eventually end up in a similar situation as D85802, that is in the extreme case you might end up with -f[no-]fuchsia-c++-abi, -f[no-]webassembly-c++-abi, etc. which is not any better than -fc++-abi=.

With target triple, I can imagine using either <arch>-unknown-fuchsia-itanium or <arch>-unknown-fuchsia-gnu, where the former would mean targeting Fuchsia with Itanium C++ ABI while the latter would mean using GCC compatible ABI (which would imply Itanium C++ ABI). Both of these are already used by MinGW for the same purpose so there's a precedent and we don't need to invent anything new.

Jan 7 2021, 1:11 PM · Restricted Project

Dec 21 2020

leonardchan requested review of D93668: [clang] Override the Fuchsia platform ABI using the triple environment.
Dec 21 2020, 3:36 PM · Restricted Project

Dec 7 2020

leonardchan closed D92141: Fix noderef for AddrOf on MemberExpr.

Ok this time I remembered the email. Unsure why the bug isn't automatically closed though.

Dec 7 2020, 2:51 PM · Restricted Project
leonardchan committed rG6dad7ec539cb: [clang] Fix noderef for AddrOf on MemberExpr (authored by thejh).
[clang] Fix noderef for AddrOf on MemberExpr
Dec 7 2020, 2:50 PM
leonardchan closed D92140: Fix noderef for array member of deref expr.

Committed in 155fca3cae275562e626d3e4fbfac70b4b75d2e7. (Sorry, I forgot to change the author email in the commit)

Dec 7 2020, 2:42 PM · Restricted Project
leonardchan committed rG155fca3cae27: [clang] Fix noderef for array member of deref expr (authored by leonardchan).
[clang] Fix noderef for array member of deref expr
Dec 7 2020, 2:40 PM
leonardchan added a comment to D92140: Fix noderef for array member of deref expr.

Sorry. I accidentally missed this in my emails. Will commit these.

Dec 7 2020, 2:14 PM · Restricted Project

Dec 1 2020

leonardchan accepted D92442: [lsan] Use final on Fuchsia ThreadContext declaration.
Dec 1 2020, 6:40 PM · Restricted Project
leonardchan committed rG1e91803c671a: Recommit "[clang][Fuchsia] Add relative-vtables multilib" (authored by leonardchan).
Recommit "[clang][Fuchsia] Add relative-vtables multilib"
Dec 1 2020, 5:03 PM
leonardchan committed rG19bdc8e5a307: [llvm] Fix for failing test from fdbd84c6c819d4462546961f6086c1524d5d5ae8 (authored by leonardchan).
[llvm] Fix for failing test from fdbd84c6c819d4462546961f6086c1524d5d5ae8
Dec 1 2020, 3:48 PM

Nov 30 2020

leonardchan added a reverting change for rGfdbd84c6c819: [clang][Fuchsia] Add relative-vtables multilib: rG7bc944c102c2: Revert "[clang][Fuchsia] Add relative-vtables multilib".
Nov 30 2020, 7:23 PM
leonardchan committed rG7bc944c102c2: Revert "[clang][Fuchsia] Add relative-vtables multilib" (authored by leonardchan).
Revert "[clang][Fuchsia] Add relative-vtables multilib"
Nov 30 2020, 7:22 PM
leonardchan added a reverting change for D85576: [clang][Fuchsia] Add relative-vtables multilib: rG7bc944c102c2: Revert "[clang][Fuchsia] Add relative-vtables multilib".
Nov 30 2020, 7:22 PM · Restricted Project
leonardchan committed rGfdbd84c6c819: [clang][Fuchsia] Add relative-vtables multilib (authored by leonardchan).
[clang][Fuchsia] Add relative-vtables multilib
Nov 30 2020, 6:22 PM