Page MenuHomePhabricator
Feed Advanced Search

Mon, Jun 29

leonardchan committed rGde172dd17f03: [clang][RelativeVTablesABI] Update CodeGenCXX/RelativeVTablesABI/dynamic-cast. (authored by leonardchan).
[clang][RelativeVTablesABI] Update CodeGenCXX/RelativeVTablesABI/dynamic-cast.
Mon, Jun 29, 1:36 PM
leonardchan closed D82802: [clang][RelativeVTablesABI] Update CodeGenCXX/RelativeVTablesABI/dynamic-cast.cpp.
Mon, Jun 29, 1:36 PM · Restricted Project
leonardchan created D82802: [clang][RelativeVTablesABI] Update CodeGenCXX/RelativeVTablesABI/dynamic-cast.cpp.
Mon, Jun 29, 1:01 PM · Restricted Project

Fri, Jun 26

leonardchan accepted D82662: [CodeGen] Use the common semantic for fixed-point codegen, not the result semantic..

LGTM. Thanks for the fix.

Fri, Jun 26, 10:55 AM · Restricted Project

Thu, Jun 25

leonardchan accepted D73186: [AST] Add fixed-point multiplication constant evaluation..

LGTM

Thu, Jun 25, 10:46 AM · Restricted Project

Tue, Jun 23

leonardchan committed rG723b5a178542: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation (authored by leonardchan).
[lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation
Tue, Jun 23, 4:12 PM
leonardchan closed D81184: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.
Tue, Jun 23, 4:12 PM · Restricted Project
leonardchan updated the diff for D81184: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.
Tue, Jun 23, 4:11 PM · Restricted Project
leonardchan added inline comments to D81184: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.
Tue, Jun 23, 12:21 PM · Restricted Project
leonardchan updated the diff for D81184: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.
Tue, Jun 23, 12:21 PM · Restricted Project

Mon, Jun 22

leonardchan added a comment to D81184: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.

Looking good so far. Would be good to add a range extension thunk test case. For example:

 .section .text.1, "ax", %progbits
 .global _start
 .type _start, %function
_start: .word callee@PLT - .

 .section .text.2, "ax", %progbits
 .global callee
 .type callee, %function        
callee: ret

Using a linker script to get a > 4gb gap. The AT is there to stop a multi gigabyte file being written.

SECTIONS {
  .text.1 0x10000 : { *(.text.1) }
  .text.2 0x200000000 : AT(0x20000) { *(.text.2) }
}

The .word should be an offset to the range extension thunk instead of the target.

Mon, Jun 22, 3:03 PM · Restricted Project
leonardchan updated the diff for D81184: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.
Mon, Jun 22, 3:03 PM · Restricted Project

Thu, Jun 11

leonardchan updated the diff for D81184: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.

Rebased and updated tests with assembly instead of yaml.

Thu, Jun 11, 1:13 PM · Restricted Project
leonardchan committed rG71568a9e28d6: [clang] Frontend components for the relative vtables ABI (round 2) (authored by leonardchan).
[clang] Frontend components for the relative vtables ABI (round 2)
Thu, Jun 11, 11:33 AM

Wed, Jun 10

leonardchan committed rG7201272d4c1b: Revert "[clang] Frontend components for the relative vtables ABI" (authored by leonardchan).
Revert "[clang] Frontend components for the relative vtables ABI"
Wed, Jun 10, 1:56 PM
leonardchan added a reverting change for rG2e009dbcb3e3: [clang] Frontend components for the relative vtables ABI: rG7201272d4c1b: Revert "[clang] Frontend components for the relative vtables ABI".
Wed, Jun 10, 1:56 PM
leonardchan committed rG2e009dbcb3e3: [clang] Frontend components for the relative vtables ABI (authored by leonardchan).
[clang] Frontend components for the relative vtables ABI
Wed, Jun 10, 12:50 PM
leonardchan closed D77592: [clang] Frontend components for the relative vtables ABI.
Wed, Jun 10, 12:49 PM · Restricted Project
leonardchan committed rG2f6bb2a69215: [clang][Attribute] Fix noderef attribute false-negatives (authored by leonardchan).
[clang][Attribute] Fix noderef attribute false-negatives
Wed, Jun 10, 12:49 PM
leonardchan closed D77836: [Attribute] Fix noderef attribute false-negatives.
Wed, Jun 10, 12:49 PM · Restricted Project
leonardchan accepted D81514: [Fuchsia] Set projects and runtimes in the cache file.
Wed, Jun 10, 12:13 PM · Restricted Project
leonardchan committed rG6adc664b9dfe: [llvm][ELF][AArch64] Handle R_AARCH64_PLT32 relocation (authored by leonardchan).
[llvm][ELF][AArch64] Handle R_AARCH64_PLT32 relocation
Wed, Jun 10, 11:46 AM
leonardchan closed D81446: [llvm][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.
Wed, Jun 10, 11:46 AM · Restricted Project

Tue, Jun 9

leonardchan updated the diff for D81446: [llvm][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.
Tue, Jun 9, 2:21 PM · Restricted Project
leonardchan added inline comments to D81446: [llvm][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.
Tue, Jun 9, 2:21 PM · Restricted Project
leonardchan added reviewers for D77592: [clang] Frontend components for the relative vtables ABI: phosek, mcgrathr.
Tue, Jun 9, 1:14 PM · Restricted Project
leonardchan added a comment to D77836: [Attribute] Fix noderef attribute false-negatives.

Lemme know if there's any more feedback. Will aim for committing this sometime at the end of the day.

Tue, Jun 9, 12:40 PM · Restricted Project

Mon, Jun 8

leonardchan created D81446: [llvm][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.
Mon, Jun 8, 7:55 PM · Restricted Project
leonardchan added a comment to D81184: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.

D81446 is the LLVM counterpart.

Mon, Jun 8, 7:55 PM · Restricted Project
leonardchan added a reviewer for D81184: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation: psmith.
Mon, Jun 8, 7:55 PM · Restricted Project
leonardchan updated the diff for D81184: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.
  • Removed the llvm changes to be moved to a separate patch.
  • Added a test for checking the relocation used with an undefined weak symbol. IIRC, the behavior of this is unspecified anyway.
  • Added test for checking overflow.
Mon, Jun 8, 7:55 PM · Restricted Project
leonardchan accepted D81323: Move *San module passes later in the NPM pipeline.
Mon, Jun 8, 11:35 AM · Restricted Project

Jun 4 2020

leonardchan added reviewers for D81184: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation: peter.smith, mcgrathr, phosek, pcc.
Jun 4 2020, 12:09 PM · Restricted Project
leonardchan planned changes to D81184: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.
Jun 4 2020, 12:09 PM · Restricted Project
leonardchan created D81184: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation.
Jun 4 2020, 12:09 PM · Restricted Project

Jun 1 2020

leonardchan added a comment to D77592: [clang] Frontend components for the relative vtables ABI.

@rjmccall Would it be fine to submit this since you gave LGTM on D72959?

Jun 1 2020, 3:11 PM · Restricted Project
leonardchan updated the diff for D77836: [Attribute] Fix noderef attribute false-negatives.

Rebased

Jun 1 2020, 11:52 AM · Restricted Project

May 29 2020

leonardchan added a comment to D80452: [libc++] Complete overhaul of constexpr support in std::array.

Hi! I think this patch might be the cause of the bug at https://bugs.llvm.org/show_bug.cgi?id=46137.

Essentially, we get an error when attempting to create std::array<S, 0> if S has a non-trivial destructor (full example at the bug link):

test.cc:20:20: error: call to implicitly-deleted default constructor of 'std::array<S, 0>'
  std::array<S, 0> x;  // bad
                   ^
/usr/local/google/home/leonardchan/llvm-monorepo/llvm-build-1-master-fuchsia-toolchain/install/bin/../include/c++/v1/array:252:7: note: default constructor of 'array<S, 0>' is implicitly deleted because field '__w' has a deleted destructor
    } __w;
      ^
/usr/local/google/home/leonardchan/llvm-monorepo/llvm-build-1-master-fuchsia-toolchain/install/bin/../include/c++/v1/array:248:9: note: explicitly defaulted function was implicitly deleted here
        ~__wrapper() = default;
        ^
/usr/local/google/home/leonardchan/llvm-monorepo/llvm-build-1-master-fuchsia-toolchain/install/bin/../include/c++/v1/array:251:13: note: destructor of '__wrapper' is implicitly deleted because variant field '__t' has a non-trivial destructor
        _Tp __t;
            ^
test.cc:20:20: error: attempt to use a deleted function
  std::array<S, 0> x;  // bad
                   ^

I believe std::arrays of size 0 should be legal regardless of constraints on the element type.

May 29 2020, 4:25 PM · Restricted Project
leonardchan added a comment to D80452: [libc++] Complete overhaul of constexpr support in std::array.

Hi! I think this patch might be the cause of the bug at https://bugs.llvm.org/show_bug.cgi?id=46137.

May 29 2020, 4:25 PM · Restricted Project

May 28 2020

leonardchan accepted D80692: Run Coverage pass before other *San passes under new pass manager, round 2.

I foolishly submitted without running check-all, and it turns out this broke a test under check-clang.
Looks like https://reviews.llvm.org/D62888 added tests in sancov-new-pm.c to make sure that sancov + LTO work together, but they won't after this change since the (Thin)LTO pipeline doesn't run things under registerOptimizerLastEPCallback(). So I deleted those tests. Other sanitizers don't work under LTO right now (at least for non-O0) because of the same thing. Does this make sense?

May 28 2020, 4:32 PM · Restricted Project, Restricted Project
leonardchan accepted D80692: Run Coverage pass before other *San passes under new pass manager, round 2.

Would be worthwhile to write a small test that asserts Sancov runs before the other sanitizers under the new PM?

May 28 2020, 1:13 PM · Restricted Project, Restricted Project
leonardchan added a comment to D77836: [Attribute] Fix noderef attribute false-negatives.

*ping*

May 28 2020, 12:38 PM · Restricted Project
leonardchan added inline comments to D80692: Run Coverage pass before other *San passes under new pass manager, round 2.
May 28 2020, 11:33 AM · Restricted Project, Restricted Project

May 27 2020

leonardchan updated the diff for D77592: [clang] Frontend components for the relative vtables ABI.

I decided to just include all the frontend changes here since most of them are tightly coupled. If this patch should be split up more, I don't mind splitting it again.

May 27 2020, 4:56 PM · Restricted Project
leonardchan committed rGef3744405855: [Lexer] Fix invalid suffix diagnostic for fixed-point literals (authored by leonardchan).
[Lexer] Fix invalid suffix diagnostic for fixed-point literals
May 27 2020, 4:24 PM
leonardchan closed D80412: Summary: [Lexer] Fix invalid suffix diagnostic for fixed-point literals.
May 27 2020, 4:24 PM · Restricted Project
leonardchan added a comment to D80412: Summary: [Lexer] Fix invalid suffix diagnostic for fixed-point literals.

I don't have commit access. Could any one please help to commit this patch.
Thanks in advance.

May 27 2020, 4:23 PM · Restricted Project

May 26 2020

leonardchan accepted D80467: [GlobalISel][InlineAsm] Add missing EarlyClobber flag to inline asm output operands.

LGTM. Confirmed the test passes after this and the correct assembly is generated. Thanks for the fix!

May 26 2020, 1:05 PM · Restricted Project
leonardchan accepted D80412: Summary: [Lexer] Fix invalid suffix diagnostic for fixed-point literals.

LGTM. Thanks for fixing this!

May 26 2020, 11:58 AM · Restricted Project

May 21 2020

leonardchan added a comment to D79955: [GlobalISel][InlineAsm] Add early return for memory inputs that need to be indirectified.

Hi! I believe commits 5425cdc3adf9998aeaf587d93417bd2f4f1373c9 and 91063cf85a4038537731f582a27936187fb0759c lead to the crash we're seeing in https://bugs.llvm.org/show_bug.cgi?id=46028.

May 21 2020, 4:48 PM · Restricted Project

May 20 2020

leonardchan updated the diff for D72959: Relative VTables ABI on Fuchsia.

Calculate the address points once beforehand such that we can get an address point from a vtable index.

May 20 2020, 2:18 PM · Restricted Project, Restricted Project, Restricted Project

May 18 2020

leonardchan added inline comments to D72959: Relative VTables ABI on Fuchsia.
May 18 2020, 11:54 AM · Restricted Project, Restricted Project, Restricted Project
leonardchan updated the diff for D72959: Relative VTables ABI on Fuchsia.

Evidently I left a lot of spelling mistakes and leftover comments. Cleaned them up!

May 18 2020, 11:54 AM · Restricted Project, Restricted Project, Restricted Project

May 14 2020

leonardchan committed rG592303a53e6b: [Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain (authored by leonardchan).
[Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain
May 14 2020, 5:26 PM
leonardchan closed D79974: [Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain.
May 14 2020, 5:26 PM · Restricted Project
leonardchan created D79974: [Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain.
May 14 2020, 4:21 PM · Restricted Project
leonardchan committed rGe9802aa4221b: Revert "Run Coverage pass before other *San passes under new pass manager" (authored by leonardchan).
Revert "Run Coverage pass before other *San passes under new pass manager"
May 14 2020, 3:49 PM
leonardchan added a reverting change for rG7d5bb94d7838: Run Coverage pass before other *San passes under new pass manager: rGe9802aa4221b: Revert "Run Coverage pass before other *San passes under new pass manager".
May 14 2020, 3:49 PM
leonardchan added a comment to D79698: Run Coverage pass before other *San passes under new pass manager.

Just to followup on this: We believe the root cause of the error we're running into is that some sancov guards in one comdat are being referenced by symbols in another comdat, so due to linking order, the other comdat in question is referencing a sancov guard that was in a discarded comdat group. I posted full details of this on llvm-dev. We believe we're running into this error now because with this patch, inlining occurs after the sanitizers are run.

Based on some discussion in http://lists.llvm.org/pipermail/llvm-dev/2020-May/141558.html, it seems appropriate that the solution for this is to just run sanitizers after inlining, so we would avoid this error that's brought about by inlining after sanitizer runs. Since this has been breaking us for a few days, and unless other folks don't mind, I'm thinking it might be appropriate to temporarily revert this until there's a fix for either

Maybe the fix is to use registerScalarOptimizerLateEPCallback() instead of registerPipelineStartEPCallback(). But I'm not sure how to test that, could you try that and lmk if that fixes the issue?

May 14 2020, 3:47 PM · Restricted Project
leonardchan added a comment to D79822: [AArch64] Emit CFI instruction for updating x18 when using ShadowCallStack with exception unwinding.

@pcc Do you happen to have a list of platforms that you suspect use libgcc and will break with this CFI? If this is a bug compatibility issue, we're thinking that instead of just disabling this for everyone, we should instead disable it for a blacklisted set of targets. So all targets by default would go through this branch except for those that actively crash from this.

May 14 2020, 2:41 PM · Restricted Project
leonardchan added a comment to D79698: Run Coverage pass before other *San passes under new pass manager.

Just to followup on this: We believe the root cause of the error we're running into is that some sancov guards in one comdat are being referenced by symbols in another comdat, so due to linking order, the other comdat in question is referencing a sancov guard that was in a discarded comdat group. I posted full details of this on llvm-dev. We believe we're running into this error now because with this patch, inlining occurs after the sanitizers are run.

May 14 2020, 2:41 PM · Restricted Project
leonardchan added a comment to D79042: [llvm] Add interface to drive inlining decision using ML model.

Hello, a bisect seems to show this breaks our 2 stage toolchain build from assertion errors:

May 14 2020, 1:36 PM · Restricted Project

May 12 2020

leonardchan created D79822: [AArch64] Emit CFI instruction for updating x18 when using ShadowCallStack with exception unwinding.
May 12 2020, 4:11 PM · Restricted Project
leonardchan added a comment to D79698: Run Coverage pass before other *San passes under new pass manager.

This patch seems to lead to the undefined symbol error we're seeing when building fuchsia:

May 12 2020, 1:59 PM · Restricted Project

May 11 2020

leonardchan accepted D79698: Run Coverage pass before other *San passes under new pass manager.

LGTM

May 11 2020, 11:50 AM · Restricted Project

May 6 2020

leonardchan added a comment to D79445: [MSan] Pass MSan command line options under new pass manager.

In addSanitizersAtO0, could you make something similar to the ASanPass lambda for the MSan passes and also apply it when adding kernel MSan?

It ends up calling an extra MPM.addPass(createModuleToFunctionPassAdaptor()) in the KernelMemory case, is that okay?

May 6 2020, 9:40 AM · Restricted Project

May 5 2020

leonardchan accepted D79445: [MSan] Pass MSan command line options under new pass manager.

In addSanitizersAtO0, could you make something similar to the ASanPass lambda for the MSan passes and also apply it when adding kernel MSan?

May 5 2020, 2:36 PM · Restricted Project

May 4 2020

leonardchan updated the diff for D72959: Relative VTables ABI on Fuchsia.

Updated to use builders for constructing the vtable in "leaf" functions instead of returning a value and propagating it back up to a builder. Also extended ConstantAggregateBuilderBase with a method to add a relative offset to a specific position in the aggregate being constructed.

May 4 2020, 12:53 PM · Restricted Project, Restricted Project, Restricted Project

May 1 2020

leonardchan added inline comments to D77836: [Attribute] Fix noderef attribute false-negatives.
May 1 2020, 5:11 PM · Restricted Project
leonardchan updated the diff for D77836: [Attribute] Fix noderef attribute false-negatives.
May 1 2020, 5:11 PM · Restricted Project

Apr 27 2020

leonardchan added inline comments to D72959: Relative VTables ABI on Fuchsia.
Apr 27 2020, 7:56 PM · Restricted Project, Restricted Project, Restricted Project

Apr 24 2020

leonardchan added inline comments to D72959: Relative VTables ABI on Fuchsia.
Apr 24 2020, 11:20 AM · Restricted Project, Restricted Project, Restricted Project
leonardchan added a comment to D77592: [clang] Frontend components for the relative vtables ABI.

Okay. The plan sounds good to me. So you want to roll out this enum in this patch, but not really use it for much until the follow-up?

Apr 24 2020, 10:49 AM · Restricted Project

Apr 23 2020

leonardchan updated the diff for D77592: [clang] Frontend components for the relative vtables ABI.

Updated to reflect the changes in D72959 which make the vtable 4-byte aligned under the Relative layout.

Apr 23 2020, 9:43 AM · Restricted Project
leonardchan updated the diff for D72959: Relative VTables ABI on Fuchsia.
  • Remove fuchsia pair from the argument and LangOpt.
  • Make the virtual base offset and offset to top 32-bits to make the whole vtable 32-bit aligned.
  • Introduce and check against the ItaniumVTableContext::VTableComponentLayout enum which will indicate that vtable components should be relative instead of pointers. Use this instead of making overridable virtual methods in ABI classes since this shouldn't be customized between ABIs.
  • Update tests.
Apr 23 2020, 9:11 AM · Restricted Project, Restricted Project, Restricted Project

Apr 17 2020

leonardchan added a comment to D77592: [clang] Frontend components for the relative vtables ABI.

Okay, sure, if there are already offsets in bytes already in the AST-level layout, I agree that we should be able to compute all of the byte offsets at that level.

How are you planning to handle alignments here? Currently alignment doesn't affect the layout because all the entries are uniformly pointer-sized. If you're planning to make the offset-to-top and vcall offsets 64-bit on 64-bit architectures, you're going to either have interior padding or those offsets might not be naturally-aligned.

Personally, I would just use 32-bit offsets unless you really think you need to support types with base adjustments more than ±2GB. And that has the nice impact of making all the offsets within the v-table uniformly scaled again, just by 4 bytes instead of the pointer size.

Apr 17 2020, 3:47 PM · Restricted Project

Apr 16 2020

leonardchan added a comment to D77592: [clang] Frontend components for the relative vtables ABI.

I'm not sure if the AST-level v-table layout abstraction really cares about these differences. I don't think it vends byte offsets into the v-table, just slot indices (i.e. word offsets).

Apr 16 2020, 2:31 PM · Restricted Project
leonardchan accepted D78294: [Fixed Point] Move the compassign LHS type correction a bit further down. NFCI..

LGTM

Apr 16 2020, 11:45 AM · Restricted Project

Apr 15 2020

leonardchan updated the diff for D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches.
Apr 15 2020, 12:36 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D77592: [clang] Frontend components for the relative vtables ABI.

I'm not sure how to test it yet without adding all the mechanisms for actually laying out the components, but at the very least this adds the switch for it.

Apr 15 2020, 12:03 PM · Restricted Project

Apr 14 2020

leonardchan updated the diff for D77836: [Attribute] Fix noderef attribute false-negatives.

Rebased

Apr 14 2020, 11:50 AM · Restricted Project

Apr 13 2020

leonardchan updated the diff for D77836: [Attribute] Fix noderef attribute false-negatives.

Updated to address comments and added an RAII class for easier checking before exiting functions.

Apr 13 2020, 4:52 PM · Restricted Project
leonardchan added inline comments to D77836: [Attribute] Fix noderef attribute false-negatives.
Apr 13 2020, 4:52 PM · Restricted Project
leonardchan added a comment to D77592: [clang] Frontend components for the relative vtables ABI.

This is a global switch, right, not something that's mix-and-match between hierarchies or even between classes? I think I would prefer that the ABI object just tell us the expected layout of a v-table entry (as an enum) rather than forcing a bunch of different callbacks. Seems more composable, among other things.

Apr 13 2020, 3:47 PM · Restricted Project
leonardchan added inline comments to D77836: [Attribute] Fix noderef attribute false-negatives.
Apr 13 2020, 1:35 PM · Restricted Project
leonardchan added a comment to D77592: [clang] Frontend components for the relative vtables ABI.

This is a weird point to allow further ABI customization of. I understand why you want to customize this, but I wonder if it's actually worthwhile to make a virtual function for it vs. just checking some sort of flag in the builder. Isn't there quite a lot of structure you're going to have to duplicate just to call addRelativeAddress at the leaves?

Apr 13 2020, 1:34 PM · Restricted Project

Apr 9 2020

leonardchan created D77836: [Attribute] Fix noderef attribute false-negatives.
Apr 9 2020, 3:48 PM · Restricted Project

Apr 8 2020

leonardchan added a comment to D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals..

https://reviews.llvm.org/D77721 depends on this serialization change for fixed point literals.

Apr 8 2020, 11:24 AM · Restricted Project

Apr 7 2020

leonardchan updated the diff for D72959: Relative VTables ABI on Fuchsia.

Updated such that this ABI is only usable on Fuchsia and if -fexperimental-fuchsia-relative-c++-abi-vtables is passed.

Apr 7 2020, 9:46 PM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2020

leonardchan added a comment to D77248: [IR] Strip constant inbound GEPs when checking Constant::needsRelocation().

*ping*

Apr 6 2020, 4:54 PM · Restricted Project
leonardchan created D77606: [WIP][libcxxabi] Add macro for changing functions to support the relative vtables ABI.
Apr 6 2020, 4:22 PM · Restricted Project
leonardchan planned changes to D77606: [WIP][libcxxabi] Add macro for changing functions to support the relative vtables ABI.

Marking WIP for now since (I think for testing), this will require some separate clang changes first.

Apr 6 2020, 4:22 PM · Restricted Project
leonardchan created D77592: [clang] Frontend components for the relative vtables ABI.
Apr 6 2020, 3:16 PM · Restricted Project
leonardchan committed rGa0222ac1f9c2: [AsmPrinter] Do not define local aliases for global objects in a comdat (authored by leonardchan).
[AsmPrinter] Do not define local aliases for global objects in a comdat
Apr 6 2020, 2:12 PM
leonardchan closed D77429: [AsmPrinter] Do not define local aliases for global objects in a comdat.
Apr 6 2020, 2:11 PM · Restricted Project
leonardchan added inline comments to D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches.
Apr 6 2020, 2:10 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches.
Apr 6 2020, 1:39 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D77429: [AsmPrinter] Do not define local aliases for global objects in a comdat.
Apr 6 2020, 1:04 PM · Restricted Project

Apr 3 2020

leonardchan added a parent revision for D77429: [AsmPrinter] Do not define local aliases for global objects in a comdat: D72959: Relative VTables ABI on Fuchsia.
Apr 3 2020, 1:33 PM · Restricted Project
leonardchan created D77429: [AsmPrinter] Do not define local aliases for global objects in a comdat.
Apr 3 2020, 1:33 PM · Restricted Project