Page MenuHomePhabricator
Feed Advanced Search

Fri, Jun 14

leonardchan added inline comments to D62888: [NewPM] Port Sancov.
Fri, Jun 14, 8:36 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D62888: [NewPM] Port Sancov.
Fri, Jun 14, 8:36 PM · Restricted Project, Restricted Project
leonardchan added a comment to D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM.

For the avx tests, I don't suppose you know a simple way to generate these tests? They're about 10k lines long and it's taking a while to go through it by hand to replace the current IR checks with codegen for -O1. (Perhaps something along the lines of utils/update_llc_test_checks.py in llvm?)

Fri, Jun 14, 1:13 PM · Restricted Project
leonardchan added a comment to D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM.
Fri, Jun 14, 12:43 PM · Restricted Project
leonardchan added a comment to D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests.

I did some more digging and found the following differences between PMs for each test, and they seem to all differ and can be fixed for different reasons.

Fri, Jun 14, 10:47 AM · Restricted Project, Restricted Project
leonardchan updated the diff for D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests.
Fri, Jun 14, 10:47 AM · Restricted Project, Restricted Project

Thu, Jun 13

leonardchan committed rG09f56b51ec8c: [clang][NewPM] Fix broken -O0 test from missing assumptions (authored by leonardchan).
[clang][NewPM] Fix broken -O0 test from missing assumptions
Thu, Jun 13, 11:18 AM
leonardchan committed rL363287: [clang][NewPM] Fix broken -O0 test from missing assumptions.
[clang][NewPM] Fix broken -O0 test from missing assumptions
Thu, Jun 13, 11:18 AM
leonardchan closed D63170: [clang][NewPM] Fix broken -O0 test from missing assumptions.
Thu, Jun 13, 11:18 AM · Restricted Project, Restricted Project
leonardchan committed rG9f8ce3feb224: [clang][NewPM] Fix split debug test (authored by leonardchan).
[clang][NewPM] Fix split debug test
Thu, Jun 13, 10:38 AM
leonardchan committed rL363281: [clang][NewPM] Fix split debug test.
[clang][NewPM] Fix split debug test
Thu, Jun 13, 10:37 AM
leonardchan closed D63168: [clang][NewPM] Fix split debug test.
Thu, Jun 13, 10:36 AM · Restricted Project, Restricted Project
leonardchan committed rGab2c0ed01edf: [clang][NewPM] Fix broken profile test (authored by leonardchan).
[clang][NewPM] Fix broken profile test
Thu, Jun 13, 10:24 AM
leonardchan committed rL363278: [clang][NewPM] Fix broken profile test.
[clang][NewPM] Fix broken profile test
Thu, Jun 13, 10:23 AM
leonardchan closed D63155: [clang][NewPM] Fix broken profile test.
Thu, Jun 13, 10:23 AM · Restricted Project, Restricted Project
leonardchan committed rG587497b87d08: [clang][NewPM] Fix broken -O0 test from the AlwaysInliner (authored by leonardchan).
[clang][NewPM] Fix broken -O0 test from the AlwaysInliner
Thu, Jun 13, 9:43 AM
leonardchan added a comment to D63153: [clang][NewPM] Fix broken -O0 test from the AlwaysInliner.

Code change LGTM. Can you update at least one of the tests to explicitly run both PMs so that we'll notice if this breaks in some weird way? Feel free to submit with that change.

Thu, Jun 13, 9:43 AM · Restricted Project, Restricted Project
leonardchan committed rL363277: [clang][NewPM] Fix broken -O0 test from the AlwaysInliner.
[clang][NewPM] Fix broken -O0 test from the AlwaysInliner
Thu, Jun 13, 9:42 AM
leonardchan closed D63153: [clang][NewPM] Fix broken -O0 test from the AlwaysInliner.
Thu, Jun 13, 9:42 AM · Restricted Project, Restricted Project

Wed, Jun 12

leonardchan updated the diff for D62888: [NewPM] Port Sancov.
Wed, Jun 12, 11:09 AM · Restricted Project, Restricted Project
leonardchan added a comment to D62888: [NewPM] Port Sancov.

I would just change this to have the module pass loop over the functions -- that seems like it'll be much cleaner.

As it is, I'm not seeing where the loop actually happens. But rather than trying to figure that out, just seems better to turn it into an explicit loop. That way you can get rid of all the check analysis overhead I think.

Wed, Jun 12, 11:09 AM · Restricted Project, Restricted Project

Tue, Jun 11

leonardchan added a comment to D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.

I think this ultimately needs to be split up into smaller patches. A bunch of these things can be landed independently. Here is my first cut at things to split out, each one into its own patch.

Tue, Jun 11, 6:38 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
Tue, Jun 11, 6:21 PM · Restricted Project, Restricted Project
leonardchan added a parent revision for D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM: D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
Tue, Jun 11, 4:23 PM · Restricted Project
leonardchan added a child revision for D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM: D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM.
Tue, Jun 11, 4:23 PM · Restricted Project, Restricted Project
leonardchan created D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM.
Tue, Jun 11, 4:23 PM · Restricted Project
leonardchan updated the diff for D63170: [clang][NewPM] Fix broken -O0 test from missing assumptions.
Tue, Jun 11, 2:53 PM · Restricted Project, Restricted Project
leonardchan added a parent revision for D63170: [clang][NewPM] Fix broken -O0 test from missing assumptions: D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
Tue, Jun 11, 2:44 PM · Restricted Project, Restricted Project
leonardchan added a child revision for D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM: D63170: [clang][NewPM] Fix broken -O0 test from missing assumptions.
Tue, Jun 11, 2:44 PM · Restricted Project, Restricted Project
leonardchan created D63170: [clang][NewPM] Fix broken -O0 test from missing assumptions.
Tue, Jun 11, 2:44 PM · Restricted Project, Restricted Project
leonardchan retitled D63168: [clang][NewPM] Fix split debug test from [clang][NewPM] Fix to [clang][NewPM] Fix split debug test.
Tue, Jun 11, 2:28 PM · Restricted Project, Restricted Project
leonardchan added a parent revision for D63168: [clang][NewPM] Fix split debug test: D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
Tue, Jun 11, 2:18 PM · Restricted Project, Restricted Project
leonardchan added a child revision for D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM: D63168: [clang][NewPM] Fix split debug test.
Tue, Jun 11, 2:18 PM · Restricted Project, Restricted Project
leonardchan created D63168: [clang][NewPM] Fix split debug test.
Tue, Jun 11, 2:18 PM · Restricted Project, Restricted Project
leonardchan added a parent revision for D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests: D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
Tue, Jun 11, 12:06 PM · Restricted Project, Restricted Project
leonardchan added a child revision for D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM: D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests.
Tue, Jun 11, 12:06 PM · Restricted Project, Restricted Project
leonardchan created D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests.
Tue, Jun 11, 12:02 PM · Restricted Project, Restricted Project
leonardchan added a parent revision for D63155: [clang][NewPM] Fix broken profile test: D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
Tue, Jun 11, 11:55 AM · Restricted Project, Restricted Project
leonardchan created D63155: [clang][NewPM] Fix broken profile test.
Tue, Jun 11, 11:55 AM · Restricted Project, Restricted Project
leonardchan added a child revision for D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM: D63155: [clang][NewPM] Fix broken profile test.
Tue, Jun 11, 11:55 AM · Restricted Project, Restricted Project
leonardchan added a child revision for D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM: D63153: [clang][NewPM] Fix broken -O0 test from the AlwaysInliner.
Tue, Jun 11, 10:47 AM · Restricted Project, Restricted Project
leonardchan added a parent revision for D63153: [clang][NewPM] Fix broken -O0 test from the AlwaysInliner: D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
Tue, Jun 11, 10:47 AM · Restricted Project, Restricted Project
leonardchan created D63153: [clang][NewPM] Fix broken -O0 test from the AlwaysInliner.
Tue, Jun 11, 10:47 AM · Restricted Project, Restricted Project

Mon, Jun 10

leonardchan added a comment to D62088: [compiler-rt][builtins] Scaled Integer log10().

Well, I think the builtin has to be able to operate on signed scaled-integer / fixed-point types, and you'll have to specify the behavior for negative numbers. If you're comfortable implementing those semantics inline in the caller, then I agree you don't need signed functions in compiler-rt.

Ok. I'll add it to the caller when adding the builtin clang function. We can handle usage with different types there.

Okay. Please mention the behavior for 0 in the documentation, since this function is not otherwise defined for 0.

Mon, Jun 10, 4:55 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D62088: [compiler-rt][builtins] Scaled Integer log10().
Mon, Jun 10, 4:55 PM · Restricted Project, Restricted Project
leonardchan added a comment to D62888: [NewPM] Port Sancov.

*ping*

Mon, Jun 10, 1:58 PM · Restricted Project, Restricted Project

Wed, Jun 5

leonardchan added a comment to D62088: [compiler-rt][builtins] Scaled Integer log10().

Well, I think the builtin has to be able to operate on signed scaled-integer / fixed-point types, and you'll have to specify the behavior for negative numbers. If you're comfortable implementing those semantics inline in the caller, then I agree you don't need signed functions in compiler-rt.

Wed, Jun 5, 5:18 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D62088: [compiler-rt][builtins] Scaled Integer log10().
Wed, Jun 5, 5:18 PM · Restricted Project, Restricted Project
leonardchan added a comment to D62088: [compiler-rt][builtins] Scaled Integer log10().

The number is the argument count plus one for return value. So this function should be named

__log10scaleddi3

Wed, Jun 5, 11:16 AM · Restricted Project, Restricted Project
leonardchan updated subscribers of D62088: [compiler-rt][builtins] Scaled Integer log10().
Wed, Jun 5, 11:10 AM · Restricted Project, Restricted Project
leonardchan updated the diff for D62088: [compiler-rt][builtins] Scaled Integer log10().
Wed, Jun 5, 11:10 AM · Restricted Project, Restricted Project
leonardchan added a comment to D62088: [compiler-rt][builtins] Scaled Integer log10().

I don't review compiler-rt patches generally. Can you explain what would actually use this function? Is there supposed to be a new Clang builtin for it?

Wed, Jun 5, 11:03 AM · Restricted Project, Restricted Project
leonardchan updated the diff for D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.

For now, I made the avx512-reduceMinMaxIntrin.c test only run under the legacy PM since there were already too many changes in this patch. The changes were lit expecting allocas for temporary variables to be in specific orders which weren't respected in the new PM for some reason, but still followed the same logic. I can update this in a later patch separated from this one to make reviewing easier.

Wed, Jun 5, 10:30 AM · Restricted Project, Restricted Project
leonardchan updated the diff for D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
Wed, Jun 5, 10:11 AM · Restricted Project, Restricted Project
leonardchan added a comment to D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.

Are the behavior differences between the newpm alwaysinliner and the oldpm alwaysinliner intentional? Specifically, the differences in pass remarks, and the differences in the treatment of the alwaysinline attribute seem suspect. (I'm not that interested in the different bitcasts and different order of inline allocas, although that might be nice to fix if it's a small change.)

Wed, Jun 5, 10:11 AM · Restricted Project, Restricted Project

Tue, Jun 4

leonardchan created D62888: [NewPM] Port Sancov.
Tue, Jun 4, 7:36 PM · Restricted Project, Restricted Project

Fri, May 24

leonardchan updated the diff for D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.

OK, this should be all the tests and now requesting reviews. Most of the tests just require checking different output that is slightly different between pass managers whereas others were functional changes that involved adding some passes to the new PM pipeline or changing the AlwaysInliner somehow.

Fri, May 24, 9:25 PM · Restricted Project, Restricted Project

Thu, May 23

leonardchan updated the diff for D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
Thu, May 23, 4:31 PM · Restricted Project, Restricted Project

Wed, May 22

leonardchan updated the diff for D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
Wed, May 22, 6:38 PM · Restricted Project, Restricted Project
Herald added a project to D23299: [PM] Port the always inliner to the new pass manager in a much more minimal and boring form than the old pass manager's version.: Restricted Project.

Hi, I'm attempting to fix all clang tests that fail when enabling the new PM by default and one of the failing tests is CodeGen/flatten.c which tests the flatten attribute. According to the docs, this attribute attempts to inline function calls in functions marked with flatten. But if I understand this patch correctly, one of the intentions is only inlining for functions and not calls.

Wed, May 22, 5:31 PM · Restricted Project
leonardchan added a reviewer for D62088: [compiler-rt][builtins] Scaled Integer log10(): saugustine.
Wed, May 22, 11:51 AM · Restricted Project, Restricted Project
leonardchan added a reviewer for D62088: [compiler-rt][builtins] Scaled Integer log10(): rsmith.
Wed, May 22, 11:50 AM · Restricted Project, Restricted Project
leonardchan added inline comments to D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
Wed, May 22, 9:16 AM · Restricted Project, Restricted Project

Tue, May 21

leonardchan created D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
Tue, May 21, 4:46 PM · Restricted Project, Restricted Project
leonardchan committed rG3af7cf58bb09: Remove unicode character from test (authored by leonardchan).
Remove unicode character from test
Tue, May 21, 1:10 PM
leonardchan added a comment to D62088: [compiler-rt][builtins] Scaled Integer log10().

*ping*

Tue, May 21, 1:09 PM · Restricted Project, Restricted Project
leonardchan committed rL361302: Remove unicode character from test.
Remove unicode character from test
Tue, May 21, 1:09 PM
leonardchan committed rC361302: Remove unicode character from test.
Remove unicode character from test
Tue, May 21, 1:09 PM
leonardchan committed rG9bb96980aa3c: Fix for sphinx bot warning (authored by leonardchan).
Fix for sphinx bot warning
Tue, May 21, 12:31 PM
leonardchan committed rL361292: Fix for sphinx bot warning.
Fix for sphinx bot warning
Tue, May 21, 12:27 PM
leonardchan committed rG0bada7ce6c12: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic (authored by leonardchan).
[Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic
Tue, May 21, 12:20 PM
leonardchan committed rL361289: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
[Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic
Tue, May 21, 12:15 PM
leonardchan closed D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Tue, May 21, 12:14 PM · Restricted Project

Mon, May 20

leonardchan committed rG16beaae2a61c: [Sema] Fix for build on some iOS programs. (authored by leonardchan).
[Sema] Fix for build on some iOS programs.
Mon, May 20, 3:44 PM
leonardchan committed rC361205: [Sema] Fix for build on some iOS programs..
[Sema] Fix for build on some iOS programs.
Mon, May 20, 3:43 PM
leonardchan committed rL361205: [Sema] Fix for build on some iOS programs..
[Sema] Fix for build on some iOS programs.
Mon, May 20, 3:43 PM

May 17 2019

leonardchan added a comment to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.

LGTM! (if all comments from other reviewers has been taken care of) (maybe you should wait another day to see if anyone else object, but I think this patch has been open for a long time so there have been plenty of time for comments already)

Btw, I'm still having a hard time reviewing the X86 test cases with very long results, and a little bit worried that those just will give annoying churn when doing unrelated patches in the future, rather than help out detecting problems related to smul.fix. I currently have no more ideas on how to improve that.

Hopefully I'll be able to run some runtime comparison tests between X86 and our OOT target when this has landed (and when I've adapted our target to use these new intrinsics using "legal" lowering and not "expand").

May 17 2019, 3:03 PM · Restricted Project
leonardchan created D62088: [compiler-rt][builtins] Scaled Integer log10().
May 17 2019, 2:37 PM · Restricted Project, Restricted Project

May 15 2019

leonardchan added inline comments to D58321: Support for relative vtables.
May 15 2019, 4:20 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D58321: Support for relative vtables.
May 15 2019, 4:20 PM · Restricted Project, Restricted Project
leonardchan added inline comments to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
May 15 2019, 12:20 PM · Restricted Project
leonardchan updated the diff for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
May 15 2019, 12:18 PM · Restricted Project

May 14 2019

leonardchan committed rG048a97bca4da: Fix bots by adding target triple to test. (authored by leonardchan).
Fix bots by adding target triple to test.
May 14 2019, 3:37 PM
leonardchan committed rC360720: Fix bots by adding target triple to test..
Fix bots by adding target triple to test.
May 14 2019, 3:37 PM
leonardchan committed rL360720: Fix bots by adding target triple to test..
Fix bots by adding target triple to test.
May 14 2019, 3:37 PM
leonardchan committed rG0cdd3b1d817a: [NewPM] Port HWASan and Kernel HWASan (authored by leonardchan).
[NewPM] Port HWASan and Kernel HWASan
May 14 2019, 2:15 PM
leonardchan committed rL360707: [NewPM] Port HWASan and Kernel HWASan.
[NewPM] Port HWASan and Kernel HWASan
May 14 2019, 2:15 PM
leonardchan added inline comments to D61709: [NewPM] Port HWASan and Kernel HWASan.
May 14 2019, 2:15 PM · Restricted Project, Restricted Project
leonardchan committed rC360707: [NewPM] Port HWASan and Kernel HWASan.
[NewPM] Port HWASan and Kernel HWASan
May 14 2019, 2:15 PM
leonardchan closed D61709: [NewPM] Port HWASan and Kernel HWASan.
May 14 2019, 2:15 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
May 14 2019, 12:54 PM · Restricted Project
leonardchan added inline comments to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
May 14 2019, 12:52 PM · Restricted Project

May 12 2019

leonardchan committed rG4235a4edfebd: Fix test to use -cc1. (authored by leonardchan).
Fix test to use -cc1.
May 12 2019, 3:47 PM
leonardchan committed rC360548: Fix test to use -cc1..
Fix test to use -cc1.
May 12 2019, 3:42 PM
leonardchan committed rL360548: Fix test to use -cc1..
Fix test to use -cc1.
May 12 2019, 3:42 PM
leonardchan added a comment to D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.

This caused a regression when including mingw-w64 headers (in a case where they happen to include redundant/duplicate attribute specifications), triggering asserts. See https://bugs.llvm.org/show_bug.cgi?id=41852 for details.

May 12 2019, 2:53 PM · Restricted Project
leonardchan committed rG69aec05bb155: Fix for P41852 where builtin attributes were being caught by… (authored by leonardchan).
Fix for P41852 where builtin attributes were being caught by…
May 12 2019, 2:50 PM
leonardchan committed rC360544: Fix for P41852 where builtin attributes were being caught by….
Fix for P41852 where builtin attributes were being caught by…
May 12 2019, 2:50 PM
leonardchan committed rL360544: Fix for P41852 where builtin attributes were being caught by….
Fix for P41852 where builtin attributes were being caught by…
May 12 2019, 2:50 PM

May 10 2019

leonardchan added a comment to D61680: [X86] Avoid SFB - Fix inconsistent codegen with/without debug info .

Hi, it seems that this patch results in an assertion error when building zircon:

May 10 2019, 3:12 PM · Restricted Project