Page MenuHomePhabricator
Feed Advanced Search

Wed, Jul 21

curdeius added inline comments to D106364: [libc++] Add `__libcpp_copysign` conditionally constexpr overloads..
Wed, Jul 21, 7:59 AM · Restricted Project
curdeius committed rG1daf0e22562c: [libc++] Add `__libcpp_copysign` conditionally constexpr overloads. (authored by curdeius).
[libc++] Add `__libcpp_copysign` conditionally constexpr overloads.
Wed, Jul 21, 7:58 AM
curdeius closed D106364: [libc++] Add `__libcpp_copysign` conditionally constexpr overloads..
Wed, Jul 21, 7:57 AM · Restricted Project
curdeius added inline comments to D79555: [libc++] [C++20] [P0415] Constexpr for std::complex..
Wed, Jul 21, 7:50 AM · Restricted Project
curdeius added inline comments to D106364: [libc++] Add `__libcpp_copysign` conditionally constexpr overloads..
Wed, Jul 21, 7:02 AM · Restricted Project
curdeius retitled D106364: [libc++] Add `__libcpp_copysign` conditionally constexpr overloads. from [libc++] Add __copysign conditionally constexpr overloads. to [libc++] Add `__libcpp_copysign` conditionally constexpr overloads..
Wed, Jul 21, 6:59 AM · Restricted Project
curdeius updated the diff for D106364: [libc++] Add `__libcpp_copysign` conditionally constexpr overloads..
  • Rename to libcpp_copysign due to clashes with Linux ::copysign. Add double overload.
Wed, Jul 21, 6:58 AM · Restricted Project
curdeius added a comment to D106364: [libc++] Add `__libcpp_copysign` conditionally constexpr overloads..

Regarding naming, maybe I should rename __copysign to __libcpp_copysign to match what is done currently?

Wed, Jul 21, 6:49 AM · Restricted Project
curdeius added inline comments to D106364: [libc++] Add `__libcpp_copysign` conditionally constexpr overloads..
Wed, Jul 21, 6:30 AM · Restricted Project
curdeius updated the diff for D106364: [libc++] Add `__libcpp_copysign` conditionally constexpr overloads..
  • Qualify calls.
Wed, Jul 21, 6:28 AM · Restricted Project

Tue, Jul 20

curdeius added inline comments to D106364: [libc++] Add `__libcpp_copysign` conditionally constexpr overloads..
Tue, Jul 20, 8:00 AM · Restricted Project
curdeius updated the summary of D106364: [libc++] Add `__libcpp_copysign` conditionally constexpr overloads..
Tue, Jul 20, 7:52 AM · Restricted Project
curdeius requested review of D106364: [libc++] Add `__libcpp_copysign` conditionally constexpr overloads..
Tue, Jul 20, 7:52 AM · Restricted Project

Mon, Jul 19

curdeius accepted D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl.

I just reviewed the differences between K&R C (circa 1978) and ANSI/ISO C again and didn't see anything else that would impact clang-format, so a new Standard enum value for C78 is not needed. Nevertheless, we can add a boolean option e.g. C78ParameterDecl in the future if this patch causes regressions for some users. WDYT?

Mon, Jul 19, 7:48 AM · Restricted Project, Restricted Project

Fri, Jul 16

curdeius added a comment to D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl.

Looks okay, but I was wondering if we don't want to guard all K&R-related changes behind e.g. `Standard: Cpp78``, so as not to possibly introduce strange bugs in newer modes.
It may be an overkill if there are 2 patches like this, but if there are more, that might become sensible to do so.
WDYT?

Fri, Jul 16, 8:17 AM · Restricted Project, Restricted Project

Wed, Jul 14

curdeius added a comment to D69764: [clang-format] Add East/West Const fixer capability.

I've been trying to make my opinion on this patch for the last few weeks...
I was pretty much opposed to introducing non-whitespace chances previously, but I'm reviewing my standpoint.
As mentioned already, there are precedents (include sorting, namespace comments, long string splitting).
I'm however even more wary of adding yet another tool that will be almost the same as clang-format. It could work if it were a drop-in replacement of clang-format, but that seems to be very much wishful thinking to me.
First, maintenance burden to verify that the two don't diverge somehow. Secondly, the drop-in replacement wouldn't be possible without changing clang-format itself (e.g. to ignore style options that are for "clang-format++" only). Also, it might divide the users into clang-format camp and clang-format++ camp (which may or may not be a problem).
Lastly, I do think that clang-format can be as reliable with this patch as it's now. Breaking code is of course possible but that's the case of many style options. And these are bugs that will eventually get fixed. It's of course important that this option doesn't break anything ever by default, but given that the default is Leave, and it's implemented as an additional pass, that should be the case.
Also, I'd be a bit surprised if people used it in CI immediately after this feature has landed without verifying that it doesn't break anything on their codebase.

Wed, Jul 14, 5:47 AM · Restricted Project, Restricted Project
curdeius accepted D105964: [clang-format] Make AlwaysBreakAfterReturnType work with K&R C function definitions.

LGTM.

Wed, Jul 14, 5:16 AM · Restricted Project, Restricted Project

Wed, Jun 30

curdeius added a comment to D105099: [clang-format] Add an option to put one constructor initializer per line.

If we were to start this all over without the need of backward compatibility and the existence of the related unit tests, an enum might be a better option. Then I still think the user might have some trouble relating the following to the enum.

If AlwaysOnePerLine:
  Put each on its own line.
Else If AllOnOneLineOrOnePerline:
  If they all fit on one line:
    Put all of them on a single line.
  Else If AllOnNextLine:
    Put (the rest of) them on the next line.
  Else:
    Put each on its own line.
Else:
  ...

Is there anything else in the "Else:" part above? Is there an option that we forgot?

Wed, Jun 30, 8:41 AM · Restricted Project, Restricted Project

Tue, Jun 29

curdeius added a comment to D105099: [clang-format] Add an option to put one constructor initializer per line.

Formatting part and tests look good to me, but I'd rather see this patch merge all related boolean options into one enum.
Just thinking out loud, but is it doable to merge AllowAllConstructorInitializersOnNextLine, ConstructorInitializerAllOnOneLineOrOnePerLine and this patch's ConstructorInitializerAlwaysOnePerLine into e.g. ConstructorInitializerStyle: AllowNextLine | NonBinPack==AllOnOneLineOrOnePerLine | OnePerLine. And one other enum value for the default case without special handling.
Of course, we'd need to keep that backward compatible.

Tue, Jun 29, 1:25 PM · Restricted Project, Restricted Project
curdeius added a comment to D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect.

I can't help with C# part either, unfortunately.
I'll chime in if I see something strange, but current patch looks okay to me. I let other reviewers (@exv) accept it when they feel it's ok.

Tue, Jun 29, 1:04 PM · Restricted Project, Restricted Project

Jun 16 2021

curdeius accepted D104372: [libcxx] Fix a case of -Wundef warnings regarding _POSIX_TIMERS.

LGTM.

Jun 16 2021, 8:30 AM · Restricted Project

Jun 9 2021

curdeius accepted D101868: [clang-format] Adds a formatter for aligning arrays of structs.

LGTM. That's a great piece work @feg208. Thank you!

Jun 9 2021, 12:47 PM · Restricted Project, Restricted Project
curdeius added inline comments to D101868: [clang-format] Adds a formatter for aligning arrays of structs.
Jun 9 2021, 11:25 AM · Restricted Project, Restricted Project
curdeius added inline comments to D101868: [clang-format] Adds a formatter for aligning arrays of structs.
Jun 9 2021, 12:43 AM · Restricted Project, Restricted Project

Jun 8 2021

curdeius accepted D103678: [Format] Fix incorrect pointer/reference detection.

LGTM modulo nits.

Jun 8 2021, 5:09 AM · Restricted Project, Restricted Project
curdeius added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Better still how about having

ArraryMemberAligmentEnum AlignArrayOfStructures

of "None, Left and Right"

I find boolean options don't stay boolean for long!

Jun 8 2021, 4:56 AM · Restricted Project, Restricted Project

Jun 6 2021

curdeius closed D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right.

This has been superseded by D103245. Closing.

Jun 6 2021, 12:07 AM · Restricted Project, Restricted Project

Jun 4 2021

curdeius committed rG21c18d5a0431: [Format] Fix incorrect pointer detection (authored by Nuullll).
[Format] Fix incorrect pointer detection
Jun 4 2021, 12:39 AM
curdeius closed D103589: [Format] Fix incorrect pointer detection.
Jun 4 2021, 12:39 AM · Restricted Project, Restricted Project

Jun 3 2021

curdeius accepted D103589: [Format] Fix incorrect pointer detection.

LGTM. Thanks for fixing this!
Do you have commit rights or you need somebody to land it for you?

Jun 3 2021, 5:13 AM · Restricted Project, Restricted Project
curdeius updated the summary of D103589: [Format] Fix incorrect pointer detection.
Jun 3 2021, 5:03 AM · Restricted Project, Restricted Project

Jun 2 2021

curdeius requested changes to D103589: [Format] Fix incorrect pointer detection.

Thanks for looking into this, but please add a test case that demonstrates the bug to FormatTests.cpp
Also, is there, by any chance, an associated bugzilla ticket?

Jun 2 2021, 10:31 PM · Restricted Project, Restricted Project
curdeius added reviewers for D103589: [Format] Fix incorrect pointer detection: MyDeveloperDay, HazardyKnusperkeks.
Jun 2 2021, 10:29 PM · Restricted Project, Restricted Project
curdeius added a comment to D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations.

Thanks for adding the tests. 👍

Jun 2 2021, 8:52 AM · Restricted Project, Restricted Project
curdeius added inline comments to D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations.
Jun 2 2021, 4:48 AM · Restricted Project, Restricted Project

May 29 2021

curdeius accepted D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations.

LGTM. But please wait for @HazardyKnusperkeks to land.

May 29 2021, 5:14 AM · Restricted Project, Restricted Project

May 28 2021

curdeius added a comment to D102730: [clang-format] Support custom If macros.

Thanks for working on this!
Looks pretty nice, but please clang-format the changes and add some more test cases (cf. inline comment).

May 28 2021, 1:26 PM · Restricted Project, Restricted Project
curdeius accepted D103307: [clang-format] successive C# attributes cause line breaking issues.

LGTM.

May 28 2021, 1:07 PM · Restricted Project, Restricted Project
curdeius added a comment to D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations.

Seems really nice. Just some nits & question.
Thanks for resuscitating the other review!

May 28 2021, 1:03 PM · Restricted Project, Restricted Project
curdeius added a comment to D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is..

Whoops, We forgot to regenerate ClangFormatStyleOptions.rst here following the change to Format.h

May 28 2021, 12:50 PM · Restricted Project
curdeius committed rG8702c6da162b: [clang-format] [docs] Regenerate style options documentation. (authored by curdeius).
[clang-format] [docs] Regenerate style options documentation.
May 28 2021, 12:49 PM
curdeius accepted D103204: [clang-format] New BreakInheritanceList style AfterComma.

LGTM.

May 28 2021, 12:31 PM · Restricted Project, Restricted Project

May 19 2021

curdeius added inline comments to D92168: [clang-format] Handle statement macro expressions in switch block.
May 19 2021, 4:10 AM · Restricted Project

May 14 2021

curdeius accepted D102357: [libcxx] [test] Explain an XFAIL LIBCXX-WINDOWS-FIXME and convert into "UNSUPPORTED".
May 14 2021, 8:28 AM · Restricted Project
curdeius accepted D102360: [libcxx] [test] Change the generic_string_alloc test to do a conversion that also does something on windows.
May 14 2021, 12:15 AM · Restricted Project
curdeius added a comment to D102359: [libc++] [test] Fix a few tests for 32-bit x86.

Also, please update https://bugs.llvm.org/show_bug.cgi?id=48939 and add it to the description.

May 14 2021, 12:14 AM · Restricted Project
curdeius accepted D102359: [libc++] [test] Fix a few tests for 32-bit x86.

LGTM. But please rebase to rerun CI (the commit that provoked the failures has been reverted).
It would be cool if @saugustine could have a look at gdb part though. @ldionne, this patch should unblock adding 32-bit buildbots to CI in D92508.

May 14 2021, 12:12 AM · Restricted Project
curdeius added a reviewer for D102359: [libc++] [test] Fix a few tests for 32-bit x86: saugustine.
May 14 2021, 12:08 AM · Restricted Project

May 13 2021

curdeius accepted D102360: [libcxx] [test] Change the generic_string_alloc test to do a conversion that also does something on windows.

LGTM. What do you think, would there be any value in testing different char types?

May 13 2021, 10:35 AM · Restricted Project
curdeius accepted D102365: [libcxx] Fix the function name in exceptions from create_directories.

LGTM.

May 13 2021, 10:29 AM · Restricted Project
curdeius added inline comments to D102357: [libcxx] [test] Explain an XFAIL LIBCXX-WINDOWS-FIXME and convert into "UNSUPPORTED".
May 13 2021, 10:14 AM · Restricted Project
curdeius accepted D102414: [libc++] Improve make_string test support..

LGTM. I second what Arthur said.

May 13 2021, 10:12 AM · Restricted Project
curdeius accepted D102392: [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit.

LGTM. Not blocking, but I'd add foo4 example from the description as a test case (with a link to the bug maybe).

May 13 2021, 6:45 AM · Restricted Project, Restricted Project

May 12 2021

curdeius added inline comments to D102332: [libc++][nfc] remove duplicated __to_unsigned..
May 12 2021, 12:00 PM · Restricted Project

May 7 2021

curdeius added inline comments to D92168: [clang-format] Handle statement macro expressions in switch block.
May 7 2021, 2:33 AM · Restricted Project
curdeius added inline comments to D101868: [clang-format] Adds a formatter for aligning arrays of structs.
May 7 2021, 1:04 AM · Restricted Project, Restricted Project
curdeius added inline comments to D102048: [libc++] Run `substitutes-in-compile-flags.sh.cpp` test on Windows..
May 7 2021, 12:43 AM · Restricted Project

May 6 2021

curdeius accepted D101978: [libcxx] Fix a case of -Wundef warnings. NFC..

LGTM.

May 6 2021, 3:22 AM · Restricted Project
curdeius committed rGcdf33962d976: [clang-format] Rename common types between C#/JS (authored by exv).
[clang-format] Rename common types between C#/JS
May 6 2021, 3:13 AM
curdeius closed D101862: [clang-format] Rename common types between C#/JS.
May 6 2021, 3:13 AM · Restricted Project, Restricted Project
curdeius committed rGec725b307f3f: [clang-format] Fix C# nullable-related errors (authored by exv).
[clang-format] Fix C# nullable-related errors
May 6 2021, 3:11 AM
curdeius closed D101860: [clang-format] Fix C# nullable-related errors.
May 6 2021, 3:11 AM · Restricted Project, Restricted Project
curdeius committed rGa437befa8f85: [clang-format] Add more support for C# 8 nullables (authored by exv).
[clang-format] Add more support for C# 8 nullables
May 6 2021, 2:58 AM
curdeius closed D101702: [clang-format] Add more support for C# 8 nullables.
May 6 2021, 2:58 AM · Restricted Project, Restricted Project

May 5 2021

curdeius added a comment to D101878: [git-clang-format] Do not apply clang-format to symlinks.

Oh, I forgot, please add a release note.

May 5 2021, 2:03 PM · Restricted Project, Restricted Project
curdeius accepted D101878: [git-clang-format] Do not apply clang-format to symlinks.

LGTM but let's wait a day or two before landing, so that others can chime in.
Btw, do you have commit rights? If no, please provide "Name <email>" for commit attribution.

May 5 2021, 1:54 PM · Restricted Project, Restricted Project
curdeius added inline comments to D101878: [git-clang-format] Do not apply clang-format to symlinks.
May 5 2021, 1:40 PM · Restricted Project, Restricted Project
curdeius requested changes to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

I like the idea, but we need more tests.

May 5 2021, 2:32 AM · Restricted Project, Restricted Project
curdeius added reviewers for D101868: [clang-format] Adds a formatter for aligning arrays of structs: MyDeveloperDay, HazardyKnusperkeks.
May 5 2021, 2:16 AM · Restricted Project, Restricted Project
curdeius retitled D101868: [clang-format] Adds a formatter for aligning arrays of structs from Adds a formatter for aligning arrays of structs to [clang-format] Adds a formatter for aligning arrays of structs.
May 5 2021, 2:15 AM · Restricted Project, Restricted Project
curdeius accepted D101862: [clang-format] Rename common types between C#/JS.

LGTM pending CI.

May 5 2021, 2:15 AM · Restricted Project, Restricted Project
curdeius accepted D101860: [clang-format] Fix C# nullable-related errors.

LGTM pending CI.

May 5 2021, 12:44 AM · Restricted Project, Restricted Project
curdeius added a comment to D101860: [clang-format] Fix C# nullable-related errors.

You can add a parent revision so that this patch will be applied upon its parent.

May 5 2021, 12:39 AM · Restricted Project, Restricted Project
curdeius added a comment to D101702: [clang-format] Add more support for C# 8 nullables.

Could you please rebase to re-run the CI (that failed for sum unrelated reason)?

May 5 2021, 12:38 AM · Restricted Project, Restricted Project

May 4 2021

curdeius added a comment to D101702: [clang-format] Add more support for C# 8 nullables.

Preferably a new one unless it's something really minor.

May 4 2021, 2:18 PM · Restricted Project, Restricted Project
curdeius added a comment to D101702: [clang-format] Add more support for C# 8 nullables.

According to the wiki, it seems like someone who has commit access must now submit this change.

May 4 2021, 12:17 PM · Restricted Project, Restricted Project
curdeius accepted D101628: [Format] Don't sort includes if DisableFormat is true.

LGTM. Thanks!

May 4 2021, 10:26 AM · Restricted Project, Restricted Project
curdeius accepted D101702: [clang-format] Add more support for C# 8 nullables.

LGTM. That's great. Thanks for working on this and for the cleanup.

May 4 2021, 12:14 AM · Restricted Project, Restricted Project

May 3 2021

curdeius requested changes to D101702: [clang-format] Add more support for C# 8 nullables.

Looks very good already. Just some questions and test requests.

May 3 2021, 2:25 PM · Restricted Project, Restricted Project
curdeius added a comment to D101628: [Format] Don't sort includes if DisableFormat is true.

Is it testable?

May 3 2021, 1:36 PM · Restricted Project, Restricted Project
curdeius committed rG31751ce1b923: [clang-format] Fix build on gcc < 7 introduced in rG8d93d7ff. (authored by curdeius).
[clang-format] Fix build on gcc < 7 introduced in rG8d93d7ff.
May 3 2021, 9:54 AM
curdeius committed rG40f783434b0b: [docs] Automatically update copyright year in libc++. (authored by curdeius).
[docs] Automatically update copyright year in libc++.
May 3 2021, 9:46 AM
curdeius committed rG9d669e859b80: [docs] Bump the trunk major version to 13 and update copyright year. (authored by curdeius).
[docs] Bump the trunk major version to 13 and update copyright year.
May 3 2021, 9:45 AM
curdeius committed rGb2be167a4952: [docs] Fix title overline. (authored by curdeius).
[docs] Fix title overline.
May 3 2021, 9:33 AM
curdeius committed rGd492532b8c3a: [docs] Fix syntax typo. (authored by curdeius).
[docs] Fix syntax typo.
May 3 2021, 9:29 AM
curdeius committed rG8d93d7ffedeb: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to… (authored by curdeius).
[clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to…
May 3 2021, 9:11 AM
curdeius closed D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else"..
May 3 2021, 9:11 AM · Restricted Project
curdeius updated the diff for D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else"..
  • Fix format.
May 3 2021, 2:13 AM · Restricted Project
curdeius added a comment to D101565: [libcxx] [ci] Add a Windows CI configuration for a statically linked libc++.

Still LGTM.

May 3 2021, 1:31 AM · Restricted Project

May 1 2021

curdeius added a comment to D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else"..

I went a different way in order to keep backward compatibility.
I renamed Alwayss to OnlyFirstIf and added AllIfsAndElse that behaves as Always in my initial patch.
@MyDeveloperDay, please have another look.

May 1 2021, 1:17 PM · Restricted Project
curdeius retitled D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else". from [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch. to [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else"..
May 1 2021, 1:14 PM · Restricted Project
curdeius updated the diff for D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else"..
  • [clang-format] Apply AllowShortIfStatementsOnASingleLine: AllIfsAndElse to "else if" and "else". Keep backward-compatibility.
May 1 2021, 1:13 PM · Restricted Project

Apr 30 2021

curdeius accepted D101565: [libcxx] [ci] Add a Windows CI configuration for a statically linked libc++.

LGTM. Nice!

Apr 30 2021, 4:39 AM · Restricted Project
curdeius accepted D101613: [libcxx] Reenable ranges for clang-cl.

LGTM pending CI.

Apr 30 2021, 4:27 AM · Restricted Project

Apr 29 2021

curdeius added inline comments to D101565: [libcxx] [ci] Add a Windows CI configuration for a statically linked libc++.
Apr 29 2021, 1:33 PM · Restricted Project
curdeius committed rG40c2d6188b08: [clang-format] Fix build on gcc < 7 introduced in rG9363aa9. (authored by curdeius).
[clang-format] Fix build on gcc < 7 introduced in rG9363aa9.
Apr 29 2021, 1:09 AM
curdeius committed rG6e5082bbc498: [clang-format] Fix build on gcc < 7 introduced in rG9363aa9. (authored by curdeius).
[clang-format] Fix build on gcc < 7 introduced in rG9363aa9.
Apr 29 2021, 12:58 AM

Apr 28 2021

curdeius committed rG9363aa90bfe6: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle… (authored by curdeius).
[clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle…
Apr 28 2021, 11:59 PM
curdeius closed D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is..
Apr 28 2021, 11:59 PM · Restricted Project
curdeius accepted D101436: [libcxx] Stop hardcoding the bash path in the Windows CI.

LGTM. Cool!

Apr 28 2021, 9:17 AM · Restricted Project