Page MenuHomePhabricator
Feed Advanced Search

Tue, Jun 29

AMDChirag added a comment to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

@jdoerfert Could you please take a look at this patch as well? (especially for the clang part)

Tue, Jun 29, 1:44 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 28

AMDChirag added a comment to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

@kiranchandramohan The tests passed now!

Mon, Jun 28, 8:34 AM · Restricted Project, Restricted Project, Restricted Project
AMDChirag updated the diff for D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

Rebased

Mon, Jun 28, 4:25 AM · Restricted Project, Restricted Project, Restricted Project

Jun 22 2021

AMDChirag added a comment to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

@kiranchandramohan It failed again. Apparently, it automatically attempted to add a patch D93105 which is already merged. I removed that patch as dependency before (edit related revisions), but it seems to have been added again.
Am I missing something?

Jun 22 2021, 2:32 AM · Restricted Project, Restricted Project, Restricted Project
AMDChirag added a comment to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

Oh great! That triggered it!
Thank you!

Jun 22 2021, 1:58 AM · Restricted Project, Restricted Project, Restricted Project
AMDChirag updated the diff for D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

Rebased

Jun 22 2021, 1:57 AM · Restricted Project, Restricted Project, Restricted Project
AMDChirag added a comment to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

It could be because you are not the author. Can you commandeer the patch (option available in the Add Action menu below)?

Jun 22 2021, 1:14 AM · Restricted Project, Restricted Project, Restricted Project
AMDChirag commandeered D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..
Jun 22 2021, 1:13 AM · Restricted Project, Restricted Project, Restricted Project
AMDChirag added a comment to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

Hi @kiranchandramohan How do I restart the build? It says I don't have permission.

Jun 22 2021, 1:06 AM · Restricted Project, Restricted Project, Restricted Project

Jun 21 2021

AMDChirag updated the diff for D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

Rebased to main

Jun 21 2021, 9:38 PM · Restricted Project, Restricted Project, Restricted Project
AMDChirag updated the diff for D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

Fixes the clang test cases

Jun 21 2021, 8:09 AM · Restricted Project, Restricted Project, Restricted Project

Jun 1 2021

AMDChirag accepted D102849: [flang][driver] Add support for the "-init-only" option.
Jun 1 2021, 5:16 AM · Restricted Project, Restricted Project
AMDChirag added a comment to D102849: [flang][driver] Add support for the "-init-only" option.

LGTM. I'll let someone else take a look too.

Jun 1 2021, 4:36 AM · Restricted Project, Restricted Project

Apr 29 2021

AMDChirag added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Apr 29 2021, 10:36 PM · Restricted Project, Restricted Project
AMDChirag committed rGc20410618827: [Clang][OpenMP] Frontend work for sections - D89671 (authored by AMDChirag).
[Clang][OpenMP] Frontend work for sections - D89671
Apr 29 2021, 7:23 AM
AMDChirag closed D91054: [Clang][OpenMP] Frontend work for sections - D89671.
Apr 29 2021, 7:22 AM · Restricted Project
AMDChirag updated the diff for D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Rebase to retrigger build

Apr 29 2021, 6:43 AM · Restricted Project
AMDChirag updated the summary of D91054: [Clang][OpenMP] Frontend work for sections - D89671.
Apr 29 2021, 6:37 AM · Restricted Project
AMDChirag committed rGfbd3548d1ca7: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder (authored by AMDChirag).
[LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder
Apr 29 2021, 6:10 AM
AMDChirag closed D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Apr 29 2021, 6:10 AM · Restricted Project, Restricted Project
AMDChirag updated the summary of D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Apr 29 2021, 5:59 AM · Restricted Project, Restricted Project
AMDChirag updated the summary of D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Apr 29 2021, 5:58 AM · Restricted Project, Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Corrected rebase

Apr 29 2021, 4:25 AM · Restricted Project, Restricted Project
AMDChirag updated the diff for D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Rebased to HEAD of main branch

Apr 29 2021, 1:42 AM · Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Rebased to HEAD of main branch

Apr 29 2021, 1:39 AM · Restricted Project, Restricted Project

Apr 28 2021

AMDChirag updated the summary of D91054: [Clang][OpenMP] Frontend work for sections - D89671.
Apr 28 2021, 10:24 PM · Restricted Project

Apr 27 2021

AMDChirag updated the summary of D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Apr 27 2021, 11:46 PM · Restricted Project, Restricted Project

Apr 23 2021

AMDChirag accepted D100649: [flang][driver] Fine-tune `-fdebug-dump-symbols`.
Apr 23 2021, 2:24 AM · Restricted Project, Restricted Project

Apr 22 2021

AMDChirag added a comment to D91054: [Clang][OpenMP] Frontend work for sections - D89671.

What is missing or not working in the IRBuilder impl that prevents us from turning it on by default?

Apr 22 2021, 8:49 AM · Restricted Project
AMDChirag added inline comments to D100649: [flang][driver] Fine-tune `-fdebug-dump-symbols`.
Apr 22 2021, 7:00 AM · Restricted Project, Restricted Project
AMDChirag requested changes to D100649: [flang][driver] Fine-tune `-fdebug-dump-symbols`.
Apr 22 2021, 12:39 AM · Restricted Project, Restricted Project

Apr 21 2021

AMDChirag accepted D100649: [flang][driver] Fine-tune `-fdebug-dump-symbols`.
Apr 21 2021, 10:15 PM · Restricted Project, Restricted Project
AMDChirag added a comment to D100649: [flang][driver] Fine-tune `-fdebug-dump-symbols`.
Apr 21 2021, 10:14 PM · Restricted Project, Restricted Project
AMDChirag added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

@jdoerfert Anything else to do here? Can this be merged?

Apr 21 2021, 9:50 PM · Restricted Project, Restricted Project
AMDChirag added a comment to D91054: [Clang][OpenMP] Frontend work for sections - D89671.

@Meinersbur For D89671, Johannes had some comments which have been taken care of. I am just waiting for him to get back on it. I'll ping him there.
This patch is done from my end unless someone has some comment/thought.

Apr 21 2021, 9:48 PM · Restricted Project

Apr 15 2021

AMDChirag added a comment to D91054: [Clang][OpenMP] Frontend work for sections - D89671.

You can update the tests as long as long as the output is correct. for example the difference is only in names, ordering of basicblocks and instructions that doesn't affect correctness, etc.

Apr 15 2021, 10:56 PM · Restricted Project
AMDChirag added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Apr 15 2021, 10:54 PM · Restricted Project, Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Incorporated comments.

Apr 15 2021, 10:54 PM · Restricted Project, Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Removed the mistakenly added utils file (common.py)

Apr 15 2021, 4:09 AM · Restricted Project, Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Fixed cancel codegen crash, updated test case.

Apr 15 2021, 4:08 AM · Restricted Project, Restricted Project
AMDChirag updated the diff for D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Fixed cancel construct and applied updates to its test cases

Apr 15 2021, 1:04 AM · Restricted Project

Mar 15 2021

AMDChirag added inline comments to D91054: [Clang][OpenMP] Frontend work for sections - D89671.
Mar 15 2021, 9:49 AM · Restricted Project

Mar 9 2021

AMDChirag accepted D97457: [flang][driver] Add `-fdebug-dump-parsing-log`.
Mar 9 2021, 3:49 AM · Restricted Project, Restricted Project

Mar 1 2021

AMDChirag added a comment to D97457: [flang][driver] Add `-fdebug-dump-parsing-log`.

LGTM.
I'll let someone else review the patch if required.

Mar 1 2021, 5:29 AM · Restricted Project, Restricted Project

Feb 25 2021

AMDChirag added inline comments to D97457: [flang][driver] Add `-fdebug-dump-parsing-log`.
Feb 25 2021, 7:26 AM · Restricted Project, Restricted Project
AMDChirag added inline comments to D97457: [flang][driver] Add `-fdebug-dump-parsing-log`.
Feb 25 2021, 3:45 AM · Restricted Project, Restricted Project

Feb 8 2021

AMDChirag added a comment to D91054: [Clang][OpenMP] Frontend work for sections - D89671.

@fghanim @jdoerfert please review the code if/when possible.

Feb 8 2021, 3:42 AM · Restricted Project

Jan 25 2021

AMDChirag updated the diff for D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Added FIXME comment for cancellation construct not working with sections construct
Also updated the lit test cases to reflect this change.
The lit test case modification will be removed once this issue is resolved.

Jan 25 2021, 12:41 PM · Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Added IsCancellable parameter to EmitOMPInlinedRegion for sections construct.
Even after which, the cancel construct is causing an assertion failure.
For now, this is marked as an expected failure and the FIXME comment is available.
The clang test case (marked XFAIL) is available in frontend patch - D91054.

Jan 25 2021, 9:38 AM · Restricted Project, Restricted Project

Jan 18 2021

AMDChirag abandoned D94373: [LLVM][OpenMP] Added OMP Scheduler Constants (Required for D89671).
Jan 18 2021, 2:36 AM · Restricted Project

Jan 11 2021

AMDChirag added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Currently cancellation clause is failing to work, within sections directive. Working on it.

Jan 11 2021, 6:01 AM · Restricted Project, Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

removed the accidentally added test statement

Jan 11 2021, 2:38 AM · Restricted Project, Restricted Project

Jan 10 2021

AMDChirag updated the diff for D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Added OMP delegating code for createSection (EmitOMPSectionDirective).
@fghanim working on clang lit test case.

Jan 10 2021, 11:12 PM · Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Address a comment.

Jan 10 2021, 10:20 PM · Restricted Project, Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Added the use of createCanonicalLoop and createStaticWorkshareLoop.
Created OMP.createSection for handling the section's code generation.
Section callbacks are no longer a part of createSections.
Modified EmitOMPInlinedRegion to be able to handle nullptr for EntryCall/ExitCall parameters.
Removed changes from OMPConstants.hpp and OMPKinds.def to, originally, move to separate differential, but now are not required since loop creation is handled with createCanonicalLoop and createStaticWorkshareLoop.
OMP.createSections no longer uses EmitOMPInlinedRegion.

Jan 10 2021, 10:16 PM · Restricted Project, Restricted Project
AMDChirag added a comment to D94373: [LLVM][OpenMP] Added OMP Scheduler Constants (Required for D89671).

Please don't merge this differential.
With new changes being done in D89671, this will probably no longer be required.

Jan 10 2021, 9:50 PM · Restricted Project
AMDChirag updated the diff for D94373: [LLVM][OpenMP] Added OMP Scheduler Constants (Required for D89671).

Addressing comment

Jan 10 2021, 9:29 PM · Restricted Project

Jan 9 2021

AMDChirag updated subscribers of D94373: [LLVM][OpenMP] Added OMP Scheduler Constants (Required for D89671).
Jan 9 2021, 10:50 PM · Restricted Project
AMDChirag requested review of D94373: [LLVM][OpenMP] Added OMP Scheduler Constants (Required for D89671).
Jan 9 2021, 10:49 PM · Restricted Project
AMDChirag added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Jan 9 2021, 9:02 PM · Restricted Project, Restricted Project

Jan 8 2021

AMDChirag added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Jan 8 2021, 6:08 AM · Restricted Project, Restricted Project
AMDChirag updated subscribers of D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Jan 8 2021, 5:51 AM · Restricted Project, Restricted Project

Jan 7 2021

AMDChirag added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

@jdoerfert Ouch. Totally forgot about that, apologies, on it.
Would it be fine/better to have the change for that in a separate patch though? Or must it be a part of this patch itself?

Jan 7 2021, 10:01 AM · Restricted Project, Restricted Project
AMDChirag added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Jan 7 2021, 9:12 AM · Restricted Project, Restricted Project

Dec 22 2020

AMDChirag updated the diff for D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Updated BGenCallbackTy to StorableBodyGenCallbackTy.

Dec 22 2020, 5:27 AM · Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Updated information for StoredBodyGenCallbackTy

Dec 22 2020, 5:24 AM · Restricted Project, Restricted Project
AMDChirag updated the diff for D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Updated code according to the changes in LLVM side of things.

Dec 22 2020, 5:11 AM · Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Updated code, test case, fixed some issues

Dec 22 2020, 5:05 AM · Restricted Project, Restricted Project

Dec 2 2020

AMDChirag added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Dec 2 2020, 10:30 PM · Restricted Project, Restricted Project

Nov 24 2020

AMDChirag added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Nov 24 2020, 10:41 PM · Restricted Project, Restricted Project

Nov 23 2020

AMDChirag added inline comments to D91054: [Clang][OpenMP] Frontend work for sections - D89671.
Nov 23 2020, 4:33 AM · Restricted Project
AMDChirag updated the diff for D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Fixed usage of BodyGenCallbackTy
Removed ArrayRef variable

Nov 23 2020, 3:16 AM · Restricted Project

Nov 17 2020

AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Added FiniCB usage and Control Flow Graph

Nov 17 2020, 6:47 AM · Restricted Project, Restricted Project

Nov 9 2020

AMDChirag added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Nov 9 2020, 1:36 AM · Restricted Project, Restricted Project
AMDChirag added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Nov 9 2020, 1:33 AM · Restricted Project, Restricted Project
AMDChirag added a comment to D91054: [Clang][OpenMP] Frontend work for sections - D89671.

The test case will also be added here.

Nov 9 2020, 1:30 AM · Restricted Project
AMDChirag retitled D91054: [Clang][OpenMP] Frontend work for sections - D89671 from [LLVM][OpenMP] Frontend work for sections - D89671 to [Clang][OpenMP] Frontend work for sections - D89671.
Nov 9 2020, 1:15 AM · Restricted Project
AMDChirag requested review of D91054: [Clang][OpenMP] Frontend work for sections - D89671.
Nov 9 2020, 1:03 AM · Restricted Project

Nov 5 2020

AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Minor corrections in naming

Nov 5 2020, 7:47 AM · Restricted Project, Restricted Project

Nov 3 2020

AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

squashed the commits

Nov 3 2020, 12:56 AM · Restricted Project, Restricted Project

Nov 2 2020

AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Applied some review changes

Nov 2 2020, 5:23 AM · Restricted Project, Restricted Project

Oct 21 2020

AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Amended the original commit, applying the fixes:

Oct 21 2020, 1:46 AM · Restricted Project, Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Oct 21 2020, 1:39 AM · Restricted Project, Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Oct 21 2020, 12:47 AM · Restricted Project, Restricted Project

Oct 19 2020

AMDChirag added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

@fghanim Hello and thank you!

Oct 19 2020, 9:02 PM · Restricted Project, Restricted Project
AMDChirag retitled D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder from [Flang][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder to [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Oct 19 2020, 8:47 PM · Restricted Project, Restricted Project
AMDChirag added a reviewer for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder: kiranktp.
Oct 19 2020, 1:05 AM · Restricted Project, Restricted Project
AMDChirag requested review of D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Oct 19 2020, 12:39 AM · Restricted Project, Restricted Project