@jdoerfert Could you please take a look at this patch as well? (especially for the clang part)
Tue, Jun 29
Mon, Jun 28
@kiranchandramohan The tests passed now!
Jun 22 2021
@kiranchandramohan It failed again. Apparently, it automatically attempted to add a patch D93105 which is already merged. I removed that patch as dependency before (edit related revisions), but it seems to have been added again.
Am I missing something?
Oh great! That triggered it!
It could be because you are not the author. Can you commandeer the patch (option available in the Add Action menu below)?
Hi @kiranchandramohan How do I restart the build? It says I don't have permission.
Jun 21 2021
Rebased to main
Fixes the clang test cases
Jun 1 2021
LGTM. I'll let someone else take a look too.
Apr 29 2021
Rebase to retrigger build
Rebased to HEAD of main branch
Rebased to HEAD of main branch
Apr 28 2021
Apr 27 2021
Apr 23 2021
Apr 22 2021
What is missing or not working in the IRBuilder impl that prevents us from turning it on by default?
Apr 21 2021
@jdoerfert Anything else to do here? Can this be merged?
@Meinersbur For D89671, Johannes had some comments which have been taken care of. I am just waiting for him to get back on it. I'll ping him there.
This patch is done from my end unless someone has some comment/thought.
Apr 15 2021
You can update the tests as long as long as the output is correct. for example the difference is only in names, ordering of basicblocks and instructions that doesn't affect correctness, etc.
Removed the mistakenly added utils file (common.py)
Fixed cancel codegen crash, updated test case.
Fixed cancel construct and applied updates to its test cases
Mar 15 2021
Mar 9 2021
Mar 1 2021
I'll let someone else review the patch if required.
Feb 25 2021
Feb 8 2021
Jan 25 2021
Added FIXME comment for cancellation construct not working with sections construct
Also updated the lit test cases to reflect this change.
The lit test case modification will be removed once this issue is resolved.
Added IsCancellable parameter to EmitOMPInlinedRegion for sections construct.
Even after which, the cancel construct is causing an assertion failure.
For now, this is marked as an expected failure and the FIXME comment is available.
The clang test case (marked XFAIL) is available in frontend patch - D91054.
Jan 18 2021
Jan 11 2021
Currently cancellation clause is failing to work, within sections directive. Working on it.
removed the accidentally added test statement
Jan 10 2021
Added OMP delegating code for createSection (EmitOMPSectionDirective).
@fghanim working on clang lit test case.
Address a comment.
Added the use of createCanonicalLoop and createStaticWorkshareLoop.
Created OMP.createSection for handling the section's code generation.
Section callbacks are no longer a part of createSections.
Modified EmitOMPInlinedRegion to be able to handle nullptr for EntryCall/ExitCall parameters.
Removed changes from OMPConstants.hpp and OMPKinds.def to, originally, move to separate differential, but now are not required since loop creation is handled with createCanonicalLoop and createStaticWorkshareLoop.
OMP.createSections no longer uses EmitOMPInlinedRegion.
Please don't merge this differential.
With new changes being done in D89671, this will probably no longer be required.
Jan 9 2021
Jan 8 2021
Jan 7 2021
@jdoerfert Ouch. Totally forgot about that, apologies, on it.
Would it be fine/better to have the change for that in a separate patch though? Or must it be a part of this patch itself?
Dec 22 2020
Updated BGenCallbackTy to StorableBodyGenCallbackTy.
Updated information for StoredBodyGenCallbackTy
Updated code according to the changes in LLVM side of things.
Updated code, test case, fixed some issues
Dec 2 2020
Nov 24 2020
Nov 23 2020
Fixed usage of BodyGenCallbackTy
Removed ArrayRef variable
Nov 17 2020
Added FiniCB usage and Control Flow Graph
Nov 9 2020
The test case will also be added here.
Nov 5 2020
Minor corrections in naming
Nov 3 2020
squashed the commits
Nov 2 2020
Applied some review changes
Oct 21 2020
Amended the original commit, applying the fixes:
Oct 19 2020
@fghanim Hello and thank you!