Page MenuHomePhabricator
Feed Advanced Search

Jul 1 2019

brucem added a comment to D43159: Modernize: Use nullptr more..

In addition to my previous explanation for the concerns about using nullptr more ... it should be noted that many of these files already use nullptr.

Jul 1 2019, 9:35 AM
brucem updated the diff for D43159: Modernize: Use nullptr more..

Updating to current master.

Jul 1 2019, 9:32 AM
brucem committed rG4603460a3956: __threading_support: Remove (void) in favor of (). (authored by brucem).
__threading_support: Remove (void) in favor of ().
Jul 1 2019, 9:21 AM
brucem committed rL364799: __threading_support: Remove (void) in favor of ()..
__threading_support: Remove (void) in favor of ().
Jul 1 2019, 9:20 AM
brucem closed D43226: __threading_support: Remove (void) in favor of ()..
Jul 1 2019, 9:20 AM · Restricted Project
brucem committed rGba41d3b1fd68: Fix -Wdouble-promotion warnings. (authored by brucem).
Fix -Wdouble-promotion warnings.
Jul 1 2019, 9:14 AM
brucem committed rL364798: Fix -Wdouble-promotion warnings..
Fix -Wdouble-promotion warnings.
Jul 1 2019, 9:13 AM
brucem closed D62782: Fix -Wdouble-promotion warnings..
Jul 1 2019, 9:13 AM · Restricted Project

Jun 4 2019

brucem added a comment to D62782: Fix -Wdouble-promotion warnings..

I'd modified CMakeLists.txt to add -Wdouble-promotion and removed this line: -Wno-double-promotion # FIXME: remove me ...

Jun 4 2019, 8:00 AM · Restricted Project

Jun 1 2019

brucem created D62782: Fix -Wdouble-promotion warnings..
Jun 1 2019, 10:53 AM · Restricted Project
brucem added a comment to D43159: Modernize: Use nullptr more..

What was the result of testing with -std=c++98 and/or -std=gnu++98 ?
The code changes look fine; but as @EricWF said....

Jun 1 2019, 10:44 AM
brucem added inline comments to D43159: Modernize: Use nullptr more..
Jun 1 2019, 10:22 AM
brucem updated the diff for D43159: Modernize: Use nullptr more..

More nullptr-ification.

Jun 1 2019, 10:21 AM
brucem updated the diff for D43159: Modernize: Use nullptr more..

Remove CMakeLists.txt change.

Jun 1 2019, 8:30 AM
brucem updated the diff for D43159: Modernize: Use nullptr more..

Updated to current master and added more nullptr usage.

Jun 1 2019, 8:27 AM
brucem added a comment to D43226: __threading_support: Remove (void) in favor of ()..

Can we revive this review? I'd still like to land it ...

Jun 1 2019, 4:49 AM · Restricted Project
brucem added a comment to D43159: Modernize: Use nullptr more..

Can we revive this review? I'd still like to land this ...

Jun 1 2019, 4:49 AM

Dec 6 2018

brucem added a comment to D55376: Generate LLDB website/documentation from rst with Sphinx.

This sounds great to me.

Dec 6 2018, 9:07 AM · Restricted Project
brucem added a comment to D55361: Move Broadcaster+Listener+Event combo from Core into Utility.

I recognize that it might be dull, but should you re-sort the various include lists so that the now-in-Utility headers are listed with the other Utility headers?

Dec 6 2018, 3:16 AM

Nov 26 2018

brucem committed rLLDB347637: Add support for the Dylan language to ClangASTContext.
Add support for the Dylan language to ClangASTContext
Nov 26 2018, 9:40 PM
brucem committed rL347637: Add support for the Dylan language to ClangASTContext.
Add support for the Dylan language to ClangASTContext
Nov 26 2018, 9:40 PM
brucem closed D54886: Add support for the Dylan language to ClangASTContext.
Nov 26 2018, 9:40 PM
brucem added a comment to D54886: Add support for the Dylan language to ClangASTContext.

I can land this today.

Nov 26 2018, 8:21 PM

Nov 25 2018

brucem added a reviewer for D54886: Add support for the Dylan language to ClangASTContext: clayborg.
Nov 25 2018, 10:50 PM

Oct 4 2018

brucem committed rL343825: Fix typos..
Fix typos.
Oct 4 2018, 3:35 PM
brucem committed rLLDB343825: Fix typos..
Fix typos.
Oct 4 2018, 3:35 PM
brucem closed D52884: Fix typos..
Oct 4 2018, 3:35 PM
brucem closed D52884: Fix typos..
Oct 4 2018, 3:35 PM
brucem created D52884: Fix typos..
Oct 4 2018, 6:04 AM

Jun 29 2018

brucem requested changes to D48775: Add new SBTarget::IsDummy method..
Jun 29 2018, 9:45 AM

May 29 2018

brucem committed rL333400: Remove Linux-specific includes for posix/FileSystem.cpp.
Remove Linux-specific includes for posix/FileSystem.cpp
May 29 2018, 2:19 AM
brucem closed D47420: Remove Linux-specific includes for posix/FileSystem.cpp.
May 29 2018, 2:18 AM
brucem committed rL333399: Typo fixes..
Typo fixes.
May 29 2018, 2:15 AM
brucem closed D47421: Typo fixes..
May 29 2018, 2:14 AM

May 27 2018

brucem updated the diff for D47421: Typo fixes..

A couple of additional fixes.

May 27 2018, 6:40 AM
brucem created D47421: Typo fixes..
May 27 2018, 5:41 AM
brucem created D47420: Remove Linux-specific includes for posix/FileSystem.cpp.
May 27 2018, 5:36 AM

Feb 15 2018

brucem added a comment to D43277: limits: Use `false` instead of `type(0)`..

Without this, anyone using clang-tidy with this check gets 6 system header warnings whenever they transitively have included limits.

Feb 15 2018, 8:18 PM
brucem added a comment to D43226: __threading_support: Remove (void) in favor of ()..

This is modernize-redundant-void-arg: https://clang.llvm.org/extra/clang-tidy/checks/modernize-redundant-void-arg.html

Feb 15 2018, 8:18 PM · Restricted Project

Feb 13 2018

brucem created D43277: limits: Use `false` instead of `type(0)`..
Feb 13 2018, 8:47 PM
brucem committed rCXX325087: Fix incorrect indentation..
Fix incorrect indentation.
Feb 13 2018, 4:31 PM
brucem committed rL325087: Fix incorrect indentation..
Fix incorrect indentation.
Feb 13 2018, 4:31 PM
brucem closed D43167: Fix incorrect indentation..
Feb 13 2018, 4:31 PM
brucem created D43226: __threading_support: Remove (void) in favor of ()..
Feb 13 2018, 12:19 AM · Restricted Project
brucem added a reviewer for D43167: Fix incorrect indentation.: EricWF.
Feb 13 2018, 12:16 AM
brucem updated the diff for D43167: Fix incorrect indentation..

Rebased forward.

Feb 13 2018, 12:16 AM
brucem committed rCXX324989: Fix typos..
Fix typos.
Feb 13 2018, 12:14 AM
brucem committed rL324989: Fix typos..
Fix typos.
Feb 13 2018, 12:14 AM
brucem closed D43224: Fix typos..
Feb 13 2018, 12:13 AM

Feb 12 2018

brucem created D43224: Fix typos..
Feb 12 2018, 11:22 PM
brucem added a comment to D43159: Modernize: Use nullptr more..

Is it worth adding -Werror=zero-as-null-pointer-constant to the build?

Feb 12 2018, 10:58 PM
brucem added a comment to D43159: Modernize: Use nullptr more..
In D43159#1004639, @dim wrote:

So my main concern with this patch is that nullptr is actually #defined'ed in C++03 mode. That definition comes from the __nullptr header, and therefore we would need to add that header to each include which uses it. Which kind of sucks.

Indeed, but isn't nullptr used in many headers already? And as far as I can see, none of those includes <__nullptr> explicitly, so the definition must come from some transitive include.

Feb 12 2018, 10:53 PM
brucem updated the diff for D43159: Modernize: Use nullptr more..

Addressed minor issues.

Feb 12 2018, 10:51 PM

Feb 10 2018

brucem created D43167: Fix incorrect indentation..
Feb 10 2018, 5:31 PM
brucem updated the diff for D43159: Modernize: Use nullptr more..

More nullptr usage.

Feb 10 2018, 5:17 PM
brucem created D43159: Modernize: Use nullptr more..
Feb 10 2018, 7:27 AM

Feb 5 2018

brucem created D42945: [libc++] Fix misleading indentation..
Feb 5 2018, 8:50 PM

Aug 21 2017

brucem committed rL311399: lldb-argdumper doesn't need lldbCore..
lldb-argdumper doesn't need lldbCore.
Aug 21 2017, 3:56 PM
brucem closed D36948: lldb-argdumper doesn't need lldbCore. by committing rL311399: lldb-argdumper doesn't need lldbCore..
Aug 21 2017, 3:56 PM

Aug 20 2017

brucem created D36948: lldb-argdumper doesn't need lldbCore..
Aug 20 2017, 11:24 PM

Jul 21 2017

brucem committed rL308716: Fix typo in error message in 'platform status'..
Fix typo in error message in 'platform status'.
Jul 21 2017, 12:10 AM

Jul 19 2017

brucem committed rL308480: Expose hit count via SBBreakpointLocation..
Expose hit count via SBBreakpointLocation.
Jul 19 2017, 7:32 AM
brucem closed D31283: Expose hit count via SBBreakpointLocation. by committing rL308480: Expose hit count via SBBreakpointLocation..
Jul 19 2017, 7:32 AM
brucem updated the diff for D31283: Expose hit count via SBBreakpointLocation..

Update per comments.

Jul 19 2017, 7:16 AM
brucem added a reviewer for D31283: Expose hit count via SBBreakpointLocation.: labath.

Pavel, since Jim was okay with this before apart from it not having a test, want to take a quick look now? Thanks!

Jul 19 2017, 3:14 AM
brucem removed a reviewer for D14182: Centos 5 compile fixes for lldb: brucem.
Jul 19 2017, 3:11 AM
brucem updated the diff for D31283: Expose hit count via SBBreakpointLocation..

Add a test.

Jul 19 2017, 2:59 AM
brucem committed rL308426: Fix typos in documentation..
Fix typos in documentation.
Jul 19 2017, 2:38 AM
brucem closed D31282: Fix typos in documentation. by committing rL308426: Fix typos in documentation..
Jul 19 2017, 2:38 AM
brucem committed rL308425: Update API headers..
Update API headers.
Jul 19 2017, 2:32 AM
brucem closed D35614: Update API headers. by committing rL308425: Update API headers..
Jul 19 2017, 2:32 AM
brucem created D35614: Update API headers..
Jul 19 2017, 2:20 AM

Mar 23 2017

brucem committed rL298601: [libcxx] Improve code generation for vector::clear()..
[libcxx] Improve code generation for vector::clear().
Mar 23 2017, 7:51 AM
brucem closed D25241: [libcxx] Improve code generation for vector::clear(). by committing rL298601: [libcxx] Improve code generation for vector::clear()..
Mar 23 2017, 7:51 AM
brucem added a comment to D25241: [libcxx] Improve code generation for vector::clear()..

This was accepted long ago, and then I got sidetracked for a while. Is this still okay to land?

Mar 23 2017, 6:44 AM
brucem created D31283: Expose hit count via SBBreakpointLocation..
Mar 23 2017, 6:41 AM
brucem created D31282: Fix typos in documentation..
Mar 23 2017, 6:41 AM
brucem committed rL298585: Fix warnings from clang build on macOS..
Fix warnings from clang build on macOS.
Mar 23 2017, 3:04 AM
brucem closed D31279: Fix warnings from clang build on macOS. by committing rL298585: Fix warnings from clang build on macOS..
Mar 23 2017, 3:04 AM
brucem created D31279: Fix warnings from clang build on macOS..
Mar 23 2017, 12:05 AM

Oct 20 2016

brucem added a comment to D25241: [libcxx] Improve code generation for vector::clear()..

These have been addressed, so this should be good for further review.

Oct 20 2016, 3:06 AM

Oct 6 2016

brucem updated the diff for D25241: [libcxx] Improve code generation for vector::clear()..

Address comments from mclow.

Oct 6 2016, 6:30 AM

Oct 4 2016

brucem added a reviewer for D25241: [libcxx] Improve code generation for vector::clear().: mclow.lists.
Oct 4 2016, 9:13 AM
brucem retitled D25241: [libcxx] Improve code generation for vector::clear(). from to [libcxx] Improve code generation for vector::clear()..
Oct 4 2016, 9:12 AM

Aug 28 2016

brucem added inline comments to D23977: Support of lldb on Kfreebsd .
Aug 28 2016, 9:13 PM · Restricted Project

Nov 14 2015

brucem committed rL253153: Add more autotools/gmake NetBSD glue.
Add more autotools/gmake NetBSD glue
Nov 14 2015, 6:02 PM
brucem closed D14531: Add more autotools/gmake NetBSD glue by committing rL253153: Add more autotools/gmake NetBSD glue.
Nov 14 2015, 6:02 PM
brucem committed rL253152: Allow to override python-config executable name from command line.
Allow to override python-config executable name from command line
Nov 14 2015, 5:59 PM
brucem closed D14528: Allow to override python-config executable name from command line by committing rL253152: Allow to override python-config executable name from command line.
Nov 14 2015, 5:59 PM
brucem committed rL253151: Use library discovery for curses and panel.
Use library discovery for curses and panel
Nov 14 2015, 5:56 PM
brucem closed D14529: Use library discovery for curses and panel by committing rL253151: Use library discovery for curses and panel.
Nov 14 2015, 5:55 PM

Nov 13 2015

brucem added a reviewer for D14530: Plug-in PlatformNetBSD initializer and terminator: clayborg.
Nov 13 2015, 5:48 AM
brucem added a reviewer for D14529: Use library discovery for curses and panel: clayborg.
Nov 13 2015, 5:47 AM

Nov 7 2015

brucem committed rL252403: Add more NetBSD platform glue for lldb.
Add more NetBSD platform glue for lldb
Nov 7 2015, 7:34 AM
brucem closed D14042: Add more NetBSD platform glue for lldb by committing rL252403: Add more NetBSD platform glue for lldb.
Nov 7 2015, 7:34 AM

Nov 6 2015

brucem committed rL252396: Make lldb::endian::InlHostByteOrder() private..
Make lldb::endian::InlHostByteOrder() private.
Nov 6 2015, 8:43 PM
brucem closed D14417: Make lldb::endian::InlHostByteOrder() private. by committing rL252396: Make lldb::endian::InlHostByteOrder() private..
Nov 6 2015, 8:42 PM
brucem added a comment to D14042: Add more NetBSD platform glue for lldb.

Kamil, please rebase forward and I'll land it.

Nov 6 2015, 8:10 PM
brucem committed rL252330: [swig] Remove check_lldb_swig_executable_file_exists..
[swig] Remove check_lldb_swig_executable_file_exists.
Nov 6 2015, 10:56 AM
brucem closed D14415: [swig] Simplify check_lldb_swig_executable_file_exists. by committing rL252330: [swig] Remove check_lldb_swig_executable_file_exists..
Nov 6 2015, 10:56 AM