Page MenuHomePhabricator
Feed Advanced Search

Tue, Nov 29

jreiffers accepted D138915: [mlir][bufferization][WIP] Make `TensorCopyInsertionPass` a test pass.

Thanks for the fix!

Tue, Nov 29, 6:22 AM · Restricted Project, Restricted Project

Sat, Nov 26

jreiffers accepted D138745: [mlir][tensor][bufferize] Fix tensor.insert_slice regression.

Thanks for the fix!

Sat, Nov 26, 6:57 AM · Restricted Project, Restricted Project

Thu, Nov 17

jreiffers accepted D138266: [llvm][Bazel] Remove dependency to avoid cycyle..
Thu, Nov 17, 11:50 PM · Restricted Project, Restricted Project

Mon, Nov 14

jreiffers committed rG67df73030f66: Update bazel files. (authored by jreiffers).
Update bazel files.
Mon, Nov 14, 10:49 PM · Restricted Project

Sun, Nov 13

jreiffers committed rGc9845735a619: Add missing include. (authored by jreiffers).
Add missing include.
Sun, Nov 13, 11:15 PM · Restricted Project, Restricted Project

Tue, Nov 8

jreiffers committed rG2525fddae8ed: Fix build file for PDLL tests. (authored by jreiffers).
Fix build file for PDLL tests.
Tue, Nov 8, 4:24 AM · Restricted Project
jreiffers committed rG000aecafce78: Add missing PDLL libs. (authored by jreiffers).
Add missing PDLL libs.
Tue, Nov 8, 3:14 AM · Restricted Project
jreiffers committed rGe7bb54d4fd2a: Add missing build deps. (authored by jreiffers).
Add missing build deps.
Tue, Nov 8, 2:45 AM · Restricted Project
jreiffers committed rGeee5c3859e78: Suppress warning for unused variable if assertions are disabled. (authored by jreiffers).
Suppress warning for unused variable if assertions are disabled.
Tue, Nov 8, 2:15 AM · Restricted Project, Restricted Project
jreiffers closed D137621: Suppress warning for unused variable if assertions are disabled..
Tue, Nov 8, 2:14 AM · Restricted Project, Restricted Project
jreiffers requested review of D137621: Suppress warning for unused variable if assertions are disabled..
Tue, Nov 8, 2:13 AM · Restricted Project, Restricted Project

Oct 24 2022

jreiffers abandoned D136597: build.bazel: Add missing dep to SparseTensorPipelines..
Oct 24 2022, 7:18 AM · Restricted Project, Restricted Project
jreiffers updated the diff for D136597: build.bazel: Add missing dep to SparseTensorPipelines..

Actually use the correct dependency.

Oct 24 2022, 7:12 AM · Restricted Project, Restricted Project
jreiffers requested review of D136597: build.bazel: Add missing dep to SparseTensorPipelines..
Oct 24 2022, 7:11 AM · Restricted Project, Restricted Project

Oct 7 2022

jreiffers accepted D135420: [mlir][bufferize] Fix repetitive region conflict detection.

Thanks for the fix!

Oct 7 2022, 12:24 AM · Restricted Project, Restricted Project

Sep 22 2022

jreiffers committed rGeaf20c4fc257: [mlir] Fix a cast that should be a dyn_cast. (authored by jreiffers).
[mlir] Fix a cast that should be a dyn_cast.
Sep 22 2022, 4:13 AM · Restricted Project, Restricted Project
jreiffers closed D134424: [mlir] Fix a cast that should be a dyn_cast..
Sep 22 2022, 4:13 AM · Restricted Project, Restricted Project
jreiffers requested review of D134424: [mlir] Fix a cast that should be a dyn_cast..
Sep 22 2022, 4:02 AM · Restricted Project, Restricted Project

Sep 20 2022

jreiffers accepted D134331: [mlir][tensor][bufferize] Implement getBufferType for Expand/CollapseShapeOp.

Thanks, I was about to do just that :-).

Sep 20 2022, 11:19 PM · Restricted Project, Restricted Project

Sep 16 2022

jreiffers committed rG78f4a02aef57: Fixes for D133947. (authored by jreiffers).
Fixes for D133947.
Sep 16 2022, 2:39 AM · Restricted Project, Restricted Project
jreiffers committed rGd7c606f5b7f4: Fix bufferization of collapse_shape of subviews with size 1 dims. (authored by jreiffers).
Fix bufferization of collapse_shape of subviews with size 1 dims.
Sep 16 2022, 2:33 AM · Restricted Project, Restricted Project
jreiffers closed D134026: Fix bufferization of collapse_shape of subviews with size 1 dims..
Sep 16 2022, 2:32 AM · Restricted Project, Restricted Project
jreiffers requested review of D134026: Fix bufferization of collapse_shape of subviews with size 1 dims..
Sep 16 2022, 2:10 AM · Restricted Project, Restricted Project

Sep 8 2022

jreiffers committed rGd1536ee48c3b: Fix clang-format. (authored by jreiffers).
Fix clang-format.
Sep 8 2022, 2:05 AM · Restricted Project, Restricted Project
jreiffers committed rG6247988e0751: One-shot-bufferize: fix for inconsistent while arg types in before/after. (authored by jreiffers).
One-shot-bufferize: fix for inconsistent while arg types in before/after.
Sep 8 2022, 1:24 AM · Restricted Project, Restricted Project
jreiffers closed D133477: One-shot-bufferize: fix for inconsistent while arg types in before/after..
Sep 8 2022, 1:24 AM · Restricted Project, Restricted Project
jreiffers requested review of D133477: One-shot-bufferize: fix for inconsistent while arg types in before/after..
Sep 8 2022, 12:39 AM · Restricted Project, Restricted Project

Sep 7 2022

jreiffers committed rGfb9fc79809d5: One-shot-bufferize: allow non-tensor arguments in scg.while/for. (authored by jreiffers).
One-shot-bufferize: allow non-tensor arguments in scg.while/for.
Sep 7 2022, 6:54 AM · Restricted Project, Restricted Project
jreiffers closed D133419: One-shot-bufferize: allow non-tensor arguments in scg.while/for..
Sep 7 2022, 6:54 AM · Restricted Project, Restricted Project
jreiffers requested review of D133419: One-shot-bufferize: allow non-tensor arguments in scg.while/for..
Sep 7 2022, 5:36 AM · Restricted Project, Restricted Project

Sep 5 2022

jreiffers committed rG34f4a9ef2a1d: Add ArithBuilder::sub, make add, mul work with IndexTypes. (authored by jreiffers).
Add ArithBuilder::sub, make add, mul work with IndexTypes.
Sep 5 2022, 3:44 AM · Restricted Project, Restricted Project
jreiffers closed D133285: Add ArithBuilder::sub, make add, mul work with IndexTypes..
Sep 5 2022, 3:44 AM · Restricted Project, Restricted Project
jreiffers requested review of D133285: Add ArithBuilder::sub, make add, mul work with IndexTypes..
Sep 5 2022, 2:28 AM · Restricted Project, Restricted Project

Aug 30 2022

jreiffers committed rG23dec4a3524a: Move BufferViewFlowAnalysis to the Bufferization dialect. (authored by jreiffers).
Move BufferViewFlowAnalysis to the Bufferization dialect.
Aug 30 2022, 5:26 AM · Restricted Project, Restricted Project
jreiffers closed D132928: Move BufferViewFlowAnalysis to the Bufferization dialect..
Aug 30 2022, 5:26 AM · Restricted Project, Restricted Project
jreiffers added inline comments to D132460: buffer-deallocation: consider aliases introduced by arith.select..
Aug 30 2022, 4:16 AM · Restricted Project, Restricted Project
jreiffers requested review of D132928: Move BufferViewFlowAnalysis to the Bufferization dialect..
Aug 30 2022, 4:16 AM · Restricted Project, Restricted Project

Aug 29 2022

jreiffers added inline comments to D132460: buffer-deallocation: consider aliases introduced by arith.select..
Aug 29 2022, 10:42 PM · Restricted Project, Restricted Project

Aug 23 2022

jreiffers committed rG27a1a85662e6: buffer-deallocation: consider aliases introduced by arith.select. (authored by jreiffers).
buffer-deallocation: consider aliases introduced by arith.select.
Aug 23 2022, 5:37 AM · Restricted Project, Restricted Project
jreiffers closed D132460: buffer-deallocation: consider aliases introduced by arith.select..
Aug 23 2022, 5:37 AM · Restricted Project, Restricted Project
jreiffers added a comment to D132460: buffer-deallocation: consider aliases introduced by arith.select..

Thanks!

Aug 23 2022, 5:22 AM · Restricted Project, Restricted Project
jreiffers updated the diff for D132460: buffer-deallocation: consider aliases introduced by arith.select..

Fix CMakeLists, add a TODO.

Aug 23 2022, 5:22 AM · Restricted Project, Restricted Project
jreiffers updated the diff for D132460: buffer-deallocation: consider aliases introduced by arith.select..

Remove accidental --dump-input.

Aug 23 2022, 5:02 AM · Restricted Project, Restricted Project
jreiffers requested review of D132460: buffer-deallocation: consider aliases introduced by arith.select..
Aug 23 2022, 4:12 AM · Restricted Project, Restricted Project

Aug 15 2022

jreiffers committed rG375a5cb64883: Don't lower log1p(x) to log(1 + x). (authored by jreiffers).
Don't lower log1p(x) to log(1 + x).
Aug 15 2022, 9:58 PM · Restricted Project, Restricted Project
jreiffers closed D131676: Don't lower log1p(x) to log(1 + x)..
Aug 15 2022, 9:58 PM · Restricted Project, Restricted Project

Aug 11 2022

jreiffers accepted D131689: [mlir][bufferize] Fix missing copy when bufferizing loops.

Thanks for the quick fix!

Aug 11 2022, 1:40 PM · Restricted Project, Restricted Project
jreiffers requested review of D131676: Don't lower log1p(x) to log(1 + x)..
Aug 11 2022, 6:56 AM · Restricted Project, Restricted Project

Aug 5 2022

jreiffers added a comment to D129745: Fix a stack overflow in ScalarEvolution..

It's too generic, it should ideally be more clear about which stack overflow was fixed for example.

Aug 5 2022, 5:19 AM · Restricted Project, Restricted Project
jreiffers added a comment to D129745: Fix a stack overflow in ScalarEvolution..

It might be good to adjust the commit message to be a bit more precise about the actual fix.

It would have been good to improve the commit title....

Aug 5 2022, 4:03 AM · Restricted Project, Restricted Project

Aug 3 2022

jreiffers committed rG3e9e43b48eb7: Fix compiler error: init-statements in if/switch. (authored by jreiffers).
Fix compiler error: init-statements in if/switch.
Aug 3 2022, 2:37 AM · Restricted Project, Restricted Project
jreiffers closed D131061: Fix compiler error: init-statements in if/switch..
Aug 3 2022, 2:36 AM · Restricted Project, Restricted Project
jreiffers updated the diff for D131061: Fix compiler error: init-statements in if/switch..

Fix formatting.

Aug 3 2022, 2:35 AM · Restricted Project, Restricted Project
jreiffers requested review of D131061: Fix compiler error: init-statements in if/switch..
Aug 3 2022, 2:32 AM · Restricted Project, Restricted Project
jreiffers committed rG7ae5d00afaf3: Fix a stack overflow in ScalarEvolution. (authored by jreiffers).
Fix a stack overflow in ScalarEvolution.
Aug 3 2022, 2:08 AM · Restricted Project, Restricted Project
jreiffers closed D129745: Fix a stack overflow in ScalarEvolution..
Aug 3 2022, 2:08 AM · Restricted Project, Restricted Project
jreiffers added a comment to D129745: Fix a stack overflow in ScalarEvolution..

Thanks for the reviews and discussion!

Aug 3 2022, 12:25 AM · Restricted Project, Restricted Project

Aug 2 2022

jreiffers added a comment to D129745: Fix a stack overflow in ScalarEvolution..

@fhahn The recursion loop is createSCEV -> isSCEVExprNeverPoison -> createSCEVIter -> createSCEV (see also the summary of this change).

Aug 2 2022, 12:31 AM · Restricted Project, Restricted Project

Jul 31 2022

jreiffers accepted D130706: [mlir] Reuse the code between `getMixed*s()` funcs in ViewLikeInterface.cpp..
Jul 31 2022, 11:56 AM · Restricted Project, Restricted Project

Jul 28 2022

jreiffers added inline comments to D130706: [mlir] Reuse the code between `getMixed*s()` funcs in ViewLikeInterface.cpp..
Jul 28 2022, 7:04 AM · Restricted Project, Restricted Project

Jul 25 2022

jreiffers updated the diff for D129745: Fix a stack overflow in ScalarEvolution..

Rebase changes.

Jul 25 2022, 1:23 AM · Restricted Project, Restricted Project

Jul 18 2022

jreiffers added a comment to D129745: Fix a stack overflow in ScalarEvolution..

Friendly ping on this.

Jul 18 2022, 8:44 AM · Restricted Project, Restricted Project

Jul 15 2022

jreiffers added a comment to D129745: Fix a stack overflow in ScalarEvolution..
Jul 15 2022, 2:20 PM · Restricted Project, Restricted Project

Jul 14 2022

jreiffers added a comment to D129745: Fix a stack overflow in ScalarEvolution..

Ah sorry, my wording here was really ambiguous: By "optimization" I was referring to the compile-time optimization of combining operands from multiple add/muls, rather than just creating pairwise expressions. The preservation of nowrap flags via UB reasoning is important, and not something that can be dropped.

Jul 14 2022, 11:44 AM · Restricted Project, Restricted Project
jreiffers added a comment to D129745: Fix a stack overflow in ScalarEvolution..

Would it be possible to share a reproducer? Is this a new stack overflow?

Jul 14 2022, 9:13 AM · Restricted Project, Restricted Project
jreiffers added a comment to D129745: Fix a stack overflow in ScalarEvolution..

Before doing something like this, we should evaluate compile-time impact of dropping this optimization entirely.

Jul 14 2022, 2:17 AM · Restricted Project, Restricted Project
jreiffers requested review of D129745: Fix a stack overflow in ScalarEvolution..
Jul 14 2022, 2:06 AM · Restricted Project, Restricted Project

Jul 12 2022

jreiffers committed rGad3a078745d9: Fix linalg.dot over boolean tensors. (authored by jreiffers).
Fix linalg.dot over boolean tensors.
Jul 12 2022, 12:09 AM · Restricted Project, Restricted Project
jreiffers closed D129292: Fix linalg.dot over boolean tensors..
Jul 12 2022, 12:08 AM · Restricted Project, Restricted Project
jreiffers retitled D129292: Fix linalg.dot over boolean tensors. from Fix linalg.dot over boolean tensors with --xla_cpu_enable_mlir_lowering=true. to Fix linalg.dot over boolean tensors..
Jul 12 2022, 12:08 AM · Restricted Project, Restricted Project

Jul 8 2022

jreiffers updated the diff for D129292: Fix linalg.dot over boolean tensors..

Fix clang-format.

Jul 8 2022, 1:50 AM · Restricted Project, Restricted Project

Jul 7 2022

jreiffers added a comment to D129292: Fix linalg.dot over boolean tensors..

<snip>

Jul 7 2022, 11:45 AM · Restricted Project, Restricted Project
jreiffers updated the diff for D129292: Fix linalg.dot over boolean tensors..

Fix linalg.dot over boolean tensors.

Jul 7 2022, 11:44 AM · Restricted Project, Restricted Project
jreiffers abandoned D129313: Fix linalg.dot over boolean tensors..
Jul 7 2022, 11:43 AM · Restricted Project, Restricted Project
jreiffers updated the summary of D129313: Fix linalg.dot over boolean tensors..
Jul 7 2022, 11:40 AM · Restricted Project, Restricted Project
jreiffers requested review of D129313: Fix linalg.dot over boolean tensors..
Jul 7 2022, 11:39 AM · Restricted Project, Restricted Project
jreiffers requested review of D129292: Fix linalg.dot over boolean tensors..
Jul 7 2022, 7:30 AM · Restricted Project, Restricted Project