Page MenuHomePhabricator
Feed Advanced Search

Yesterday

evandro added a comment to D68353: [AArch64] Remove overlapping definitions (NFC).

馃敂 隆Ping! 馃敂

Thu, Oct 17, 10:04 AMRestricted Project

Fri, Oct 11

evandro added a comment to D67199: [InstCombine] Expand the simplification of log().

For the record, the issue reported in PR43617 was fixed by rL374243 and a test case was added by rL374453.

Fri, Oct 11, 11:30 AMRestricted Project

Thu, Oct 10

evandro committed rG8bd42769816a: [InstCombine] Add test case for PR43617 (NFC) (authored by evandro).
[InstCombine] Add test case for PR43617 (NFC)
Thu, Oct 10, 2:34 PM
evandro committed rL374453: [InstCombine] Add test case for PR43617 (NFC).
[InstCombine] Add test case for PR43617 (NFC)
Thu, Oct 10, 2:34 PM

Wed, Oct 9

evandro committed rGd2f4c452d9e6: [InstCombine] Fix PR43617 (authored by evandro).
[InstCombine] Fix PR43617
Wed, Oct 9, 3:05 PM
evandro committed rL374243: [InstCombine] Fix PR43617.
[InstCombine] Fix PR43617
Wed, Oct 9, 3:04 PM
evandro updated subscribers of D67199: [InstCombine] Expand the simplification of log().
Wed, Oct 9, 1:29 PMRestricted Project
evandro committed rGc57a9dc487e3: [AMDGPU] Use math constants defined in MathExtras (NFC) (authored by evandro).
[AMDGPU] Use math constants defined in MathExtras (NFC)
Wed, Oct 9, 1:01 PM
evandro committed rGe60415a0db2b: [Support] Add mathematical constants (authored by evandro).
[Support] Add mathematical constants
Wed, Oct 9, 1:01 PM
evandro closed D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Wed, Oct 9, 1:01 PMRestricted Project
evandro committed rL374208: [AMDGPU] Use math constants defined in MathExtras (NFC).
[AMDGPU] Use math constants defined in MathExtras (NFC)
Wed, Oct 9, 1:01 PM
evandro committed rL374207: [Support] Add mathematical constants.
[Support] Add mathematical constants
Wed, Oct 9, 1:01 PM
evandro closed D68257: [Support] Add mathematical constants.
Wed, Oct 9, 1:00 PMRestricted Project
evandro added a comment to D68353: [AArch64] Remove overlapping definitions (NFC).

Ping! 馃敂

Wed, Oct 9, 12:26 PMRestricted Project
evandro added a comment to D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Wed, Oct 9, 12:25 PMRestricted Project
evandro added inline comments to D68257: [Support] Add mathematical constants.
Wed, Oct 9, 12:23 PMRestricted Project

Tue, Oct 8

evandro updated the diff for D68257: [Support] Add mathematical constants.

Added the hex FP constants for easier auditing.

Tue, Oct 8, 12:59 PMRestricted Project
evandro updated the diff for D68257: [Support] Add mathematical constants.

@efriedma, you had a point. I now trimmed the precision down to one digit short of seeing a change in the mantissa bits.

Tue, Oct 8, 12:03 PMRestricted Project
evandro added inline comments to D68257: [Support] Add mathematical constants.
Tue, Oct 8, 8:54 AMRestricted Project

Mon, Oct 7

evandro added inline comments to D68231: [SLC] Allow llvm.pow(x,2.0) -> x*x etc even if no pow() lib func.
Mon, Oct 7, 3:21 PMRestricted Project
evandro updated the diff for D68257: [Support] Add mathematical constants.
Mon, Oct 7, 3:08 PMRestricted Project
evandro added inline comments to D68257: [Support] Add mathematical constants.
Mon, Oct 7, 3:00 PMRestricted Project
evandro updated the diff for D68257: [Support] Add mathematical constants.
Mon, Oct 7, 12:24 PMRestricted Project
evandro added a comment to D68231: [SLC] Allow llvm.pow(x,2.0) -> x*x etc even if no pow() lib func.

Indeed, it seemed to be a coarse check in case the following transformations end up calling pow(). However, the only transformation that calls pow() is when shrinking to powf(), which itself chacks for the availability of this routine. So this patch seems to address this issue the wrong way. It seems that removing this check would be better.

Mon, Oct 7, 12:13 PMRestricted Project

Sat, Oct 5

evandro updated the diff for D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Sat, Oct 5, 9:59 AMRestricted Project
evandro updated the diff for D68257: [Support] Add mathematical constants.
Sat, Oct 5, 9:52 AMRestricted Project

Wed, Oct 2

evandro created D68353: [AArch64] Remove overlapping definitions (NFC).
Wed, Oct 2, 12:58 PMRestricted Project
evandro committed rGe139a73c5fc1: [TableGen] Improve error reporting of overlapping definitions (NFC) (authored by evandro).
[TableGen] Improve error reporting of overlapping definitions (NFC)
Wed, Oct 2, 12:44 PM
evandro committed rL373514: [TableGen] Improve error reporting of overlapping definitions (NFC).
[TableGen] Improve error reporting of overlapping definitions (NFC)
Wed, Oct 2, 12:42 PM
evandro added a comment to D68257: [Support] Add mathematical constants.

Maybe take std::numbers implementation - llvm::numbers?

Wed, Oct 2, 10:33 AMRestricted Project

Tue, Oct 1

evandro added a child revision for D68257: [Support] Add mathematical constants: D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Tue, Oct 1, 11:27 AMRestricted Project
evandro added a parent revision for D68285: [AMDGPU] Use math constants defined in MathExtras (NFC): D68257: [Support] Add mathematical constants.
Tue, Oct 1, 11:27 AMRestricted Project
evandro created D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Tue, Oct 1, 11:27 AMRestricted Project
evandro updated the diff for D68257: [Support] Add mathematical constants.

Split the changes to the AMDGPU target in a separate patch.

Tue, Oct 1, 11:22 AMRestricted Project

Mon, Sep 30

evandro created D68257: [Support] Add mathematical constants.
Mon, Sep 30, 9:09 PMRestricted Project
evandro committed rG41ead4281fad: [SimplifyLibCalls] Define the value of the Euler number (authored by evandro).
[SimplifyLibCalls] Define the value of the Euler number
Mon, Sep 30, 4:20 PM
evandro committed rL373274: [SimplifyLibCalls] Define the value of the Euler number.
[SimplifyLibCalls] Define the value of the Euler number
Mon, Sep 30, 4:20 PM
evandro committed rG22cb3d2e58f4: [ConstantFolding] Fold constant calls to log2() (authored by evandro).
[ConstantFolding] Fold constant calls to log2()
Mon, Sep 30, 1:53 PM
evandro committed rG110b1138baf4: [InstCombine] Expand the simplification of log() (authored by evandro).
[InstCombine] Expand the simplification of log()
Mon, Sep 30, 1:51 PM
evandro committed rL373262: [ConstantFolding] Fold constant calls to log2().
[ConstantFolding] Fold constant calls to log2()
Mon, Sep 30, 1:51 PM
evandro closed D67300: [ConstantFolding] Fold constant calls to log2().
Mon, Sep 30, 1:51 PMRestricted Project
evandro committed rL373261: [InstCombine] Expand the simplification of log().
[InstCombine] Expand the simplification of log()
Mon, Sep 30, 1:50 PM
evandro closed D67199: [InstCombine] Expand the simplification of log().
Mon, Sep 30, 1:50 PMRestricted Project

Wed, Sep 25

evandro committed rG3bd8ba156b52: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets (authored by evandro).
[CodeGen] Replace -max-jump-table-size with -max-jump-table-targets
Wed, Sep 25, 9:12 AM
evandro committed rL372893: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
[CodeGen] Replace -max-jump-table-size with -max-jump-table-targets
Wed, Sep 25, 9:09 AM
evandro closed D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Wed, Sep 25, 9:09 AMRestricted Project
evandro added a comment to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.

Thank you.

Wed, Sep 25, 9:05 AMRestricted Project

Tue, Sep 24

evandro added a comment to D67199: [InstCombine] Expand the simplification of log().

Ping! 馃敂

Tue, Sep 24, 1:58 PMRestricted Project
evandro added a comment to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.

馃う馃徎鈥嶁檪锔

Tue, Sep 24, 11:07 AMRestricted Project
evandro updated the diff for D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Tue, Sep 24, 11:07 AMRestricted Project

Mon, Sep 23

evandro updated the diff for D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Mon, Sep 23, 11:30 AMRestricted Project

Fri, Sep 20

evandro updated the diff for D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Fri, Sep 20, 12:50 PMRestricted Project
evandro updated the diff for D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Fri, Sep 20, 12:29 PMRestricted Project
evandro added inline comments to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Fri, Sep 20, 11:18 AMRestricted Project

Thu, Sep 19

evandro committed rGa4da991e4a4e: [AArch64] Fix formatting (NFC) (authored by evandro).
[AArch64] Fix formatting (NFC)
Thu, Sep 19, 2:49 PM
evandro committed rL372357: [AArch64] Fix formatting (NFC).
[AArch64] Fix formatting (NFC)
Thu, Sep 19, 2:48 PM

Sep 18 2019

evandro updated the diff for D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Sep 18 2019, 8:23 AMRestricted Project
evandro added inline comments to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Sep 18 2019, 8:16 AMRestricted Project

Sep 17 2019

evandro updated the diff for D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.

Update the patch Including the suggested refactoring.

Sep 17 2019, 9:52 AMRestricted Project
evandro added inline comments to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Sep 17 2019, 8:32 AMRestricted Project
evandro added a comment to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.

Thank you.

Sep 17 2019, 8:25 AMRestricted Project

Sep 16 2019

evandro updated the diff for D67199: [InstCombine] Expand the simplification of log().
Sep 16 2019, 11:21 AMRestricted Project
evandro added inline comments to D67199: [InstCombine] Expand the simplification of log().
Sep 16 2019, 11:00 AMRestricted Project

Sep 12 2019

evandro added a comment to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.

Running llc -O1 3 times on the byte code from a.i in the "reduced some more" archive:

  • Before: average of 38.383s 卤 0.064s
  • After: average of 38.440s 卤 0.049s
Sep 12 2019, 5:07 PMRestricted Project
evandro committed rG08df6e64d570: [ConstantFolding] Expand folding of some library functions (authored by evandro).
[ConstantFolding] Expand folding of some library functions
Sep 12 2019, 2:25 PM
evandro committed rL371774: [ConstantFolding] Expand folding of some library functions.
[ConstantFolding] Expand folding of some library functions
Sep 12 2019, 2:22 PM
evandro closed D67468: [ConstantFolding] Expand folding of some library functions.
Sep 12 2019, 2:21 PMRestricted Project
evandro updated the diff for D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.

Please, stand by for numbers.

Sep 12 2019, 1:01 PMRestricted Project
evandro added a comment to D67497: [aarch64] move custom isel of extract_vector_elt to td file - NFC.

Is there a test case that checks that this change does not break what the code in AArch64DAGToDAGISel::Select() was meant to handle?

Sep 12 2019, 7:57 AMRestricted Project

Sep 11 2019

evandro committed rGed5f45264554: [ConstantFolding] Refactor math functions to use LLVM ones (NFC) (authored by evandro).
[ConstantFolding] Refactor math functions to use LLVM ones (NFC)
Sep 11 2019, 2:47 PM
evandro committed rL371677: [ConstantFolding] Refactor math functions to use LLVM ones (NFC).
[ConstantFolding] Refactor math functions to use LLVM ones (NFC)
Sep 11 2019, 2:45 PM
evandro closed D67459: [ConstantFolding] Refactor math functions to use LLVM ones (NFC).
Sep 11 2019, 2:45 PMRestricted Project
evandro added a parent revision for D67468: [ConstantFolding] Expand folding of some library functions: D67459: [ConstantFolding] Refactor math functions to use LLVM ones (NFC).
Sep 11 2019, 2:29 PMRestricted Project
evandro added a child revision for D67459: [ConstantFolding] Refactor math functions to use LLVM ones (NFC): D67468: [ConstantFolding] Expand folding of some library functions.
Sep 11 2019, 2:28 PMRestricted Project
evandro created D67468: [ConstantFolding] Expand folding of some library functions.
Sep 11 2019, 2:28 PMRestricted Project
evandro added reviewers for D67468: [ConstantFolding] Expand folding of some library functions: efriedma, xbolva00, spatel.
Sep 11 2019, 2:28 PMRestricted Project
evandro created D67459: [ConstantFolding] Refactor math functions to use LLVM ones (NFC).
Sep 11 2019, 12:44 PMRestricted Project

Sep 9 2019

evandro updated the diff for D67199: [InstCombine] Expand the simplification of log().
Sep 9 2019, 1:29 PMRestricted Project

Sep 6 2019

evandro added a comment to D67300: [ConstantFolding] Fold constant calls to log2().

@efriedma, I never know what Windows supports or not...

Sep 6 2019, 3:53 PMRestricted Project
evandro updated the diff for D67199: [InstCombine] Expand the simplification of log().
Sep 6 2019, 3:18 PMRestricted Project
evandro added a comment to D67300: [ConstantFolding] Fold constant calls to log2().

@efriedma, yes, I noticed that and noted it in rL371236.

Sep 6 2019, 3:18 PMRestricted Project
evandro committed rG7d677adf2df6: [InstCombine] Refactor substitution of instruction in the parent BB (NFC) (authored by evandro).
[InstCombine] Refactor substitution of instruction in the parent BB (NFC)
Sep 6 2019, 3:09 PM
evandro committed rL371264: [InstCombine] Refactor substitution of instruction in the parent BB (NFC).
[InstCombine] Refactor substitution of instruction in the parent BB (NFC)
Sep 6 2019, 3:09 PM
evandro added inline comments to D67199: [InstCombine] Expand the simplification of log().
Sep 6 2019, 2:24 PMRestricted Project
evandro added a child revision for D67199: [InstCombine] Expand the simplification of log(): D67300: [ConstantFolding] Fold constant calls to log2().
Sep 6 2019, 1:32 PMRestricted Project
evandro added a parent revision for D67300: [ConstantFolding] Fold constant calls to log2(): D67199: [InstCombine] Expand the simplification of log().
Sep 6 2019, 1:32 PMRestricted Project
evandro created D67300: [ConstantFolding] Fold constant calls to log2().
Sep 6 2019, 1:32 PMRestricted Project
evandro committed rG88a98ea3f75c: [ConstantFolding] Add new test cases for transcendentals (NFC) (authored by evandro).
[ConstantFolding] Add new test cases for transcendentals (NFC)
Sep 6 2019, 12:42 PM
evandro committed rL371246: [ConstantFolding] Add new test cases for transcendentals (NFC).
[ConstantFolding] Add new test cases for transcendentals (NFC)
Sep 6 2019, 12:41 PM
evandro committed rG7feb812ccde7: [ConstantFolding] Refactor functions not available before C99 (NFC) (authored by evandro).
[ConstantFolding] Refactor functions not available before C99 (NFC)
Sep 6 2019, 11:29 AM
evandro committed rL371236: [ConstantFolding] Refactor functions not available before C99 (NFC).
[ConstantFolding] Refactor functions not available before C99 (NFC)
Sep 6 2019, 11:28 AM
evandro committed rG6f1369755dcd: [ConstantFolding] Refactor function match for better speed (NFC) (authored by evandro).
[ConstantFolding] Refactor function match for better speed (NFC)
Sep 6 2019, 9:50 AM
evandro committed rL371228: [ConstantFolding] Refactor function match for better speed (NFC).
[ConstantFolding] Refactor function match for better speed (NFC)
Sep 6 2019, 9:49 AM

Sep 4 2019

evandro updated the diff for D67199: [InstCombine] Expand the simplification of log().
Sep 4 2019, 5:09 PMRestricted Project
evandro updated the diff for D67199: [InstCombine] Expand the simplification of log().
Sep 4 2019, 5:03 PMRestricted Project
evandro added inline comments to D67199: [InstCombine] Expand the simplification of log().
Sep 4 2019, 4:54 PMRestricted Project
evandro updated the diff for D67199: [InstCombine] Expand the simplification of log().
Sep 4 2019, 4:24 PMRestricted Project
evandro added inline comments to D67199: [InstCombine] Expand the simplification of log().
Sep 4 2019, 4:24 PMRestricted Project
evandro created D67199: [InstCombine] Expand the simplification of log().
Sep 4 2019, 3:51 PMRestricted Project
evandro committed rGbf78e39cbbbe: [InstCombine] Add more test cases (NFC) (authored by evandro).
[InstCombine] Add more test cases (NFC)
Sep 4 2019, 1:01 PM