Page MenuHomePhabricator
Feed Advanced Search

Today

domada added a comment to D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend.

For AArch64 the default alignment is 0? I would have expected 128.

Wed, Feb 8, 8:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada added a comment to D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend.

@akyrtzi Thank you for your feedback. Can I land the patch?

Wed, Feb 8, 12:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Yesterday

domada updated the diff for D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend.

Patch rebased

Tue, Feb 7, 1:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada reopened D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend.
Tue, Feb 7, 12:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend.

Added changes in clang/lib/AST/CMakeLists.txt to address build issue reported by @akyrtzi .

Tue, Feb 7, 12:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Thu, Feb 2

domada added a comment to D127272: [flang][OpenMP] Lowering support for atomic capture.

LGTM

Thu, Feb 2, 12:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Jan 27

domada added reviewers for D142722: [Flang][OpenMP] Implement lowering simd aligned to LLVM IR: dpalermo, jsjodin, kiranchandramohan, kiranktp, NimishMishra, skatrak, agozillon, raghavendhra, TIFitis.
Fri, Jan 27, 7:07 AM · Restricted Project, Restricted Project, Restricted Project
domada requested review of D142722: [Flang][OpenMP] Implement lowering simd aligned to LLVM IR.
Fri, Jan 27, 7:03 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jan 26

domada committed rGca446037af01: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend (authored by domada).
[OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend
Thu, Jan 26, 1:18 PM · Restricted Project, Restricted Project, Restricted Project
domada closed D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend.
Thu, Jan 26, 1:18 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Thu, Jan 19

domada committed rGe4ebe14fd16f: [mlir][OpenMP] Add nontemporal clause definition to simd construct (authored by domada).
[mlir][OpenMP] Add nontemporal clause definition to simd construct
Thu, Jan 19, 3:51 AM · Restricted Project, Restricted Project, Restricted Project
domada closed D140553: [mlir][OpenMP] Add nontemporal clause definition to simd construct.
Thu, Jan 19, 3:51 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jan 17

domada requested review of D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend.
Tue, Jan 17, 3:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Jan 13

domada added a reverting change for rGed01de674331: [OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend: rG6809af1a232b: Revert "[OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend".
Fri, Jan 13, 12:40 PM · Restricted Project, Restricted Project, Restricted Project
domada committed rG6809af1a232b: Revert "[OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend" (authored by domada).
Revert "[OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend"
Fri, Jan 13, 12:40 PM · Restricted Project, Restricted Project, Restricted Project
domada added a reverting change for D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend: rG6809af1a232b: Revert "[OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend".
Fri, Jan 13, 12:40 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada committed rGed01de674331: [OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend (authored by domada).
[OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend
Fri, Jan 13, 12:24 PM · Restricted Project, Restricted Project, Restricted Project
domada closed D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend.
Fri, Jan 13, 12:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 9 2023

domada added inline comments to D140553: [mlir][OpenMP] Add nontemporal clause definition to simd construct.
Jan 9 2023, 4:25 AM · Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D140553: [mlir][OpenMP] Add nontemporal clause definition to simd construct.

Applied remarks - removed custom parser and printer of nontemporal clause.

Jan 9 2023, 4:14 AM · Restricted Project, Restricted Project, Restricted Project

Jan 5 2023

domada updated the diff for D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend.

Rename OMPIRBuilder function to query SIMD alignment

Jan 5 2023, 7:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend.

Scope of changes:

  1. Refactored createTargetMachine function.

Reuse existing code.

Jan 5 2023, 5:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 22 2022

domada requested review of D140553: [mlir][OpenMP] Add nontemporal clause definition to simd construct.
Dec 22 2022, 6:55 AM · Restricted Project, Restricted Project, Restricted Project

Dec 16 2022

domada added inline comments to D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend.
Dec 16 2022, 4:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada added inline comments to D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend.
Dec 16 2022, 3:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 15 2022

domada added inline comments to D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend.
Dec 15 2022, 6:54 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend.

Applied review remarks.

Dec 15 2022, 6:35 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 12 2022

domada added a comment to D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend.

Hi Johannes,
I was referring to Jan's idea. He proposes to move part of the functionality to the DataLayout class. IMO this option is not the best approach, because DataLayout object does not contain information about subtarget and we cannot determine if SIMD extensions (avx options) are enabled.

Dec 12 2022, 4:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 9 2022

domada added a comment to D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend.

I think we cannot not rely on DataLayout to find the maximal SIMD alignment.

Dec 9 2022, 9:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 5 2022

domada added a comment to D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend.

@jsjodin thanks for your remark. Let me add some more information to this patch.

Dec 5 2022, 3:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 29 2022

domada added inline comments to D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend.
Nov 29 2022, 3:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend.
  1. Refactored OMPIRBuilder method which calculates SIMD alignment. Added optional parameter Type *AlignedValueTy which can be used to define optimal alignment. If this parameter is not specified then, we return the maximal SIMD alignment for given target.
  2. Clang still uses suboptimal value because there is no link between clang TargetInfo and LLVM-Type. More information about this decision can be found in previous review which introduced original getSimdDefaultAlign function: https://reviews.llvm.org/D10597?id=28205#inline-85925
  3. TargetInfo class contains method: getMaxVectorAlign . This method returns maximal vector alignment for given target. The only difference between original: getMaxVectorAlign and getSimdDefaultAlign is that getSimdDefaultAlign returns 0 alignment for ARM target. I don't know if it is ok, that we assume 0 alignment for ARM targets.
  4. Removed getSimdDefaultAlign function.
Nov 29 2022, 3:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 22 2022

domada added a comment to D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend.

Yes, we can extend calculations of the default alignment. My primary goal was to move code from clang into llvm without modification of the code logic.

Nov 22 2022, 8:54 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada requested review of D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend.
Nov 22 2022, 6:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 18 2022

domada closed D136350: [mlir][OpenMP] Add order clause definition to simd construct.

Patch is committed. Link to the commit: https://github.com/llvm/llvm-project/commit/163dbfe869f550bd2d22520fda109876a1122eda . I forgot to add review link in commit message.

Nov 18 2022, 4:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada committed rG163dbfe869f5: [mlir][OpenMP] Add order clause definition to simd construct (authored by domada).
[mlir][OpenMP] Add order clause definition to simd construct
Nov 18 2022, 4:11 AM · Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D136350: [mlir][OpenMP] Add order clause definition to simd construct.

Patch rebased

Nov 18 2022, 3:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 1 2022

domada committed rG25243d717dc9: [mlir][OpenMP] Add aligned clause definition to simd construct (authored by domada).
[mlir][OpenMP] Add aligned clause definition to simd construct
Nov 1 2022, 9:10 AM · Restricted Project, Restricted Project, Restricted Project
domada closed D135865: [mlir][OpenMP] Add aligned clause definition to simd construct.
Nov 1 2022, 9:10 AM · Restricted Project, Restricted Project, Restricted Project

Oct 31 2022

domada added inline comments to D135865: [mlir][OpenMP] Add aligned clause definition to simd construct.
Oct 31 2022, 5:34 AM · Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D135865: [mlir][OpenMP] Add aligned clause definition to simd construct.

Applied remarks. Added more tests.

Oct 31 2022, 5:01 AM · Restricted Project, Restricted Project, Restricted Project

Oct 20 2022

domada requested review of D136350: [mlir][OpenMP] Add order clause definition to simd construct.
Oct 20 2022, 6:44 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada retitled D135865: [mlir][OpenMP] Add aligned clause definition to simd construct from [mlir][OpenMP] Add aligned clause defintion to simd construct to [mlir][OpenMP] Add aligned clause definition to simd construct.
Oct 20 2022, 6:38 AM · Restricted Project, Restricted Project, Restricted Project
domada added inline comments to D135865: [mlir][OpenMP] Add aligned clause definition to simd construct.
Oct 20 2022, 5:24 AM · Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D135865: [mlir][OpenMP] Add aligned clause definition to simd construct.

Addressed review comments:

  1. Modified the way how aligned clause is represented. Use I64ArrayAttr instead of Variadic to represent alignment values
  2. Added verifier which checks if aligned clause was properly mapped
  3. Added more tests MLIR tests
Oct 20 2022, 5:11 AM · Restricted Project, Restricted Project, Restricted Project

Oct 18 2022

domada committed rGccd314d3209a: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder (authored by domada).
[OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder
Oct 18 2022, 12:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada closed D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Oct 18 2022, 12:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 17 2022

domada added inline comments to D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Oct 17 2022, 3:28 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
  1. Changed DenseMap to MapVector. MapVector provides that the iteration order is the same as insertion order
Oct 17 2022, 1:40 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 13 2022

domada added a reviewer for D135865: [mlir][OpenMP] Add aligned clause definition to simd construct: kiranchandramohan.
Oct 13 2022, 4:26 AM · Restricted Project, Restricted Project, Restricted Project
domada requested review of D135865: [mlir][OpenMP] Add aligned clause definition to simd construct.
Oct 13 2022, 3:38 AM · Restricted Project, Restricted Project, Restricted Project
domada added inline comments to D135695: [OMPIRBuilder] Support depend clause for task construct.
Oct 13 2022, 3:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 11 2022

domada added inline comments to D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Oct 11 2022, 5:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
  1. Update description of AlignedVars argument
Oct 11 2022, 5:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada added inline comments to D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Oct 11 2022, 4:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
  1. Modified generation of align assumptions. OMPIRBuilder generates now only assumptions calls. The arguments of the assumption calls are generated by Clang.
  2. Added integration test to prove that Clang and OMPIRBuilder support aligned clause
  3. Simplification of unit tests -> applying review remarks
Oct 11 2022, 4:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 5 2022

domada added inline comments to D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Oct 5 2022, 4:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.

Patch rebased.

Oct 5 2022, 3:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 4 2022

domada committed rG6842d3501266: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for… (authored by domada).
[OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for…
Oct 4 2022, 6:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada closed D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive.
Oct 4 2022, 6:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive.

Remove custom enum for mapping order(concurrent)

Oct 4 2022, 4:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.

Add assert to ensure that alignment value is always specified.

Oct 4 2022, 2:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 3 2022

domada added inline comments to D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Oct 3 2022, 7:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive.

Patch rebased

Oct 3 2022, 3:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.

Patch rebased.

Oct 3 2022, 2:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 19 2022

domada added a comment to D128596: [flang][OpenMP] Support privatization for single construct.

For me the patch is ok, but I think it would be better, if somebody else will also review it.

Sep 19 2022, 6:08 AM · Restricted Project, Restricted Project, Restricted Project
domada added inline comments to D128596: [flang][OpenMP] Support privatization for single construct.
Sep 19 2022, 1:37 AM · Restricted Project, Restricted Project, Restricted Project

Sep 16 2022

domada requested review of D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive.
Sep 16 2022, 7:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 13 2022

domada added a comment to D128596: [flang][OpenMP] Support privatization for single construct.

@peixin What is status of this patch? Are you planning to modify this patch or is it ready for the review?

Sep 13 2022, 4:02 AM · Restricted Project, Restricted Project, Restricted Project
domada added inline comments to D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Sep 13 2022, 3:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.

Applied review remarks. Scope of changes:

Sep 13 2022, 3:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 9 2022

domada added reviewers for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder: peixin, arnamoy10.
Sep 9 2022, 7:21 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada requested review of D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Sep 9 2022, 7:19 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 19 2022

domada committed rGb736179e3449: [NFC][OpenMP] Add test for simd directive with nested loop (authored by domada).
[NFC][OpenMP] Add test for simd directive with nested loop
Aug 19 2022, 3:46 AM · Restricted Project, Restricted Project
domada closed D132215: [NFC][OpenMP] Add test for simd directive with nested loop.
Aug 19 2022, 3:46 AM · Restricted Project, Restricted Project
domada added a reviewer for D132215: [NFC][OpenMP] Add test for simd directive with nested loop: kiranchandramohan.
Aug 19 2022, 3:15 AM · Restricted Project, Restricted Project
domada requested review of D132215: [NFC][OpenMP] Add test for simd directive with nested loop.
Aug 19 2022, 3:14 AM · Restricted Project, Restricted Project

Aug 17 2022

domada committed rGcc8c746f8df5: [NFC][Flang] Add simd collapse test case (authored by domada).
[NFC][Flang] Add simd collapse test case
Aug 17 2022, 5:48 AM · Restricted Project, Restricted Project
domada closed D132023: [NFC][Flang] Add simd collapse test case.
Aug 17 2022, 5:48 AM · Restricted Project, Restricted Project
domada added a comment to D131674: [NFC][OpenMP] Update simd loop collapse support description.

Follow up review: https://reviews.llvm.org/D132023 . This review contains Fortran test with simd clause.

Aug 17 2022, 4:26 AM · Restricted Project, Restricted Project, Restricted Project
domada requested review of D132023: [NFC][Flang] Add simd collapse test case.
Aug 17 2022, 4:18 AM · Restricted Project, Restricted Project
domada committed rG19bd4789b9d6: [NFC][OpenMP] Update simd loop collapse support description (authored by domada).
[NFC][OpenMP] Update simd loop collapse support description
Aug 17 2022, 1:58 AM · Restricted Project, Restricted Project
domada closed D131674: [NFC][OpenMP] Update simd loop collapse support description.
Aug 17 2022, 1:58 AM · Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D131674: [NFC][OpenMP] Update simd loop collapse support description.

Updated test: Do not rely on hardcoded labels. Check if collapsed loop bound is calculated.

Aug 17 2022, 1:18 AM · Restricted Project, Restricted Project, Restricted Project

Aug 16 2022

domada added a comment to D131674: [NFC][OpenMP] Update simd loop collapse support description.

@peixin
Thank you for your review. I will apply your remarks in the separate patch which will be Flang specific.

Aug 16 2022, 4:18 AM · Restricted Project, Restricted Project, Restricted Project
domada added a comment to D131674: [NFC][OpenMP] Update simd loop collapse support description.

As far as possible we should try to have Flang and MLIR OpenMP dialect changes in separate patches.

I would recommend splitting this into two simple patches.

  1. Testing the lowering of OpenMP dialect simdloop collapse to LLVM IR. There is an existing test case, simdloop_multi in the translation tests. You need to strengthen it minimally to check the occurrence of collapse. And adding the collapse information to the OpenMP dialect op description.

The relevant code for this came in the patch https://reviews.llvm.org/D118065.

Done. I modified this review so that it contains only OpenMP specific changes.

Aug 16 2022, 4:16 AM · Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D131674: [NFC][OpenMP] Update simd loop collapse support description.

Add only OpenMP specific changes. Update simd loop MLIR description and strengthen translation test.

Aug 16 2022, 4:13 AM · Restricted Project, Restricted Project, Restricted Project

Aug 11 2022

domada requested review of D131674: [NFC][OpenMP] Update simd loop collapse support description.
Aug 11 2022, 5:47 AM · Restricted Project, Restricted Project, Restricted Project

Aug 10 2022

domada committed rG98ed6e106972: [Flang][OpenMP] Fix conversion of nested loops for SIMD directive (authored by domada).
[Flang][OpenMP] Fix conversion of nested loops for SIMD directive
Aug 10 2022, 2:02 AM · Restricted Project, Restricted Project, Restricted Project
domada closed D131402: [Flang][OpenMP] Fix conversion to LLVM IR for Fortran code with OpenMP SIMD directive and nested loop.
Aug 10 2022, 2:01 AM · Restricted Project, Restricted Project, Restricted Project
domada added inline comments to D131526: [OMPIRBuilder] Add support for safelen clause.
Aug 10 2022, 1:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 9 2022

domada added reviewers for D131402: [Flang][OpenMP] Fix conversion to LLVM IR for Fortran code with OpenMP SIMD directive and nested loop: Meinersbur, kiranchandramohan.
Aug 9 2022, 2:42 PM · Restricted Project, Restricted Project, Restricted Project
domada added inline comments to D131402: [Flang][OpenMP] Fix conversion to LLVM IR for Fortran code with OpenMP SIMD directive and nested loop.
Aug 9 2022, 4:20 AM · Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D131402: [Flang][OpenMP] Fix conversion to LLVM IR for Fortran code with OpenMP SIMD directive and nested loop.

Scope of changes:

Aug 9 2022, 4:19 AM · Restricted Project, Restricted Project, Restricted Project

Aug 8 2022

domada requested review of D131402: [Flang][OpenMP] Fix conversion to LLVM IR for Fortran code with OpenMP SIMD directive and nested loop.
Aug 8 2022, 8:19 AM · Restricted Project, Restricted Project, Restricted Project

Aug 1 2022

domada committed rGd90b7bf2c53d: Add support for lowering simd if clause to LLVM IR (authored by domada).
Add support for lowering simd if clause to LLVM IR
Aug 1 2022, 2:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada closed D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.
Aug 1 2022, 2:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada added inline comments to D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.
Aug 1 2022, 1:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 29 2022

domada updated the diff for D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.

Applied remarks:
Do not collapse loops inside function responsible for applying SIMD metadirectives
Added special function for loop versioning

Jul 29 2022, 9:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 28 2022

domada added inline comments to D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.
Jul 28 2022, 5:53 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project