Page MenuHomePhabricator
Feed Advanced Search

Today

stephanemoore added inline comments to D67578: [clang-tidy] New check to warn when writing to a dispatch_once_t variable..
Mon, Sep 16, 3:31 PMRestricted Project, Restricted Project

Wed, Sep 11

stephanemoore requested changes to D65917: [clang-tidy] Added check for the Google style guide's category method naming rule..
Wed, Sep 11, 4:54 AMRestricted Project, Restricted Project

Aug 15 2019

stephanemoore committed rGa53cce943d16: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 馃殯 (authored by stephanemoore).
[clang-tidy] Migrate objc-super-self to use isDerivedFrom 馃殯
Aug 15 2019, 7:28 PM
stephanemoore committed rL369081: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 馃殯.
[clang-tidy] Migrate objc-super-self to use isDerivedFrom 馃殯
Aug 15 2019, 7:28 PM
stephanemoore closed D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 馃殯.
Aug 15 2019, 7:28 PMRestricted Project, Restricted Project
stephanemoore committed rG8c90c1d2d57d: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 馃殯 (authored by stephanemoore).
[clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 馃殯
Aug 15 2019, 6:52 PM
stephanemoore committed rL369076: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 馃殯.
[clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 馃殯
Aug 15 2019, 6:51 PM
stephanemoore closed D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 馃殯.
Aug 15 2019, 6:51 PMRestricted Project, Restricted Project

Aug 14 2019

stephanemoore updated the diff for D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 馃殯.

Fix example matches in comment.

Aug 14 2019, 8:01 PMRestricted Project, Restricted Project
stephanemoore created D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 馃殯.
Aug 14 2019, 7:59 PMRestricted Project, Restricted Project
stephanemoore added reviewers for D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 馃殯: aaron.ballman, gribozavr.
Aug 14 2019, 7:04 PMRestricted Project, Restricted Project
stephanemoore created D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 馃殯.
Aug 14 2019, 7:01 PMRestricted Project, Restricted Project

Aug 12 2019

stephanemoore committed rGa0a47d8ac113: [clang] Update isDerivedFrom to support Objective-C classes 馃攳 (authored by stephanemoore).
[clang] Update isDerivedFrom to support Objective-C classes 馃攳
Aug 12 2019, 4:24 PM
stephanemoore committed rL368632: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
[clang] Update isDerivedFrom to support Objective-C classes 馃攳
Aug 12 2019, 4:24 PM
stephanemoore closed D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
Aug 12 2019, 4:23 PMRestricted Project, Restricted Project

Aug 8 2019

stephanemoore added inline comments to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
Aug 8 2019, 6:31 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Use llvm::SmallPtrSet to store the compatible aliases instead of std::set.
Fix a stray unit test failure in RegistryTest.cpp.

Aug 8 2019, 6:29 PMRestricted Project, Restricted Project

Aug 7 2019

stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Add tests for isDirectlyDerivedFrom.

Aug 7 2019, 6:56 PMRestricted Project, Restricted Project
stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Whoops; forgot to add test cases for isDirectlyDerivedFrom 馃う Will do that shortly.

Aug 7 2019, 6:15 PMRestricted Project, Restricted Project
stephanemoore removed a reviewer for D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳: stephanemoore.
Aug 7 2019, 5:16 PMRestricted Project, Restricted Project
stephanemoore added a comment to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

I spent some time becoming familiar with how isDerivedFrom behaves for C++ classes. I think that I have managed to get the behavior for Objective-C classes to mirror that of C++ classes. Please let me know if I overlooked anything.

Aug 7 2019, 5:12 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Update isDerivedFrom to match aliased types and compatibility aliases of
derived Objective-C classes.

Aug 7 2019, 5:06 PMRestricted Project, Restricted Project

May 31 2019

stephanemoore committed rGec1982f07f5b: Revise the google-objc-global-variable-declaration check to match the style鈥 (authored by stephanemoore).
Revise the google-objc-global-variable-declaration check to match the style鈥
May 31 2019, 4:39 PM
stephanemoore committed rL362279: Revise the google-objc-global-variable-declaration check to match the style鈥.
Revise the google-objc-global-variable-declaration check to match the style鈥
May 31 2019, 4:38 PM
stephanemoore closed D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 31 2019, 4:38 PMRestricted Project, Restricted Project

May 29 2019

stephanemoore accepted D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 29 2019, 8:45 PMRestricted Project, Restricted Project

May 28 2019

stephanemoore added a comment to rL361907: Revise the google-objc-global-variable-declaration check to match the style鈥.

I think your changeset caused a failure in this buildbot.
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/18933
Failure : http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/18933/steps/ninja%20check%201/logs/stdio

May 28 2019, 8:43 PM
stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Thanks for the input! I will get started on making changes accordingly.

May 28 2019, 8:24 PMRestricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 28 2019, 7:32 PMRestricted Project, Restricted Project
stephanemoore reopened D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 28 2019, 7:32 PMRestricted Project, Restricted Project
stephanemoore committed rG9ac757bf09a3: Rollback "Revise the google-objc-global-variable-declaration check to match the鈥 (authored by stephanemoore).
Rollback "Revise the google-objc-global-variable-declaration check to match the鈥
May 28 2019, 7:22 PM
stephanemoore committed rL361914: Rollback "Revise the google-objc-global-variable-declaration check to match the鈥.
Rollback "Revise the google-objc-global-variable-declaration check to match the鈥
May 28 2019, 7:22 PM
stephanemoore committed rCTE361914: Rollback "Revise the google-objc-global-variable-declaration check to match the鈥.
Rollback "Revise the google-objc-global-variable-declaration check to match the鈥
May 28 2019, 7:22 PM
stephanemoore committed rG12e3726fadb0: Revise the google-objc-global-variable-declaration check to match the style鈥 (authored by stephanemoore).
Revise the google-objc-global-variable-declaration check to match the style鈥
May 28 2019, 6:37 PM
stephanemoore committed rL361907: Revise the google-objc-global-variable-declaration check to match the style鈥.
Revise the google-objc-global-variable-declaration check to match the style鈥
May 28 2019, 6:33 PM
stephanemoore committed rCTE361907: Revise the google-objc-global-variable-declaration check to match the style鈥.
Revise the google-objc-global-variable-declaration check to match the style鈥
May 28 2019, 6:33 PM
stephanemoore closed D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 28 2019, 6:33 PMRestricted Project, Restricted Project
stephanemoore added a comment to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

It looks like all concerns have been addressed. Do you need me to land this commit for you?

May 28 2019, 1:47 PMRestricted Project, Restricted Project

May 24 2019

stephanemoore requested review of D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
May 24 2019, 8:36 PMRestricted Project, Restricted Project
stephanemoore accepted D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Okay I now have an implementation of Option 2 that works.

May 24 2019, 8:36 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Add missing braces to multi-line if statements.

May 24 2019, 8:30 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Update isDerivedFrom and related matchers to polymorphic matchers.

May 24 2019, 8:24 PMRestricted Project, Restricted Project
stephanemoore accepted D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Looks good! Thanks for being patient with me!

May 24 2019, 3:45 PMRestricted Project, Restricted Project
stephanemoore accepted D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

(sorry I forgot to send this earlier)

May 24 2019, 3:13 PMRestricted Project, Restricted Project

May 21 2019

stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Out of curiosity, how invasive is Option 2 within our own code base?

May 21 2019, 9:00 PMRestricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Many thanks for being patient with me 馃檹 I think there are just two more things 鉁岋笍

May 21 2019, 6:18 PMRestricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Almost there. I think everything looks good after we resolve this last round of comments.

May 21 2019, 4:53 PMRestricted Project, Restricted Project

May 17 2019

stephanemoore added inline comments to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 17 2019, 6:09 PMRestricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Thanks for restoring the support for the legacy style! I noticed that there are some cases where we can preserve an existing fixit.

May 17 2019, 3:03 PMRestricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 17 2019, 12:28 PMRestricted Project, Restricted Project

May 14 2019

stephanemoore accepted D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
May 14 2019, 3:08 PMRestricted Project, Restricted Project

May 13 2019

stephanemoore requested changes to D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
May 13 2019, 3:28 PMRestricted Project, Restricted Project
stephanemoore accepted D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

I believe that all the feedback from @gribozavr has been addressed modulo one small nit. Once that nit has been addressed, I can land this.

May 13 2019, 3:09 PMRestricted Project, Restricted Project

May 12 2019

stephanemoore committed rG3109836a60a7: [clang] Regenerate AST matcher docs 馃摉 (authored by stephanemoore).
[clang] Regenerate AST matcher docs 馃摉
May 12 2019, 2:51 PM
stephanemoore committed rL360545: [clang] Regenerate AST matcher docs 馃摉.
[clang] Regenerate AST matcher docs 馃摉
May 12 2019, 2:50 PM
stephanemoore committed rC360545: [clang] Regenerate AST matcher docs 馃摉.
[clang] Regenerate AST matcher docs 馃摉
May 12 2019, 2:50 PM
stephanemoore closed D61769: [clang] Regenerate AST matcher docs 馃摉.
May 12 2019, 2:50 PMRestricted Project, Restricted Project

May 9 2019

stephanemoore added inline comments to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
May 9 2019, 5:32 PMRestricted Project, Restricted Project
stephanemoore added a comment to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

I did some digging and I believe there are two approaches that we can take to extend isDerivedFrom to support Objective-C classes.

May 9 2019, 5:29 PMRestricted Project, Restricted Project
stephanemoore retitled D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳 from [clang] Add matcher for subclasses of Objective-C interfaces 馃攳 to [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
May 9 2019, 5:03 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Present one potential option for making isDerivedFrom support Objective-C classes.

May 9 2019, 4:59 PMRestricted Project, Restricted Project
stephanemoore added reviewers for D61769: [clang] Regenerate AST matcher docs 馃摉: benhamilton, mwyman.
May 9 2019, 4:32 PMRestricted Project, Restricted Project
stephanemoore created D61769: [clang] Regenerate AST matcher docs 馃摉.
May 9 2019, 4:32 PMRestricted Project, Restricted Project

May 7 2019

stephanemoore accepted D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

Looks good to me once the comments from other reviewers have been addressed. I added a couple suggestions as well.

May 7 2019, 12:41 PMRestricted Project, Restricted Project

Apr 17 2019

stephanemoore committed rGb0c1f8c09e43: [clang-tidy] Add a check for [super self] in initializers 馃攳 (authored by stephanemoore).
[clang-tidy] Add a check for [super self] in initializers 馃攳
Apr 17 2019, 3:28 PM
stephanemoore committed rCTE358620: [clang-tidy] Add a check for [super self] in initializers 馃攳.
[clang-tidy] Add a check for [super self] in initializers 馃攳
Apr 17 2019, 3:27 PM
stephanemoore committed rL358620: [clang-tidy] Add a check for [super self] in initializers 馃攳.
[clang-tidy] Add a check for [super self] in initializers 馃攳
Apr 17 2019, 3:27 PM
stephanemoore closed D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.
Apr 17 2019, 3:27 PMRestricted Project, Restricted Project

Apr 16 2019

stephanemoore added a comment to D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.

LGTM! You can either land this now and refactor after the AST matcher lands, or you can wait until the AST matcher lands and land this patch after -- your call.

Apr 16 2019, 8:32 PMRestricted Project, Restricted Project

Apr 15 2019

stephanemoore added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.
Apr 15 2019, 5:23 PMRestricted Project, Restricted Project
stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
Apr 15 2019, 3:50 PMRestricted Project, Restricted Project

Apr 12 2019

stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.

Fix some formatting issues.

Apr 12 2019, 8:35 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.

Check if either the receiver or selector are in macro locations.

Apr 12 2019, 8:34 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.

Add CHECK-FIXES to verify code is preserved for scenarios that should not have fixes.

Apr 12 2019, 8:16 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.

Update check to avoid emitting a fix if the expression is in a macro.

Apr 12 2019, 8:11 PMRestricted Project, Restricted Project

Apr 10 2019

stephanemoore added inline comments to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
Apr 10 2019, 3:20 PMRestricted Project, Restricted Project
stephanemoore added a reviewer for D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳: aaron.ballman.
Apr 10 2019, 3:15 PMRestricted Project, Restricted Project
stephanemoore created D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
Apr 10 2019, 3:15 PMRestricted Project, Restricted Project
stephanemoore added a comment to D60263: [clang-format] Preserve include blocks in ObjC Google style.

Looks good to me.

Apr 10 2019, 12:07 PMRestricted Project, Restricted Project

Apr 4 2019

stephanemoore planned changes to D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.
Apr 4 2019, 5:57 PMRestricted Project, Restricted Project

Apr 2 2019

stephanemoore added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.
Apr 2 2019, 12:25 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.

Add a test case where a macro emits just self in the message expression.

Apr 2 2019, 12:20 PMRestricted Project, Restricted Project

Mar 29 2019

stephanemoore added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.
Mar 29 2019, 4:20 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.

Add test cases with [super self] expanded from macros.

Mar 29 2019, 4:16 PMRestricted Project, Restricted Project
stephanemoore added a comment to D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.

I don't think there's ever a reason to call [super self], and doing so through a macro could easily indicate a bug.

Mar 29 2019, 3:46 PMRestricted Project, Restricted Project

Mar 26 2019

stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.

Update tests to match updated diagnostic.

Mar 26 2019, 4:04 PMRestricted Project, Restricted Project
stephanemoore added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.
Mar 26 2019, 3:35 PMRestricted Project, Restricted Project
stephanemoore added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.
Mar 26 2019, 3:21 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.

Use double backticks rather than single backticks for symbols in documentation.

Mar 26 2019, 3:18 PMRestricted Project, Restricted Project
stephanemoore added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.
Mar 26 2019, 12:24 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.

Enclose -self in backticks in check documentation (overlooked in previous attempt).

Mar 26 2019, 12:20 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.

Enclose -self in backticks in release notes and check documentation.

Mar 26 2019, 12:18 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.

Fix diagnostic format string to actually use the message's method declaration.

Mar 26 2019, 12:16 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.

Removed usage of auto with a nonobvious type in isSubclassOf matcher.
Added backticks around NSObject in docs.
Synchronized check description in release notes and check documentation.

Mar 26 2019, 12:00 PMRestricted Project, Restricted Project

Mar 25 2019

stephanemoore added a reviewer for D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳: aaron.ballman.
Mar 25 2019, 6:25 PMRestricted Project, Restricted Project
stephanemoore updated the summary of D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.
Mar 25 2019, 6:20 PMRestricted Project, Restricted Project
stephanemoore created D59806: [clang-tidy] Add a check for [super self] in initializers 馃攳.
Mar 25 2019, 6:20 PMRestricted Project, Restricted Project

Mar 20 2019

stephanemoore committed rG5f70c473c9c0: [clang-tidy] Disable google-runtime-int in Objective-C++ 馃敁 (authored by stephanemoore).
[clang-tidy] Disable google-runtime-int in Objective-C++ 馃敁
Mar 20 2019, 4:05 PM
stephanemoore committed rL356627: [clang-tidy] Disable google-runtime-int in Objective-C++ 馃敁.
[clang-tidy] Disable google-runtime-int in Objective-C++ 馃敁
Mar 20 2019, 4:04 PM
stephanemoore committed rCTE356627: [clang-tidy] Disable google-runtime-int in Objective-C++ 馃敁.
[clang-tidy] Disable google-runtime-int in Objective-C++ 馃敁
Mar 20 2019, 4:04 PM