Page MenuHomePhabricator
Feed Advanced Search

Fri, Jul 10

ckandeler accepted D83438: [AST] Fix potential nullptr dereference in Expr::HasSideEffects.
Fri, Jul 10, 2:57 AM · Restricted Project
ckandeler added a comment to D83438: [AST] Fix potential nullptr dereference in Expr::HasSideEffects.

I can confirm that the test case crashes without the null pointer check and passes with the check.

Fri, Jul 10, 2:56 AM · Restricted Project

Tue, Jul 7

ckandeler added a comment to D82629: [libclang] Fix crash when visiting a captured VLA..

@ckandeler do you have commit access or do you want me to land the patch?

Tue, Jul 7, 12:47 AM · Restricted Project

Jul 2 2020

ckandeler added a comment to D82629: [libclang] Fix crash when visiting a captured VLA..

I suppose it boils down to whether the visit() function is supposed to accept null arguments or not. Since I don't know the answer to that, I added the check at the caller. From the description of the linked patch, it appears that other places are also calling the function with a null pointer, but that could just mean that these should be fixed independently. Someone with better knowledge of the code would have to make that decision.

Jul 2 2020, 1:01 AM · Restricted Project

Jun 29 2020

ckandeler updated the diff for D82629: [libclang] Fix crash when visiting a captured VLA..

Fixed formatting issues.

Jun 29 2020, 5:54 AM · Restricted Project

Jun 26 2020

ckandeler created D82629: [libclang] Fix crash when visiting a captured VLA..
Jun 26 2020, 2:08 AM · Restricted Project

Jun 16 2020

ckandeler added a comment to D80279: [libclang] Extend clang_Cursor_Evaluate()..

A kind reminder that I need someone with commit rights to merge this for me.

Jun 16 2020, 1:04 AM · Restricted Project

May 22 2020

ckandeler added a comment to D80279: [libclang] Extend clang_Cursor_Evaluate()..

Thanks for the quick review. I don't have commit access, so can someone please commit it for me?

May 22 2020, 1:13 AM · Restricted Project

May 20 2020

ckandeler added a reviewer for D80279: [libclang] Extend clang_Cursor_Evaluate().: akyrtzi.
May 20 2020, 2:07 AM · Restricted Project
ckandeler created D80279: [libclang] Extend clang_Cursor_Evaluate()..
May 20 2020, 1:35 AM · Restricted Project