I can confirm that the test case crashes without the null pointer check and passes with the check.
Fri, Jul 10
Tue, Jul 7
@ckandeler do you have commit access or do you want me to land the patch?
Jul 2 2020
I suppose it boils down to whether the visit() function is supposed to accept null arguments or not. Since I don't know the answer to that, I added the check at the caller. From the description of the linked patch, it appears that other places are also calling the function with a null pointer, but that could just mean that these should be fixed independently. Someone with better knowledge of the code would have to make that decision.
Jun 29 2020
Fixed formatting issues.
Jun 26 2020
Jun 16 2020
A kind reminder that I need someone with commit rights to merge this for me.
May 22 2020
Thanks for the quick review. I don't have commit access, so can someone please commit it for me?