Page MenuHomePhabricator
Feed Advanced Search

Thu, Nov 17

sinan committed rG2caf1de1b87c: Fix broken CI (authored by sinan).
Fix broken CI
Thu, Nov 17, 1:26 AM · Restricted Project, Restricted Project
sinan closed D138188: Fix broken CI.
Thu, Nov 17, 1:25 AM · Restricted Project, Restricted Project

Wed, Nov 16

sinan requested review of D138188: Fix broken CI.
Wed, Nov 16, 11:55 PM · Restricted Project, Restricted Project
sinan committed rG4ad8952d2d89: [CodeGen][BasicBlockSections] Fix wrong alignment directive placement in (authored by sinan).
[CodeGen][BasicBlockSections] Fix wrong alignment directive placement in
Wed, Nov 16, 11:03 PM · Restricted Project, Restricted Project
sinan closed D137535: [CodeGen][BasicBlockSections] Fix wrong alignment directive placement in basic block section cases.
Wed, Nov 16, 11:02 PM · Restricted Project, Restricted Project
sinan updated the diff for D136237: [BasicBlockSections] avoid insertting redundant branch to fall through blocks.

remove the incorrect description.

Wed, Nov 16, 7:42 PM · Restricted Project, Restricted Project

Wed, Nov 9

sinan updated the diff for D136237: [BasicBlockSections] avoid insertting redundant branch to fall through blocks.

update the patch according to suggestions.

Wed, Nov 9, 7:32 PM · Restricted Project, Restricted Project
sinan updated the diff for D137535: [CodeGen][BasicBlockSections] Fix wrong alignment directive placement in basic block section cases.

update the test case. This test case is generated after basic-block-sections pass and the name mapping between the basic block(bb.2.entry (align 256, bbsections 2)) and the label name(test.__part.2) from the assembly can be clearer in this way.

Wed, Nov 9, 6:43 PM · Restricted Project, Restricted Project

Nov 7 2022

sinan updated the summary of D137535: [CodeGen][BasicBlockSections] Fix wrong alignment directive placement in basic block section cases.
Nov 7 2022, 12:40 AM · Restricted Project, Restricted Project
sinan added a comment to D136237: [BasicBlockSections] avoid insertting redundant branch to fall through blocks.

Hi @rahmanl, Sorry for the delay. I did not find any countercase for just checking the last terminator, and I spent some time investigating a pattern:

Nov 7 2022, 12:36 AM · Restricted Project, Restricted Project
sinan updated the diff for D136237: [BasicBlockSections] avoid insertting redundant branch to fall through blocks.

update according to comments

Nov 7 2022, 12:30 AM · Restricted Project, Restricted Project
sinan requested review of D137535: [CodeGen][BasicBlockSections] Fix wrong alignment directive placement in basic block section cases.
Nov 7 2022, 12:25 AM · Restricted Project, Restricted Project

Oct 20 2022

sinan added inline comments to D136237: [BasicBlockSections] avoid insertting redundant branch to fall through blocks.
Oct 20 2022, 6:03 AM · Restricted Project, Restricted Project
sinan added a comment to D136237: [BasicBlockSections] avoid insertting redundant branch to fall through blocks.

Hi @rahmanl, I tested with -O2, and the redundant branch can be removed by machine code sinking pass.

Oct 20 2022, 5:53 AM · Restricted Project, Restricted Project

Oct 19 2022

sinan updated the diff for D136237: [BasicBlockSections] avoid insertting redundant branch to fall through blocks.

simplify code

Oct 19 2022, 5:56 AM · Restricted Project, Restricted Project
sinan requested review of D136237: [BasicBlockSections] avoid insertting redundant branch to fall through blocks.
Oct 19 2022, 2:19 AM · Restricted Project, Restricted Project

Sep 27 2022

sinan added inline comments to D134600: [RISCV][LLD] Add RISCV zcmt optimise in linker relaxation.
Sep 27 2022, 1:37 AM · Restricted Project, Restricted Project

Sep 5 2022

sinan requested review of D133308: [cmake] do not set execution permission to regular files.
Sep 5 2022, 8:11 AM · Restricted Project, Restricted Project, Restricted Project

Sep 1 2022

sinan requested review of D133160: [cmake] Append CLANG_LIBDIR_SUFFIX to scan-build-py installation destination..
Sep 1 2022, 3:06 PM · Restricted Project, Restricted Project

Aug 2 2022

sinan accepted D128822: [FuncSpec] Partially revert rG8b360c69e9e3..

Sounds fine. I tend to accept this patch since it is a stepping stone for the patch series, and we can revisit the constant expression case later after all patches merged.

Aug 2 2022, 12:20 AM · Restricted Project, Restricted Project

Jul 25 2022

sinan added reviewers for D130461: [CodeMetrics] use hasOneLiveUse instead of hasOneUse while analyzing inlinable callsites: fhahn, nikic.
Jul 25 2022, 12:41 AM · Restricted Project, Restricted Project
sinan requested review of D130461: [CodeMetrics] use hasOneLiveUse instead of hasOneUse while analyzing inlinable callsites.
Jul 25 2022, 12:36 AM · Restricted Project, Restricted Project

Jul 11 2022

sinan added a comment to D126455: [FuncSpec] Make the Function Specializer part of the IPSCCP pass..

tryToReplaceWithConstant method in SCCP does not update the lattice value map at SCCPSolver, and it might lead to a problem that

Jul 11 2022, 11:15 PM · Restricted Project, Restricted Project
sinan added a comment to D128822: [FuncSpec] Partially revert rG8b360c69e9e3..

The reason why test cases crash at Solver.getLatticeValueFor is that SCCPSolver does not track the lattice value of a callbase argument. However, it is doable for SCCPSolver to track the lattice value of a ConstantExpr, and that is why I think skipping ConstantExpr is not an sound solution.

Jul 11 2022, 10:53 PM · Restricted Project, Restricted Project

Jun 1 2022

sinan added a comment to D126355: [FuncSpec]Fix assertion failure when lattice value is not found..

We should generate a patch with option -U9999 to offer more context to review.

Thanks for working on this. Have you measured any performance/code size change?

Also, I feel we could do better since we've already mark it as overrefined in https://github.com/llvm/llvm-project/blob/cd2292ef824591cc34cc299910a3098545c840c7/llvm/lib/Transforms/Utils/SCCPSolver.cpp#L1254
So it looks possible to get the lattice successfully.

Jun 1 2022, 10:24 PM · Restricted Project, Restricted Project

May 25 2022

sinan added a comment to D126355: [FuncSpec]Fix assertion failure when lattice value is not found..

We should generate a patch with option -U9999 to offer more context to review.

Thanks for the info and feedback. I have updated the diff file.

May 25 2022, 8:37 PM · Restricted Project, Restricted Project
sinan updated the diff for D126355: [FuncSpec]Fix assertion failure when lattice value is not found..
May 25 2022, 8:19 PM · Restricted Project, Restricted Project
sinan requested review of D126355: [FuncSpec]Fix assertion failure when lattice value is not found..
May 25 2022, 12:52 AM · Restricted Project, Restricted Project