The statement is now correct, but it's still not completely clear to me why it is necessary. All floating-point intrinsics may still produce a result in addition to raising an exception (if they do), so the definition of the result is always independent of the question what -if any- exceptions are raised. Why does this need to be called out here specifically?
I don't believe this change is correct. Note that even if an exception is raised, the instruction may still have a result (if exceptions are configured to only set a flag bit and not actually trap). This result will still be different for ordered vs. unordered comparisons.
Tue, Apr 20
Remove NSS2 variable since _Z8tnosplitIiEiv uses the same attribute as _Z3foov
Remove debuging code now that test pass on Windows as well.
Mon, Apr 19
use sys.executable to find Python executable
Thu, Apr 15
Print not found file's filename
Wed, Apr 14
Use slash as path separator
- Use exception to see file
Tue, Apr 13
Add print statement
Mon, Apr 12
Status update: I've started manually rebasing this patch on top of latest FileCheck. Hopefully I'll update this diff in about 2 weeks. Sorry for the delay.
Sat, Apr 10
Fri, Apr 9
Thu, Apr 8
Call script with python3 to not rely on it being executable
Do rely on script being executable but not on Python 3.6 being in PATH, only Python3
Do not rely on testing script being executable
@jdenny I have no more changes to make to this patch and the CI is now green. Are you ok with the patch?
Rename function instead
Wed, Apr 7
Remove directives instead
It's really hard to write checks for R600, but it's in maintenance mode. The comment doesn't really make sense to me. I doubt this check was ever really correct or stable. You can't really write this test stably and expect specific things in T registers at a specific time. I guess just go with this is it passes?
Tue, Apr 6
Rename NUW_RN for CHECK-YES to NUW
Change attribute check to a positive match
- Add unit test for multiple errors in match()
I'd suggest to simply switch these to update_tests_checks.py instead. Or is there some reason this is not possible for these tests?
Regenerate FileCheck directives with update_test_checks
Keep checking each line
$ cmake -G Ninja -DCMAKE_CXX_COMPILER=$(command -v clang++) -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang;debuginfo-tests;mlir" ../llvm ... $ ninja projects/debuginfo-tests/CMakeFiles/check-gdb-mlir-support.dir/llvm-prettyprinters/gdb/mlir-support.cpp.o ... /home/nathan/src/llvm-project/debuginfo-tests/llvm-prettyprinters/gdb/mlir-support.cpp:13:33: error: no member named 'Kind' in 'mlir::Value' mlir::Value::Kind::TrailingOpResult}); ~~~~~~~~~~~~~^ 1 error generated.
D98613 is needed to avoid other errors in this file.
Mon, Apr 5
Disable directive since it actually fails with current fix
Fix unit test failure, still need to add unit tests to cover new code