Page MenuHomePhabricator
Feed Advanced Search

Today

thopre added inline comments to D66141: [FileCheck] Forbid using var defined on same line.
Tue, Aug 20, 3:53 AM · Restricted Project
thopre updated the diff for D66141: [FileCheck] Forbid using var defined on same line.
  • Keep a positive match test
  • Fix comment in unit tests
Tue, Aug 20, 3:52 AM · Restricted Project

Yesterday

thopre added a comment to D65751: [LNT] Add support for v2 fmt in test data library.

What does this mean for the existing v1 users? Will they continue using v1 format, i.e. will LNT keep using whatever it was using before this patch or will it switch to v2? Btw, is there some place/short summary of the rationale behind v2? Not really related to this patch per se, just want to understand the implication of the new format for the downstream users.

Mon, Aug 19, 6:32 AM

Fri, Aug 16

thopre requested review of D65751: [LNT] Add support for v2 fmt in test data library.

Putting back under review to get confirmation changes made are ok.

Fri, Aug 16, 4:22 PM
thopre added inline comments to D66141: [FileCheck] Forbid using var defined on same line.
Fri, Aug 16, 3:30 AM · Restricted Project

Tue, Aug 13

thopre created D66141: [FileCheck] Forbid using var defined on same line.
Tue, Aug 13, 7:24 AM · Restricted Project
thopre added inline comments to D65751: [LNT] Add support for v2 fmt in test data library.
Tue, Aug 13, 7:19 AM
thopre updated the diff for D65751: [LNT] Add support for v2 fmt in test data library.

Reduce amount of dictionary update done

Tue, Aug 13, 7:19 AM
thopre updated the diff for D65751: [LNT] Add support for v2 fmt in test data library.

Add comments explaining version checks

Tue, Aug 13, 3:14 AM

Mon, Aug 12

thopre committed rL368642: [LNT] Add unittests for test data creation library.
[LNT] Add unittests for test data creation library
Mon, Aug 12, 5:41 PM
thopre closed D65747: [LNT] Add unittests for test data creation library.
Mon, Aug 12, 5:41 PM · Restricted Project
thopre added a comment to D65751: [LNT] Add support for v2 fmt in test data library.

Ping?

Mon, Aug 12, 5:07 AM
thopre added a comment to D65747: [LNT] Add unittests for test data creation library.

Ping?

Mon, Aug 12, 5:07 AM · Restricted Project

Thu, Aug 8

thopre committed rGb1add2b7748d: [FileCheck] Add missing includes in header (authored by thopre).
[FileCheck] Add missing includes in header
Thu, Aug 8, 6:57 AM
thopre committed rL368297: [FileCheck] Add missing includes in header.
[FileCheck] Add missing includes in header
Thu, Aug 8, 6:57 AM
thopre closed D65778: [FileCheck] Add missing includes in header.
Thu, Aug 8, 6:56 AM · Restricted Project

Tue, Aug 6

thopre updated the diff for D65778: [FileCheck] Add missing includes in header.
  • Include FileCheck.h first
  • Remove includes in FileCheck.cpp of headers already included in FileCheck.h
Tue, Aug 6, 2:40 AM · Restricted Project
thopre created D65794: [LNT] Add docker containerization files.
Tue, Aug 6, 2:12 AM
thopre accepted D65702: [FileCheck] Move -dump-input diagnostic to first line.

Does this work for multiline annotations? If I read this correctly (I often don't so my apologies if that's the case) it will print the marker for each line in a multiline annotation except the last.

It works correctly for the multi-line annotations I've tested: it prints the note (like error: no match found) only for the first line. See the test suite changes and the summary for examples. Does that help? Thanks for reviewing.

Tue, Aug 6, 1:25 AM · Restricted Project
thopre added inline comments to D65778: [FileCheck] Add missing includes in header.
Tue, Aug 6, 1:09 AM · Restricted Project
thopre updated the diff for D65778: [FileCheck] Add missing includes in header.

Address review comment

Tue, Aug 6, 1:03 AM · Restricted Project

Mon, Aug 5

thopre created D65778: [FileCheck] Add missing includes in header.
Mon, Aug 5, 2:44 PM · Restricted Project
thopre updated the diff for D65751: [LNT] Add support for v2 fmt in test data library.

Rebase on top of latest changes

Mon, Aug 5, 1:59 PM
thopre updated the diff for D65747: [LNT] Add unittests for test data creation library.

Rebase on top of latest changes

Mon, Aug 5, 1:59 PM · Restricted Project
thopre added inline comments to D65774: Removing redundant-move warnings generated by gcc9x..
Mon, Aug 5, 1:49 PM · Restricted Project
thopre accepted D65707: [FileCheck] Document FILECHECK_OPTS in -help.

LGTM.

Mon, Aug 5, 1:47 PM · Restricted Project
thopre committed rL367924: [LNT] Add missing method docstrings in lnt.testing.
[LNT] Add missing method docstrings in lnt.testing
Mon, Aug 5, 1:35 PM
thopre closed D65750: [LNT] Add missing method docstrings in lnt.testing.
Mon, Aug 5, 1:35 PM · Restricted Project
thopre committed rL367923: [LNT] Wrap comments and docstrings at 72 chars.
[LNT] Wrap comments and docstrings at 72 chars
Mon, Aug 5, 1:33 PM
thopre closed D65749: [LNT] Wrap comments and docstrings at 72 chars.
Mon, Aug 5, 1:33 PM · Restricted Project
thopre updated the diff for D65750: [LNT] Add missing method docstrings in lnt.testing.

Address review comments

Mon, Aug 5, 12:51 PM · Restricted Project
thopre added a reviewer for D65751: [LNT] Add support for v2 fmt in test data library: cmatthews.
Mon, Aug 5, 8:19 AM
thopre added a reviewer for D65750: [LNT] Add missing method docstrings in lnt.testing: cmatthews.
Mon, Aug 5, 8:18 AM · Restricted Project
thopre added a reviewer for D65747: [LNT] Add unittests for test data creation library: cmatthews.
Mon, Aug 5, 8:18 AM · Restricted Project
thopre added a reviewer for D65749: [LNT] Wrap comments and docstrings at 72 chars: cmatthews.
Mon, Aug 5, 8:18 AM · Restricted Project
thopre added inline comments to D65707: [FileCheck] Document FILECHECK_OPTS in -help.
Mon, Aug 5, 8:18 AM · Restricted Project
thopre added a comment to D65702: [FileCheck] Move -dump-input diagnostic to first line.

Does this work for multiline annotations? If I read this correctly (I often don't so my apologies if that's the case) it will print the marker for each line in a multiline annotation except the last.

Mon, Aug 5, 8:15 AM · Restricted Project
thopre added a parent revision for D65751: [LNT] Add support for v2 fmt in test data library: D65750: [LNT] Add missing method docstrings in lnt.testing.
Mon, Aug 5, 7:42 AM
thopre added a child revision for D65750: [LNT] Add missing method docstrings in lnt.testing: D65751: [LNT] Add support for v2 fmt in test data library.
Mon, Aug 5, 7:42 AM · Restricted Project
thopre added a parent revision for D65750: [LNT] Add missing method docstrings in lnt.testing: D65749: [LNT] Wrap comments and docstrings at 72 chars.
Mon, Aug 5, 7:41 AM · Restricted Project
thopre added a child revision for D65749: [LNT] Wrap comments and docstrings at 72 chars: D65750: [LNT] Add missing method docstrings in lnt.testing.
Mon, Aug 5, 7:41 AM · Restricted Project
thopre created D65751: [LNT] Add support for v2 fmt in test data library.
Mon, Aug 5, 7:40 AM
thopre created D65750: [LNT] Add missing method docstrings in lnt.testing.
Mon, Aug 5, 7:40 AM · Restricted Project
thopre added a parent revision for D65749: [LNT] Wrap comments and docstrings at 72 chars: D65747: [LNT] Add unittests for test data creation library.
Mon, Aug 5, 7:40 AM · Restricted Project
thopre added a child revision for D65747: [LNT] Add unittests for test data creation library: D65749: [LNT] Wrap comments and docstrings at 72 chars.
Mon, Aug 5, 7:40 AM · Restricted Project
thopre created D65749: [LNT] Wrap comments and docstrings at 72 chars.
Mon, Aug 5, 7:40 AM · Restricted Project
thopre created D65747: [LNT] Add unittests for test data creation library.
Mon, Aug 5, 7:37 AM · Restricted Project

Wed, Jul 24

thopre committed rG168a6dc94769: [FileCheck] Use ASSERT for fatal unit tests (authored by thopre).
[FileCheck] Use ASSERT for fatal unit tests
Wed, Jul 24, 5:40 AM
thopre committed rGa83dfd92bef4: [FileCheck]] Canonicalize caret location testing (authored by thopre).
[FileCheck]] Canonicalize caret location testing
Wed, Jul 24, 5:39 AM
thopre committed rG4cd9b853b5ae: FileCheck [8/12]: Define numeric var from expr (authored by thopre).
FileCheck [8/12]: Define numeric var from expr
Wed, Jul 24, 5:39 AM
thopre committed rL366899: [FileCheck] Use ASSERT for fatal unit tests.
[FileCheck] Use ASSERT for fatal unit tests
Wed, Jul 24, 5:39 AM
thopre committed rL366898: [FileCheck]] Canonicalize caret location testing.
[FileCheck]] Canonicalize caret location testing
Wed, Jul 24, 5:39 AM
thopre committed rL366897: FileCheck [8/12]: Define numeric var from expr.
FileCheck [8/12]: Define numeric var from expr
Wed, Jul 24, 5:39 AM
thopre committed rG5ecb8802414c: Revert "FileCheck [8/12]: Define numeric var from expr" (authored by thopre).
Revert "FileCheck [8/12]: Define numeric var from expr"
Wed, Jul 24, 12:34 AM
thopre added a reverting change for rG1b05977538d9: FileCheck [8/12]: Define numeric var from expr: rG5ecb8802414c: Revert "FileCheck [8/12]: Define numeric var from expr".
Wed, Jul 24, 12:34 AM
thopre committed rG75299de1911c: Revert "[FileCheck]] Canonicalize caret location testing" (authored by thopre).
Revert "[FileCheck]] Canonicalize caret location testing"
Wed, Jul 24, 12:34 AM
thopre added a reverting change for rGba4e8d791342: [FileCheck]] Canonicalize caret location testing: rG75299de1911c: Revert "[FileCheck]] Canonicalize caret location testing".
Wed, Jul 24, 12:33 AM
thopre committed rG00c8dab21984: Revert "[FileCheck] Use ASSERT for fatal unit tests" (authored by thopre).
Revert "[FileCheck] Use ASSERT for fatal unit tests"
Wed, Jul 24, 12:33 AM
thopre added a reverting change for rGfb596735fe9c: [FileCheck] Use ASSERT for fatal unit tests: rG00c8dab21984: Revert "[FileCheck] Use ASSERT for fatal unit tests".
Wed, Jul 24, 12:33 AM
thopre committed rL366872: Revert "FileCheck [8/12]: Define numeric var from expr".
Revert "FileCheck [8/12]: Define numeric var from expr"
Wed, Jul 24, 12:32 AM
thopre committed rL366871: Revert "[FileCheck]] Canonicalize caret location testing".
Revert "[FileCheck]] Canonicalize caret location testing"
Wed, Jul 24, 12:32 AM
thopre committed rL366870: Revert "[FileCheck] Use ASSERT for fatal unit tests".
Revert "[FileCheck] Use ASSERT for fatal unit tests"
Wed, Jul 24, 12:31 AM

Tue, Jul 23

thopre committed rGfb596735fe9c: [FileCheck] Use ASSERT for fatal unit tests (authored by thopre).
[FileCheck] Use ASSERT for fatal unit tests
Tue, Jul 23, 3:45 PM
thopre committed rGba4e8d791342: [FileCheck]] Canonicalize caret location testing (authored by thopre).
[FileCheck]] Canonicalize caret location testing
Tue, Jul 23, 3:45 PM
thopre committed rG1b05977538d9: FileCheck [8/12]: Define numeric var from expr (authored by thopre).
FileCheck [8/12]: Define numeric var from expr
Tue, Jul 23, 3:45 PM
thopre committed rL366862: [FileCheck] Use ASSERT for fatal unit tests.
[FileCheck] Use ASSERT for fatal unit tests
Tue, Jul 23, 3:45 PM
thopre committed rL366861: [FileCheck]] Canonicalize caret location testing.
[FileCheck]] Canonicalize caret location testing
Tue, Jul 23, 3:45 PM
thopre closed D64921: [FileCheck] Use ASSERT for fatal unit tests.
Tue, Jul 23, 3:45 PM · Restricted Project
thopre closed D64923: [FileCheck]] Canonicalize caret location testing.
Tue, Jul 23, 3:45 PM · Restricted Project
thopre committed rL366860: FileCheck [8/12]: Define numeric var from expr.
FileCheck [8/12]: Define numeric var from expr
Tue, Jul 23, 3:45 PM
thopre closed D60388: FileCheck [8/12]: Define numeric var from expr.
Tue, Jul 23, 3:45 PM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.
  • Remove reference to expression constraint, this is patch 11/12 material
  • Clarify what the FileCheckNumericVariable constructor does and what is rather an expectation
Tue, Jul 23, 11:28 AM · Restricted Project
thopre added a comment to D65121: [FileCheck] Make FILECHECK_OPTS useful for its test suite.

Could you add a section FileCheck-specific substitutions section in llvm/docs/TestingGuide.rst to describe %TestFileCheckOut?

Tue, Jul 23, 11:04 AM · Restricted Project

Jul 18 2019

thopre added a comment to D64923: [FileCheck]] Canonicalize caret location testing.

Readability is to some extent in the eye of the reader, so I've restrained myself to one suggestion. Otherwise this review is up to James.

Jul 18 2019, 1:32 PM · Restricted Project
thopre added a comment to D64923: [FileCheck]] Canonicalize caret location testing.

I've reintroduced the {{$}} in end of lines because it is clear the intent was to test the whole lines in existing tests.

Jul 18 2019, 8:35 AM · Restricted Project
thopre updated the summary of D64923: [FileCheck]] Canonicalize caret location testing.
Jul 18 2019, 8:34 AM · Restricted Project
thopre updated the diff for D64923: [FileCheck]] Canonicalize caret location testing.

Address review comment

Jul 18 2019, 8:33 AM · Restricted Project
thopre added a parent revision for D64921: [FileCheck] Use ASSERT for fatal unit tests: D64923: [FileCheck]] Canonicalize caret location testing.
Jul 18 2019, 7:35 AM · Restricted Project
thopre added a child revision for D64923: [FileCheck]] Canonicalize caret location testing: D64921: [FileCheck] Use ASSERT for fatal unit tests.
Jul 18 2019, 7:35 AM · Restricted Project
thopre edited child revisions for D60388: FileCheck [8/12]: Define numeric var from expr, added: 1; removed: 1.
Jul 18 2019, 7:34 AM · Restricted Project
thopre removed a parent revision for D64921: [FileCheck] Use ASSERT for fatal unit tests: D60388: FileCheck [8/12]: Define numeric var from expr.
Jul 18 2019, 7:34 AM · Restricted Project
thopre created D64923: [FileCheck]] Canonicalize caret location testing.
Jul 18 2019, 7:34 AM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.

Address remaining review comments

Jul 18 2019, 7:34 AM · Restricted Project
thopre added a parent revision for D60389: FileCheck [9/12]: Add support for matching formats: D64921: [FileCheck] Use ASSERT for fatal unit tests.
Jul 18 2019, 6:47 AM · Restricted Project
thopre edited child revisions for D60388: FileCheck [8/12]: Define numeric var from expr, added: 1; removed: 1.
Jul 18 2019, 6:47 AM · Restricted Project
thopre removed a parent revision for D60389: FileCheck [9/12]: Add support for matching formats: D60388: FileCheck [8/12]: Define numeric var from expr.
Jul 18 2019, 6:47 AM · Restricted Project
thopre added a parent revision for D64921: [FileCheck] Use ASSERT for fatal unit tests: D60388: FileCheck [8/12]: Define numeric var from expr.
Jul 18 2019, 6:47 AM · Restricted Project
thopre added a child revision for D64921: [FileCheck] Use ASSERT for fatal unit tests: D60389: FileCheck [9/12]: Add support for matching formats.
Jul 18 2019, 6:47 AM · Restricted Project
thopre created D64921: [FileCheck] Use ASSERT for fatal unit tests.
Jul 18 2019, 6:44 AM · Restricted Project
thopre committed rG70494494c1e3: [FileCheck] Fix numeric variable redefinition (authored by thopre).
[FileCheck] Fix numeric variable redefinition
Jul 18 2019, 6:40 AM
thopre committed rL366434: [FileCheck] Fix numeric variable redefinition.
[FileCheck] Fix numeric variable redefinition
Jul 18 2019, 6:38 AM
thopre closed D64882: [FileCheck] Fix numeric variable redefinition.
Jul 18 2019, 6:38 AM · Restricted Project
thopre added a comment to D64882: [FileCheck] Fix numeric variable redefinition.

LGTM.

I think I'll add unit tests as well.

Jul 18 2019, 4:51 AM · Restricted Project
thopre added a comment to D64882: [FileCheck] Fix numeric variable redefinition.

LGTM.

Jul 18 2019, 3:58 AM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.

Fix more review comments

Jul 18 2019, 3:30 AM · Restricted Project
thopre removed a child revision for D64639: [FileCheck] Store line numbers as optional values: D60388: FileCheck [8/12]: Define numeric var from expr.
Jul 18 2019, 3:15 AM · Restricted Project
thopre added a child revision for D64882: [FileCheck] Fix numeric variable redefinition: D60388: FileCheck [8/12]: Define numeric var from expr.
Jul 18 2019, 3:15 AM · Restricted Project
thopre edited parent revisions for D60388: FileCheck [8/12]: Define numeric var from expr, added: 1; removed: 1.
Jul 18 2019, 3:15 AM · Restricted Project
thopre added inline comments to D60388: FileCheck [8/12]: Define numeric var from expr.
Jul 18 2019, 3:15 AM · Restricted Project
thopre added a child revision for D64639: [FileCheck] Store line numbers as optional values: D64882: [FileCheck] Fix numeric variable redefinition.
Jul 18 2019, 3:15 AM · Restricted Project