Page MenuHomePhabricator
Feed Advanced Search

Today

thopre committed rG2fdedf905a6b: [doc] Clarify constrained fcmps behavior (authored by thopre).
[doc] Clarify constrained fcmps behavior
Fri, Apr 23, 3:55 AM
thopre closed D101053: [doc] Clarify constrained fcmps behavior.
Fri, Apr 23, 3:55 AM · Restricted Project

Yesterday

thopre added a comment to D101053: [doc] Clarify constrained fcmps behavior.

The statement is now correct, but it's still not completely clear to me why it is necessary. All floating-point intrinsics may still produce a result in addition to raising an exception (if they do), so the definition of the result is always independent of the question what -if any- exceptions are raised. Why does this need to be called out here specifically?

Thu, Apr 22, 2:33 PM · Restricted Project
thopre updated the diff for D101053: [doc] Clarify constrained fcmps behavior.

Fix clarification

Thu, Apr 22, 7:06 AM · Restricted Project
thopre added a comment to D101053: [doc] Clarify constrained fcmps behavior.

I don't believe this change is correct. Note that even if an exception is raised, the instruction may still have a result (if exceptions are configured to only set a flag bit and not actually trap). This result will still be different for ordered vs. unordered comparisons.

Thu, Apr 22, 6:01 AM · Restricted Project
thopre requested review of D101053: [doc] Clarify constrained fcmps behavior.
Thu, Apr 22, 5:21 AM · Restricted Project

Tue, Apr 20

thopre committed rGfd941036bf24: Fix PR46880: Fail CHECK-NOT with undefined variable (authored by thopre).
Fix PR46880: Fail CHECK-NOT with undefined variable
Tue, Apr 20, 6:42 AM
thopre closed D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.
Tue, Apr 20, 6:42 AM · Restricted Project
thopre committed rGd618c6e8ceb7: [lit, test] Fix test cancellation feature detection (authored by thopre).
[lit, test] Fix test cancellation feature detection
Tue, Apr 20, 4:09 AM
thopre closed D99728: [lit, test] Fix test cancellation feature detection.
Tue, Apr 20, 4:09 AM · Restricted Project
thopre updated the diff for D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Rebase

Tue, Apr 20, 4:08 AM · Restricted Project
thopre committed rG8cee150e9ac4: [C++, test] Fix typo in NSS* vars (authored by thopre).
[C++, test] Fix typo in NSS* vars
Tue, Apr 20, 4:07 AM
thopre closed D99839: [C++, test] Fix typo in NSS* vars.
Tue, Apr 20, 4:07 AM · Restricted Project
thopre updated the summary of D99839: [C++, test] Fix typo in NSS* vars.
Tue, Apr 20, 4:06 AM · Restricted Project
thopre added inline comments to D99839: [C++, test] Fix typo in NSS* vars.
Tue, Apr 20, 4:00 AM · Restricted Project
thopre updated the diff for D99839: [C++, test] Fix typo in NSS* vars.

Remove NSS2 variable since _Z8tnosplitIiEiv uses the same attribute as _Z3foov

Tue, Apr 20, 4:00 AM · Restricted Project
thopre added inline comments to D99839: [C++, test] Fix typo in NSS* vars.
Tue, Apr 20, 3:03 AM · Restricted Project
thopre added inline comments to D99728: [lit, test] Fix test cancellation feature detection.
Tue, Apr 20, 1:40 AM · Restricted Project
thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Remove debuging code now that test pass on Windows as well.

Tue, Apr 20, 1:39 AM · Restricted Project
thopre added inline comments to D99839: [C++, test] Fix typo in NSS* vars.
Tue, Apr 20, 1:37 AM · Restricted Project

Mon, Apr 19

thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

use sys.executable to find Python executable

Mon, Apr 19, 8:21 AM · Restricted Project
thopre added inline comments to D99728: [lit, test] Fix test cancellation feature detection.
Mon, Apr 19, 8:01 AM · Restricted Project
thopre added a comment to D99839: [C++, test] Fix typo in NSS* vars.

Ping?

Mon, Apr 19, 2:47 AM · Restricted Project
thopre added reviewers for D99839: [C++, test] Fix typo in NSS* vars: ChuanqiXu, MaskRay, nmcintosh.
Mon, Apr 19, 2:47 AM · Restricted Project

Thu, Apr 15

thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Print not found file's filename

Thu, Apr 15, 1:09 PM · Restricted Project

Wed, Apr 14

thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Fix joining

Wed, Apr 14, 2:06 PM · Restricted Project
thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Use slash as path separator

Wed, Apr 14, 1:12 PM · Restricted Project
thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.
  • Use exception to see file
Wed, Apr 14, 1:39 AM · Restricted Project

Tue, Apr 13

thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Add print statement

Tue, Apr 13, 2:34 PM · Restricted Project

Mon, Apr 12

thopre added a comment to D60392: FileCheck [12/12]: Support use of var defined on same line.

Status update: I've started manually rebasing this patch on top of latest FileCheck. Hopefully I'll update this diff in about 2 weeks. Sorry for the delay.

Mon, Apr 12, 2:08 AM · Restricted Project

Sat, Apr 10

thopre updated the diff for D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Fix comment

Sat, Apr 10, 1:47 PM · Restricted Project

Fri, Apr 9

thopre updated the diff for D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Rebase

Fri, Apr 9, 7:07 AM · Restricted Project
thopre added a comment to D99839: [C++, test] Fix typo in NSS* vars.

Ping?

Fri, Apr 9, 4:59 AM · Restricted Project
thopre committed rG0494b6b6769f: [PowerPC, test] Fix use of undef FileCheck var (authored by thopre).
[PowerPC, test] Fix use of undef FileCheck var
Fri, Apr 9, 4:55 AM
thopre closed D99881: [PowerPC, test] Fix use of undef FileCheck var.
Fri, Apr 9, 4:55 AM · Restricted Project
thopre committed rGbb69173ae5d1: [PowerPC, test] Fix use of undef FileCheck var (authored by thopre).
[PowerPC, test] Fix use of undef FileCheck var
Fri, Apr 9, 4:54 AM
thopre closed D99870: [PowerPC, test] Fix use of undef FileCheck var.
Fri, Apr 9, 4:54 AM · Restricted Project
thopre committed rG494ba60bb71e: [PowerPC, test] Fix use of undef FileCheck var (authored by thopre).
[PowerPC, test] Fix use of undef FileCheck var
Fri, Apr 9, 4:10 AM
thopre closed D99868: [PowerPC, test] Fix use of undef FileCheck var.
Fri, Apr 9, 4:09 AM · Restricted Project
thopre added a comment to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Thanks for all that work on the other tests! Still LGTM.

Fri, Apr 9, 2:07 AM · Restricted Project
thopre committed rG623475248a9d: [test, LoopVectorize] Fix use of var defined in CHECK-NOT (authored by thopre).
[test, LoopVectorize] Fix use of var defined in CHECK-NOT
Fri, Apr 9, 2:02 AM
thopre closed D99582: [test, LoopVectorize] Fix use of var defined in CHECK-NOT.
Fri, Apr 9, 2:02 AM · Restricted Project

Thu, Apr 8

thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Call script with python3 to not rely on it being executable

Thu, Apr 8, 2:01 PM · Restricted Project
thopre committed rG5ca168b03211: [FileCheck, test] Rename checkWildcardRegexCharMatchFailure (authored by thopre).
[FileCheck, test] Rename checkWildcardRegexCharMatchFailure
Thu, Apr 8, 1:58 PM
thopre closed D98343: [FileCheck, test] Rename checkWildcardRegexCharMatchFailure.
Thu, Apr 8, 1:57 PM · Restricted Project
thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Do rely on script being executable but not on Python 3.6 being in PATH, only Python3

Thu, Apr 8, 3:56 AM · Restricted Project
thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Do not rely on testing script being executable

Thu, Apr 8, 3:54 AM · Restricted Project
thopre added a comment to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

@jdenny I have no more changes to make to this patch and the CI is now green. Are you ok with the patch?

Thu, Apr 8, 3:41 AM · Restricted Project
thopre updated the diff for D98343: [FileCheck, test] Rename checkWildcardRegexCharMatchFailure.

Rename function instead

Thu, Apr 8, 3:39 AM · Restricted Project
thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Simplify logic

Thu, Apr 8, 3:27 AM · Restricted Project
thopre updated the diff for D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Rebase

Thu, Apr 8, 1:45 AM · Restricted Project
thopre committed rG04419628e011: [AMDGPU, test] Fix use of undef FileCheck var (authored by thopre).
[AMDGPU, test] Fix use of undef FileCheck var
Thu, Apr 8, 1:43 AM
thopre closed D99865: [AMDGPU, test] Fix use of undef FileCheck var.
Thu, Apr 8, 1:43 AM · Restricted Project

Wed, Apr 7

thopre retitled D99865: [AMDGPU, test] Fix use of undef FileCheck var from [RFC, AMDGPU, test] Fix use of undef FileCheck var to [AMDGPU, test] Fix use of undef FileCheck var.
Wed, Apr 7, 3:28 PM · Restricted Project
thopre updated the diff for D99865: [AMDGPU, test] Fix use of undef FileCheck var.

Remove directives instead

Wed, Apr 7, 3:28 PM · Restricted Project
thopre added a comment to D99865: [AMDGPU, test] Fix use of undef FileCheck var.

It's really hard to write checks for R600, but it's in maintenance mode. The comment doesn't really make sense to me. I doubt this check was ever really correct or stable. You can't really write this test stably and expect specific things in T registers at a specific time. I guess just go with this is it passes?

Wed, Apr 7, 2:51 PM · Restricted Project
thopre updated the summary of D99868: [PowerPC, test] Fix use of undef FileCheck var.
Wed, Apr 7, 3:53 AM · Restricted Project
thopre committed rG73a7d451a2ca: [PowerPC, test] Fix use of undef FileCheck var (authored by thopre).
[PowerPC, test] Fix use of undef FileCheck var
Wed, Apr 7, 1:45 AM
thopre closed D99880: [PowerPC, test] Fix use of undef FileCheck var.
Wed, Apr 7, 1:45 AM · Restricted Project
thopre committed rGe018698bec36: [clang, test] Fix use of undef FileCheck var (authored by thopre).
[clang, test] Fix use of undef FileCheck var
Wed, Apr 7, 1:44 AM
thopre closed D99898: [clang, test] Fix use of undef FileCheck var.
Wed, Apr 7, 1:44 AM · Restricted Project
thopre committed rGb62c62c51973: [Coroutines, test] Fix use of var defined in CHECK-NOT (authored by thopre).
[Coroutines, test] Fix use of var defined in CHECK-NOT
Wed, Apr 7, 1:43 AM
thopre closed D99856: [Coroutines, test] Fix use of var defined in CHECK-NOT.
Wed, Apr 7, 1:43 AM · Restricted Project

Tue, Apr 6

thopre committed rG3ba246719b7c: [test, AArch64] Fix use of var defined in CHECK-NOT (authored by thopre).
[test, AArch64] Fix use of var defined in CHECK-NOT
Tue, Apr 6, 1:15 PM
thopre closed D99866: [test, AArch64] Fix use of var defined in CHECK-NOT.
Tue, Apr 6, 1:15 PM · Restricted Project
thopre updated the diff for D99898: [clang, test] Fix use of undef FileCheck var.

Rename NUW_RN for CHECK-YES to NUW

Tue, Apr 6, 1:12 PM · Restricted Project
thopre committed rG1d9d7f6a2c0f: [MLIR, test] Fix use of undef FileCheck var (authored by thopre).
[MLIR, test] Fix use of undef FileCheck var
Tue, Apr 6, 12:08 PM
thopre closed D99957: [MLIR, test] Fix use of undef FileCheck var.
Tue, Apr 6, 12:08 PM · Restricted Project
thopre added inline comments to D99866: [test, AArch64] Fix use of var defined in CHECK-NOT.
Tue, Apr 6, 12:07 PM · Restricted Project
thopre updated the summary of D99898: [clang, test] Fix use of undef FileCheck var.
Tue, Apr 6, 12:04 PM · Restricted Project
thopre updated the diff for D99898: [clang, test] Fix use of undef FileCheck var.

Change attribute check to a positive match

Tue, Apr 6, 12:03 PM · Restricted Project
thopre added a comment to D99957: [MLIR, test] Fix use of undef FileCheck var.

thanks!

Is the line 319 referencing the right version of l0?? Is there an equivalent to update_test_checks for mlir-opt that we could use perhaps?

Tue, Apr 6, 10:18 AM · Restricted Project
thopre updated the diff for D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.
  • Add unit test for multiple errors in match()
  • Rebase
Tue, Apr 6, 9:10 AM · Restricted Project
thopre committed rG9c5ebf035896: [test, GVN] Fix use of var defined in CHECK-NOT (authored by thopre).
[test, GVN] Fix use of var defined in CHECK-NOT
Tue, Apr 6, 9:00 AM
thopre closed D99581: [test, GVN] Fix use of var defined in CHECK-NOT.
Tue, Apr 6, 9:00 AM · Restricted Project
thopre committed rG17f4f23eeab4: [MLIR, test] Fix use of undef FileCheck var (authored by thopre).
[MLIR, test] Fix use of undef FileCheck var
Tue, Apr 6, 8:58 AM
thopre closed D99958: [MLIR, test] Fix use of undef FileCheck var.
Tue, Apr 6, 8:58 AM · Restricted Project
thopre added a comment to D99957: [MLIR, test] Fix use of undef FileCheck var.

thanks!

Tue, Apr 6, 8:45 AM · Restricted Project
thopre committed rGb36ef9f47db7: [MLIR, test] Fix use of undef FileCheck var (authored by thopre).
[MLIR, test] Fix use of undef FileCheck var
Tue, Apr 6, 8:27 AM
thopre closed D99956: [MLIR, test] Fix use of undef FileCheck var.
Tue, Apr 6, 8:27 AM · Restricted Project
thopre requested review of D99958: [MLIR, test] Fix use of undef FileCheck var.
Tue, Apr 6, 7:26 AM · Restricted Project
thopre requested review of D99957: [MLIR, test] Fix use of undef FileCheck var.
Tue, Apr 6, 7:25 AM · Restricted Project
thopre requested review of D99956: [MLIR, test] Fix use of undef FileCheck var.
Tue, Apr 6, 7:25 AM · Restricted Project
Herald added a project to D78498: [mlir] [linalg] Only promote selected buffers.: Restricted Project.
Tue, Apr 6, 6:56 AM · Restricted Project, Restricted Project
thopre added a comment to D99581: [test, GVN] Fix use of var defined in CHECK-NOT.

I'd suggest to simply switch these to update_tests_checks.py instead. Or is there some reason this is not possible for these tests?

Tue, Apr 6, 4:26 AM · Restricted Project
thopre updated the diff for D99581: [test, GVN] Fix use of var defined in CHECK-NOT.

Regenerate FileCheck directives with update_test_checks

Tue, Apr 6, 4:25 AM · Restricted Project
thopre added inline comments to D99582: [test, LoopVectorize] Fix use of var defined in CHECK-NOT.
Tue, Apr 6, 4:17 AM · Restricted Project
thopre updated the diff for D99582: [test, LoopVectorize] Fix use of var defined in CHECK-NOT.

Keep checking each line

Tue, Apr 6, 4:17 AM · Restricted Project
thopre added a comment to D97804: [mlir][IR] Refactor the internal implementation of Value.
$ cmake -G Ninja -DCMAKE_CXX_COMPILER=$(command -v clang++) -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang;debuginfo-tests;mlir" ../llvm
...

$ ninja projects/debuginfo-tests/CMakeFiles/check-gdb-mlir-support.dir/llvm-prettyprinters/gdb/mlir-support.cpp.o
...
/home/nathan/src/llvm-project/debuginfo-tests/llvm-prettyprinters/gdb/mlir-support.cpp:13:33: error: no member named 'Kind' in 'mlir::Value'
                   mlir::Value::Kind::TrailingOpResult});
                   ~~~~~~~~~~~~~^
1 error generated.

D98613 is needed to avoid other errors in this file.

Tue, Apr 6, 4:06 AM · Restricted Project
thopre committed rG638d70be6b93: [test, AArch64] Fix use of var defined in CHECK-NOT (authored by thopre).
[test, AArch64] Fix use of var defined in CHECK-NOT
Tue, Apr 6, 2:45 AM
thopre closed D99602: [test, AArch64] Fix use of var defined in CHECK-NOT.
Tue, Apr 6, 2:45 AM · Restricted Project
thopre added a comment to D99602: [test, AArch64] Fix use of var defined in CHECK-NOT.

Ping?

Tue, Apr 6, 2:13 AM · Restricted Project
thopre added a comment to D99582: [test, LoopVectorize] Fix use of var defined in CHECK-NOT.

Ping?

Tue, Apr 6, 2:13 AM · Restricted Project
thopre added a comment to D99581: [test, GVN] Fix use of var defined in CHECK-NOT.

Ping?

Tue, Apr 6, 2:13 AM · Restricted Project

Mon, Apr 5

thopre added inline comments to D99870: [PowerPC, test] Fix use of undef FileCheck var.
Mon, Apr 5, 3:37 PM · Restricted Project
thopre updated the diff for D99870: [PowerPC, test] Fix use of undef FileCheck var.

Disable directive since it actually fails with current fix

Mon, Apr 5, 3:37 PM · Restricted Project
thopre added a comment to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

How many tests does this patch break?

60, one of them being the FileCheck unittest which I haven't adapted yet. I've already made 4 patches solving 5 tests:

Mon, Apr 5, 1:59 PM · Restricted Project
thopre updated the diff for D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Fix unit test failure, still need to add unit tests to cover new code

Mon, Apr 5, 1:57 PM · Restricted Project
thopre requested review of D99898: [clang, test] Fix use of undef FileCheck var.
Mon, Apr 5, 1:42 PM · Restricted Project
thopre committed rG828ec9e9e5da: [OpenCL, test] Fix use of undef FileCheck var (authored by thopre).
[OpenCL, test] Fix use of undef FileCheck var
Mon, Apr 5, 1:11 PM