Page MenuHomePhabricator
Feed Advanced Search

Jul 11 2019

Nathan-Huckleberry committed rG83c94bfc0a10: [Docs] Add standardized header links to analyzer doc (authored by Nathan-Huckleberry).
[Docs] Add standardized header links to analyzer doc
Jul 11 2019, 10:13 AM
Nathan-Huckleberry committed rL365797: [Docs] Add standardized header links to analyzer doc.
[Docs] Add standardized header links to analyzer doc
Jul 11 2019, 10:11 AM
Nathan-Huckleberry closed D64543: [Docs] Add standardized header links to analyzer doc.
Jul 11 2019, 10:11 AM · Restricted Project, Restricted Project
Nathan-Huckleberry updated subscribers of D64543: [Docs] Add standardized header links to analyzer doc.
Jul 11 2019, 10:09 AM · Restricted Project, Restricted Project

Jul 10 2019

Nathan-Huckleberry added a comment to D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.

Docs exist for these checks on the analyzer side, they're just all on the same page and hyperlinking to them individually is difficult because the links have a nonstandard naming convention. Currently I'm just linking to that page.

I think it'll be reasonable to standardize Static Analyzer documentation links first.

Jul 10 2019, 5:45 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added reviewers for D64543: [Docs] Add standardized header links to analyzer doc: JonasToth, aaron.ballman, NoQ, Szelethus.
Jul 10 2019, 5:44 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64543: [Docs] Add standardized header links to analyzer doc.
  • Fix .m and i..
Jul 10 2019, 5:44 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64543: [Docs] Add standardized header links to analyzer doc.
  • Fix file periods being converted to dashes
Jul 10 2019, 5:35 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64543: [Docs] Add standardized header links to analyzer doc.
  • Fixed periods in sentences being dashes
Jul 10 2019, 5:32 PM · Restricted Project, Restricted Project
Nathan-Huckleberry created D64543: [Docs] Add standardized header links to analyzer doc.
Jul 10 2019, 5:24 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added a comment to D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.

May be script should generate documentation during build, so files .rst files are not needed?

I'd personally weakly advise against that, to be honest;
that would not be inherently bad though, i think.

Please also insert empty line between header (===) and text.

Is there some docs for these checks on clang analyzer side? (will there be?)
Perhaps these can link to those main docs?

Jul 10 2019, 3:10 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added inline comments to D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
Jul 10 2019, 2:20 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
  • Added script for generation of docs based off Checkers.td
Jul 10 2019, 2:18 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added a comment to D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.

I'm worried that this will continue to drift out of sync with the static analyzer checks unless we find some way to automate it. I wonder if we could write a script to generate these .rst files and somehow fit it into the workflow for adding new static analyzer checks to re-run the script to produce new files (or modified files) as needed? @NoQ and @Szelethus may have ideas.

Jul 10 2019, 9:58 AM · Restricted Project, Restricted Project

Jul 9 2019

Nathan-Huckleberry added reviewers for D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks: JonasToth, aaron.ballman.
Jul 9 2019, 4:22 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added a comment to D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.

The contents of each check page are identical other than the check name.

Jul 9 2019, 4:17 PM · Restricted Project, Restricted Project
Nathan-Huckleberry created D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
Jul 9 2019, 4:17 PM · Restricted Project, Restricted Project

Jul 8 2019

Nathan-Huckleberry added reviewers for D63889: Check possible warnings on global initializers for reachability: rsmith, aaron.ballman.
Jul 8 2019, 10:15 AM · Restricted Project

Jul 3 2019

Nathan-Huckleberry updated the diff for D63889: Check possible warnings on global initializers for reachability.
  • Stylistic fixes of function names and removal of namespace prefixes
Jul 3 2019, 4:51 PM · Restricted Project
Nathan-Huckleberry updated the diff for D63889: Check possible warnings on global initializers for reachability.
  • Small functional and formatting changes
Jul 3 2019, 4:34 PM · Restricted Project
Nathan-Huckleberry added inline comments to D63889: Check possible warnings on global initializers for reachability.
Jul 3 2019, 4:10 PM · Restricted Project

Jul 1 2019

Nathan-Huckleberry committed rG121401425d4d: [analyzer] Support kfree in MallocChecker (authored by Nathan-Huckleberry).
[analyzer] Support kfree in MallocChecker
Jul 1 2019, 4:36 PM
Nathan-Huckleberry committed rL364875: [analyzer] Support kfree in MallocChecker.
[analyzer] Support kfree in MallocChecker
Jul 1 2019, 4:35 PM
Nathan-Huckleberry closed D64030: [analyzer] Support kfree in MallocChecker.
Jul 1 2019, 4:35 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added reviewers for D64030: [analyzer] Support kfree in MallocChecker: jordan_rose, NoQ, nickdesaulniers.
Jul 1 2019, 1:05 PM · Restricted Project, Restricted Project
Nathan-Huckleberry created D64030: [analyzer] Support kfree in MallocChecker.
Jul 1 2019, 12:59 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added reviewers for D63889: Check possible warnings on global initializers for reachability: pirama, srhines.
Jul 1 2019, 9:57 AM · Restricted Project

Jun 27 2019

Nathan-Huckleberry committed rG13fde7a89a53: [analyzer] Fix clang-tidy crash on GCCAsmStmt (authored by Nathan-Huckleberry).
[analyzer] Fix clang-tidy crash on GCCAsmStmt
Jun 27 2019, 3:52 PM
Nathan-Huckleberry committed rL364605: [analyzer] Fix clang-tidy crash on GCCAsmStmt.
[analyzer] Fix clang-tidy crash on GCCAsmStmt
Jun 27 2019, 3:52 PM
Nathan-Huckleberry closed D63533: [analyzer] Fix clang-tidy crash on GCCAsmStmt.
Jun 27 2019, 3:52 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D63533: [analyzer] Fix clang-tidy crash on GCCAsmStmt.
  • Minor style change on assert
Jun 27 2019, 3:35 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D63533: [analyzer] Fix clang-tidy crash on GCCAsmStmt.
  • Add assertion message and simplify test case
Jun 27 2019, 1:26 PM · Restricted Project, Restricted Project
Nathan-Huckleberry created D63889: Check possible warnings on global initializers for reachability.
Jun 27 2019, 12:29 PM · Restricted Project

Jun 19 2019

Nathan-Huckleberry added inline comments to D63533: [analyzer] Fix clang-tidy crash on GCCAsmStmt.
Jun 19 2019, 2:41 PM · Restricted Project, Restricted Project
Nathan-Huckleberry committed rG321f902a0122: [AST] Fixed extraneous warnings for binary conditional operator (authored by Nathan-Huckleberry).
[AST] Fixed extraneous warnings for binary conditional operator
Jun 19 2019, 11:34 AM
Nathan-Huckleberry committed rL363857: [AST] Fixed extraneous warnings for binary conditional operator.
[AST] Fixed extraneous warnings for binary conditional operator
Jun 19 2019, 11:34 AM
Nathan-Huckleberry closed D63369: [AST] Fixed extraneous warnings for binary conditional operator.
Jun 19 2019, 11:34 AM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D63533: [analyzer] Fix clang-tidy crash on GCCAsmStmt.
  • [analyzer] Revise test case and add TODO
Jun 19 2019, 11:06 AM · Restricted Project, Restricted Project

Jun 18 2019

Nathan-Huckleberry added reviewers for D63533: [analyzer] Fix clang-tidy crash on GCCAsmStmt: nickdesaulniers, dergachev.a, george.karpenkov.
Jun 18 2019, 5:10 PM · Restricted Project, Restricted Project
Nathan-Huckleberry created D63533: [analyzer] Fix clang-tidy crash on GCCAsmStmt.
Jun 18 2019, 5:07 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D63369: [AST] Fixed extraneous warnings for binary conditional operator.

Mistakenly updated revision. Attempting to revert.

Jun 18 2019, 4:52 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D63369: [AST] Fixed extraneous warnings for binary conditional operator.
  • [analyzer] Fix clang-tidy crash on GCCAsmStmt
Jun 18 2019, 4:43 PM · Restricted Project, Restricted Project

Jun 17 2019

Nathan-Huckleberry updated the diff for D63369: [AST] Fixed extraneous warnings for binary conditional operator.
  • [AST] Formatting changes to ConditionalOperator unused detection
Jun 17 2019, 11:23 AM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D63369: [AST] Fixed extraneous warnings for binary conditional operator.
  • [AST] Cleanup of conditional operator unused warning detection
Jun 17 2019, 10:33 AM · Restricted Project, Restricted Project

Jun 14 2019

Nathan-Huckleberry added reviewers for D63369: [AST] Fixed extraneous warnings for binary conditional operator: rsmith, aaron.ballman, nickdesaulniers.
Jun 14 2019, 4:11 PM · Restricted Project, Restricted Project
Nathan-Huckleberry created D63369: [AST] Fixed extraneous warnings for binary conditional operator.
Jun 14 2019, 4:01 PM · Restricted Project, Restricted Project