For a while I will be in a place where the Internet does not work well. I'll finish the patch when I come back.
Aug 11 2022
First of all, thank you for your feedback! I've tried to address all your comments.
Aug 10 2022
Aug 9 2022
In sum, this change brings the following improvements for all graph traversal iterators that are used in 'range-based for loop':
- avoid creating an empty iterator (that holds containers inside) to compare with the end iterator
- make 'empty()' call explicit (instead of comparing two containers of iterators) when an iterator is compared with the end iterator
Fix mlir build and rebase
Aug 8 2022
Aug 7 2022
LGTM. Maybe in the future it's better to use SwiftABIInfo as mix-in like this
Jul 26 2022
@ChuanqiXu , the release notes were updated. Could you check and merge please?
Add a release note.
Jul 25 2022
@ChuanqiXu , I've added additional comments. Could you check again please?
Rebase and add additional comments.
Jul 24 2022
@ChuanqiXu , could you take a look again? I've updated the original implementation.
Update the origianl implementation.
Jul 21 2022
My concern here is with the behavior of PrintMessage and friends. The original change would produce misleading output there. WIth the current change, PrintMessage will print the location of the definition (if it is known).
Jul 20 2022
Right you are, sorry for my confusion. The patch isn't quite right because it overrides the current meaning of the Locs array (which is to track multiclass instantiations), and that can lead to confusion e.g. with PrintMessage. I took the liberty of making some adjustments before committing the patch (394a388d140dc9e74178532501cddb558a589398)
Jul 19 2022
Jul 18 2022
Unfortunately I don't have time to finish this pull request, so please feel free to take it and get it done =)
(You may reuse the code from this PR or write a completely new implementation)
Jul 17 2022
This failure is not related to my changes
Jul 16 2022
Removed unsed 'private' access specifier.
changed commit message
Jul 13 2022
I can merge it!
Jul 12 2022
I have no permission to merge. @MaskRay could you merge please?