Page MenuHomePhabricator
Feed Advanced Search

Jun 28 2017

yawanng updated the diff for D34633: [clang-tidy] Rename android-file-open-flag and fix a bug.

rename the check.

Jun 28 2017, 6:25 PM · Restricted Project
yawanng updated the diff for D33747: [clang-tidy][Part3] Add a new module Android and three new checks..

rename the check.

Jun 28 2017, 6:14 PM · Restricted Project
yawanng updated the diff for D33745: [clang-tidy][Part2] Add a new module Android and three new checks.

Format change.

Jun 28 2017, 6:01 PM · Restricted Project
yawanng updated the diff for D33745: [clang-tidy][Part2] Add a new module Android and three new checks.

rename this check.

Jun 28 2017, 5:51 PM · Restricted Project

Jun 27 2017

yawanng updated the diff for D33747: [clang-tidy][Part3] Add a new module Android and three new checks..
Jun 27 2017, 2:03 PM · Restricted Project

Jun 26 2017

yawanng updated the diff for D33747: [clang-tidy][Part3] Add a new module Android and three new checks..
Jun 26 2017, 12:03 PM · Restricted Project
yawanng created D34633: [clang-tidy] Rename android-file-open-flag and fix a bug.
Jun 26 2017, 10:35 AM · Restricted Project
yawanng updated the diff for D33745: [clang-tidy][Part2] Add a new module Android and three new checks.
Jun 26 2017, 9:51 AM · Restricted Project

Jun 23 2017

yawanng updated the diff for D33747: [clang-tidy][Part3] Add a new module Android and three new checks..

url format fix in doc.rst

Jun 23 2017, 4:20 PM · Restricted Project
yawanng updated the diff for D33745: [clang-tidy][Part2] Add a new module Android and three new checks.

Format fix.

Jun 23 2017, 4:01 PM · Restricted Project
yawanng committed rL306172: [clang-tidy] doc format fix.
[clang-tidy] doc format fix
Jun 23 2017, 3:13 PM
yawanng closed D34573: [clang-tidy] doc format fix.
Jun 23 2017, 3:13 PM · Restricted Project
yawanng created D34573: [clang-tidy] doc format fix.
Jun 23 2017, 2:59 PM · Restricted Project
yawanng committed rL306165: [clang-tidy][Part1] Add a new module Android and three new checks..
[clang-tidy][Part1] Add a new module Android and three new checks.
Jun 23 2017, 2:38 PM
yawanng closed D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
Jun 23 2017, 2:38 PM · Restricted Project

Jun 19 2017

yawanng updated the diff for D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
Jun 19 2017, 9:57 AM · Restricted Project

Jun 16 2017

yawanng added a comment to D34114: [clang] Change the condition of unnecessary packed warning.

Ping.

Jun 16 2017, 2:05 PM

Jun 15 2017

yawanng updated the diff for D33745: [clang-tidy][Part2] Add a new module Android and three new checks.
Jun 15 2017, 4:28 PM · Restricted Project
yawanng updated the diff for D33745: [clang-tidy][Part2] Add a new module Android and three new checks.
Jun 15 2017, 4:24 PM · Restricted Project
yawanng updated the diff for D33304: [clang-tidy][Part1] Add a new module Android and three new checks..

Format change.

Jun 15 2017, 10:48 AM · Restricted Project

Jun 14 2017

yawanng added inline comments to D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
Jun 14 2017, 10:45 AM · Restricted Project
yawanng updated the diff for D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
Jun 14 2017, 10:45 AM · Restricted Project

Jun 13 2017

yawanng updated the summary of D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
Jun 13 2017, 10:29 AM · Restricted Project
yawanng added inline comments to D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
Jun 13 2017, 10:02 AM · Restricted Project

Jun 12 2017

yawanng updated subscribers of D34114: [clang] Change the condition of unnecessary packed warning.
Jun 12 2017, 1:29 PM
yawanng created D34114: [clang] Change the condition of unnecessary packed warning.
Jun 12 2017, 12:24 PM

Jun 9 2017

yawanng updated the diff for D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
Jun 9 2017, 12:15 PM · Restricted Project

Jun 7 2017

yawanng committed rL304949: [clang-tidy] When" -fno-exceptions is used", this warning is better to be….
[clang-tidy] When" -fno-exceptions is used", this warning is better to be…
Jun 7 2017, 3:39 PM
yawanng closed D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed..
Jun 7 2017, 3:39 PM · Restricted Project
yawanng updated the diff for D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed..
Jun 7 2017, 3:38 PM · Restricted Project
yawanng updated the diff for D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
Jun 7 2017, 3:28 PM · Restricted Project
yawanng updated the diff for D33747: [clang-tidy][Part3] Add a new module Android and three new checks..
Jun 7 2017, 3:25 PM · Restricted Project
yawanng updated the diff for D33745: [clang-tidy][Part2] Add a new module Android and three new checks.
Jun 7 2017, 3:20 PM · Restricted Project
yawanng created D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed..
Jun 7 2017, 10:52 AM · Restricted Project
yawanng committed rL304931: [clang-tidy] When" -fno-exceptions is used", this warning is better to be….
[clang-tidy] When" -fno-exceptions is used", this warning is better to be…
Jun 7 2017, 10:42 AM
yawanng closed D33917: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed..
Jun 7 2017, 10:42 AM · Restricted Project
yawanng updated the diff for D33917: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed..
Jun 7 2017, 10:21 AM · Restricted Project

Jun 5 2017

yawanng updated the diff for D33917: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed..

Format changing.

Jun 5 2017, 3:47 PM · Restricted Project
yawanng edited reviewers for D33917: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed., added: aaron.ballman; removed: mgrang.
Jun 5 2017, 3:42 PM · Restricted Project
yawanng created D33917: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed..
Jun 5 2017, 3:41 PM · Restricted Project

Jun 2 2017

yawanng updated the diff for D33304: [clang-tidy][Part1] Add a new module Android and three new checks..

Format changes.

Jun 2 2017, 2:33 PM · Restricted Project
yawanng updated the diff for D33747: [clang-tidy][Part3] Add a new module Android and three new checks..
Jun 2 2017, 1:43 PM · Restricted Project
yawanng updated the diff for D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
Jun 2 2017, 1:42 PM · Restricted Project
yawanng updated the diff for D33745: [clang-tidy][Part2] Add a new module Android and three new checks.
Jun 2 2017, 11:40 AM · Restricted Project
yawanng added inline comments to D33747: [clang-tidy][Part3] Add a new module Android and three new checks..
Jun 2 2017, 11:31 AM · Restricted Project
yawanng updated the diff for D33747: [clang-tidy][Part3] Add a new module Android and three new checks..
Jun 2 2017, 11:31 AM · Restricted Project

Jun 1 2017

yawanng updated the diff for D33747: [clang-tidy][Part3] Add a new module Android and three new checks..

Modify the format.

Jun 1 2017, 3:38 PM · Restricted Project
yawanng updated the summary of D33747: [clang-tidy][Part3] Add a new module Android and three new checks..
Jun 1 2017, 3:35 PM · Restricted Project

May 31 2017

yawanng updated the summary of D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
May 31 2017, 4:33 PM · Restricted Project
yawanng created D33747: [clang-tidy][Part3] Add a new module Android and three new checks..
May 31 2017, 4:24 PM · Restricted Project
yawanng updated the diff for D33745: [clang-tidy][Part2] Add a new module Android and three new checks.
May 31 2017, 4:19 PM · Restricted Project
yawanng created D33745: [clang-tidy][Part2] Add a new module Android and three new checks.
May 31 2017, 4:12 PM · Restricted Project
yawanng updated the diff for D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
May 31 2017, 4:06 PM · Restricted Project
yawanng retitled D33304: [clang-tidy][Part1] Add a new module Android and three new checks. from [clang-tidy] Add a new module Android and three new checks. to [clang-tidy][Part1] Add a new module Android and three new checks..
May 31 2017, 3:34 PM · Restricted Project
yawanng updated the diff for D33304: [clang-tidy][Part1] Add a new module Android and three new checks..

Split the commit to three ones that each of them contains one. This is the first part.

May 31 2017, 3:34 PM · Restricted Project
yawanng updated the summary of D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
May 31 2017, 10:35 AM · Restricted Project
yawanng added a comment to D33304: [clang-tidy][Part1] Add a new module Android and three new checks..

It's awesome to see another two checks, and it seems to justify adding a separate module, but I'd prefer the other two checks to be sent for review as separate patches to make the review easier and faster.

May 31 2017, 10:34 AM · Restricted Project
yawanng updated the summary of D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
May 31 2017, 10:27 AM · Restricted Project

May 30 2017

yawanng retitled D33304: [clang-tidy][Part1] Add a new module Android and three new checks. from [clang-tidy] Add a new module Android and a new check for file descriptors. to [clang-tidy] Add a new module Android and three new checks..
May 30 2017, 4:00 PM · Restricted Project
yawanng updated the diff for D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
May 30 2017, 3:05 PM · Restricted Project
yawanng updated the diff for D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
May 30 2017, 2:52 PM · Restricted Project
yawanng added a comment to D33304: [clang-tidy][Part1] Add a new module Android and three new checks..

Hi, I have updated this CL for review. Thank you very much :)

May 30 2017, 2:49 PM · Restricted Project
yawanng retitled D33304: [clang-tidy][Part1] Add a new module Android and three new checks. from [WIP][clang-tidy] Add a new module Android and a new check for file descriptors. to [clang-tidy] Add a new module Android and a new check for file descriptors. .
May 30 2017, 2:45 PM · Restricted Project
yawanng updated the diff for D33304: [clang-tidy][Part1] Add a new module Android and three new checks..

Modify the detection algorithm. Add another two checks and corresponding tests as well as the docs.

May 30 2017, 2:43 PM · Restricted Project

May 22 2017

yawanng added a comment to D33304: [clang-tidy][Part1] Add a new module Android and three new checks..

I will make some major changes to this CL based on the current suggestions from reviewers and update it for further review later. Thank you for the valuable advice.

May 22 2017, 8:27 AM · Restricted Project

May 18 2017

yawanng added a comment to D33304: [clang-tidy][Part1] Add a new module Android and three new checks..

I find the use of "must" at the very least inappropriate. If there was no use case for not including it, it wouldn't be an option. There is also nothing really Android-specific here beside maybe the open64 mess.

On Android, we are requiring this flag. That is why this is part of a new category of Android-specific tidy rules. If you think this belongs more generally in a different category for tidy, can you suggest somewhere else to put it? We didn't want to impose these restrictions for platforms that might not want to be so strict. Also, as with any static analysis, there is the possibility that the original code author intended to "break" the rules, but that is what NOLINT is for.

I'm not keen on putting this in an Android module either, as it's not really Android-specific behavior. For instance, this is also part of a recommended compliant solution for CERT FIO22-C.

I think AOSP has enough specific guidelines and requirements to warrant a separate module (especially, if Android folks have plans to contribute more than one check into it ;). As for this check, if the relevant requirements of CERT and Android are really identical, we could make an alias for the check in the CERT module (or vice versa). Another possibility that comes to mind is to create a new "posix" module specifically for things related to POSIX APIs (or "unix", if we want it to be slightly broader). WDYT?

If there are plans to add more checks, then yes. However, I think I'd prefer to see at least 2-3 checks in the work (or have some commitment for doing at least that many checks) before we add a module for it. I mostly worry about adding a single check and then nothing else. (No matter what module name we're talking about, btw.) I'd be fine with android, posix, or unix, depending on the nature of the checks.

I think this should probably be in misc, or the bugprone module that @alexfh has mentioned previously.

I'm strongly against bloating "misc" module. It's more or less the last resort, a place for checks we have found no better place for. The proposed "bugprone" module is an attempt to address this by pulling out a large part of "misc" to a place with more definite name and purpose. However, in the case of this check we seem to have enough good (and more specific) alternatives to default to "misc" or even "bugprone".

I was hesitant to suggest misc, but I was hoping to avoid adding a module with a single check under it and no commitment for further ones.

May 18 2017, 12:50 PM · Restricted Project
yawanng retitled D33304: [clang-tidy][Part1] Add a new module Android and three new checks. from [clang-tidy] Add a new module Android and a new check for file descriptors. to [WIP][clang-tidy] Add a new module Android and a new check for file descriptors. .
May 18 2017, 10:34 AM · Restricted Project
yawanng added inline comments to D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
May 18 2017, 10:30 AM · Restricted Project
yawanng updated the diff for D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
May 18 2017, 9:45 AM · Restricted Project

May 17 2017

yawanng updated the summary of D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
May 17 2017, 7:45 PM · Restricted Project
yawanng updated the diff for D33304: [clang-tidy][Part1] Add a new module Android and three new checks..

Add unit test file.

May 17 2017, 5:25 PM · Restricted Project
yawanng updated the summary of D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
May 17 2017, 5:19 PM · Restricted Project
yawanng created D33304: [clang-tidy][Part1] Add a new module Android and three new checks..
May 17 2017, 5:18 PM · Restricted Project

May 13 2017

yawanng committed rL303001: [clang-tidy] TwineLocalCheck: add param # checking.
[clang-tidy] TwineLocalCheck: add param # checking
May 13 2017, 9:28 PM
yawanng closed D33103: [clang-tidy] TwineLocalCheck: add param # checking.
May 13 2017, 9:28 PM · Restricted Project

May 11 2017

yawanng updated the diff for D33103: [clang-tidy] TwineLocalCheck: add param # checking.

Add more tests.

May 11 2017, 5:36 PM · Restricted Project
yawanng updated the diff for D33103: [clang-tidy] TwineLocalCheck: add param # checking.
May 11 2017, 3:04 PM · Restricted Project
yawanng added a reviewer for D33103: [clang-tidy] TwineLocalCheck: add param # checking: bkramer.
May 11 2017, 2:43 PM · Restricted Project
yawanng updated the diff for D33103: [clang-tidy] TwineLocalCheck: add param # checking.
May 11 2017, 11:50 AM · Restricted Project
yawanng created D33103: [clang-tidy] TwineLocalCheck: add param # checking.
May 11 2017, 9:32 AM · Restricted Project