Page MenuHomePhabricator
Feed Advanced Search

Aug 11 2017

yawanng updated the diff for D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module..
Aug 11 2017, 10:14 AM · Restricted Project
yawanng updated the diff for D35363: [clang-tidy] Add a close-on-exec check on accept4() in Android module..
Aug 11 2017, 10:11 AM · Restricted Project
yawanng added inline comments to D35364: [clang-tidy] Add a close-on-exec check on dup() in Android module..
Aug 11 2017, 10:09 AM · Restricted Project
yawanng updated the diff for D35364: [clang-tidy] Add a close-on-exec check on dup() in Android module..
Aug 11 2017, 10:08 AM · Restricted Project
yawanng updated the diff for D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module..
Aug 11 2017, 10:04 AM · Restricted Project
yawanng updated the diff for D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module..
Aug 11 2017, 10:02 AM · Restricted Project
yawanng updated the diff for D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module..
Aug 11 2017, 10:02 AM · Restricted Project
yawanng updated the diff for D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module..
Aug 11 2017, 9:58 AM · Restricted Project

Aug 10 2017

yawanng updated the diff for D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module..
Aug 10 2017, 5:16 PM · Restricted Project
yawanng updated the diff for D35363: [clang-tidy] Add a close-on-exec check on accept4() in Android module..
Aug 10 2017, 5:07 PM · Restricted Project
yawanng updated the diff for D35364: [clang-tidy] Add a close-on-exec check on dup() in Android module..
Aug 10 2017, 4:56 PM · Restricted Project
yawanng updated the diff for D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module..
Aug 10 2017, 4:43 PM · Restricted Project
yawanng updated the diff for D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module..
Aug 10 2017, 4:35 PM · Restricted Project
yawanng updated the diff for D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module..
Aug 10 2017, 4:25 PM · Restricted Project
yawanng updated the diff for D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module..
Aug 10 2017, 4:13 PM · Restricted Project
yawanng added a comment to D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..

rL310669 is the latest and complete version. It fixes an issue in windows platform.

Aug 10 2017, 3:56 PM · Restricted Project
yawanng updated the diff for D35743: [clang-format] Adjust space around &/&& of structured bindings.

Show full context.

Aug 10 2017, 3:24 PM · Restricted Project
yawanng committed rL310669: [clang-tidy] Fix for buildbot..
[clang-tidy] Fix for buildbot.
Aug 10 2017, 3:10 PM
yawanng committed rL310643: [clang-tidy] Fix a buildbot..
[clang-tidy] Fix a buildbot.
Aug 10 2017, 11:20 AM
yawanng committed rL310630: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create()….
[clang-tidy] Refactor the code and add a close-on-exec check on memfd_create()…
Aug 10 2017, 10:19 AM
yawanng closed D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..
Aug 10 2017, 10:18 AM · Restricted Project
yawanng updated the diff for D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..
Aug 10 2017, 10:13 AM · Restricted Project

Aug 9 2017

yawanng updated the diff for D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..
Aug 9 2017, 11:30 AM · Restricted Project

Aug 7 2017

yawanng added a comment to D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..

Looks good to me, a few nits. Thanks for improving it continuously.

I'd hold it for a while to see whether @alexfh has further comments before submitting it.

Aug 7 2017, 1:16 PM · Restricted Project
yawanng updated the diff for D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..
Aug 7 2017, 1:15 PM · Restricted Project

Aug 4 2017

yawanng added inline comments to D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..
Aug 4 2017, 10:50 AM · Restricted Project
yawanng updated the diff for D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..
Aug 4 2017, 10:50 AM · Restricted Project

Aug 3 2017

yawanng added inline comments to D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..
Aug 3 2017, 10:27 AM · Restricted Project
yawanng updated the diff for D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..
Aug 3 2017, 10:26 AM · Restricted Project

Aug 1 2017

yawanng committed rL309750: [clang] Change the condition of unnecessary packed warning.
[clang] Change the condition of unnecessary packed warning
Aug 1 2017, 2:42 PM
yawanng closed D34114: [clang] Change the condition of unnecessary packed warning.
Aug 1 2017, 2:42 PM
yawanng updated the diff for D35743: [clang-format] Adjust space around &/&& of structured bindings.

Move tests to unitest and fix a bug.

Aug 1 2017, 2:15 PM · Restricted Project

Jul 31 2017

yawanng added a comment to D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..

Ping.

Jul 31 2017, 3:29 PM · Restricted Project
yawanng added a comment to D35743: [clang-format] Adjust space around &/&& of structured bindings.

Ping.

Jul 31 2017, 3:29 PM · Restricted Project

Jul 28 2017

yawanng retitled D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module. from [clang-tidy] Add a close-on-exec check on memfd_create() in Android module. to [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..
Jul 28 2017, 4:04 PM · Restricted Project
yawanng updated the diff for D34114: [clang] Change the condition of unnecessary packed warning.
Jul 28 2017, 10:01 AM

Jul 27 2017

yawanng updated the diff for D34114: [clang] Change the condition of unnecessary packed warning.

Add more tests and restrict the conditions.

Jul 27 2017, 5:16 PM
yawanng updated the diff for D34114: [clang] Change the condition of unnecessary packed warning.
Jul 27 2017, 12:21 PM

Jul 26 2017

yawanng updated the diff for D34114: [clang] Change the condition of unnecessary packed warning.

Add more tests.

Jul 26 2017, 6:29 PM
yawanng updated the diff for D34114: [clang] Change the condition of unnecessary packed warning.
Jul 26 2017, 6:08 PM
yawanng updated the diff for D34114: [clang] Change the condition of unnecessary packed warning.

Including cases 'attribute((packed, aligned(X)));'. When the alignment before packing is less or equal to the packed one, he 'packed' attribute not including 'aligned(X)' seems unnecessary. Because the alignment won't change as well as the size after removing 'packed'.

Jul 26 2017, 6:02 PM
yawanng added inline comments to D34114: [clang] Change the condition of unnecessary packed warning.
Jul 26 2017, 4:27 PM
yawanng retitled D34114: [clang] Change the condition of unnecessary packed warning from [clang] A better format for unnecessary packed warning. to [clang] Change the condition of unnecessary packed warning.
Jul 26 2017, 4:03 PM
yawanng added a comment to D34114: [clang] Change the condition of unnecessary packed warning.

Some concrete suggestions throughout the patch, but I think we should take a step back and reconsider this warning approach: it seems bizarre for us to warn on any packed struct that happens to contain a char. It would make sense to warn if an __attribute__((packed)) written in the source has *no* effect (because it's applied to a struct where all fields already have alignment 1, or because it's applied to a field that has alignment 1) -- even then I'm not entirely convinced this is a valuable warning, but I assume there's some reason you want to warn on it :)

Jul 26 2017, 4:01 PM
yawanng updated the diff for D34114: [clang] Change the condition of unnecessary packed warning.

Change the condition of this unnecessary packed warning to when the alignment of the class is one byte. Remove all field-level warning.

Jul 26 2017, 3:59 PM

Jul 24 2017

yawanng added a comment to D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..

Ping

Jul 24 2017, 9:52 AM · Restricted Project

Jul 21 2017

yawanng created D35743: [clang-format] Adjust space around &/&& of structured bindings.
Jul 21 2017, 3:47 PM · Restricted Project

Jul 20 2017

yawanng updated the diff for D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..

Refactor the check, add a base class for it, which can facilitate all other similar checks. Basically, all checks in the same category will have only one or two lines code in both "check" and "registerMatcher" by inheriting the base class. If this looks good, I will modify all other similar ones. Thank you :-)

Jul 20 2017, 10:59 AM · Restricted Project

Jul 17 2017

yawanng added a comment to D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..

I have deja vu ;)

Should we make a single check for all CLOEXEC and friends with a single configurable list of (function name, flag name) pairs?

Okay, it may be a bit more complicated than just a list of function name -> flag name mappings, since we have to take in account the argument position as well. We also might want to check the signature to a certain degree to avoid matching wrong function. There are multiple approaches possible to rule out incorrect functions with the same name:

  1. just look at the number of arguments - this might well be enough, since for a certain codebase I wouldn't expect multiple memfd_create's etc. It would allow user configurability of the function -> flag mappings.
  2. encode the types of arguments as strings and have a small dictionary of matchers in the check (e.g. "const char*" -> pointerType(pointee(isAnyCharacter()))) - that will be more precise and still quite flexible and also allow user-configurable function -> flag mappings. But this mechanism may be an overkill, if we don't anticipate user-configurable functions. I don't know how complex the resulting code turns out to be.
  3. Add a matcher for each function statically. This would obviously allow for arbitrarily complex matchers, but won't be extensible via configuration options.
Jul 17 2017, 10:51 AM · Restricted Project

Jul 13 2017

yawanng updated the diff for D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module..
Jul 13 2017, 2:52 PM · Restricted Project
yawanng updated the diff for D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module..
Jul 13 2017, 1:55 PM · Restricted Project
yawanng updated the diff for D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module..
Jul 13 2017, 1:51 PM · Restricted Project
yawanng updated the diff for D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module..
Jul 13 2017, 1:44 PM · Restricted Project
yawanng updated the diff for D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..
Jul 13 2017, 1:41 PM · Restricted Project
yawanng updated the summary of D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module..
Jul 13 2017, 11:07 AM · Restricted Project
yawanng updated the summary of D35363: [clang-tidy] Add a close-on-exec check on accept4() in Android module..
Jul 13 2017, 11:01 AM · Restricted Project
yawanng updated the summary of D35364: [clang-tidy] Add a close-on-exec check on dup() in Android module..
Jul 13 2017, 11:01 AM · Restricted Project
yawanng updated the summary of D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module..
Jul 13 2017, 11:01 AM · Restricted Project
yawanng updated the summary of D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module..
Jul 13 2017, 11:01 AM · Restricted Project
yawanng updated the summary of D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module..
Jul 13 2017, 11:01 AM · Restricted Project
yawanng updated the summary of D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module..
Jul 13 2017, 11:00 AM · Restricted Project
yawanng updated the summary of D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..
Jul 13 2017, 11:00 AM · Restricted Project
yawanng retitled D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module. from [clang-tidy] Add close-on-exec checks on several functions in Android module. to [clang-tidy] Add a close-on-exec check on accept() in Android module..
Jul 13 2017, 10:56 AM · Restricted Project
yawanng updated the summary of D35363: [clang-tidy] Add a close-on-exec check on accept4() in Android module..
Jul 13 2017, 10:55 AM · Restricted Project
yawanng updated the summary of D35364: [clang-tidy] Add a close-on-exec check on dup() in Android module..
Jul 13 2017, 10:55 AM · Restricted Project
yawanng updated the summary of D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module..
Jul 13 2017, 10:54 AM · Restricted Project
yawanng retitled D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module. from Add a close-on-exec check on epoll_create() in Android module. to [clang-tidy] Add a close-on-exec check on epoll_create() in Android module..
Jul 13 2017, 10:54 AM · Restricted Project
yawanng updated the summary of D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module..
Jul 13 2017, 10:53 AM · Restricted Project
yawanng updated the summary of D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..
Jul 13 2017, 10:53 AM · Restricted Project
yawanng retitled D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module. from Add a close-on-exec check on inotify_init1() in Android module. to [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module..
Jul 13 2017, 10:53 AM · Restricted Project
yawanng created D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..
Jul 13 2017, 10:50 AM · Restricted Project
yawanng created D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module..
Jul 13 2017, 10:45 AM · Restricted Project
yawanng created D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module..
Jul 13 2017, 10:44 AM · Restricted Project
yawanng created D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module..
Jul 13 2017, 10:42 AM · Restricted Project
yawanng created D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module..
Jul 13 2017, 10:39 AM · Restricted Project
yawanng created D35364: [clang-tidy] Add a close-on-exec check on dup() in Android module..
Jul 13 2017, 10:36 AM · Restricted Project
yawanng created D35363: [clang-tidy] Add a close-on-exec check on accept4() in Android module..
Jul 13 2017, 10:34 AM · Restricted Project
yawanng created D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module..
Jul 13 2017, 10:29 AM · Restricted Project

Jul 12 2017

yawanng committed rL307818: [clang-tidy] Add a new Android check "android-cloexec-socket".
[clang-tidy] Add a new Android check "android-cloexec-socket"
Jul 12 2017, 10:44 AM
yawanng closed D34913: [clang-tidy] Add a new Android check "android-cloexec-socket" by committing rL307818: [clang-tidy] Add a new Android check "android-cloexec-socket".
Jul 12 2017, 10:44 AM · Restricted Project
yawanng added a comment to D34913: [clang-tidy] Add a new Android check "android-cloexec-socket".

Please wait for Alexander, Aaron or Haojian approval.

Jul 12 2017, 10:13 AM · Restricted Project

Jul 11 2017

yawanng updated the diff for D34913: [clang-tidy] Add a new Android check "android-cloexec-socket".
Jul 11 2017, 9:59 AM · Restricted Project

Jul 10 2017

yawanng added a comment to D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry.

LGTM. Please wait for Alexander approval.

Jul 10 2017, 4:23 PM · Restricted Project
yawanng added inline comments to D34913: [clang-tidy] Add a new Android check "android-cloexec-socket".
Jul 10 2017, 10:42 AM · Restricted Project
yawanng updated the diff for D34913: [clang-tidy] Add a new Android check "android-cloexec-socket".
Jul 10 2017, 10:42 AM · Restricted Project

Jul 5 2017

yawanng added a comment to D34114: [clang] Change the condition of unnecessary packed warning.

PING

Jul 5 2017, 3:56 PM
yawanng updated the diff for D34913: [clang-tidy] Add a new Android check "android-cloexec-socket".
Jul 5 2017, 10:03 AM · Restricted Project

Jun 30 2017

yawanng created D34913: [clang-tidy] Add a new Android check "android-cloexec-socket".
Jun 30 2017, 3:21 PM · Restricted Project

Jun 29 2017

yawanng committed rL306728: [clang-tidy] Rename android-file-open-flag and fix a bug.
[clang-tidy] Rename android-file-open-flag and fix a bug
Jun 29 2017, 12:14 PM
yawanng closed D34633: [clang-tidy] Rename android-file-open-flag and fix a bug.
Jun 29 2017, 12:13 PM · Restricted Project
yawanng updated the diff for D34633: [clang-tidy] Rename android-file-open-flag and fix a bug.

Change the file name in toctree.

Jun 29 2017, 11:46 AM · Restricted Project
yawanng committed rL306719: [clang-tidy] Add docs to toctree.
[clang-tidy] Add docs to toctree
Jun 29 2017, 11:44 AM
yawanng closed D34825: [clang-tidy] Add docs to toctree.
Jun 29 2017, 11:44 AM
yawanng created D34825: [clang-tidy] Add docs to toctree.
Jun 29 2017, 11:38 AM
yawanng retitled D34633: [clang-tidy] Rename android-file-open-flag and fix a bug from [clang-tidy] Fix a bug in android-file-open-flag to [clang-tidy] Rename android-file-open-flag and fix a bug.
Jun 29 2017, 11:36 AM · Restricted Project
yawanng updated the diff for D34633: [clang-tidy] Rename android-file-open-flag and fix a bug.

Pull back the previous change. For some reason it's lost.

Jun 29 2017, 10:57 AM · Restricted Project
yawanng committed rL306709: [clang-tidy][Part3] Add a new module Android and three new checks..
[clang-tidy][Part3] Add a new module Android and three new checks.
Jun 29 2017, 10:42 AM
yawanng closed D33747: [clang-tidy][Part3] Add a new module Android and three new checks..
Jun 29 2017, 10:42 AM · Restricted Project
yawanng committed rL306708: [clang-tidy][Part2] Add a new module Android and three new checks.
[clang-tidy][Part2] Add a new module Android and three new checks
Jun 29 2017, 10:41 AM
yawanng closed D33745: [clang-tidy][Part2] Add a new module Android and three new checks.
Jun 29 2017, 10:41 AM · Restricted Project