Page MenuHomePhabricator
Feed Advanced Search

Thu, Aug 22

tlively added inline comments to D66545: [WebAssembly] Add Emscripten support for UBSan, LSan and ASan.
Thu, Aug 22, 11:49 AM · Restricted Project, Restricted Project

Fri, Aug 16

tlively accepted D66356: [WebAssembly] Forbid use of EM_ASM with setjmp/longjmp.
Fri, Aug 16, 11:18 AM · Restricted Project
tlively added inline comments to D66356: [WebAssembly] Forbid use of EM_ASM with setjmp/longjmp.
Fri, Aug 16, 11:00 AM · Restricted Project

Wed, Aug 14

tlively added a comment to D65783: [WebAssembly] Initialize memory in start function.

Thanks for you comments! I am also planning to update the memory initialization scheme to use wait and notify so that it works with racing modules instead of requiring the runtime to ensure that no module is called into before the main module is finished initializing. In a web context the runtime will have to ensure the main thread wins this race because it is not allowed to wait, but this is still strictly more general than the current scheme. Does that sound good to you?

Wed, Aug 14, 9:59 AM · Restricted Project
tlively committed rGde0133eaa2c5: [WebAssembly] Stop unrolling SIMD shifts since they are fixed in V8 (authored by tlively).
[WebAssembly] Stop unrolling SIMD shifts since they are fixed in V8
Wed, Aug 14, 9:25 AM
tlively committed rL368868: [WebAssembly] Stop unrolling SIMD shifts since they are fixed in V8.
[WebAssembly] Stop unrolling SIMD shifts since they are fixed in V8
Wed, Aug 14, 9:24 AM
tlively closed D66166: [WebAssembly] Stop unrolling SIMD shifts since they are fixed in V8.
Wed, Aug 14, 9:24 AM · Restricted Project

Tue, Aug 13

tlively created D66166: [WebAssembly] Stop unrolling SIMD shifts since they are fixed in V8.
Tue, Aug 13, 2:06 PM · Restricted Project

Wed, Aug 7

tlively accepted D65887: [TargetLowering] SimplifyDemandedBits - call SimplifyMultipleUseDemandedBits for ISD::EXTRACT_VECTOR_ELT.

@tlively Another thing we could consider is adding WebAssemblyISD opcodes for zero extending extract vector element - similar to what X86ISD does with PEXTRW/PEXTRB - this would avoid the need for the (and, extract_element(v, c), 0xFFFF) pattern that is causing all the problems.

Wed, Aug 7, 1:41 PM · Restricted Project

Tue, Aug 6

tlively accepted D65684: [WebAssembly] Lower ASan constructor priority on Emscripten.

It would be good to add a test here, too ;)

Tue, Aug 6, 1:05 PM · Restricted Project, Restricted Project
tlively accepted D65785: [WebAssembly] Fix null pointer in createInitTLSFunction.
Tue, Aug 6, 1:03 PM · Restricted Project
tlively added a comment to D65720: [WebAssembly] Regenerate SIMD Arithmetic tests.

Sounds good; I'm happy to help out.

Tue, Aug 6, 8:57 AM · Restricted Project

Mon, Aug 5

tlively accepted D65785: [WebAssembly] Fix null pointer in createInitTLSFunction.
Mon, Aug 5, 7:30 PM · Restricted Project
tlively added a comment to D65785: [WebAssembly] Fix null pointer in createInitTLSFunction.

Oops it would be good to have a test, too ;)

Mon, Aug 5, 7:30 PM · Restricted Project
tlively created D65783: [WebAssembly] Initialize memory in start function.
Mon, Aug 5, 5:46 PM · Restricted Project
tlively added a comment to D65720: [WebAssembly] Regenerate SIMD Arithmetic tests.

I have mixed feelings about this. One one hand I understand that this file is huge and cross-cutting changes could cause a lot of manual updating work, but on the other hand each individual test was very readable and succinct. The auto-generated version would certainly be less work to maintain, but its enormous amount of irrelevant information and repetition is unfortunate. @aheejin, what do you think about this?

Mon, Aug 5, 12:58 PM · Restricted Project
tlively accepted D65463: [WebAssembly] Fix conflict between ret legalization and sjlj.

LGTM with a small test format change.

Mon, Aug 5, 11:56 AM · Restricted Project
tlively added inline comments to D65684: [WebAssembly] Lower ASan constructor priority on Emscripten.
Mon, Aug 5, 11:34 AM · Restricted Project, Restricted Project

Wed, Jul 31

tlively added inline comments to D64758: [WebAssembly] Assembler/InstPrinter: support call_indirect type index..
Wed, Jul 31, 10:52 AM · Restricted Project
tlively added a comment to D65463: [WebAssembly] Fix conflict between ret legalization and sjlj.

I like this approach. I prefer the option 2 among the three options you described: 1 is redundantly doing what ISel is already doing, and 3 makes LLVM-backend generated code incorrect so we have to rely on the other tool to fix it, which seems not very desirable. As you said, having to add an extra argument to the interface of CanLowerReturn is a bit sad but I don't really mind that if others are OK with it.

@dschuff @tlively Any more opinions?

Wed, Jul 31, 10:47 AM · Restricted Project

Tue, Jul 30

tlively accepted D64758: [WebAssembly] Assembler/InstPrinter: support call_indirect type index..

This looks great! The code is straightforward and I like the extra information in the text format. We will have to do a little more work to support return_call_indirect, but it looks like doing so should be fairly straightforward on top of this base.

Tue, Jul 30, 11:03 PM · Restricted Project
tlively committed rGe0a9dce543ad: [WebAssembly] Do not emit tail calls with return type mismatch (authored by tlively).
[WebAssembly] Do not emit tail calls with return type mismatch
Tue, Jul 30, 11:09 AM
tlively committed rL367339: [WebAssembly] Do not emit tail calls with return type mismatch.
[WebAssembly] Do not emit tail calls with return type mismatch
Tue, Jul 30, 11:08 AM
tlively closed D65246: [WebAssembly] Do not emit tail calls with return type mismatch.
Tue, Jul 30, 11:08 AM · Restricted Project

Mon, Jul 29

tlively updated the diff for D65246: [WebAssembly] Do not emit tail calls with return type mismatch.
  • Update documentation
Mon, Jul 29, 6:01 PM · Restricted Project
tlively added inline comments to D65246: [WebAssembly] Do not emit tail calls with return type mismatch.
Mon, Jul 29, 5:55 PM · Restricted Project

Jul 26 2019

tlively updated the diff for D65246: [WebAssembly] Do not emit tail calls with return type mismatch.
  • Do not allow varargs tail calls
Jul 26 2019, 8:11 PM · Restricted Project
tlively updated the diff for D65246: [WebAssembly] Do not emit tail calls with return type mismatch.
  • Address comments, add a few more tests
Jul 26 2019, 6:24 PM · Restricted Project
tlively added inline comments to D65246: [WebAssembly] Do not emit tail calls with return type mismatch.
Jul 26 2019, 5:03 PM · Restricted Project
tlively updated the diff for D65246: [WebAssembly] Do not emit tail calls with return type mismatch.
  • Record proper return types for indirect tail calls as well
Jul 26 2019, 4:15 PM · Restricted Project

Jul 24 2019

tlively created D65246: [WebAssembly] Do not emit tail calls with return type mismatch.
Jul 24 2019, 3:19 PM · Restricted Project
tlively accepted D65177: [WebAssembly] Set __tls_align to 1 when there is no TLS.
Jul 24 2019, 11:24 AM · Restricted Project

Jul 23 2019

tlively accepted D65177: [WebAssembly] Set __tls_align to 1 when there is no TLS.
Jul 23 2019, 5:46 PM · Restricted Project

Jul 19 2019

tlively accepted D65028: [WebAssembly] Compute and export TLS block alignment.

Nice

Jul 19 2019, 4:32 PM · Restricted Project, Restricted Project

Jul 18 2019

tlively committed rG6a6f28f7b720: [WebAssembly] Use passive segments by default when memory is shared (authored by tlively).
[WebAssembly] Use passive segments by default when memory is shared
Jul 18 2019, 2:51 PM
tlively committed rL366504: [WebAssembly] Use passive segments by default when memory is shared.
[WebAssembly] Use passive segments by default when memory is shared
Jul 18 2019, 2:51 PM
tlively closed D64950: [WebAssembly] Use passive segments by default when memory is shared.
Jul 18 2019, 2:50 PM · Restricted Project
tlively added inline comments to D64950: [WebAssembly] Use passive segments by default when memory is shared.
Jul 18 2019, 2:39 PM · Restricted Project
tlively updated the diff for D64950: [WebAssembly] Use passive segments by default when memory is shared.
  • Simplify flags logic
Jul 18 2019, 2:39 PM · Restricted Project
tlively created D64950: [WebAssembly] Use passive segments by default when memory is shared.
Jul 18 2019, 2:10 PM · Restricted Project
tlively accepted D64949: [WebAssembly] Fix __builtin_wasm_tls_base intrinsic.

LGTM modulo a test!

Jul 18 2019, 2:08 PM · Restricted Project, Restricted Project

Jul 16 2019

tlively accepted D64537: [WebAssembly] Implement thread-local storage (local-exec model).

Nice work!

Jul 16 2019, 3:00 PM · Restricted Project, Restricted Project
tlively added a comment to D64537: [WebAssembly] Implement thread-local storage (local-exec model).

LGTM apart from one last comment

Jul 16 2019, 1:08 PM · Restricted Project, Restricted Project

Jul 15 2019

tlively accepted D64705: [WebAssembly] Add missing utility methods for exnref type.
Jul 15 2019, 2:53 PM · Restricted Project
tlively accepted D64704: [WebAssembly] Simplify regcopy.mir.
Jul 15 2019, 2:07 PM · Restricted Project

Jul 12 2019

tlively added inline comments to D64537: [WebAssembly] Implement thread-local storage (local-exec model).
Jul 12 2019, 8:30 PM · Restricted Project, Restricted Project
tlively committed rGdb8e36481a21: [WebAssembly] Make pthread imply bulk-memory, mutable-globals (authored by tlively).
[WebAssembly] Make pthread imply bulk-memory, mutable-globals
Jul 12 2019, 11:24 AM
tlively committed rL365935: [WebAssembly] Make pthread imply bulk-memory, mutable-globals.
[WebAssembly] Make pthread imply bulk-memory, mutable-globals
Jul 12 2019, 11:23 AM
tlively closed D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals.
Jul 12 2019, 11:23 AM · Restricted Project, Restricted Project
tlively committed rG26a6b95da9ba: [WebAssembly] i32.const operands should be signed (authored by tlively).
[WebAssembly] i32.const operands should be signed
Jul 12 2019, 10:57 AM
tlively committed rL365930: [WebAssembly] i32.const operands should be signed.
[WebAssembly] i32.const operands should be signed
Jul 12 2019, 10:57 AM
tlively closed D64612: [WebAssembly] i32.const operands should be signed.
Jul 12 2019, 10:56 AM · Restricted Project
tlively added inline comments to D64612: [WebAssembly] i32.const operands should be signed.
Jul 12 2019, 10:56 AM · Restricted Project

Jul 11 2019

tlively created D64612: [WebAssembly] i32.const operands should be signed.
Jul 11 2019, 6:13 PM · Restricted Project
tlively updated the diff for D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals.
  • and other comment
Jul 11 2019, 4:07 PM · Restricted Project, Restricted Project
tlively updated the diff for D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals.
  • Update comment
Jul 11 2019, 4:07 PM · Restricted Project, Restricted Project
tlively updated the diff for D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals.
  • Add mutable-globals
Jul 11 2019, 4:07 PM · Restricted Project, Restricted Project
tlively retitled D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals from [WebAssembly] Make -pthread imply -bulk-memory to [WebAssembly] Make pthread imply bulk-memory, mutable-globals.
Jul 11 2019, 4:07 PM · Restricted Project, Restricted Project
tlively added inline comments to D64537: [WebAssembly] Implement thread-local storage (local-exec model).
Jul 11 2019, 3:30 PM · Restricted Project, Restricted Project
tlively created D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals.
Jul 11 2019, 1:19 PM · Restricted Project, Restricted Project

Jul 8 2019

tlively accepted D64372: [LLD] NFC: Fixed GCC warning in wasm/OutputSections.cpp.

Thanks!

Jul 8 2019, 3:26 PM · Restricted Project

Jul 3 2019

tlively committed rG6004d9a13d1f: [WebAssembly] Add option to emit passive segments (authored by tlively).
[WebAssembly] Add option to emit passive segments
Jul 3 2019, 3:06 PM
tlively committed rL365088: [WebAssembly] Add option to emit passive segments.
[WebAssembly] Add option to emit passive segments
Jul 3 2019, 3:05 PM
tlively closed D59343: [WebAssembly] Add option to emit passive segments.
Jul 3 2019, 3:05 PM · Restricted Project
tlively accepted rGed13fef47741: [SelectionDAG] Do minnum->minimum at legalization time instead of building time.

Yeah this looks great. Thanks!

Jul 3 2019, 11:30 AM

Jul 2 2019

tlively added inline comments to D64115: [WebAssembly] Prevent inline assembly from being mangled by SjLj.
Jul 2 2019, 5:33 PM · Restricted Project
tlively accepted D64115: [WebAssembly] Prevent inline assembly from being mangled by SjLj.

LGTM with a quick explanatory comment!

Jul 2 2019, 5:29 PM · Restricted Project

Jun 28 2019

tlively added a comment to D59343: [WebAssembly] Add option to emit passive segments.

@sbc100 it's been a long time but there is nothing blocking this change any more, so PTAL!

Jun 28 2019, 5:11 PM · Restricted Project
tlively updated the diff for D59343: [WebAssembly] Add option to emit passive segments.
  • Remove extraneous braces
Jun 28 2019, 5:09 PM · Restricted Project
tlively updated the diff for D59343: [WebAssembly] Add option to emit passive segments.

Change to use explicit flags instead of depending on shared
memory. This means this change is a nop in existing
toolchains. Emscripten can be taught to use the new flags explicitly
without requiring a manual double roll.

Jun 28 2019, 5:00 PM · Restricted Project
tlively updated the summary of D59343: [WebAssembly] Add option to emit passive segments.
Jun 28 2019, 4:45 PM · Restricted Project
tlively retitled D59343: [WebAssembly] Add option to emit passive segments from [WebAssembly] Use passive segments when memory is shared to [WebAssembly] Add option to emit passive segments.
Jun 28 2019, 4:43 PM · Restricted Project

Jun 26 2019

tlively committed rG7663e0cd7dbb: [WebAssembly] Omit wrap on i64x2.{shl,shr*} ISel when possible (authored by tlively).
[WebAssembly] Omit wrap on i64x2.{shl,shr*} ISel when possible
Jun 26 2019, 9:23 AM
tlively committed rL364446: [WebAssembly] Omit wrap on i64x2.{shl,shr*} ISel when possible.
[WebAssembly] Omit wrap on i64x2.{shl,shr*} ISel when possible
Jun 26 2019, 9:20 AM
tlively closed D63615: [WebAssembly] Omit wrap on i64x2.{shl,shr*} ISel when possible.
Jun 26 2019, 9:20 AM · Restricted Project
tlively committed rGa1d97a960e62: [WebAssembly] Implement tail calls and unify tablegen call classes (authored by tlively).
[WebAssembly] Implement tail calls and unify tablegen call classes
Jun 26 2019, 9:19 AM
tlively committed rL364445: [WebAssembly] Implement tail calls and unify tablegen call classes.
[WebAssembly] Implement tail calls and unify tablegen call classes
Jun 26 2019, 9:19 AM
tlively closed D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Jun 26 2019, 9:19 AM · Restricted Project

Jun 20 2019

tlively abandoned D63575: [WebAssembly] Add builtin functions for creating vector constants.
Jun 20 2019, 11:15 AM · Restricted Project
tlively created D63615: [WebAssembly] Omit wrap on i64x2.{shl,shr*} ISel when possible.
Jun 20 2019, 10:19 AM · Restricted Project

Jun 19 2019

tlively added a comment to D63575: [WebAssembly] Add builtin functions for creating vector constants.

This CL does not provide a mechanism for enforcing that the lanes of a floating point vector are constant, and it doesn't look like clang supports that kind of check. That makes this CL a half-baked solution, so I'm not sure we should actually go in this direction.

Jun 19 2019, 4:18 PM · Restricted Project
tlively created D63575: [WebAssembly] Add builtin functions for creating vector constants.
Jun 19 2019, 2:44 PM · Restricted Project

Jun 18 2019

tlively committed rG1885747498c2: [WebAssembly] Optimize ISel for SIMD Boolean reductions (authored by tlively).
[WebAssembly] Optimize ISel for SIMD Boolean reductions
Jun 18 2019, 5:00 PM
tlively committed rL363756: [WebAssembly] Optimize ISel for SIMD Boolean reductions.
[WebAssembly] Optimize ISel for SIMD Boolean reductions
Jun 18 2019, 5:00 PM
tlively closed D63529: [WebAssembly] Optimize ISel for SIMD Boolean reductions.
Jun 18 2019, 5:00 PM · Restricted Project
tlively created D63529: [WebAssembly] Optimize ISel for SIMD Boolean reductions.
Jun 18 2019, 4:32 PM · Restricted Project
tlively accepted D63509: DAG: Use getStoreSize when expanding dynamic vector indexing.

That was simple! Thank you!

Jun 18 2019, 12:46 PM

Jun 12 2019

tlively updated the diff for D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
  • Address comments
Jun 12 2019, 1:26 AM · Restricted Project

Jun 9 2019

tlively added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Jun 9 2019, 1:11 PM · Restricted Project

Jun 7 2019

tlively updated the diff for D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
  • Restore previous logic, add tests for strange ABIs and prototype mismatches
Jun 7 2019, 5:39 PM · Restricted Project
tlively added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Jun 7 2019, 12:26 PM · Restricted Project
tlively added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Jun 7 2019, 10:18 AM · Restricted Project

Jun 6 2019

tlively added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Jun 6 2019, 6:08 PM · Restricted Project
tlively updated the diff for D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
  • Add TODO in FastISel, add isReturn attribute, integrate into existing logic flow
Jun 6 2019, 6:06 PM · Restricted Project

Jun 5 2019

tlively committed rG5e7ca755d8c7: [WebAssembly] Support Leak Sanitizer on Emscripten (authored by tlively).
[WebAssembly] Support Leak Sanitizer on Emscripten
Jun 5 2019, 6:37 PM
tlively committed rL362667: [WebAssembly] Support Leak Sanitizer on Emscripten.
[WebAssembly] Support Leak Sanitizer on Emscripten
Jun 5 2019, 6:37 PM
tlively closed D62830: [WebAssembly] Support Leak Sanitizer on Emscripten.
Jun 5 2019, 6:37 PM · Restricted Project, Restricted Project
tlively added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Jun 5 2019, 1:28 PM · Restricted Project
tlively updated the diff for D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
  • Fix formatting and error message, add documentation and notail tests
Jun 5 2019, 1:28 PM · Restricted Project

Jun 4 2019

tlively committed rGb98025a2f75d: [WebAssembly] make wasm-ld --verbose show data section startVA and name (authored by tlively).
[WebAssembly] make wasm-ld --verbose show data section startVA and name
Jun 4 2019, 2:13 PM