Page MenuHomePhabricator
Feed Advanced Search

Yesterday

tlively added a comment to D85494: [WebAssembly] Allow inlining functions with different features.

@alexcrichton As someone who works on an LLVM frontend, do you think the possibility that a feature can be "forgotten" would be worth introducing a restriction that functions can only be inlined into other functions that have a superset of their features?

Thu, Aug 6, 8:27 PM · Restricted Project
tlively requested review of D85494: [WebAssembly] Allow inlining functions with different features.
Thu, Aug 6, 8:24 PM · Restricted Project

Wed, Aug 5

tlively requested review of D85392: [WebAssembly][ConstantFolding] Fold fp-to-int truncation intrinsics.
Wed, Aug 5, 8:09 PM · Restricted Project
tlively committed rGf496950001c4: [WebAssembly] Fix types in wasm_simd128.h and add tests (authored by tlively).
[WebAssembly] Fix types in wasm_simd128.h and add tests
Wed, Aug 5, 2:00 PM
tlively closed D85347: [WebAssembly] Fix types in wasm_simd128.h and add tests.
Wed, Aug 5, 2:00 PM · Restricted Project
tlively added inline comments to D85347: [WebAssembly] Fix types in wasm_simd128.h and add tests.
Wed, Aug 5, 1:37 PM · Restricted Project
tlively updated the diff for D85347: [WebAssembly] Fix types in wasm_simd128.h and add tests.
  • Fix and test macros as well
Wed, Aug 5, 1:31 PM · Restricted Project
tlively updated the diff for D85347: [WebAssembly] Fix types in wasm_simd128.h and add tests.
  • Fix
Wed, Aug 5, 12:38 PM · Restricted Project
tlively added reviewers for D85347: [WebAssembly] Fix types in wasm_simd128.h and add tests: aheejin, sunfish.
Wed, Aug 5, 12:35 PM · Restricted Project
tlively requested review of D85347: [WebAssembly] Fix types in wasm_simd128.h and add tests.
Wed, Aug 5, 12:34 PM · Restricted Project

Mon, Aug 3

tlively committed rGcb327922101b: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions (authored by tlively).
[WebAssembly] Implement prototype v128.load{32,64}_zero instructions
Mon, Aug 3, 1:54 PM
tlively closed D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions.
Mon, Aug 3, 1:54 PM · Restricted Project, Restricted Project
tlively updated the diff for D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions.
  • Renumber i32x4.dot_i16x8_s to match V8 as well
Mon, Aug 3, 10:50 AM · Restricted Project, Restricted Project

Sun, Aug 2

tlively accepted D85074: [WebAssembly] Use "signed char" instead of "char" in SIMD intrinsics..

Nice! Thanks for doing that :)

Sun, Aug 2, 10:54 AM · Restricted Project

Fri, Jul 31

tlively added a comment to D66035: [WebAssembly] WIP: Add support for reference types.

It would be good to split this into (at least) two patches. The first should do the minimal testable amount of work to get instruction selection working, and follow-on patches can add the other parts, like additions to the object file format. Part of the reason for that split is that different people will be better at reviewing those different parts of the patch.

Fri, Jul 31, 7:15 PM · Restricted Project, Restricted Project
tlively added a comment to D66035: [WebAssembly] WIP: Add support for reference types.

I will be splitting the part enabling the target feature through clang into a separate revision as suggested by @tlively

I just noticed that most of this work landed in an earlier commit

Fri, Jul 31, 10:07 AM · Restricted Project, Restricted Project

Thu, Jul 30

tlively added inline comments to D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions.
Thu, Jul 30, 5:42 PM · Restricted Project, Restricted Project
tlively updated the diff for D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions.
  • Remove IntrSpeculatable
Thu, Jul 30, 12:40 PM · Restricted Project, Restricted Project

Wed, Jul 29

tlively added a comment to D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions.

Since this changes opcodes, it needs to be landed in concert with the corresponding Binaryen change.

Wed, Jul 29, 3:00 PM · Restricted Project, Restricted Project

Tue, Jul 28

tlively requested review of D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions.
Tue, Jul 28, 8:27 PM · Restricted Project, Restricted Project
tlively added inline comments to D84556: [WebAssembly] Remove intrinsics for SIMD widening ops.
Tue, Jul 28, 7:59 PM · Restricted Project, Restricted Project
tlively committed rG11bb7eef4152: [WebAssembly] Remove intrinsics for SIMD widening ops (authored by tlively).
[WebAssembly] Remove intrinsics for SIMD widening ops
Tue, Jul 28, 6:26 PM
tlively closed D84556: [WebAssembly] Remove intrinsics for SIMD widening ops.
Tue, Jul 28, 6:26 PM · Restricted Project, Restricted Project
tlively added inline comments to D84556: [WebAssembly] Remove intrinsics for SIMD widening ops.
Tue, Jul 28, 6:18 PM · Restricted Project, Restricted Project
tlively committed rGffd8c23ccb74: [WebAssembly] Implement truncating vector stores (authored by tlively).
[WebAssembly] Implement truncating vector stores
Tue, Jul 28, 5:47 PM
tlively closed D84377: [WebAssembly] Implement truncating vector stores.
Tue, Jul 28, 5:46 PM · Restricted Project
tlively added a comment to D66035: [WebAssembly] WIP: Add support for reference types.

Please ignore my .gitlab-ci.yml. That's just an internal change that I got uploaded by mistake.
I am looking to see this through and start discussion on this with the goal of landing it.

Tue, Jul 28, 11:44 AM · Restricted Project, Restricted Project

Mon, Jul 27

tlively accepted D84705: [WebAssembly] Fixed 64-bit indices in br_table.

LGTM!

Mon, Jul 27, 5:03 PM · Restricted Project

Fri, Jul 24

Herald added projects to D84556: [WebAssembly] Remove intrinsics for SIMD widening ops: Restricted Project, Restricted Project.
Fri, Jul 24, 1:54 PM · Restricted Project, Restricted Project

Thu, Jul 23

tlively updated the summary of D84377: [WebAssembly] Implement truncating vector stores.
Thu, Jul 23, 9:13 PM · Restricted Project
tlively committed rGa459459248db: [WebAssembly] Fix store_unfolded_offset tests in simd-offset.ll (authored by tlively).
[WebAssembly] Fix store_unfolded_offset tests in simd-offset.ll
Thu, Jul 23, 4:05 PM
tlively closed D84365: [WebAssembly] Fix store_unfolded_offset tests in simd-offset.ll.
Thu, Jul 23, 4:05 PM · Restricted Project
tlively updated the diff for D84377: [WebAssembly] Implement truncating vector stores.
  • Improve codegen: use faster i32x4.splats and reuse the existing vector as the second narrowing argument
Thu, Jul 23, 3:52 PM · Restricted Project
tlively added a comment to D84365: [WebAssembly] Fix store_unfolded_offset tests in simd-offset.ll.

They seem to have been written that way because negative offsets aren't folded? What does it mean that they are duplicates of other patterns?

Thu, Jul 23, 2:04 PM · Restricted Project

Wed, Jul 22

Herald added a project to D84377: [WebAssembly] Implement truncating vector stores: Restricted Project.
Wed, Jul 22, 6:20 PM · Restricted Project
Herald added a project to D84365: [WebAssembly] Fix store_unfolded_offset tests in simd-offset.ll: Restricted Project.
Wed, Jul 22, 3:29 PM · Restricted Project
tlively committed rG51cd326f99bb: [WebAssembly] Autogenerate checks in simd-offset.ll (authored by tlively).
[WebAssembly] Autogenerate checks in simd-offset.ll
Wed, Jul 22, 10:13 AM
tlively closed D84288: [WebAssembly] Autogenerate checks in simd-offset.ll.
Wed, Jul 22, 10:12 AM · Restricted Project

Tue, Jul 21

Herald added a project to D84288: [WebAssembly] Autogenerate checks in simd-offset.ll: Restricted Project.
Tue, Jul 21, 6:25 PM · Restricted Project
tlively planned changes to D83615: [WebAssembly] Custom combine splat build_vectors into swizzles.
Tue, Jul 21, 2:11 PM · Restricted Project
tlively planned changes to D83606: [DAGCombiner][WebAssembly] Combine shuffles of more splat vals.
Tue, Jul 21, 2:10 PM · Restricted Project
tlively planned changes to D83605: [SelectionDAG][WebAssembly] Recognize splat value ABS operations.
Tue, Jul 21, 2:10 PM · Restricted Project
tlively planned changes to D83602: [DAGCombiner] Scalarize splats with just one demanded lane.

I'm taking this patch sequence out of the review queue for now, pending an investigation of the alternatives suggested above.

Tue, Jul 21, 2:10 PM · Restricted Project

Thu, Jul 16

tlively added a comment to D83602: [DAGCombiner] Scalarize splats with just one demanded lane.

Thank you all for the comments! I agree that the opcodes in SelectionDAG::isSplatValue are rather arbitrary, so a more principled approach using a TLI hook might be better. I will take a look at what X86 is doing to see if a simpler solution would work for WebAssembly, too.

Thu, Jul 16, 1:00 PM · Restricted Project
tlively committed rGecb2e5bcd7e6: [WebAssembly] Implement v128.select (authored by tlively).
[WebAssembly] Implement v128.select
Thu, Jul 16, 11:37 AM
tlively closed D83737: [WebAssembly] Implement v128.select.
Thu, Jul 16, 11:37 AM · Restricted Project
tlively committed rGf7868f87accb: [WebAssembly] Autogenerate tests for simd-select.ll (authored by tlively).
[WebAssembly] Autogenerate tests for simd-select.ll
Thu, Jul 16, 11:19 AM
tlively closed D83736: [WebAssembly] Autogenerate tests for simd-select.ll.
Thu, Jul 16, 11:19 AM · Restricted Project
tlively committed rGf0f97876469e: [WebAssembly] Lower vselect to v128.bitselect (authored by tlively).
[WebAssembly] Lower vselect to v128.bitselect
Thu, Jul 16, 11:11 AM
tlively closed D83734: [WebAssembly] Lower vselect to v128.bitselect.
Thu, Jul 16, 11:11 AM · Restricted Project
tlively retitled D83736: [WebAssembly] Autogenerate tests for simd-select.ll from [WebAssembly][NFC] Autogenerate tests for simd-select.ll to [WebAssembly] Autogenerate tests for simd-select.ll.
Thu, Jul 16, 11:02 AM · Restricted Project
tlively added a comment to D83736: [WebAssembly] Autogenerate tests for simd-select.ll.

LGTM.
Nit: NFC usually means code change that does not affect output, so adding tests or changing tests is not NFC by that definition :)

Thu, Jul 16, 11:02 AM · Restricted Project
tlively added inline comments to D83734: [WebAssembly] Lower vselect to v128.bitselect.
Thu, Jul 16, 11:00 AM · Restricted Project

Mon, Jul 13

Herald added a project to D83737: [WebAssembly] Implement v128.select: Restricted Project.
Mon, Jul 13, 7:52 PM · Restricted Project
Herald added a project to D83736: [WebAssembly] Autogenerate tests for simd-select.ll: Restricted Project.
Mon, Jul 13, 7:40 PM · Restricted Project
Herald added a project to D83734: [WebAssembly] Lower vselect to v128.bitselect: Restricted Project.
Mon, Jul 13, 6:43 PM · Restricted Project
tlively added inline comments to D83729: [WebAssembly] 64-bit (function) pointer fixes..
Mon, Jul 13, 5:45 PM · Restricted Project
tlively added a comment to D83729: [WebAssembly] 64-bit (function) pointer fixes..

The part with the wrap lgtm!

Mon, Jul 13, 5:15 PM · Restricted Project

Sun, Jul 12

tlively updated the diff for D83605: [SelectionDAG][WebAssembly] Recognize splat value ABS operations.
  • Remove superfluous parentheses
Sun, Jul 12, 11:12 AM · Restricted Project

Sat, Jul 11

tlively added a comment to D83602: [DAGCombiner] Scalarize splats with just one demanded lane.

Is this supposed to fix some lowering-produced code?
If not, shouldn't this be best done in the middle-end?

Sat, Jul 11, 10:11 PM · Restricted Project

Fri, Jul 10

Herald added a project to D83615: [WebAssembly] Custom combine splat build_vectors into swizzles: Restricted Project.
Fri, Jul 10, 7:49 PM · Restricted Project
tlively updated the diff for D83606: [DAGCombiner][WebAssembly] Combine shuffles of more splat vals.
  • Update another x86 test
Fri, Jul 10, 7:31 PM · Restricted Project
tlively updated the diff for D83606: [DAGCombiner][WebAssembly] Combine shuffles of more splat vals.
  • Remove TODO
Fri, Jul 10, 7:13 PM · Restricted Project
Herald added a project to D83606: [DAGCombiner][WebAssembly] Combine shuffles of more splat vals: Restricted Project.
Fri, Jul 10, 7:10 PM · Restricted Project
Herald added a project to D83605: [SelectionDAG][WebAssembly] Recognize splat value ABS operations: Restricted Project.
Fri, Jul 10, 6:46 PM · Restricted Project
tlively committed rGb59c6fcaf3fc: [WebAssembly] Prefer v128.const for constant splats (authored by tlively).
[WebAssembly] Prefer v128.const for constant splats
Fri, Jul 10, 6:28 PM
tlively closed D83581: [WebAssembly] Prefer v128.const for constant splats.
Fri, Jul 10, 6:28 PM · Restricted Project
Herald added a project to D83602: [DAGCombiner] Scalarize splats with just one demanded lane: Restricted Project.
Fri, Jul 10, 6:16 PM · Restricted Project
Herald added a project to D83581: [WebAssembly] Prefer v128.const for constant splats: Restricted Project.
Fri, Jul 10, 12:12 PM · Restricted Project
tlively planned changes to D83537: [WebAssembly] Use ISD::SPLAT_VECTOR for splats.

This whole patch got a whole lot more complex than I thought it would be at first, so I'm going to split out some of the separately-useful parts and experiment with other ways of getting rid of the undef lanes in splat build_vectors.

Fri, Jul 10, 12:38 AM · Restricted Project
Herald added a project to D83537: [WebAssembly] Use ISD::SPLAT_VECTOR for splats: Restricted Project.
Fri, Jul 10, 12:27 AM · Restricted Project
tlively committed rG043eaa9a4a08: [WebAssembly][NFC] Simplify vector shift lowering and add tests (authored by tlively).
[WebAssembly][NFC] Simplify vector shift lowering and add tests
Fri, Jul 10, 12:19 AM
tlively closed D83493: [WebAssembly][NFC] Simplify vector shift lowering and add tests.
Fri, Jul 10, 12:19 AM · Restricted Project

Thu, Jul 9

tlively updated the summary of D83493: [WebAssembly][NFC] Simplify vector shift lowering and add tests.
Thu, Jul 9, 3:28 PM · Restricted Project
Herald added a project to D83493: [WebAssembly][NFC] Simplify vector shift lowering and add tests: Restricted Project.
Thu, Jul 9, 10:16 AM · Restricted Project

Jul 7 2020

tlively committed rG0d7286a65237: [WebAssembly] Avoid scalarizing vector shifts in more cases (authored by tlively).
[WebAssembly] Avoid scalarizing vector shifts in more cases
Jul 7 2020, 10:45 AM
tlively closed D83278: [WebAssembly] Avoid scalarizing vector shifts in more cases.
Jul 7 2020, 10:45 AM · Restricted Project

Jul 6 2020

tlively accepted D83277: [WebAssembly] Generate unreachable after __stack_chk_fail.

LGTM!

Jul 6 2020, 11:35 PM · Restricted Project
Herald added a project to D83278: [WebAssembly] Avoid scalarizing vector shifts in more cases: Restricted Project.
Jul 6 2020, 10:44 PM · Restricted Project
tlively accepted D82821: [WebAssembly] Added 64-bit memory.grow/size/init/copy/fill.

LGTM, thanks!

Jul 6 2020, 12:23 PM · Restricted Project, Restricted Project

Jul 5 2020

tlively added a comment to D83082: [Alignment][NFC] Use proper getter to retrieve alignment from ConstantInt and ConstantSDNode.

I filed a bug for this issue at https://bugs.llvm.org/show_bug.cgi?id=46594 (although I probably wouldn't have bothered if I had refreshed the page and seen @sbc100's comments first. Oops!)

Jul 5 2020, 10:40 PM · Restricted Project

Jul 4 2020

tlively committed rG65330f394b2c: [WebAssembly] Do not assume br_table range checks will be gt_u (authored by tlively).
[WebAssembly] Do not assume br_table range checks will be gt_u
Jul 4 2020, 6:23 PM
tlively closed D83169: [WebAssembly] Do not assume br_table range checks will be gt_u.
Jul 4 2020, 6:23 PM · Restricted Project
tlively created D83169: [WebAssembly] Do not assume br_table range checks will be gt_u.
Jul 4 2020, 6:23 PM · Restricted Project
tlively added a comment to D83169: [WebAssembly] Do not assume br_table range checks will be gt_u.

Landing TBR to unbreak stuff faster.

Jul 4 2020, 6:23 PM · Restricted Project

Jul 3 2020

tlively added inline comments to D82821: [WebAssembly] Added 64-bit memory.grow/size/init/copy/fill.
Jul 3 2020, 5:46 PM · Restricted Project, Restricted Project
tlively committed rG8df30d988e9e: [WebAssembly] Do not omit range checks for i64 switches (authored by tlively).
[WebAssembly] Do not omit range checks for i64 switches
Jul 3 2020, 5:23 PM
tlively closed D83017: [WebAssembly] Do not omit range checks for i64 switches.
Jul 3 2020, 5:23 PM · Restricted Project
tlively updated the summary of D83017: [WebAssembly] Do not omit range checks for i64 switches.
Jul 3 2020, 4:11 PM · Restricted Project
tlively added a comment to D83017: [WebAssembly] Do not omit range checks for i64 switches.

Good point, that was a problem. I changed the implementation to examine the range check rather than the table index and added a test for this case.

Jul 3 2020, 4:11 PM · Restricted Project
tlively updated the diff for D83017: [WebAssembly] Do not omit range checks for i64 switches.
  • Check the range check condition rather than the index source
Jul 3 2020, 4:11 PM · Restricted Project

Jul 1 2020

tlively updated the summary of D83017: [WebAssembly] Do not omit range checks for i64 switches.
Jul 1 2020, 6:23 PM · Restricted Project
tlively created D83017: [WebAssembly] Do not omit range checks for i64 switches.
Jul 1 2020, 6:23 PM · Restricted Project

Jun 29 2020

tlively added inline comments to D82821: [WebAssembly] Added 64-bit memory.grow/size/init/copy/fill.
Jun 29 2020, 10:00 PM · Restricted Project, Restricted Project
tlively added inline comments to D82821: [WebAssembly] Added 64-bit memory.grow/size/init/copy/fill.
Jun 29 2020, 5:48 PM · Restricted Project, Restricted Project

Jun 23 2020

tlively added a comment to D79530: [lld][WebAssembly] Allow `atomics` feature with unshared memory.

Actually, a better commit to track is https://chromiumdash.appspot.com/commit/e1a9c1e807d3d44e03dc77c69cc2a0303f1d9f38.

Jun 23 2020, 10:43 AM · Restricted Project

Jun 22 2020

tlively added a comment to D79530: [lld][WebAssembly] Allow `atomics` feature with unshared memory.

The corresponding semantics change in Chrome can be tracked at https://chromiumdash.appspot.com/commit/895c52ddcb783fed5637cb1e6e31b6fd730872da.

Jun 22 2020, 12:21 PM · Restricted Project

Jun 19 2020

tlively accepted D82217: [SVE] Remove calls to VectorType::getNumElements from WebASM.

+1 to what Derek said :)

Jun 19 2020, 11:15 PM · Restricted Project

Jun 18 2020

tlively accepted D82097: WebAssembly: Don't store MachineFunction in MachineFunctionInfo.

Thanks, @arsenm, looks fine to me. Do you have more context on why this change is necessary, though?

Jun 18 2020, 9:45 AM · Restricted Project

Jun 17 2020

tlively added inline comments to D81909: [WebAssembly] Fix bug in FixBrTables and use branch analysis utils.
Jun 17 2020, 2:34 PM · Restricted Project