Page MenuHomePhabricator
Feed Advanced Search

Yesterday

kastiglione accepted D131996: Use a SmallPtrSet rather than a SmallVector in ClusterManager..

+1

Tue, Aug 16, 3:35 PM · Restricted Project, Restricted Project

Mon, Aug 15

kastiglione updated the summary of D117383: [lldb] Expose std::pair children for unordered_map.
Mon, Aug 15, 10:16 AM · Restricted Project, Restricted Project
kastiglione added a reviewer for D117383: [lldb] Expose std::pair children for unordered_map: Michael137.
Mon, Aug 15, 10:07 AM · Restricted Project, Restricted Project

Fri, Aug 12

kastiglione updated the diff for D117383: [lldb] Expose std::pair children for unordered_map.

fix comment grammar

Fri, Aug 12, 8:30 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D117383: [lldb] Expose std::pair children for unordered_map.

Handle GetTypeName() returning strings both with and without std:: namespace

Fri, Aug 12, 8:29 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D117383: [lldb] Expose std::pair children for unordered_map.

Ignore the internal field name and use type names for conditions

Fri, Aug 12, 8:10 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D117383: [lldb] Expose std::pair children for unordered_map.

Use backend's type name to differentiate between unordered_{map,set}

Fri, Aug 12, 7:59 PM · Restricted Project, Restricted Project
kastiglione accepted D131761: [LLDB] Remove __future__ imports from tests.

👍

Fri, Aug 12, 7:22 AM · Restricted Project, Restricted Project
kastiglione accepted D131772: [LLDB] Remove __future__ imports from examples.

thanks I had the same thought

Fri, Aug 12, 7:21 AM · Restricted Project, Restricted Project

Thu, Aug 11

kastiglione committed rG95367da43ddd: [lldb] Remove unused "import unittest2" statements (authored by kastiglione).
[lldb] Remove unused "import unittest2" statements
Thu, Aug 11, 7:11 PM · Restricted Project
kastiglione committed rG56f9cfe30c44: [lldb] Remove uses of six module (NFC) (authored by kastiglione).
[lldb] Remove uses of six module (NFC)
Thu, Aug 11, 7:07 PM · Restricted Project
kastiglione closed D131304: [lldb] Remove uses of six module (NFC).
Thu, Aug 11, 7:06 PM · Restricted Project, Restricted Project
kastiglione accepted D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format.

one typo to fix, but otherwise looks good

Thu, Aug 11, 4:35 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format.
Thu, Aug 11, 4:19 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D131304: [lldb] Remove uses of six module (NFC).

Restore LLDB_USE_SYSTEM_SIX

Thu, Aug 11, 3:31 PM · Restricted Project, Restricted Project
kastiglione committed rG28d0c0c2c8e8: [lldb] Tidy some regex in crashlog.py (NFC) (authored by kastiglione).
[lldb] Tidy some regex in crashlog.py (NFC)
Thu, Aug 11, 3:25 PM · Restricted Project
kastiglione closed D131305: [lldb] Tidy some regex in crashlog.py (NFC).
Thu, Aug 11, 3:25 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format.
Thu, Aug 11, 3:22 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format.
Thu, Aug 11, 3:17 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D131305: [lldb] Tidy some regex in crashlog.py (NFC).

Fix one crashlog test

Thu, Aug 11, 2:19 PM · Restricted Project, Restricted Project
mib awarded D131305: [lldb] Tidy some regex in crashlog.py (NFC) a Yellow Medal token.
Thu, Aug 11, 11:15 AM · Restricted Project, Restricted Project

Tue, Aug 9

kastiglione added a comment to D131539: [lldb] Make sure all Python API tests are marked as NO_DEBUG_INFO_TESTCASE.

this diff has made me wonder: should we have a NoDebugInfoTestCase that can be used by any test, and would replace assigning to NO_DEBUG_INFO_TESTCASE?

Tue, Aug 9, 8:56 PM · Restricted Project
kastiglione accepted D131085: [lldb/crashlog] Refactor the CrashLogParser logic.

thanks for having patience with us reviewers, lgtm with one comment about python versions

Tue, Aug 9, 3:57 PM · Restricted Project, Restricted Project
kastiglione added a comment to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.

was the chmod intentional?

Tue, Aug 9, 11:35 AM · Restricted Project, Restricted Project
kastiglione added inline comments to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.
Tue, Aug 9, 11:32 AM · Restricted Project, Restricted Project
kastiglione added inline comments to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.
Tue, Aug 9, 11:21 AM · Restricted Project, Restricted Project
kastiglione added inline comments to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.
Tue, Aug 9, 8:36 AM · Restricted Project, Restricted Project

Mon, Aug 8

kastiglione added inline comments to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.
Mon, Aug 8, 3:16 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.
Mon, Aug 8, 3:12 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D131304: [lldb] Remove uses of six module (NFC).
Mon, Aug 8, 9:34 AM · Restricted Project, Restricted Project
kastiglione updated the diff for D131304: [lldb] Remove uses of six module (NFC).

remove LLDB_USE_SYSTEM_SIX

Mon, Aug 8, 9:31 AM · Restricted Project, Restricted Project

Sun, Aug 7

kastiglione updated the diff for D131304: [lldb] Remove uses of six module (NFC).

Missed a restore of str variable name

Sun, Aug 7, 1:32 PM · Restricted Project, Restricted Project
kastiglione committed rGc615e467dbaf: [lldb] Hoist TraceOn check out of loop (NFC) (authored by kastiglione).
[lldb] Hoist TraceOn check out of loop (NFC)
Sun, Aug 7, 11:20 AM · Restricted Project
kastiglione committed rG87990fd8f4ba: [lldb] Fix formatting in python-reference.rst (authored by kastiglione).
[lldb] Fix formatting in python-reference.rst
Sun, Aug 7, 11:18 AM · Restricted Project
kastiglione committed rGe49c1568b616: [lldb] Dynamically generate enum names in lldbutil (authored by kastiglione).
[lldb] Dynamically generate enum names in lldbutil
Sun, Aug 7, 11:16 AM · Restricted Project
kastiglione closed D131138: [lldb] Dynamically generate enum names in lldbutil.
Sun, Aug 7, 11:16 AM · Restricted Project, Restricted Project

Fri, Aug 5

kastiglione added a comment to D131305: [lldb] Tidy some regex in crashlog.py (NFC).

this includes changes in D131032 and so depends on it merging first.

Fri, Aug 5, 4:37 PM · Restricted Project, Restricted Project
kastiglione requested review of D131305: [lldb] Tidy some regex in crashlog.py (NFC).
Fri, Aug 5, 4:26 PM · Restricted Project, Restricted Project
kastiglione added a comment to D131304: [lldb] Remove uses of six module (NFC).

@mib the tests pass on my machine.

Fri, Aug 5, 4:13 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D131304: [lldb] Remove uses of six module (NFC).

Restore some "str" variable names

Fri, Aug 5, 4:12 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D131304: [lldb] Remove uses of six module (NFC).
Fri, Aug 5, 4:06 PM · Restricted Project, Restricted Project
kastiglione added a comment to D131304: [lldb] Remove uses of six module (NFC).

I left third_party/Python/module/six, in case there are any lldb scripts that depend on the existence of six.

Fri, Aug 5, 3:49 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D131304: [lldb] Remove uses of six module (NFC).
Fri, Aug 5, 3:46 PM · Restricted Project, Restricted Project
kastiglione requested review of D131304: [lldb] Remove uses of six module (NFC).
Fri, Aug 5, 3:39 PM · Restricted Project, Restricted Project
kastiglione requested review of D131138: [lldb] Dynamically generate enum names in lldbutil.

@JDevlieghere @mib what do you think of introducing type annotations as code is being touched?

Fri, Aug 5, 3:34 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D131138: [lldb] Dynamically generate enum names in lldbutil.

Fix bug; Add type annotations

Fri, Aug 5, 3:32 PM · Restricted Project, Restricted Project
kastiglione added a comment to D131138: [lldb] Dynamically generate enum names in lldbutil.

I wonder how much breakage there would be if you implemented a bunch of the dunder methods. Ex:

Fri, Aug 5, 12:56 PM · Restricted Project, Restricted Project
kastiglione added a comment to D131138: [lldb] Dynamically generate enum names in lldbutil.

@mib I like that idea.

Fri, Aug 5, 9:31 AM · Restricted Project, Restricted Project

Wed, Aug 3

kastiglione added inline comments to D131083: [lldb] Add assertStopReason helper function.
Wed, Aug 3, 8:55 PM · Restricted Project, Restricted Project
kastiglione requested review of D131138: [lldb] Dynamically generate enum names in lldbutil.
Wed, Aug 3, 8:54 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D131033: [lldb/crashlog] Remove 'process_path' parsing logic.
Wed, Aug 3, 2:51 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.
Wed, Aug 3, 11:20 AM · Restricted Project, Restricted Project
kastiglione accepted D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument.

lgtm

Wed, Aug 3, 10:10 AM · Restricted Project, Restricted Project
kastiglione added inline comments to D131032: [lldb/crashlog] Update frame regex matcher.
Wed, Aug 3, 9:43 AM · Restricted Project, Restricted Project

Jul 16 2022

kastiglione added a comment to rG52232abc2304: [Support] Remove redundant declaration setCurrentDebugTypes (NFC).

If NDEBUG is defined, then the declaration doesn't exist as it is gated by #ifndef NDEBUG.

Jul 16 2022, 5:15 PM · Restricted Project, Restricted Project

Jul 13 2022

kastiglione committed rGb5ccfeb6bfbb: [lldb] Add image dump pcm-info command (authored by kastiglione).
[lldb] Add image dump pcm-info command
Jul 13 2022, 4:57 PM · Restricted Project, Restricted Project
kastiglione closed D129456: [lldb] Add image dump pcm-info command.
Jul 13 2022, 4:57 PM · Restricted Project, Restricted Project, Restricted Project
kastiglione added inline comments to D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument.
Jul 13 2022, 10:29 AM · Restricted Project, Restricted Project

Jul 12 2022

kastiglione updated the diff for D129456: [lldb] Add image dump pcm-info command.

simplify error handling by checking for .pcm extension

Jul 12 2022, 1:10 PM · Restricted Project, Restricted Project, Restricted Project

Jul 11 2022

kastiglione updated the diff for D129456: [lldb] Add image dump pcm-info command.

added error handling

Jul 11 2022, 9:47 PM · Restricted Project, Restricted Project, Restricted Project
kastiglione added a comment to D129456: [lldb] Add image dump pcm-info command.

@JDevlieghere I had it as dump pcm at first, but switched it to pcm-info for two reasons

Jul 11 2022, 2:52 PM · Restricted Project, Restricted Project, Restricted Project
kastiglione added a reviewer for D129456: [lldb] Add image dump pcm-info command: Michael137.
Jul 11 2022, 10:41 AM · Restricted Project, Restricted Project, Restricted Project

Jul 10 2022

kastiglione committed rG4655400b2113: [lldb] Delete more mydir references (NFC) (authored by kastiglione).
[lldb] Delete more mydir references (NFC)
Jul 10 2022, 6:56 PM · Restricted Project
kastiglione retitled D129456: [lldb] Add image dump pcm-info command from [lldb] Add image dump pcm command to [lldb] Add image dump pcm-info command.
Jul 10 2022, 4:06 PM · Restricted Project, Restricted Project, Restricted Project
kastiglione updated the diff for D129456: [lldb] Add image dump pcm-info command.

remove commented-out code in test

Jul 10 2022, 4:02 PM · Restricted Project, Restricted Project, Restricted Project
kastiglione updated the diff for D129456: [lldb] Add image dump pcm-info command.

add @skipUnlessDarwin

Jul 10 2022, 4:00 PM · Restricted Project, Restricted Project, Restricted Project
kastiglione requested review of D129456: [lldb] Add image dump pcm-info command.
Jul 10 2022, 3:58 PM · Restricted Project, Restricted Project, Restricted Project

Jun 21 2022

kastiglione accepted D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.

thanks Jim

Jun 21 2022, 4:30 PM · Restricted Project, Restricted Project

Jun 17 2022

kastiglione committed rG4cc8f2a017c7: [lldb][tests] Automatically call compute_mydir (NFC) (authored by kastiglione).
[lldb][tests] Automatically call compute_mydir (NFC)
Jun 17 2022, 2:35 PM · Restricted Project
kastiglione closed D128077: [lldb][tests] Automatically call compute_mydir (NFC).
Jun 17 2022, 2:35 PM · Restricted Project, Restricted Project
kastiglione requested review of D128077: [lldb][tests] Automatically call compute_mydir (NFC).
Jun 17 2022, 11:12 AM · Restricted Project, Restricted Project

Jun 16 2022

kastiglione accepted D127937: [lldb] Add RotatingLogHandler.

lgtm

Jun 16 2022, 2:26 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D127937: [lldb] Add RotatingLogHandler.
Jun 16 2022, 11:08 AM · Restricted Project, Restricted Project

Jun 15 2022

kastiglione committed rGe9349ef9e6d8: Fix `script -lpython` to handle control flow in one-line commands. (authored by kastiglione).
Fix `script -lpython` to handle control flow in one-line commands.
Jun 15 2022, 10:23 PM · Restricted Project
kastiglione closed D127586: [lldb][Interpreter] Add newline terminal to one-line script calls.
Jun 15 2022, 10:23 PM · Restricted Project, Restricted Project
kastiglione committed rGe30c493894c4: [lldb] Support non-pointer implicit this/self in… (authored by kastiglione).
[lldb] Support non-pointer implicit this/self in…
Jun 15 2022, 10:05 PM · Restricted Project
kastiglione closed D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.
Jun 15 2022, 10:05 PM · Restricted Project, Restricted Project
kastiglione accepted D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter.

Before this, I didn't realize that quit/exit worked without being a function call. I think it's unfortunate we have to preserve that, but oh well.

Jun 15 2022, 2:40 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter.
Jun 15 2022, 1:25 PM · Restricted Project, Restricted Project

Jun 13 2022

kastiglione added a comment to D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.

This is good, but it also illustrates how the strings "->" and ".'" should actually come from the typesystem and not be hardcoded. We're just lucky that all languages have a "." operator.

More elegant would be to just add an API to TypeSystem to get the operator to access ivars.

Jun 13 2022, 4:52 PM · Restricted Project, Restricted Project

Jun 12 2022

kastiglione updated the diff for D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.

check valid compiler type

Jun 12 2022, 4:39 PM · Restricted Project, Restricted Project
kastiglione updated the summary of D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.
Jun 12 2022, 12:14 PM · Restricted Project, Restricted Project
kastiglione updated the summary of D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.
Jun 12 2022, 12:12 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.

use explicit type instead of auto

Jun 12 2022, 12:10 PM · Restricted Project, Restricted Project
kastiglione requested review of D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.
Jun 12 2022, 12:08 PM · Restricted Project, Restricted Project

Jun 11 2022

kastiglione updated the summary of D127586: [lldb][Interpreter] Add newline terminal to one-line script calls.
Jun 11 2022, 9:07 PM · Restricted Project, Restricted Project
kastiglione requested review of D127586: [lldb][Interpreter] Add newline terminal to one-line script calls.
Jun 11 2022, 8:58 PM · Restricted Project, Restricted Project
kastiglione committed rGc7a56af3072c: [lldb][bindings] Implement __repr__ instead of __str__ (authored by kastiglione).
[lldb][bindings] Implement __repr__ instead of __str__
Jun 11 2022, 10:20 AM · Restricted Project
kastiglione closed D127458: [lldb][bindings] Implement __repr__ instead of __str__.
Jun 11 2022, 10:20 AM · Restricted Project, Restricted Project

Jun 10 2022

kastiglione updated the diff for D127458: [lldb][bindings] Implement __repr__ instead of __str__.

update TestConvenienceVariables.test

Jun 10 2022, 11:07 AM · Restricted Project, Restricted Project
kastiglione updated the diff for D127458: [lldb][bindings] Implement __repr__ instead of __str__.

add test/API/sanity/TestReprStrEquality.py

Jun 10 2022, 10:49 AM · Restricted Project, Restricted Project
kastiglione added a comment to D127458: [lldb][bindings] Implement __repr__ instead of __str__.

Note also that the tests use str() in many places, so we can be sure this hasn't regressed that. I will add a test for repr.

Jun 10 2022, 9:48 AM · Restricted Project, Restricted Project
kastiglione accepted D127038: Add some documentation for the "breakpoint name" feature.

thank you again

Jun 10 2022, 9:46 AM · Restricted Project, Restricted Project
kastiglione updated the summary of D127458: [lldb][bindings] Implement __repr__ instead of __str__.
Jun 10 2022, 9:14 AM · Restricted Project, Restricted Project
kastiglione updated the summary of D127458: [lldb][bindings] Implement __repr__ instead of __str__.
Jun 10 2022, 9:11 AM · Restricted Project, Restricted Project
kastiglione added a comment to D127458: [lldb][bindings] Implement __repr__ instead of __str__.

@mib I tried but failed to answer that in the original commit description. I have reworded it to be more clear. Here's the relevant paragraph:

Jun 10 2022, 9:11 AM · Restricted Project, Restricted Project
kastiglione updated the summary of D127458: [lldb][bindings] Implement __repr__ instead of __str__.
Jun 10 2022, 9:10 AM · Restricted Project, Restricted Project

Jun 9 2022

kastiglione requested review of D127458: [lldb][bindings] Implement __repr__ instead of __str__.
Jun 9 2022, 4:53 PM · Restricted Project, Restricted Project
kastiglione committed rG47c4c6a7469f: [lldb] Use assertState in more tests (NFC) (authored by kastiglione).
[lldb] Use assertState in more tests (NFC)
Jun 9 2022, 4:18 PM · Restricted Project
kastiglione added a comment to D127378: [lldb] Use assertState in more tests (NFC).

@JDevlieghere assertEquals is the deprecated name, assertEqual is the

Jun 9 2022, 4:18 PM · Restricted Project, Restricted Project