@Tyker in case you didn't see my previous message, I'm curious if you'd be willing to take a look at the bug. Thanks!
Wed, May 5
Thu, Apr 29
I changed direction, to ensure the impl pointer is always non-null.
Ensure m_impl_up is always non-null
I should expand this to fix other unchecked dereferences.
Fri, Apr 23
@aaron.ballman's point that maybe this should be -Werror by default in clang sounds plausible - because not all projects will be using -Werror, etc. If that helps some users who work on LLVM itself but don't want to turn on -Werror (not sure why - the buildbots will do it and so things will break/you'll have to fix stuff if you're not building with -Werror using a fairly recent clang) that's OK.
Thu, Apr 22
I guess wait until the dust on https://reviews.llvm.org/D101037 settles?
Mon, Apr 19
I like it, though I'm not sure about the python3 requirement.
Fri, Apr 16
other than the clang-tidy note about the capitalization of rpath, lgtm
Apr 6 2021
For reformat commits, what are your thoughts on adding the shas in .git-blame-ignore-revs?
Generally we try pretty hard to be -Werror clean for clang at least (& some folks do so for gcc too)
friendly ping @jingham
- I've updated the summary to include wording from the original diff D98224 which points out that -Werror=return-type is used in libcxx, libcxxabi, and libunwind.
- Warnings have a spectrum of severity, -Wreturn-type is one of the most severe, but turning on -Werror for more mundane warnings would be a deal breaker for some projects. I think it's more reasonable to turn errors on individually, rather than require a codebase to be all or nothing.
- There are already other -Werror=... in this same file, so there is precedent.
Apr 4 2021
Apr 2 2021
Apr 1 2021
s/lldb alias/pdb alias
Indent source block
Mar 31 2021
Mar 29 2021
Mar 22 2021
Mar 19 2021
Mar 16 2021
Mar 15 2021
Mar 12 2021
Mar 10 2021
@xbolva00 yes I plan to do that. I'll quickly check into the gcc situation first, and but may just re-enable it for clang.
Reverted because some versions of gcc can emit -Wreturn-type warnings on functions that have exhaustive switches over enums. A fix is to use llvm_unreachable but that's not currently done everywhere (and also seems like a poor/unnecessary practice).
Jim previously approved this offline.
Mar 9 2021
thanks. I reverted my module change 736afe465f4216f55372a907d7288910f9de6bea
Mar 8 2021
I pushed f1b690598eeca0568e39134f28e0a59c1c1f3598 as a fix or temporary fix.
Mar 7 2021
@Tyker Hi, I noticed a case that isn't caught by -Wmisleading-indentation. In code that uses two space indents, there's a corner case that isn't caught when the preceding if uses curly braces. I've noticed a couple instances of this in lldb.
Mar 4 2021
Feb 26 2021
internal_dict renames done in 8d1b6afcea6c30db7728d966d9281ab373eaa9e1
back out dict renames
@teemperor I switched dict to internal_dict because more code uses internal_dict, and because variables named dict shadow the dict constructor. The dict constructor isn't used, but I think it's better to avoid shadowing it.
Feb 25 2021
There's pretty much nothing new here compared D97165.
Feb 24 2021
Feb 23 2021
check ptr_sp before use
Feb 22 2021
test for null using SBValue.unsigned