Page MenuHomePhabricator
Feed Advanced Search

Fri, Nov 22

jdemeule added a reviewer for D69282: [RFC] Add a VCS conflict marker format printing on tooling::ReplacementError: ioeric.

Kindly ping reviewers and adding Eric as you were interested last year about that.

Fri, Nov 22, 7:27 AM · Restricted Project
jdemeule added a comment to D69475: [clang] Provide better fix-it on exception spec error.

Kindly ping reviewer.

Fri, Nov 22, 7:27 AM · Restricted Project

Oct 27 2019

jdemeule created D69475: [clang] Provide better fix-it on exception spec error.
Oct 27 2019, 2:09 AM · Restricted Project

Oct 21 2019

jdemeule created D69282: [RFC] Add a VCS conflict marker format printing on tooling::ReplacementError.
Oct 21 2019, 3:37 PM · Restricted Project

Jun 17 2019

jdemeule added a comment to D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon..

What is the status here? Will you continue to work on this patch @jdemeule (which would be great!) ?

Hi, now, this patch contains only tests which are already covered with lit tests.
The cleanup is now applied in clang-apply-replacements.

How does that work with clang-tidy -fix ?

Jun 17 2019, 7:19 AM · Restricted Project
jdemeule added a comment to D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon..

What is the status here? Will you continue to work on this patch @jdemeule (which would be great!) ?

Jun 17 2019, 7:00 AM · Restricted Project

Aug 9 2018

jdemeule added a comment to D48523: [clang-tidy] Update run-clang-tidy.py with vfsoverlay arg.

Kindly ping reviewers.

Aug 9 2018, 11:29 PM

Jul 10 2018

jdemeule added a comment to D48523: [clang-tidy] Update run-clang-tidy.py with vfsoverlay arg.

kindly ping reviewers.

Jul 10 2018, 1:38 AM

Jun 23 2018

jdemeule created D48523: [clang-tidy] Update run-clang-tidy.py with vfsoverlay arg.
Jun 23 2018, 1:39 PM

Apr 12 2018

jdemeule accepted D45555: [clang-apply-replacements] Fix a link failure in applyChanges().
Apr 12 2018, 3:59 AM

Apr 11 2018

jdemeule updated the diff for D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..

Sort replacements before converting them to AtomicChange.

Apr 11 2018, 2:52 AM

Apr 10 2018

jdemeule added a comment to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..

Ok, I understand the problem.
Previously, during the deduplication step, replacements per file where sorted and it is not the case anymore.
That means now, clang-apply-replacement is highly dependant of reading file order during error reporting.
I mainly see 2 options (I can miss others), rewrite the test (e.g merging yaml file together) or sort the replacements per file to fix the order of application.

Apr 10 2018, 1:40 AM

Apr 8 2018

jdemeule added a comment to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..

Thank you for applying the patch.

Apr 8 2018, 10:17 AM

Apr 4 2018

jdemeule added a comment to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..

Can I help in some way to close this PR?

Apr 4 2018, 11:37 PM

Mar 28 2018

jdemeule added a comment to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..

Thanks a lot!
Can I ask you if I need to do something as I do not have commit access?

Mar 28 2018, 7:45 AM

Mar 26 2018

jdemeule updated the diff for D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..

Update after review (cleanup and improve comments).

Mar 26 2018, 11:26 PM

Mar 20 2018

jdemeule added inline comments to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..
Mar 20 2018, 2:05 PM
jdemeule updated the diff for D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..

Update after review.
Change error reporting to use ReplacementError message.

Mar 20 2018, 12:31 AM

Mar 16 2018

jdemeule added inline comments to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..
Mar 16 2018, 6:16 AM

Mar 15 2018

jdemeule added inline comments to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..
Mar 15 2018, 4:08 AM
jdemeule updated the diff for D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..

Update after review.
Add tests to check identical insertions and order dependent insertions.

Mar 15 2018, 1:51 AM

Mar 12 2018

jdemeule added inline comments to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..
Mar 12 2018, 11:50 AM

Mar 6 2018

jdemeule added inline comments to D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon..
Mar 6 2018, 1:05 PM · Restricted Project

Mar 4 2018

jdemeule updated the diff for D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..

Update patch after reviewer comments.

Mar 4 2018, 2:27 PM
jdemeule added inline comments to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..
Mar 4 2018, 9:01 AM

Feb 28 2018

jdemeule added a comment to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..

Thanks for your feedback, they are very precious to me!

Feb 28 2018, 2:51 PM
jdemeule updated the diff for D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon..

Update after review.

Feb 28 2018, 1:49 PM · Restricted Project

Feb 26 2018

jdemeule added inline comments to D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon..
Feb 26 2018, 2:09 PM · Restricted Project
jdemeule created D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..
Feb 26 2018, 7:39 AM
jdemeule updated the diff for D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon..

As discuss, I have removed the modifications but keep the tests.
To have tests with meaning, I have also add a way to format code on 'runCheckOnCode'.

Feb 26 2018, 6:53 AM · Restricted Project

Feb 21 2018

jdemeule added a comment to D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon..

Is there a way to make clang-apply-replacements smarter rather than forcing every check to jump through hoops? I'm worried that if we have to fix individual checks we'll just run into the same bug later.

See http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161017/174238.html

Feb 21 2018, 2:28 PM · Restricted Project

Feb 19 2018

jdemeule created D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon..
Feb 19 2018, 11:37 PM · Restricted Project