Page MenuHomePhabricator
Feed Advanced Search

Today

Szelethus added a comment to D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions.
In D54823#1675604, @NoQ wrote:

Is it just me or phabricator somehow refuses to display the changes since the last diff here? That's probably the commit diff is involved somehow. So i'm confused what exactly has changed >.<

Thu, Sep 19, 1:28 PM · Restricted Project
Szelethus added a comment to D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions.

Rebase, fix (suspected) error that caused buildbot errors. Hold off commiting in favor checking whether putting CallDescriptionMap in would be too invasive, but really, can't be worse then it already is.

Thu, Sep 19, 11:33 AM · Restricted Project
Szelethus set the repository for D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions to rG LLVM Github Monorepo.
Thu, Sep 19, 8:36 AM · Restricted Project
Szelethus updated the diff for D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions.

Rebase, fix (suspected) error that caused buildbot errors. Hold off commiting in favor checking whether putting CallDescriptionMap in would be too invasive, but really, can't be worse then it already is.

Thu, Sep 19, 8:36 AM · Restricted Project
Herald added a project to D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions: Restricted Project.
Thu, Sep 19, 7:51 AM · Restricted Project

Yesterday

Szelethus added a comment to D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.

We have no solid evidence to conclude that such an event should not occur at a BlockEntrance, so fixing this error mustn't be that bad. I certainly should've used llvm::isa_or_nonnull, so the patch overall makes sense, so I'm commiting it as is. With that said, this test case highlights a fundamental flaw in how loop wideining is implemented (hence it being off-by-default), and it should be addressed later separately.

Wed, Sep 18, 3:31 PM · Restricted Project, Restricted Project
Szelethus committed rL372269: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic….
[analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic…
Wed, Sep 18, 3:23 PM
Szelethus closed D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.
Wed, Sep 18, 3:23 PM · Restricted Project, Restricted Project
Szelethus retitled D67706: [clang][analyzer] Using CallDescription in StreamChecker. from [clang][checkers] Using CallDescription in StreamChecker. to [clang][analyzer] Using CallDescription in StreamChecker..
Wed, Sep 18, 9:57 AM · Restricted Project

Tue, Sep 17

Szelethus edited reviewers for D67682: [WIP] Add support for preprocessing sources for analyzer, added: NoQ; removed: dergachev.a.
Tue, Sep 17, 6:04 PM

Mon, Sep 16

Szelethus added reviewers for D67545: [clang-tidy] Added DefaultOperatorNewCheck.: aaron.ballman, alexfh, JonasToth, lebedev.ri.
Mon, Sep 16, 7:37 AM · Restricted Project
Szelethus added a comment to D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.

While we're there, could you please see whether the included test case (note how condition tracking is turned off) fails on your platform without the rest of the patch applied (it definitely does on mine, which is why I was surprised to see this bug report pop up only now)? If not, I can just push a small commit with the llvm::isa_and_nonnull change to get some breathing room.

Mon, Sep 16, 5:23 AM · Restricted Project, Restricted Project
Szelethus added a comment to D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.

Hi there,

just checking in, is this patch still going ahead?

thanks
Tom W

Mon, Sep 16, 5:20 AM · Restricted Project, Restricted Project

Sun, Sep 15

Szelethus added inline comments to D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions..
Sun, Sep 15, 8:00 AM · Restricted Project

Sat, Sep 14

Szelethus added a comment to D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions..

Aha, so every user gets to create their own PathDiagnosticConsumerOptions object, makes sense! There is no interface misconception, because -analyzer-config will only configure what the analyzer would tinket with. I like this patch! If you dont mind, I'd prefer to have one last round with this, but otherwise LGTM.

Sat, Sep 14, 9:42 AM · Restricted Project

Thu, Sep 12

Szelethus added a comment to D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks".

Yes, thank you! I've been keeping my mailbox open and commiting slowly, it seems like the buildbots have a wrong email address set up for me.

Thu, Sep 12, 2:33 PM · Restricted Project, Restricted Project
Szelethus added a comment to D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions..
In D67420#1668474, @NoQ wrote:

It's not that AnalyzerOptions is necessary to construct this, it's more like sufficient.

Thu, Sep 12, 2:25 PM · Restricted Project
Szelethus committed rL371765: [CFG] Add dumps for CFGElement and CFGElementRef.
[CFG] Add dumps for CFGElement and CFGElementRef
Thu, Sep 12, 12:52 PM
Szelethus closed D66715: [CFG] Add dumps for CFGElement and CFGElementRef.
Thu, Sep 12, 12:51 PM · Restricted Project, Restricted Project
Szelethus committed rL371760: [analyzer][NFC] Fix inconsistent references to checkers as "checks".
[analyzer][NFC] Fix inconsistent references to checkers as "checks"
Thu, Sep 12, 12:11 PM
Szelethus closed D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks".
Thu, Sep 12, 12:11 PM · Restricted Project, Restricted Project
Szelethus committed rL371756: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers.
[analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers
Thu, Sep 12, 11:55 AM
Szelethus closed D66714: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers.
Thu, Sep 12, 11:54 AM · Restricted Project, Restricted Project
Szelethus added a comment to D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions..
In D67420#1666578, @NoQ wrote:

I do!

Hmm, it sounds like you want to force both Clang frontend and Clang-Tidy to use the same set of flags to control these options (?) Much like -analyzer-config, these flags will have different "style" compared to other flags in the tool. Which is probably not too bad for hidden frontend flags that control the Analyzer because they're anyway set by a separate GUI checkbox, but the inconsistency with other flags would be super glaring in case of Clang-Tidy CLI. Do we really want to go in that direction? I'll be much more comfortable with letting each tool deal with its flags the way it prefers - this doesn't look like a good place for code reuse to me.

Thu, Sep 12, 10:36 AM · Restricted Project
Szelethus retitled D67480: [analyzer] Add 'freopen' support to SimpleStreamChecker. from [Clang][Checkers] Add 'freopen' support to SimpleStreamChecker. to [analyzer] Add 'freopen' support to SimpleStreamChecker..
Thu, Sep 12, 8:19 AM · Restricted Project

Wed, Sep 11

Szelethus added a comment to D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions..

@Szelethus: I could have stored PathDiagnosticConsumerOptions in AnalyzerOptions by value and pass a const reference around, but it wasn't pleasant to integrate with AnalyzerOptions.def. I.e., i'd have to implement a new kind of option that doesn't allocate its own field but instead re-uses a field within a sub-object. Do you want me to go for it or is this implementation good enough?

Wed, Sep 11, 7:27 AM · Restricted Project
Szelethus added a comment to D67419: [analyzer] NFC: Move PathDiagnostic to libAnalysis..

Looks great! Are we sure that PathDiagnostic.h is a good header name?

Wed, Sep 11, 5:19 AM · Restricted Project, Restricted Project
Szelethus accepted D67382: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic..

LGTM! I think code readability improved geatly.

Wed, Sep 11, 5:15 AM · Restricted Project, Restricted Project
Szelethus accepted D67381: [analyzer] NFC: Move stack hints to a side map..

I'm open to discuss a better design here. Eg., i thought about making it part of the visitor interface instead, but i don't immediately see how to do this without breaking the logic of "only add the note at the call site in which the event has happened, not every time allocated memory is returned from anywhere".

Wed, Sep 11, 4:46 AM · Restricted Project, Restricted Project
Szelethus accepted D67418: [analyzer] NFC: Move PathDiagnostic::resetDiagnosticLocationToMainFile to bug reporter..

Sure!

Wed, Sep 11, 2:49 AM · Restricted Project, Restricted Project

Sun, Sep 8

Szelethus added inline comments to D67335: [analyzer][NFC] Refactor the checker registration unit test file.
Sun, Sep 8, 3:18 PM · Restricted Project
Szelethus added a parent revision for D67336: [analyzer][NFC] Introduce SuperChecker<>, a convenient alternative to Checker<> for storing subcheckers: D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks".
Sun, Sep 8, 3:09 PM · Restricted Project
Szelethus added a child revision for D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks": D67336: [analyzer][NFC] Introduce SuperChecker<>, a convenient alternative to Checker<> for storing subcheckers.
Sun, Sep 8, 3:09 PM · Restricted Project, Restricted Project
Szelethus added a child revision for D67335: [analyzer][NFC] Refactor the checker registration unit test file: D67336: [analyzer][NFC] Introduce SuperChecker<>, a convenient alternative to Checker<> for storing subcheckers.
Sun, Sep 8, 3:09 PM · Restricted Project
Szelethus added a parent revision for D67336: [analyzer][NFC] Introduce SuperChecker<>, a convenient alternative to Checker<> for storing subcheckers: D67335: [analyzer][NFC] Refactor the checker registration unit test file.
Sun, Sep 8, 3:09 PM · Restricted Project
Szelethus created D67336: [analyzer][NFC] Introduce SuperChecker<>, a convenient alternative to Checker<> for storing subcheckers.
Sun, Sep 8, 3:09 PM · Restricted Project
Szelethus created D67335: [analyzer][NFC] Refactor the checker registration unit test file.
Sun, Sep 8, 3:07 PM · Restricted Project

Sat, Sep 7

Szelethus added a comment to D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis.

Hmm, we could make a redundant assignments checker: if a variable has multiple reaching definitions, but those all assign the same value, emit a warning. We could even use fixits with that.

void t(int a) {
  if (coin())
    a = 2; // note: reaching def
  else
    a = 2; // note: reaching def
  use(a); // warn: a is always 2 here
}
Sat, Sep 7, 9:29 AM · Restricted Project

Fri, Sep 6

Szelethus added a comment to D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection.

I'm sadly not knowledgeable enough with CallDescriptionMap, so let's have another round of review on this, otherwise, its perfect.

Fri, Sep 6, 6:19 PM · Restricted Project
Szelethus added a comment to D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection.

Niiiiice! Thank you so much for sorting this out! I think this will make reviewing far more accessible for newcomers to the IteratorChecker family. I have a couple nits to comment on, but I won't clutter the code just yet. @NoQ, do you have any high level objections to this?

Fri, Sep 6, 4:56 PM · Restricted Project
Szelethus added a comment to D66572: [analyzer] NFC: BugReporter Separation Ep.I..

But, of course, let's wait for @gribozavr to give his blessings as well, I'm only accepting because removing/changing other parts of the API seems to deserve a separate revision :)

Fri, Sep 6, 4:32 PM · Restricted Project, Restricted Project
Szelethus accepted D66572: [analyzer] NFC: BugReporter Separation Ep.I..

This patch set the goal of splitting BugReport into two different report kinds, and I think it did that well. Not only that, we drastically improved the documentation, formalized many things that weren't in the core before, so I wouldn't like you to bear the burdern of never ending rebases (it doesn't make reviewing easier either). Let's work on the rest of the code in a followup patch.

Fri, Sep 6, 4:27 PM · Restricted Project, Restricted Project
Szelethus accepted D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.

I'm fine with moving in-class function into anonymous namespace later. LGTM, feel free to commit!

Fri, Sep 6, 2:50 PM · Restricted Project

Thu, Sep 5

Szelethus added a comment to D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks".
In D67140#1659907, @NoQ wrote:

If we're okay with the inconsistency but still feel like giving ourselves more work, adding proper punctuation to Static Analyzer diagnostics would at least make them grammatically correct. :-D

I'd love us some punctuation! Unfortunately the last time a person who actually speaks English committed actively to the Static Analyzer was, like, a couple of years ago at least (:

Thu, Sep 5, 3:51 PM · Restricted Project, Restricted Project
Szelethus added a comment to D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks".

I don't have strong feelings on capitalization itself either, but the idea of longer, multi-sentence bug report messages (maybe this could finally be used? D66572#inline-602143) sound pretty cool.

Thu, Sep 5, 2:52 PM · Restricted Project, Restricted Project
Szelethus added a comment to D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.

I'm still working on this, just been kinda busy. I'll try to get it out of the way asap.

Thu, Sep 5, 8:08 AM · Restricted Project, Restricted Project
Szelethus added a comment to D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks".

Then again, with the recent resurfacing of discussions about renaming everything under the sun, maybe we've changed our community opinion here. :-D I guess I don't see Check vs Checker to be worthy of breaking everyone's out-of-tree code over.

Thu, Sep 5, 8:02 AM · Restricted Project, Restricted Project
Szelethus added a comment to D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.

Also, please mark inlines done as you fix them :)

Thu, Sep 5, 12:58 AM · Restricted Project
Szelethus accepted D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.

Some nits inline, otherwise LGTM. @steakhal, do you have anything to add to this?

Thu, Sep 5, 12:58 AM · Restricted Project

Wed, Sep 4

Szelethus added reviewers for D66569: [analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path: Charusso, NoQ.
Wed, Sep 4, 11:21 AM · Restricted Project, Restricted Project
Szelethus updated the summary of D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks".
Wed, Sep 4, 9:59 AM · Restricted Project, Restricted Project

Tue, Sep 3

Szelethus added inline comments to D66733: [analyzer] Add a checker option to detect nested dead stores.
Tue, Sep 3, 8:31 PM · Restricted Project, Restricted Project
Szelethus added reviewers for D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks": gribozavr, alexfh.

@gribozavr, @alexfh this isn't a particularly exciting patch, but it does highlight a fundamental difference in between the analyzer and clang-tidy, so I added you for the sake of it, since we're talking about a closer interaction anyway :)

Tue, Sep 3, 7:38 PM · Restricted Project, Restricted Project
Szelethus created D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks".
Tue, Sep 3, 7:36 PM · Restricted Project, Restricted Project
Szelethus added inline comments to D66733: [analyzer] Add a checker option to detect nested dead stores.
Tue, Sep 3, 2:27 PM · Restricted Project, Restricted Project
Szelethus added inline comments to D67079: [analyzer] CastValueChecker: Model inheritance.
Tue, Sep 3, 2:12 PM · Restricted Project
Szelethus added a comment to D66572: [analyzer] NFC: BugReporter Separation Ep.I..

Also, thank you @gribozavr for your comments -- its very nice to have someone review a bigger part of our development interface who is knowledgeable about Clang, but not the Static Analyzer specifically. Looking at your inlines, these are very fair criticisms, I found (find) these confusing when I just started contributing as well.

Tue, Sep 3, 1:13 PM · Restricted Project, Restricted Project
Szelethus accepted D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers..

Other then the things @gribozavr mentioned, LGTM.

Tue, Sep 3, 1:09 PM · Restricted Project, Restricted Project
Szelethus committed rL370798: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker….
[analyzer] NonNullParamChecker and CStringChecker parameter number in checker…
Tue, Sep 3, 10:56 AM
Szelethus closed D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message.
Tue, Sep 3, 10:56 AM · Restricted Project, Restricted Project
Szelethus committed rL370767: [analyzer] Add a checker option to detect nested dead stores.
[analyzer] Add a checker option to detect nested dead stores
Tue, Sep 3, 8:24 AM
Szelethus closed D66733: [analyzer] Add a checker option to detect nested dead stores.
Tue, Sep 3, 8:24 AM · Restricted Project, Restricted Project
Szelethus added inline comments to D66572: [analyzer] NFC: BugReporter Separation Ep.I..
Tue, Sep 3, 4:32 AM · Restricted Project, Restricted Project
Szelethus added a comment to D66042: [analyzer] Analysis: Silence checkers.

@Charusso This probably should be added to the release notes:
https://clang.llvm.org/docs/ReleaseNotes.html#static-analyzer
and detailed in the doc.
Please let me know if you need help!

Tue, Sep 3, 3:08 AM · Restricted Project, Restricted Project

Wed, Aug 28

Szelethus added a comment to D65361: [analyzer] Trust global initializers when analyzing main()..

Sorry for not accepting this -- I actually read the code multiple times and didn't see anything that stood out! I didn't have the time to dig too deep, but if the tests are anything to go by, its gotta be alright.

Wed, Aug 28, 12:01 PM · Restricted Project, Restricted Project
Szelethus accepted D66733: [analyzer] Add a checker option to detect nested dead stores.

Excellent detective work! Thanks! I'll do the honors.

Wed, Aug 28, 10:54 AM · Restricted Project, Restricted Project
Szelethus added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

@Szelethus The mispositioned report message was my fault. I used a different version of clang for the analysis and to upload the results, which resulted in some mispositioned reports.
I've fixed the linked CodeChecker instance.

Wed, Aug 28, 7:54 AM · Restricted Project, Restricted Project

Tue, Aug 27

Szelethus added a comment to D66765: [analyzer] (Urgent!) Add 9.0.0. release notes..
In D66765#1646237, @NoQ wrote:

I approve the patch and i don't see anything obvious that we're missing out (@Szelethus, your GSoC isn't on by default back in 9.0, only in master, right?).

Tue, Aug 27, 6:59 PM · Restricted Project, Restricted Project
Szelethus updated the diff for D66765: [analyzer] (Urgent!) Add 9.0.0. release notes..

Fixing inlines!

Tue, Aug 27, 6:56 PM · Restricted Project, Restricted Project
Szelethus added a comment to D66847: [analyzer] Fix analyzer warnings..

Another common mistake is this:

if (A) {
  const auto *B = dyn_cast_or_null<FunctionDecl>(A); // warn: A is known to be non-null, prefer dyn_cast
}
Tue, Aug 27, 6:29 PM · Restricted Project, Restricted Project
Szelethus accepted D66847: [analyzer] Fix analyzer warnings..

if the dyn_ part is really necessary here, then you crash with a null dereference a few lines below because you didn't check the result

Tue, Aug 27, 5:48 PM · Restricted Project, Restricted Project
Szelethus added a comment to D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.
In D66716#1647668, @NoQ wrote:

I don't understand. Isn't widening supposed to happen after we exit the loop? The loop isn't over yet when the bug is being reported. Why is this problem widening-specific? Given that we also have a weird invalidation of b, i suspect that we're doing widening in a wrong moment of time.

Tue, Aug 27, 1:14 PM · Restricted Project, Restricted Project
Szelethus added a comment to D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.

Note how I am partially at fault here, which is why the bug reports state that the crash originates from TrackControlDependencyVisitor, but even after that is fixed, the diagnostics construction flopped on an out-of-bounds error.

Tue, Aug 27, 4:35 AM · Restricted Project, Restricted Project
Szelethus updated subscribers of D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.
Tue, Aug 27, 4:35 AM · Restricted Project, Restricted Project

Mon, Aug 26

Szelethus added a comment to D66404: [CFG] Make destructor calls more accurate.

Heh, I guess I'll request commit access, although I'm not sure if I have enough of a 'track record of submitting high quality patches'.

Mon, Aug 26, 1:52 PM · Restricted Project, Restricted Project
Szelethus added a reviewer for D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.: hans.
Mon, Aug 26, 12:04 PM · Restricted Project, Restricted Project
Szelethus added a comment to D66765: [analyzer] (Urgent!) Add 9.0.0. release notes..

Please note that LLVM 9.0.0-final is due on the 28th of August.

Mon, Aug 26, 12:04 PM · Restricted Project, Restricted Project
Szelethus created D66765: [analyzer] (Urgent!) Add 9.0.0. release notes..
Mon, Aug 26, 12:04 PM · Restricted Project, Restricted Project
Szelethus accepted D66565: [analyzer] pr43036: Fix support for operator `sizeof...'..

(++LGTM)++

Mon, Aug 26, 9:14 AM · Restricted Project, Restricted Project
Szelethus accepted D66733: [analyzer] Add a checker option to detect nested dead stores.

I really-really like this change. The results look great, though I'm not sure what happened here, are we sure that this originates from the analyzer, and is not some storing error?

Mon, Aug 26, 5:10 AM · Restricted Project, Restricted Project

Sun, Aug 25

Szelethus added a comment to D66721: [analyzer] Analysis: Prevent bitwise operation false positives.
In D66721#1644514, @NoQ wrote:

No-no, you're disabling the checkers here but you should be silencing them. This will be crashing because modeling is disabled.

I also recommend checker options, even if they apply to multiple checkers (@Szelethus mentioned that package options are a thing, you might use these if you don't want to make multiple options).

Sun, Aug 25, 3:11 PM · Restricted Project
Szelethus added a comment to D66715: [CFG] Add dumps for CFGElement and CFGElementRef.

Mind that I'll probably commit without the unit test, last time I learned the hard way that the AST's lifetime ends by the time we retrieve the CFG.

Sun, Aug 25, 9:25 AM · Restricted Project, Restricted Project
Szelethus added a comment to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

No worries, always happy to help! :)

Sun, Aug 25, 9:21 AM · Restricted Project, Restricted Project
Szelethus added inline comments to D66572: [analyzer] NFC: BugReporter Separation Ep.I..
Sun, Aug 25, 7:27 AM · Restricted Project, Restricted Project
Szelethus created D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.
Sun, Aug 25, 6:46 AM · Restricted Project, Restricted Project
Szelethus created D66715: [CFG] Add dumps for CFGElement and CFGElementRef.
Sun, Aug 25, 6:31 AM · Restricted Project, Restricted Project
Szelethus created D66714: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers.
Sun, Aug 25, 5:24 AM · Restricted Project, Restricted Project

Fri, Aug 23

Szelethus committed rL369763: [clang-tidy] Possibility of displaying duplicate warnings.
[clang-tidy] Possibility of displaying duplicate warnings
Fri, Aug 23, 8:00 AM
Szelethus closed D65065: [clang-tidy] Possibility of displaying duplicate warnings.
Fri, Aug 23, 8:00 AM · Restricted Project, Restricted Project
Szelethus added a comment to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

I seem to have been able to put this together by fetching the individual diffs and squashing them this time :)

Fri, Aug 23, 7:20 AM · Restricted Project, Restricted Project
Szelethus committed rL369760: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.
[analyzer] Avoid unnecessary enum range check on LValueToRValue casts
Fri, Aug 23, 7:20 AM
Szelethus closed D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.
Fri, Aug 23, 7:20 AM · Restricted Project, Restricted Project
Szelethus added a comment to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

What I meant is that the diff has to be made against the master branch or I won't be able to apply it locally. Say your repo is structured like this:

Fri, Aug 23, 6:47 AM · Restricted Project, Restricted Project
Szelethus accepted D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message.

@whisperity, any objections to this?

Fri, Aug 23, 6:19 AM · Restricted Project, Restricted Project

Thu, Aug 22

Szelethus added a comment to D66572: [analyzer] NFC: BugReporter Separation Ep.I..

You got me convinced.

Thu, Aug 22, 4:06 PM · Restricted Project, Restricted Project

Wed, Aug 21

Szelethus committed rG0f9e530c0f4d: [analyzer] Enable control dependency condition tracking by default (authored by Szelethus).
[analyzer] Enable control dependency condition tracking by default
Wed, Aug 21, 8:09 PM
Szelethus committed rL369616: [analyzer] Enable control dependency condition tracking by default.
[analyzer] Enable control dependency condition tracking by default
Wed, Aug 21, 8:09 PM
Szelethus closed D66381: [analyzer] Enable control dependency condition tracking by default.
Wed, Aug 21, 8:09 PM · Restricted Project
Szelethus added a comment to D66572: [analyzer] NFC: BugReporter Separation Ep.I..

Super high level question: CheckerManager knows whether a checker, and I suspect a checker callback is path sensitive or not, do you think we can automate this decision (whether the bug report is path sensitive of syntactic)? For the purposes of clang-tidy, can we say such a thing that if we can't prove a bug report to be path sensitive, it will not be that?

Wed, Aug 21, 7:44 PM · Restricted Project, Restricted Project
Szelethus committed rG58eb033a4977: [analyzer] Don't track the condition of foreach loops (authored by Szelethus).
[analyzer] Don't track the condition of foreach loops
Wed, Aug 21, 7:44 PM