In D12079#244059, @jaydeep wrote:
In D12079#243390, @clayborg wrote:
In D12079#242998, @jaydeep wrote:
In D12079#242742, @clayborg wrote:
So DumpAddress() in FormatEntity.cpp is a generic "dump any address by describing it". You can't just change the code to suit your needs for MIPS. This address could be any address: code or data. If you want something that can take an address like 0x1000 and you ask for its AddressClass and it sees that its address class is eAddressClassCodeAlternateISA, and then you change it to be "0x1001", this will need to be a new format type.

DumpAddress in FormatEntity.cpp is called for the following entities:
case Entry::Type::LineEntryStartAddress:
case Entry::Type::LineEntryEndAddress:
case Entry::Type::AddressFile:
case Entry::Type::AddressLoad:
case Entry::Type::AddressLoadOrFile:
case Entry::Type::FrameRegisterPC
So only the LineEntry ones should actually do what you did.
We need to display all these entities in compressed address format. How about a new MIPS specific function in Address and Target class which would do this.

Address Address::GetCallableAddress(Target *target);
lldb::addr_t Target::GetCallableAddress (lldb::addr_t load_addr, AddressClass addr_class);
We already have this in Target:
lldb::addr_t
GetCallableLoadAddress (lldb::addr_t load_addr, lldb::AddressClass addr_class = lldb::eAddressClassInvalid) const;
So the solution here will be to modify Address::Dump() such that it detects when an address is eAddressClassCodeAlternateISA and when that happens it checks if the ExecutionContext parameter is non NULL, and if so, extract the target, and check the target's architecture is MIPS, then add the extra bit when displaying this address. As it seems that we would always want to describe a section offset address (lldb_private::Address object) in this way to show the MicroMIPS address space bit, right?
In D12079#243390, @clayborg wrote:
In D12079#242998, @jaydeep wrote:
In D12079#242742, @clayborg wrote:
So DumpAddress() in FormatEntity.cpp is a generic "dump any address by describing it". You can't just change the code to suit your needs for MIPS. This address could be any address: code or data. If you want something that can take an address like 0x1000 and you ask for its AddressClass and it sees that its address class is eAddressClassCodeAlternateISA, and then you change it to be "0x1001", this will need to be a new format type.

DumpAddress in FormatEntity.cpp is called for the following entities:
case Entry::Type::LineEntryStartAddress:
case Entry::Type::LineEntryEndAddress:
case Entry::Type::AddressFile:
case Entry::Type::AddressLoad:
case Entry::Type::AddressLoadOrFile:
case Entry::Type::FrameRegisterPC
So only the LineEntry ones should actually do what you did.
We need to display all these entities in compressed address format. How about a new MIPS specific function in Address and Target class which would do this.

Address Address::GetCallableAddress(Target *target);
lldb::addr_t Target::GetCallableAddress (lldb::addr_t load_addr, AddressClass addr_class);
We already have this in Target:
lldb::addr_t
GetCallableLoadAddress (lldb::addr_t load_addr, lldb::AddressClass addr_class = lldb::eAddressClassInvalid) const;
So the solution here will be to modify Address::Dump() such that it detects when an address is eAddressClassCodeAlternateISA and when that happens it checks if the ExecutionContext parameter is non NULL, and if so, extract the target, and check the target's architecture is MIPS, then add the extra bit when displaying this address. As it seems that we would always want to describe a section offset address (lldb_private::Address object) in this way to show the MicroMIPS address space bit, right?
Yes.

Sep 10 2015, 10:31 PM

jaydeep added a comment to D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses.

In D12079#243390, @clayborg wrote:
In D12079#242998, @jaydeep wrote:
In D12079#242742, @clayborg wrote:
So DumpAddress() in FormatEntity.cpp is a generic "dump any address by describing it". You can't just change the code to suit your needs for MIPS. This address could be any address: code or data. If you want something that can take an address like 0x1000 and you ask for its AddressClass and it sees that its address class is eAddressClassCodeAlternateISA, and then you change it to be "0x1001", this will need to be a new format type.

DumpAddress in FormatEntity.cpp is called for the following entities:
case Entry::Type::LineEntryStartAddress:
case Entry::Type::LineEntryEndAddress:
case Entry::Type::AddressFile:
case Entry::Type::AddressLoad:
case Entry::Type::AddressLoadOrFile:
case Entry::Type::FrameRegisterPC
So only the LineEntry ones should actually do what you did.
We need to display all these entities in compressed address format. How about a new MIPS specific function in Address and Target class which would do this.

Address Address::GetCallableAddress(Target *target);
lldb::addr_t Target::GetCallableAddress (lldb::addr_t load_addr, AddressClass addr_class);
We already have this in Target:
lldb::addr_t
GetCallableLoadAddress (lldb::addr_t load_addr, lldb::AddressClass addr_class = lldb::eAddressClassInvalid) const;
So the solution here will be to modify Address::Dump() such that it detects when an address is eAddressClassCodeAlternateISA and when that happens it checks if the ExecutionContext parameter is non NULL, and if so, extract the target, and check the target's architecture is MIPS, then add the extra bit when displaying this address. As it seems that we would always want to describe a section offset address (lldb_private::Address object) in this way to show the MicroMIPS address space bit, right?

Sep 10 2015, 8:45 PM

Sep 9 2015

jaydeep added a comment to D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses.

In D12079#242742, @clayborg wrote:
So DumpAddress() in FormatEntity.cpp is a generic "dump any address by describing it". You can't just change the code to suit your needs for MIPS. This address could be any address: code or data. If you want something that can take an address like 0x1000 and you ask for its AddressClass and it sees that its address class is eAddressClassCodeAlternateISA, and then you change it to be "0x1001", this will need to be a new format type.

DumpAddress in FormatEntity.cpp is called for the following entities:
case Entry::Type::LineEntryStartAddress:
case Entry::Type::LineEntryEndAddress:
case Entry::Type::AddressFile:
case Entry::Type::AddressLoad:
case Entry::Type::AddressLoadOrFile:
case Entry::Type::FrameRegisterPC
So only the LineEntry ones should actually do what you did.

Sep 9 2015, 8:55 PM

jaydeep added a comment to D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses.

In D12079#242751, @clayborg wrote:
Actually not a new format type, but an extra arg will need to be passed to DumpAddress like "bool addr_is_callable".

Can you explain something to me? In the following example:
0x8020067d <+0>:  addiusp -16
0x8020067f <+2>:  sw     $fp, 12($sp)
0x80200681 <+4>:  move   $fp, $sp
Is the addiusp actually at 0x8020067c in memory? Then we just display 0x8020067d to let people know this is MicroMIPS?

Sep 9 2015, 8:49 PM

Sep 8 2015

jaydeep updated the diff for D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses.

In this patch:

Removed MIPS comment from generic code
Used Target::GetOpcodeLoadAddress to fixup the PC

Sep 8 2015, 9:08 PM

jaydeep updated the diff for D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses.

In this patch:

Sep 8 2015, 1:43 AM

Sep 4 2015

jaydeep added inline comments to D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses.

Sep 4 2015, 5:07 AM

Sep 2 2015

jaydeep updated the diff for D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses.

Added GetCallableFileAddress for MIPS

Sep 2 2015, 3:22 AM

Sep 1 2015

jaydeep accepted D12356: [MIPS64] Emulate MSA branch instructions.

Looks good to me

Sep 1 2015, 9:59 PM

Aug 28 2015

jaydeep accepted D12427: [LLDB][MIPS] Aligning code with rL245831 .

Looks good to me.

Aug 28 2015, 1:17 AM

Aug 26 2015

jaydeep updated the diff for D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses.

Addressed review comments.
Address conversions are handled in Address class. This is a reduced version of the original patch where address conversions are handled for breakpoints only.

Aug 26 2015, 10:58 PM

jaydeep requested changes to D12356: [MIPS64] Emulate MSA branch instructions.

Aug 26 2015, 12:18 AM