Page MenuHomePhabricator
Feed Advanced Search

Tue, Oct 29

GitHub <noreply@github.com> committed rG264bd8997823: [APINotes] Don't apply API notes to @class / forward @protocol decls (#198) (authored by jordan_rose).
[APINotes] Don't apply API notes to @class / forward @protocol decls (#198)
Tue, Oct 29, 5:10 PM
GitHub <noreply@github.com> committed rG5292db0578d1: [APINotes] API-noted attributes should not be implicit (#189) (authored by jordan_rose).
[APINotes] API-noted attributes should not be implicit (#189)
Tue, Oct 29, 5:10 PM
GitHub <noreply@github.com> committed rG77f577c64cc2: RecordLayout.h: avoid spurious copies of values to be emitted (#108) (authored by jordan_rose).
RecordLayout.h: avoid spurious copies of values to be emitted (#108)
Tue, Oct 29, 5:10 PM
jordan_rose committed rG83bcfb8a9fa0: Merge remote-tracking branch 'llvm/master' into upstream-with-swift (authored by jordan_rose).
Merge remote-tracking branch 'llvm/master' into upstream-with-swift
Tue, Oct 29, 5:05 PM
jordan_rose committed rG52d91185ec67: Merge remote-tracking branch 'llvm/master' into upstream-with-swift (authored by jordan_rose).
Merge remote-tracking branch 'llvm/master' into upstream-with-swift
Tue, Oct 29, 4:56 PM
jordan_rose committed rG29bce8f49eaf: Merge commit 'llvm/master' into upstream-with-swift (authored by jordan_rose).
Merge commit 'llvm/master' into upstream-with-swift
Tue, Oct 29, 4:56 PM
GitHub <noreply@github.com> committed rG671ad50789d4: Re-remove problematic PrettyStackTrace entry added in r328276 (#203) (authored by jordan_rose).
Re-remove problematic PrettyStackTrace entry added in r328276 (#203)
Tue, Oct 29, 4:54 PM
jordan_rose committed rG994c50caba9d: Merge remote-tracking branch 'llvm/master' into upstream-with-swift (authored by jordan_rose).
Merge remote-tracking branch 'llvm/master' into upstream-with-swift
Tue, Oct 29, 4:53 PM
jordan_rose committed rG7fa91b077395: Merge remote-tracking branch 'llvm/master' into upstream-with-swift (authored by jordan_rose).
Merge remote-tracking branch 'llvm/master' into upstream-with-swift
Tue, Oct 29, 4:52 PM
jordan_rose committed rG477b05d2efd4: Sink PrettyDeclStackTrace down to the AST library (authored by jordan_rose).
Sink PrettyDeclStackTrace down to the AST library
Tue, Oct 29, 4:52 PM
jordan_rose committed rG3248e3233aa1: [APINotes] API-noted attributes should not be implicit (authored by jordan_rose).
[APINotes] API-noted attributes should not be implicit
Tue, Oct 29, 4:52 PM
GitHub <noreply@github.com> committed rGc78ae0e94418: [APINotes] Warn when a private API notes file uses the wrong case (#190) (authored by jordan_rose).
[APINotes] Warn when a private API notes file uses the wrong case (#190)
Tue, Oct 29, 4:19 PM
GitHub <noreply@github.com> committed rG695e9a7cdde9: [test] Disable some API notes tests broken by upstream changes (#188) (authored by jordan_rose).
[test] Disable some API notes tests broken by upstream changes (#188)
Tue, Oct 29, 4:18 PM
GitHub <noreply@github.com> committed rGc58ca3fbd251: Merge pull request #181 from jrose-apple/note-to-self (authored by jordan_rose).
Merge pull request #181 from jrose-apple/note-to-self
Tue, Oct 29, 4:10 PM
jordan_rose committed rG82e3f53a66e1: Tweak search path for API notes for private top-level modules (authored by jordan_rose).
Tweak search path for API notes for private top-level modules
Tue, Oct 29, 4:09 PM
jordan_rose committed rGe843a3fcae9e: Tweak Module to reduce merge conflicts with upstream LLVM Clang (authored by jordan_rose).
Tweak Module to reduce merge conflicts with upstream LLVM Clang
Tue, Oct 29, 4:09 PM
jordan_rose committed rG7a0fb52df54c: Merge remote-tracking branch 'llvm/master' into upstream-with-swift (authored by jordan_rose).
Merge remote-tracking branch 'llvm/master' into upstream-with-swift
Tue, Oct 29, 4:09 PM
jordan_rose committed rG096e15b5ff4f: Tweak doc comment for RecordLayout.h. (authored by jordan_rose).
Tweak doc comment for RecordLayout.h.
Tue, Oct 29, 3:15 PM
GitHub <noreply@github.com> committed rG7b4f41674414: [APINotes] Add 'RetainCountConvention' (#128) (authored by jordan_rose).
[APINotes] Add 'RetainCountConvention' (#128)
Tue, Oct 29, 3:13 PM
GitHub <noreply@github.com> committed rGb979e8d7be10: [APINotes] Record what version caused an annotation to get replaced. (#123) (authored by jordan_rose).
[APINotes] Record what version caused an annotation to get replaced. (#123)
Tue, Oct 29, 3:10 PM
GitHub <noreply@github.com> committed rG8c57c80b9345: Merge pull request #122 from jrose-apple/apinotes-less-than-or-equal (authored by jordan_rose).
Merge pull request #122 from jrose-apple/apinotes-less-than-or-equal
Tue, Oct 29, 3:10 PM
jordan_rose committed rG30147d6682b2: [APINotes] Sort versioned info entries to make lookup easier. (authored by jordan_rose).
[APINotes] Sort versioned info entries to make lookup easier.
Tue, Oct 29, 3:10 PM
jordan_rose committed rGb7fcfbe1c0dc: [APINotes] Honor Swift 4 API notes in Swift 3 mode. (authored by jordan_rose).
[APINotes] Honor Swift 4 API notes in Swift 3 mode.
Tue, Oct 29, 3:10 PM
GitHub <noreply@github.com> committed rG1f6dff503c91: On second thought, don't bother caching compiled API notes at all. (#120) (authored by jordan_rose).
On second thought, don't bother caching compiled API notes at all. (#120)
Tue, Oct 29, 3:09 PM
GitHub <noreply@github.com> committed rG2e986945d174: Soft-deprecate -fapinotes-cache-path; use -fmodules-cache-path instead. (#119) (authored by jordan_rose).
Soft-deprecate -fapinotes-cache-path; use -fmodules-cache-path instead. (#119)
Tue, Oct 29, 3:09 PM
GitHub <noreply@github.com> committed rGeb3dbbb7b598: Mark the swift_wrapper attribute as inheritable (#111) (authored by jordan_rose).
Mark the swift_wrapper attribute as inheritable (#111)
Tue, Oct 29, 3:00 PM
jordan_rose committed rG0ebc64037f65: [Lex] Expose a ModuleMacro's IdentifierInfo. (authored by jordan_rose).
[Lex] Expose a ModuleMacro's IdentifierInfo.
Tue, Oct 29, 2:56 PM
jordan_rose committed rGd0f81be7748d: Revert "Temporary hack to allow making progress on master-next build failures." (authored by jordan_rose).
Revert "Temporary hack to allow making progress on master-next build failures."
Tue, Oct 29, 2:56 PM
GitHub <noreply@github.com> committed rG64ad67b08af6: [APINotes] Always provide an unversioned SwiftName of some kind. (#81) (authored by jordan_rose).
[APINotes] Always provide an unversioned SwiftName of some kind. (#81)
Tue, Oct 29, 2:44 PM
GitHub <noreply@github.com> committed rGd32e2f273372: Merge pull request #79 from jrose-apple/enum-api-notes (authored by jordan_rose).
Merge pull request #79 from jrose-apple/enum-api-notes
Tue, Oct 29, 2:39 PM
jordan_rose committed rG5a375f34070f: [APINotes] Add 'EnumKind' as syntactic sugar. (authored by jordan_rose).
[APINotes] Add 'EnumKind' as syntactic sugar.
Tue, Oct 29, 2:39 PM
jordan_rose committed rG45050445b4b1: [APINotes] Add 'EnumExtensibility' and 'FlagEnum' API notes. (authored by jordan_rose).
[APINotes] Add 'EnumExtensibility' and 'FlagEnum' API notes.
Tue, Oct 29, 2:39 PM
GitHub <noreply@github.com> committed rG3ec8379f3527: [APINotes] Don't apply API notes to non-definitions of structs. (#69) (authored by jordan_rose).
[APINotes] Don't apply API notes to non-definitions of structs. (#69)
Tue, Oct 29, 2:32 PM
GitHub <noreply@github.com> committed rG585faeeb5621: [APINotes] Add a 'SwiftImportAsNonGeneric' entry for ObjC classes (#70) (authored by jordan_rose).
[APINotes] Add a 'SwiftImportAsNonGeneric' entry for ObjC classes (#70)
Tue, Oct 29, 2:21 PM
jordan_rose committed rG5ee3434bac9f: [APINotes] Remove VersionedInfoRole. (authored by jordan_rose).
[APINotes] Remove VersionedInfoRole.
Tue, Oct 29, 2:20 PM
GitHub <noreply@github.com> committed rG37f07d4d441c: Merge pull request #67 from jrose-apple/APINotes-cleanup (authored by jordan_rose).
Merge pull request #67 from jrose-apple/APINotes-cleanup
Tue, Oct 29, 2:20 PM
jordan_rose committed rG75d0e02ee279: Remove the attribute used by the FactoryAsInit API note. (authored by jordan_rose).
Remove the attribute used by the FactoryAsInit API note.
Tue, Oct 29, 2:20 PM
jordan_rose committed rG654e4a76ec35: [APINotes] Remove FactoryAsInit (superseded by SwiftName) (authored by jordan_rose).
[APINotes] Remove FactoryAsInit (superseded by SwiftName)
Tue, Oct 29, 2:20 PM
GitHub <noreply@github.com> committed rG4653f82a9959: [APINotes] Preserve attributes from inactive versions. (#53) (authored by jordan_rose).
[APINotes] Preserve attributes from inactive versions. (#53)
Tue, Oct 29, 2:19 PM
GitHub <noreply@github.com> committed rGa270e653f7de: Re-revert "ObjectiveC Generics: Start using ObjCTypeParamType." (#56) (authored by jordan_rose).
Re-revert "ObjectiveC Generics: Start using ObjCTypeParamType." (#56)
Tue, Oct 29, 2:12 PM
jordan_rose committed rG57046a8edb49: Fix warnings building Swift with swift-llvm with MSVC (#39) (authored by hughbe).
Fix warnings building Swift with swift-llvm with MSVC (#39)
Tue, Oct 29, 2:10 PM
GitHub <noreply@github.com> committed rG83be4cf8ce2b: Fix MSVC errors building SemaAPINotes with MSVC (#54) (authored by jordan_rose).
Fix MSVC errors building SemaAPINotes with MSVC (#54)
Tue, Oct 29, 2:10 PM
GitHub <noreply@github.com> committed rG09fd205a6c66: Re-apply "ObjectiveC Generics: Start using ObjCTypeParamType." (#51) (authored by jordan_rose).
Re-apply "ObjectiveC Generics: Start using ObjCTypeParamType." (#51)
Tue, Oct 29, 2:08 PM
GitHub <noreply@github.com> committed rGb99d56f576b1: [APINotes] Add missing include. (#49) (authored by jordan_rose).
[APINotes] Add missing include. (#49)
Tue, Oct 29, 2:07 PM
GitHub <noreply@github.com> committed rG2288a35a530b: [APINotes] Add a 'SwiftImportAsAccessors' entry for properties. (#39) (authored by jordan_rose).
[APINotes] Add a 'SwiftImportAsAccessors' entry for properties. (#39)
Tue, Oct 29, 2:02 PM
jordan_rose committed rG10eff17ffc1a: [APINotes] Add support for nullability on arrays. (authored by jordan_rose).
[APINotes] Add support for nullability on arrays.
Tue, Oct 29, 2:02 PM
jordan_rose committed rG6a06b7bcafa8: Merge remote-tracking branch 'llvm/master' into upstream-with-swift (authored by jordan_rose).
Merge remote-tracking branch 'llvm/master' into upstream-with-swift
Tue, Oct 29, 2:02 PM
GitHub <noreply@github.com> committed rG3a1210fa3393: [APINotes] Go with a slightly simpler overload. NFC. (#38) (authored by jordan_rose).
[APINotes] Go with a slightly simpler overload. NFC. (#38)
Tue, Oct 29, 2:02 PM
GitHub <noreply@github.com> committed rG15ec27b9be46: [APINotes] Update for upstream changes to llvm::BitstreamReader. (#37) (authored by jordan_rose).
[APINotes] Update for upstream changes to llvm::BitstreamReader. (#37)
Tue, Oct 29, 2:02 PM
jordan_rose committed rGc3322f807465: Remove llvm::Fixnum. Use llvm::PointerEmbeddedInt from now on. (authored by jordan_rose).
Remove llvm::Fixnum. Use llvm::PointerEmbeddedInt from now on.
Tue, Oct 29, 12:52 PM
jordan_rose committed rG4a4c6955aa84: Replaces uses of Fixnum with llvm::PointerEmbeddedInt. (authored by jordan_rose).
Replaces uses of Fixnum with llvm::PointerEmbeddedInt.
Tue, Oct 29, 12:52 PM
jordan_rose committed rG96ad82d49e7f: [ADT] Fix PointerEmbeddedInt when the underlying type is uintptr_t. (authored by jordan_rose).
[ADT] Fix PointerEmbeddedInt when the underlying type is uintptr_t.
Tue, Oct 29, 12:45 PM
jordan_rose committed rG002115512a6a: Add legal notice for pull requests and reference to contribution guidelines. (authored by jordan_rose).
Add legal notice for pull requests and reference to contribution guidelines.
Tue, Oct 29, 12:26 PM
jordan_rose committed rG34ce081b6367: Add legal notice for pull requests and reference to contribution guidelines. (authored by jordan_rose).
Add legal notice for pull requests and reference to contribution guidelines.
Tue, Oct 29, 12:26 PM

Oct 18 2019

jordan_rose added inline comments to D69148: Disable exit-on-SIGPIPE in lldb.
Oct 18 2019, 9:43 AM · Restricted Project, Restricted Project

Oct 17 2019

jordan_rose added inline comments to D69148: Disable exit-on-SIGPIPE in lldb.
Oct 17 2019, 5:09 PM · Restricted Project, Restricted Project

Oct 10 2019

jordan_rose committed rG7b5c8792431f: Get ClangdXPC.framework building (barely) with CMake's Xcode generator (authored by jordan_rose).
Get ClangdXPC.framework building (barely) with CMake's Xcode generator
Oct 10 2019, 6:26 PM
jordan_rose closed D68846: Do the bare minimum to get ClangdXPC.framework building with CMake's Xcode generator.

Committed in rCTE374494.

Oct 10 2019, 6:26 PM · Restricted Project
jordan_rose created D68846: Do the bare minimum to get ClangdXPC.framework building with CMake's Xcode generator.
Oct 10 2019, 5:58 PM · Restricted Project
jordan_rose committed rGaab67b571a3d: ADT: Save a word in every StringSet entry (authored by jordan_rose).
ADT: Save a word in every StringSet entry
Oct 10 2019, 1:26 PM
jordan_rose closed D68586: Save a word in every StringSet entry.

Committed in rL374440. I split the difference and put the EBO comment in the commit message.

Oct 10 2019, 1:25 PM · Restricted Project
jordan_rose added a comment to D68586: Save a word in every StringSet entry.

Any idea why MDString is friending an implementation detail like this? Should it be? Could we make it an actual private implementation detail so people can't do this?

Oct 10 2019, 1:25 PM · Restricted Project
jordan_rose added a reviewer for D68586: Save a word in every StringSet entry: dblaikie.
Oct 10 2019, 11:50 AM · Restricted Project

Oct 8 2019

jordan_rose committed rGcb8292274a22: Mark several PointerIntPair methods as lvalue-only (authored by jordan_rose).
Mark several PointerIntPair methods as lvalue-only
Oct 8 2019, 12:03 PM
jordan_rose closed D63945: Mark several PointerIntPair methods as lvalue-only.

Committed in rL374102.

Oct 8 2019, 12:03 PM · Restricted Project

Oct 7 2019

jordan_rose committed rGfdaa74217420: Second attempt to add iterator_range::empty() (authored by jordan_rose).
Second attempt to add iterator_range::empty()
Oct 7 2019, 10:17 PM
jordan_rose added a reviewer for D68044: [LitConfig] Silenced notes/warnings on quiet.: yln.
Oct 7 2019, 3:39 PM · Restricted Project
jordan_rose updated the diff for D68586: Save a word in every StringSet entry.

Fixed bad uses of StringSet, changed a friend from StringMapEntry to StringMapEntryStorage. The fact that I only had to do this in one place (and that one place is definitely doing something tricky) makes me still feel confident enough to make this change.

Oct 7 2019, 1:09 PM · Restricted Project
jordan_rose added a comment to D68586: Save a word in every StringSet entry.

Hm, doesn't quite work yet but I'll get there.

Oct 7 2019, 11:43 AM · Restricted Project
jordan_rose created D68586: Save a word in every StringSet entry.
Oct 7 2019, 11:40 AM · Restricted Project
jordan_rose closed D68439: Second attempt to add iterator_range::empty().

Committed in rL373935 (with the update for AMDGPURegisterBankInfo.cpp).

Oct 7 2019, 11:12 AM · Restricted Project

Oct 4 2019

jordan_rose committed rG5fd467feb813: [CMake] Clang: Don't use object libraries with Xcode (authored by jordan_rose).
[CMake] Clang: Don't use object libraries with Xcode
Oct 4 2019, 11:20 AM
jordan_rose closed D68430: Don't use object libraries with Xcode.

Committed as rC373769.

Oct 4 2019, 11:20 AM · Restricted Project
jordan_rose updated the diff for D68430: Don't use object libraries with Xcode.

Okay, having Xcode force-load the static libraries doesn't seem bad at all.

Oct 4 2019, 11:04 AM · Restricted Project
jordan_rose added a comment to D68430: Don't use object libraries with Xcode.

clang_cpp can't link the libraries "normally" because it has no unresolved symbols to force the contents of the libraries to link. I don't like it, but I think the best option is to disable clang_cpp under Xcode. You can add AND XCODE to the if on line 2 of clang/tools/clang-shlib/CMakeLists.txt, and that should do the trick.

Oct 4 2019, 10:33 AM · Restricted Project

Oct 3 2019

jordan_rose added a comment to rL361944: [ADT] add iterator_range::empty().

Okay, new patch set at D68439.

Oct 3 2019, 6:36 PM
jordan_rose created D68439: Second attempt to add iterator_range::empty().
Oct 3 2019, 6:36 PM · Restricted Project
jordan_rose added a comment to D68430: Don't use object libraries with Xcode.

I'm not quite sure what it's doing. The executable targets end up trying to link against the static libraries anyway, which of course haven't been built. It's possible that this is because the LIBTYPE is both STATIC and OBJECT and if it were just OBJECT we might be better off, but I'm not sure if Xcode's IDE features will be happy with a target that doesn't actually produce a library. I can try it if you want, though.

Oct 3 2019, 6:19 PM · Restricted Project
jordan_rose created D68430: Don't use object libraries with Xcode.
Oct 3 2019, 3:15 PM · Restricted Project

Oct 2 2019

jordan_rose added a comment to rL361944: [ADT] add iterator_range::empty().

I don't. I know Swift's (hopefully superfluous) version of the same code works fine on the MSVC's we support, though: https://github.com/apple/swift/blob/da1002025323cc4199439b10d4c7bac11322d22c/include/swift/Basic/STLExtras.h#L267

Oct 2 2019, 1:11 PM
jordan_rose added a comment to rL361944: [ADT] add iterator_range::empty().

I'd like to try adding this back. Do you remember what the failure was? Maybe we can try calling begin() and end() instead of using the fields directly?

Oct 2 2019, 11:12 AM

Sep 25 2019

jordan_rose added a comment to D68044: [LitConfig] Silenced notes/warnings on quiet..

Definitely in favor. :-)

Sep 25 2019, 1:26 PM · Restricted Project

Sep 3 2019

jordan_rose retitled D67138: Tweak StringRef operators for ever-so-slightly smaller assembly from Tweak StringRef operators for ever-so-slightly faster assembly to Tweak StringRef operators for ever-so-slightly smaller assembly.
Sep 3 2019, 6:20 PM · Restricted Project
jordan_rose created D67138: Tweak StringRef operators for ever-so-slightly smaller assembly.
Sep 3 2019, 6:20 PM · Restricted Project

Aug 16 2019

jordan_rose committed rGea0ace75e034: Fix llvm-config support for CMake build-mode-style builds (authored by jordan_rose).
Fix llvm-config support for CMake build-mode-style builds
Aug 16 2019, 10:18 AM
jordan_rose closed D66326: Fix llvm-config support for CMake build-mode-style builds.

Committed as rL369129.

Aug 16 2019, 10:17 AM · Restricted Project
jordan_rose added a comment to D66326: Fix llvm-config support for CMake build-mode-style builds.

libcxx is using llvm-config to find the CMake exports; that's actually what prompted this change.

Aug 16 2019, 10:17 AM · Restricted Project

Aug 15 2019

jordan_rose created D66326: Fix llvm-config support for CMake build-mode-style builds.
Aug 15 2019, 5:27 PM · Restricted Project
jordan_rose added inline comments to D66326: Fix llvm-config support for CMake build-mode-style builds.
Aug 15 2019, 5:27 PM · Restricted Project

Jul 25 2019

jordan_rose added a comment to D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.

Sorry, am I missing something? Such a union would've been either ill-formed or unavailable in ARC (depending on where it was declared) before this recent work.

Jul 25 2019, 11:50 AM · Restricted Project, Restricted Project
jordan_rose added a comment to D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.

I'm personally still of the opinion that allowing non-trivial fields in unions was a mistake, but it's too late to change that as well.

Jul 25 2019, 10:26 AM · Restricted Project, Restricted Project
jordan_rose added a comment to D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.

These were unavailable in system headers before because otherwise we would've had to make them invalid. Since these unions are no longer otherwise invalid, there shouldn't be a problem with allowing them in system headers, and in fact making the semantics vary that way seems quite problematic. Now, specific *uses* in system headers might still appear to be invalid — e.g. an ObjC ivar of type union { __strong id x; } — and the right behavior is definitely that those use sites should be marked as invalid instead of refusing to compile the system header.

Jul 25 2019, 10:26 AM · Restricted Project, Restricted Project

Jul 24 2019

jordan_rose added inline comments to D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.
Jul 24 2019, 5:34 PM · Restricted Project, Restricted Project
jordan_rose added a comment to D65235: CrashHandler: be careful about crashing while handling.

Sure, I guess. I suspect most crashes-while-crashing are from the PrettyStackTrace machinery, not these allocations, but you're right that we can get a partial string out of it if it's short enough.

Jul 24 2019, 12:03 PM · Restricted Project
jordan_rose added a comment to D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows.

Oops. It looks like there's another place where this pattern shows up (see rC139382). The other one should probably be changed as well.

Jul 24 2019, 10:22 AM · Restricted Project

Jul 18 2019

jordan_rose closed D64940: FileSystem: Check for DTTOIF alone, not _DIRENT_HAVE_D_TYPE.

Committed as rL366486.

Jul 18 2019, 1:43 PM · Restricted Project
jordan_rose committed rG887d31cceee2: FileSystem: Check for DTTOIF alone, not _DIRENT_HAVE_D_TYPE (authored by jordan_rose).
FileSystem: Check for DTTOIF alone, not _DIRENT_HAVE_D_TYPE
Jul 18 2019, 1:08 PM
jordan_rose created D64940: FileSystem: Check for DTTOIF alone, not _DIRENT_HAVE_D_TYPE.
Jul 18 2019, 11:58 AM · Restricted Project

Jul 17 2019

Herald added a project to D51918: [Support] sys::fs::directory_entry includes the file_type.: Restricted Project.
Jul 17 2019, 3:51 PM · Restricted Project

Jul 12 2019

jordan_rose committed rGbe28cddeeaa6: Support for dumping current PrettyStackTrace on SIGINFO (Ctrl-T) (authored by jordan_rose).
Support for dumping current PrettyStackTrace on SIGINFO (Ctrl-T)
Jul 12 2019, 9:06 AM