Page MenuHomePhabricator
Feed Advanced Search

Today

cjdb added inline comments to D101922: [libcxx][iterator] adds `std::ranges::advance`.
Fri, May 14, 10:47 AM · Restricted Project
cjdb updated the diff for D101922: [libcxx][iterator] adds `std::ranges::advance`.

Applies feedback from @ldionne:

Fri, May 14, 10:45 AM · Restricted Project

Yesterday

cjdb requested review of D102468: [libcxx][ranges] makes `basic_string_view` and `span` satisfy concept view.
Thu, May 13, 11:22 PM · Restricted Project
cjdb added inline comments to D102434: [libcxx][ranges] adds concept `sized_range` and cleans up `ranges::size`.
Thu, May 13, 9:12 PM · Restricted Project
cjdb added inline comments to D102434: [libcxx][ranges] adds concept `sized_range` and cleans up `ranges::size`.
Thu, May 13, 4:26 PM · Restricted Project
cjdb added inline comments to D101396: [libcxx][ranges] Add `contiguous_iterator`..
Thu, May 13, 2:40 PM · Restricted Project
cjdb requested review of D102434: [libcxx][ranges] adds concept `sized_range` and cleans up `ranges::size`.
Thu, May 13, 12:36 PM · Restricted Project
cjdb requested changes to D102426: [libcxx][ranges] Implement `ranges::borrowed_range`..

LGTM overall. Please don't forget the conformance tests!

Thu, May 13, 10:56 AM · Restricted Project
cjdb accepted D102414: [libc++] Improve make_string test support..
Thu, May 13, 9:35 AM · Restricted Project
cjdb updated the diff for D80891: [libcxx] adds consistent comparison for `basic_string_view`.

rebases to fix CI (and revert local experiment that made its way on to Phab)

Thu, May 13, 8:59 AM · Restricted Project

Wed, May 12

cjdb updated the diff for D80891: [libcxx] adds consistent comparison for `basic_string_view`.

rebases to activate CI

Wed, May 12, 10:28 PM · Restricted Project
cjdb committed rG46c17429bc86: [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain (authored by cjdb).
[libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain
Wed, May 12, 5:46 PM
cjdb closed D101708: [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain.
Wed, May 12, 5:46 PM · Restricted Project
cjdb updated the diff for D101708: [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain.

tries to get CI on AppleClang working one more

Wed, May 12, 1:58 PM · Restricted Project
cjdb added inline comments to D80895: [libcxx] adds consistent comparison for `basic_string`.
Wed, May 12, 1:45 PM · Restricted Project
cjdb updated the diff for D101708: [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain.

applies @Mordante's offline feedback to fix hack

Wed, May 12, 10:44 AM · Restricted Project
cjdb added inline comments to D80895: [libcxx] adds consistent comparison for `basic_string`.
Wed, May 12, 10:35 AM · Restricted Project
cjdb updated subscribers of D102332: [libc++][nfc] remove duplicated __to_unsigned..
Wed, May 12, 9:40 AM · Restricted Project
cjdb added a comment to D102332: [libc++][nfc] remove duplicated __to_unsigned..

to-unsigned-like/ is named thusly because it works with make-unsigned-like-t//, which is exposition-only transformation that could be make_unsigned_t or some unspecified thing if the type parameter isn't an integral. Even though we don't have any such types today, I'm not confident we won't in the future, and think both names should be kept.

Wed, May 12, 9:07 AM · Restricted Project

Tue, May 11

cjdb added inline comments to D101708: [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain.
Tue, May 11, 10:17 PM · Restricted Project
cjdb updated the diff for D101708: [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain.

ensures 0L fails

Tue, May 11, 10:16 PM · Restricted Project
cjdb added inline comments to D80895: [libcxx] adds consistent comparison for `basic_string`.
Tue, May 11, 7:05 PM · Restricted Project
cjdb added inline comments to D102028: [libcxx][ranges] Implement views::all..
Tue, May 11, 4:42 PM · Restricted Project
cjdb added inline comments to D101476: [libcxx][ranges] Add ranges::data CPO..
Tue, May 11, 11:39 AM · Restricted Project
cjdb added a comment to D80895: [libcxx] adds consistent comparison for `basic_string`.

@cjdb: I think you should go ahead and land the additions to "libcxx/test/std/strings/basic.string/string.nonmembers/" (other than ".../string_opcmp/", obviously). These look like good additions to the test suite, and should pass both before and after your spaceship-related changes.

Tue, May 11, 11:35 AM · Restricted Project
cjdb updated the diff for D101708: [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain.

Turns TEST_OP into TEST_FAIL and adds TEST_PASS (requested by @Mordante)

Tue, May 11, 11:18 AM · Restricted Project
cjdb updated the diff for D80895: [libcxx] adds consistent comparison for `basic_string`.

rebases to activate CI and get on people's radar

Tue, May 11, 10:39 AM · Restricted Project
cjdb edited reviewers for D80895: [libcxx] adds consistent comparison for `basic_string`, added: curdeius, Mordante, zoecarver, Quuxplusone; removed: mclow.lists, jfb, mpark.
Tue, May 11, 10:39 AM · Restricted Project
cjdb added a comment to D101708: [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain.

Ping

Tue, May 11, 9:32 AM · Restricted Project

Mon, May 10

cjdb committed rG578d09c1b195: [libcxx] deprecates/removes `std::raw_storage_iterator` (authored by cjdb).
[libcxx] deprecates/removes `std::raw_storage_iterator`
Mon, May 10, 11:44 PM
cjdb closed D101730: [libcxx] deprecates/removes `std::raw_storage_iterator`.
Mon, May 10, 11:44 PM · Restricted Project
cjdb updated the diff for D80891: [libcxx] adds consistent comparison for `basic_string_view`.

rebases to activate CI

Mon, May 10, 11:43 PM · Restricted Project
cjdb committed rG9eb0969a767b: [libcxx] makes comparison operators for `std::*_ordering` types hidden friends (authored by cjdb).
[libcxx] makes comparison operators for `std::*_ordering` types hidden friends
Mon, May 10, 11:42 PM
cjdb updated the diff for D101708: [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain.

rebases to activate CI

Mon, May 10, 11:42 PM · Restricted Project
cjdb closed D101707: [libcxx][nfc] makes comparison operators for `std::*_ordering` types hidden friends.
Mon, May 10, 11:42 PM · Restricted Project
cjdb committed rG20506fb1f361: [libcxx] removes operator!= and globally guards against no spaceship operator (authored by cjdb).
[libcxx] removes operator!= and globally guards against no spaceship operator
Mon, May 10, 11:42 PM
cjdb closed D100342: [libcxx] removes operator!= and globally guards against no spaceship operator.
Mon, May 10, 11:41 PM · Restricted Project
cjdb updated the diff for D101707: [libcxx][nfc] makes comparison operators for `std::*_ordering` types hidden friends.

updates commit message

Mon, May 10, 4:07 PM · Restricted Project
cjdb updated the diff for D100342: [libcxx] removes operator!= and globally guards against no spaceship operator.

adds // UNSUPPORTED: apple-clang-9, apple-clang-10, apple-clang-11, apple-clang-12.0.0 to the files failing CI (AppleClang <12.0.1 seems to not work)

Mon, May 10, 4:06 PM · Restricted Project
cjdb requested changes to D101476: [libcxx][ranges] Add ranges::data CPO..
Mon, May 10, 3:56 PM · Restricted Project
cjdb added a comment to D101730: [libcxx] deprecates/removes `std::raw_storage_iterator`.

Feedback addressed.

Mon, May 10, 3:18 PM · Restricted Project
cjdb updated the diff for D101730: [libcxx] deprecates/removes `std::raw_storage_iterator`.

applies all of @Quuxplusone's feedback

Mon, May 10, 3:18 PM · Restricted Project
cjdb committed rG4ff2fe1df0ce: [libcxx] removes `weak_equality` and `strong_equality` from <compare> (authored by cjdb).
[libcxx] removes `weak_equality` and `strong_equality` from <compare>
Mon, May 10, 1:46 PM
cjdb closed D100283: [libcxx] removes `weak_equality` and `strong_equality` from <compare>.
Mon, May 10, 1:46 PM · Restricted Project
cjdb updated the diff for D80891: [libcxx] adds consistent comparison for `basic_string_view`.

rebases to activate CI

Mon, May 10, 10:39 AM · Restricted Project
cjdb updated the diff for D101708: [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain.

rebases to activate CI

Mon, May 10, 10:36 AM · Restricted Project
cjdb updated the diff for D101707: [libcxx][nfc] makes comparison operators for `std::*_ordering` types hidden friends.

rebases to activate CI

Mon, May 10, 10:34 AM · Restricted Project
cjdb updated the diff for D100342: [libcxx] removes operator!= and globally guards against no spaceship operator.

rebases to activate CI

Mon, May 10, 10:33 AM · Restricted Project
cjdb updated the diff for D100283: [libcxx] removes `weak_equality` and `strong_equality` from <compare>.

rebases to activate CI

Mon, May 10, 10:33 AM · Restricted Project
cjdb updated subscribers of D102037: [libcxx][views] Add drop_view..
Mon, May 10, 9:39 AM · Restricted Project
cjdb added inline comments to D102121: [libcxx][ranges] adds _`non-propagating-cache`_.
Mon, May 10, 9:23 AM · Restricted Project

Sun, May 9

cjdb added a comment to D102121: [libcxx][ranges] adds _`non-propagating-cache`_.

Would you mind documenting the state of the paper in the header like in the format header?

Sun, May 9, 4:11 PM · Restricted Project
cjdb updated the diff for D102121: [libcxx][ranges] adds _`non-propagating-cache`_.

Can you update the status papers documentation and add a warning based on which version of the paper this feature has been implemented? If the wording changes before the paper is accepted we need to update our implementation to match the final wording.

Sun, May 9, 2:06 PM · Restricted Project
cjdb updated the diff for D102119: [libcxx][optional] adds missing constexpr operations.

updates C++2b status paper

Sun, May 9, 1:59 PM · Restricted Project
cjdb requested review of D102135: [libcxx][ranges] adds _`semiregular-box`_.
Sun, May 9, 10:11 AM · Restricted Project

Sat, May 8

cjdb updated the diff for D102121: [libcxx][ranges] adds _`non-propagating-cache`_.

rebases to activate CI

Sat, May 8, 9:42 PM · Restricted Project
cjdb updated the diff for D102119: [libcxx][optional] adds missing constexpr operations.
  • disables GCC for constexpr tests (should this be temporary or permanent?)
  • removes tests using is_literal_type since that was deprecated in C++17 and is to be removed in C++20
Sat, May 8, 9:42 PM · Restricted Project
cjdb updated the diff for D102119: [libcxx][optional] adds missing constexpr operations.
  • Gets C++17 mode working.
  • GCC 10 doesn't like this patch, but GCC 11 mostly does
Sat, May 8, 7:58 PM · Restricted Project
cjdb updated the diff for D102119: [libcxx][optional] adds missing constexpr operations.

replaces placement new with std::construct_at in C++20

Sat, May 8, 7:14 PM · Restricted Project
cjdb added inline comments to D102121: [libcxx][ranges] adds _`non-propagating-cache`_.
Sat, May 8, 7:01 PM · Restricted Project
cjdb requested review of D102121: [libcxx][ranges] adds _`non-propagating-cache`_.
Sat, May 8, 6:58 PM · Restricted Project
cjdb requested review of D102119: [libcxx][optional] adds missing constexpr operations.
Sat, May 8, 6:43 PM · Restricted Project
cjdb added inline comments to D102037: [libcxx][views] Add drop_view..
Sat, May 8, 12:10 PM · Restricted Project
cjdb updated subscribers of D101922: [libcxx][iterator] adds `std::ranges::advance`.
Sat, May 8, 12:09 PM · Restricted Project
cjdb added inline comments to D101922: [libcxx][iterator] adds `std::ranges::advance`.
Sat, May 8, 10:35 AM · Restricted Project

Fri, May 7

cjdb commandeered D101193: [libcxx][ranges] Add ranges::empty CPO..

Commandeering with @zoecarver's permission.

Fri, May 7, 4:47 PM · Restricted Project
cjdb requested changes to D102037: [libcxx][views] Add drop_view..
Fri, May 7, 11:06 AM · Restricted Project
cjdb added inline comments to D101922: [libcxx][iterator] adds `std::ranges::advance`.
Fri, May 7, 9:38 AM · Restricted Project

Thu, May 6

cjdb updated the diff for D101922: [libcxx][iterator] adds `std::ranges::advance`.

applies feedback from @Mordante:

  • replaces leftover instances of "functionish" with "function_like"
  • changes -__n to explicit two's complement
Thu, May 6, 10:27 PM · Restricted Project
cjdb added inline comments to D102006: [libcxx][ranges] Add range.subrange..
Thu, May 6, 10:20 PM · Restricted Project
cjdb added inline comments to D101737: [libcxx] Implement view.interface..
Thu, May 6, 9:43 PM · Restricted Project
cjdb added inline comments to D101922: [libcxx][iterator] adds `std::ranges::advance`.
Thu, May 6, 9:38 PM · Restricted Project
cjdb requested changes to D102037: [libcxx][views] Add drop_view..

Overall, this is great! Sadly, I can't LGTM till caching is implemented, but I think we'll be good to land this sometime next week :-)

Thu, May 6, 7:12 PM · Restricted Project
cjdb added inline comments to D101193: [libcxx][ranges] Add ranges::empty CPO..
Thu, May 6, 3:59 PM · Restricted Project
cjdb added a comment to D101193: [libcxx][ranges] Add ranges::empty CPO..

Ping. Can this be merged or is there a blocker besides CI?

Thu, May 6, 11:49 AM · Restricted Project
cjdb added inline comments to D102006: [libcxx][ranges] Add range.subrange..
Thu, May 6, 10:16 AM · Restricted Project
cjdb updated the diff for D101922: [libcxx][iterator] adds `std::ranges::advance`.

removes 0wcp

Thu, May 6, 10:14 AM · Restricted Project
cjdb added a comment to D101922: [libcxx][iterator] adds `std::ranges::advance`.

Is the synopsis up to date?

Thu, May 6, 10:11 AM · Restricted Project
cjdb updated the diff for D101922: [libcxx][iterator] adds `std::ranges::advance`.

responds to comments from @Mordante

Thu, May 6, 10:11 AM · Restricted Project
cjdb added inline comments to D101922: [libcxx][iterator] adds `std::ranges::advance`.
Thu, May 6, 9:17 AM · Restricted Project

Wed, May 5

cjdb added inline comments to D101922: [libcxx][iterator] adds `std::ranges::advance`.
Wed, May 5, 2:31 PM · Restricted Project
cjdb added inline comments to D101922: [libcxx][iterator] adds `std::ranges::advance`.
Wed, May 5, 12:49 PM · Restricted Project
cjdb updated the diff for D101922: [libcxx][iterator] adds `std::ranges::advance`.

removes a different 0wcp

Wed, May 5, 9:55 AM · Restricted Project
cjdb added inline comments to D101922: [libcxx][iterator] adds `std::ranges::advance`.
Wed, May 5, 9:52 AM · Restricted Project
cjdb updated the diff for D101922: [libcxx][iterator] adds `std::ranges::advance`.

removes 0wcp

Wed, May 5, 9:44 AM · Restricted Project
cjdb requested review of D101922: [libcxx][iterator] adds `std::ranges::advance`.
Wed, May 5, 9:43 AM · Restricted Project

Tue, May 4

cjdb added inline comments to D101316: [libcxx][ranges] Add `random_access_{iterator,range}`..
Tue, May 4, 3:56 PM · Restricted Project
cjdb planned changes to D101729: [libcxx] deprecates `std::iterator` and removes it as a base class.

Haven't had time to respond to changes (and this is lowish in my p-queue).

Tue, May 4, 1:39 PM · Restricted Project
cjdb planned changes to D80895: [libcxx] adds consistent comparison for `basic_string`.

Needs rebase, etc.

Tue, May 4, 1:37 PM · Restricted Project
cjdb added inline comments to D101316: [libcxx][ranges] Add `random_access_{iterator,range}`..
Tue, May 4, 10:44 AM · Restricted Project
cjdb added inline comments to D101316: [libcxx][ranges] Add `random_access_{iterator,range}`..
Tue, May 4, 10:16 AM · Restricted Project
cjdb added a comment to D101845: [libcxx][iterator][nfc] acquires lock for working on [range.iter.ops].

Wouldn't it be easier to claim these without a review?
The section changes look good to me.

Tue, May 4, 10:00 AM · Restricted Project
cjdb added inline comments to D101316: [libcxx][ranges] Add `random_access_{iterator,range}`..
Tue, May 4, 9:58 AM · Restricted Project
cjdb requested review of D101845: [libcxx][iterator][nfc] acquires lock for working on [range.iter.ops].
Tue, May 4, 9:33 AM · Restricted Project

Mon, May 3

cjdb added inline comments to D101316: [libcxx][ranges] Add `random_access_{iterator,range}`..
Mon, May 3, 4:13 PM · Restricted Project
cjdb committed rG9c5d86aac505: [libcxx][iterator][ranges] adds `bidirectional_iterator` and… (authored by cjdb).
[libcxx][iterator][ranges] adds `bidirectional_iterator` and…
Mon, May 3, 2:25 PM
cjdb closed D100278: [libcxx][iterator][ranges] adds `bidirectional_iterator` and `bidirectional_range`.
Mon, May 3, 2:25 PM · Restricted Project
cjdb committed rGfa3e26266cd4: [libcxx][iterator][ranges] adds `forward_iterator` and `forward_range` (authored by cjdb).
[libcxx][iterator][ranges] adds `forward_iterator` and `forward_range`
Mon, May 3, 1:47 PM
cjdb closed D100275: [libcxx][iterator][ranges] adds `forward_iterator` and `forward_range`.
Mon, May 3, 1:47 PM · Restricted Project
cjdb added inline comments to D101737: [libcxx] Implement view.interface..
Mon, May 3, 12:48 PM · Restricted Project