Page MenuHomePhabricator
Feed Advanced Search

Nov 6 2019

jkorous added inline comments to D69648: Add VFS support for sanitizers' blacklist' 2.
Nov 6 2019, 11:13 AM · Restricted Project, Restricted Project

Oct 31 2019

jkorous updated the diff for D69648: Add VFS support for sanitizers' blacklist' 2.
Oct 31 2019, 5:03 PM · Restricted Project, Restricted Project
jkorous added a comment to D69648: Add VFS support for sanitizers' blacklist' 2.

I see what you mean - I didn't realize I could use the real fs as the default arg.
I still feel that handling files is out of scope for SpecialCaseList but I don't think those couple lines are a big deal either way - updating the patch now.

Oct 31 2019, 4:08 PM · Restricted Project, Restricted Project
jkorous updated the diff for D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

Added a cc1 command line option -fsanitize-system-blacklist so driver can tell cc1 which blacklists are user-specified and which are system ones.

Oct 31 2019, 4:07 PM · Restricted Project
jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

@eugenis Does this make your workaround obsolete?

Oct 31 2019, 4:07 PM · Restricted Project
jkorous added inline comments to D69648: Add VFS support for sanitizers' blacklist' 2.
Oct 31 2019, 12:10 PM · Restricted Project, Restricted Project

Oct 30 2019

jkorous added inline comments to D69648: Add VFS support for sanitizers' blacklist' 2.
Oct 30 2019, 3:54 PM · Restricted Project, Restricted Project
jkorous created D69648: Add VFS support for sanitizers' blacklist' 2.
Oct 30 2019, 3:48 PM · Restricted Project, Restricted Project

Oct 29 2019

jkorous committed rG071567bc7e78: Merge branch 'conflict_resolution' into upstream-with-swift (authored by jkorous).
Merge branch 'conflict_resolution' into upstream-with-swift
Oct 29 2019, 4:00 PM
jkorous committed rG14152fd55ee4: Merge remote-tracking branch 'llvm.org/master' into 'upstream-with-swift' (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into 'upstream-with-swift'
Oct 29 2019, 4:00 PM
jkorous committed rG241651beca5b: [clang-apply-replacements] Fix missing dependency - clangToolingRefactoring (authored by jkorous).
[clang-apply-replacements] Fix missing dependency - clangToolingRefactoring
Oct 29 2019, 12:19 PM
jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

Ping.

Oct 29 2019, 10:36 AM · Restricted Project

Oct 21 2019

jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

I am trying to solve two different things here.

Oct 21 2019, 6:20 PM · Restricted Project
jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

@pcc since you reviewed the above-mentioned patch - could you please take a look at this one too?

Oct 21 2019, 5:48 PM · Restricted Project
jkorous created D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.
Oct 21 2019, 5:39 PM · Restricted Project

Oct 17 2019

jkorous added inline comments to D69122: Add support to find out resource dir and add it as compilation args.
Oct 17 2019, 3:25 PM · Restricted Project
jkorous added a comment to D69090: [Try 2] Include sanitize blacklist and other extra deps as part of scan-deps output.

I think you could've just used CHECK-DAG to fix the tests. It *might* be a bit more robust. Although just reordering checks seems perfectly fine too.
https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-dag-directive

Oct 17 2019, 11:40 AM · Restricted Project

Oct 16 2019

jkorous accepted D69017: Include sanitize blacklist and other extra deps as part of scan-deps output.

Looks great! Thanks!

Oct 16 2019, 4:41 PM · Restricted Project

Oct 15 2019

jkorous committed rG9e49adc97574: Fix Driver/working-directory.c test (authored by jkorous).
Fix Driver/working-directory.c test
Oct 15 2019, 11:08 AM
jkorous committed rL374929: Fix Driver/working-directory.c test.
Fix Driver/working-directory.c test
Oct 15 2019, 11:08 AM
jkorous committed rGf8907fa6f4b7: Reland [Driver] Fix -working-directory issues (authored by jkorous).
Reland [Driver] Fix -working-directory issues
Oct 15 2019, 10:58 AM
jkorous added a reverting change for rG999f8a7416f8: Revert r361885 "[Driver] Fix -working-directory issues": rGf8907fa6f4b7: Reland [Driver] Fix -working-directory issues.
Oct 15 2019, 10:58 AM
jkorous committed rL374926: Reland [Driver] Fix -working-directory issues.
Reland [Driver] Fix -working-directory issues
Oct 15 2019, 10:58 AM

Oct 14 2019

jkorous committed rG9d0a84f5f3d3: [NFC] Fix ClangScanDeps/static-analyzer.c test on Windows (authored by jkorous).
[NFC] Fix ClangScanDeps/static-analyzer.c test on Windows
Oct 14 2019, 2:12 PM
jkorous committed rL374821: [NFC] Fix ClangScanDeps/static-analyzer.c test on Windows.
[NFC] Fix ClangScanDeps/static-analyzer.c test on Windows
Oct 14 2019, 2:04 PM
jkorous committed rGc5d14b5c6fa9: [clang-scan-deps] Support for clang --analyze in clang-scan-deps (authored by jkorous).
[clang-scan-deps] Support for clang --analyze in clang-scan-deps
Oct 14 2019, 1:16 PM
jkorous closed D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps.
Oct 14 2019, 1:16 PM · Restricted Project, Restricted Project
jkorous committed rL374815: [clang-scan-deps] Support for clang --analyze in clang-scan-deps.
[clang-scan-deps] Support for clang --analyze in clang-scan-deps
Oct 14 2019, 1:16 PM

Oct 8 2019

jkorous added a comment to D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps.

@NoQ , @hiraditya any suggestions for the option name and/or description?

Oct 8 2019, 3:28 PM · Restricted Project, Restricted Project
jkorous committed rG135f2f01a2d9: [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows (authored by jkorous).
[NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows
Oct 8 2019, 11:16 AM
jkorous committed rL374098: [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows.
[NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows
Oct 8 2019, 11:16 AM

Oct 7 2019

jkorous committed rGd6609a404fec: [NFC] Fix ubsan-blacklist test (authored by jkorous).
[NFC] Fix ubsan-blacklist test
Oct 7 2019, 10:26 PM
jkorous committed rL374011: [NFC] Fix ubsan-blacklist test.
[NFC] Fix ubsan-blacklist test
Oct 7 2019, 10:26 PM
jkorous committed rG3dab5e825b8c: Reland 'Add VFS support for sanitizers' blacklist' (authored by jkorous).
Reland 'Add VFS support for sanitizers' blacklist'
Oct 7 2019, 10:26 PM
jkorous committed rL374006: Reland 'Add VFS support for sanitizers' blacklist'.
Reland 'Add VFS support for sanitizers' blacklist'
Oct 7 2019, 10:25 PM
jkorous added a reverting change for rG96ac97a42132: Add VFS support for sanitizers' blacklist: rG40943b5193f2: Revert "Add VFS support for sanitizers' blacklist".
Oct 7 2019, 10:25 PM
jkorous committed rG40943b5193f2: Revert "Add VFS support for sanitizers' blacklist" (authored by jkorous).
Revert "Add VFS support for sanitizers' blacklist"
Oct 7 2019, 10:25 PM
jkorous committed rL373999: Revert "Add VFS support for sanitizers' blacklist".
Revert "Add VFS support for sanitizers' blacklist"
Oct 7 2019, 10:25 PM
jkorous committed rG96ac97a42132: Add VFS support for sanitizers' blacklist (authored by jkorous).
Add VFS support for sanitizers' blacklist
Oct 7 2019, 10:22 PM
jkorous committed rL373977: Add VFS support for sanitizers' blacklist.
Add VFS support for sanitizers' blacklist
Oct 7 2019, 10:22 PM
jkorous closed D67742: Add VFS support for sanitizers' blacklist.
Oct 7 2019, 10:22 PM · Restricted Project
jkorous added inline comments to D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps.
Oct 7 2019, 7:41 PM · Restricted Project, Restricted Project
jkorous retitled D67742: Add VFS support for sanitizers' blacklist from [WIP] Add VFS support for sanitizers' blacklist to Add VFS support for sanitizers' blacklist.
Oct 7 2019, 3:21 PM · Restricted Project
jkorous added inline comments to D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps.
Oct 7 2019, 2:18 PM · Restricted Project, Restricted Project
jkorous updated the diff for D67742: Add VFS support for sanitizers' blacklist.

Addressed comments.

Oct 7 2019, 2:16 PM · Restricted Project
jkorous added inline comments to D67742: Add VFS support for sanitizers' blacklist.
Oct 7 2019, 2:14 PM · Restricted Project
jkorous updated the diff for D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps.

Addressed comment.

Oct 7 2019, 11:04 AM · Restricted Project, Restricted Project

Sep 27 2019

jkorous added a comment to D66764: [clang][index] Move ParsedSrcLocationsTracker to libIndex.

Sorry, I missed your reply.

Sep 27 2019, 1:33 PM

Sep 26 2019

jkorous updated the diff for D64384: [WIP] Index-while-building.

Rebased on top of current master and also tentatively on top of SerializablePathCollection (previously PathStorage, PathIndexer) from https://reviews.llvm.org/D66854

Sep 26 2019, 5:10 PM · Restricted Project
jkorous added a parent revision for D64384: [WIP] Index-while-building: D68111: [Frontend] Add ASTConsumerInjector.
Sep 26 2019, 5:07 PM · Restricted Project
jkorous added a child revision for D68111: [Frontend] Add ASTConsumerInjector: D64384: [WIP] Index-while-building.
Sep 26 2019, 5:07 PM
jkorous created D68111: [Frontend] Add ASTConsumerInjector.
Sep 26 2019, 5:06 PM
jkorous added inline comments to D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps.
Sep 26 2019, 1:22 PM · Restricted Project, Restricted Project
jkorous updated the diff for D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps.

Adressed comments.

Sep 26 2019, 1:22 PM · Restricted Project, Restricted Project
jkorous created D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps.
Sep 26 2019, 10:41 AM · Restricted Project, Restricted Project

Sep 23 2019

jkorous committed rGb26e9e2a8f18: Revert "[static analyzer] Define __clang_analyzer__ macro in driver" (authored by jkorous).
Revert "[static analyzer] Define __clang_analyzer__ macro in driver"
Sep 23 2019, 8:24 PM
jkorous added a reverting change for rGfbd13570b0d5: [static analyzer] Define __clang_analyzer__ macro in driver: rGb26e9e2a8f18: Revert "[static analyzer] Define __clang_analyzer__ macro in driver".
Sep 23 2019, 8:24 PM
jkorous committed rG5e61895aed1d: Revert "[lit] Add -D__clang_analyzer__ to clang_analyze_cc1" (authored by jkorous).
Revert "[lit] Add -D__clang_analyzer__ to clang_analyze_cc1"
Sep 23 2019, 8:21 PM
jkorous added a reverting change for rG4185460f758b: [lit] Add -D__clang_analyzer__ to clang_analyze_cc1: rG5e61895aed1d: Revert "[lit] Add -D__clang_analyzer__ to clang_analyze_cc1".
Sep 23 2019, 8:21 PM
jkorous committed rL372687: Revert "[static analyzer] Define __clang_analyzer__ macro in driver".
Revert "[static analyzer] Define __clang_analyzer__ macro in driver"
Sep 23 2019, 8:21 PM
jkorous committed rL372686: Revert "[lit] Add -D__clang_analyzer__ to clang_analyze_cc1".
Revert "[lit] Add -D__clang_analyzer__ to clang_analyze_cc1"
Sep 23 2019, 8:20 PM
jkorous committed rG5199aa88fe6c: Revert "[static analyzer][test] Test directly that driver sets… (authored by jkorous).
Revert "[static analyzer][test] Test directly that driver sets…
Sep 23 2019, 8:20 PM
jkorous added a reverting change for rGc7541903d727: [static analyzer][test] Test directly that driver sets D__clang_analyzer__: rG5199aa88fe6c: Revert "[static analyzer][test] Test directly that driver sets….
Sep 23 2019, 8:20 PM
jkorous committed rL372685: Revert "[static analyzer][test] Test directly that driver sets….
Revert "[static analyzer][test] Test directly that driver sets…
Sep 23 2019, 8:20 PM
jkorous committed rGc7541903d727: [static analyzer][test] Test directly that driver sets D__clang_analyzer__ (authored by jkorous).
[static analyzer][test] Test directly that driver sets D__clang_analyzer__
Sep 23 2019, 7:08 PM
jkorous committed rL372683: [static analyzer][test] Test directly that driver sets D__clang_analyzer__.
[static analyzer][test] Test directly that driver sets D__clang_analyzer__
Sep 23 2019, 7:05 PM
jkorous committed rG4185460f758b: [lit] Add -D__clang_analyzer__ to clang_analyze_cc1 (authored by jkorous).
[lit] Add -D__clang_analyzer__ to clang_analyze_cc1
Sep 23 2019, 6:59 PM
jkorous committed rL372682: [lit] Add -D__clang_analyzer__ to clang_analyze_cc1.
[lit] Add -D__clang_analyzer__ to clang_analyze_cc1
Sep 23 2019, 6:59 PM
jkorous added inline comments to D67938: [static analyzer] Define __clang_analyzer__ macro in driver.
Sep 23 2019, 6:30 PM · Restricted Project
jkorous committed rG72b9049b43c1: [static analyzer] Remove --analyze-auto (authored by jkorous).
[static analyzer] Remove --analyze-auto
Sep 23 2019, 5:37 PM
jkorous committed rL372680: [static analyzer] Remove --analyze-auto.
[static analyzer] Remove --analyze-auto
Sep 23 2019, 5:36 PM
jkorous closed D67934: [static-analyzer] Remove --analyze-auto.
Sep 23 2019, 5:36 PM · Restricted Project
jkorous committed rGfbd13570b0d5: [static analyzer] Define __clang_analyzer__ macro in driver (authored by jkorous).
[static analyzer] Define __clang_analyzer__ macro in driver
Sep 23 2019, 5:34 PM
jkorous committed rL372679: [static analyzer] Define __clang_analyzer__ macro in driver.
[static analyzer] Define __clang_analyzer__ macro in driver
Sep 23 2019, 5:32 PM
jkorous closed D67938: [static analyzer] Define __clang_analyzer__ macro in driver.
Sep 23 2019, 5:32 PM · Restricted Project
jkorous updated the diff for D67938: [static analyzer] Define __clang_analyzer__ macro in driver.

Added the test.

Sep 23 2019, 5:21 PM · Restricted Project
jkorous added a reviewer for D67938: [static analyzer] Define __clang_analyzer__ macro in driver: arphaman.
Sep 23 2019, 4:02 PM · Restricted Project
jkorous added a comment to D67682: [WIP] Add support for preprocessing sources for analyzer.

Anyways, I created a separate patch:
https://reviews.llvm.org/D67938

Sep 23 2019, 4:02 PM
jkorous created D67938: [static analyzer] Define __clang_analyzer__ macro in driver.
Sep 23 2019, 3:58 PM · Restricted Project
jkorous added a comment to D67682: [WIP] Add support for preprocessing sources for analyzer.

@Szelethus @NoQ There's this (fairly vintage) test
https://github.com/llvm/llvm-project/blob/master/clang/test/Analysis/misc-ps.m#L6
that checks specifically for the __clang_analyzer__ macro being set when cc1 is run directly.

#ifndef __clang_analyzer__
#error __clang_analyzer__ not defined
#endif

It's not obvious to me why though.

Sep 23 2019, 3:58 PM
jkorous created D67934: [static-analyzer] Remove --analyze-auto.
Sep 23 2019, 2:29 PM · Restricted Project
jkorous updated the diff for D67742: Add VFS support for sanitizers' blacklist.
Sep 23 2019, 1:17 PM · Restricted Project
jkorous changed the visibility for D67742: Add VFS support for sanitizers' blacklist.
Sep 23 2019, 1:17 PM · Restricted Project

Sep 20 2019

jkorous changed the visibility for D67742: Add VFS support for sanitizers' blacklist.
Sep 20 2019, 4:19 PM · Restricted Project
jkorous planned changes to D67742: Add VFS support for sanitizers' blacklist.
Sep 20 2019, 4:08 PM · Restricted Project
jkorous updated the diff for D67742: Add VFS support for sanitizers' blacklist.

The test was incorrect.

Sep 20 2019, 4:04 PM · Restricted Project
jkorous added a comment to D67742: Add VFS support for sanitizers' blacklist.

I took a look at SanitizerSpecialCaseList and I'm now thinking it might not be necessary to plumb VFS there. It's derived from llvm::SpecialCaseList whose sole interaction with filesystem is that it has couple named constructors that read a file and init an instance with its content.
It feels like dealing with paths and files is actually out of scope for SpecialCaseList and the natural interface is probably just a buffer.

Sep 20 2019, 3:49 PM · Restricted Project
jkorous updated the diff for D67742: Add VFS support for sanitizers' blacklist.

Added happy-path test.

Sep 20 2019, 3:10 PM · Restricted Project
jkorous added a comment to D67742: Add VFS support for sanitizers' blacklist.

I completely forgot about error handling which would be tricky in current place where I devirtualize files. We discussed offline and seems like it will be better to use VFS in SanitizerBlacklist anyway.

Sep 20 2019, 3:10 PM · Restricted Project
jkorous updated the diff for D67742: Add VFS support for sanitizers' blacklist.

We discussed offline and agreed that we don't need to use overlay in driver at all. I simplified the patch.

Sep 20 2019, 2:02 PM · Restricted Project
jkorous updated the diff for D66854: [index-while-building] PathIndexer.

Addressed the comments and tried to simplify things by splitting into multiple smaller classes.

Sep 20 2019, 11:46 AM
jkorous added inline comments to D66854: [index-while-building] PathIndexer.
Sep 20 2019, 11:37 AM

Sep 18 2019

jkorous added a reviewer for D67742: Add VFS support for sanitizers' blacklist: JDevlieghere.
Sep 18 2019, 5:34 PM · Restricted Project
jkorous created D67742: Add VFS support for sanitizers' blacklist.
Sep 18 2019, 5:31 PM · Restricted Project

Sep 17 2019

jkorous created D67682: [WIP] Add support for preprocessing sources for analyzer.
Sep 17 2019, 3:34 PM
jkorous committed rG1b87364f511a: [clang-scan-deps] Add verbose mode (authored by jkorous).
[clang-scan-deps] Add verbose mode
Sep 17 2019, 12:45 PM
jkorous committed rL372174: [clang-scan-deps] Add verbose mode.
[clang-scan-deps] Add verbose mode
Sep 17 2019, 12:45 PM
jkorous closed D67522: [clang-scan-deps] Verbose mode.
Sep 17 2019, 12:45 PM · Restricted Project
jkorous added inline comments to D67668: [ADT] Add StringMap::insert_or_assign.
Sep 17 2019, 10:45 AM · Restricted Project
jkorous accepted D67584: [Support] Replace function with function_ref in writeFileAtomically. NFC.

Good point! Thanks.

Sep 17 2019, 10:43 AM · Restricted Project